D10663: Remove a partially copied file if copyjob was cancelled in the middle of file copying

ngraham added a comment. Restricted Application added a subscriber: kde-frameworks-devel. You're right, the destination file was indeed silently corrupted in the "before" case. Yikes, that's bad. Really, both options are bad. I can see now that your patch doesn't actually regress

KDE CI: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.10 - Build # 47 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20SUSEQt5.10/47/ Project: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.10 Date of build: Fri, 11 May 2018 23:13:02 + Build duration: 2 min 38 sec and counting JUnit

D12831: Don't automatically set the default icons for each style

This revision was automatically updated to reflect the committed changes. Closed by commit R236:f213aa037f65: Dont automatically set the default icons for each style (authored by ngraham). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE

D12831: Don't automatically set the default icons for each style

cfeck accepted this revision. cfeck added a comment. This revision is now accepted and ready to land. Somehow I didn't notice you added those, but I have seen rejections to this, so please commit this revert. REPOSITORY R236 KWidgetsAddons BRANCH no-more-mandatory-icons (branched from

D12508: Make KMessageWidget match Kirigami inlineMessage's style

ngraham added a comment. Submitted D12831: Don't automatically set the default icons for each style to correct the issues. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D12508 To: ngraham, hein, #plasma, #vdg, cfeck Cc:

D12831: Don't automatically set the default icons for each style

ngraham edited the test plan for this revision. ngraham added a reviewer: cullmann. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D12831 To: ngraham, cullmann Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12831: Don't automatically set the default icons for each style

ngraham created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY When re-doing the visual style of the `KMessageWidget`, I inappropriately added a call

Re: kfilemetadata compile failure

On Thu, Apr 26, 2018 at 08:31:46AM +0200, Kevin Funk wrote: > On Wednesday, 25 April 2018 14:34:58 CEST Jonathan Riddell wrote: > > kfilemetadata does not compile in KDE neon from git master currently > > > > /workspace/build/src/extractors/ffmpegextractor.cpp:97:15: error: > >

D12820: Add KWayland virtual desktop protocol

romangg added a comment. The file org_kde_plasma_virtual_desktop.xml should be renamed to virtual-desktops.xml or plasma-virtual-desktops.xml to have a similar name format as the other protocol files we have. Also I would in general prefer to just call it "VirtualDesktop..." instaed of

D10702: Always use a job to delete files to avoid freezing process waiting on IO

meven added a comment. Restricted Application added a subscriber: kde-frameworks-devel. In D10702#242143 , @dfaure wrote: > s/thread/process/. It's not about threads it's about two processes: the (GUI) application, and the kioslave. > > But

D12820: Add KWayland virtual desktop protocol

mart added a comment. An important part the review should adress is how compatible the current api is to the current KWin architecture: the virtualdesktopmamagement interface is made to correspond pretty much to the new virtualDesktop class, tough both Workspace and AbstractClient still

D12820: Add KWayland virtual desktop protocol

mart added a comment. A part i'm not sure is the amount of behavior and consistency checks in the server part: right now it renumbers the virtual desktops in function of the grid and tries to keep always one desktop active. should this be done (also) in the kwayland protocol server part

D12820: Add KWayland virtual desktop protocol

mart added a comment. Only difference is the plasmawindow part api to have just the ids for consistence (always easy to get to the objects anyways) REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D12820 To: mart, #kwin, #plasma, graesslin, hein Cc:

D12820: Add KWayland virtual desktop protocol

mart retitled this revision from "virtual diland Virtual desktop protocol" to "Add KWayland virtual desktop protocol". mart added reviewers: graesslin, hein. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D12820 To: mart, #kwin, #plasma, graesslin, hein Cc:

D12820: virtual diland Virtual desktop protocol

mart created this revision. mart added reviewers: KWin, Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY Implement the virtual desktop protocol discussed in