D12689: Lua: updated for Lua5.3

dhaumann added a comment. Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. @jpoelen Could you have a look at https://bugs.kde.org/show_bug.cgi?id=394184 ? It seems we have a regression? REPOSITORY R216 Syntax Highlighting REVISION DETAIL

D12320: [RFC] add ability to read embedded cover files

astippich added a comment. @anthonyfieroni The preview is actually working perfectly fine, my configuration was wrong. I swear I checked it before :) sorry for the noise REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12320 To: astippich, mgallien,

D12320: [RFC] add ability to read embedded cover files

astippich added a comment. In D12320#260789 , @anthonyfieroni wrote: > In D12320#260768 , @astippich wrote: > > > Unfortunately, found it only after I wrote all that myself :/ > > > Sorry i

D12320: [RFC] add ability to read embedded cover files

astippich updated this revision to Diff 34012. astippich added a comment. - add an AllImages flag - add simple documentation REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12320?vs=33955=34012 BRANCH cover_read REVISION DETAIL

D12320: [RFC] add ability to read embedded cover files

mgallien added a comment. I am away from keyboard. Can we move forward ? Does it make sense to aim for having only one copy of this code and makes the kio code depends on KFileMetaData ? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12320 To: astippich,

D12831: Don't automatically set the default icons for each style

dhaumann added a comment. Thanks! REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D12831 To: ngraham, cullmann, cfeck Cc: dhaumann, cfeck, kde-frameworks-devel, michaelh, ngraham, bruns