KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 263 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/263/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Fri, 18 May 2018 03:40:30 + Build duration: 5 min 47 sec and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 18 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/18/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Fri, 18 May 2018 03:40:30 + Build duration: 4 min 11 sec and counting JUnit Tests

D11282: less expensive findByUrl in KCoreDirListerCache

bruns added inline comments. INLINE COMMENTS > mwolff wrote in kcoredirlister.cpp:2532 > this can be slow, see above To make this more efficient, a little bit of reshuffling is needed IMHO: 1. Move the filter implementation from `KDL::Private::addNewItem(...)` to

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.9 - Build # 16 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.9/16/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.9 Date of build: Thu, 17 May 2018 21:16:28 + Build duration: 17 min and counting JUnit Tests Name:

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.10 - Build # 45 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/45/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.10 Date of build: Thu, 17 May 2018 21:16:28 + Build duration: 17 min and counting JUnit Tests Name:

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 - Build # 7 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.10/7/ Project: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 Date of build: Thu, 17 May 2018 21:16:28 + Build duration: 12 min and counting JUnit Tests

D12156: implement reading of rating tag

astippich added a comment. any comments on the previous discussion? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12156 To: astippich, mgallien, michaelh Cc: kde-frameworks-devel, #baloo, bruns, ashaposhnikov, michaelh, astippich, spoorun, ngraham

D12156: implement reading of rating tag

astippich updated this revision to Diff 34398. astippich added a comment. Restricted Application edited subscribers, added: Baloo, kde-frameworks-devel; removed: Frameworks. - rebase on master - implement rating tag for m4a REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D12950: add test which checks the property types

astippich created this revision. astippich added reviewers: mgallien, bruns. Restricted Application added projects: Frameworks, Baloo. Restricted Application added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Check the type of the

D12932: handle string lists as input

This revision was automatically updated to reflect the committed changes. Closed by commit R293:03ab297f2512: handle string lists as input (authored by astippich). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12932?vs=34323=34395 REVISION DETAIL

D12820: Add KWayland virtual desktop protocol

zzag added inline comments. INLINE COMMENTS > plasmavirtualdesktop_interface.cpp:36 > + > +class PlasmaVirtualDesktopInterface::Private > +{ class Q_DECL_HIDDEN PlasmaVirtualDesktopInterface::Private Same for the server part. REPOSITORY R127 KWayland REVISION DETAIL

D12578: fix some issues reported by clazy

This revision was automatically updated to reflect the committed changes. Closed by commit R293:f887468b172a: fix some issues reported by clazy (authored by mgallien). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12578?vs=34389=34390 REVISION DETAIL

D12578: fix some issues reported by clazy

bruns accepted this revision. bruns added a comment. This revision is now accepted and ready to land. No, worries, just wanted to make shure this does not stall 1 meter to the finish line ... REPOSITORY R293 Baloo BRANCH arcpatch-D12578 REVISION DETAIL

D12578: fix some issues reported by clazy

mgallien marked an inline comment as done. mgallien added a comment. @bruns Thanks for the review and sorry for my slowness. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12578 To: mgallien, #baloo, #frameworks, bruns Cc: kde-frameworks-devel, bruns, ashaposhnikov,

D12578: fix some issues reported by clazy

mgallien updated this revision to Diff 34389. mgallien added a comment. - fix one more issue REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12578?vs=34223=34389 BRANCH arcpatch-D12578 REVISION DETAIL https://phabricator.kde.org/D12578 AFFECTED FILES

D12578: fix some issues reported by clazy

bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. One change pending, then you are good to go ... REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12578 To: mgallien, #baloo, #frameworks, bruns Cc:

D11282: less expensive findByUrl in KCoreDirListerCache

bruns added inline comments. INLINE COMMENTS > dfaure wrote in kcoredirlister.cpp:852 > That was the case already hmm but not in my version of kio. It looks like > this patch is on top of other patches. D10742 - this makes it even harder to review ...

D11282: less expensive findByUrl in KCoreDirListerCache

bruns added a comment. Restricted Application added a subscriber: kde-frameworks-devel. @jtamate - can you use `arc --diff` next time you create a revision, instead of using the web upload? Not using arc results in phabricator being unable to show the context ("Context not available"),

D12820: Add KWayland virtual desktop protocol

mart added inline comments. INLINE COMMENTS > graesslin wrote in org_kde_plasma_virtual_desktop.xml:45 > A possibility could be a sibling concept. Every desktop could have a > reference to the desktop to the left/top/right/bottom. How you would envision different virtual desktops per output?

D12820: Add KWayland virtual desktop protocol

graesslin added inline comments. INLINE COMMENTS > mart wrote in org_kde_plasma_virtual_desktop.xml:45 > Ok, so no layout information at all neither in the manager nor in the single > virtual desktops? > I kindof like that as makes things a lot simpler. Tough in this case if the > concept of

D12820: Add KWayland virtual desktop protocol

mart added inline comments. INLINE COMMENTS > graesslin wrote in org_kde_plasma_virtual_desktop.xml:45 > I would prefer to not have any layout in the protocol. Setting a layout makes > it impossible to have different virtual desktop per output. Ok, so no layout information at all neither in

D12945: kcoredirlister lstItems benchmark

jtamate added a dependent revision: D11282: less expensive findByUrl in KCoreDirListerCache. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12945 To: jtamate, dfaure, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D11282: less expensive findByUrl in KCoreDirListerCache

jtamate added a dependency: D12945: kcoredirlister lstItems benchmark. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11282 To: jtamate, #frameworks, dfaure Cc: mwolff, michaelh, ngraham, bruns

D12945: kcoredirlister lstItems benchmark

jtamate created this revision. jtamate added reviewers: dfaure, Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. jtamate requested review of this revision. REVISION SUMMARY Decide which data structure is best for

D12919: [Plotter] Don't render if m_node is null

This revision was automatically updated to reflect the committed changes. Closed by commit R296:9d7c4927e506: [Plotter] Dont render if m_node is null (authored by broulik). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12919?vs=34261=34356 REVISION

D12919: [Plotter] Don't render if m_node is null

davidedmundson accepted this revision. davidedmundson added a comment. I think it makes sense in the following situation: a remove window event is queued a render event is queued we'll have set node to null, and called disconnect, but we'll still be processing pending events.

KDE CI: Frameworks knotifications kf5-qt5 WindowsMSVCQt5.10 - Build # 16 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20knotifications%20kf5-qt5%20WindowsMSVCQt5.10/16/ Project: Frameworks knotifications kf5-qt5 WindowsMSVCQt5.10 Date of build: Thu, 17 May 2018 07:58:25 + Build duration: 19 min and counting