KDE CI: Frameworks knewstuff kf5-qt5 FreeBSDQt5.10 - Build # 6 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20knewstuff%20kf5-qt5%20FreeBSDQt5.10/6/
 Project:
Frameworks knewstuff kf5-qt5 FreeBSDQt5.10
 Date of build:
Sat, 19 May 2018 04:07:40 +
 Build duration:
52 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.kmoretoolstest

D12971: Add entities CIFS, NFS, Samba, SMB to general.entities

[Luigi Toscano]

ltoscano accepted this revision.
ltoscano added a comment.
This revision is now accepted and ready to land.


  Thanks!

REVISION DETAIL
  https://phabricator.kde.org/D12971

To: lueck, #documentation, ltoscano
Cc: kde-frameworks-devel, kde-doc-english, michaelh, ngraham, bruns, skadinna

D12971: Add entities CIFS, NFS, Samba, SMB to general.entities

[Burkhard Lück]

lueck marked 3 inline comments as done.

REVISION DETAIL
  https://phabricator.kde.org/D12971

To: lueck, #documentation, ltoscano
Cc: kde-frameworks-devel, kde-doc-english, michaelh, ngraham, bruns, skadinna

D12971: Add entities CIFS, NFS, Samba, SMB to general.entities

[Burkhard Lück]

lueck updated this revision to Diff 34452.
lueck added a comment.


  fix typos spotted by Luigi, thanks

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12971?vs=34450=34452

REVISION DETAIL
  https://phabricator.kde.org/D12971

AFFECTED FILES
  src/customization/entities/general.entities

To: lueck, #documentation, ltoscano
Cc: kde-frameworks-devel, kde-doc-english, michaelh, ngraham, bruns, skadinna

D12971: Add entities CIFS, NFS, Samba, SMB to general.entities

[Luigi Toscano]

ltoscano requested changes to this revision.
ltoscano added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> general.entities:132
>  Choqok">
> +CIFS"<
>  CMake'>

last character should be ">"

> general.entities:409
>  MusiXTeX">
> +NFS"
>  Okteta">

missing ">" at the end of line

> general.entities:434
>  RSIBreak">
> +Samba"
> +SMB">

missing ">" at the end of line

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D12971

To: lueck, #documentation, ltoscano
Cc: kde-frameworks-devel, kde-doc-english, michaelh, ngraham, bruns, skadinna

D12971: Add entities CIFS, NFS, Samba, SMB to general.entities

[Burkhard Lück]

lueck added a reviewer: ltoscano.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D12971

To: lueck, #documentation, ltoscano
Cc: kde-frameworks-devel, kde-doc-english, michaelh, ngraham, bruns, skadinna

D12971: Add entities CIFS, NFS, Samba, SMB to general.entities

[Burkhard Lück]

lueck created this revision.
lueck added a reviewer: Documentation.
Restricted Application added projects: Frameworks, Documentation.
Restricted Application added subscribers: kde-doc-english, kde-frameworks-devel.
lueck requested review of this revision.

REVISION SUMMARY
  hits in trunk/l10n-kf5/documentation:
  
  16 x CIFS
  46 x NFS
  61 x Samba
  44 x SMB

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D12971

AFFECTED FILES
  src/customization/entities/general.entities

To: lueck, #documentation
Cc: kde-frameworks-devel, kde-doc-english, michaelh, ngraham, bruns, skadinna

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 160 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/160/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 18 May 2018 18:58:27 +
 Build duration:
16 min and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)26%
(3561/13468)19%
(1979/10659)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(609/1140)28%
(421/1492)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/470)0%
(0/263)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(253/2246)7%
(102/1496)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/525)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1442/3532)28%
(827/2965)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)41%
(671/1621)28%
(318/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)27%
(555/2020)17%
(306/1781)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1179)0%
(0/1058)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%
   

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 - Build # 12 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.10/12/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10
 Date of build:
Fri, 18 May 2018 18:58:27 +
 Build duration:
5 min 54 sec and counting
   JUnit Tests
  Name: (root) Failed: 13 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.coronatestFailed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-dialogstatetestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-framesvgtestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-pluginloadertestFailed: TestSuite.plasma-sortfiltermodeltestFailed: TestSuite.plasma-storagetestFailed: TestSuite.plasma-themetest

D12959: [Breeze Plasma Theme] Fix kleopatra icon to use color stylesheet

[Friedrich W . H . Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:b6a6e95afce7: [Breeze Plasma Theme] Fix kleopatra icon to 
use color stylesheet (authored by kossebau).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12959?vs=34422=34447

REVISION DETAIL
  https://phabricator.kde.org/D12959

AFFECTED FILES
  src/desktoptheme/breeze/icons/kleopatra.svgz

To: kossebau, #plasma, aheinecke
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D11810: Add Falkon, Kirigami, macOS, Solid, USB, Wayland, X11, SDDM to general entities

[Burkhard Lück]

This revision was automatically updated to reflect the committed changes.
Closed by commit R238:4b9ee198b95b: Add Falkon, Kirigami, macOS, Solid, USB, 
Wayland, X11, SDDM to general entities (authored by lueck).
Restricted Application edited subscribers, added: kde-doc-english, 
kde-frameworks-devel; removed: Frameworks.

REPOSITORY
  R238 KDocTools

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11810?vs=30968=3

REVISION DETAIL
  https://phabricator.kde.org/D11810

AFFECTED FILES
  src/customization/entities/general.entities

To: lueck, ltoscano, #documentation
Cc: kde-frameworks-devel, kde-doc-english, michaelh, ngraham, bruns, skadinna, 
#frameworks

D11810: Add Falkon, Kirigami, macOS, Solid, USB, Wayland, X11, SDDM to general entities

[Luigi Toscano]

ltoscano accepted this revision as: ltoscano.
ltoscano added a comment.
This revision is now accepted and ready to land.


  Sorry for the delay!

REVISION DETAIL
  https://phabricator.kde.org/D11810

To: lueck, ltoscano, #documentation
Cc: #frameworks, michaelh, ngraham, bruns, skadinna

D12820: Add KWayland virtual desktop protocol

[Martin Flöser]

graesslin added inline comments.

INLINE COMMENTS

> mart wrote in org_kde_plasma_virtual_desktop.xml:45
> How you would envision different virtual desktops per output?
> to me is a bit of a weird concept, as an output is an actual desktop, not 
> virtual?

Have a look at i3. Btw it's a really often requested feature.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D12820

To: mart, #kwin, #plasma, graesslin, hein
Cc: zzag, bshah, romangg, kde-frameworks-devel, michaelh, ngraham, bruns

D12959: [Breeze Plasma Theme] Fix kleopatra icon to use color stylesheet

[Andre Heinecke]

aheinecke accepted this revision.
aheinecke added a comment.
This revision is now accepted and ready to land.


  Works in Ubuntu 18.04 with default breeze theme: F5855745: 
kleo-plasma-tray.png 
  
  Thanks!

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fixkleopatrabreezeicon

REVISION DETAIL
  https://phabricator.kde.org/D12959

To: kossebau, #plasma, aheinecke
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12959: [Breeze Plasma Theme] Fix kleopatra icon to use color stylesheet

[Friedrich W . H . Kossebau]

kossebau created this revision.
kossebau added reviewers: Plasma, aheinecke.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Had hardcoded colors before.
  
  BUG: 394400

TEST PLAN
  Looks properly in cuttlefish in black/white mode, both inverted &
  non-inverted.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fixkleopatrabreezeicon

REVISION DETAIL
  https://phabricator.kde.org/D12959

AFFECTED FILES
  src/desktoptheme/breeze/icons/kleopatra.svgz

To: kossebau, #plasma, aheinecke
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12337: Give the file dialogs a "Sort by" menu button on the toolbar

[Henrik Fehlauer]

rkflx added a comment.


  Let's commit this on a separate branch, as getting micro-approvals from 
#Frameworks  does not work that 
well. Then we can implement (in the form of reviewed Diffs as before) what we 
already discussed in a bigger setting, e.g.
  
  - rework the view modes
  - set new defaults
  - put the New folder button on the bottom
  - decide on D12647: Move the inline preview button into the menu 

  - figure out D12218: Remove Reload button from the file dialogs' toolbar 

  - figure out Up
  - hopefully abandon D12333: Put the open/save dialog's toolbar above all 
other widgets, like Dolphin does  for good
  
  …and finally present the final outcome to a wider audience for approval 
before merging. This way can we make progress as time allows, without shipping 
incomplete features or get bogged down with dependencies. Note I'm not 
proposing to wait for //everything// you put into T8552 
.
  
  (Sorry for not being able to help more currently, but I first wanna reduce my 
Gwenview and Spectacle backlogs…)

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D12337

REVISION DETAIL
  https://phabricator.kde.org/D12337

To: ngraham, #frameworks, #dolphin, #vdg, rkflx
Cc: kde-frameworks-devel, andreaska, markg, broulik, anemeth, michaelh, 
ngraham, bruns

D12955: [KCModuleQml] Ignore disabled controls when tabbing

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R295:6fb265469e57: [KCModuleQml] Ignore disabled controls when 
tabbing (authored by broulik).

REPOSITORY
  R295 KCMUtils

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12955?vs=34413=34414

REVISION DETAIL
  https://phabricator.kde.org/D12955

AFFECTED FILES
  src/kcmoduleqml.cpp

To: broulik, #plasma, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 113 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/113/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 18 May 2018 08:04:48 +
 Build duration:
15 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(294/443)66%
(294/443)53%
(31827/60030)38%
(18770/49372)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8702/9259)48%
(5404/11151)autotests.http100%
(9/9)100%
(9/9)99%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core84%
(100/119)84%
(100/119)58%
(8458/14499)50%
(4919/9808)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets78%
(31/40)78%
(31/40)49%
(3901/7917)33%
(1639/4966)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(521/1008)42%
(417/1004)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1333)55%
(648/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%
(7/11)64%

D12955: [KCModuleQml] Ignore disabled controls when tabbing

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D12955

To: broulik, #plasma, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12955: [KCModuleQml] Ignore disabled controls when tabbing

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, mart.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Whether an item is enabled or not doesn't seem to affect its `focusPolicy` or 
position in the focus chain.
  Explicitly ignore disabled controls and move to the next.
  Fixes being unable to tab out of a QML KCM when the "Help" button (typically 
next control after the view in System Settings) is disabled

TEST PLAN
  Successfully tabbed in and ouf of desktop theme KCM in both directions and 
never got stuck

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D12955

AFFECTED FILES
  src/kcmoduleqml.cpp

To: broulik, #plasma, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 112 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/112/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 18 May 2018 03:40:30 +
 Build duration:
4 hr 2 min and counting
   CONSOLE OUTPUT
  [...truncated 190.80 KB...][  2%] Built target docs-kcontrol5-useragent-index-cache-bz2Scanning dependencies of target KF5KIOCore_autogen[  2%] Built target docs-kcontrol5-webshortcuts-index-cache-bz2[  2%] Generating moc_predefs.hScanning dependencies of target protocoltojson_autogen[  3%] Automatic MOC for target KF5KIOCore[  3%] Automatic MOC for target protocoltojson[  3%] Built target protocoltojson_autogenScanning dependencies of target KF5KIONTLM_autogen[  3%] Automatic MOC for target KF5KIONTLM[  3%] Built target KF5KIONTLM_autogenScanning dependencies of target kcookiejar5_autogen[  3%] Automatic MOC for target kcookiejar5[  3%] Built target kcookiejar5_autogenScanning dependencies of target kded_kcookiejar_autogen[  3%] Automatic MOC for target kded_kcookiejar[  3%] Built target kded_kcookiejar_autogenScanning dependencies of target ktelnetservice5_autogen[  3%] Automatic MOC for target ktelnetservice5[  3%] Built target ktelnetservice5_autogenScanning dependencies of target lockingtest_autogen[  3%] Automatic MOC for target lockingtest[  3%] Built target lockingtest_autogenScanning dependencies of target kpac_dhcp_helper_autogen[  3%] Automatic MOC for target kpac_dhcp_helper[  3%] Built target kpac_dhcp_helper_autogenScanning dependencies of target httpheaderdispositiontest_autogen[  4%] Automatic MOC for target httpheaderdispositiontest[  4%] Built target httpheaderdispositiontest_autogenScanning dependencies of target httpheadertokenizetest_autogen[  4%] Automatic MOC for target httpheadertokenizetest[  4%] Built target httpheadertokenizetest_autogenScanning dependencies of target httpfiltertest_autogen[  4%] Automatic MOC for target httpfiltertest[  4%] Built target httpfiltertest_autogenScanning dependencies of target protocoltojson[  4%] Building CXX object src/protocoltojson/CMakeFiles/protocoltojson.dir/main.cpp.o[  4%] Built target KF5KIOCore_autogenScanning dependencies of target KF5KIONTLM[  4%] Building CXX object src/kntlm/CMakeFiles/KF5KIONTLM.dir/kntlm.cpp.o[  5%] Building CXX object src/kntlm/CMakeFiles/KF5KIONTLM.dir/des.cpp.o[  5%] Building CXX object src/protocoltojson/CMakeFiles/protocoltojson.dir/protocoltojson_autogen/mocs_compilation.cpp.o[  6%] Linking CXX executable ../../bin/protocoltojson[  6%] Building CXX object src/kntlm/CMakeFiles/KF5KIONTLM.dir/KF5KIONTLM_autogen/mocs_compilation.cpp.o[  6%] Linking CXX shared library ../../bin/libKF5KIONTLM.so[  6%] Built target protocoltojson[  6%] Generating org.kde.KCookieServer.xml[  6%] Generating kcookieserverinterface.cpp, kcookieserverinterface.h[  6%] Generating kcookieserverinterface.mocScanning dependencies of target kcookiejar5[  6%] Built target KF5KIONTLM[  7%] Building CXX object src/ioslaves/http/kcookiejar/CMakeFiles/kcookiejar5.dir/kcookieserverinterface.cpp.o[  7%] Generating kcookieserveradaptor.cpp, kcookieserveradaptor.h[  7%] Generating kcookieserveradaptor.mocScanning dependencies of target kded_kcookiejar[  7%] Building CXX object src/ioslaves/http/kcookiejar/CMakeFiles/kded_kcookiejar.dir/kcookiejar.cpp.o[  7%] Building CXX object src/ioslaves/http/kcookiejar/CMakeFiles/kcookiejar5.dir/main.cpp.o[  7%] Building CXX object src/ioslaves/http/kcookiejar/CMakeFiles/kded_kcookiejar.dir/kcookieserver.cpp.o[  7%] Building CXX object src/ioslaves/http/kcookiejar/CMakeFiles/kcookiejar5.dir/kcookiejar5_autogen/mocs_compilation.cpp.o[  7%] Linking CXX executable ../../../../bin/kcookiejar5[  7%] Built target kcookiejar5Scanning dependencies of target ktelnetservice5[  7%] Building CXX object src/ioslaves/telnet/CMakeFiles/ktelnetservice5.dir/ktelnetservice.cpp.o[  7%] Building CXX object src/ioslaves/http/kcookiejar/CMakeFiles/kded_kcookiejar.dir/kcookiewin.cpp.o[  7%] Building CXX object src/ioslaves/telnet/CMakeFiles/ktelnetservice5.dir/ktelnetservice5_autogen/mocs_compilation.cpp.o[  7%] Linking CXX executable ../../../bin/ktelnetservice5[  7%] Built target ktelnetservice5Scanning dependencies of target lockingtest[  7%] Building CXX object src/ioslaves/trash/tests/CMakeFiles/lockingtest.dir/lockingtest.cpp.o[  8%] Building CXX object src/ioslaves/trash/tests/CMakeFiles/lockingtest.dir/__/kinterprocesslock.cpp.o[  9%] Building CXX object src/ioslaves/http/kcookiejar/CMakeFiles/kded_kcookiejar.dir/kcookieserveradaptor.cpp.o[  9%] Building CXX object src/ioslaves/trash/tests/CMakeFiles/lockingtest.dir/lockingtest_autogen/mocs_compilation.cpp.o[  9%] Linking CXX executable ../../../../bin/lockingtest[  9%] Built target lockingtestScanning dependencies of target kpac_dhcp_helper[  9%] Building C object src/kpac/CMakeFiles/kpac_dhcp_helper.dir/kpac_dhcp_helper.c.o[ 10%] Building CXX object