D12388: Output device color curves correction

[Roman Gilg]

romangg marked 2 inline comments as done.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D12388

To: romangg, #frameworks, davidedmundson, graesslin
Cc: kde-frameworks-devel, graesslin, davidedmundson, zzag, cfeck, michaelh, 
ngraham, bruns

D12388: Output device color curves correction

[Roman Gilg]

romangg updated this revision to Diff 34770.
romangg added a comment.


  - Send color curves only for version 2 and above

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12388?vs=33564=34770

BRANCH
  outputColorCorrectionCurvesOnly

REVISION DETAIL
  https://phabricator.kde.org/D12388

AFFECTED FILES
  autotests/client/test_wayland_outputdevice.cpp
  autotests/client/test_wayland_outputmanagement.cpp
  src/client/outputconfiguration.cpp
  src/client/outputconfiguration.h
  src/client/outputdevice.cpp
  src/client/outputdevice.h
  src/client/protocols/output-management.xml
  src/client/protocols/outputdevice.xml
  src/client/registry.cpp
  src/server/outputchangeset.cpp
  src/server/outputchangeset.h
  src/server/outputchangeset_p.h
  src/server/outputconfiguration_interface.cpp
  src/server/outputdevice_interface.cpp
  src/server/outputdevice_interface.h
  src/server/outputmanagement_interface.cpp

To: romangg, #frameworks, davidedmundson, graesslin
Cc: kde-frameworks-devel, graesslin, davidedmundson, zzag, cfeck, michaelh, 
ngraham, bruns

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 - Build # 9 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.10/9/
 Project:
Frameworks kwayland kf5-qt5 FreeBSDQt5.10
 Date of build:
Thu, 24 May 2018 04:37:45 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: (root) Failed: 13 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kwayland-testCompositorFailed: TestSuite.kwayland-testDataDeviceFailed: TestSuite.kwayland-testDataSourceFailed: TestSuite.kwayland-testRegionFailed: TestSuite.kwayland-testRemoteAccessFailed: TestSuite.kwayland-testShmPoolFailed: TestSuite.kwayland-testSubCompositorFailed: TestSuite.kwayland-testSubSurfaceFailed: TestSuite.kwayland-testWaylandConnectionThreadFailed: TestSuite.kwayland-testWaylandRegistryFailed: TestSuite.kwayland-testWaylandServerDisplayFailed: TestSuite.kwayland-testWaylandShellFailed: TestSuite.kwayland-testWaylandSurface

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.9 - Build # 18 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.9/18/
 Project:
Frameworks kwayland kf5-qt5 SUSEQt5.9
 Date of build:
Thu, 24 May 2018 04:37:45 +
 Build duration:
9 min 9 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 43 test(s), Skipped: 0 test(s), Total: 44 test(s)Failed: TestSuite.kwayland-testRemoteAccess
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report57%
(4/7)90%
(225/251)90%
(225/251)84%
(24102/28746)52%
(11783/22722)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client98%
(40/41)98%
(40/41)98%
(11221/11503)49%
(7704/15593)autotests.server100%
(5/5)100%
(5/5)99%
(359/362)49%
(220/446)src.client97%
(69/71)97%
(69/71)84%
(5688/6743)65%
(1782/2752)src.server97%
(111/115)97%
(111/115)86%
(6834/7970)64%
(2077/3252)src.tools0%
(0/2)0%
(0/2)0%
(0/786)0%
(0/346)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/16)tests0%
(0/14)0%
(0/14)0%
(0/1262)0%
(0/317)

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.10 - Build # 47 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/47/
 Project:
Frameworks kwayland kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 24 May 2018 04:37:45 +
 Build duration:
8 min 56 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 43 test(s), Skipped: 0 test(s), Total: 44 test(s)Failed: TestSuite.kwayland-testRemoteAccess
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report57%
(4/7)90%
(225/251)90%
(225/251)84%
(24102/28746)52%
(11783/22722)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client98%
(40/41)98%
(40/41)98%
(11221/11503)49%
(7704/15593)autotests.server100%
(5/5)100%
(5/5)99%
(359/362)49%
(220/446)src.client97%
(69/71)97%
(69/71)84%
(5688/6743)65%
(1782/2752)src.server97%
(111/115)97%
(111/115)86%
(6834/7970)64%
(2077/3252)src.tools0%
(0/2)0%
(0/2)0%
(0/786)0%
(0/346)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/16)tests0%
(0/14)0%
(0/14)0%
(0/1262)0%
(0/317)

D13076: Increase org_kde_plasma_shell interface version

[Roman Gilg]

This revision was automatically updated to reflect the committed changes.
Closed by commit R127:f0363584861c: Increase org_kde_plasma_shell interface 
version (authored by romangg).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13076?vs=34745=34768

REVISION DETAIL
  https://phabricator.kde.org/D13076

AFFECTED FILES
  src/client/protocols/plasma-shell.xml

To: romangg, #plasma, sharvey, bshah
Cc: bshah, kde-frameworks-devel, michaelh, ngraham, bruns

D13076: Increase org_kde_plasma_shell interface version

[Bhushan Shah]

bshah accepted this revision.
bshah added a comment.
This revision is now accepted and ready to land.


  Works for me, (and makes sense). Thanks for debugging this @romangg

REPOSITORY
  R127 KWayland

BRANCH
  fixPlasmaShellVersion

REVISION DETAIL
  https://phabricator.kde.org/D13076

To: romangg, #plasma, sharvey, bshah
Cc: bshah, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 269 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/269/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 24 May 2018 03:30:05 +
 Build duration:
14 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiocore-ktcpsockettest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(294/443)66%
(294/443)53%
(31890/60032)38%
(18934/49394)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)95%
(8826/9260)50%
(5583/11153)autotests.http100%
(9/9)100%
(9/9)99%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core84%
(100/119)84%
(100/119)58%
(8400/14498)50%
(4898/9804)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets78%
(31/40)78%
(31/40)49%
(3917/7918)33%
(1655/4966)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(521/1008)42%
(417/1004)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1789/4339)35%
(1379/3995)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%
(7/11)64%
(7/11)51%
  

D13048: Move redundant logic in KIO::iconNameForUrl() into KFileItem::iconName()

[Nathaniel Graham]

ngraham abandoned this revision.
ngraham added a comment.


  Let's do this in a more sensible and better-performing way with D13082 
 and D13083 
.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13048

To: ngraham, #frameworks, broulik
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D13083: Respect custom directory icons in iconNameForURL()

[Nathaniel Graham]

ngraham edited the summary of this revision.
ngraham set the repository for this revision to R241 KIO.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13083

To: ngraham, #frameworks, apol, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13083: Respect custom directory icons in iconNameForURL()

[Nathaniel Graham]

ngraham added a dependency: D13082: Make iconFromDirectoryFile() and 
iconFromDesktopFile() public in KIOCore.

REVISION DETAIL
  https://phabricator.kde.org/D13083

To: ngraham, #frameworks, apol, broulik

D13082: Make iconFromDirectoryFile() and iconFromDesktopFile() public in KIOCore

[Nathaniel Graham]

ngraham added a dependent revision: D13083: Respect custom directory icons in 
iconNameForURL().

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13082

To: ngraham, #frameworks, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13083: Respect custom directory icons in iconNameForURL()

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Frameworks, apol, broulik.
ngraham requested review of this revision.

REVISION SUMMARY
  With `iconFromDirectoryFile()` a public function thanks to D13082 
, we can use it to get custom icons for 
folders without having to `stat` anything.

TEST PLAN
  - No test regressions
  - Adding a folder with a custom icon to the Places panel results in the new 
Places item getting the custom icon: F5864410: Places panel with inherited 
custom icon.png 

BRANCH
  custom-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D13083

AFFECTED FILES
  src/core/global.cpp

To: ngraham, #frameworks, apol, broulik

D12992: New elisa icon

[Diego Gangl]

januz added a comment.


  TBH I like the concept of the cassette icon more than the current 
implementation of it. What was good about about is that it had //personality//, 
which is a big deal since usually icons also double as logos. IMO a solid icon 
should be 1) Memorable and 2) Descriptive. Imagine both icons amongst these 
google search results 
 and 
consider which one would stand out, which one you would know it's elisa's. 
These icons are technically great, they are just not memorable.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D12992

To: lshoravi, #vdg, ngraham, #elisa
Cc: januz, astippich, mgallien, alex-l, andreask, kde-frameworks-devel, 
ssteffen, lcmscheid, nhuisman, ursjoss, mykolak, jussiv, michaelh, ognarb, 
ngraham, bruns, kmf

D13082: Make iconFromDirectoryFile() and iconFromDesktopFile() public in KIOCore

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Frameworks, apol.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This allows us to use them in KIO::iconNameForURL() to gain custom folder 
icon support without needing to `stat` anything.
  
  CCBUG: 356045

TEST PLAN
  - No visual regressions in Dolphin
  - No unit test regressions

REPOSITORY
  R241 KIO

BRANCH
  public-iconFromDesktopFile-and-iconFromDirectoryFile (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D13082

AFFECTED FILES
  src/core/global.cpp
  src/core/global.h
  src/core/kfileitem.cpp

To: ngraham, #frameworks, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 43 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/43/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 23 May 2018 20:18:54 +
 Build duration:
7 min 53 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report24%
(5/21)30%
(17/57)30%
(17/57)20%
(443/2175)21%
(264/1270)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(4/4)100%
(4/4)97%
(150/155)62%
(117/188)src100%
(8/8)100%
(8/8)68%
(205/303)47%
(111/237)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/142)0%
(0/94)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/57)0%
(0/32)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/188)0%
(0/78)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/34)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/16)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/81)0%
(0/40)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/56)0%
(0/36)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/90)src.plugins.phabricator.quick0%
(0/6)0%
(0/6)0%
(0/86)0%
(0/59)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/242)0%
(0/80)src.plugins.reviewboard.quick0%
(0/8)0%
(0/8)0%
(0/159)0%
(0/100)src.plugins.saveas100%
(1/1)100%
(1/1)58%
(31/53)63%
(30/48)src.plugins.telegram0%
(0/1)0%
(0/1)0%
(0/59)0%
(0/20)src.plugins.youtube0%
(0/5)0%
(0/5)0%
(0/122)0%
(0/44)src.quick100%
(2/2)100%
(2/2)100%
(9/9)100%

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 19 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/19/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 23 May 2018 20:18:54 +
 Build duration:
1 min 59 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.alternativesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report24%
(5/21)30%
(17/57)30%
(17/57)21%
(459/2175)22%
(277/1270)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(4/4)100%
(4/4)93%
(144/155)59%
(111/188)src100%
(8/8)100%
(8/8)75%
(227/303)55%
(130/237)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/142)0%
(0/94)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/57)0%
(0/32)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/188)0%
(0/78)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/34)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/16)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/81)0%
(0/40)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/56)0%
(0/36)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/90)src.plugins.phabricator.quick0%
(0/6)0%
(0/6)0%
(0/86)0%
(0/59)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/242)0%
(0/80)src.plugins.reviewboard.quick0%
(0/8)0%
(0/8)0%
(0/159)0%
(0/100)src.plugins.saveas100%
(1/1)100%
(1/1)58%
(31/53)63%
(30/48)src.plugins.telegram0%
(0/1)0%
(0/1)0%
(0/59)0%
(0/20)src.plugins.youtube0%
(0/5)0%
(0/5)0%
(0/122)0%
(0/44)src.quick100%
(2/2)100%
(2/2)100%
(9/9)100%
  

D12896: Add Telegram plugin

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R495:6f74cbb9659f: Add Telegram plugin (authored by 
nicolasfella).

REPOSITORY
  R495 Purpose Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12896?vs=34737=34750

REVISION DETAIL
  https://phabricator.kde.org/D12896

AFFECTED FILES
  src/plugins/CMakeLists.txt
  src/plugins/telegram/CMakeLists.txt
  src/plugins/telegram/Messages.sh
  src/plugins/telegram/debug.h
  src/plugins/telegram/telegramplugin.cpp
  src/plugins/telegram/telegramplugin.json

To: nicolasfella, apol
Cc: ngraham, kde-frameworks-devel, apol, michaelh, bruns

D12896: Add Telegram plugin

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Okay, let's land this and I'll try to fix it myself.

REPOSITORY
  R495 Purpose Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12896

To: nicolasfella, apol
Cc: ngraham, kde-frameworks-devel, apol, michaelh, bruns

D13076: Increase org_kde_plasma_shell interface version

[Roman Gilg]

romangg created this revision.
romangg added reviewers: Plasma, sharvey.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
romangg requested review of this revision.

REVISION SUMMARY
  It was forgotten in 10b00a219e 
 to 
increase org_kde_plasma_shell version
  in the xml file, which leads to broken implementation.

REPOSITORY
  R127 KWayland

BRANCH
  fixPlasmaShellVersion

REVISION DETAIL
  https://phabricator.kde.org/D13076

AFFECTED FILES
  src/client/protocols/plasma-shell.xml

To: romangg, #plasma, sharvey
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12896: Add Telegram plugin

[Nicolas Fella]

nicolasfella updated this revision to Diff 34737.
nicolasfella added a comment.


  :  - Hardcode commands and try until success

REPOSITORY
  R495 Purpose Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12896?vs=34213=34737

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12896

AFFECTED FILES
  src/plugins/CMakeLists.txt
  src/plugins/telegram/CMakeLists.txt
  src/plugins/telegram/Messages.sh
  src/plugins/telegram/debug.h
  src/plugins/telegram/telegramplugin.cpp
  src/plugins/telegram/telegramplugin.json

To: nicolasfella, apol
Cc: ngraham, kde-frameworks-devel, apol, michaelh, bruns

D12320: [RFC] add ability to read embedded cover files

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> embeddedimagedata.cpp:67
> +
> +if (types & EmbeddedImageData::FrontCover || types & 
> EmbeddedImageData::AllImages) {
> +imageData.insert(EmbeddedImageData::FrontCover, 
> d->getFrontCover(fileUrl,mimeType));

If you follow the suggestion above, you can drop the second or'ed statement.

> embeddedimagedata.cpp:68
> +if (types & EmbeddedImageData::FrontCover || types & 
> EmbeddedImageData::AllImages) {
> +imageData.insert(EmbeddedImageData::FrontCover, 
> d->getFrontCover(fileUrl,mimeType));
> +}

missing space after `,`
you can also directly pass in fileMimeType.name()

> embeddedimagedata.h:45
> +AllImages = 0x01,
> +FrontCover = 0x02
> +};

I would prefer `FrontCover = 0x1`, `AllImages = FrontCover`, where AllImages is 
extended later when other types are supported.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D12320

To: astippich, mgallien, michaelh, bruns
Cc: anthonyfieroni, kde-frameworks-devel, #baloo, bruns, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham

D12896: Add Telegram plugin

[Nicolas Fella]

nicolasfella added a comment.


  I played around a bit and it turns out more difficult than expected.
  
  - telegram-desktop-bin from AUR has telegramdesktop.desktop whereas the 
Flatpak version has org.telegram.desktop.desktop, so we would need to look for 
at least those desktop files
  - the flatpak command needs @@ around the url, the AUR version not
  - the flatpak command contains "--" which hinders the appending of the 
-sendpath parameter
  
  This makes parsing the desktop file and building the correct command utterly 
complex and when we know whether its flatpak or not we know the overall command
  
  My much simpler suggestion would be hardcoding the two commands and try them 
all until we succeed.
  Those would be
  telegram-desktop $URL (regular package)
  /usr/bin/flatpak run --file-forwarding org.telegram.desktop -sendpath @@ $URL 
@@ (flatpak)
  
  More commands (e.g. for Snap) could be added, making it more maintainable 
than complex and error-prone parsing (which would also rely on case-handling 
and assumptions)

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D12896

To: nicolasfella, apol
Cc: ngraham, kde-frameworks-devel, apol, michaelh, bruns

D12992: New elisa icon

[Nathaniel Graham]

ngraham added a comment.


  Without meaning to offend whoever made the cassette icon, I think any variant 
of the one proposed here is hugely better. If I recall, I wasn't overly fond of 
the cassette icon when it was first proposed and predicted that it would not be 
popular. Sure enough, that's exactly what happened, and this new one was borne 
of a Reddit thread that was full of people complaining about the cassette icon.
  
  @lshoravi here's an idea for a slight modification to the original: keep the 
whole letter-E-wrapped-around-a-musical-note thing, but change the size of the 
note and the letter such that the bottom rounded part of the note isn't 
overlapping any part of the [E]. I really liked that original design, but the 
only thing I thought was slightly problematic was how so much of the letter was 
covered up.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D12992

To: lshoravi, #vdg, ngraham, #elisa
Cc: januz, astippich, mgallien, alex-l, andreask, kde-frameworks-devel, 
ssteffen, lcmscheid, nhuisman, ursjoss, mykolak, jussiv, michaelh, ognarb, 
ngraham, bruns, kmf

D13067: add pgf to the latex-ish file formats (same format as tikz)

[Jan Hajer]

jan.hajer created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
jan.hajer requested review of this revision.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13067

AFFECTED FILES
  data/syntax/latex.xml

To: jan.hajer
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12896: Add Telegram plugin

[Aleix Pol Gonzalez]

apol added a comment.


  In D12896#267091 , @nicolasfella 
wrote:
  
  > In D12896#266713 , @apol wrote:
  >
  > > Then just read the Exec field and we'll add the sendpath by hand. This is 
ad-hoc for telegram anyway.
  >
  >
  > I'm not quite sure what to do. Best I came up with is something like
  >
  >   execStr = parseExec()
  >  
  >   if (execStr.contains("flatpak"))
  >   execStr += "-sendpath @@ url @@"
  >   else
  >   execStr += "-sendpath url"
  >
  >
  > Is this what you had in mind?
  
  
  Sure, something along the lines.  I'm sure we'll be able to find an elegant 
solution.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D12896

To: nicolasfella, apol
Cc: ngraham, kde-frameworks-devel, apol, michaelh, bruns

D12896: Add Telegram plugin

[Nicolas Fella]

nicolasfella added a comment.


  In D12896#266713 , @apol wrote:
  
  > Then just read the Exec field and we'll add the sendpath by hand. This is 
ad-hoc for telegram anyway.
  
  
  I'm not quite sure what to do. Best I came up with is something like
  
execStr = parseExec()

if (execStr.contains("flatpak"))
execStr += "-sendpath @@ url @@"
else
execStr += "-sendpath url"
  
  Is this what you had in mind?

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D12896

To: nicolasfella, apol
Cc: ngraham, kde-frameworks-devel, apol, michaelh, bruns

D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> kcoredirlister_p.h:302
> +// Remove the item from the sorted list (from the wrong place) and 
> insert it in the right place.
> +void reinsert(KFileItem , const QUrl )
> +{

This can be better implemented with std::move and std::move_backward from 

http://www.cplusplus.com/reference/algorithm/move/

1. calculate start and end iterators from the old and new URL
2. move old item to tmp
3.

  if (old_it < new_it) {
 std::move(old_it + 1, new_it, old_it); // move downwards
  } else {
 std::move_backward(new_it , old_it - 1, old_it);
  }
  *new_it = tmp;

> kfileitem.cpp:180
> +// The hash of the url for faster std::lower_bound
> +uint m_hash;
>  };

You can probably leave this out if you use the following for ordering:

  bool operator< (const KFileItem& other) {
if m_url.size() != other.m_url.size() {
  return m_url.size() < other.m_url.size()
}
return m_url < other.m_url;
  }

You don't need lexicographical sorting, but just a total ordering for the 
lookup.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10742

To: jtamate, #frameworks, dfaure
Cc: bruns, kde-frameworks-devel, mwolff, markg, michaelh, ngraham

D13048: Move redundant logic in KIO::iconNameForUrl() into KFileItem::iconName()

[Nathaniel Graham]

ngraham planned changes to this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13048

To: ngraham, #frameworks, broulik
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D13048: Move redundant logic in KIO::iconNameForUrl() into KFileItem::iconName()

[Nathaniel Graham]

ngraham updated this revision to Diff 34715.
ngraham added a comment.


  Merge master to get those nice test fixes

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13048?vs=34675=34715

BRANCH
  iconNameForUrl (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D13048

AFFECTED FILES
  src/core/global.cpp
  src/core/kfileitem.cpp
  src/ioslaves/trash/tests/testtrash.cpp

To: ngraham, #frameworks, broulik
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 118 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/118/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 23 May 2018 14:11:18 +
 Build duration:
17 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiocore-ktcpsockettest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(294/443)66%
(294/443)53%
(31966/60033)38%
(18970/49390)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)95%
(8826/9260)50%
(5581/11153)autotests.http100%
(9/9)100%
(9/9)99%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core84%
(100/119)84%
(100/119)58%
(8460/14499)50%
(4922/9808)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets78%
(31/40)78%
(31/40)49%
(3918/7918)33%
(1656/4966)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(521/1008)42%
(417/1004)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1784/4339)35%
(1382/3995)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1333)55%
(648/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%
(7/11)64%
(7/11)52%

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 268 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/268/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 23 May 2018 14:11:18 +
 Build duration:
5 min 36 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiocore-ktcpsockettest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(294/443)66%
(294/443)53%
(31878/60032)38%
(18936/49394)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)95%
(8826/9260)50%
(5583/11153)autotests.http100%
(9/9)100%
(9/9)99%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core84%
(100/119)84%
(100/119)58%
(8391/14498)50%
(4895/9804)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets78%
(31/40)78%
(31/40)49%
(3917/7918)33%
(1655/4966)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(521/1008)42%
(417/1004)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1786/4339)35%
(1384/3995)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%
(7/11)64%
(7/11)51%

D13061: Fixed kfileplacesviewtest when not running on empty home

[Phabricator]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:a6f88d7e9c69: Fixed kfileplacesviewtest when not running 
on empty home (authored by Renato Araujo Oliveira Filho 
renato.ara...@kdab.com).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13061?vs=34710=34713

REVISION DETAIL
  https://phabricator.kde.org/D13061

AFFECTED FILES
  autotests/kfileplacesviewtest.cpp

To: renatoo, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D13061: Fixed kfileplacesviewtest when not running on empty home

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Works great, thanks!

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13061

To: renatoo, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> kfileitem.cpp:1248
> +{
> +return d->m_hash < other.d->m_hash;
> +}

This is incomplete for two cases:

1. Same URL
2. Hash collision

> kfileitem.h:490
> +/**
> + * Returns -1 if other's URL is greater, 0 if == and 1 if less than (as 
> in String comparations).
> + * @since 5.47

The description does not match the implementation ...

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10742

To: jtamate, #frameworks, dfaure
Cc: bruns, kde-frameworks-devel, mwolff, markg, michaelh, ngraham

D13061: Fixed kfileplacesviewtest when not running on empty home

[Renato Oliveira Filho]

renatoo created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
renatoo requested review of this revision.

REVISION SUMMARY
  Make sure that the test always run on a empty home dir

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13061

AFFECTED FILES
  autotests/kfileplacesviewtest.cpp

To: renatoo
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache

[Jaime Torres Amate]

jtamate updated this revision to Diff 34708.
jtamate edited the summary of this revision.
jtamate edited the test plan for this revision.
jtamate added a comment.
Restricted Application added a subscriber: kde-frameworks-devel.


  Based on the tests done in D12945  and 
D11282 , the best solution is to have the 
result of qHash(url) in KFileItem to compare items in the binary search.
  In two cases, the KFileItem in the list has to be moved to the right 
position, this is still faster than before.
  Introduce two methods to insert an item into the list and to move the item to 
the right position.
  
  The crash in kdirmodeltest was due to getting twice the signal of a file 
changed into a directory.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10742?vs=29572=34708

REVISION DETAIL
  https://phabricator.kde.org/D10742

AFFECTED FILES
  src/core/kcoredirlister.cpp
  src/core/kcoredirlister_p.h
  src/core/kfileitem.cpp
  src/core/kfileitem.h
  src/widgets/kdirmodel.cpp

To: jtamate, #frameworks, dfaure
Cc: kde-frameworks-devel, mwolff, markg, michaelh, ngraham, bruns

KDE CI: Frameworks kservice kf5-qt5 SUSEQt5.10 - Build # 31 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20SUSEQt5.10/31/
 Project:
Frameworks kservice kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 23 May 2018 11:59:42 +
 Build duration:
1 min 45 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.kplugininfotestFailed: TestSuite.kservicetestFailed: TestSuite.ksycocathreadtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report75%
(6/8)83%
(73/88)83%
(73/88)68%
(5508/8117)48%
(3182/6680)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(13/14)93%
(13/14)84%
(1307/1560)45%
(907/2007)src.kbuildsycoca100%
(1/1)100%
(1/1)92%
(54/59)68%
(15/22)src.kdeinit0%
(0/2)0%
(0/2)0%
(0/334)0%
(0/278)src.plugin67%
(2/3)67%
(2/3)49%
(47/96)42%
(44/106)src.services97%
(29/30)97%
(29/30)61%
(1849/3036)41%
(818/1982)src.sycoca83%
(25/30)83%
(25/30)77%
(2143/2794)62%
(1365/2197)tests0%
(0/5)0%
(0/5)0%
(0/118)0%
(0/40)tests.pluginlocator100%
(3/3)100%
(3/3)90%
(108/120)69%
(33/48)

KDE CI: Frameworks kservice kf5-qt5 FreeBSDQt5.10 - Build # 6 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20FreeBSDQt5.10/6/
 Project:
Frameworks kservice kf5-qt5 FreeBSDQt5.10
 Date of build:
Wed, 23 May 2018 11:59:42 +
 Build duration:
1 min 21 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 10 test(s)Failed: TestSuite.kmimeassociationstest

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 267 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/267/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 23 May 2018 11:28:07 +
 Build duration:
18 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiocore-ktcpsockettest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(294/443)66%
(294/443)53%
(31911/60032)38%
(18949/49390)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)95%
(8825/9259)50%
(5579/11149)autotests.http100%
(9/9)100%
(9/9)99%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core84%
(100/119)84%
(100/119)58%
(8401/14498)50%
(4902/9804)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets78%
(31/40)78%
(31/40)50%
(3922/7919)33%
(1655/4966)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(521/1008)42%
(417/1004)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1784/4339)35%
(1382/3995)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%
(7/11)64%
(7/11)52%
  

KDE CI: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.9 - Build # 25 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20SUSEQt5.9/25/
 Project:
Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 23 May 2018 11:36:47 +
 Build duration:
3 min 48 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 19 test(s), Skipped: 0 test(s), Total: 19 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(2/3)45%
(85/187)45%
(85/187)30%
(4536/15085)23%
(1911/8358)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(33/33)100%
(33/33)99%
(1663/1681)52%
(973/1878)src44%
(52/117)44%
(52/117)23%
(2873/12276)15%
(938/6303)tests0%
(0/37)0%
(0/37)0%
(0/1128)0%
(0/177)

KDE CI: Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.10 - Build # 10 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20FreeBSDQt5.10/10/
 Project:
Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.10
 Date of build:
Wed, 23 May 2018 11:36:47 +
 Build duration:
2 min 17 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 18 test(s)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 117 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/117/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 23 May 2018 11:28:07 +
 Build duration:
6 min 4 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiocore-ktcpsockettest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(294/443)66%
(294/443)53%
(31933/60032)38%
(18954/49386)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)95%
(8825/9259)50%
(5579/11149)autotests.http100%
(9/9)100%
(9/9)99%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core84%
(100/119)84%
(100/119)58%
(8449/14499)50%
(4917/9808)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets78%
(31/40)78%
(31/40)49%
(3918/7918)33%
(1656/4966)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(521/1008)42%
(417/1004)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1784/4339)35%
(1381/3995)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1333)55%
(648/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%
(7/11)64%
(7/11)51%
   

D13018: Fix unit test for kfileplacesmodeltest

[Phabricator]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:2c478f4e429b: Fix unit test for kfileplacesmodeltest 
(authored by Renato Araujo Oliveira Filho renato.ara...@kdab.com).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13018?vs=34666=34700

REVISION DETAIL
  https://phabricator.kde.org/D13018

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp

To: renatoo, ngraham
Cc: bruns, ngraham, maximilianocuria, elvisangelaccio, kde-frameworks-devel, 
michaelh

D13018: Fix unit test for kfileplacesmodeltest

[Renato Oliveira Filho]

renatoo added a comment.


  In D13018#266694 , @bruns wrote:
  
  > Shouldn't this be handled by:
  >  http://doc.qt.io/qt-5/qstandardpaths.html#setTestModeEnabled
  
  
  this is different "setTestModeEnabled" sets the XDG_* dirs but the KIO tests 
expects an empty home dir without subfolders like Downloads, Documents, etc..

REVISION DETAIL
  https://phabricator.kde.org/D13018

To: renatoo, ngraham
Cc: bruns, ngraham, maximilianocuria, elvisangelaccio, kde-frameworks-devel, 
michaelh

D13043: Properly sanitize input

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> kconcatenaterowsproxymodel.cpp:70
>  const QAbstractItemModel *sourceModel = sourceIndex.model();
> +if (!sourceModel)
> +return {};

Coding style, braces also for single line statements

> kconcatenaterowsproxymodel.cpp:112
>  const QModelIndex sourceIndex = mapToSource(proxyIndex);
> -return sourceIndex.model()->itemData(sourceIndex);
> +return sourceIndex.isValid() ? 
> sourceIndex.model()->itemData(sourceIndex) : QMap();
>  }

You can also use `{}` here, no? Also, I would prefer an early return rather 
than unary operator

> kconcatenaterowsproxymodel.cpp:151
>  {
> -Q_ASSERT(row >= 0);
> -Q_ASSERT(column >= 0);
> +if(row < 0)
> +return {};

Coding style. Also, check `parent.isValid() return {};` since this is a flat 
model?

REPOSITORY
  R275 KItemModels

REVISION DETAIL
  https://phabricator.kde.org/D13043

To: apol, #frameworks
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kimageformats kf5-qt5 SUSEQt5.9 - Build # 12 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kimageformats%20kf5-qt5%20SUSEQt5.9/12/
 Project:
Frameworks kimageformats kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 23 May 2018 06:07:15 +
 Build duration:
4 min 17 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.kimageformats-read-xcf
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(3/3)88%
(21/24)88%
(21/24)46%
(1663/3633)38%
(847/2228)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(3/3)100%
(3/3)72%
(273/379)51%
(129/252)src.imageformats94%
(17/18)94%
(17/18)44%
(1386/3120)37%
(716/1918)tests33%
(1/3)33%
(1/3)3%
(4/134)3%
(2/58)

KDE CI: Frameworks kimageformats kf5-qt5 FreeBSDQt5.10 - Build # 4 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kimageformats%20kf5-qt5%20FreeBSDQt5.10/4/
 Project:
Frameworks kimageformats kf5-qt5 FreeBSDQt5.10
 Date of build:
Wed, 23 May 2018 06:07:15 +
 Build duration:
1 min 55 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.kimageformats-read-xcf

KDE CI: Frameworks kimageformats kf5-qt5 SUSEQt5.10 - Build # 19 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kimageformats%20kf5-qt5%20SUSEQt5.10/19/
 Project:
Frameworks kimageformats kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 23 May 2018 06:07:15 +
 Build duration:
1 min 44 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.kimageformats-read-tgaFailed: TestSuite.kimageformats-read-xcfFailed: TestSuite.kimageformats-write-tga
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(3/3)79%
(19/24)79%
(19/24)42%
(1532/3631)36%
(798/2228)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(3/3)100%
(3/3)75%
(283/379)59%
(149/252)src.imageformats83%
(15/18)83%
(15/18)40%
(1245/3118)34%
(647/1918)tests33%
(1/3)33%
(1/3)3%
(4/134)3%
(2/58)

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 163 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/163/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 23 May 2018 06:06:06 +
 Build duration:
2 min 51 sec and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)26%
(3561/13468)19%
(1979/10659)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(609/1140)28%
(421/1492)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/470)0%
(0/263)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(253/2246)7%
(102/1496)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/525)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1442/3532)28%
(827/2965)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)41%
(671/1621)28%
(318/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)27%
(555/2020)17%
(306/1781)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1179)0%
(0/1058)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%
 

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 - Build # 15 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.10/15/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10
 Date of build:
Wed, 23 May 2018 06:06:05 +
 Build duration:
2 min 20 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest