D13275: Teach ContainmentInterface::processMimeData how to handle Task Manager drops

[Nathaniel Graham]

ngraham added a comment.


  Hmm, this doesn't build for me (Neon dev unstable, deps built from source):
  

/home/dev/repos/plasma-framework/src/scriptengines/qml/plasmoid/containmentinterface.cpp:
 In member function 'void ContainmentInterface::processMimeData(QMimeData*, 
int, int, KIO::DropJob*)':

/home/dev/repos/plasma-framework/src/scriptengines/qml/plasmoid/containmentinterface.cpp:455:52:
 error: 'mimeCopy' was not declared in this scope
 QList urls = 
{QUrl(QString::fromUtf8(mimeCopy->data(QStringLiteral("text/x-orgkd
^

/home/dev/repos/plasma-framework/src/scriptengines/qml/plasmoid/containmentinterface.cpp:455:126:
 error: could not convert '{}' from '' to 'QList'
 
QString::fromUtf8(mimeCopy->data(QStringLiteral("text/x-orgkdeplasmataskmanager_taskurl"};

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D13275

To: hein, davidedmundson, Zren, mart
Cc: ngraham, zzag, kde-frameworks-devel, plasma-devel, michaelh, bruns

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 282 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/282/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 01 Jun 2018 21:39:36 +
 Build duration:
6 min 57 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiocore-ktcpsockettest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(294/443)66%
(294/443)53%
(31871/60034)38%
(18929/49410)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)95%
(8829/9263)50%
(5580/11155)autotests.http100%
(9/9)100%
(9/9)99%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core84%
(100/119)84%
(100/119)58%
(8378/14484)50%
(4894/9798)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets78%
(31/40)78%
(31/40)49%
(3917/7918)33%
(1655/4966)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(526/1015)42%
(421/1012)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/107)0%
(0/77)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1784/4339)35%
(1379/3995)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%
(7/11)64%
(7/11)51%

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 38 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/38/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.10
 Date of build:
Fri, 01 Jun 2018 21:39:36 +
 Build duration:
5 min 32 sec and counting
   JUnit Tests
  Name: (root) Failed: 5 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiocore-ktcpsockettestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 131 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/131/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 01 Jun 2018 21:39:36 +
 Build duration:
5 min 29 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiocore-ktcpsockettestFailed: TestSuite.kiofilewidgets-kfileplacesviewtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(294/443)66%
(294/443)53%
(31926/60035)38%
(18962/49406)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)95%
(8829/9263)50%
(5586/11155)autotests.http100%
(9/9)100%
(9/9)99%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core84%
(100/119)84%
(100/119)58%
(8436/14485)50%
(4919/9802)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets78%
(31/40)78%
(31/40)49%
(3915/7918)33%
(1653/4966)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(526/1015)42%
(421/1012)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/107)0%
(0/77)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1784/4339)35%
(1381/3995)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1333)55%
(648/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%
(7/11)64%

D13268: Add signal for devices's address changing

[David Rosca]

drosca accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D13268

To: andreysemenov, mlaurent, drosca
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D10747: Implement zwp_linux_dmabuf_v1

[Roman Gilg]

romangg added a comment.
Restricted Application edited subscribers, added: kde-frameworks-devel; 
removed: Frameworks.


  What's the current state of this patch and the KWin one?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D10747

To: fredrik, #kwin, #plasma, graesslin, davidedmundson, mart
Cc: kde-frameworks-devel, romangg, plasma-devel, ragreen, Pitel, schernikov, 
michaelh, ZrenBot, ngraham, bruns, alexeymin, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, #frameworks

D13215: Update sizes before generating frame svg background

[Andres Betts]

abetts added a comment.


  +1 on this! Love it!

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D13215

To: zzag, #plasma, #frameworks
Cc: abetts, mart, aseigo, broulik, kde-frameworks-devel, michaelh, ngraham, 
bruns

D13215: Update sizes before generating frame svg background

[Vlad Zagorodniy]

zzag added inline comments.

INLINE COMMENTS

> framesvg.cpp:483
>  
>  updateSizes(maskFrame);
>  }

Should it be here?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D13215

To: zzag, #plasma, #frameworks
Cc: mart, aseigo, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D13215: Update sizes before generating frame svg background

[Vlad Zagorodniy]

zzag edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D13215

To: zzag, #plasma, #frameworks
Cc: mart, aseigo, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D13215: Update sizes before generating frame svg background

[Vlad Zagorodniy]

zzag updated this revision to Diff 35338.
zzag added a comment.


  Code cleanup.

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13215?vs=35336=35338

BRANCH
  fix-framesvg-contentrect

REVISION DETAIL
  https://phabricator.kde.org/D13215

AFFECTED FILES
  src/plasma/framesvg.cpp

To: zzag, #plasma, #frameworks
Cc: mart, aseigo, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D13268: Add signal for devices's address changing

[Andrey Semenov]

andreysemenov added a reviewer: mlaurent.

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D13268

To: andreysemenov, mlaurent
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13215: Update sizes before generating frame svg background

[Vlad Zagorodniy]

zzag updated this revision to Diff 35336.
zzag added a comment.


  Do not ignore previous maskFrame's enabled borders.

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13215?vs=35191=35336

BRANCH
  fix-framesvg-contentrect

REVISION DETAIL
  https://phabricator.kde.org/D13215

AFFECTED FILES
  src/plasma/framesvg.cpp

To: zzag, #plasma, #frameworks
Cc: mart, aseigo, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D13268: Add signal for devices's address changing

[Andrey Semenov]

andreysemenov created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
andreysemenov requested review of this revision.

REVISION SUMMARY
  If device connected with adapter via Bluetooth LE and i try to pair, device's 
address changing to another and it's address type becomes to 'public' instead 
of 'random'. So there is no actual  possibility to control pairing result.

TEST PLAN
  1. Create Bluetooth Low Energy service.
  2. Connect with device to this service.
  3. Try to pair device with BluezQt API.
  4. Even if device paired BluezQt API's method isPaired() returns false, 
because device changed its address and address type.
  5. Apply patch.
  6. Do same steps with connection to addressChanged signal.

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D13268

AFFECTED FILES
  src/device.h
  src/device_p.cpp
  src/device_p.h

To: andreysemenov
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13215: Update sizes before generating frame svg background

[Vlad Zagorodniy]

zzag added a comment.


  I think I got it.
  
  FrameSVGPrivate::updateFrameData updates only `frame`, `maskFrame` is updated 
lazily in `alphaMask` method, but the alphaMask method ignores previous state 
of enabledBorders. So, we end up with using stale maskFrame.
  
  E.g.
  
FrameSVGPrivate::updateFrameData() {
if (!fd) {
...
old key = "10_216_768_1_1__dialogs/background"
old borders = 
QFlags(BottomBorder|RightBorder)
new key = "8_216_768_1_1__dialogs/background"
new borders = QFlags(RightBorder)
  
  Now, when we call alphaMask,
  
FrameSVGPrivate::alphaMask() {
if (maskPrefix.isNull()) {
} else {
 ...
 oldKey = "10_216_768_1_1_mask-_dialogs/background"

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D13215

To: zzag, #plasma, #frameworks
Cc: mart, aseigo, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 130 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/130/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 01 Jun 2018 12:28:07 +
 Build duration:
24 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiocore-ktcpsockettest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(294/443)66%
(294/443)53%
(31951/60028)38%
(18970/49400)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)95%
(8829/9263)50%
(5582/11155)autotests.http100%
(9/9)100%
(9/9)99%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core84%
(100/119)84%
(100/119)58%
(8437/14484)50%
(4916/9802)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets78%
(31/40)78%
(31/40)49%
(3917/7918)33%
(1655/4966)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(527/1015)42%
(422/1012)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/107)0%
(0/77)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1784/4339)35%
(1381/3995)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1333)55%
(648/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%
(7/11)64%
(7/11)52%

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 281 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/281/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 01 Jun 2018 12:18:51 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiocore-ktcpsockettest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(294/443)66%
(294/443)53%
(31893/60027)38%
(18945/49404)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)95%
(8829/9263)50%
(5580/11155)autotests.http100%
(9/9)100%
(9/9)99%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core84%
(100/119)84%
(100/119)58%
(8379/14483)50%
(4896/9798)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets78%
(31/40)78%
(31/40)49%
(3917/7918)33%
(1655/4966)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(526/1015)42%
(421/1012)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/107)0%
(0/77)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1784/4339)35%
(1381/3995)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%
(7/11)64%
(7/11)52%
  

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 129 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/129/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 01 Jun 2018 12:02:57 +
 Build duration:
25 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiocore-ktcpsockettest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(294/443)66%
(294/443)53%
(31940/60028)38%
(18961/49400)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)95%
(8829/9263)50%
(5581/11155)autotests.http100%
(9/9)100%
(9/9)99%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core84%
(100/119)84%
(100/119)58%
(8426/14484)50%
(4908/9802)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets78%
(31/40)78%
(31/40)49%
(3917/7918)33%
(1655/4966)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(527/1015)42%
(422/1012)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/107)0%
(0/77)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1784/4339)35%
(1381/3995)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1333)55%
(648/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%
(7/11)64%
(7/11)52%

D13266: Set RTL supported by default on QtQuick KCMs

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

TEST PLAN
  Opened translations KCM
  Opened desktop KCM
  Opened LNF KCM

REPOSITORY
  R296 KDeclarative

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13266

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/SimpleKCM.qml

To: davidedmundson, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 37 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/37/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.10
 Date of build:
Fri, 01 Jun 2018 12:16:59 +
 Build duration:
8 min 11 sec and counting
   JUnit Tests
  Name: (root) Failed: 5 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiocore-ktcpsockettestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 280 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/280/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 01 Jun 2018 12:06:01 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiocore-ktcpsockettest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(294/443)66%
(294/443)53%
(31900/60028)38%
(18947/49404)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)95%
(8829/9263)50%
(5582/11155)autotests.http100%
(9/9)100%
(9/9)99%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core84%
(100/119)84%
(100/119)58%
(8386/14484)50%
(4896/9798)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets78%
(31/40)78%
(31/40)49%
(3917/7918)33%
(1655/4966)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(526/1015)42%
(421/1012)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/107)0%
(0/77)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1784/4339)35%
(1381/3995)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%
(7/11)64%
(7/11)52%
  

D13215: Update sizes before generating frame svg background

[Vlad Zagorodniy]

zzag added a comment.


  In D13215#271994 , @zzag wrote:
  
  > In D13215#271983 , @broulik 
wrote:
  >
  > > +1
  > >
  > > Doesn't make a difference in Oxygen's rounded corners on panels but 
doesn't make it worse either. Please also profile whether it causes any 
needless recalculations on Plasma startup
  >
  >
  > Maybe, because of
  >
  >   if (!d->repaintBlocked) {
  >  d->updateFrameData();
  >   }
  >
  >
  > FrameSVG misses to update margins, and so on.
  
  
  OK, I'm wrong about this part.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D13215

To: zzag, #plasma, #frameworks
Cc: mart, aseigo, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 36 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/36/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.10
 Date of build:
Fri, 01 Jun 2018 12:07:38 +
 Build duration:
8 min 12 sec and counting
   JUnit Tests
  Name: (root) Failed: 5 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiocore-ktcpsockettestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 35 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/35/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.10
 Date of build:
Fri, 01 Jun 2018 11:59:15 +
 Build duration:
8 min 19 sec and counting
   JUnit Tests
  Name: (root) Failed: 5 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiocore-ktcpsockettestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 279 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/279/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 01 Jun 2018 12:00:55 +
 Build duration:
5 min 5 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiocore-ktcpsockettest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(294/443)66%
(294/443)53%
(31872/60028)38%
(18938/49404)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)95%
(8829/9263)50%
(5582/11155)autotests.http100%
(9/9)100%
(9/9)99%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core84%
(100/119)84%
(100/119)58%
(8379/14484)50%
(4897/9798)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets78%
(31/40)78%
(31/40)49%
(3917/7918)33%
(1655/4966)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(526/1015)42%
(421/1012)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/107)0%
(0/77)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1784/4339)35%
(1379/3995)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%
(7/11)64%
(7/11)51%
 

D12745: Unify API for file descriptor sharing

[Chinmoy Ranjan Pradhan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:a3328eaa5197: Unify API for file descriptor sharing 
(authored by chinmoyr).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12745?vs=35325=35326

REVISION DETAIL
  https://phabricator.kde.org/D12745

AFFECTED FILES
  src/ioslaves/file/fdreceiver.cpp
  src/ioslaves/file/fdreceiver.h
  src/ioslaves/file/file_unix.cpp

To: chinmoyr, dfaure, ossi
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 128 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/128/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 01 Jun 2018 11:47:41 +
 Build duration:
15 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiocore-ktcpsockettest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(294/443)66%
(294/443)53%
(31961/60023)38%
(18983/49396)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)95%
(8829/9263)50%
(5582/11155)autotests.http100%
(9/9)100%
(9/9)99%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core84%
(100/119)84%
(100/119)58%
(8438/14485)50%
(4922/9802)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets78%
(31/40)78%
(31/40)49%
(3918/7918)33%
(1656/4966)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(530/1012)42%
(426/1010)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1784/4339)35%
(1381/3995)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1333)55%
(648/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%
(7/11)64%
(7/11)52%

D12745: Unify API for file descriptor sharing

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 35325.
chinmoyr added a comment.


  Rebased on master

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12745?vs=34965=35325

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12745

AFFECTED FILES
  src/ioslaves/file/fdreceiver.cpp
  src/ioslaves/file/fdreceiver.h
  src/ioslaves/file/file_unix.cpp

To: chinmoyr, dfaure, ossi
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 278 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/278/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 01 Jun 2018 11:55:33 +
 Build duration:
5 min 20 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiocore-ktcpsockettest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(294/443)66%
(294/443)53%
(31875/60022)38%
(18935/49400)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)95%
(8829/9263)50%
(5582/11155)autotests.http100%
(9/9)100%
(9/9)99%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core84%
(100/119)84%
(100/119)58%
(8378/14484)50%
(4895/9798)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets78%
(31/40)78%
(31/40)49%
(3917/7918)33%
(1655/4966)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(525/1012)42%
(420/1010)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1789/4339)35%
(1379/3995)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%
(7/11)64%
(7/11)51%

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 34 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/34/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.10
 Date of build:
Fri, 01 Jun 2018 11:51:04 +
 Build duration:
8 min 7 sec and counting
   JUnit Tests
  Name: (root) Failed: 5 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiocore-ktcpsockettestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

D12744: Add null pointer check when creating SocketAddress

[Chinmoy Ranjan Pradhan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:bf7bfe9353c5: Add null pointer check when creating 
SocketAddress (authored by chinmoyr).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12744?vs=34961=35323

REVISION DETAIL
  https://phabricator.kde.org/D12744

AFFECTED FILES
  src/ioslaves/file/fdreceiver.cpp
  src/ioslaves/file/kauth/fdsender.cpp

To: chinmoyr, dfaure, ossi
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 277 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/277/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 01 Jun 2018 11:28:14 +
 Build duration:
27 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiocore-ktcpsockettest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(294/443)66%
(294/443)53%
(31899/60021)38%
(18945/49400)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)95%
(8827/9263)50%
(5579/11155)autotests.http100%
(9/9)100%
(9/9)99%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core84%
(100/119)84%
(100/119)58%
(8388/14484)50%
(4897/9798)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets78%
(31/40)78%
(31/40)49%
(3917/7918)33%
(1655/4966)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(525/1011)42%
(421/1010)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1784/4339)35%
(1381/3995)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%
(7/11)64%
(7/11)52%
  

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 33 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/33/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.10
 Date of build:
Fri, 01 Jun 2018 11:46:29 +
 Build duration:
4 min 22 sec and counting
   JUnit Tests
  Name: (root) Failed: 5 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiocore-ktcpsockettestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

D10411: Create socket file in user's runtime directory

[Chinmoy Ranjan Pradhan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:ae08be3a4847: Create socket file in users runtime 
directory (authored by chinmoyr).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10411?vs=33765=35322

REVISION DETAIL
  https://phabricator.kde.org/D10411

AFFECTED FILES
  src/ioslaves/file/file_unix.cpp
  src/ioslaves/file/sharefd_p.h

To: chinmoyr, #frameworks, ossi
Cc: kde-frameworks-devel, dfaure, michaelh, ngraham, bruns

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 127 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/127/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 01 Jun 2018 11:28:14 +
 Build duration:
19 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiocore-ktcpsockettest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(294/443)66%
(294/443)53%
(31959/60022)38%
(18974/49396)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)95%
(8829/9263)50%
(5580/11155)autotests.http100%
(9/9)100%
(9/9)99%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core84%
(100/119)84%
(100/119)58%
(8447/14485)50%
(4925/9802)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets78%
(31/40)78%
(31/40)49%
(3918/7918)33%
(1656/4966)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(524/1011)42%
(420/1010)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1784/4339)35%
(1381/3995)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1333)55%
(648/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%
(7/11)64%
(7/11)52%

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 32 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/32/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.10
 Date of build:
Fri, 01 Jun 2018 11:36:34 +
 Build duration:
8 min 17 sec and counting
   JUnit Tests
  Name: (root) Failed: 5 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiocore-ktcpsockettestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

D10410: Move task of cleaning up socket file to FdReceiver

[Chinmoy Ranjan Pradhan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:3e7c84e877e5: Move task of cleaning up socket file to 
FdReceiver (authored by chinmoyr).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10410?vs=34960=35321

REVISION DETAIL
  https://phabricator.kde.org/D10410

AFFECTED FILES
  src/ioslaves/file/fdreceiver.cpp
  src/ioslaves/file/fdreceiver.h
  src/ioslaves/file/sharefd_p.h

To: chinmoyr, #frameworks, ossi, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 31 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/31/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.10
 Date of build:
Fri, 01 Jun 2018 11:28:14 +
 Build duration:
8 min 15 sec and counting
   JUnit Tests
  Name: (root) Failed: 5 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiocore-ktcpsockettestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

D10410: Move task of cleaning up socket file to FdReceiver

[Chinmoy Ranjan Pradhan]

chinmoyr retitled this revision from "Move the task of cleaning up of socket 
file to file ioslave and FdReceiver" to "Move task of cleaning up socket file 
to FdReceiver".

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10410

To: chinmoyr, #frameworks, ossi, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D10410: Move the task of cleaning up of socket file to file ioslave and FdReceiver

[Chinmoy Ranjan Pradhan]

chinmoyr edited the summary of this revision.

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10410

To: chinmoyr, #frameworks, ossi, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D10409: In linux don't use abstract socket to share file descriptor

[Chinmoy Ranjan Pradhan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:89275d0d1450: In linux dont use abstract socket to 
share file descriptor (authored by chinmoyr).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10409?vs=32413=35320

REVISION DETAIL
  https://phabricator.kde.org/D10409

AFFECTED FILES
  src/ioslaves/file/sharefd_p.h

To: chinmoyr, #frameworks, ossi
Cc: kde-frameworks-devel, dfaure, michaelh, ngraham, bruns

D13215: Update sizes before generating frame svg background

[Vlad Zagorodniy]

zzag added subscribers: aseigo, mart.
zzag added a comment.


  In D13215#271983 , @broulik wrote:
  
  > +1
  >
  > Doesn't make a difference in Oxygen's rounded corners on panels but doesn't 
make it worse either. Please also profile whether it causes any needless 
recalculations on Plasma startup
  
  
  I'd like to dig deeper why margins do not correspond to enabled margins. 
Maybe, because of
  
if (!d->repaintBlocked) {
   d->updateFrameData();
}
  
  FrameSVG misses to update margins, and so on.
  
  I really would like to here opinion of @mart and @aseigo . Maybe, there is a 
better way to fix this.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D13215

To: zzag, #plasma, #frameworks
Cc: mart, aseigo, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D13215: Update sizes before generating frame svg background

[Kai Uwe Broulik]

broulik added a comment.


  +1
  
  Doesn't make a difference in Oxygen's rounded corners on panels but doesn't 
make it worse either. Please also profile whether it causes any needless 
recalculations on Plasma startup

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D13215

To: zzag, #plasma, #frameworks
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D6313: Support Icon Scale from Icon naming specification 0.13

[David Edmundson]

davidedmundson added a comment.


  +1 from me, but wait till after this release tagging

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D6313

To: broulik, kde-frameworks-devel, #plasma, #vdg
Cc: hein, rkflx, acrouthamel, ngraham, elvisangelaccio, mart, kvermette, cfeck, 
davidedmundson, plasma-devel, ragreen, Pitel, michaelh, ZrenBot, bruns, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D12520: [PasteJob] Emit KDirNotify on paste

[Kai Uwe Broulik]

broulik added a comment.
Restricted Application added a subscriber: kde-frameworks-devel.


  Ping

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12520

To: broulik, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D6313: Support Icon Scale from Icon naming specification 0.13

[Kai Uwe Broulik]

broulik updated this revision to Diff 35318.
broulik added a comment.


  …

REPOSITORY
  R302 KIconThemes

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6313?vs=35317=35318

REVISION DETAIL
  https://phabricator.kde.org/D6313

AFFECTED FILES
  src/kiconengine.cpp
  src/kiconengine.h
  src/kiconloader.cpp
  src/kiconloader.h
  src/kicontheme.cpp
  src/kicontheme.h

To: broulik, kde-frameworks-devel, #plasma, #vdg
Cc: hein, rkflx, acrouthamel, ngraham, elvisangelaccio, mart, kvermette, cfeck, 
davidedmundson, plasma-devel, ragreen, Pitel, michaelh, ZrenBot, bruns, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D6313: Support Icon Scale from Icon naming specification 0.13

[Kai Uwe Broulik]

broulik updated this revision to Diff 35317.
broulik added a comment.


  - Fix rebase

REPOSITORY
  R302 KIconThemes

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6313?vs=34781=35317

REVISION DETAIL
  https://phabricator.kde.org/D6313

AFFECTED FILES
  src/kiconengine.cpp
  src/kiconengine.h
  src/kiconloader.cpp
  src/kiconloader.h
  src/kicontheme.cpp
  src/kicontheme.h

To: broulik, kde-frameworks-devel, #plasma, #vdg
Cc: hein, rkflx, acrouthamel, ngraham, elvisangelaccio, mart, kvermette, cfeck, 
davidedmundson, plasma-devel, ragreen, Pitel, michaelh, ZrenBot, bruns, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D12895: WIP: Add KFileItemActionsPlugin

[Kai Uwe Broulik]

broulik abandoned this revision.
broulik added a comment.


  Superseded by D13124 

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D12895

To: broulik, #plasma, #vdg, apol
Cc: nicolasfella, elvisangelaccio, abetts, ngraham, kde-frameworks-devel, 
michaelh, bruns

KDE CI: Frameworks kdeclarative kf5-qt5 WindowsMSVCQt5.10 - Build # 30 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kdeclarative%20kf5-qt5%20WindowsMSVCQt5.10/30/
 Project:
Frameworks kdeclarative kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Fri, 01 Jun 2018 10:01:38 +
 Build duration:
8 min 53 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)

KDE CI: Frameworks kdeclarative kf5-qt5 SUSEQt5.9 - Build # 29 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kdeclarative%20kf5-qt5%20SUSEQt5.9/29/
 Project:
Frameworks kdeclarative kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 01 Jun 2018 10:01:38 +
 Build duration:
1 min 35 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(5/15)23%
(18/78)23%
(18/78)21%
(701/3391)15%
(313/2133)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(7/7)100%
(7/7)83%
(386/463)40%
(198/490)src.calendarevents0%
(0/2)0%
(0/2)0%
(0/62)0%
(0/2)src.kdeclarative75%
(3/4)75%
(3/4)51%
(154/302)39%
(57/148)src.kdeclarative.private100%
(4/4)100%
(4/4)24%
(8/33)0%
(0/18)src.kpackagelauncherqml0%
(0/1)0%
(0/1)0%
(0/62)0%
(0/18)src.qmlcontrols.draganddrop0%
(0/11)0%
(0/11)0%
(0/361)0%
(0/210)src.qmlcontrols.kcmcontrols0%
(0/2)0%
(0/2)0%
(0/5)0%
(0/2)src.qmlcontrols.kconfig0%
(0/3)0%
(0/3)0%
(0/12)0%
(0/2)src.qmlcontrols.kcoreaddons0%
(0/5)0%
(0/5)0%
(0/87)0%
(0/82)src.qmlcontrols.kioplugin0%
(0/4)0%
(0/4)0%
(0/22)0%
(0/18)src.qmlcontrols.kquickcontrols.private0%
(0/5)0%
(0/5)0%
(0/315)0%
(0/220)src.qmlcontrols.kquickcontrolsaddons11%
(2/18)11%
(2/18)5%
(66/1310)5%
(35/773)src.qmlcontrols.kwindowsystemplugin0%
(0/3)0%
(0/3)0%
(0/61)0%
(0/36)src.quickaddons29%
(2/7)29%
(2/7)32%
(87/269)21%
(23/112)tests0%
(0/2)0%
(0/2)0%
(0/27)0%
(0/2)

KDE CI: Frameworks kdeclarative kf5-qt5 SUSEQt5.10 - Build # 51 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kdeclarative%20kf5-qt5%20SUSEQt5.10/51/
 Project:
Frameworks kdeclarative kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 01 Jun 2018 10:01:38 +
 Build duration:
1 min 48 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(5/15)23%
(18/78)23%
(18/78)21%
(701/3391)15%
(313/2133)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(7/7)100%
(7/7)83%
(386/463)40%
(198/490)src.calendarevents0%
(0/2)0%
(0/2)0%
(0/62)0%
(0/2)src.kdeclarative75%
(3/4)75%
(3/4)51%
(154/302)39%
(57/148)src.kdeclarative.private100%
(4/4)100%
(4/4)24%
(8/33)0%
(0/18)src.kpackagelauncherqml0%
(0/1)0%
(0/1)0%
(0/62)0%
(0/18)src.qmlcontrols.draganddrop0%
(0/11)0%
(0/11)0%
(0/361)0%
(0/210)src.qmlcontrols.kcmcontrols0%
(0/2)0%
(0/2)0%
(0/5)0%
(0/2)src.qmlcontrols.kconfig0%
(0/3)0%
(0/3)0%
(0/12)0%
(0/2)src.qmlcontrols.kcoreaddons0%
(0/5)0%
(0/5)0%
(0/87)0%
(0/82)src.qmlcontrols.kioplugin0%
(0/4)0%
(0/4)0%
(0/22)0%
(0/18)src.qmlcontrols.kquickcontrols.private0%
(0/5)0%
(0/5)0%
(0/315)0%
(0/220)src.qmlcontrols.kquickcontrolsaddons11%
(2/18)11%
(2/18)5%
(66/1310)5%
(35/773)src.qmlcontrols.kwindowsystemplugin0%
(0/3)0%
(0/3)0%
(0/61)0%
(0/36)src.quickaddons29%
(2/7)29%
(2/7)32%
(87/269)21%
(23/112)tests0%
(0/2)0%
(0/2)0%
(0/27)0%
(0/2)

KDE CI: Frameworks kdeclarative kf5-qt5 FreeBSDQt5.10 - Build # 9 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kdeclarative%20kf5-qt5%20FreeBSDQt5.10/9/
 Project:
Frameworks kdeclarative kf5-qt5 FreeBSDQt5.10
 Date of build:
Fri, 01 Jun 2018 10:01:38 +
 Build duration:
1 min 7 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)

KDE CI: Frameworks kdeclarative kf5-qt5 SUSEQt5.9 - Build # 28 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kdeclarative%20kf5-qt5%20SUSEQt5.9/28/
 Project:
Frameworks kdeclarative kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 01 Jun 2018 09:39:08 +
 Build duration:
4 min 12 sec and counting
   CONSOLE OUTPUT
  [...truncated 69.15 KB...]PAGER = 'less'BUILD_NUMBER  = '28'MORE  = '-sl'WORKSPACE = '/home/jenkins/workspace/Frameworks kdeclarative kf5-qt5 SUSEQt5.9'PWD   = '/home/jenkins/workspace/Frameworks kdeclarative kf5-qt5 SUSEQt5.9'HUDSON_URL= 'https://build.kde.org/'HOME  = '/home/jenkins/'NODE_NAME = 'Docker Swarm-dd78e490399e'HOST  = 'dd78e490399e'XNLSPATH  = '/usr/X11R6/lib/X11/nls'JOB_NAME  = 'Frameworks kdeclarative kf5-qt5 SUSEQt5.9'XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'LIBGL_DEBUG   = 'quiet'HUDSON_HOME   = '/home/production/data'JOB_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks%20kdeclarative%20kf5-qt5%20SUSEQt5.9/display/redirect'PROFILEREAD   = 'true'MAIL  = '/var/mail/jenkins'QTC_BUILD = '/usr'LESSKEY   = '/etc/lesskey.bin'BUILD_URL = 'https://build.kde.org/job/Frameworks%20kdeclarative%20kf5-qt5%20SUSEQt5.9/28/'SHELL = '/bin/bash'STAGE_NAME= 'Configuring Build'JOB_URL   = 'https://build.kde.org/job/Frameworks%20kdeclarative%20kf5-qt5%20SUSEQt5.9/'BUILD_DISPLAY_NAME= '#28'XCURSOR_THEME = 'DMZ'SHLVL = '3'BUILD_TAG = 'jenkins-Frameworks kdeclarative kf5-qt5 SUSEQt5.9-28'NODE_LABELS   = 'Docker Swarm-dd78e490399e SUSEQt5.9'LOGNAME   = 'jenkins'JRE_HOME  = '/usr/lib64/jvm/jre'XDG_CONFIG_DIRS   = '/home/jenkins/install-prefix/etc/xdg:/etc/xdg'PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'JAVA_BINDIR   = '/usr/lib64/jvm/jre/bin'G_BROKEN_FILENAMES= '1'HISTSIZE  = '1000'CPU   = 'x86_64'CVS_RSH   = 'ssh'LESSOPEN  = 'lessopen.sh %s'CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'QT_SELECT = 'qt5'XDG_CURRENT_DESKTOP   = 'KDE'ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON  "/home/jenkins/workspace/Frameworks kdeclarative kf5-qt5 SUSEQt5.9"-- The C compiler identification is GNU 7.3.1-- The CXX compiler identification is GNU 7.3.1-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Looking for __GLIBC__-- Looking for __GLIBC__ - found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- Found Gettext: /usr/bin/msgmerge (found version "0.19.8.1") CMake Error at CMakeLists.txt:31 (find_package):  By not providing "FindKF5NewStuff.cmake" in CMAKE_MODULE_PATH this project  has asked CMake to find a package configuration file provided by  "KF5NewStuff", but CMake did not find one.  Could not find a package configuration file provided by "KF5NewStuff"  (requested version 5.46.0) with any of the following names:KF5NewStuffConfig.cmakekf5newstuff-config.cmake  Add the installation prefix of "KF5NewStuff" to CMAKE_PREFIX_PATH or set  "KF5NewStuff_DIR" to a directory containing one of the above files.  If  "KF5NewStuff" provides a separate development package or SDK, be sure it  has been installed.-- Configuring incomplete, errors occurred!See also "/home/jenkins/workspace/Frameworks kdeclarative kf5-qt5 

KDE CI: Frameworks kdeclarative kf5-qt5 WindowsMSVCQt5.10 - Build # 29 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kdeclarative%20kf5-qt5%20WindowsMSVCQt5.10/29/
 Project:
Frameworks kdeclarative kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Fri, 01 Jun 2018 09:39:08 +
 Build duration:
1 min 38 sec and counting
   CONSOLE OUTPUT
  [...truncated 70.78 KB...]PROGRAMW6432  = 'C:\Program Files'PROMPT= '$P$G'PSMODULEPATH  = 'C:\WINDOWS\system32\WindowsPowerShell\v1.0\Modules\'PUBLIC= 'C:\Users\Public'RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks%20kdeclarative%20kf5-qt5%20WindowsMSVCQt5.10/29/display/redirect?page=changes'RUN_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks%20kdeclarative%20kf5-qt5%20WindowsMSVCQt5.10/29/display/redirect'STAGE_NAME= 'Configuring Build'SYSTEMDRIVE   = 'C:'SYSTEMROOT= 'C:\WINDOWS'TEMP  = 'C:\Users\Jenkins\AppData\Local\Temp'TMP   = 'C:\Users\Jenkins\AppData\Local\Temp'UCRTVERSION   = '10.0.17134.0'UNIVERSALCRTSDKDIR= 'C:\Program Files (x86)\Windows Kits\10\'USERDOMAIN= 'DESKTOP-66R8QOQ'USERNAME  = 'Jenkins'USERPROFILE   = 'C:\Users\Jenkins'VCIDEINSTALLDIR   = 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\Common7\IDE\VC\'VCINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\VC\'VCTOOLSINSTALLDIR = 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\VC\Tools\MSVC\14.14.26428\'VCTOOLSREDISTDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\VC\Redist\MSVC\14.14.26405\'VCTOOLSVERSION= '14.14.26428'VISUALSTUDIOVERSION   = '15.0'VS140COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\Tools\'VS150COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\Common7\Tools\'VSCMD_ARG_APP_PLAT= 'Desktop'VSCMD_ARG_HOST_ARCH   = 'x64'VSCMD_ARG_TGT_ARCH= 'x64'VSCMD_VER = '15.7.2'VSINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\'WINDIR= 'C:\WINDOWS'WINDOWSLIBPATH= 'C:\Program Files (x86)\Windows Kits\10\UnionMetadata\10.0.17134.0;C:\Program Files (x86)\Windows Kits\10\References\10.0.17134.0'WINDOWSSDKBINPATH = 'C:\Program Files (x86)\Windows Kits\10\bin\'WINDOWSSDKDIR = 'C:\Program Files (x86)\Windows Kits\10\'WINDOWSSDKLIBVERSION  = '10.0.17134.0\'WINDOWSSDKVERBINPATH  = 'C:\Program Files (x86)\Windows Kits\10\bin\10.0.17134.0\'WINDOWSSDKVERSION = '10.0.17134.0\'WORKSPACE = 'C:\CI\workspace\Frameworks kdeclarative kf5-qt5 WindowsMSVCQt5.10'__DOTNET_ADD_64BIT= '1'__DOTNET_PREFERRED_BITNESS = '64'__VSCMD_PREINIT_PATH  = 'C:\Program Files (x86)\Common Files\Oracle\Java\javapath;C:\Program Files\Python36-32\Scripts\;C:\Program Files\Python36-32\;C:\ProgramData\Oracle\Java\javapath;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\Program Files\Git\cmd;C:\WINDOWS\System32\OpenSSH\;C:\Users\Jenkins\AppData\Local\Microsoft\WindowsApps'CMAKE_PREFIX_PATH = 'C:\CI\workspace\Frameworks kdeclarative kf5-qt5 WindowsMSVCQt5.10\install-prefix;C:\Craft\CI\windows-msvc2017_64-cl-debug;C:\Craft\CI\windows-msvc2017_64-cl-debug\dev-utils'QT_PLUGIN_PATH= 'C:\CI\workspace\Frameworks kdeclarative kf5-qt5 WindowsMSVCQt5.10\install-prefix\lib\plugins;C:\Craft\CI\windows-msvc2017_64-cl-debug\lib\qca-qt5'QML2_IMPORT_PATH  = 'C:\CI\workspace\Frameworks kdeclarative kf5-qt5 WindowsMSVCQt5.10\install-prefix\lib\qml'XDG_DATA_DIRS = 'C:\CI\workspace\Frameworks kdeclarative kf5-qt5 WindowsMSVCQt5.10\install-prefix\share;C:\Craft\CI\windows-msvc2017_64-cl-debug\share;C:\Craft\CI\windows-msvc2017_64-cl-debug\dev-utils\share'XDG_CONFIG_DIRS   = 'C:\CI\workspace\Frameworks kdeclarative kf5-qt5 WindowsMSVCQt5.10\install-prefix\etc/xdg'PKG_CONFIG_PATH   = 'C:\Craft\CI\windows-msvc2017_64-cl-debug\lib\pkgconfig;C:\Craft\CI\windows-msvc2017_64-cl-debug\dev-utils\lib\pkgconfig'QMAKEFEATURES = 'C:\Craft\CI\windows-msvc2017_64-cl-debug\mkspecs/features'XDG_CURRENT_DESKTOP   = 'KDE'ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="C:\CI\workspace\Frameworks kdeclarative kf5-qt5 WindowsMSVCQt5.10/install-prefix/" -G "NMake Makefiles JOM"  "C:\CI\workspace\Frameworks kdeclarative kf5-qt5 WindowsMSVCQt5.10"-- The C compiler identification is MSVC 19.14.26429.4-- The CXX compiler identification is 

KDE CI: Frameworks kdeclarative kf5-qt5 SUSEQt5.10 - Build # 50 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kdeclarative%20kf5-qt5%20SUSEQt5.10/50/
 Project:
Frameworks kdeclarative kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 01 Jun 2018 09:39:08 +
 Build duration:
39 sec and counting
   CONSOLE OUTPUT
  [...truncated 68.01 KB...]USER  = 'jenkins'PAGER = 'less'BUILD_NUMBER  = '50'MORE  = '-sl'WORKSPACE = '/home/jenkins/workspace/Frameworks kdeclarative kf5-qt5 SUSEQt5.10'PWD   = '/home/jenkins/workspace/Frameworks kdeclarative kf5-qt5 SUSEQt5.10'HUDSON_URL= 'https://build.kde.org/'HOME  = '/home/jenkins/'NODE_NAME = 'Docker Swarm-311e54c8'HOST  = '311e54c8'XNLSPATH  = '/usr/X11R6/lib/X11/nls'JOB_NAME  = 'Frameworks kdeclarative kf5-qt5 SUSEQt5.10'XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'LIBGL_DEBUG   = 'quiet'HUDSON_HOME   = '/home/production/data'JOB_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks%20kdeclarative%20kf5-qt5%20SUSEQt5.10/display/redirect'PROFILEREAD   = 'true'MAIL  = '/var/mail/jenkins'LESSKEY   = '/etc/lesskey.bin'BUILD_URL = 'https://build.kde.org/job/Frameworks%20kdeclarative%20kf5-qt5%20SUSEQt5.10/50/'SHELL = '/bin/bash'STAGE_NAME= 'Configuring Build'JOB_URL   = 'https://build.kde.org/job/Frameworks%20kdeclarative%20kf5-qt5%20SUSEQt5.10/'BUILD_DISPLAY_NAME= '#50'XCURSOR_THEME = 'DMZ'SHLVL = '3'BUILD_TAG = 'jenkins-Frameworks kdeclarative kf5-qt5 SUSEQt5.10-50'NODE_LABELS   = 'Docker Swarm-311e54c8 SUSEQt5.10'LOGNAME   = 'jenkins'JRE_HOME  = '/usr/lib64/jvm/jre'XDG_CONFIG_DIRS   = '/home/jenkins/install-prefix/etc/xdg:/etc/xdg'PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'JAVA_BINDIR   = '/usr/lib64/jvm/jre/bin'G_BROKEN_FILENAMES= '1'HISTSIZE  = '1000'CPU   = 'x86_64'CVS_RSH   = 'ssh'LESSOPEN  = 'lessopen.sh %s'CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'QT_SELECT = 'qt5'XDG_CURRENT_DESKTOP   = 'KDE'ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON  "/home/jenkins/workspace/Frameworks kdeclarative kf5-qt5 SUSEQt5.10"-- The C compiler identification is GNU 7.3.1-- The CXX compiler identification is GNU 7.3.1-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Looking for __GLIBC__-- Looking for __GLIBC__ - found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- Found Gettext: /usr/bin/msgmerge (found version "0.19.8.1") CMake Error at CMakeLists.txt:31 (find_package):  By not providing "FindKF5NewStuff.cmake" in CMAKE_MODULE_PATH this project  has asked CMake to find a package configuration file provided by  "KF5NewStuff", but CMake did not find one.  Could not find a package configuration file provided by "KF5NewStuff"  (requested version 5.46.0) with any of the following names:KF5NewStuffConfig.cmakekf5newstuff-config.cmake  Add the installation prefix of "KF5NewStuff" to CMAKE_PREFIX_PATH or set  "KF5NewStuff_DIR" to a directory containing one of the above files.  If  "KF5NewStuff" provides a separate development package or SDK, be sure it  has been installed.-- Configuring incomplete, errors occurred!See also "/home/jenkins/workspace/Frameworks kdeclarative kf5-qt5 

KDE CI: Frameworks kdeclarative kf5-qt5 FreeBSDQt5.10 - Build # 8 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kdeclarative%20kf5-qt5%20FreeBSDQt5.10/8/
 Project:
Frameworks kdeclarative kf5-qt5 FreeBSDQt5.10
 Date of build:
Fri, 01 Jun 2018 09:39:08 +
 Build duration:
30 sec and counting
   CONSOLE OUTPUT
  [...truncated 45.12 KB...]HUDSON_HOME   = '/home/production/data'RUN_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks%20kdeclarative%20kf5-qt5%20FreeBSDQt5.10/8/display/redirect'XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'XDG_CONFIG_DIRS   = '/usr/home/jenkins/install-prefix/etc/xdg:/usr/local/etc/xdg'JAVA_HOME = '/usr/local/openjdk8-jre'NODE_NAME = 'FreeBSD Builder 2'BLOCKSIZE = 'K'RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks%20kdeclarative%20kf5-qt5%20FreeBSDQt5.10/8/display/redirect?page=changes'BUILD_ID  = '8'JOB_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks%20kdeclarative%20kf5-qt5%20FreeBSDQt5.10/display/redirect'USER  = 'jenkins'HOME  = '/home/jenkins'HUDSON_URL= 'https://build.kde.org/'OLDPWD= '/usr/home/jenkins'PWD   = '/usr/home/jenkins/workspace/Frameworks kdeclarative kf5-qt5 FreeBSDQt5.10'QT_PLUGIN_PATH= '/usr/home/jenkins/install-prefix/lib/plugins'CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'BUILD_TAG = 'jenkins-Frameworks kdeclarative kf5-qt5 FreeBSDQt5.10-8'_ = '/usr/local/bin/java'PKG_CONFIG_PATH   = '/usr/home/jenkins/install-prefix/lib/pkgconfig:/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'TERM  = 'su'BUILD_NUMBER  = '8'LOGNAME   = 'jenkins'JOB_URL   = 'https://build.kde.org/job/Frameworks%20kdeclarative%20kf5-qt5%20FreeBSDQt5.10/'LANG  = 'en_US.UTF-8'QML2_IMPORT_PATH  = '/usr/home/jenkins/install-prefix/lib/qml'MM_CHARSET= 'UTF-8'NODE_LABELS   = 'FreeBSD Builder 2 FreeBSDQt5.10'EXECUTOR_NUMBER   = '0'LD_LIBRARY_PATH   = '/usr/home/jenkins/install-prefix/lib'WORKSPACE = '/usr/home/jenkins/workspace/Frameworks kdeclarative kf5-qt5 FreeBSDQt5.10'JENKINS_URL   = 'https://build.kde.org/'PATH  = '/usr/home/jenkins/install-prefix/bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/home/jenkins/bin'BUILD_DISPLAY_NAME= '#8'QT_SELECT = 'qt5'SHLVL = '1'BUILD_URL = 'https://build.kde.org/job/Frameworks%20kdeclarative%20kf5-qt5%20FreeBSDQt5.10/8/'MAIL  = '/var/mail/jenkins'SHELL = '/usr/local/bin/bash'ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:symbolize=1'JOB_BASE_NAME = 'Frameworks kdeclarative kf5-qt5 FreeBSDQt5.10'XDG_CURRENT_DESKTOP   = 'KDE'JOB_NAME  = 'Frameworks kdeclarative kf5-qt5 FreeBSDQt5.10'STAGE_NAME= 'Configuring Build'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins/install-prefix/"  "/usr/home/jenkins/workspace/Frameworks kdeclarative kf5-qt5 FreeBSDQt5.10"-- The C compiler identification is Clang 4.0.0-- The CXX compiler identification is Clang 4.0.0-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Looking for __GLIBC__-- Looking for __GLIBC__ - not found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- Could not set up the appstream test. appstreamcli is missing.-- Found Gettext: /usr/local/bin/msgmerge (found version "0.19.8.1") CMake Error at CMakeLists.txt:31 (find_package):  By not providing "FindKF5NewStuff.cmake" in CMAKE_MODULE_PATH this project  has asked CMake to find a package configuration file provided by  "KF5NewStuff", but CMake did not find one.  Could not find a package configuration file provided by "KF5NewStuff"  (requested version 5.46.0) with any of the following names:KF5NewStuffConfig.cmakekf5newstuff-config.cmake  Add the installation prefix of "KF5NewStuff" to CMAKE_PREFIX_PATH or set  

D13223: Set kcm context property on the correct context

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R296:5ec7d0d83d0f: Set kcm context property on the correct 
context (authored by davidedmundson).

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13223?vs=35219=35307

REVISION DETAIL
  https://phabricator.kde.org/D13223

AFFECTED FILES
  src/quickaddons/configmodule.cpp

To: davidedmundson, #plasma, hein
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache

[Jaime Torres Amate]

jtamate updated this revision to Diff 35305.
jtamate marked 4 inline comments as done.
jtamate edited the summary of this revision.
jtamate edited the test plan for this revision.
jtamate added a comment.


  The change in kdirmodel is not needed anymore.
  The methods that were const are const again.
  Better documented the new reinsert method.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10742?vs=34775=35305

REVISION DETAIL
  https://phabricator.kde.org/D10742

AFFECTED FILES
  src/core/kcoredirlister.cpp
  src/core/kcoredirlister_p.h

To: jtamate, #frameworks, dfaure
Cc: bruns, kde-frameworks-devel, mwolff, markg, michaelh, ngraham

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 56 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/56/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 01 Jun 2018 03:35:54 +
 Build duration:
4 hr 22 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.alternativesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report24%
(5/21)30%
(17/57)30%
(17/57)20%
(437/2183)20%
(251/1281)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(4/4)100%
(4/4)90%
(140/155)54%
(102/188)src100%
(8/8)100%
(8/8)67%
(211/315)48%
(113/236)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/142)0%
(0/94)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/57)0%
(0/32)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/188)0%
(0/78)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/34)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/16)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/81)0%
(0/40)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/56)0%
(0/36)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/90)src.plugins.phabricator.quick0%
(0/6)0%
(0/6)0%
(0/86)0%
(0/59)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/242)0%
(0/80)src.plugins.reviewboard.quick0%
(0/8)0%
(0/8)0%
(0/159)0%
(0/100)src.plugins.saveas100%
(1/1)100%
(1/1)55%
(29/53)63%
(30/48)src.plugins.telegram0%
(0/1)0%
(0/1)0%
(0/55)0%
(0/32)src.plugins.youtube0%
(0/5)0%
(0/5)0%
(0/122)0%
(0/44)src.quick100%
(2/2)100%
(2/2)100%
(9/9)100%
 

D13211: Enable comparing KFileItems by url

[Jaime Torres Amate]

jtamate updated this revision to Diff 35303.
jtamate added a comment.


  Now passes the tests and its performance for non invalid items is not 
degraded too much (same +3ms inserting).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13211?vs=35192=35303

REVISION DETAIL
  https://phabricator.kde.org/D13211

AFFECTED FILES
  autotests/kfileitemtest.cpp
  autotests/kfileitemtest.h
  src/core/kfileitem.cpp
  src/core/kfileitem.h

To: jtamate, dfaure
Cc: bruns, kde-frameworks-devel, michaelh, ngraham