KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 289 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/289/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 05 Jun 2018 05:50:08 +
 Build duration:
24 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 58 test(s), Skipped: 0 test(s), Total: 58 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(294/443)66%
(294/443)53%
(31909/60029)38%
(18954/49410)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)95%
(8833/9263)50%
(5582/11155)autotests.http100%
(9/9)100%
(9/9)99%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core84%
(100/119)84%
(100/119)58%
(8390/14484)50%
(4902/9798)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets78%
(31/40)78%
(31/40)49%
(3917/7918)33%
(1655/4966)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(527/1015)42%
(422/1012)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/107)0%
(0/77)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1784/4339)35%
(1381/3995)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%
(7/11)64%
(7/11)52%
(723/13

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 45 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/45/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 05 Jun 2018 05:50:08 +
 Build duration:
6 min 51 sec and counting
   JUnit Tests
  Name: (root) Failed: 4 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

KDE CI: Frameworks kservice kf5-qt5 SUSEQt5.10 - Build # 34 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20SUSEQt5.10/34/
 Project:
Frameworks kservice kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 05 Jun 2018 05:36:58 +
 Build duration:
6 min 41 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.kplugininfotestFailed: TestSuite.kservicetestFailed: TestSuite.ksycocathreadtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report75%
(6/8)83%
(73/88)83%
(73/88)68%
(5508/8117)48%
(3182/6680)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(13/14)93%
(13/14)84%
(1307/1560)45%
(907/2007)src.kbuildsycoca100%
(1/1)100%
(1/1)92%
(54/59)68%
(15/22)src.kdeinit0%
(0/2)0%
(0/2)0%
(0/334)0%
(0/278)src.plugin67%
(2/3)67%
(2/3)49%
(47/96)42%
(44/106)src.services97%
(29/30)97%
(29/30)61%
(1849/3036)41%
(818/1982)src.sycoca83%
(25/30)83%
(25/30)77%
(2143/2794)62%
(1365/2197)tests0%
(0/5)0%
(0/5)0%
(0/118)0%
(0/40)tests.pluginlocator100%
(3/3)100%
(3/3)90%
(108/120)69%
(33/48)

KDE CI: Frameworks kservice kf5-qt5 FreeBSDQt5.10 - Build # 9 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20FreeBSDQt5.10/9/
 Project:
Frameworks kservice kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 05 Jun 2018 05:36:58 +
 Build duration:
1 min 30 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 10 test(s)Failed: TestSuite.kmimeassociationstest

KDE CI: Frameworks kservice kf5-qt5 SUSEQt5.10 - Build # 33 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20SUSEQt5.10/33/
 Project:
Frameworks kservice kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 05 Jun 2018 05:05:20 +
 Build duration:
2 min 10 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.kplugininfotestFailed: TestSuite.kservicetestFailed: TestSuite.ksycocathreadtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report75%
(6/8)83%
(73/88)83%
(73/88)68%
(5508/8116)48%
(3183/6678)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(13/14)93%
(13/14)84%
(1307/1560)45%
(907/2007)src.kbuildsycoca100%
(1/1)100%
(1/1)92%
(54/59)68%
(15/22)src.kdeinit0%
(0/2)0%
(0/2)0%
(0/334)0%
(0/278)src.plugin67%
(2/3)67%
(2/3)49%
(47/96)42%
(44/106)src.services97%
(29/30)97%
(29/30)61%
(1849/3036)41%
(818/1982)src.sycoca83%
(25/30)83%
(25/30)77%
(2143/2793)62%
(1366/2195)tests0%
(0/5)0%
(0/5)0%
(0/118)0%
(0/40)tests.pluginlocator100%
(3/3)100%
(3/3)90%
(108/120)69%
(33/48)

KDE CI: Frameworks kservice kf5-qt5 FreeBSDQt5.10 - Build # 8 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20FreeBSDQt5.10/8/
 Project:
Frameworks kservice kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 05 Jun 2018 05:05:20 +
 Build duration:
1 min 37 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 10 test(s)Failed: TestSuite.kmimeassociationstest

D13343: Properly reset plugins

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Thanks ^^'

REPOSITORY
  R495 Purpose Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13343

To: elvisangelaccio, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13315: Detect mime type of local files based on their contents

[Miklós Máté]

miklosm added inline comments.

INLINE COMMENTS

> broulik wrote in kfileitem.cpp:730
> That and also (broken) NFS mounts. We have that in quite a few places where 
> seemingly innocent local files can freeze the entire UI, so I'd rather not 
> introduce another place where this may happen.

> FUSE appears as local urls and it's slow.

People still use FUSE?? If the connection is lost, it sends all processes 
trying to access that volume into uninterruptable sleep.

> seemingly innocent local files can freeze the entire UI

KFileItem::determineMimeType() promises proper mime type detection, and that 
can only be achieved by reading into the file. I agree that potentially long 
operations should be performed in a background thread, but the KFileItem API 
doesn't allow such a change, so it's the responsibility of the callers of this 
method.

BTW the currentMimeType() method shouldn't do any detection. It's very 
misleading, and when there are multiple candidates, choosing the first one on 
the list is not "accurate" or "real determination".

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13315

To: miklosm, #frameworks, dfaure
Cc: broulik, ngraham, apol, kde-frameworks-devel, michaelh, bruns

D13216: Overhaul the file index scheduler.

[James Smith]

smithjd added a reviewer: bruns.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13216

To: smithjd, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns

D13342: Fix regression when pasting binary data from clipboard

[Elvis Angelaccio]

elvisangelaccio created this revision.
elvisangelaccio added a reviewer: dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
elvisangelaccio requested review of this revision.

REVISION SUMMARY
  Commit b73355da3f 
 
broke pasting of binary data when the destination does
  not already exist. If the StatJob fails, we need to use the URL provided
  as user input, rather than an empty URL.

TEST PLAN
  Paste something from clipboard in dolphin.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13342

AFFECTED FILES
  src/widgets/paste.cpp

To: elvisangelaccio, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13343: Properly reset plugins

[Elvis Angelaccio]

elvisangelaccio created this revision.
elvisangelaccio added a reviewer: apol.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
elvisangelaccio requested review of this revision.

REVISION SUMMARY
  This patch fixes a small regression of commit 727ce79c81 
.

TEST PLAN
  Run `alternativesmodeltest` before/after the patch.

REPOSITORY
  R495 Purpose Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13343

AFFECTED FILES
  src/alternativesmodel.cpp

To: elvisangelaccio, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13268: Add signal for devices's address changing

[David Rosca]

drosca added a comment.


  Do you have a dev account?

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D13268

To: andreysemenov, drosca
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13268: Add signal for devices's address changing

[Andrey Semenov]

andreysemenov added a comment.


  In D13268#273515 , @drosca wrote:
  
  > Do you have a dev account?
  
  
  I think i don't.

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D13268

To: andreysemenov, drosca
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12520: [PasteJob] Emit KDirNotify on paste

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> elvisangelaccio wrote in paste.cpp:125
> Missing  `this` as the receiver argument?

This is a `static` so there's no `this` and we also just access `job` and then 
call another `static` method

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12520

To: broulik, #frameworks
Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D13268: Add signal for devices's address changing

[Andrey Semenov]

andreysemenov added a comment.


  In D13268#273519 , @drosca wrote:
  
  > In D13268#273516 , 
@andreysemenov wrote:
  >
  > > In D13268#273515 , @drosca 
wrote:
  > >
  > > > Do you have a dev account?
  > >
  > >
  > > I think i don't.
  >
  >
  > Ok, your name and e-mail please so I can commit it for you.
  
  
  Andrey Semenov blizk...@gmail.com

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D13268

To: andreysemenov, drosca
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13328: A backend is required for kdnssd

[Adriaan de Groot]

adridg edited the test plan for this revision.

REPOSITORY
  R272 KDNSSD

REVISION DETAIL
  https://phabricator.kde.org/D13328

To: adridg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13268: Add signal for devices's address changing

[David Rosca]

drosca added a comment.


  In D13268#273516 , @andreysemenov 
wrote:
  
  > In D13268#273515 , @drosca wrote:
  >
  > > Do you have a dev account?
  >
  >
  > I think i don't.
  
  
  Ok, your name and e-mail please so I can commit it for you.

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D13268

To: andreysemenov, drosca
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13268: Add signal for devices's address changing

[David Rosca]

This revision was automatically updated to reflect the committed changes.
Closed by commit R269:41b41939c028: Add signal for devices's address 
changing (authored by andreysemenov, committed by drosca).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D13268?vs=35331&id=35511#toc

REPOSITORY
  R269 BluezQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13268?vs=35331&id=35511

REVISION DETAIL
  https://phabricator.kde.org/D13268

AFFECTED FILES
  src/device.h
  src/device_p.cpp
  src/device_p.h

To: andreysemenov, drosca
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13268: Add signal for devices's address changing

[Andrey Semenov]

andreysemenov removed a reviewer: mlaurent.

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D13268

To: andreysemenov, drosca, mlaurent
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13328: A backend is required for kdnssd

[Albert Astals Cid]

aacid added a comment.


  I'm with you that having a possibility to just compile kdnssd without any 
backend may be of value so i would either not commit this or improve the cmake 
so there's a way to say I_KNOW_WHAT_I_AM_DOING_KEEP_GOING

REPOSITORY
  R272 KDNSSD

REVISION DETAIL
  https://phabricator.kde.org/D13328

To: adridg
Cc: aacid, cgiboudeaux, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 59 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/59/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 04 Jun 2018 20:08:37 +
 Build duration:
7 min 10 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.alternativesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report24%
(5/21)30%
(17/57)30%
(17/57)21%
(454/2193)20%
(263/1301)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(4/4)100%
(4/4)92%
(142/155)56%
(105/188)src100%
(8/8)100%
(8/8)69%
(224/325)48%
(122/256)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/142)0%
(0/94)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/57)0%
(0/32)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/188)0%
(0/78)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/34)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/16)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/81)0%
(0/40)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/56)0%
(0/36)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/90)src.plugins.phabricator.quick0%
(0/6)0%
(0/6)0%
(0/86)0%
(0/59)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/242)0%
(0/80)src.plugins.reviewboard.quick0%
(0/8)0%
(0/8)0%
(0/159)0%
(0/100)src.plugins.saveas100%
(1/1)100%
(1/1)58%
(31/53)63%
(30/48)src.plugins.telegram0%
(0/1)0%
(0/1)0%
(0/55)0%
(0/32)src.plugins.youtube0%
(0/5)0%
(0/5)0%
(0/122)0%
(0/44)src.quick100%
(2/2)100%
(2/2)100%
(9/9)100%

D13308: Filter out duplicate plugins

[Elvis Angelaccio]

This revision was automatically updated to reflect the committed changes.
Closed by commit R495:727ce79c815d: Filter out duplicate plugins (authored by 
elvisangelaccio).

REPOSITORY
  R495 Purpose Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13308?vs=35472&id=35557

REVISION DETAIL
  https://phabricator.kde.org/D13308

AFFECTED FILES
  src/alternativesmodel.cpp

To: elvisangelaccio, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks purpose kf5-qt5 FreeBSDQt5.10 - Build # 24 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20FreeBSDQt5.10/24/
 Project:
Frameworks purpose kf5-qt5 FreeBSDQt5.10
 Date of build:
Mon, 04 Jun 2018 20:08:37 +
 Build duration:
1 min 54 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.alternativesmodeltest

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 35 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/35/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 04 Jun 2018 20:08:37 +
 Build duration:
2 min 14 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.alternativesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report24%
(5/21)30%
(17/57)30%
(17/57)21%
(471/2193)22%
(283/1301)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(4/4)100%
(4/4)88%
(136/155)54%
(101/188)src100%
(8/8)100%
(8/8)76%
(247/325)57%
(146/256)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/142)0%
(0/94)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/57)0%
(0/32)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/188)0%
(0/78)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/34)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/16)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/81)0%
(0/40)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/56)0%
(0/36)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/90)src.plugins.phabricator.quick0%
(0/6)0%
(0/6)0%
(0/86)0%
(0/59)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/242)0%
(0/80)src.plugins.reviewboard.quick0%
(0/8)0%
(0/8)0%
(0/159)0%
(0/100)src.plugins.saveas100%
(1/1)100%
(1/1)58%
(31/53)63%
(30/48)src.plugins.telegram0%
(0/1)0%
(0/1)0%
(0/55)0%
(0/32)src.plugins.youtube0%
(0/5)0%
(0/5)0%
(0/122)0%
(0/44)src.quick100%
(2/2)100%
(2/2)100%
(9/9)100%
  

D13215: FrameSVG: Recache maskFrame if enabledBorders has been changed

[Vlad Zagorodniy]

zzag updated this revision to Diff 35542.
zzag added a comment.


  Rebase.

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13215?vs=35338&id=35542

BRANCH
  fix-framesvg-alphamask

REVISION DETAIL
  https://phabricator.kde.org/D13215

AFFECTED FILES
  src/plasma/framesvg.cpp

To: zzag, #plasma, #frameworks
Cc: abetts, mart, aseigo, broulik, kde-frameworks-devel, michaelh, ngraham, 
bruns

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 169 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/169/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 04 Jun 2018 16:49:18 +
 Build duration:
6 min 24 sec and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)26%
(3558/13467)19%
(1977/10653)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(607/1140)28%
(421/1492)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/473)0%
(0/265)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(253/2246)7%
(102/1496)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/525)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1441/3528)28%
(826/2957)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)41%
(671/1621)28%
(317/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)27%
(555/2020)17%
(306/1781)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1179)0%
(0/1058)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%
 

D13287: FrameSVG: Delete redundant checks

[Vlad Zagorodniy]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:b169aa50f917: FrameSVG: Delete redundant checks (authored 
by zzag).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13287?vs=35414&id=35541

REVISION DETAIL
  https://phabricator.kde.org/D13287

AFFECTED FILES
  src/plasma/framesvg.cpp

To: zzag, #plasma, #frameworks, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13286: FrameSVG: Fix QObject include

[Vlad Zagorodniy]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:a363815a796a: FrameSVG: Fix QObject include (authored by 
zzag).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13286?vs=35413&id=35540

REVISION DETAIL
  https://phabricator.kde.org/D13286

AFFECTED FILES
  src/plasma/framesvg.h

To: zzag, #plasma, #frameworks, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13287: FrameSVG: Delete redundant checks

[Vlad Zagorodniy]

zzag added a comment.


  In D13287#273556 , @apol wrote:
  
  > :( am I not plasma enough?
  
  
  Sorry, I still don't know who is who. :D

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  framesvg-redundant-checks

REVISION DETAIL
  https://phabricator.kde.org/D13287

To: zzag, #plasma, #frameworks, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13216: Overhaul the file index scheduler.

[James Smith]

smithjd added a reviewer: mgallien.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13216

To: smithjd, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns

D13328: A backend is required for kdnssd

[Adriaan de Groot]

adridg updated this revision to Diff 35524.
adridg added a comment.


  Use the right place (sorry Christophe, to use a Dutch phrase:
  I must have been looking with my nose).

REPOSITORY
  R272 KDNSSD

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13328?vs=35514&id=35524

BRANCH
  require-backend

REVISION DETAIL
  https://phabricator.kde.org/D13328

AFFECTED FILES
  CMakeLists.txt

To: adridg
Cc: cgiboudeaux, kde-frameworks-devel, michaelh, ngraham, bruns

D13328: A backend is required for kdnssd

[Christophe Giboudeaux]

cgiboudeaux added inline comments.

INLINE COMMENTS

> adridg wrote in CMakeLists.txt:65-66
> Hi. If you're posting a review, please provide constructive input. If there 
> are policies or guidelines about places, please link to them. If there 
> aren't, but you would prefer a change, please describe the (outline of the) 
> change. If you mean "there should be an additional space in the else() 
> statement to match the text formatting from line 57", then write that.

your else() follows if (IS_DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}/po"), I 
thought the comment was clear.

Your current patch means:  if there's no "po" subdir, throw a fatal error with 
an unrelated message.

REPOSITORY
  R272 KDNSSD

REVISION DETAIL
  https://phabricator.kde.org/D13328

To: adridg
Cc: cgiboudeaux, kde-frameworks-devel, michaelh, ngraham, bruns

D13328: A backend is required for kdnssd

[Adriaan de Groot]

adridg added inline comments.

INLINE COMMENTS

> cgiboudeaux wrote in CMakeLists.txt:65-66
> wrong place

Hi. If you're posting a review, please provide constructive input. If there are 
policies or guidelines about places, please link to them. If there aren't, but 
you would prefer a change, please describe the (outline of the) change. If you 
mean "there should be an additional space in the else() statement to match the 
text formatting from line 57", then write that.

REPOSITORY
  R272 KDNSSD

REVISION DETAIL
  https://phabricator.kde.org/D13328

To: adridg
Cc: cgiboudeaux, kde-frameworks-devel, michaelh, ngraham, bruns

D13287: FrameSVG: Delete redundant checks

[Aleix Pol Gonzalez]

apol added a comment.


  :( am I not plasma enough?

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  framesvg-redundant-checks

REVISION DETAIL
  https://phabricator.kde.org/D13287

To: zzag, #plasma, #frameworks, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13328: A backend is required for kdnssd

[Christophe Giboudeaux]

cgiboudeaux added inline comments.

INLINE COMMENTS

> CMakeLists.txt:65-66
>  ecm_install_po_files_as_qm(po)
> +else()
> +message(FATAL_ERROR "Either Avahi or DNSSD is required for KDE 
> applications to make use of multicast DNS/DNS-SD service discovery")
>  endif()

wrong place

REPOSITORY
  R272 KDNSSD

REVISION DETAIL
  https://phabricator.kde.org/D13328

To: adridg
Cc: cgiboudeaux, kde-frameworks-devel, michaelh, ngraham, bruns

D13328: A backend is required for kdnssd

[Adriaan de Groot]

adridg added a comment.


  Something to consider, though, is that it might perhaps be useful to have 
kdnssd build -- without a backend -- for environments where there is no real 
dnssd and any service discovery returns "not found". Requiring a backend makes 
that impossible.
  
  (So something else to do is to install avahi on the openSUSE and other Linux 
KDE CI machines)

REPOSITORY
  R272 KDNSSD

REVISION DETAIL
  https://phabricator.kde.org/D13328

To: adridg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13328: A backend is required for kdnssd

[Adriaan de Groot]

adridg created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
adridg requested review of this revision.

REVISION SUMMARY
  Refuse to build if there are no backends for DNSSD at all. The messages for 
the OPTIONAL backeds mention that one is required, but it wasn't enforced. KDE 
CI has been building with no backend configured for some time.

TEST PLAN
  Configure without as backend:
cmake -DCMAKE_DISABLE_FIND_PACKAGE_Avahi=1 \
  
-DCMAKE_DISABLE_FIND_PACKAGE_DNSSD=1
  
  note that the backend requirements are optional, but one is required.

REPOSITORY
  R272 KDNSSD

BRANCH
  require-backend

REVISION DETAIL
  https://phabricator.kde.org/D13328

AFFECTED FILES
  CMakeLists.txt

To: adridg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13327: Fix conversion error when compiled against MDNSRESPONDER option

[Harald Sitter]

sitter added a comment.


  `-DQT_NO_CAST_FROM_BYTEARRAY` is a default define from 
`KDEFrameworkCompilerSettings.cmake`, so kdnssd should be working. The reason 
it wasn't is likely because most/all distributions build with avahi. 
Additionally, build.kde.org seems to build without avahi and dnssd, so it 
doesn't validate half the code at all 😒
  
  With all that said, the change looks good.
  
  qUtf8Printable  might be 
nicer to read than `qString.toUtf8().constData()` though, might be worth 
thinking about.

INLINE COMMENTS

> mdnsd-publicservice.cpp:163
>  for (QMap::ConstIterator it = 
> d->m_textData.cbegin(); it != itEnd; ++it) {
> -if (TXTRecordSetValue(&txt, it.key().toUtf8(), it.value().length(), 
> it.value()) != kDNSServiceErr_NoError) {
> +if (TXTRecordSetValue(&txt, it.key().toUtf8().constData(), 
> it.value().length(), it.value().data()) != kDNSServiceErr_NoError) {
>  TXTRecordDeallocate(&txt);

Is there a reason the second call is going to `data()` rather than 
`constData()`? There is `const char *data() const` so it ultimately makes no 
difference, for code expressiveness I would say all calls should be to 
`constData()` though.

REPOSITORY
  R272 KDNSSD

REVISION DETAIL
  https://phabricator.kde.org/D13327

To: adridg
Cc: sitter, kde-frameworks-devel, michaelh, ngraham, bruns

D13191: [server] Small code cleanup in SurfaceInterface

[Roman Gilg]

romangg edited the summary of this revision.

REPOSITORY
  R127 KWayland

BRANCH
  surfaceCodeCleanup

REVISION DETAIL
  https://phabricator.kde.org/D13191

To: romangg, #plasma, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D13191: [server] Small code cleanup in SurfaceInterface

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R127 KWayland

BRANCH
  surfaceCodeCleanup

REVISION DETAIL
  https://phabricator.kde.org/D13191

To: romangg, #plasma, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D13327: Fix conversion error when compiled against MDNSRESPONDER option

[Adriaan de Groot]

adridg created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
adridg requested review of this revision.

REVISION SUMMARY
  If QT_NO_CAST_FROM_BYTEARRAY is set, along with using MDNSRESPONDER,
  then the implicit cast from QByteArray to const char * is not available.
  The MDNSRESPONDER API uses const char * parameters and kdnssd passes
  QByteArray to them.  Make the necessary conversion explicit.
  
  Submitted downstream in FreeBSD by Ashish SHUKLA

TEST PLAN
  - builds ok, unpatched, with QT_NO_CAST_FROM_BYTEARRAY against AVAHI
  - build fails, unpatched, with QT_NO.. against MDNSRESPONDER
  - build succees, patched, with QT_NO.. against MDNS..

REPOSITORY
  R272 KDNSSD

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13327

AFFECTED FILES
  src/mdnsd-publicservice.cpp
  src/mdnsd-remoteservice.cpp
  src/mdnsd-servicebrowser.cpp

To: adridg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 167 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/167/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 04 Jun 2018 08:33:29 +
 Build duration:
8 min 11 sec and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)26%
(3561/13471)19%
(1979/10661)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(609/1140)28%
(421/1492)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/473)0%
(0/265)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(253/2246)7%
(102/1496)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/525)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1442/3532)28%
(827/2965)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)41%
(671/1621)28%
(318/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)27%
(555/2020)17%
(306/1781)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1179)0%
(0/1058)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%
 

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 - Build # 19 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.10/19/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10
 Date of build:
Mon, 04 Jun 2018 08:33:29 +
 Build duration:
3 min 35 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

D13222: Use QDateTime for interfacing with QML

[Fabian Vogt]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:d15f0fa8322d: Use QDateTime for interfacing with QML 
(authored by fvogt).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13222?vs=35217&id=35509

REVISION DETAIL
  https://phabricator.kde.org/D13222

AFFECTED FILES
  src/declarativeimports/calendar/calendar.cpp
  src/declarativeimports/calendar/calendar.h

To: fvogt, #plasma, #frameworks, davidedmundson
Cc: ngraham, Zren, sharvey, kde-frameworks-devel, michaelh, bruns

D13222: Use QDateTime for interfacing with QML

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13222

To: fvogt, #plasma, #frameworks, davidedmundson
Cc: ngraham, Zren, sharvey, kde-frameworks-devel, michaelh, bruns

D13287: FrameSVG: Delete redundant checks

[Vlad Zagorodniy]

zzag added a comment.


  @apol Do I need to wait for other reviewers (from plasma)? Or I can land it 
right away?

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  framesvg-redundant-checks

REVISION DETAIL
  https://phabricator.kde.org/D13287

To: zzag, #plasma, #frameworks, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13315: Detect mime type of local files based on their contents

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> apol wrote in kfileitem.cpp:730
> I'm not sure that makes sense. The fact that it's a local url doesn't mean it 
> will be fast to read.
> FUSE appears as local urls and it's slow.

That and also (broken) NFS mounts. We have that in quite a few places where 
seemingly innocent local files can freeze the entire UI, so I'd rather not 
introduce another place where this may happen.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13315

To: miklosm, #frameworks, dfaure
Cc: broulik, ngraham, apol, kde-frameworks-devel, michaelh, bruns