D13535: Do not cancel old clipboard selection if it is same as the new one.

[Roman Gilg]

romangg added a comment.


  In D13535#278441 , @fvogt wrote:
  
  > in TestDataDevice::testReplaceSource() and it fails without this patch.
  >  With this patch however, the selection isn't offered (is that correct 
behaviour?) so the wait() times out.
  >  Is there a better way to test this?
  
  
  I did some research and yes, it's the correct behavior in my opinion: 
selectionOffered is emitted on receiving a selection event. According to 
Wayland documentation:
  
  > The selection event is sent out to notify the client of a new wl_data_offer 
for the selection for this device.
  
  Since there is no new selection the old wl_data_source and wl_data_offer do 
still exist (selection->cancel() just below your insertion was never called) 
and a new selection event won't get sent.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D13535

To: fvogt, #plasma, #frameworks
Cc: romangg, graesslin, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 175 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/175/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 16 Jun 2018 21:31:56 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)26%
(3560/13477)19%
(1978/10667)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(609/1140)28%
(421/1492)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/473)0%
(0/265)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(253/2246)7%
(102/1496)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/525)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1441/3535)28%
(826/2957)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)41%
(671/1621)28%
(318/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)27%
(555/2020)17%
(306/1781)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1182)0%
(0/1072)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%
   

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 - Build # 26 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.10/26/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10
 Date of build:
Sat, 16 Jun 2018 21:31:56 +
 Build duration:
2 min 4 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

D13510: Add XDG WM Base support to our XDGShell API

[David Edmundson]

davidedmundson added a comment.


  > XDG_SURFACE_ERROR_ALREADY_CONSTRUCTED
  
  I'm not sure. There's an implication that XDG_SURFACE errors are meant for in 
response to requests on an xdg_surface interface, (i.e for use with 
xdg_surface.get_toplevel xdg_surface.get_popup)  whereas this is a callback on 
the wm_base interface.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D13510

To: davidedmundson, #kwin
Cc: romangg, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D13510: Add XDG WM Base support to our XDGShell API

[David Edmundson]

davidedmundson updated this revision to Diff 36244.
davidedmundson added a comment.


  use static_cast in client

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13510?vs=36206=36244

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13510

AFFECTED FILES
  autotests/client/CMakeLists.txt
  autotests/client/test_xdg_shell.cpp
  autotests/client/test_xdg_shell_stable.cpp
  src/client/CMakeLists.txt
  src/client/protocols/xdg-shell.xml
  src/client/registry.cpp
  src/client/registry.h
  src/client/xdgshell.cpp
  src/client/xdgshell.h
  src/client/xdgshell_p.h
  src/client/xdgshell_stable.cpp
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/xdgshell_interface.h
  src/server/xdgshell_stable_interface.cpp
  src/server/xdgshell_stable_interface_p.h

To: davidedmundson, #kwin
Cc: romangg, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D13394: C++: update for c++20 and fix some syntax errors

[Christoph Cullmann]

cullmann added a comment.


  Will take a look ;=)

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D13394

To: jpoelen, dhaumann
Cc: cullmann, kde-frameworks-devel, michaelh, ngraham, bruns

D13571: Correct KFormat::formatBytes examples

[Stefan Brüns]

bruns created this revision.
bruns added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The example left out the "precision" parameter, reported values where
  wrong (values are rounded, not truncated). The precision parameter is
  ignored for values less than 1000 resp. 1024.

TEST PLAN
  make test

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13571

AFFECTED FILES
  autotests/kformattest.cpp
  src/lib/util/kformat.h

To: bruns, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13570: Add workaround for labels with word-wrapping

[Elvis Angelaccio]

elvisangelaccio created this revision.
elvisangelaccio added a reviewer: davidedmundson.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
elvisangelaccio requested review of this revision.

REVISION SUMMARY
  It's not clear why, but the combination of a word-wrapped QLabel with
  the `setFocusPolicy()` call in `overrideFocusPolicyOf()` seems to break
  the positioning of the groupbox in its parent layout.
  
  Until we understand where the bug is and how to fix it, we can toggle
  the groupbox twice when we detect that a QLabel with word-wrapping
  enabled has been added as child. Not clear why (again), but this fixes
  (or at least hides) the issue.

TEST PLAN
  Apply the patch, then run `kcollapsiblegroupboxtest` with/without the 
workaround compiled in.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  workaround-wordwrap (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D13570

AFFECTED FILES
  src/kcollapsiblegroupbox.cpp
  tests/kcollapsiblegroupboxtest.cpp

To: elvisangelaccio, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13394: C++: update for c++20 and fix some syntax errors

[jonathan poelen]

jpoelen updated this revision to Diff 36229.
jpoelen added a comment.


  - C++: test with clang:: in an attribute

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13394?vs=35729=36229

BRANCH
  cpp

REVISION DETAIL
  https://phabricator.kde.org/D13394

AFFECTED FILES
  autotests/folding/example.rmd.fold
  autotests/folding/folding.cpp.fold
  autotests/folding/highlight.cpp.fold
  autotests/folding/highlight.lex.fold
  autotests/folding/highlight.y.fold
  autotests/folding/preprocessor-bug363280.cpp.fold
  autotests/html/folding.cpp.html
  autotests/html/highlight.cpp.html
  autotests/input/highlight.cpp
  autotests/reference/folding.cpp.ref
  autotests/reference/highlight.cpp.ref
  data/syntax/gcc.xml
  data/syntax/isocpp.xml

To: jpoelen, dhaumann
Cc: cullmann, kde-frameworks-devel, michaelh, ngraham, bruns

D13541: Port solid from Qt5::Widgets to Qt5::Gui

[Kai Uwe Broulik]

broulik accepted this revision.

REPOSITORY
  R245 Solid

BRANCH
  gui-instead-of-widgets

REVISION DETAIL
  https://phabricator.kde.org/D13541

To: graesslin, #frameworks, dhaumann, apol, broulik
Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kfilemetadata kf5-qt5 WindowsMSVCQt5.10 - Build # 33 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kfilemetadata%20kf5-qt5%20WindowsMSVCQt5.10/33/
 Project:
Frameworks kfilemetadata kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Sat, 16 Jun 2018 10:13:09 +
 Build duration:
5 min 57 sec and counting
   CONSOLE OUTPUT
  [...truncated 178.41 KB...]   Creating library ..\..\lib\kfilemetadata_odfextractor.lib and object ..\..\lib\kfilemetadata_odfextractor.exp   Creating library ..\..\lib\kfilemetadata_odfextractor.lib and object ..\..\lib\kfilemetadata_odfextractor.exp[ 50%] Built target kfilemetadata_odfextractorScanning dependencies of target kfilemetadata_plaintextextractor[ 52%] Building CXX object src/extractors/CMakeFiles/kfilemetadata_plaintextextractor.dir/plaintextextractor.cpp.obj[ 52%] Building CXX object src/extractors/CMakeFiles/kfilemetadata_plaintextextractor.dir/kfilemetadata_plaintextextractor_autogen/mocs_compilation.cpp.objplaintextextractor.cppC:\CI\workspace\Frameworks kfilemetadata kf5-qt5 WindowsMSVCQt5.10\src\extractors\plaintextextractor.cpp(119): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of datamocs_compilation.cpp[ 52%] Linking CXX shared module ..\..\bin\kf5\kfilemetadata\kfilemetadata_plaintextextractor.dll   Creating library ..\..\lib\kfilemetadata_plaintextextractor.lib and object ..\..\lib\kfilemetadata_plaintextextractor.exp   Creating library ..\..\lib\kfilemetadata_plaintextextractor.lib and object ..\..\lib\kfilemetadata_plaintextextractor.exp[ 52%] Built target kfilemetadata_plaintextextractorScanning dependencies of target kfilemetadata_poextractor[ 53%] Building CXX object src/extractors/CMakeFiles/kfilemetadata_poextractor.dir/poextractor.cpp.obj[ 54%] Building CXX object src/extractors/CMakeFiles/kfilemetadata_poextractor.dir/kfilemetadata_poextractor_autogen/mocs_compilation.cpp.objpoextractor.cppC:\CI\workspace\Frameworks kfilemetadata kf5-qt5 WindowsMSVCQt5.10\src\extractors\poextractor.cpp(154): warning C4267: 'argument': conversion from 'size_t' to 'quint32', possible loss of dataC:\CI\workspace\Frameworks kfilemetadata kf5-qt5 WindowsMSVCQt5.10\src\extractors\poextractor.cpp(163): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of dataC:\CI\workspace\Frameworks kfilemetadata kf5-qt5 WindowsMSVCQt5.10\src\extractors\poextractor.cpp(165): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of dataC:\CI\workspace\Frameworks kfilemetadata kf5-qt5 WindowsMSVCQt5.10\src\extractors\poextractor.cpp(167): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of datamocs_compilation.cpp[ 55%] Linking CXX shared module ..\..\bin\kf5\kfilemetadata\kfilemetadata_poextractor.dll   Creating library ..\..\lib\kfilemetadata_poextractor.lib and object ..\..\lib\kfilemetadata_poextractor.exp   Creating library ..\..\lib\kfilemetadata_poextractor.lib and object ..\..\lib\kfilemetadata_poextractor.exp[ 55%] Built target kfilemetadata_poextractorScanning dependencies of target kfilemetadata_taglibwriter[ 56%] Building CXX object src/writers/CMakeFiles/kfilemetadata_taglibwriter.dir/kfilemetadata_taglibwriter_autogen/mocs_compilation.cpp.obj[ 56%] Building CXX object src/writers/CMakeFiles/kfilemetadata_taglibwriter.dir/taglibwriter.cpp.objtaglibwriter.cppmocs_compilation.cpp[ 57%] Linking CXX shared module ..\..\bin\kfilemetadata_taglibwriter.dll   Creating library ..\..\lib\kfilemetadata_taglibwriter.lib and object ..\..\lib\kfilemetadata_taglibwriter.exp   Creating library ..\..\lib\kfilemetadata_taglibwriter.lib and object ..\..\lib\kfilemetadata_taglibwriter.exp[ 57%] Built target kfilemetadata_taglibwriterScanning dependencies of target indexextractortest[ 58%] Building CXX object autotests/CMakeFiles/indexextractortest.dir/indexerextractortests.cpp.obj[ 60%] Building CXX object autotests/CMakeFiles/indexextractortest.dir/__/src/extractors/plaintextextractor.cpp.obj[ 60%] Building CXX object autotests/CMakeFiles/indexextractortest.dir/indexextractortest_autogen/mocs_compilation.cpp.objindexerextractortests.cppmocs_compilation.cppplaintextextractor.cppC:\CI\workspace\Frameworks kfilemetadata kf5-qt5 WindowsMSVCQt5.10\src\extractors\plaintextextractor.cpp(119): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data[ 61%] Linking CXX executable ..\bin\indexextractortest.exe   Creating library ..\lib\indexextractortest.lib and object ..\lib\indexextractortest.exp   Creating library ..\lib\indexextractortest.lib and object ..\lib\indexextractortest.exp[ 61%] Built target indexextractortestScanning dependencies of target odfextractortest[ 64%] Building CXX object autotests/CMakeFiles/odfextractortest.dir/odfextractortest.cpp.obj[ 64%] Building CXX object autotests/CMakeFiles/odfextractortest.dir/__/src/extractors/odfextractor.cpp.obj[ 64%] Building CXX object 

D12320: add ability to read embedded cover files

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:885616cee7a0: add ability to read embedded cover files 
(authored by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12320?vs=35940=36219

REVISION DETAIL
  https://phabricator.kde.org/D12320

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/embeddedimagedatatest.cpp
  autotests/embeddedimagedatatest.h
  autotests/samplefiles/test.mpc
  src/CMakeLists.txt
  src/embeddedimagedata.cpp
  src/embeddedimagedata.h

To: astippich, mgallien, michaelh, bruns
Cc: anthonyfieroni, kde-frameworks-devel, #baloo, bruns, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, abrahams