D13585: Use LIB_SUFFIX for lmdb libdir rather than hardcode lib

2018-06-17 Thread Pino Toscano 
pino added a comment.


  In D13585#279400 , @asturmlechner 
wrote:
  
  > The problem with that is cmake picking the wrong dir (first in order is 
`lib`, while it should be e.g. `lib64`).
  
  
  Sure, and that's why I suggested to drop the usage of `LMDB_DIR`. There is 
already `CMAKE_PREFIX_PATH` 
 to 
specify additional prefixes where to search for installed software, so 
`LMDB_DIR` is simply an ad-hoc version of it.
  In case this is the chosen way, make sure to port away from where `LMDB_DIR` 
is used: https://lxr.kde.org/search?_filestring=&_string=LMDB_DIR

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13585

To: asturmlechner, #baloo
Cc: pino, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D13585: Use LIB_SUFFIX for lmdb libdir rather than hardcode lib

2018-06-17 Thread Andreas Sturmlechner 
asturmlechner added a comment.


  The problem with that is cmake picking the wrong dir (first in order is 
`lib`, while it should be e.g. `lib64`).

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13585

To: asturmlechner, #baloo
Cc: pino, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 - Build # 27 - Still Unstable!

2018-06-17 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.10/27/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10
 Date of build:
Mon, 18 Jun 2018 03:30:05 +
 Build duration:
16 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

D13585: Use LIB_SUFFIX for lmdb libdir rather than hardcode lib

2018-06-17 Thread Pino Toscano 
pino added a comment.


  Or just drop the two `HINTS` (for `find_path` and `find_library`) altogether, 
as cmake already looks in standard include/library paths.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13585

To: asturmlechner, #baloo
Cc: pino, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D13460: implement the lyrics tag for taglibextractor

2018-06-17 Thread Stefan Brüns 
bruns accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R286 KFileMetaData

BRANCH
  lyrics

REVISION DETAIL
  https://phabricator.kde.org/D13460

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D12233: Avoid manipulation of lists with quadratic complexity

2018-06-17 Thread Stefan Brüns 
bruns added a comment.


  Still waiting for a final review ...

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D12233

To: bruns, #baloo, michaelh
Cc: dhaumann, ngraham, kde-frameworks-devel, jtamate, bruns, ashaposhnikov, 
michaelh, astippich, spoorun, abrahams

D13585: Use LIB_SUFFIX for lmdb libdir rather than hardcode lib

2018-06-17 Thread Andreas Sturmlechner 
asturmlechner added a comment.


  Not convinved it is the best way but it is some way to make it point to the 
desired multiarch libdir rather than make it choose a random one.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13585

To: asturmlechner, #baloo
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D13585: Use LIB_SUFFIX for lmdb libdir rather than hardcode lib

2018-06-17 Thread Andreas Sturmlechner 
asturmlechner added a reviewer: Baloo.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13585

To: asturmlechner, #baloo
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D13585: Use LIB_SUFFIX for lmdb libdir rather than hardcode lib

2018-06-17 Thread Andreas Sturmlechner 
asturmlechner created this revision.
Restricted Application added projects: Frameworks, Baloo.
Restricted Application added subscribers: Baloo, kde-frameworks-devel.
asturmlechner requested review of this revision.

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13585

AFFECTED FILES
  cmake/FindLMDB.cmake

To: asturmlechner
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

2018-06-17 Thread Stefan Brüns 
bruns added a task: T8500: Add HIG rules about use of units/symbols in (config) 
UI.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D13583

To: bruns, #frameworks
Cc: kde-frameworks-devel, astippich, michaelh, ngraham, bruns

D13584: KFormat: Replace byte specific implementation with generic one

2018-06-17 Thread Stefan Brüns 
bruns added a task: T8500: Add HIG rules about use of units/symbols in (config) 
UI.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D13584

To: bruns, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

2018-06-17 Thread Stefan Brüns 
bruns added a dependent revision: D13584: KFormat: Replace byte specific 
implementation with generic one.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D13583

To: bruns, #frameworks
Cc: kde-frameworks-devel, astippich, michaelh, ngraham, bruns

D13584: KFormat: Replace byte specific implementation with generic one

2018-06-17 Thread Stefan Brüns 
bruns added a dependency: D13583: KFormat: Allow usage of quantities beyond 
bytes and seconds.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D13584

To: bruns, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13584: KFormat: Replace byte specific implementation with generic one

2018-06-17 Thread Stefan Brüns 
bruns created this revision.
bruns added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  There is no need for duplicate implementations. As formatValue covers
  a superset, call it from formatByteSize, mapping the prefix enums.

TEST PLAN
  make test

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13584

AFFECTED FILES
  src/lib/util/kformatprivate.cpp

To: bruns, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

2018-06-17 Thread Stefan Brüns 
bruns created this revision.
bruns added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Its useful to allow automatic formatting of quantities like bit per
  second (bit/s), but formatByteSize can not be used for this. Generalize
  the implementation to allow usage for arbitrary quantities.

TEST PLAN
  make test

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13583

AFFECTED FILES
  autotests/kformattest.cpp
  autotests/kformattest.h
  src/lib/util/kformat.cpp
  src/lib/util/kformat.h
  src/lib/util/kformatprivate.cpp
  src/lib/util/kformatprivate_p.h

To: bruns, #frameworks
Cc: kde-frameworks-devel, astippich, michaelh, ngraham, bruns

D13394: C++: update for c++20 and fix some syntax errors

2018-06-17 Thread Christoph Cullmann 
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Looks good for me!
  Thanks for the improvements.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  cpp

REVISION DETAIL
  https://phabricator.kde.org/D13394

To: jpoelen, dhaumann, cullmann
Cc: cullmann, kde-frameworks-devel, michaelh, ngraham, bruns