D13670: Add subseq operator to match sub-sequences
michaeleden created this revision. michaeleden added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. michaeleden requested review of this revision. REVISION SUMMARY Added `subseq` and `~subseq` operators which match subsequences of strings. This is useful to filter out matches quicker: $ ktraderclient5 --constraint "'libremath' ~subseq Name" --servicetype 'Application' --short servicetype is : Application constraint is : 'libremath' ~subseq Name got 1 offers. /nix/store/zq1kgdxk426qgf06nzpd7xqkpk4z5hh2-system-path/share/applications/math.desktop TEST PLAN I'll need help knowing where tests for this will go. REPOSITORY R309 KService BRANCH feature/match-subseq REVISION DETAIL https://phabricator.kde.org/D13670 AFFECTED FILES src/services/ktraderparse.cpp src/services/ktraderparse_p.h src/services/ktraderparsetree.cpp src/services/ktraderparsetree_p.h src/services/lex.l src/services/yacc.y To: michaeleden, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13641: [KCharSelect] Port generate-datafile.py to Python 3
lbeltrame accepted this revision. lbeltrame added a comment. This revision is now accepted and ready to land. I did an accept to undo my earlier "Changes required" because Phab messed up the lines I commented on, and because I realized I wasn't commenting on your specific changes. Sorry about that. INLINE COMMENTS > kcharselect-generate-datafile.py:432 > size += 2 > return size Perhaps the diff view is wrong.. but the return size here (at this level of nesting) wouldn't make the downstream code de facto unreachable in this function? > kcharselect-generate-datafile.py:607 > for char in self.unihan.keys(): > for entry in self.unihan[char]: Unrelated to this patch, but this could be changed to `for char in self.unihan` (perhaps in a separate revision). > kcharselect-generate-datafile.py:624 > pos += size > return pos Same here wrt position of return. Now I notice that they're not related to your changes, so I wonder if it's phab showing something off, or there is a problem of tab vs spaces REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D13641 To: cfeck, #frameworks, lbeltrame Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13627: [KIconThemes] Isolate private data from race conditions
anthonyfieroni updated this revision to Diff 36492. anthonyfieroni added a comment. Fix deadlock, icon of DragonPlayer and its related is not showed, i have no idea why !? REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13627?vs=36487=36492 REVISION DETAIL https://phabricator.kde.org/D13627 AFFECTED FILES src/kiconeffect.cpp src/kiconeffect.h src/kiconloader.cpp src/kiconloader.h To: anthonyfieroni, davidedmundson, dfaure, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13641: [KCharSelect] Port generate-datafile.py to Python 3
lbeltrame requested changes to this revision. lbeltrame added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kcharselect-generate-datafile.py:41 Perhaps the diff view is wrong.. but the `return size` here (at this level of nesting) wouldn't make the downstream code de facto unreachable in this function? > kcharselect-generate-datafile.py:118 Same here. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D13641 To: cfeck, #frameworks, lbeltrame Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13641: [KCharSelect] Port generate-datafile.py to Python 3
cfeck requested review of this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D13641 To: cfeck, #frameworks, lbeltrame Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13641: [KCharSelect] Port generate-datafile.py to Python 3
cfeck updated this revision to Diff 36490. cfeck added a comment. This revision is now accepted and ready to land. len() of UTF-8 encoded bytearray is different than len(str). Account for the difference when accumulating sizes. Unicode Names are always ASCII, so here len(bytearray) == len(str), and no change needed. REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13641?vs=36414=36490 REVISION DETAIL https://phabricator.kde.org/D13641 AFFECTED FILES src/kcharselect-generate-datafile.py To: cfeck, #frameworks, lbeltrame Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D10363: [KIO] Add support for XDG_TEMPLATES_DIR in KNewFileMenu
ngraham added a comment. @mmustac very nice! Should we consider 191632 to be resolved, or wait until you're implemented support for plain old non-`.desktop` files in `~/Templates`? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10363 To: mmustac, #frameworks, dfaure Cc: kde-frameworks-devel, broulik, ngraham, michaelh, bruns
KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 299 - Failure!
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/299/
Project:
Frameworks kio kf5-qt5 SUSEQt5.10
Date of build:
Thu, 21 Jun 2018 21:05:49 +
Build duration:
5 min 48 sec and counting
CONSOLE OUTPUT
[...truncated 145.79 KB...]-- The following REQUIRED packages have been found: * ECM (required version >= 5.47.0), Extra CMake Modules., * KF5Config (required version >= 5.47.0) * KF5CoreAddons (required version >= 5.47.0) * KF5DBusAddons (required version >= 5.47.0) * Gettext * KF5I18n (required version >= 5.47.0) * KF5Service (required version >= 5.47.0) * KF5Solid (required version >= 5.47.0) * Qt5Gui (required version >= 5.10.1) * KF5Completion (required version >= 5.47.0) * KF5ConfigWidgets (required version >= 5.47.0) * KF5IconThemes (required version >= 5.47.0) * KF5ItemViews (required version >= 5.47.0) * KF5JobWidgets (required version >= 5.47.0) * KF5WidgetsAddons (required version >= 5.47.0) * KF5WindowSystem (required version >= 5.47.0) * KF5Auth (required version >= 5.47.0) * Qt5DBus * Qt5Network * Qt5Xml * Qt5X11Extras * Qt5 (required version >= 5.8.0) * LibXslt,Required by the KDE help system to process DocBook XML * LibXml2,Required by the KDE help system to process DocBook XML * Qt5Core (required version >= 5.8.0) * KF5Bookmarks (required version >= 5.47.0) * KF5TextWidgets (required version >= 5.47.0) * KF5Archive (required version >= 5.47.0) * ZLIB, Support for gzip compressed files and data streams,Required for httpfiltertest * Qt5Test * Qt5Widgets * Qt5Concurrent (required version >= 5.8.0) * KF5XmlGui (required version >= 5.47.0)-- The following features have been disabled: * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)-- The following RECOMMENDED packages have not been found: * ACL, LibACL,Support for manipulating access control lists Support for manipulating access control lists Support for manipulating access control lists-- Configuring done-- Generating done-- Build files have been written to: /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.10/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[Frameworks kio kf5-qt5 SUSEQt5.10] Running shell script+ python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project kio --branchGroup kf5-qt5 --platform SUSEQt5.10 --usingInstall /home/jenkins//install-prefix/Scanning dependencies of target docs-kioslave5-data-index-cache-bz2Scanning dependencies of target docs-kcookiejar5-kcookiejar5-8Scanning dependencies of target docs-kioslave5-file-index-cache-bz2Scanning dependencies of target docs-kioslave5-ftp-index-cache-bz2Scanning dependencies of target docs-kioslave5-help-documentationnotfound-index-cache-bz2Scanning dependencies of target docs-kioslave5-help-index-cache-bz2[ 0%] Generating index.cache.bz2[ 0%] Generating index.cache.bz2[ 0%] Generating kcookiejar5.8[ 0%] Generating index.cache.bz2[ 0%] Generating index.cache.bz2[ 1%] Generating index.cache.bz2/home/jenkins/install-prefix/bin/meinproc5: error while loading shared libraries: libasan.so.4: cannot open shared object file: No such file or directory/home/jenkins/install-prefix/bin/meinproc5: error while loading shared libraries: libasan.so.4: cannot open shared object file: No such file or directory/home/jenkins/install-prefix/bin/meinproc5: error while loading shared libraries: libasan.so.4: cannot open shared object file: No such file or directory/home/jenkins/install-prefix/bin/meinproc5: error while loading shared libraries: libasan.so.4: cannot open shared object file: No such file or directorymake[2]: *** [docs/kioslave5/file/CMakeFiles/docs-kioslave5-file-index-cache-bz2.dir/build.make:62: docs/kioslave5/file/index.cache.bz2] Error 127make[2]: *** [docs/kioslave5/data/CMakeFiles/docs-kioslave5-data-index-cache-bz2.dir/build.make:62: docs/kioslave5/data/index.cache.bz2] Error 127make[2]: *** [docs/kioslave5/ftp/CMakeFiles/docs-kioslave5-ftp-index-cache-bz2.dir/build.make:62: docs/kioslave5/ftp/index.cache.bz2] Error 127make[2]: *** [docs/kioslave5/help/CMakeFiles/docs-kioslave5-help-index-cache-bz2.dir/build.make:62: docs/kioslave5/help/index.cache.bz2] Error 127/home/jenkins/install-prefix/bin/meinproc5: error while loading shared libraries: libasan.so.4: cannot open shared object file: No such file or directorymake[2]: *** [docs/kcookiejar5/CMakeFiles/docs-kcookiejar5-kcookiejar5-8.dir/build.make:62: docs/kcookiejar5/kcookiejar5.8] Error 127/home/jenkins/install-prefix/bin/meinproc5: error while loading shared libraries: libasan.so.4: cannot open shared object file: No such file or directorymake[1]: *** [CMakeFiles/Makefile2:268: docs/kioslave5/data/CMakeFiles/docs-kioslave5-data-index-cache-bz2.dir/all] Error 2make[2]: *** [docs/kioslave5/help/documentationnotfound/CMakeFiles/docs-kioslave5-help-documentationnotfound-index-cache-bz2.dir/build.make:62:
KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 55 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/55/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Thu, 21 Jun 2018 21:05:49 + Build duration: 3 min 54 sec and counting JUnit Tests Name: (root) Failed: 34 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiofilewidgets-kdiroperatortestFailed: TestSuite.kiofilewidgets-kfilecopytomenutestFailed: TestSuite.kiofilewidgets-kfilecustomdialogtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiofilewidgets-kfileplacesviewtestFailed: TestSuite.kiofilewidgets-kfilewidgettestFailed: TestSuite.kiofilewidgets-knewfilemenutestFailed: TestSuite.kiofilewidgets-kurlcomboboxtestFailed: TestSuite.kiofilewidgets-kurlnavigatortestFailed: TestSuite.kiofilewidgets-kurlrequestertestFailed: TestSuite.kiogui-favicontestFailed: TestSuite.kioslave-httpauthenticationtestFailed: TestSuite.kioslave-httpheaderdispositiontestFailed: TestSuite.kioslave-httpheadertokenizetestFailed: TestSuite.kioslave-httpobjecttestFailed: TestSuite.kioslave-kcookiejartestFailed: TestSuite.kiowidgets-accessmanagertestFailed: TestSuite.kiowidgets-accessmanagertest-qnamFailed: TestSuite.kiowidgets-clipboardupdatertestFailed: TestSuite.kiowidgets-dropjobtestFailed: TestSuite.kiowidgets-fileundomanagertestFailed: TestSuite.kiowidgets-jobguitestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltestFailed: TestSuite.kiowidgets-kfileitemactionstestFailed: TestSuite.kiowidgets-krununittestFailed: TestSuite.kiowidgets-kurifiltersearchprovideractionstestFailed: TestSuite.kiowidgets-kurifiltertestFailed: TestSuite.kiowidgets-kurlcompletiontestFailed: TestSuite.kiowidgets-kurlcompletiontest-nowaitFailed: TestSuite.kiowidgets-pastetestFailed: TestSuite.kpasswdservertest
KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 148 - Failure!
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/148/
Project:
Frameworks kio kf5-qt5 SUSEQt5.9
Date of build:
Thu, 21 Jun 2018 21:05:49 +
Build duration:
1 min 34 sec and counting
CONSOLE OUTPUT
[...truncated 136.40 KB...]-- Found ZLIB: /usr/lib64/libz.so (found version "1.2.11") CMake Deprecation Warning at tests/CMakeLists.txt:2 (cmake_policy): The OLD behavior for policy CMP0028 will be removed from a future version of CMake. The cmake-policies(7) manual explains that the OLD behaviors of all policies are deprecated and that a policy should be set to OLD only under specific short-term circumstances. Projects should be ported to the NEW behavior and not rely on setting a policy to OLD.-- The following OPTIONAL packages have been found: * KF5DocTools (required version >= 5.47.0), Provides tools to generate documentation in various format from DocBook files Required to build help ioslave and documentation * GSSAPI, Allows KIO to make use of certain HTTP authentication services,A MIT or HEIMDAL flavor of GSSAPI can be used * X11 * KF5Wallet (required version >= 5.47.0), Safe desktop-wide storage for passwords Required to have permanent storage of passwords for kpasswdserver * KF5Notifications (required version >= 5.47.0), Notifications library Required to have error notification support in kpac * Qt5Script (required version >= 5.8.0), QtScript, one of the Qt5 modules Required to build support for auto-configuration of network proxies-- The following REQUIRED packages have been found: * ECM (required version >= 5.47.0), Extra CMake Modules., * KF5Config (required version >= 5.47.0) * KF5CoreAddons (required version >= 5.47.0) * KF5DBusAddons (required version >= 5.47.0) * Gettext * KF5I18n (required version >= 5.47.0) * KF5Service (required version >= 5.47.0) * KF5Solid (required version >= 5.47.0) * Qt5Gui (required version >= 5.9.6) * KF5Completion (required version >= 5.47.0) * KF5ConfigWidgets (required version >= 5.47.0) * KF5IconThemes (required version >= 5.47.0) * KF5ItemViews (required version >= 5.47.0) * KF5JobWidgets (required version >= 5.47.0) * KF5WidgetsAddons (required version >= 5.47.0) * KF5WindowSystem (required version >= 5.47.0) * KF5Auth (required version >= 5.47.0) * Qt5DBus * Qt5Network * Qt5Xml * Qt5X11Extras * Qt5 (required version >= 5.8.0) * LibXslt,Required by the KDE help system to process DocBook XML * LibXml2,Required by the KDE help system to process DocBook XML * Qt5Core (required version >= 5.8.0) * KF5Bookmarks (required version >= 5.47.0) * KF5TextWidgets (required version >= 5.47.0) * KF5Archive (required version >= 5.47.0) * ZLIB, Support for gzip compressed files and data streams,Required for httpfiltertest * Qt5Test * Qt5Widgets * Qt5Concurrent (required version >= 5.8.0) * KF5XmlGui (required version >= 5.47.0)-- The following features have been disabled: * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)-- The following RECOMMENDED packages have not been found: * ACL, LibACL,Support for manipulating access control lists Support for manipulating access control lists Support for manipulating access control lists-- Configuring done-- Generating done-- Build files have been written to: /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.9/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[Frameworks kio kf5-qt5 SUSEQt5.9] Running shell script+ python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project kio --branchGroup kf5-qt5 --platform SUSEQt5.9 --usingInstall /home/jenkins//install-prefix/Scanning dependencies of target docs-kcookiejar5-kcookiejar5-8[ 0%] Generating kcookiejar5.8/home/jenkins/install-prefix/bin/meinproc5: error while loading shared libraries: libasan.so.4: cannot open shared object file: No such file or directorymake[2]: *** [docs/kcookiejar5/CMakeFiles/docs-kcookiejar5-kcookiejar5-8.dir/build.make:62: docs/kcookiejar5/kcookiejar5.8] Error 127make[1]: *** [CMakeFiles/Makefile2:174: docs/kcookiejar5/CMakeFiles/docs-kcookiejar5-kcookiejar5-8.dir/all] Error 2make: *** [Makefile:141: all] Error 2[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] emailextrecipients[Pipeline] emailext
D10363: [KIO] Add support for XDG_TEMPLATES_DIR in KNewFileMenu
This revision was automatically updated to reflect the committed changes. Closed by commit R241:de5ab5e74b4c: [KIO] Add support for XDG_TEMPLATES_DIR in KNewFileMenu (authored by mmustac, committed by elvisangelaccio). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10363?vs=35173=36488 REVISION DETAIL https://phabricator.kde.org/D10363 AFFECTED FILES src/filewidgets/knewfilemenu.cpp To: mmustac, #frameworks, dfaure Cc: kde-frameworks-devel, broulik, ngraham, michaelh, bruns
D13627: [KIconThemes] Isolate private data from race conditions
anthonyfieroni updated this revision to Diff 36487. anthonyfieroni added a comment. Protect also dbus slot REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13627?vs=36486=36487 REVISION DETAIL https://phabricator.kde.org/D13627 AFFECTED FILES src/kiconloader.cpp src/kiconloader.h To: anthonyfieroni, davidedmundson, dfaure, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13643: Add LabPlot project file icon
mtrescott edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D13643 To: mtrescott, #labplot, #vdg, #breeze Cc: ngraham, kde-frameworks-devel, michaelh, bruns
D13641: [KCharSelect] Port generate-datafile.py to Python 3
cfeck planned changes to this revision. cfeck added a comment. Needs more changes :/ REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D13641 To: cfeck, #frameworks, lbeltrame Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13643: Add LabPlot project file icon
mtrescott added a comment. @ngraham I edited it to have a screenshot. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D13643 To: mtrescott, #labplot, #vdg, #breeze Cc: ngraham, kde-frameworks-devel, michaelh, bruns
D13643: Add LabPlot project file icon
mtrescott edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D13643 To: mtrescott, #labplot, #vdg, #breeze Cc: ngraham, kde-frameworks-devel, michaelh, bruns
D13627: [KIconThemes] Isolate private data from race conditions
anthonyfieroni updated this revision to Diff 36486. REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13627?vs=36376=36486 REVISION DETAIL https://phabricator.kde.org/D13627 AFFECTED FILES src/kiconloader.cpp src/kiconloader.h To: anthonyfieroni, davidedmundson, dfaure, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13394: C++: update for c++20 and fix some syntax errors
dhaumann added a comment. @jpoelen Can you push yourself, or do you still not have a KDE contributor account? REPOSITORY R216 Syntax Highlighting BRANCH cpp REVISION DETAIL https://phabricator.kde.org/D13394 To: jpoelen, dhaumann, cullmann Cc: cullmann, kde-frameworks-devel, michaelh, ngraham, bruns
D13657: Highlight Gradle files with Groovy syntax too
dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Looks good. REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D13657 To: vkrause, dhaumann Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns
KDE CI: Frameworks kfilemetadata kf5-qt5 SUSEQt5.10 - Build # 56 - Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kfilemetadata%20kf5-qt5%20SUSEQt5.10/56/ Project: Frameworks kfilemetadata kf5-qt5 SUSEQt5.10 Date of build: Thu, 21 Jun 2018 17:09:44 + Build duration: 1 min 22 sec and counting JUnit Tests Name: (root) Failed: 14 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.embeddedimagedatatestFailed: TestSuite.epubextractortestFailed: TestSuite.exiv2extractortestFailed: TestSuite.externalextractortestFailed: TestSuite.externalwritertestFailed: TestSuite.extractorcollectiontestFailed: TestSuite.indexextractortestFailed: TestSuite.odfextractortestFailed: TestSuite.officeextractortestFailed: TestSuite.popplerextractortestFailed: TestSuite.propertyinfotestFailed: TestSuite.taglibextractortestFailed: TestSuite.taglibwritertestFailed: TestSuite.usermetadatawritertest Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report0% (0/5)0% (0/50)0% (0/50)0% (0/3117)0% (0/8177)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests0% (0/14)0% (0/14)0% (0/604)0% (0/3366)src0% (0/24)0% (0/24)0% (0/1212)0% (0/1069)src.extractors0% (0/10)0% (0/10)0% (0/1251)0% (0/3674)src.writers0% (0/1)0% (0/1)0% (0/23)0% (0/56)tests0% (0/1)0% (0/1)0% (0/27)0% (0/12)
D13460: implement the lyrics tag for taglibextractor
This revision was automatically updated to reflect the committed changes. Closed by commit R286:535de62bec16: implement the lyrics tag for taglibextractor (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13460?vs=35941=36476 REVISION DETAIL https://phabricator.kde.org/D13460 AFFECTED FILES autotests/taglibextractortest.cpp src/extractors/taglibextractor.cpp src/extractors/taglibextractor.h src/properties.h src/propertyinfo.cpp To: astippich, mgallien, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
D13657: Highlight Gradle files with Groovy syntax too
vkrause created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY While at it, add alert support to Groovy comments too. REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D13657 AFFECTED FILES autotests/folding/build.gradle.fold autotests/html/build.gradle.html autotests/input/build.gradle autotests/reference/build.gradle.ref data/syntax/groovy.xml To: vkrause Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13535: Do not cancel old clipboard selection if it is same as the new one.
This revision was automatically updated to reflect the committed changes. Closed by commit R127:0e580ae9bdc5: Do not cancel old clipboard selection if it is same as the new one. (authored by michalsrb, committed by fvogt). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13535?vs=36286=36460 REVISION DETAIL https://phabricator.kde.org/D13535 AFFECTED FILES autotests/client/test_datadevice.cpp src/server/datadevice_interface.cpp To: fvogt, #plasma, #frameworks, romangg Cc: michalsrb, romangg, graesslin, kde-frameworks-devel, michaelh, ngraham, bruns
D13535: Do not cancel old clipboard selection if it is same as the new one.
romangg accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D13535 To: fvogt, #plasma, #frameworks, romangg Cc: michalsrb, romangg, graesslin, kde-frameworks-devel, michaelh, ngraham, bruns
D11099: Fix compilation on Android
vkrause abandoned this revision. Restricted Application added a subscriber: kde-frameworks-devel. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D11099 To: vkrause, #frameworks Cc: kde-frameworks-devel, apol, michaelh, ngraham, bruns
D13643: Add LabPlot project file icon
ngraham added a comment. Icon patches always need screenshots! :) REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D13643 To: mtrescott, #labplot, #vdg, #breeze Cc: ngraham, kde-frameworks-devel, michaelh, bruns
D13627: [KIconThemes] Isolate private data from race conditions
anthonyfieroni added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in kiconloader.cpp:616
> Yeah, i saw it, i'll made a sequenceLock like this
>
> void sequenceLock(std::function func)
> {
> QMutexLocker locker();
> func():
> }
> //usage
> S_D(d)->sequenceLocker([d, _appname, extraSearchPaths]() {
> d->mIconCache->clear();
> d->clear();
> d->init(_appname, extraSearchPaths);
> });
>
> Are you ok with such approach?
Even QMutexLocker locker(); will not present or it'll deadlock. Only
sequenceLocker with func() in.
REPOSITORY
R302 KIconThemes
REVISION DETAIL
https://phabricator.kde.org/D13627
To: anthonyfieroni, davidedmundson, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13627: [KIconThemes] Isolate private data from race conditions
anthonyfieroni added inline comments.
INLINE COMMENTS
> dfaure wrote in kiconloader.cpp:616
> This locks and unlocks three times in a row, which is not only slightly
> inefficient, it also means that another thread could interleave calls in
> between, and get completely inconsistent state.
Yeah, i saw it, i'll made a sequenceLock like this
void sequenceLock(std::function func)
{
QMutexLocker locker();
func():
}
//usage
S_D(d)->sequenceLocker([d, _appname, extraSearchPaths]() {
d->mIconCache->clear();
d->clear();
d->init(_appname, extraSearchPaths);
});
Are you ok with such approach?
> dfaure wrote in kiconloader.cpp:1829
> similar here, if another thread changes mIconAvailability between the
> previous line and this one, you'll end up comparing iterators for a different
> container, that will never work
Here with sure with other approach.
REPOSITORY
R302 KIconThemes
REVISION DETAIL
https://phabricator.kde.org/D13627
To: anthonyfieroni, davidedmundson, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13627: [KIconThemes] Isolate private data from race conditions
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
This is the wrong approach for thread safety (wrong level of locking). It
should come with a multithreaded unittest so it can be checked for safety (with
clang+tsan for instance). And yes the concept overall seems wrong anyway as
QIcon isn't threadsafe in the first place, AFAIK.
A separate KIconLoader instance, used only to fetch paths and not icons,
could possibly be used in a secondary thread, but only that. In which case the
fix would look very different from this.
INLINE COMMENTS
> kiconloader.cpp:616
> +S_D(d)->mIconCache->clear();
> +S_D(d)->clear();
> +S_D(d)->init(_appname, extraSearchPaths);
This locks and unlocks three times in a row, which is not only slightly
inefficient, it also means that another thread could interleave calls in
between, and get completely inconsistent state.
> kiconloader.cpp:1829
> +auto it = S_D(d)->mIconAvailability.constFind(name);
> +const auto end = S_D(d)->mIconAvailability.constEnd();
> +if (it != end && !it.value() && !S_D(d)->shouldCheckForUnknownIcons()) {
similar here, if another thread changes mIconAvailability between the previous
line and this one, you'll end up comparing iterators for a different container,
that will never work
REPOSITORY
R302 KIconThemes
REVISION DETAIL
https://phabricator.kde.org/D13627
To: anthonyfieroni, davidedmundson, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D10363: [KIO] Add support for XDG_TEMPLATES_DIR in KNewFileMenu
mmustac added a comment. @dfaure Can you commit these changes as I don't have the access to ? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10363 To: mmustac, #frameworks, dfaure Cc: kde-frameworks-devel, broulik, ngraham, michaelh, bruns
KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 54 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/54/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Thu, 21 Jun 2018 07:21:49 + Build duration: 7 min 35 sec and counting JUnit Tests Name: (root) Failed: 4 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest
KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 298 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/298/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Thu, 21 Jun 2018 07:21:49 + Build duration: 5 min 28 sec and counting JUnit Tests Name: (root) Failed: 0 test(s), Passed: 58 test(s), Skipped: 0 test(s), Total: 58 test(s) Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report64% (23/36)66% (294/443)66% (294/443)53% (31916/60072)38% (18954/49460)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests100% (73/73)100% (73/73)95% (8860/9290)50% (5608/11209)autotests.http100% (9/9)100% (9/9)99% (586/587)59% (217/368)autotests.kcookiejar100% (1/1)100% (1/1)91% (180/198)67% (63/94)src100% (1/1)100% (1/1)86% (6/7)67% (4/6)src.core84% (100/119)84% (100/119)58% (8393/14498)50% (4895/9794)src.core.kssl100% (1/1)100% (1/1)40% (35/88)50% (3/6)src.filewidgets78% (31/40)78% (31/40)49% (3917/7918)33% (1655/4966)src.gui100% (2/2)100% (2/2)95% (104/110)77% (57/74)src.ioslaves.file100% (5/5)100% (5/5)52% (526/1015)42% (421/1012)src.ioslaves.file.kauth0% (0/3)0% (0/3)0% (0/107)0% (0/77)src.ioslaves.ftp0% (0/2)0% (0/2)0% (0/1365)0% (0/1515)src.ioslaves.help0% (0/5)0% (0/5)0% (0/247)0% (0/184)src.ioslaves.http89% (8/9)89% (8/9)41% (1781/4339)34% (1371/3995)src.ioslaves.http.kcookiejar33% (2/6)33% (2/6)47% (631/1333)55% (649/1174)src.ioslaves.remote100% (2/2)100% (2/2)28% (72/258)8% (19/242)src.ioslaves.remote.kdedmodule0% (0/4)0% (0/4)0% (0/14)100% (0/0)src.ioslaves.telnet0% (0/1)0% (0/1)0% (0/43)0% (0/30)src.ioslaves.trash64% (7/11)64% (7/11)51%
D13226: update trash docbook to 5.48
This revision was automatically updated to reflect the committed changes. Closed by commit R241:34d6917f46a3: update trash docbook to 5.48 (authored by lueck). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13226?vs=35227=36432 REVISION DETAIL https://phabricator.kde.org/D13226 AFFECTED FILES docs/kcontrol5/trash/index.docbook To: lueck, #frameworks, #documentation, ngraham Cc: ngraham, kde-frameworks-devel, kde-doc-english, michaelh, bruns, skadinna
