D13773: [KDirOperator] Use alternating background colors for list-style views

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13773 To: ngraham, #frameworks, #vdg, #dolphin Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13773: [KDirOperator] Use alternating background colors for list-style views

ngraham created this revision. ngraham added reviewers: Frameworks, VDG, Dolphin. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY This makes `KDirOperator` vilews matc

D10663: Remove a partially copied file if copyjob was cancelled in the middle of file copying

ngraham added a comment. Any progress on that, dmitrio? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10663 To: dmitrio, #frameworks, dfaure, ngraham Cc: kde-frameworks-devel, elvisangelaccio, ngraham, anthonyfieroni, meven, #frameworks, michaelh, bruns

D9446: WIP: Allow to autogenerate and install categories file

ltoscano added a comment. There can be more headers file for the same repository, and it has not been a problem in practice because the categories usually maps to different groups of files in different directories. See for example kopete, wacomtablet o kgraphviewer. REPOSITORY R240 Extra

D9446: WIP: Allow to autogenerate and install categories file

habacker added a comment. Restricted Application edited subscribers, added: kde-buildsystem, kde-frameworks-devel; removed: Frameworks, Build System. Having support for defining multiple debug categories has an additional issue as shown with the following example. As far as I can see there s

D13549: Switch KIO::convertSize() to KFormat::formatByteSize()

aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. i guess you can commit this, i don't see anything totally wrong and makes sense, so if you've tested it and you're confident it's fine please go ahead. REPOSITORY R241 KIO BRANCH kformat

D10166: Add -Wlogical-op -Wzero-as-null-pointer-constant to KF5 warnings

apol accepted this revision. apol added inline comments. INLINE COMMENTS > aacid wrote in KDEFrameworkCompilerSettings.cmake:70 > problem it's i also need the version check and since we already have it here > it doesn't make the code any more simpler. Ugh true, sorry. REPOSITORY R240 Extra C

Akademy Config Workshop

Dear KDE community, as you all know Akademy 2018 is approaching fast. I'll host a Config Workshop [0] on Tuesday 14th August, Room 125: two sessions from 10:30-12:30, then lunch together and a last session 14:00-15:00. I hope we will have interactive and interesting discussions about configurati

D13718: Support choosing .ico files in custom icon file chooser

This revision was automatically updated to reflect the committed changes. Closed by commit R302:0131f8afe845: Support choosing .ico files in custom icon file chooser (authored by ngraham). REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13718?vs=36636&id=36

D13718: Support choosing .ico files in custom icon file chooser

ngraham added a comment. In D13718#284112 , @cfeck wrote: > But if this works for the special case of full-path icons Right, and that's exactly what this patch enables. Thanks! REPOSITORY R302 KIconThemes BRANCH ico-support-in-i

D13695: Make sure KLineEdit::clearButtonClicked is emitted

This revision was automatically updated to reflect the committed changes. Closed by commit R284:e76aa5f2c715: Make sure KLineEdit::clearButtonClicked is emitted (authored by aacid). REPOSITORY R284 KCompletion CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13695?vs=36559&id=36798 RE

D10166: Add -Wlogical-op -Wzero-as-null-pointer-constant to KF5 warnings

aacid added inline comments. INLINE COMMENTS > apol wrote in KDEFrameworkCompilerSettings.cmake:70 > Maybe you can add `-Wzero-as-null-pointer-constant` to the if above which is > `gcc or clang`? problem it's i also need the version check and since we already have it here it doesn't make the c

D13718: Support choosing .ico files in custom icon file chooser

cfeck accepted this revision. cfeck added a comment. This revision is now accepted and ready to land. I was thinking if we need general support for .ico files on Windows, but fear a slowdown while lookup of theme icons. But if this works for the special case of full-path icons, we can revisit

D13641: [KCharSelect] Port generate-datafile.py to Python 3

This revision was automatically updated to reflect the committed changes. Closed by commit R236:0a70dc9bb0f2: [KCharSelect] Port generate-datafile.py to Python 3 (authored by cfeck). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D13641?vs=36490&id=36790#toc REPOSITORY R236 KWidgetsAddo

D13718: Support choosing .ico files in custom icon file chooser

ngraham added a comment. So is this patch okay, or is more needed here? REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D13718 To: ngraham, #frameworks, cfeck Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D13732: Add debug output for all network requests

ltoscano added a comment. kdebugsettings is what you are looking for, it works for all Qt applications. You can specify the rules directly, or use the available .categories file to quickly select some levels. Many applications by KDE exports a .categories file. There was an effort to au

D13732: Add debug output for all network requests

habacker added a comment. In D13732#283984 , @bruns wrote: > `org.kde.attica.debug=true` Just on question relating the category: Is there something comparable to KDebugDialog and kdebug.areas from KDE4 times https://cgit.kde.org/kdelibs.

D13732: Add debug output for all network requests

habacker added a comment. In D13732#283984 , @bruns wrote: > Actually, it does. You have to enable logging explicitly for the per default excluded levels: > `org.kde.attica.debug=true` > > http://doc.qt.io/qt-5/qloggingcategory.html#config

D13732: Add debug output for all network requests

bruns added a comment. In D13732#283754 , @habacker wrote: > Unfortunally changing to qCDebug will not show any debug messages in the provider test app. > > Any hint how to do that programmatically in the provider test app ? http://doc.qt.io

D13752: Kill solidautoeject

anthonyfieroni added a comment. I have looking on https://bugs.kde.org/show_bug.cgi?id=394348 that's using same interface when ISO is mounting? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D13752 To: broulik, #plasma, #frameworks, adridg, davidedmundson,

D12233: Avoid manipulation of lists with quadratic complexity

lbeltrame added a reviewer: mgallien. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12233 To: bruns, #baloo, michaelh, mgallien Cc: dhaumann, ngraham, kde-frameworks-devel, jtamate, bruns, ashaposhnikov, michaelh, astippich, spoorun, abrahams

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 152 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/152/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Wed, 27 Jun 2018 13:02:09 + Build duration: 6 min 52 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 303 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/303/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Wed, 27 Jun 2018 13:02:09 + Build duration: 6 min 16 sec and counting JUnit Tests Name: (roo

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 58 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/58/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Wed, 27 Jun 2018 13:02:10 + Build duration: 5 min 11 sec and counting JUnit Tests Name:

D13757: Move parsing .desktop file for folder Comment to file KIO

dfaure added a comment. The problem is that now this is done for every single file being listed, rather than on demand. In a directory with 1000 subdirs, this would look for 1000 */.directory files, while the user is typically only going to hover one or two... I agree that blocking a differe

D13597: Use a correct emblem icon for readonly files and folders

This revision was automatically updated to reflect the committed changes. Closed by commit R241:0726f17ae791: Use a correct emblem icon for readonly files and folders (authored by ngraham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13597?vs=36301&id=36761 RE

D13757: Move parsing .desktop file for folder Comment to file KIO

ngraham added a comment. Would this be a satisfactory way to also read a custom icon from the .directory file? If you add that, I'll be happy to abandon D13083: Respect custom directory icons in iconNameForURL() . REPOSITORY R241 KIO REVISION DETAIL h

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 179 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/179/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Wed, 27 Jun 2018 12:47:03 + Build duration: 2 min 36 sec and counting JU

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 178 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/178/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Wed, 27 Jun 2018 12:34:44 + Build duration: 12 min and counting JUnit Te

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 - Build # 30 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.10/30/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 Date of build: Wed, 27 Jun 2018 12:39:44 + Build duration: 3 min 41 sec and counting

D13496: FrameSvg: Update mask frame if image path has been changed

This revision was automatically updated to reflect the committed changes. Closed by commit R242:0c8dd9dc2b54: FrameSvg: Update mask frame if image path has been changed (authored by zzag). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13496

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 - Build # 29 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.10/29/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 Date of build: Wed, 27 Jun 2018 12:34:44 + Build duration: 4 min 31 sec and counting

D13384: FrameSvg: Do not wreck shared mask frames

This revision was automatically updated to reflect the committed changes. Closed by commit R242:412a517576d5: FrameSvg: Do not wreck shared mask frames (authored by zzag). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13384?vs=36056&id=3675

D13402: FrameSvg: Simplify updateSizes

This revision was automatically updated to reflect the committed changes. Closed by commit R242:acdaefa221cc: FrameSvg: Simplify updateSizes (authored by zzag). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13402?vs=35748&id=36757 REVISION

D13757: Move parsing .desktop file for folder Comment to file KIO

broulik retitled this revision from "Move parsing .desktop file for Comment to file KIO" to "Move parsing .desktop file for folder Comment to file KIO". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13757 To: broulik, dfaure, lbeltrame Cc: kde-frameworks-devel, michaelh,

D13757: Move parsing .desktop file for Comment to file KIO

broulik created this revision. broulik added reviewers: dfaure, lbeltrame. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY This avoids blocking when the folder is on a

D13384: FrameSvg: Do not wreck shared mask frames

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. sorry for making you wait too long on those framesvg changes, looks like i have to tune up phab notifications a bit more as they didn't show up :/ (anyways, adding Plasma in tags should maximi

D13402: FrameSvg: Simplify updateSizes

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH framesvg-simplify-updatesizes REVISION DETAIL https://phabricator.kde.org/D13402 To: zzag, #plasma, #frameworks, mart Cc: kde-frameworks-devel, michaelh, ngraham

D13496: FrameSvg: Update mask frame if image path has been changed

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH dont-wreck-shared-mask-frames REVISION DETAIL https://phabricator.kde.org/D13496 To: zzag, #plasma, #frameworks, mart Cc: kde-frameworks-devel, michaelh, ngraham

D13752: Kill solidautoeject

broulik added a comment. > It's not clear to me what this revision is trying to change (in terms of user-visible behavior) or how to test the change I think you could test it by disabling the "Drive Ejector" module in "Background Services" (kded settings) in System Settings. If pressing

D13752: Kill solidautoeject

adridg added a comment. It's not clear to me what this revision is trying to change (in terms of user-visible behavior) or how to test the change; what I've written above is current behavior on FreeBSD 11 with Plasma 5.12.5; HAL is running. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D13752: Kill solidautoeject

adridg added a comment. Since the ticket is rather unclear on what functionality is being tested, or how: - Put a CD with an ISO9660 filesystem in the drive (I used one with Debian from 1995 on it) - When device notifier pops up, pick "open with filemanager" (`*`) - Ensure the silesy

D13627: [KIconThemes] Isolate private data from race conditions

anthonyfieroni added inline comments. INLINE COMMENTS > dfaure wrote in kiconloadertest.cpp:19 > But why not use a different icon loader per thread? Because that's scenario when you give global pointer to Qt, no? REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D1362

D13743: Migrate build system to use find_package in autotests/ki18n_install

ltoscano added a comment. Most of the projects are configured so that the reviews are automatic subscription to the relevant list. This means that the people involved with the project should already know about it, even without a reviewer and despite the message from phabricator UI. REPOSITO

D13719: OdfExtractor: deal with non-common prefix names

This revision was automatically updated to reflect the committed changes. Closed by commit R286:fd3319a6803b: OdfExtractor: deal with non-common prefix names (authored by kossebau). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13719?vs=36647&id=36751

D13732: Add debug output for all network requests

habacker added a comment. Unfortunally changing to qCDebug will not show any debug messages in the provider test app. I can only see debug messages if I change in the top level CMakeLists.txt the line ecm_qt_declare_logging_category(attica_SRCS HEADER attica_debug.h IDENTIFIER AT

D13743: Migrate build system to use find_package in autotests/ki18n_install

habacker removed a reviewer: leinir. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D13743 To: habacker, apol, ilic, leinir Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13743: Migrate build system to use find_package in autotests/ki18n_install

habacker added a comment. Sorry, copy and paste bug It is complicate to find the correct reviewer for a project, because by default reviews do not get any reviewer by default. .arcconfig located in a related git repo clone does not contain any hint. REPOSITORY R249 KI18n REVISION DET

KDE CI: Frameworks attica kf5-qt5 SUSEQt5.10 - Build # 29 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20attica%20kf5-qt5%20SUSEQt5.10/29/ Project: Frameworks attica kf5-qt5 SUSEQt5.10 Date of build: Wed, 27 Jun 2018 10:12:44 + Build duration: 3 min 13 sec and counting JUnit Tests Name:

KDE CI: Frameworks attica kf5-qt5 WindowsMSVCQt5.10 - Build # 20 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20attica%20kf5-qt5%20WindowsMSVCQt5.10/20/ Project: Frameworks attica kf5-qt5 WindowsMSVCQt5.10 Date of build: Wed, 27 Jun 2018 10:12:45 + Build duration: 4 min 6 sec and counting JUnit Tests

KDE CI: Frameworks attica kf5-qt5 SUSEQt5.9 - Build # 20 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20attica%20kf5-qt5%20SUSEQt5.9/20/ Project: Frameworks attica kf5-qt5 SUSEQt5.9 Date of build: Wed, 27 Jun 2018 10:12:45 + Build duration: 3 min 11 sec and counting JUnit Tests Name: (r

KDE CI: Frameworks attica kf5-qt5 FreeBSDQt5.10 - Build # 11 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20attica%20kf5-qt5%20FreeBSDQt5.10/11/ Project: Frameworks attica kf5-qt5 FreeBSDQt5.10 Date of build: Wed, 27 Jun 2018 10:12:45 + Build duration: 1 min 18 sec and counting JUnit Tests

Re: text search balloon background colour

Hi, > Has the background colour used for text search balloons ("Continuing search > from top" , for instance) been changed recently? it was adjusted to more closely resemble the Breeze visual style. The colors are unfortunately hardcoded as KWidgetAddons as a Tier 1 framework cannot depend on

D13743: Migrate build system to use find_package in autotests/ki18n_install

ltoscano added reviewers: apol, ilic. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D13743 To: habacker, leinir, apol, ilic Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13743: Migrate build system to use find_package in autotests/ki18n_install

leinir added a comment. This seems quite sensible to me, a cleanup and simplification of the test build system is not bad... That said, i'm unsure why you think i'm qualified to speak about ki18n and the general cmake build system to a level high enough that you highlight me specificall

D13752: Kill solidautoeject

mart added a comment. +1 (maybe build conditionally on freebsd if it's *really* necessary there) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D13752 To: broulik, #plasma, #frameworks, adridg, davidedmundson, dfaure, fvogt, ervin Cc: mart, plasma-devel, r

D13597: Use a correct emblem icon for readonly files and folders

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Neither icon is in the naming specification but since this is meant as an overlay, `emblem` makes more sense. REPOSITORY R241 KIO BRANCH use-emblem-icon-for-readonly-items (branched

D13695: Make sure KLineEdit::clearButtonClicked is emitted

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R284 KCompletion BRANCH master REVISION DETAIL https://phabricator.kde.org/D13695 To: aacid, broulik Cc: davidedmundson, kde-frameworks-devel, broulik, michaelh, ngraham, bruns

D13718: Support choosing .ico files in custom icon file chooser

broulik added a comment. I think if you pass a completely custom icon to it an absolute path will be looked up and as a result this (unintentionally) works REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D13718 To: ngraham, #frameworks, cfeck Cc: broulik, kde-fra

D13752: Kill solidautoeject

fvogt added a comment. Umount on eject press still works even without the kded module loaded. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D13752 To: broulik, #plasma, #frameworks, adridg, davidedmundson, dfaure, fvogt, ervin Cc: plasma-devel, ragreen, Pit

D13752: Kill solidautoeject

broulik edited the summary of this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D13752 To: broulik, #plasma, #frameworks, adridg, davidedmundson, dfaure, fvogt, ervin Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg

D13752: Kill solidautoeject

broulik created this revision. broulik added reviewers: Plasma, Frameworks, adridg, davidedmundson, dfaure, fvogt, ervin. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Solid's

D10166: Add -Wlogical-op -Wzero-as-null-pointer-constant to KF5 warnings

apol added a comment. INLINE COMMENTS > KDEFrameworkCompilerSettings.cmake:70 > if (NOT CMAKE_CXX_COMPILER_VERSION VERSION_LESS "5.0.0") > - set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wsuggest-override" ) > + set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wsuggest-override > -Wlogical-o

KDE CI: Frameworks attica kf5-qt5 SUSEQt5.10 - Build # 28 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20attica%20kf5-qt5%20SUSEQt5.10/28/ Project: Frameworks attica kf5-qt5 SUSEQt5.10 Date of build: Wed, 27 Jun 2018 08:48:29 + Build duration: 4 min 20 sec and counting JUnit Tests Name:

KDE CI: Frameworks attica kf5-qt5 WindowsMSVCQt5.10 - Build # 19 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20attica%20kf5-qt5%20WindowsMSVCQt5.10/19/ Project: Frameworks attica kf5-qt5 WindowsMSVCQt5.10 Date of build: Wed, 27 Jun 2018 08:48:29 + Build duration: 3 min 16 sec and counting JUnit Tes

KDE CI: Frameworks attica kf5-qt5 SUSEQt5.9 - Build # 19 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20attica%20kf5-qt5%20SUSEQt5.9/19/ Project: Frameworks attica kf5-qt5 SUSEQt5.9 Date of build: Wed, 27 Jun 2018 08:48:29 + Build duration: 2 min 32 sec and counting JUnit Tests Name: (

KDE CI: Frameworks attica kf5-qt5 FreeBSDQt5.10 - Build # 10 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20attica%20kf5-qt5%20FreeBSDQt5.10/10/ Project: Frameworks attica kf5-qt5 FreeBSDQt5.10 Date of build: Wed, 27 Jun 2018 08:48:29 + Build duration: 1 min 44 sec and counting JUnit Tests

D13627: [KIconThemes] Isolate private data from race conditions

dfaure added inline comments. INLINE COMMENTS > kiconloadertest.cpp:19 > +{ > +KIconLoader *mpLoader = KIconLoader::global(); > +KIconLoader::Context mContext = KIconLoader::Application; But why not use a different icon loader per thread? REPOSITORY R302 KIconThemes REVIS

KDE CI: Frameworks attica kf5-qt5 SUSEQt5.9 - Build # 18 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20attica%20kf5-qt5%20SUSEQt5.9/18/ Project: Frameworks attica kf5-qt5 SUSEQt5.9 Date of build: Wed, 27 Jun 2018 08:32:29 + Build duration: 4 min 33 sec and counting JUnit Tests Name: (

KDE CI: Frameworks attica kf5-qt5 SUSEQt5.10 - Build # 27 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20attica%20kf5-qt5%20SUSEQt5.10/27/ Project: Frameworks attica kf5-qt5 SUSEQt5.10 Date of build: Wed, 27 Jun 2018 08:32:29 + Build duration: 3 min 21 sec and counting JUnit Tests Name:

KDE CI: Frameworks attica kf5-qt5 WindowsMSVCQt5.10 - Build # 18 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20attica%20kf5-qt5%20WindowsMSVCQt5.10/18/ Project: Frameworks attica kf5-qt5 WindowsMSVCQt5.10 Date of build: Wed, 27 Jun 2018 08:32:29 + Build duration: 1 min 35 sec and counting CONSOLE OU

KDE CI: Frameworks attica kf5-qt5 FreeBSDQt5.10 - Build # 9 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20attica%20kf5-qt5%20FreeBSDQt5.10/9/ Project: Frameworks attica kf5-qt5 FreeBSDQt5.10 Date of build: Wed, 27 Jun 2018 08:32:29 + Build duration: 1 min 10 sec and counting JUnit Tests

D13733: Add provider auto test

This revision was automatically updated to reflect the committed changes. Closed by commit R235:ebb9d8d9c1a9: Add provider auto test (authored by habacker). REPOSITORY R235 Attica CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13733?vs=36693&id=36743 REVISION DETAIL https://phabri

D13732: Add debug output for all network requests

leinir requested changes to this revision. leinir added a comment. This revision now requires changes to proceed. Straight-up qDebug would cause quite a lot of spam... I'd be much happier if this was done using qCDebug (which is already used in other parts of the code, so just need to include

D13733: Add provider auto test

leinir accepted this revision. This revision is now accepted and ready to land. REPOSITORY R235 Attica BRANCH master REVISION DETAIL https://phabricator.kde.org/D13733 To: habacker, leinir Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13627: [KIconThemes] Isolate private data from race conditions

anthonyfieroni updated this revision to Diff 36742. anthonyfieroni added a comment. Fix icon loading issue (Dragonplayer related) *Achievements Deleting cache in ~/.cache (kcache and / or qml cache) does not result in broken icons. REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDA