D13786: Show an icon for hidden files in Dolphin

ngraham added a comment. Lol! REPOSITORY R267 Oxygen Icons REVISION DETAIL https://phabricator.kde.org/D13786 To: ngraham, #dolphin, aacid, cfeck Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

D13786: Show an icon for hidden files in Dolphin

cfeck added a comment. too late ;) REPOSITORY R267 Oxygen Icons REVISION DETAIL https://phabricator.kde.org/D13786 To: ngraham, #dolphin, aacid, cfeck Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

D13786: Show an icon for hidden files in Dolphin

ngraham closed this revision. REPOSITORY R267 Oxygen Icons REVISION DETAIL https://phabricator.kde.org/D13786 To: ngraham, #dolphin, aacid, cfeck Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

D13786: Show an icon for hidden files in Dolphin

cfeck edited the summary of this revision. REPOSITORY R267 Oxygen Icons REVISION DETAIL https://phabricator.kde.org/D13786 To: ngraham, #dolphin, aacid, cfeck Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

D13786: Show an icon for hidden files in Dolphin

cfeck accepted this revision. This revision is now accepted and ready to land. REPOSITORY R267 Oxygen Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D13786 To: ngraham, #dolphin, aacid, cfeck Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

D13786: Show an icon for hidden files in Dolphin

ngraham added a comment. Oops, missed that one! REPOSITORY R267 Oxygen Icons REVISION DETAIL https://phabricator.kde.org/D13786 To: ngraham, #dolphin, aacid Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

D13786: Show an icon for hidden files in Dolphin

ngraham updated this revision to Diff 36863. ngraham added a comment. Also do 48x48 REPOSITORY R267 Oxygen Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13786?vs=36859=36863 BRANCH master REVISION DETAIL https://phabricator.kde.org/D13786 AFFECTED FILES

D13786: Show an icon for hidden files in Dolphin

cfeck added a comment. I think we also use 48x48 for actions. REPOSITORY R267 Oxygen Icons REVISION DETAIL https://phabricator.kde.org/D13786 To: ngraham, #dolphin, aacid Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

D13777: KMessageWidget : revert to using highlight colour for Information style (WIP)

cfeck added a comment. I like the refactoring, much easier to read. I have to agree with Nathan that the special casing for the alpha is unneeded. For users having a black selection color, it wouldn't tint at all. We deliberately used a small blending value (0.2) to make sure the

D13787: CoffeeScript & JavaScript: fix member objects. Add .ts extension in JS

nibags edited the summary of this revision. nibags added reviewers: dhaumann, cullmann. nibags added a project: Framework: Syntax Highlighting. nibags edited subscribers, added: Framework: Syntax Highlighting; removed: kde-frameworks-devel. REPOSITORY R216 Syntax Highlighting REVISION DETAIL

D13787: CoffeeScript & JavaScript: fix member objects. Add .ts extension in JS

nibags created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. nibags requested review of this revision. REVISION SUMMARY **CoffeeScript** - Fix [bug #394365](URL

D13786: Show an icon for hidden files in Dolphin

ngraham edited the test plan for this revision. REPOSITORY R267 Oxygen Icons REVISION DETAIL https://phabricator.kde.org/D13786 To: ngraham, #dolphin, aacid Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13786: Show an icon for hidden files in Dolphin

ngraham created this revision. ngraham added reviewers: Dolphin, aacid. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY Dolphin uses the `hint` icon for invisible

D10663: Remove a partially copied file if copyjob was cancelled in the middle of file copying

dmitrio abandoned this revision. dmitrio added a comment. No, didn't work on that, sorry. I think I am better to close the revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10663 To: dmitrio, #frameworks, dfaure, ngraham Cc: kde-frameworks-devel,

D13777: KMessageWidget : revert to using highlight colour for Information style (WIP)

rjvbb set the repository for this revision to R236 KWidgetsAddons. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D13777 To: rjvbb, ngraham, #frameworks Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

D13777: KMessageWidget : revert to using highlight colour for Information style (WIP)

rjvbb updated this revision to Diff 36858. rjvbb added a comment. The need for an extra check in `qColorFromSettings()` meant I changed the API to put all tests in there and added a default return value argument. IOW, basically the same API as KConfig has. I've simplified the

D13777: KMessageWidget : revert to using highlight colour for Information style (WIP)

cfeck added inline comments. INLINE COMMENTS > kmessagewidget.cpp:263 > +QStringList rgb = settings->value(key).toStringList(); > +return QColor(rgb.at(0).toInt(), rgb.at(1).toInt(), rgb.at(2).toInt()); > +} missing `if (rgb.size() >= 3)` > kmessagewidget.cpp:281 > +const QString

D13732: Add debug output for all network requests

This revision was automatically updated to reflect the committed changes. Closed by commit R235:65731a8f8ade: Add debug output for all network requests (authored by habacker). REPOSITORY R235 Attica CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13732?vs=36848=36850 REVISION DETAIL

D13732: Add debug output for all network requests

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Sorted! Good digging, nice work :) REPOSITORY R235 Attica BRANCH master REVISION DETAIL https://phabricator.kde.org/D13732 To: habacker, leinir Cc: ltoscano, bruns,

D13732: Add debug output for all network requests

habacker updated this revision to Diff 36848. habacker added a comment. - use qcDebug - enable debug display in providertest REPOSITORY R235 Attica CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13732?vs=36667=36848 BRANCH master REVISION DETAIL

KDE CI: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.10 - Build # 101 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.10/101/ Project: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.10 Date of build: Thu, 28 Jun 2018 17:48:39 + Build duration: 4 min 55 sec and counting

KDE CI: Frameworks syntax-highlighting kf5-qt5 FreeBSDQt5.10 - Build # 27 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20FreeBSDQt5.10/27/ Project: Frameworks syntax-highlighting kf5-qt5 FreeBSDQt5.10 Date of build: Thu, 28 Jun 2018 17:48:39 + Build duration: 3 min 42 sec and

KDE CI: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9 - Build # 43 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.9/43/ Project: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9 Date of build: Thu, 28 Jun 2018 17:48:39 + Build duration: 2 min 2 sec and counting

D13657: Highlight Gradle files with Groovy syntax too

This revision was automatically updated to reflect the committed changes. Closed by commit R216:0abcd9de2c8e: Highlight Gradle files with Groovy syntax too (authored by vkrause). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13657?vs=36461=36847

D13777: KMessageWidget : revert to using highlight colour for Information style (WIP)

rjvbb added inline comments. INLINE COMMENTS > ngraham wrote in kmessagewidget.cpp:311 > Also, commits should be atomic; even if we want to do this, it should be in > another patch since it represents a separate conceptual change compared to > the status quo, as opposed to simply a bugfix or

D13777: KMessageWidget : revert to using highlight colour for Information style (WIP)

ngraham added inline comments. INLINE COMMENTS > rjvbb wrote in kmessagewidget.cpp:311 > The issue I have with using these colours is that they are foreground > colours, to be used against one of 2 or 3 background colours. *That* is what > the theme can be expected to ensure. > > There is

D11828: Simplify orPostingIterator and make it faster

fvogt added inline comments. INLINE COMMENTS > orpostingiterator.cpp:86 > +// check if the docId is the new lowest docId > +if (((docId < m_nextId)) || (m_nextId == 0)) { > +m_nextId = docId; Looks like most of those parens are unnecessary. REPOSITORY R293 Baloo

D13777: KMessageWidget : revert to using highlight colour for Information style (WIP)

rjvbb marked 2 inline comments as done. rjvbb added inline comments. INLINE COMMENTS > ngraham wrote in kmessagewidget.cpp:311 > I don't think all of this complicated code is necessary. The theme itself is > supposed to ensure readability with the colors that it uses. Also, this > results in a

D13777: KMessageWidget : revert to using highlight colour for Information style (WIP)

ngraham added a comment. I just realized that we have another case in `KWidgetsAddons` that could benefit from your read-theme-colors-without-using-kconfig idea: D12756: [KDateTable] Use more appropriate and readable text colors for weekends and holidays

D13777: KMessageWidget : revert to using highlight colour for Information style (WIP)

ngraham added inline comments. INLINE COMMENTS > ngraham wrote in kmessagewidget.cpp:275 > This commented-out line and its comments should be removed. Never mind, you were too fast for me. :) REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D13777 To: rjvbb,

D13777: KMessageWidget : revert to using highlight colour for Information style (WIP)

ngraham added a comment. Thanks, I think this approach is more feasible! I have some comments below: INLINE COMMENTS > kmessagewidget.cpp:275 > +// for best results. > +// const QColor windowColor = KMessageWidget::palette().window().color(); > +const QColor windowColor =

D13777: KMessageWidget : revert to using highlight colour for Information style (WIP)

rjvbb updated this revision to Diff 36846. rjvbb added a comment. cleanup REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13777?vs=36845=36846 REVISION DETAIL https://phabricator.kde.org/D13777 AFFECTED FILES src/kmessagewidget.cpp To: rjvbb,

D13777: KMessageWidget : revert to using highlight colour for Information style (WIP)

rjvbb set the repository for this revision to R236 KWidgetsAddons. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D13777 To: rjvbb, ngraham, #frameworks Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

D13777: KMessageWidget : revert to using highlight colour for Information style (WIP)

rjvbb updated this revision to Diff 36845. rjvbb added a comment. Version using the suggested colour values from ~/.config/kdeglobals , if the file exists and has a Colors:Window group. In my case this gives informational and error messages almost the same background colour because I

D13777: KMessageWidget : revert to using highlight colour for Information style (WIP)

ngraham added a comment. This patch isn't the right place for discussing changing the conceptual color scheme for the widgets. This patch also isn't the place for insulting the people who you're hoping will accept your changes. :) If you want to implement a private method to get

D13777: KMessageWidget : revert to using highlight colour for Information style (WIP)

rjvbb added a comment. > Another idea would have been to have the widget style alter the appearance like it already does for things like `KTitleWidget` Care to develop? > - Suspend output in a Konsole window that has a dark background color: the text is unreadable. By hitting

D13777: KMessageWidget : revert to using highlight colour for Information style (WIP)

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. I'm not sure that's the right approach. This new version has bugs with Breeze light: - Suspend output in a Konsole window that has a dark background color: the text is

D13777: KMessageWidget : revert to using highlight colour for Information style (WIP)

broulik added a comment. -1 The upper two in second revision look quite bad. Another idea would have been to have the widget style alter the appearance like it already does for things like `KTitleWidget` REPOSITORY R236 KWidgetsAddons REVISION DETAIL

D13777: KMessageWidget : revert to using highlight colour for Information style (WIP)

rjvbb added a comment. 5.47.0 (stock) vs. 5.42.0 (stock), QtCurve (top) vs. Macintosh native (below): F5967082: KMessageWidget-styles-before,after.png with revision 2 of my patch: F5967086: Screen Shot 2018-06-28 at 16.04.28.png

D13777: KMessageWidget : revert to using highlight colour for Information style (WIP)

rjvbb marked 3 inline comments as done. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D13777 To: rjvbb, ngraham, #frameworks Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

D13777: KMessageWidget : revert to using highlight colour for Information style (WIP)

rjvbb set the repository for this revision to R236 KWidgetsAddons. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D13777 To: rjvbb, ngraham, #frameworks Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

D13777: KMessageWidget : revert to using highlight colour for Information style (WIP)

rjvbb updated this revision to Diff 36841. rjvbb added a comment. This revision incorporates the feedback and implements the approach already evoked: - use the user's highlight colour for positive messages, with a 0.4 alpha value - use the user's tooltip background colour for

D13773: [KDirOperator] Use alternating background colors for list-style views

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13773 To: ngraham, #frameworks, #vdg, #dolphin Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13782: RFC: Ignore NTFS hidden flag for root volume

broulik updated this revision to Diff 36838. broulik added a comment. Only check for folders, a file cannot be a mount, saves querying mount points for hidden files REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13782?vs=36837=36838 REVISION DETAIL

D13782: RFC: Ignore NTFS hidden flag for root volume

broulik created this revision. broulik added reviewers: dfaure, ngraham, yurikoles. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Those are always hidden as far as

D13777: KMessageWidget : revert to using highlight colour for Information style (WIP)

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. KWidgetsAddons is a Tier 1 framework, so it can't depend on any other KDE Frameworks, including KConfig, which is where the current theme's full palette is stored. Because of

D13777: KMessageWidget : revert to using highlight colour for Information style (WIP)

cfeck added a comment. here is WIP feedback: the comments explain the change, but they are not needed to explain the code. Remove them. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D13777 To: rjvbb, ngraham, #frameworks Cc: cfeck, kde-frameworks-devel,

D13777: KMessageWidget : revert to using highlight colour for Information style (WIP)

rjvbb created this revision. rjvbb added reviewers: ngraham, Frameworks. Restricted Application added a project: Frameworks. rjvbb requested review of this revision. REVISION SUMMARY A recent commit (00bce130d35e9dc398709e690a05f8dde70f52b3

D9446: WIP: Allow to autogenerate and install categories file

habacker added a comment. - doc in file header is missing - test case is missing INLINE COMMENTS > ECMQtDeclareLoggingCategory.cmake:68 > set(options) > -set(oneValueArgs HEADER IDENTIFIER CATEGORY_NAME DEFAULT_SEVERITY) > +set(oneValueArgs HEADER IDENTIFIER CATEGORY_NAME

D9446: WIP: Allow to autogenerate and install categories file

habacker added a comment. In D9446#284272 , @habacker wrote: > In D9446#181785 , @mlaurent wrote: > > > IT's a WIP as I use file(APPEND...) because I want to generate several categories in one file.

D9446: WIP: Allow to autogenerate and install categories file

ltoscano added a comment. In D9446#284288 , @cgiboudeaux wrote: > > There are several issues that need fixes: > > - Installation dir for categories, /etc/xdg on linux has always been wrong. categories are not config files

Re: text search balloon background colour

If we're indeed talking about the change to match Kirigami: why on earth do that? If developers want to achieve that style they can use the framework that provides it. If not, let the style in use handle the way things look, AS PER THE USER'S REQUEST! R.

Re: text search balloon background colour

Kai Uwe Broulik wrote: Hi, > it was adjusted to more closely resemble the Breeze visual style. The colors > are unfortunately hardcoded as KWidgetAddons as a Tier 1 framework cannot > depend on KColorScheme. Yeah, that's not good, hardcoding colours is in fact a bug because it can lead to

D9446: WIP: Allow to autogenerate and install categories file

cgiboudeaux added a comment. In D9446#284272 , @habacker wrote: > In D9446#181785 , @mlaurent wrote: > > > IT's a WIP as I use file(APPEND...) because I want to generate several categories in one

D9446: WIP: Allow to autogenerate and install categories file

habacker added a comment. In D9446#181785 , @mlaurent wrote: > IT's a WIP as I use file(APPEND...) because I want to generate several categories in one file. > But it doesn't work as I don't have idea how to reset file when cmake is

D13747: Fuzzy filename search for Baloo

michaeleden updated this revision to Diff 36811. michaeleden added a comment. Add fuzzy search class separate from db and make tests to demonstrate algorithm REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13747?vs=36724=36811 BRANCH feature/fuzzy-search