KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 88 - Still Unstable!

2018-07-01 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/88/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 02 Jul 2018 02:02:35 +
 Build duration:
7 min 58 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(69/81)85%
(69/81)75%
(6239/8332)43%
(10009/23183)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2665/2741)49%
(5715/11731)src.desktoptojson100%
(2/2)100%
(2/2)78%
(88/113)38%
(123/326)src.lib50%
(1/2)50%
(1/2)61%
(351/572)26%
(243/928)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/782)18%
(184/1038)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1047/2821)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(652/767)42%
(968/2305)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)47%
(368/778)45%
(846/1899)src.lib.util100%
(10/10)100%
(10/10)80%
(680/852)52%
(787/1523)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.10 - Build # 11 - Still Unstable!

2018-07-01 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.10/11/
 Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.10
 Date of build:
Mon, 02 Jul 2018 02:02:35 +
 Build duration:
4 min 2 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 20 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_qfswatch_unittestFailed: TestSuite.kdirwatch_stat_unittest

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 - Build # 33 - Still Unstable!

2018-07-01 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.9/33/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 02 Jul 2018 02:02:35 +
 Build duration:
3 min 8 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(69/81)85%
(69/81)75%
(6240/8332)43%
(10010/23181)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2665/2741)49%
(5716/11733)src.desktoptojson100%
(2/2)100%
(2/2)78%
(88/113)38%
(122/322)src.lib50%
(1/2)50%
(1/2)62%
(352/572)26%
(243/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/782)18%
(184/1038)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1049/2827)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(652/767)42%
(968/2303)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)47%
(368/778)44%
(845/1899)src.lib.util100%
(10/10)100%
(10/10)80%
(680/852)52%
(787/1523)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

D13829: Lua: fix multi-line string

2018-07-01 Thread Nathaniel Graham 
ngraham added reviewers: cullmann, KTextEditor, Kate.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D13829

To: jpoelen, dhaumann, cullmann, #ktexteditor, #kate
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13813: make this test work again with new uds implementation

2018-07-01 Thread Nathaniel Graham 
ngraham added a comment.


  FWIW, I'd be okay with bumping the minimum KIO version to 5.47 in master.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D13813

To: jtamate, #dolphin, #frameworks, elvisangelaccio
Cc: ngraham, bruns, elvisangelaccio, kfm-devel, spoorun, navarromorales, 
isidorov, firef, andrebarros, emmanuelp

D13814: Speedup sort

2018-07-01 Thread Aleix Pol Gonzalez 
apol added a comment.


  +1 otherwise.

INLINE COMMENTS

> kfileitemmodel.cpp:1715
>  {
> -KFileItemModelLessThan lessThan(this, m_collator);
> +auto lanbdaLessThan = [&] (const KFileItemModel::ItemData* a, const 
> KFileItemModel::ItemData* b)
> +{

it's "lambda".

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D13814

To: jtamate, #dolphin, #frameworks
Cc: apol, bruns, markg, kfm-devel, spoorun, navarromorales, isidorov, firef, 
andrebarros, emmanuelp

D13124: [RFC] Add Share action to Dolphin context menu

2018-07-01 Thread Aleix Pol Gonzalez 
apol added a comment.


  Looks good to me overall.
  
  Maybe it would make sense to call it ShareFileItemAction everywhere? 
"purpose" is an implementation detail here.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D13124

To: nicolasfella, apol
Cc: markg, broulik, kde-frameworks-devel, elvisangelaccio, ngraham, apol, 
kfm-devel, #dolphin, michaelh, spoorun, navarromorales, isidorov, firef, 
andrebarros, bruns, emmanuelp

D13559: Fix some of cppcheck warnings

2018-07-01 Thread Aleix Pol Gonzalez 
apol added a comment.


  I don't see any fix here. It's just silencing cppcheck.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D13559

To: bshah, #frameworks
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D13403: Android: Make it possible to override a target's APK directory

2018-07-01 Thread Aleix Pol Gonzalez 
apol updated this revision to Diff 37024.
apol added a comment.


  Remove unrelated change

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13403?vs=35751=37024

BRANCH
  arcpatch-D13403

REVISION DETAIL
  https://phabricator.kde.org/D13403

AFFECTED FILES
  toolchain/Android.cmake
  toolchain/ECMAndroidDeployQt.cmake
  toolchain/deployment-file.json.in

To: apol, #frameworks
Cc: vkrause, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D13643: Add LabPlot project file icon

2018-07-01 Thread Nathaniel Graham 
ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D13643

To: mtrescott, #labplot, #vdg, #breeze, ngraham
Cc: abetts, asemke, ngraham, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 182 - Still Unstable!

2018-07-01 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/182/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 01 Jul 2018 22:16:54 +
 Build duration:
3 min 13 sec and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)31%
(39/126)31%
(39/126)27%
(3489/13084)19%
(1785/9412)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests79%
(11/14)79%
(11/14)53%
(588/1113)29%
(310/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core19%
(3/16)19%
(3/16)11%
(252/2208)7%
(94/1432)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma55%
(12/22)55%
(12/22)41%
(1410/3477)30%
(779/2613)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/135)0%
(0/12)src.plasma.private47%
(9/19)47%
(9/19)43%
(661/1540)30%
(300/1001)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)28%
(547/1973)17%
(297/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1096)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 - Build # 32 - Still Unstable!

2018-07-01 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.10/32/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10
 Date of build:
Sun, 01 Jul 2018 22:16:55 +
 Build duration:
3 min 25 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

D13643: Add LabPlot project file icon

2018-07-01 Thread Andres Betts 
abetts added a comment.


  Oh great! I thought the team was looking for a logo. Then, I have nothing 
more to add. It looks great.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D13643

To: mtrescott, #labplot, #vdg, #breeze
Cc: abetts, asemke, ngraham, kde-frameworks-devel, michaelh, bruns

D13643: Add LabPlot project file icon

2018-07-01 Thread Nathaniel Graham 
ngraham added a comment.


  In D13643#285745 , @abetts wrote:
  
  > My first impression is that it looks a lot like a file emblem. I would 
probably remove the background and keep only the logo.
  
  
  But it //is// a file icon...
  
  Typically the way these are done with the Breeze icon theme is that the small 
size shows only the icon, while the larger size uses a generic colored document 
icon with the app's icon or else some other symbolic icon in the center.
  
  I think this looks great!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D13643

To: mtrescott, #labplot, #vdg, #breeze
Cc: abetts, asemke, ngraham, kde-frameworks-devel, michaelh, bruns

D13813: make this test work again with new uds implementation

2018-07-01 Thread Elvis Angelaccio 
elvisangelaccio requested changes to this revision.
elvisangelaccio added a comment.
This revision now requires changes to proceed.


  In D13813#285441 , @jtamate wrote:
  
  > Updated the patch with context.
  >
  > It will not work with kio previous to 5.47, unless there is a way to check 
the kio version at compile time or runtime.
  
  
  There is, but maybe a better idea is to bump the minimum required version of 
KIO at 5.47 (I'm assuming the new UDS implementation is worth having it?)

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D13813

To: jtamate, #dolphin, #frameworks, elvisangelaccio
Cc: bruns, elvisangelaccio, kfm-devel, spoorun, navarromorales, isidorov, 
firef, andrebarros, emmanuelp

D13805: Present error dialog when user tries to create directory named "." or ".."

2018-07-01 Thread Elvis Angelaccio 
elvisangelaccio requested changes to this revision.
elvisangelaccio added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> knewfilemenu.cpp:860
> +// Test to see if the user has given "." or ".." as a name
> +if (name == "." || name == "..") {
> +KGuiItem cancelGuiItem(KStandardGuiItem::cancel());

Please use `QLatin1String` here, which is faster for string comparisons.

> knewfilemenu.cpp:874
> +KMessageBox::createKMessageBox(confirmDialog, buttonBox, 
> QMessageBox::Critical,
> +   i18n("Folder \"%1\" could not be 
> created:\n\"%1\" is reserved for use by the operating system.", name),
> +   QStringList(),

Please use semantic markup here: 
https://api.kde.org/frameworks/ki18n/html/prg_guide.html#kuit_markup

tl;dr use `%1` instead of `\"%1\"` and `` instead of 
`\n`

> knewfilemenu.cpp:876
> +   QStringList(),
> +   "",
> +   nullptr,

Please use `QString()` here

> knewfilemenu.cpp:884
> +confirmDialog->show();
> +m_text = "";
> +return;

`m_text = QString()`, like we already do in `_k_slotAbortDialog()`.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13805

To: tmarshall, #dolphin, #frameworks, ngraham, dfaure, elvisangelaccio
Cc: cfeck, elvisangelaccio, dfaure, tmarshall, bruns, ngraham, 
kde-frameworks-devel, michaelh, spoorun, navarromorales, isidorov, firef, 
andrebarros, emmanuelp

D13643: Add LabPlot project file icon

2018-07-01 Thread Andres Betts 
abetts added a comment.


  My first impression is that it looks a lot like a file emblem. I would 
probably remove the background and keep only the logo.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D13643

To: mtrescott, #labplot, #vdg, #breeze
Cc: abetts, asemke, ngraham, kde-frameworks-devel, michaelh, bruns

D13643: Add LabPlot project file icon

2018-07-01 Thread Alexander Semke 
asemke added a comment.


  Thank for this work. It looks nice to me. However, maybe it's better for 
people from VDG and Breeze teams to accept this or to raise objections.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D13643

To: mtrescott, #labplot, #vdg, #breeze
Cc: asemke, ngraham, kde-frameworks-devel, michaelh, bruns

D13814: Speedup sort

2018-07-01 Thread Mark Gaiser 
markg added a comment.


  In D13814#285686 , @bruns wrote:
  
  > In D13814#285660 , @markg wrote:
  >
  > > > I don't know if that's still an issue or if your patch re-introduces 
whatever the problem was (race conditions?). You could look back in the commit 
log when that was added to figure out more about it.
  > >
  > > To answer that myself, it was done in this commit: 
https://cgit.kde.org/dolphin.git/commit/src/kitemviews/kfileitemmodel.cpp?id=d9680ead8099df9a2b06bfed61a62923778996f2
  > >  And doesn't explain anything :)
  >
  >
  > If you follow the link in the comment, i.e. 
https://bugs.kde.org/show_bug.cgi?id=312679, it mentions date sorting and 
KDateTime being non-reentrant.
  
  
  That would be really interesting as KDateTime isn't used anywhere in Dolphin 
anymore (according to my grep on the source). It's all QDateTime now and that 
is all reentrant according to the Qt docs!
  In other words, the fix for that can probably be removed now.
  
  Just an assumption though. I haven't tried anything.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D13814

To: jtamate, #dolphin, #frameworks
Cc: bruns, markg, kfm-devel, spoorun, navarromorales, isidorov, firef, 
andrebarros, emmanuelp

D13805: Present error dialog when user tries to create directory named "." or ".."

2018-07-01 Thread David Faure 
dfaure added a comment.


  Well, it makes sense for this check to be at the GUI level, the user 
interaction can be better adapted then, as in this patch.
  
  KIO::mkpath("/home/dfaure/tmp/.") should at least not warn or error in any 
way IMHO.
  
  (btw mkdir of such a path, on the command line, always fails: either the tmp 
dir exists and it says "already exists", or it doesn't exist and it can't 
create the parent dir first)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13805

To: tmarshall, #dolphin, #frameworks, ngraham, dfaure
Cc: cfeck, elvisangelaccio, dfaure, tmarshall, bruns, ngraham, 
kde-frameworks-devel, michaelh, spoorun, navarromorales, isidorov, firef, 
andrebarros, emmanuelp

D13124: [RFC] Add Share action to Dolphin context menu

2018-07-01 Thread Nicolas Fella 
nicolasfella added a comment.


  @apol ping?

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D13124

To: nicolasfella, apol
Cc: markg, broulik, kde-frameworks-devel, elvisangelaccio, ngraham, apol, 
kfm-devel, #dolphin, michaelh, spoorun, navarromorales, isidorov, firef, 
andrebarros, bruns, emmanuelp

D13814: Speedup sort

2018-07-01 Thread Jaime Torres Amate 
jtamate updated this revision to Diff 37019.
jtamate added a comment.


  Can not use the name lessThan because of:  error: use of ‘lessThan’ before 
deduction of ‘auto’

REPOSITORY
  R318 Dolphin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13814?vs=37010=37019

REVISION DETAIL
  https://phabricator.kde.org/D13814

AFFECTED FILES
  src/kitemviews/kfileitemmodel.cpp

To: jtamate, #dolphin, #frameworks
Cc: bruns, markg, kfm-devel, spoorun, navarromorales, isidorov, firef, 
andrebarros, emmanuelp

D13814: Speedup sort

2018-07-01 Thread Jaime Torres Amate 
jtamate added a comment.


  In D13814#285691 , @bruns wrote:
  
  > I assume you are sorting by name with "natural sorting". There may be 
another possibility for speedup here:
  >  `QCollator::sortkey()`,  http://doc.qt.io/qt-5/qcollator.html#sortKey
  >
  > It might be possible to generate the sortkey in e.g. 
https://phabricator.kde.org/source/dolphin/browse/master/src/kitemviews/kfileitemmodel.cpp$1334
  
  
  Unfortunately is not a trivial change, because it uses a  and  QCollatorSortKey can not be transformed into a QVariant, 
therefore it will not be in in this patch.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D13814

To: jtamate, #dolphin, #frameworks
Cc: bruns, markg, kfm-devel, spoorun, navarromorales, isidorov, firef, 
andrebarros, emmanuelp

D13814: Speedup sort

2018-07-01 Thread Stefan Brüns 
bruns added a comment.


  I assume you are sorting by name with "natural sorting". There may be another 
possibility for speedup here:
  `QCollator::sortkey()`,  http://doc.qt.io/qt-5/qcollator.html#sortKey
  
  It might be possible to generate the sortkey in e.g. 
https://phabricator.kde.org/source/dolphin/browse/master/src/kitemviews/kfileitemmodel.cpp$1334

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D13814

To: jtamate, #dolphin, #frameworks
Cc: bruns, markg, kfm-devel, spoorun, navarromorales, isidorov, firef, 
andrebarros, emmanuelp

D13814: Speedup sort

2018-07-01 Thread Jaime Torres Amate 
jtamate updated this revision to Diff 37010.
jtamate added a comment.


  Remove the _ prefix.

REPOSITORY
  R318 Dolphin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13814?vs=36953=37010

REVISION DETAIL
  https://phabricator.kde.org/D13814

AFFECTED FILES
  src/kitemviews/kfileitemmodel.cpp

To: jtamate, #dolphin, #frameworks
Cc: bruns, markg, kfm-devel, spoorun, navarromorales, isidorov, firef, 
andrebarros, emmanuelp

D13814: Speedup sort

2018-07-01 Thread Jaime Torres Amate 
jtamate added a comment.


  In D13814#285686 , @bruns wrote:
  
  > In D13814#285660 , @markg wrote:
  >
  > > > I don't know if that's still an issue or if your patch re-introduces 
whatever the problem was (race conditions?). You could look back in the commit 
log when that was added to figure out more about it.
  > >
  > > To answer that myself, it was done in this commit: 
https://cgit.kde.org/dolphin.git/commit/src/kitemviews/kfileitemmodel.cpp?id=d9680ead8099df9a2b06bfed61a62923778996f2
  > >  And doesn't explain anything :)
  >
  >
  > If you follow the link in the comment, i.e. 
https://bugs.kde.org/show_bug.cgi?id=312679, it mentions date sorting and 
KDateTime being non-reentrant.
  
  
  Yes, that is why parallelMergeSort is only used to sort by name. All methods 
of QCollator are reentrant (http://doc.qt.io/qt-5/qcollator.html)

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D13814

To: jtamate, #dolphin, #frameworks
Cc: bruns, markg, kfm-devel, spoorun, navarromorales, isidorov, firef, 
andrebarros, emmanuelp

D13814: Speedup sort

2018-07-01 Thread Stefan Brüns 
bruns added a comment.


  In D13814#285660 , @markg wrote:
  
  > > I don't know if that's still an issue or if your patch re-introduces 
whatever the problem was (race conditions?). You could look back in the commit 
log when that was added to figure out more about it.
  >
  > To answer that myself, it was done in this commit: 
https://cgit.kde.org/dolphin.git/commit/src/kitemviews/kfileitemmodel.cpp?id=d9680ead8099df9a2b06bfed61a62923778996f2
  >  And doesn't explain anything :)
  
  
  If you follow the link in the comment, i.e. 
https://bugs.kde.org/show_bug.cgi?id=312679, it mentions date sorting and 
KDateTime being non-reentrant.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D13814

To: jtamate, #dolphin, #frameworks
Cc: bruns, markg, kfm-devel, spoorun, navarromorales, isidorov, firef, 
andrebarros, emmanuelp

D13829: Lua: fix multi-line string

2018-07-01 Thread jonathan poelen 
jpoelen created this revision.
jpoelen added a reviewer: dhaumann.
Restricted Application added a project: Frameworks.
Restricted Application edited subscribers, added: kde-frameworks-devel; 
removed: Frameworks.
jpoelen requested review of this revision.

REVISION SUMMARY
  Strings that end with \z or \ can continue to the next line
  
  BUG: 395515

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  lua

REVISION DETAIL
  https://phabricator.kde.org/D13829

AFFECTED FILES
  autotests/folding/highlight.lua.fold
  autotests/html/highlight.lua.html
  autotests/input/highlight.lua
  autotests/reference/highlight.lua.ref
  data/syntax/lua.xml

To: jpoelen, dhaumann
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13814: Speedup sort

2018-07-01 Thread Mark Gaiser 
markg added a comment.


  > I don't know if that's still an issue or if your patch re-introduces 
whatever the problem was (race conditions?). You could look back in the commit 
log when that was added to figure out more about it.
  
  To answer that myself, it was done in this commit: 
https://cgit.kde.org/dolphin.git/commit/src/kitemviews/kfileitemmodel.cpp?id=d9680ead8099df9a2b06bfed61a62923778996f2
  And doesn't explain anything :)

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D13814

To: jtamate, #dolphin, #frameworks
Cc: markg, kfm-devel, spoorun, navarromorales, isidorov, firef, andrebarros, 
emmanuelp

D13814: Speedup sort

2018-07-01 Thread Mark Gaiser 
markg added a comment.


  +1
  
  Great! :) Back to the good old fast performance it once had!
  Please do get rid of the underscore before the name. Nothing (afaict) does 
that in Dolphin, lets not introduce it. Just lessThan is fine.
  
  Also, note that this was done for a reason. I think it was the one in the 
comment: "non-reentrant comparison functions" which is why the roles other then 
NameRole are using single-threaded sort.
  I don't know if that's still an issue or if your patch re-introduces whatever 
the problem was (race conditions?). You could look back in the commit log when 
that was added to figure out more about it.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D13814

To: jtamate, #dolphin, #frameworks
Cc: markg, kfm-devel, spoorun, navarromorales, isidorov, firef, andrebarros, 
emmanuelp

D13828: Revert "updated Japanese holidays (in Japanese and English)"

2018-07-01 Thread Jumpei Ogawa 
phanect edited the summary of this revision.
phanect added reviewers: KDE PIM, Frameworks, winterz, mlaurent.
phanect added subscribers: winterz, mlaurent.

REPOSITORY
  R175 PIM: KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D13828

To: phanect, #kde_pim, #frameworks, winterz, mlaurent
Cc: mlaurent, winterz, kde-pim, dvasin, rodsevich, vkrause, knauss, dvratil

D13812: Revert "updated Japanese holidays (in Japanese and English)"

2018-07-01 Thread Jumpei Ogawa 
phanect added a comment.


  Sorry, I made another code review request by mistake: 
https://phabricator.kde.org/D13828
  Please close this request and continue with D13828 
.

REPOSITORY
  R175 PIM: KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D13812

To: phanect, #kde_pim, #frameworks, winterz, mlaurent
Cc: mlaurent, winterz, kde-pim, dvasin, rodsevich, vkrause, knauss, dvratil

D13812: Revert "updated Japanese holidays (in Japanese and English)"

2018-07-01 Thread Jumpei Ogawa 
phanect edited the summary of this revision.

REPOSITORY
  R175 PIM: KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D13812

To: phanect, #kde_pim, #frameworks, winterz, mlaurent
Cc: mlaurent, winterz, kde-pim, dvasin, rodsevich, vkrause, knauss, dvratil

D13627: [KIconThemes] Isolate private data from race conditions

2018-07-01 Thread Anthony Fieroni 
anthonyfieroni added a comment.


  Also notice functions after 
https://phabricator.kde.org/source/kiconthemes/browse/master/src/kiconloader.cpp$1693
 there is no guaranteed that they should be run in same thread. I manage to 
downgrade Qt 5.11 and upgrade again there is not broken icons after.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D13627

To: anthonyfieroni, davidedmundson, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13819: dummy commit to test pre-review CI

2018-07-01 Thread Jenkins-CI 
jenkins-ci added a comment.


  Build is green https://build.kde.org/job/test/19/ for more details.

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D13819

To: bshah
Cc: jenkins-ci, kde-frameworks-devel, michaelh, ngraham, bruns

D13819: dummy commit to test pre-review CI

2018-07-01 Thread Bhushan Shah 
bshah updated this revision to Diff 37004.
bshah added a comment.


  - fix tests

REPOSITORY
  R243 KArchive

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13819?vs=36992=37004

BRANCH
  bshah

REVISION DETAIL
  https://phabricator.kde.org/D13819

AFFECTED FILES
  CMakeLists.txt

To: bshah
Cc: jenkins-ci, kde-frameworks-devel, michaelh, ngraham, bruns

D13559: Fix some of cppcheck warnings

2018-07-01 Thread Bhushan Shah 
bshah added a comment.


  bump?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D13559

To: bshah, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13777: KMessageWidget : revert to using highlight colour for Information style (WIP)

2018-07-01 Thread René J . V . Bertin 
rjvbb set the repository for this revision to R236 KWidgetsAddons.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D13777

To: rjvbb, ngraham, #frameworks
Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

D13777: KMessageWidget : revert to using highlight colour for Information style (WIP)

2018-07-01 Thread René J . V . Bertin 
rjvbb updated this revision to Diff 37000.
rjvbb added a comment.


  KThemeSettings moved to its own header+implementation files, and extended so 
different groups can be read. I don't think it needs much else in terms of 
functionality or complexity, if anything. There's no point in exporting it 
anyway (so it has a very specific target audience).
  
  Let's please do most of the preparatory work here so I don't have to juggle 
more than 1 review/diff that concerns multiple files in the same directory for 
longer than strictly necessary.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13777?vs=36943=37000

REVISION DETAIL
  https://phabricator.kde.org/D13777

AFFECTED FILES
  src/CMakeLists.txt
  src/kmessagewidget.cpp
  src/kthemesettings.cpp
  src/kthemesettings_p.h

To: rjvbb, ngraham, #frameworks
Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.9 - Build # 103 - Fixed!

2018-07-01 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.9/103/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 01 Jul 2018 10:24:38 +
 Build duration:
23 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 15 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(9/18)45%
(57/126)45%
(57/126)39%
(5171/13152)29%
(2724/9412)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(13/14)93%
(13/14)96%
(1073/1117)51%
(555/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core44%
(7/16)44%
(7/16)33%
(746/2232)27%
(384/1432)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)48%
(1692/3491)39%
(1019/2613)src.plasma.packagestructure57%
(4/7)57%
(4/7)37%
(51/138)42%
(5/12)src.plasma.private63%
(12/19)63%
(12/19)61%
(942/1554)42%
(424/1001)src.plasma.scripting67%
(2/3)67%
(2/3)20%
(34/166)10%
(13/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)30%
(589/1975)19%
(319/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid17%
(1/6)17%
(1/6)1%
(13/1098)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%
(0/2)0%
(0/61)0%
(0/16)tests.testengine0%
(0/1)0%

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.10 - Build # 21 - Fixed!

2018-07-01 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.10/21/
 Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.10
 Date of build:
Sun, 01 Jul 2018 10:30:50 +
 Build duration:
7 min 32 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 66 test(s), Skipped: 0 test(s), Total: 66 test(s)

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 181 - Still unstable!

2018-07-01 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/181/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 01 Jul 2018 10:24:39 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)31%
(39/126)31%
(39/126)27%
(3489/13084)19%
(1785/9412)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests79%
(11/14)79%
(11/14)53%
(588/1113)29%
(310/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core19%
(3/16)19%
(3/16)11%
(252/2208)7%
(94/1432)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma55%
(12/22)55%
(12/22)41%
(1410/3477)30%
(779/2613)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/135)0%
(0/12)src.plasma.private47%
(9/19)47%
(9/19)43%
(661/1540)30%
(300/1001)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)28%
(547/1973)17%
(297/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1096)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.10 - Build # 20 - Unstable!

2018-07-01 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.10/20/
 Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.10
 Date of build:
Sun, 01 Jul 2018 10:22:42 +
 Build duration:
8 min 5 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 65 test(s), Skipped: 0 test(s), Total: 66 test(s)Failed: TestSuite.completion_test

D13819: dummy commit to test pre-review CI

2018-07-01 Thread Jenkins-CI 
jenkins-ci added a comment.


  Build is unstable
  
  Link to build: https://build.kde.org/job/test/18/
  See console output for more information: 
https://build.kde.org/job/test/18/console

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D13819

To: bshah
Cc: jenkins-ci, kde-frameworks-devel, michaelh, ngraham, bruns

D13819: dummy commit to test pre-review CI

2018-07-01 Thread Bhushan Shah 
bshah updated this revision to Diff 36992.
bshah added a comment.


  - less fun, but this time try failing unit test

REPOSITORY
  R243 KArchive

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13819?vs=36991=36992

BRANCH
  bshah

REVISION DETAIL
  https://phabricator.kde.org/D13819

AFFECTED FILES
  CMakeLists.txt
  autotests/karchivetest.cpp

To: bshah
Cc: jenkins-ci, kde-frameworks-devel, michaelh, ngraham, bruns

D13819: dummy commit to test pre-review CI

2018-07-01 Thread Phabricator 
Harbormaster failed remote builds in B520: Diff 36991!

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D13819

To: bshah
Cc: jenkins-ci, kde-frameworks-devel, michaelh, ngraham, bruns

D13819: dummy commit to test pre-review CI

2018-07-01 Thread Jenkins-CI 
jenkins-ci added a comment.


  Build has FAILED
  
  Link to build: https://build.kde.org/job/test/17/
  See console output for more information: 
https://build.kde.org/job/test/17/console

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D13819

To: bshah
Cc: jenkins-ci, kde-frameworks-devel, michaelh, ngraham, bruns

D13819: dummy commit to test pre-review CI

2018-07-01 Thread Bhushan Shah 
bshah updated this revision to Diff 36991.
bshah added a comment.


  - find qt5 fun, because that will make build fail

REPOSITORY
  R243 KArchive

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13819?vs=36989=36991

BRANCH
  bshah

REVISION DETAIL
  https://phabricator.kde.org/D13819

AFFECTED FILES
  CMakeLists.txt

To: bshah
Cc: jenkins-ci, kde-frameworks-devel, michaelh, ngraham, bruns

D13819: dummy commit to test pre-review CI

2018-07-01 Thread Jenkins-CI 
jenkins-ci added a comment.


  Build is green https://build.kde.org/job/test/16/ for more details.

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D13819

To: bshah
Cc: jenkins-ci, kde-frameworks-devel, michaelh, ngraham, bruns

D13819: dummy commit to test pre-review CI

2018-07-01 Thread Bhushan Shah 
bshah updated this revision to Diff 36989.
bshah added a comment.


  - final change handover chnage

REPOSITORY
  R243 KArchive

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13819?vs=36988=36989

BRANCH
  bshah

REVISION DETAIL
  https://phabricator.kde.org/D13819

AFFECTED FILES
  CMakeLists.txt

To: bshah
Cc: jenkins-ci, kde-frameworks-devel, michaelh, ngraham, bruns

D13819: dummy commit to test pre-review CI

2018-07-01 Thread Jenkins-CI 
jenkins-ci added a comment.


  Build is green https://build.kde.org/job/test/15/ for more details.

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D13819

To: bshah
Cc: jenkins-ci, kde-frameworks-devel, michaelh, ngraham, bruns

D13819: dummy commit to test pre-review CI

2018-07-01 Thread Phabricator 
Harbormaster failed remote builds in B517: Diff 36988!

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D13819

To: bshah
Cc: jenkins-ci, kde-frameworks-devel, michaelh, ngraham, bruns

D13819: dummy commit to test pre-review CI

2018-07-01 Thread Jenkins-CI 
jenkins-ci added a comment.


  Build has FAILED
  
  Link to build: https://build.kde.org/job/test/14/
  See console output for more information: 
https://build.kde.org/job/test/14/console

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D13819

To: bshah
Cc: jenkins-ci, kde-frameworks-devel, michaelh, ngraham, bruns

D13819: dummy commit to test pre-review CI

2018-07-01 Thread Bhushan Shah 
bshah updated this revision to Diff 36988.
bshah added a comment.


  - enough derps

REPOSITORY
  R243 KArchive

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13819?vs=36987=36988

BRANCH
  bshah

REVISION DETAIL
  https://phabricator.kde.org/D13819

AFFECTED FILES
  CMakeLists.txt

To: bshah
Cc: jenkins-ci, kde-frameworks-devel, michaelh, ngraham, bruns

D13819: dummy commit to test pre-review CI

2018-07-01 Thread Jenkins-CI 
jenkins-ci added a comment.


  Build has FAILED
  
  Link to build: https://build.kde.org/job/test/13/
  See console output for more information: 
https://build.kde.org/job/test/13/console

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D13819

To: bshah
Cc: jenkins-ci, kde-frameworks-devel, michaelh, ngraham, bruns

D13819: dummy commit to test pre-review CI

2018-07-01 Thread Phabricator 
Harbormaster failed remote builds in B516: Diff 36987!

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D13819

To: bshah
Cc: jenkins-ci, kde-frameworks-devel, michaelh, ngraham, bruns

D13819: dummy commit to test pre-review CI

2018-07-01 Thread Bhushan Shah 
bshah updated this revision to Diff 36987.
bshah added a comment.


  - derp

REPOSITORY
  R243 KArchive

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13819?vs=36986=36987

BRANCH
  bshah

REVISION DETAIL
  https://phabricator.kde.org/D13819

AFFECTED FILES
  CMakeLists.txt

To: bshah
Cc: jenkins-ci, kde-frameworks-devel, michaelh, ngraham, bruns

D13805: Present error dialog when user tries to create directory named "." or ".."

2018-07-01 Thread Thomas Marshall 
tmarshall added a comment.


  @ngraham
  
  Name: Thomas Marshall
  Email: tmarshall7...@gmail.com

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13805

To: tmarshall, #dolphin, #frameworks, ngraham, dfaure
Cc: cfeck, elvisangelaccio, dfaure, tmarshall, bruns, ngraham, 
kde-frameworks-devel, michaelh, spoorun, navarromorales, isidorov, firef, 
andrebarros, emmanuelp

D13819: dummy commit to test pre-review CI

2018-07-01 Thread Phabricator 
Harbormaster failed remote builds in B515: Diff 36986!

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D13819

To: bshah
Cc: jenkins-ci, kde-frameworks-devel, michaelh, ngraham, bruns

D13819: dummy commit to test pre-review CI

2018-07-01 Thread Jenkins-CI 
jenkins-ci added a comment.


  Build has FAILED
  
  Link to build: https://build.kde.org/job/test/12/
  See console output for more information: 
https://build.kde.org/job/test/12/console

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D13819

To: bshah
Cc: jenkins-ci, kde-frameworks-devel, michaelh, ngraham, bruns

D13819: dummy commit to test pre-review CI

2018-07-01 Thread Bhushan Shah 
bshah updated this revision to Diff 36986.
bshah added a comment.


  - derp

REPOSITORY
  R243 KArchive

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13819?vs=36985=36986

BRANCH
  bshah

REVISION DETAIL
  https://phabricator.kde.org/D13819

AFFECTED FILES
  CMakeLists.txt

To: bshah
Cc: jenkins-ci, kde-frameworks-devel, michaelh, ngraham, bruns

D13819: dummy commit to test pre-review CI

2018-07-01 Thread Phabricator 
Harbormaster failed remote builds in B514: Diff 36985!

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D13819

To: bshah
Cc: jenkins-ci, kde-frameworks-devel, michaelh, ngraham, bruns

D13819: dummy commit to test pre-review CI

2018-07-01 Thread Bhushan Shah 
bshah updated this revision to Diff 36985.
bshah added a comment.


  - edit 4, to check change handover works

REPOSITORY
  R243 KArchive

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13819?vs=36982=36985

BRANCH
  bshah

REVISION DETAIL
  https://phabricator.kde.org/D13819

AFFECTED FILES
  CMakeLists.txt

To: bshah
Cc: jenkins-ci, kde-frameworks-devel, michaelh, ngraham, bruns

D13819: dummy commit to test pre-review CI

2018-07-01 Thread Jenkins-CI 
jenkins-ci added a comment.


  Build has FAILED
  
  Link to build: https://build.kde.org/job/test/11/
  See console output for more information: 
https://build.kde.org/job/test/11/console

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D13819

To: bshah
Cc: jenkins-ci, kde-frameworks-devel, michaelh, ngraham, bruns

D13819: dummy commit to test pre-review CI

2018-07-01 Thread Bhushan Shah 
bshah created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
Harbormaster failed remote builds in B508: Diff 36977!
Harbormaster returned this revision to the author for changes because remote 
builds failed.
bshah updated this revision to Diff 36979.
bshah added a comment.
Harbormaster failed remote builds in B509: Diff 36979!
Harbormaster returned this revision to the author for changes because remote 
builds failed.
bshah updated this revision to Diff 36980.
Harbormaster failed remote builds in B510: Diff 36980!
Harbormaster returned this revision to the author for changes because remote 
builds failed.
bshah updated this revision to Diff 36982.
Harbormaster failed remote builds in B511: Diff 36982!
Harbormaster returned this revision to the author for changes because remote 
builds failed.
bshah requested review of this revision.


  - edit 1 to re-trigger failed CI

bshah added a comment.


  - 2nd time is charm

bshah added a comment.


  - edit 3, let's try this

jenkins-ci added a comment.


  Build is green https://build.kde.org/job/test/10/ for more details.

REVISION SUMMARY
  please ignore this, it is part of work to test the upcoming pre-review CI

REPOSITORY
  R243 KArchive

BRANCH
  bshah

REVISION DETAIL
  https://phabricator.kde.org/D13819

AFFECTED FILES
  CMakeLists.txt

To: bshah
Cc: jenkins-ci, kde-frameworks-devel, michaelh, ngraham, bruns