KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 76 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/76/ Project: Frameworks purpose kf5-qt5 SUSEQt5.10 Date of build: Wed, 11 Jul 2018 03:26:12 + Build duration: 7 min 35 sec and counting JUnit Tests

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 77 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/77/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Wed, 11 Jul 2018 03:25:52 + Build duration: 4 min 54 sec and counting JUnit Tests

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 53 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/53/ Project: Frameworks purpose kf5-qt5 SUSEQt5.9 Date of build: Wed, 11 Jul 2018 03:26:12 + Build duration: 2 min 6 sec and counting JUnit Tests Name:

D14020: RPM Spec: add MIME type

nibags added a comment. Ok! REPOSITORY R216 Syntax Highlighting BRANCH add-mime-rpmspec REVISION DETAIL https://phabricator.kde.org/D14020 To: nibags, #framework_syntax_highlighting, vkrause Cc: kwrite-devel, bcooksley, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns,

D13814: Speedup sort

bruns added inline comments. INLINE COMMENTS > kfileitemmodel.cpp:58 > { > m_collator.setNumericMode(true); > this causes the dirty state - maybe also do the forced (re)initialization here? > kfileitemmodel.cpp:112 > +// Workaround for bug

D13814: Speedup sort

elvisangelaccio accepted this revision. elvisangelaccio added a comment. This revision is now accepted and ready to land. Thanks for filing the upstream bug. Looks good to me now. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D13814 To: jtamate, #dolphin,

D14022: Use non deprecated fastInsert in baloo

This revision was automatically updated to reflect the committed changes. Closed by commit R293:b806c88c6bcc: Use non deprecated fastInsert in baloo (authored by jtamate). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14022?vs=37493=37524 REVISION DETAIL

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 52 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/52/ Project: Frameworks purpose kf5-qt5 SUSEQt5.9 Date of build: Tue, 10 Jul 2018 18:59:06 + Build duration: 2 min 6 sec and counting JUnit Tests Name:

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 75 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/75/ Project: Frameworks purpose kf5-qt5 SUSEQt5.10 Date of build: Tue, 10 Jul 2018 18:59:06 + Build duration: 1 min 59 sec and counting JUnit Tests

D13933: [Purpose]: use Arc's status colours for the Phab plugin drop-down list (WIP)

This revision was automatically updated to reflect the committed changes. Closed by commit R495:6d518089aa1c: Prepare to use Arcs status colours in the revision drop-down list (authored by rjvbb). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D13933?vs=37292=37523#toc REPOSITORY R495

D13816: Make KItinerary work as a static library

lepagevalleeemmanuel added inline comments. INLINE COMMENTS > CMakeLists.txt:50 > > -add_library(KPimItinerary SHARED ${kitinerary_lib_srcs}) > +add_library(KPimItinerary ${kitinerary_lib_srcs}) > add_library(KPim::Itinerary ALIAS KPimItinerary) Ok, thanks. So it's a "Ship it!" for my point

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 184 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/184/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Tue, 10 Jul 2018 16:57:20 + Build duration: 6 min 4 sec and counting

D13973: Honor BUILD_TESTING

This revision was automatically updated to reflect the committed changes. Closed by commit R296:fdd04af53dae: Honor BUILD_TESTING (authored by arojas). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13973?vs=37347=37515 REVISION DETAIL

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 - Build # 34 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.10/34/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 10 Jul 2018 16:57:20 + Build duration: 2 min 43 sec and counting

D13982: Honor BUILD_TESTING

This revision was automatically updated to reflect the committed changes. Closed by commit R242:061588dcd6cc: Honor BUILD_TESTING (authored by arojas). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13982?vs=37359=37514 REVISION DETAIL

D13957: Honor BUILD_TESTING

This revision was automatically updated to reflect the committed changes. Closed by commit R302:f059164f8aba: Honor BUILD_TESTING (authored by arojas). REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13957?vs=37324=37513 REVISION DETAIL

D13944: Honor BUILD_TESTING

This revision was automatically updated to reflect the committed changes. Closed by commit R238:6303431a9405: Honor BUILD_TESTING (authored by arojas). REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13944?vs=37310=37512 REVISION DETAIL

D14000: qqc2-desktop-style: basic support for QGuiApplication-based apps (WIP/PoC)

mart added a comment. in principle i agree, I would love to be able to use this in qguiapplications, but are we sure qstyles won't access qapplication? doesn't this risk to just move the crash? REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL

D13973: Honor BUILD_TESTING

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D13973 To: arojas, mart, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13982: Honor BUILD_TESTING

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D13982 To: arojas, mart, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13957: Honor BUILD_TESTING

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D13957 To: arojas, cfeck, apol Cc: asturmlechner, kde-frameworks-devel, michaelh, ngraham, bruns

D13944: Honor BUILD_TESTING

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D13944 To: arojas, ltoscano, apol Cc: kde-frameworks-devel, kde-doc-english, michaelh, ngraham, bruns, skadinna

D13933: [Purpose]: use Arc's status colours for the Phab plugin drop-down list (WIP)

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM overall. INLINE COMMENTS > difflistmodel.cpp:87 > if (job->error() != 0) { > -qWarning() << "error getting differential revision list" << > job->errorString(); > +

D13816: Make KItinerary work as a static library

cgiboudeaux added inline comments. INLINE COMMENTS > lepagevalleeemmanuel wrote in CMakeLists.txt:50 > You *might* want to add > > OPTION(BUILD_SHARED_LIBS "Build the shared library (instead of static)" > ON ) > > near the top of the `CMakeLists.txt` for the sake of making sure it's the

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 76 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/76/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 10 Jul 2018 12:21:55 + Build duration: 5 min 32 sec and counting JUnit Tests

D14022: Use non deprecated fastInsert in baloo

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D14022 To: jtamate, #frameworks, #baloo, ngraham Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

D13816: Make KItinerary work as a static library

lepagevalleeemmanuel added inline comments. INLINE COMMENTS > CMakeLists.txt:50 > > -add_library(KPimItinerary SHARED ${kitinerary_lib_srcs}) > +add_library(KPimItinerary ${kitinerary_lib_srcs}) > add_library(KPim::Itinerary ALIAS KPimItinerary) You *might* want to add

D13676: Make it possible to change directory up even with trailing slashes in the url

jtamate updated this revision to Diff 37500. jtamate edited the summary of this revision. jtamate edited the test plan for this revision. jtamate added a comment. The url in the lineedit is get from KUriFilterData, and it didn't normalize the paths, allowing trailing slashes. Include 4 new

D14020: RPM Spec: add MIME type

bcooksley added a comment. Restricted Application added a project: Kate. Restricted Application added a subscriber: kwrite-devel. I have now corrected the Phabricator configuration fault which prevented #framework_syntax_highlighting

D14020: RPM Spec: add MIME type

bcooksley added a comment. @nibags Please don't remove automatically added Projects and Subscribers. I'll need to investigate why Herald didn't automatically restore those as it should have done so. In this case, removing @kde-frameworks-devel prevents the mailing list we all use from

D14020: RPM Spec: add MIME type

bcooksley edited subscribers, added: kde-frameworks-devel; removed: Framework: Syntax Highlighting. REPOSITORY R216 Syntax Highlighting BRANCH add-mime-rpmspec REVISION DETAIL https://phabricator.kde.org/D14020 To: nibags, #framework_syntax_highlighting, vkrause Cc:

D13752: Build solidautoeject only on FreeBSD

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R120:edd5e889f583: Build solidautoeject only on FreeBSD (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES

D13816: Make KItinerary work as a static library

vkrause added a subscriber: arojas. vkrause added a comment. In D13816#289594 , @lepagevalleeemmanuel wrote: > > That bug report is more what I'm looking at here. I disagree with your assessment though that this is undefined behavior or broken

D14022: Use non deprecated fastInsert in baloo

jtamate created this revision. jtamate added reviewers: Frameworks, Baloo. Restricted Application added projects: Frameworks, Baloo. Restricted Application added a subscriber: kde-frameworks-devel. jtamate requested review of this revision. REVISION SUMMARY All the entries are local variables.