KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 76 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/76/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 11 Jul 2018 03:26:12 +
 Build duration:
7 min 35 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report23%
(5/22)27%
(14/52)27%
(14/52)19%
(412/2119)18%
(194/1084)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)97%
(119/123)58%
(56/96)src100%
(8/8)100%
(8/8)68%
(212/312)50%
(104/210)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/136)0%
(0/88)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/17)0%
(0/12)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/55)0%
(0/20)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/186)0%
(0/69)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/12)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/79)0%
(0/34)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/29)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/222)0%
(0/82)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/99)0%
(0/62)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/233)0%
(0/76)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/153)0%
(0/92)src.plugins.saveas100%
(1/1)100%
(1/1)57%
(29/51)64%
(28/44)src.plugins.telegram0%
(0/1)0%
(0/1)0%
(0/48)0%
(0/22)src.plugins.youtube0%
(0/4)0%
(0/4)0%
(0/112)0%

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 77 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/77/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.10
 Date of build:
Wed, 11 Jul 2018 03:25:52 +
 Build duration:
4 min 54 sec and counting
   JUnit Tests
  Name: (root) Failed: 4 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 53 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/53/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 11 Jul 2018 03:26:12 +
 Build duration:
2 min 6 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.alternativesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report23%
(5/22)27%
(14/52)27%
(14/52)20%
(429/2119)19%
(209/1084)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)92%
(113/123)53%
(51/96)src100%
(8/8)100%
(8/8)75%
(235/312)59%
(124/210)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/136)0%
(0/88)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/17)0%
(0/12)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/55)0%
(0/20)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/186)0%
(0/69)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/12)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/79)0%
(0/34)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/29)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/222)0%
(0/82)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/99)0%
(0/62)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/233)0%
(0/76)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/153)0%
(0/92)src.plugins.saveas100%
(1/1)100%
(1/1)57%
(29/51)64%
(28/44)src.plugins.telegram0%
(0/1)0%
(0/1)0%
(0/48)0%
(0/22)src.plugins.youtube0%
(0/4)0%
(0/4)0%
(0/112)0%
  

D14020: RPM Spec: add MIME type

[Nibaldo González]

nibags added a comment.


  Ok!

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  add-mime-rpmspec

REVISION DETAIL
  https://phabricator.kde.org/D14020

To: nibags, #framework_syntax_highlighting, vkrause
Cc: kwrite-devel, bcooksley, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D13814: Speedup sort

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> kfileitemmodel.cpp:58
>  {
>  m_collator.setNumericMode(true);
>  

this causes the dirty state - maybe also do the forced (re)initialization here?

> kfileitemmodel.cpp:112
> +// Workaround for bug https://bugreports.qt.io/browse/QTBUG-69361
> +// Force the cleanup of QCollator in single thread to avoid thread 
> safety problems in sort
> +m_collator.compare(QStringLiteral("comparing"), 
> QStringLiteral("anything"));

Maybe better:

  // Force initialization from the main thread. The collator is captured by 
reference and passed to the threads,
  // and if it is not in a clean state all threads will try to initialize it in 
parallel.

> kfileitemmodel.cpp:113
> +// Force the cleanup of QCollator in single thread to avoid thread 
> safety problems in sort
> +m_collator.compare(QStringLiteral("comparing"), 
> QStringLiteral("anything"));
>  }

`m_collator.compare(QString(), QString());` is sufficient

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D13814

To: jtamate, #dolphin, #frameworks, markg, elvisangelaccio
Cc: elvisangelaccio, apol, bruns, markg, kfm-devel, spoorun, navarromorales, 
firef, andrebarros, emmanuelp

D13814: Speedup sort

[Elvis Angelaccio]

elvisangelaccio accepted this revision.
elvisangelaccio added a comment.
This revision is now accepted and ready to land.


  Thanks for filing the upstream bug. Looks good to me now.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D13814

To: jtamate, #dolphin, #frameworks, markg, elvisangelaccio
Cc: elvisangelaccio, apol, bruns, markg, kfm-devel, spoorun, navarromorales, 
firef, andrebarros, emmanuelp

D14022: Use non deprecated fastInsert in baloo

[Jaime Torres Amate]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:b806c88c6bcc: Use non deprecated fastInsert in baloo 
(authored by jtamate).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14022?vs=37493=37524

REVISION DETAIL
  https://phabricator.kde.org/D14022

AFFECTED FILES
  src/kioslaves/tags/kio_tags.cpp
  src/kioslaves/timeline/kio_timeline.cpp

To: jtamate, #frameworks, #baloo, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 52 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/52/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.9
 Date of build:
Tue, 10 Jul 2018 18:59:06 +
 Build duration:
2 min 6 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.alternativesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report23%
(5/22)27%
(14/52)27%
(14/52)20%
(429/2119)19%
(209/1084)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)92%
(113/123)53%
(51/96)src100%
(8/8)100%
(8/8)75%
(235/312)59%
(124/210)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/136)0%
(0/88)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/17)0%
(0/12)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/55)0%
(0/20)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/186)0%
(0/69)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/12)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/79)0%
(0/34)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/29)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/222)0%
(0/82)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/99)0%
(0/62)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/233)0%
(0/76)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/153)0%
(0/92)src.plugins.saveas100%
(1/1)100%
(1/1)57%
(29/51)64%
(28/44)src.plugins.telegram0%
(0/1)0%
(0/1)0%
(0/48)0%
(0/22)src.plugins.youtube0%
(0/4)0%
(0/4)0%
(0/112)0%
  

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 75 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/75/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 10 Jul 2018 18:59:06 +
 Build duration:
1 min 59 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.alternativesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report23%
(5/22)27%
(14/52)27%
(14/52)19%
(406/2119)17%
(186/1084)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)92%
(113/123)50%
(48/96)src100%
(8/8)100%
(8/8)68%
(212/312)50%
(104/210)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/136)0%
(0/88)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/17)0%
(0/12)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/55)0%
(0/20)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/186)0%
(0/69)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/12)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/79)0%
(0/34)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/29)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/222)0%
(0/82)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/99)0%
(0/62)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/233)0%
(0/76)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/153)0%
(0/92)src.plugins.saveas100%
(1/1)100%
(1/1)57%
(29/51)64%
(28/44)src.plugins.telegram0%
(0/1)0%
(0/1)0%
(0/48)0%
(0/22)src.plugins.youtube0%
(0/4)0%
(0/4)0%
(0/112)0%
   

D13933: [Purpose]: use Arc's status colours for the Phab plugin drop-down list (WIP)

[René J . V . Bertin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R495:6d518089aa1c: Prepare to use Arcs status colours in 
the revision drop-down list (authored by rjvbb).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D13933?vs=37292=37523#toc

REPOSITORY
  R495 Purpose Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13933?vs=37292=37523

REVISION DETAIL
  https://phabricator.kde.org/D13933

AFFECTED FILES
  src/plugins/phabricator/CMakeLists.txt
  src/plugins/phabricator/phabricatorjobs.cpp
  src/plugins/phabricator/phabricatorjobs.h
  src/plugins/phabricator/quick/difflistmodel.cpp
  src/plugins/phabricator/quick/difflistmodel.h

To: rjvbb, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13816: Make KItinerary work as a static library

[Emmanuel Lepage Vallee]

lepagevalleeemmanuel added inline comments.

INLINE COMMENTS

> CMakeLists.txt:50
>  
> -add_library(KPimItinerary SHARED ${kitinerary_lib_srcs})
> +add_library(KPimItinerary ${kitinerary_lib_srcs})
>  add_library(KPim::Itinerary ALIAS KPimItinerary)

Ok, thanks. So it's a "Ship it!" for my point of view (if it matter at all)

REPOSITORY
  R1003 KItinerary: Travel Reservation handling library

REVISION DETAIL
  https://phabricator.kde.org/D13816

To: vkrause, #frameworks
Cc: cgiboudeaux, arojas, mart, lepagevalleeemmanuel, apol, kde-pim, dvasin, 
rodsevich, winterz, vkrause, mlaurent, knauss, dvratil

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 184 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/184/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 10 Jul 2018 16:57:20 +
 Build duration:
6 min 4 sec and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)31%
(39/126)31%
(39/126)27%
(3489/13084)19%
(1785/9412)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests79%
(11/14)79%
(11/14)53%
(588/1113)29%
(310/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core19%
(3/16)19%
(3/16)11%
(252/2208)7%
(94/1432)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma55%
(12/22)55%
(12/22)41%
(1410/3477)30%
(779/2613)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/135)0%
(0/12)src.plasma.private47%
(9/19)47%
(9/19)43%
(661/1540)30%
(300/1001)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)28%
(547/1973)17%
(297/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1096)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
 

D13973: Honor BUILD_TESTING

[Antonio Rojas]

This revision was automatically updated to reflect the committed changes.
Closed by commit R296:fdd04af53dae: Honor BUILD_TESTING (authored by arojas).

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13973?vs=37347=37515

REVISION DETAIL
  https://phabricator.kde.org/D13973

AFFECTED FILES
  CMakeLists.txt

To: arojas, mart, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 - Build # 34 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.10/34/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 10 Jul 2018 16:57:20 +
 Build duration:
2 min 43 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

D13982: Honor BUILD_TESTING

[Antonio Rojas]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:061588dcd6cc: Honor BUILD_TESTING (authored by arojas).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13982?vs=37359=37514

REVISION DETAIL
  https://phabricator.kde.org/D13982

AFFECTED FILES
  CMakeLists.txt

To: arojas, mart, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13957: Honor BUILD_TESTING

[Antonio Rojas]

This revision was automatically updated to reflect the committed changes.
Closed by commit R302:f059164f8aba: Honor BUILD_TESTING (authored by arojas).

REPOSITORY
  R302 KIconThemes

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13957?vs=37324=37513

REVISION DETAIL
  https://phabricator.kde.org/D13957

AFFECTED FILES
  CMakeLists.txt

To: arojas, cfeck, apol
Cc: asturmlechner, kde-frameworks-devel, michaelh, ngraham, bruns

D13944: Honor BUILD_TESTING

[Antonio Rojas]

This revision was automatically updated to reflect the committed changes.
Closed by commit R238:6303431a9405: Honor BUILD_TESTING (authored by arojas).

REPOSITORY
  R238 KDocTools

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13944?vs=37310=37512

REVISION DETAIL
  https://phabricator.kde.org/D13944

AFFECTED FILES
  CMakeLists.txt

To: arojas, ltoscano, apol
Cc: kde-frameworks-devel, kde-doc-english, michaelh, ngraham, bruns, skadinna

D14000: qqc2-desktop-style: basic support for QGuiApplication-based apps (WIP/PoC)

[Marco Martin]

mart added a comment.


  in principle i agree, I would love to be able to use this in 
qguiapplications, but are we sure qstyles won't access qapplication? doesn't 
this risk to just move the crash?

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D14000

To: rjvbb, #frameworks
Cc: mart, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D13973: Honor BUILD_TESTING

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D13973

To: arojas, mart, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13982: Honor BUILD_TESTING

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D13982

To: arojas, mart, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13957: Honor BUILD_TESTING

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D13957

To: arojas, cfeck, apol
Cc: asturmlechner, kde-frameworks-devel, michaelh, ngraham, bruns

D13944: Honor BUILD_TESTING

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D13944

To: arojas, ltoscano, apol
Cc: kde-frameworks-devel, kde-doc-english, michaelh, ngraham, bruns, skadinna

D13933: [Purpose]: use Arc's status colours for the Phab plugin drop-down list (WIP)

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  LGTM overall.

INLINE COMMENTS

> difflistmodel.cpp:87
>  if (job->error() != 0) {
> -qWarning() << "error getting differential revision list" << 
> job->errorString();
> +qDebug() << "error getting differential revision list" << 
> job->errorString();
>  beginResetModel();

Why that change?

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D13933

To: rjvbb, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13816: Make KItinerary work as a static library

[Christophe Giboudeaux]

cgiboudeaux added inline comments.

INLINE COMMENTS

> lepagevalleeemmanuel wrote in CMakeLists.txt:50
> You *might* want to add
> 
>   OPTION(BUILD_SHARED_LIBS   "Build the shared library (instead of static)" 
> ON )
> 
> near the top of the `CMakeLists.txt` for the sake of making sure it's the 
> default and for readability?

No need, extra-cmake-modules already sets it to TRUE if KDECMakeSettings is 
included.

REPOSITORY
  R1003 KItinerary: Travel Reservation handling library

REVISION DETAIL
  https://phabricator.kde.org/D13816

To: vkrause, #frameworks
Cc: cgiboudeaux, arojas, mart, lepagevalleeemmanuel, apol, kde-pim, dvasin, 
rodsevich, winterz, vkrause, mlaurent, knauss, dvratil

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 76 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/76/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 10 Jul 2018 12:21:55 +
 Build duration:
5 min 32 sec and counting
   JUnit Tests
  Name: (root) Failed: 4 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

D14022: Use non deprecated fastInsert in baloo

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D14022

To: jtamate, #frameworks, #baloo, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D13816: Make KItinerary work as a static library

[Emmanuel Lepage Vallee]

lepagevalleeemmanuel added inline comments.

INLINE COMMENTS

> CMakeLists.txt:50
>  
> -add_library(KPimItinerary SHARED ${kitinerary_lib_srcs})
> +add_library(KPimItinerary ${kitinerary_lib_srcs})
>  add_library(KPim::Itinerary ALIAS KPimItinerary)

You *might* want to add

  OPTION(BUILD_SHARED_LIBS   "Build the shared library (instead of static)" ON )

near the top of the `CMakeLists.txt` for the sake of making sure it's the 
default and for readability?

> init.cpp:24
> +
> +#include 
> +#include 

unused?

REPOSITORY
  R1003 KItinerary: Travel Reservation handling library

REVISION DETAIL
  https://phabricator.kde.org/D13816

To: vkrause, #frameworks
Cc: arojas, mart, lepagevalleeemmanuel, apol, kde-pim, dvasin, rodsevich, 
winterz, vkrause, mlaurent, knauss, dvratil

D13676: Make it possible to change directory up even with trailing slashes in the url

[Jaime Torres Amate]

jtamate updated this revision to Diff 37500.
jtamate edited the summary of this revision.
jtamate edited the test plan for this revision.
jtamate added a comment.


  The url in the lineedit is get from KUriFilterData, and it didn't normalize 
the paths, allowing trailing slashes.
  Include 4 new tests and fix 2 (the ones with // in the middle of the urls).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13676?vs=36513=37500

REVISION DETAIL
  https://phabricator.kde.org/D13676

AFFECTED FILES
  autotests/kdiroperatortest.cpp
  autotests/kurifiltertest.cpp
  src/filewidgets/kdiroperator.cpp
  src/widgets/kurifilter.cpp

To: jtamate, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14020: RPM Spec: add MIME type

[Ben Cooksley]

bcooksley added a comment.
Restricted Application added a project: Kate.
Restricted Application added a subscriber: kwrite-devel.


  I have now corrected the Phabricator configuration fault which prevented 
#framework_syntax_highlighting 
 from being 
automatically added as Project and the appropriate mailing lists subscribed.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  add-mime-rpmspec

REVISION DETAIL
  https://phabricator.kde.org/D14020

To: nibags, #framework_syntax_highlighting, vkrause
Cc: kwrite-devel, bcooksley, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D14020: RPM Spec: add MIME type

[Ben Cooksley]

bcooksley added a comment.


  @nibags Please don't remove automatically added Projects and Subscribers. 
I'll need to investigate why Herald didn't automatically restore those as it 
should have done so.
  In this case, removing @kde-frameworks-devel prevents the mailing list we all 
use from being informed of this change.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  add-mime-rpmspec

REVISION DETAIL
  https://phabricator.kde.org/D14020

To: nibags, #framework_syntax_highlighting, vkrause
Cc: bcooksley, kde-frameworks-devel, michaelh, ngraham, bruns

D14020: RPM Spec: add MIME type

[Ben Cooksley]

bcooksley edited subscribers, added: kde-frameworks-devel; removed: Framework: 
Syntax Highlighting.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  add-mime-rpmspec

REVISION DETAIL
  https://phabricator.kde.org/D14020

To: nibags, #framework_syntax_highlighting, vkrause
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13752: Build solidautoeject only on FreeBSD

[Kai Uwe Broulik]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:edd5e889f583: Build solidautoeject only on FreeBSD 
(authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13752?vs=37098=37498

REVISION DETAIL
  https://phabricator.kde.org/D13752

AFFECTED FILES
  CMakeLists.txt

To: broulik, #plasma, #frameworks, adridg, davidedmundson, dfaure, fvogt, ervin
Cc: anthonyfieroni, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D13816: Make KItinerary work as a static library

[Volker Krause]

vkrause added a subscriber: arojas.
vkrause added a comment.


  In D13816#289594 , 
@lepagevalleeemmanuel wrote:
  
  > > That bug report is more what I'm looking at here. I disagree with your 
assessment though that this is undefined behavior or broken in the current 
dynamic code. Static construction is actually a pattern used all over the 
place, among them are qrc, the qml compiler and the ECM qm catalog loader, as 
well as custom code as you found in KConfig, or as this patch tries to support 
in KItinerary. So I think we need a proper solution for this.
  >
  > Static construction is fine. The issue here is a lot more subtle. Let's 
take a similar case. Back when the distributions started to use the 
`--as-needed` LDFLAGS, there was a lot of this issue too. If a library is not 
used, then you can't "trust" that the static code will get executed because the 
linker has the "right" to drop whole .so. When using LTO, you get this issue on 
the compilation unit level. So a `.o` can be dropped entirely if nothing points 
to that CU, even if static init from that CU point to other CU. This is why 
static code needs to be handled with care on them. It isn't forbidden, it just 
can't be "trusted" to be executed. In the case of the kconfig bug, it clearly 
isn't executed with very bad consequences. It is not a gold linker bug, it's 
just how LTO dead code elimination works.
  
  
  Yep, and that's what this patch proposes a solution for. Not a pretty one, 
but it at least addresses this reliably and platform-independent.
  
  >> Most of those patches seem to be dealing with the Qt5::Test dependency or 
other dependency-related changes, ie. this should be pretty harmless to 
integrate?
  > 
  > Yes and no. The majority is easy, but there is a very hard minority of 
changes that will be enormously controversial.
  > 
  > The easy basic:
  > 
  > - Allow to disable Qt::Test because LTO-ing test takes too much resources 
to be ran in every CI build
  
  @arojas is currently integrating a large set of patches for this I think.
  
  > - Stop using "SHARED" in add_library and always use the "BUILD_SHARED_LIBS 
ON" option
  > - Fix all cmake "targets" to have the correct dependencies exported to 
avoid adding manual `-lkf5foo` due to misexported deps
  > - For the framework that are Qt plugins, add the necessary MOC arguments
  > 
  >   The much harder parts:
  > - There is some new classes of bugs like dead code elimination having side 
effects
  > - Some things like Kio "hard" dependencies have to go or undergo large 
redesign because they often are used in a single line of code (file picker 
widget) and pull 10 frameworks that make no sense for static binaries.
  > - Everything using client-daemon or multi-process model become very 
impractical on Android and other bundles
  > - Everything that uses dlopen is potentially broken
  > - All KDE deamons like kdeinit5/kded5/knotify need to be reconsidered 
because they make no sense in sandboxes and have bad side effects like 
increased binary size instead of a reduction due to each binary having its own 
Qt
  > - Things like the icon theme and resource should to have some ways of 
getting bundled to have "portable" binaries
  > - Some external customization like icon theme, color scheme and theme break
  
  Valid points but mostly affecting tier 3(+) frameworks I think, most tier 1/2 
frameworks are at most affected by static construction. So I think we can look 
at this independently, as for some use-cases you don't need the full set of 
frameworks (e.g. newly written applications targeting Android from the start).
  
  > Ideally / eventually / hopefully:
  > 
  > - The kconfig kcfg compiler need either to be rewritten without Qt or 
exposed as web service because it is "incompatible"/"impractical" with 
cross-compilation
  > - The breeze icon pack generator and translation compiler also need some 
work to be easier to integrate
  > - We need a CI to validate the result and detect regression otherwise it 
will break again after 1 week
  > 
  >   For the last 2, I mix static builds with "container driven cross 
compilation" issues. It's not fully relevant to static libs, but rather the use 
case for them,
  > 
  >   So in the end, it's not simple and will make some people very unhappy. 
The patches I maintain is the strict minimum for ring-kde to link and work. It 
isn't a clean job and it isn't the complete picture. I felt like this isn't 
something I can just start submitting patches and eventually finish. It needs 
buy-in from a lot of people and I am not sure it can happen without face to 
face discussion at Akademy or something.
  
  That's why I'm not trying to look at this as one monolithic change, but one 
piece at a time :) I don't think we need to wait until Akademy to discuss e.g. 
this proposed solution for the static construction problem.

REPOSITORY
  R1003 KItinerary: Travel Reservation handling library

D14022: Use non deprecated fastInsert in baloo

[Jaime Torres Amate]

jtamate created this revision.
jtamate added reviewers: Frameworks, Baloo.
Restricted Application added projects: Frameworks, Baloo.
Restricted Application added a subscriber: kde-frameworks-devel.
jtamate requested review of this revision.

REVISION SUMMARY
  All the entries are local variables.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D14022

AFFECTED FILES
  src/kioslaves/tags/kio_tags.cpp
  src/kioslaves/timeline/kio_timeline.cpp

To: jtamate, #frameworks, #baloo
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams