D14107: [Telegram] Don't wait for Telegram to be closed

2018-07-13 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added a reviewer: apol. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Unlike e.g. kdeconnect-cli telegram

D11176: Don't call PythonInterp.cmake in KF5I18NMacros.

2018-07-13 Thread Ben Cooksley
bcooksley added a comment. Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. This change has broken the build of all projects that make use of pmap resources on Windows, as the Python path at build time is not necessarily the path at install time

D14062: Python: fix escapes in quoted-comments

2018-07-13 Thread Nibaldo González
nibags updated this revision to Diff 37722. nibags added a comment. - Add test. I also included a missing MIME type, obtained from `shared-mime-info`. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14062?vs=37615=37722 BRANCH fix-python

D13814: Speedup sort

2018-07-13 Thread Stefan Brüns
bruns added a comment. Any reason why you have pushed this with an obviously wrong commit message? REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D13814 To: jtamate, #dolphin, #frameworks, markg, elvisangelaccio, bruns Cc: elvisangelaccio, apol, bruns, markg,

D13570: Add workaround for labels with word-wrapping

2018-07-13 Thread Anthony Fieroni
anthonyfieroni added inline comments. INLINE COMMENTS > kcollapsiblegroupbox.cpp:307-308 > +if (label->wordWrap()) { > +toggle(); > +toggle(); > +} Did you know why it should be called twice? Does one later toggle invoke will fix it? REPOSITORY R236

D13814: Speedup sort

2018-07-13 Thread Jaime Torres Amate
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R318:765cc968c9df: Speedup sort (authored by jtamate). CHANGED PRIOR TO COMMIT

D14097: Change default sort order in the download dialog to Rating

2018-07-13 Thread Aleix Pol Gonzalez
apol added a comment. +1 this makes most sense to me. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D14097 To: ngraham, apol, leinir, #knewstuff Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14052: Add bluetooth plugin

2018-07-13 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Looks great and works great! REPOSITORY R495 Purpose Library BRANCH bluetooth REVISION DETAIL https://phabricator.kde.org/D14052 To: nicolasfella, apol, ngraham Cc:

D14097: Change default sort order in the download dialog to Rating

2018-07-13 Thread Nathaniel Graham
ngraham edited the test plan for this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D14097 To: ngraham, apol, leinir, #knewstuff Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14097: Change default sort order in the download dialog to Rating

2018-07-13 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: apol, leinir, KNewStuff. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY This changed the default sort

D14095: Fix DownloadDialog window margins to meet general theme margins

2018-07-13 Thread Friedrich W. H. Kossebau
kossebau created this revision. kossebau added a reviewer: leinir. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Old code prevented the widget theme to use