D13869: [solid] Notify when interface to mounted fs is lost

2018-07-22 Thread Anthony Fieroni
anthonyfieroni added a comment. Moundting by cdemu also works as expected, not without patch as is described in bug report. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D13869 To: anthonyfieroni, broulik, cfeck, dfaure Cc: bcooksley, bruns, kde-frameworks-devel, mic

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 177 - Still Unstable!

2018-07-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/177/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Mon, 23 Jul 2018 03:21:47 + Build duration: 27 min and counting JUnit Tests Name: (root) Faile

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 330 - Still Unstable!

2018-07-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/330/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Mon, 23 Jul 2018 03:21:47 + Build duration: 9 min 13 sec and counting JUnit Tests Name: (roo

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 63 - Fixed!

2018-07-22 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/63/ Project: Frameworks purpose kf5-qt5 SUSEQt5.9 Date of build: Mon, 23 Jul 2018 03:22:12 + Build duration: 8 min 14 sec and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 87 - Still Unstable!

2018-07-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/87/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Mon, 23 Jul 2018 03:21:47 + Build duration: 6 min 37 sec and counting JUnit Tests Name:

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 86 - Still Unstable!

2018-07-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/86/ Project: Frameworks purpose kf5-qt5 SUSEQt5.10 Date of build: Mon, 23 Jul 2018 03:22:12 + Build duration: 1 min 54 sec and counting JUnit Tests Nam

D14283: C++: fix standard floating-point literals

2018-07-22 Thread jonathan poelen
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: kwrite-devel. jpoelen requested review of this revision. REVISION SUMMARY BUG: 389693 REPOSITORY

D14282: CSS: fix test reference of the previous commit

2018-07-22 Thread jonathan poelen
jpoelen created this revision. jpoelen added a reviewer: dhaumann. Restricted Application added projects: Kate, Frameworks. jpoelen requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH fix_cxx REVISION DETAIL https://phabricator.kde.org/D14282 AFFECTED FILES aut

D14275: Add Autodesk EAGLE sch and brd file format to the XML category

2018-07-22 Thread Dominik Haumann
dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Looks good to me, but we also have to increase the 'version' number from 7 to 8. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14275 To: martonm

D14043: [KFilePlacesModel] Support pretty baloosearch URLs

2018-07-22 Thread Dominik Haumann
dhaumann added inline comments. INLINE COMMENTS > kfileplacesmodel.cpp:137 > > -if (path.endsWith(QLatin1String("/documents"))) { > -searchUrl = searchUrlForType(QStringLiteral("Document")); > -} else if (path.endsWith(QLatin1String("/images"))) { > -sear

D14270: CoffeeScript: fix templates in embedded JavaScript code & add escapes

2018-07-22 Thread Dominik Haumann
dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Besides version number, lgtm. REPOSITORY R216 Syntax Highlighting BRANCH jsemb-coffeescript REVISION DETAIL https://phabricator.kde.org/D14270 To: nibags, dhaumann, cullmann, #f

D14270: CoffeeScript: fix templates in embedded JavaScript code & add escapes

2018-07-22 Thread Dominik Haumann
dhaumann added a comment. Makes sense. Can you also increase the version number in the language element? BTW, do you have commit access? Given your frequent updates, it makes sense if you can push yourself. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.

KDE CI: Frameworks kxmlgui kf5-qt5 SUSEQt5.9 - Build # 20 - Fixed!

2018-07-22 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kxmlgui%20kf5-qt5%20SUSEQt5.9/20/ Project: Frameworks kxmlgui kf5-qt5 SUSEQt5.9 Date of build: Sun, 22 Jul 2018 22:11:14 + Build duration: 1 min 42 sec and counting JUnit Tests Name:

KDE CI: Frameworks kxmlgui kf5-qt5 SUSEQt5.10 - Build # 36 - Fixed!

2018-07-22 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kxmlgui%20kf5-qt5%20SUSEQt5.10/36/ Project: Frameworks kxmlgui kf5-qt5 SUSEQt5.10 Date of build: Sun, 22 Jul 2018 22:11:04 + Build duration: 1 min 47 sec and counting JUnit Tests Name

D13869: [solid] Notify when interface to mounted fs is lost

2018-07-22 Thread Anthony Fieroni
anthonyfieroni added a comment. Performing working tests - mount -o loop xxx.iso /mnt/xxx - mount xxx/iso /mnt/xxx - Add Android phone - Add second phone, first become inactive, second works REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kd

D14275: Add Autodesk EAGLE sch and brd file format to the XML category

2018-07-22 Thread Miklos Marton
martonmiklos created this revision. martonmiklos added a reviewer: Framework: Syntax Highlighting. martonmiklos added a project: Framework: Syntax Highlighting. Restricted Application added projects: Kate, Frameworks. Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. mar

D14274: Modelines: add byte-order-mark & small fixes

2018-07-22 Thread Nibaldo González
nibags edited the summary of this revision. nibags added reviewers: turbov, dhaumann, cullmann, vkrause, Kate. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14274 To: nibags, turbov, dhaumann, cullmann, vkrause, #kate Cc: kwrite-devel, kde-frameworks-devel,

D14274: Modelines: add byte-order-mark & small fixes

2018-07-22 Thread Nibaldo González
nibags created this revision. Restricted Application added projects: Kate, Frameworks. Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY Changes: - Add missing keyword: `byte-order-mark` (there is only "b

D14270: CoffeeScript: fix templates in embedded JavaScript code & add escapes

2018-07-22 Thread Nibaldo González
nibags edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14270 To: nibags, dhaumann, cullmann, #framework_syntax_highlighting, #kate Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, c

D14270: CoffeeScript: fix templates in embedded JavaScript code & add escapes

2018-07-22 Thread Nibaldo González
nibags edited the summary of this revision. nibags added reviewers: dhaumann, cullmann, Framework: Syntax Highlighting, Kate. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14270 To: nibags, dhaumann, cullmann, #framework_syntax_highlighting, #kate Cc: kwri

D14270: CoffeeScript: fix templates in embedded JavaScript code & add escapes

2018-07-22 Thread Nibaldo González
nibags created this revision. Restricted Application added projects: Kate, Frameworks. Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY In CoffeeScript, the character ` (grave accent) is used to insert JavaSc