D14302: Don't block forever in ensureKdeinitRunning

2018-07-23 Thread Thiago Macieira
thiago added a comment. Quick testing via gdb: Breakpoint 1, QLockFile::tryLock (this=0x7fffc6d8, timeout=0) at /home/tjmaciei/src/qt/qt5/qtbase/src/corelib/io/qlockfile.cpp:241 241 Q_D(QLockFile); (gdb) n 242 QDeadlineTimer timer(qMax(timeout, -1));

D14302: Don't block forever in ensureKdeinitRunning

2018-07-23 Thread Thiago Macieira
thiago added a comment. In D14302#296479 , @dfaure wrote: > I agree about tryLock(0) should return immediately, tryLock(-1) should block forever -- I wrote that code and that docu ;-) > > Thiago wrote QDeadLineTimer later on though, and

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 66 - Fixed!

2018-07-23 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/66/ Project: Frameworks purpose kf5-qt5 SUSEQt5.9 Date of build: Mon, 23 Jul 2018 23:49:54 + Build duration: 7 min 58 sec and counting JUnit Tests Name:

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 89 - Fixed!

2018-07-23 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/89/ Project: Frameworks purpose kf5-qt5 SUSEQt5.10 Date of build: Mon, 23 Jul 2018 23:49:54 + Build duration: 7 min 1 sec and counting JUnit Tests

D14218: Introduce a test to make sure we're not offering duplicated icons

2018-07-23 Thread Aleix Pol Gonzalez
apol added a comment. @andreask, thanks for looking into it. Now it's accepted but we'll get a bunch of errors, how do you suggest we resolve it? I'd rather have a plan before landing this. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D14218

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 88 - Still Unstable!

2018-07-23 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/88/ Project: Frameworks purpose kf5-qt5 SUSEQt5.10 Date of build: Mon, 23 Jul 2018 23:31:34 + Build duration: 1 min 47 sec and counting JUnit Tests

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 65 - Still Unstable!

2018-07-23 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/65/ Project: Frameworks purpose kf5-qt5 SUSEQt5.9 Date of build: Mon, 23 Jul 2018 23:31:34 + Build duration: 1 min 49 sec and counting JUnit Tests

KDE CI: Frameworks purpose kf5-qt5 FreeBSDQt5.10 - Build # 53 - Fixed!

2018-07-23 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20FreeBSDQt5.10/53/ Project: Frameworks purpose kf5-qt5 FreeBSDQt5.10 Date of build: Mon, 23 Jul 2018 23:31:34 + Build duration: 1 min 48 sec and counting JUnit Tests

KDE CI: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9 - Build # 59 - Fixed!

2018-07-23 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.9/59/ Project: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9 Date of build: Mon, 23 Jul 2018 21:23:40 + Build duration: 2 min 11 sec and counting

KDE CI: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.10 - Build # 115 - Fixed!

2018-07-23 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.10/115/ Project: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.10 Date of build: Mon, 23 Jul 2018 21:23:40 + Build duration: 2 min 9 sec and counting

KDE CI: Frameworks syntax-highlighting kf5-qt5 FreeBSDQt5.10 - Build # 43 - Fixed!

2018-07-23 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20FreeBSDQt5.10/43/ Project: Frameworks syntax-highlighting kf5-qt5 FreeBSDQt5.10 Date of build: Mon, 23 Jul 2018 21:23:37 + Build duration: 2 min 0 sec and counting

KDE CI: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9 - Build # 58 - Still Unstable!

2018-07-23 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.9/58/ Project: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9 Date of build: Mon, 23 Jul 2018 21:21:28 + Build duration: 2 min 11 sec and counting

KDE CI: Frameworks syntax-highlighting kf5-qt5 FreeBSDQt5.10 - Build # 42 - Still Unstable!

2018-07-23 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20FreeBSDQt5.10/42/ Project: Frameworks syntax-highlighting kf5-qt5 FreeBSDQt5.10 Date of build: Mon, 23 Jul 2018 21:21:28 + Build duration: 2 min 7 sec and

KDE CI: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.10 - Build # 114 - Still Unstable!

2018-07-23 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.10/114/ Project: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.10 Date of build: Mon, 23 Jul 2018 21:21:28 + Build duration: 2 min 11 sec and counting

D14282: CSS: fix test reference of the previous commit

2018-07-23 Thread jonathan poelen
This revision was automatically updated to reflect the committed changes. Closed by commit R216:a82af177bc2f: CSS: fix test reference of the previous commit (authored by jpoelen). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14282?vs=38217=38277

D14283: C++: fix standard floating-point literals

2018-07-23 Thread jonathan poelen
This revision was automatically updated to reflect the committed changes. Closed by commit R216:7a2ae6be229b: C++: fix standard floating-point literals (authored by jpoelen). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14283?vs=38218=38276

D14308: [Exe Thumbnailer] Improve icon selection algorithm

2018-07-23 Thread Nathaniel Graham
ngraham added a comment. What a dramatic set of before-and-after images! It's like we jumped from 1991 to 2018. > Algo is basically copied from Plasma's wallpaper selection Sounds like we should put this in a Framework and re-use it instead of copy-pasting it here. INLINE COMMENTS

D14201: Set system default shortcut Ctrl+0 for "Actual Size" action

2018-07-23 Thread Nathaniel Graham
ngraham added a comment. Hah! Well in that case, that won't be a blocker. REPOSITORY R237 KConfig BRANCH shortcut-actual-size (branched from master) REVISION DETAIL https://phabricator.kde.org/D14201 To: muhlenpfordt, dfaure, broulik, ngraham Cc: rkflx, kde-frameworks-devel,

D14201: Set system default shortcut Ctrl+0 for "Actual Size" action

2018-07-23 Thread Henrik Fehlauer
rkflx added a comment. Thanks for your support ;) In D14201#296520 , @ngraham wrote: > Let's hold off on landing this patch (if accepted by everyone) until Cirkuit has had a release with D14202 so we

D14201: Set system default shortcut Ctrl+0 for "Actual Size" action

2018-07-23 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Yes, I like it the idea. The chosen shortcut makes sense, and I'm always in favor of standardizing these across apps. Let's hold off on landing this patch (if accepted by everyone) until

D14302: Don't block forever in ensureKdeinitRunning

2018-07-23 Thread Jaime Torres Amate
jtamate added a comment. In D14302#296469 , @jtamate wrote: > I guess this is a Qt bug. > > qint64 QDeadlineTimer::remainingTime() const Q_DECL_NOTHROW > { > qint64 ns = remainingTimeNSecs(); > return ns <= 0 ? ns : (ns

D14201: Set system default shortcut Ctrl+0 for "Actual Size" action

2018-07-23 Thread Henrik Fehlauer
rkflx added a comment. @ngraham Would this patch be something you could back? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D14201 To: muhlenpfordt, dfaure, broulik, ngraham Cc: rkflx, kde-frameworks-devel, michaelh, ngraham, bruns

D14275: Add Autodesk EAGLE sch and brd file format to the XML category

2018-07-23 Thread Miklos Marton
martonmiklos updated this revision to Diff 38273. martonmiklos added a comment. Updated revision to 8 from 7 as suggested in the review. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14275?vs=38204=38273 REVISION DETAIL

D14308: [Exe Thumbnailer] Improve icon selection algorithm

2018-07-23 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Frameworks, dfaure, ngraham, pali, vonreth, antlarr. broulik requested review of this revision. REVISION SUMMARY Prefer downsampling over upscaling TEST PLAN Dolphin requested 128px thumbnail here. Wine executables have 32, 48, and 256

D14302: Don't block forever in ensureKdeinitRunning

2018-07-23 Thread David Faure
dfaure added a comment. I agree about tryLock(0) should return immediately, tryLock(-1) should block forever -- I wrote that code and that docu ;-) Thiago wrote QDeadLineTimer later on though, and ported QLockFile to it. Thiago, any input? REPOSITORY R271 KDBusAddons REVISION DETAIL

D14302: Don't block forever in ensureKdeinitRunning

2018-07-23 Thread David Faure
dfaure added a reviewer: thiago. REPOSITORY R271 KDBusAddons REVISION DETAIL https://phabricator.kde.org/D14302 To: jtamate, dfaure, #frameworks, thiago Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14302: Don't block forever in ensureKdeinitRunning

2018-07-23 Thread Jaime Torres Amate
jtamate added a comment. I guess this is a Qt bug. qint64 QDeadlineTimer::remainingTime() const Q_DECL_NOTHROW { qint64 ns = remainingTimeNSecs(); return ns <= 0 ? ns : (ns + 99) / (1000 * 1000); } Shouldn't it be: return ns <= 0 ? **0** : (ns +

KDE CI: Frameworks purpose kf5-qt5 FreeBSDQt5.10 - Build # 52 - Unstable!

2018-07-23 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20FreeBSDQt5.10/52/ Project: Frameworks purpose kf5-qt5 FreeBSDQt5.10 Date of build: Mon, 23 Jul 2018 18:09:22 + Build duration: 1 min 45 sec and counting JUnit Tests

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 64 - Unstable!

2018-07-23 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/64/ Project: Frameworks purpose kf5-qt5 SUSEQt5.9 Date of build: Mon, 23 Jul 2018 18:09:23 + Build duration: 1 min 43 sec and counting JUnit Tests

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 87 - Still Unstable!

2018-07-23 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/87/ Project: Frameworks purpose kf5-qt5 SUSEQt5.10 Date of build: Mon, 23 Jul 2018 18:09:23 + Build duration: 1 min 46 sec and counting JUnit Tests

D14218: Introduce a test to make sure we're not offering duplicated icons

2018-07-23 Thread Andreas Kainz
andreaska accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D14218 To: apol, andreaska, mart, vkrause, #breeze, #frameworks Cc: ngraham, andreask, kde-frameworks-devel, michaelh,

D14302: Don't block forever in ensureKdeinitRunning

2018-07-23 Thread Jaime Torres Amate
jtamate added a comment. I kept dolphin blocked, just in case. The backtrace: #0 0x7f54c47c4c90 in __GI___nanosleep (requested_time=requested_time@entry=0x7ffdda996710, remaining=remaining@entry=0x7ffdda996710) at ../sysdeps/unix/sysv/linux/nanosleep.c:28 #1

D14302: Don't block forever in ensureKdeinitRunning

2018-07-23 Thread David Faure
dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Strange, I never had that bug. Note that you can use gdb to get a backtrace for a deadlock, no need for hotspot for that particular task. In fact, hotspot even misled you.

D14291: Cleanup RemoteAccess buffers on aboutToBeUnbound instead of object destruction

2018-07-23 Thread Roman Gilg
romangg accepted this revision. romangg added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > remote_access_interface.cpp:244 > > -QObject::connect(rbuf, ::destroyed, [p, rbuf, resource, ] { > +QObject::connect(rbuf, ::aboutToBeUnbound, p->q, [p,

D14302: Don't block forever in ensureKdeinitRunning

2018-07-23 Thread Jaime Torres Amate
jtamate retitled this revision from "Don't block forever to ensureKdeinitRunning" to "Don't block forever in ensureKdeinitRunning". jtamate edited the summary of this revision. REPOSITORY R271 KDBusAddons REVISION DETAIL https://phabricator.kde.org/D14302 To: jtamate, dfaure, #frameworks

D14302: Don't block forever to ensureKdeinitRunning

2018-07-23 Thread Jaime Torres Amate
jtamate created this revision. jtamate added reviewers: dfaure, Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. jtamate requested review of this revision. REVISION SUMMARY My wife has been suffering this block for

D14218: Introduce a test to make sure we're not offering duplicated icons

2018-07-23 Thread Nathaniel Graham
ngraham added a comment. +1 conceptually. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D14218 To: apol, andreaska, mart, vkrause, #breeze, #frameworks Cc: ngraham, andreask, kde-frameworks-devel, michaelh, bruns

D14218: Introduce a test to make sure we're not offering duplicated icons

2018-07-23 Thread Nathaniel Graham
ngraham edited reviewers, added: Breeze, Frameworks; removed: Framework: Syntax Highlighting. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D14218 To: apol, andreaska, mart, vkrause, #breeze, #frameworks, #framework_syntax_highlighting Cc: andreask,

D13782: RFC: Ignore NTFS hidden flag for root volume

2018-07-23 Thread Nathaniel Graham
ngraham resigned from this revision. ngraham added a comment. @wbauer, does this work for you now? Or @bruns? Still cannot test as I have no NTFS partitions. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13782 To: broulik, dfaure, yurikoles, bruns Cc: oysteins,

D14218: Introduce a test to make sure we're not offering duplicated icons

2018-07-23 Thread Marco Martin
mart added a comment. +100 from me as well REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D14218 To: apol, andreaska, mart, vkrause, #framework_syntax_highlighting Cc: andreask, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 188 - Still Unstable!

2018-07-23 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/188/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Mon, 23 Jul 2018 14:25:37 + Build duration: 8 min 18 sec and counting

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 - Build # 38 - Still Unstable!

2018-07-23 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.10/38/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 Date of build: Mon, 23 Jul 2018 14:25:37 + Build duration: 3 min 34 sec and counting

D12311: Align lock icon with bold message text; reduce overall size of dialog

2018-07-23 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. Go for it then! REPOSITORY R121 Policykit (Polkit) KDE Agent BRANCH align-lock-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D12311 To: sharvey, davidedmundson, ngraham, abetts, #frameworks Cc:

D12311: Align lock icon with bold message text; reduce overall size of dialog

2018-07-23 Thread Scott Harvey
sharvey added a comment. I believe it's done. REPOSITORY R121 Policykit (Polkit) KDE Agent BRANCH align-lock-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D12311 To: sharvey, davidedmundson, ngraham, abetts, #frameworks Cc: stikonas, bruns, ltoscano,

D14009: [Plasma PluginLoader] Cache plugins during startup

2018-07-23 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R242:af01c2e95370: [Plasma PluginLoader] Cache plugins during startup (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D6512: Add support for proposed tags addition in OCS 1.7

2018-07-23 Thread Arjen Hiemstra
ahiemstra added a comment. T6133 suggests that tags are formatted as "group##key=value" or something similar. Wouldn't it make sense to handle parsing that format here as well? Or are tags more intended as exact matches? REPOSITORY R235 Attica REVISION

D12311: Align lock icon with bold message text; reduce overall size of dialog

2018-07-23 Thread Nathaniel Graham
ngraham added a comment. Can we commit this? REPOSITORY R121 Policykit (Polkit) KDE Agent BRANCH align-lock-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D12311 To: sharvey, davidedmundson, ngraham, abetts, #frameworks Cc: stikonas, bruns, ltoscano, broulik,

D13869: [solid] Notify when interface to mounted fs is lost

2018-07-23 Thread Anthony Fieroni
anthonyfieroni added a comment. Device(udi).interfaces() ("org.freedesktop.UDisks2.Loop", "org.freedesktop.UDisks2.Block") interfaces ("org.freedesktop.UDisks2.Filesystem") REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D13869 To: anthonyfieroni, broulik, cfeck,

D13869: [solid] Notify when interface to mounted fs is lost

2018-07-23 Thread Anthony Fieroni
anthonyfieroni added inline comments. INLINE COMMENTS > bruns wrote in udisksmanager.cpp:220 > This does not answer my question. What I need from you is: > > - which interfaces are in `interfaces` > - which interfaces are in `device.interfaces()` > > so the **exact** case where the patched

D13869: [solid] Notify when interface to mounted fs is lost

2018-07-23 Thread Stefan Brüns
bruns added inline comments. INLINE COMMENTS > anthonyfieroni wrote in udisksmanager.cpp:220 > Old code is complete broken, about me, it does not check any interface except > that it's empty. Can you please just answer the question? REPOSITORY R245 Solid REVISION DETAIL

D13869: [solid] Notify when interface to mounted fs is lost

2018-07-23 Thread Anthony Fieroni
anthonyfieroni added inline comments. INLINE COMMENTS > bruns wrote in udisksmanager.cpp:220 > This does not answer my question. What I need from you is: > > - which interfaces are in `interfaces` > - which interfaces are in `device.interfaces()` > > so the **exact** case where the patched

D13869: [solid] Notify when interface to mounted fs is lost

2018-07-23 Thread Stefan Brüns
bruns added inline comments. INLINE COMMENTS > anthonyfieroni wrote in udisksmanager.cpp:220 > According to docs, > https://dbus.freedesktop.org/doc/dbus-specification.html#standard-interfaces-objectmanager, > interfaces should not be empty but a dict of looses ones. This does not answer my

D14283: C++: fix standard floating-point literals

2018-07-23 Thread Dominik Haumann
dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Please also increase the version number. REPOSITORY R216 Syntax Highlighting BRANCH fix_cpp_udl REVISION DETAIL https://phabricator.kde.org/D14283 To: jpoelen,

D14282: CSS: fix test reference of the previous commit

2018-07-23 Thread Dominik Haumann
dhaumann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH fix_cxx REVISION DETAIL https://phabricator.kde.org/D14282 To: jpoelen, dhaumann Cc: kde-frameworks-devel, kwrite-devel, michaelh, kevinapavew, ngraham, bruns,

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 - Build # 37 - Still Unstable!

2018-07-23 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.10/37/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 Date of build: Mon, 23 Jul 2018 10:18:01 + Build duration: 28 min and counting

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 187 - Still Unstable!

2018-07-23 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/187/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Mon, 23 Jul 2018 10:18:01 + Build duration: 7 min 18 sec and counting

D12820: Add KWayland virtual desktop protocol

2018-07-23 Thread Eike Hein
hein added a task: T4457: [kwayland] Virtual Desktop protocol. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D12820 To: mart, #kwin, #plasma, graesslin, hein Cc: davidedmundson, zzag, bshah, romangg, kde-frameworks-devel, michaelh, ngraham, bruns

D14291: Cleanup RemoteAccess buffers on aboutToBeUnbound instead of object destruction

2018-07-23 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: KWin. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY The destructor or

D13782: RFC: Ignore NTFS hidden flag for root volume

2018-07-23 Thread Kai Uwe Broulik
broulik added a comment. Ping REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13782 To: broulik, dfaure, ngraham, yurikoles, bruns Cc: oysteins, wbauer, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 - Build # 33 - Still Unstable!

2018-07-23 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.10/33/ Project: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 Date of build: Mon, 23 Jul 2018 08:55:41 + Build duration: 42 min and counting JUnit Tests

D14290: [KWidgetJobTracker] Show "Open Destination" etc buttons only if destination is valid

2018-07-23 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY It checks whether the file is not in `TEMP` but it

D14175: Support cursor hints on locked pointer

2018-07-23 Thread Roman Gilg
This revision was automatically updated to reflect the committed changes. Closed by commit R127:cebfd2f8d2f9: Support cursor hints on locked pointer (authored by romangg). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D14175?vs=37971=38231#toc REPOSITORY R127 KWayland CHANGES SINCE

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.9 - Build # 44 - Still Unstable!

2018-07-23 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.9/44/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.9 Date of build: Mon, 23 Jul 2018 08:55:41 + Build duration: 9 min 38 sec and counting JUnit Tests

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.10 - Build # 71 - Still Unstable!

2018-07-23 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/71/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.10 Date of build: Mon, 23 Jul 2018 08:55:41 + Build duration: 4 min 33 sec and counting JUnit Tests

D14175: Support cursor hints on locked pointer

2018-07-23 Thread Roman Gilg
romangg edited the summary of this revision. romangg edited the test plan for this revision. REPOSITORY R127 KWayland BRANCH cursorHints REVISION DETAIL https://phabricator.kde.org/D14175 To: romangg, #plasma, davidedmundson Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham,