D14302: Don't block forever in ensureKdeinitRunning

2018-07-23 Thread Thiago Macieira 
thiago added a comment.


  Quick testing via gdb:
  
Breakpoint 1, QLockFile::tryLock (this=0x7fffc6d8, timeout=0) at 
/home/tjmaciei/src/qt/qt5/qtbase/src/corelib/io/qlockfile.cpp:241
241 Q_D(QLockFile);
(gdb) n
242 QDeadlineTimer timer(qMax(timeout, -1));// QDT only takes 
-1 as "forever"
(gdb) 
243 int sleepTime = 100;
(gdb) 
245 d->lockError = d->tryLock_sys();
(gdb) 
246 switch (d->lockError) {
(gdb) 
254 if (!d->isLocked && d->isApparentlyStale()) {
(gdb) 
265 break;
(gdb) 
268 int remainingTime = timer.remainingTime();
(gdb) p timer
$4 = {t1 = 39043, t2 = 76902106, type = 1}
(gdb) s
QDeadlineTimer::remainingTime (this=0x7fffc590) at 
/home/tjmaciei/src/qt/qt5/qtbase/src/corelib/kernel/qdeadlinetimer.cpp:426
426 qint64 ns = remainingTimeNSecs();
(gdb) s
QDeadlineTimer::remainingTimeNSecs (this=0x7fffc590) at 
/home/tjmaciei/src/qt/qt5/qtbase/src/corelib/kernel/qdeadlinetimer.cpp:440
440 if (isForever())
(gdb) n
442 qint64 raw = rawRemainingTimeNSecs();
(gdb) n
443 return raw < 0 ? 0 : raw;
(gdb) p raw
$5 = -24344165069
(gdb) fin
Run till exit from #0  QDeadlineTimer::remainingTimeNSecs 
(this=0x7fffc590)
at 
/home/tjmaciei/src/qt/qt5/qtbase/src/corelib/kernel/qdeadlinetimer.cpp:443
0x77a1d014 in QDeadlineTimer::remainingTime (this=0x7fffc590)
at 
/home/tjmaciei/src/qt/qt5/qtbase/src/corelib/kernel/qdeadlinetimer.cpp:426
426 qint64 ns = remainingTimeNSecs();
Value returned is $6 = 0
(gdb) 
Run till exit from #0  0x77a1d014 in QDeadlineTimer::remainingTime 
(this=0x7fffc590)
at 
/home/tjmaciei/src/qt/qt5/qtbase/src/corelib/kernel/qdeadlinetimer.cpp:426
QLockFile::tryLock (this=0x7fffc6d8, timeout=0) at 
/home/tjmaciei/src/qt/qt5/qtbase/src/corelib/io/qlockfile.cpp:268
268 int remainingTime = timer.remainingTime();
Value returned is $7 = 0

REPOSITORY
  R271 KDBusAddons

REVISION DETAIL
  https://phabricator.kde.org/D14302

To: jtamate, dfaure, #frameworks, thiago
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14302: Don't block forever in ensureKdeinitRunning

2018-07-23 Thread Thiago Macieira 
thiago added a comment.


  In D14302#296479 , @dfaure wrote:
  
  > I agree about tryLock(0) should return immediately, tryLock(-1) should 
block forever -- I wrote that code and that docu ;-)
  >
  > Thiago wrote QDeadLineTimer later on though, and ported QLockFile to it. 
Thiago, any input?
  
  
  QDT has no escape path for 0. The constructor calls setRemainngTime(0), which 
calls setPreciseRemainingTime(0, 0), which will get the current time, add zero, 
and store it.
  
  After all of that, the QDT should return that the remaining time is zero, 
since it's expired.
  
  remainingTime() calls remainingTimeNSecs(), which calls 
rawRemainingTimeNSecs(), which should return a negative value. 
remainingTimeNSecs() should detect the negative and return 0; remainingTime 
detects the zero and returns it.
  
(gdb) print timer.remainingTime()
$11 = -1
  
  That's not supposed to happen.

REPOSITORY
  R271 KDBusAddons

REVISION DETAIL
  https://phabricator.kde.org/D14302

To: jtamate, dfaure, #frameworks, thiago
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 66 - Fixed!

2018-07-23 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/66/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 23 Jul 2018 23:49:54 +
 Build duration:
7 min 58 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report22%
(5/23)26%
(14/53)26%
(14/53)20%
(436/2151)19%
(211/1096)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)97%
(120/124)55%
(53/96)src100%
(8/8)100%
(8/8)75%
(235/312)59%
(124/210)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/136)0%
(0/88)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/17)0%
(0/12)src.plugins.bluetooth0%
(0/1)0%
(0/1)0%
(0/34)0%
(0/14)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/55)0%
(0/20)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/186)0%
(0/69)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/12)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/79)0%
(0/34)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/29)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/222)0%
(0/82)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/99)0%
(0/62)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/233)0%
(0/76)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/153)0%
(0/92)src.plugins.saveas100%
(1/1)100%
(1/1)57%
(29/51)64%
(28/44)src.plugins.telegram0%
(0/1)0%
(0/1)0%
(0/45)0%

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 89 - Fixed!

2018-07-23 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/89/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 23 Jul 2018 23:49:54 +
 Build duration:
7 min 1 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report22%
(5/23)26%
(14/53)26%
(14/53)19%
(413/2151)18%
(194/1096)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)97%
(120/124)58%
(56/96)src100%
(8/8)100%
(8/8)68%
(212/312)50%
(104/210)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/136)0%
(0/88)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/17)0%
(0/12)src.plugins.bluetooth0%
(0/1)0%
(0/1)0%
(0/34)0%
(0/14)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/55)0%
(0/20)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/186)0%
(0/69)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/12)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/79)0%
(0/34)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/29)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/222)0%
(0/82)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/99)0%
(0/62)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/233)0%
(0/76)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/153)0%
(0/92)src.plugins.saveas100%
(1/1)100%
(1/1)57%
(29/51)64%
(28/44)src.plugins.telegram0%
(0/1)0%
(0/1)0%
(0/45)0%

D14218: Introduce a test to make sure we're not offering duplicated icons

2018-07-23 Thread Aleix Pol Gonzalez 
apol added a comment.


  @andreask, thanks for looking into it. Now it's accepted but we'll get a 
bunch of errors, how do you suggest we resolve it? I'd rather have a plan 
before landing this.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14218

To: apol, andreaska, mart, vkrause, #breeze, #frameworks
Cc: ngraham, andreask, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 88 - Still Unstable!

2018-07-23 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/88/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 23 Jul 2018 23:31:34 +
 Build duration:
1 min 47 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.alternativesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report22%
(5/23)26%
(14/53)26%
(14/53)19%
(406/2150)17%
(186/1096)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)92%
(113/123)50%
(48/96)src100%
(8/8)100%
(8/8)68%
(212/312)50%
(104/210)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/136)0%
(0/88)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/17)0%
(0/12)src.plugins.bluetooth0%
(0/1)0%
(0/1)0%
(0/34)0%
(0/14)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/55)0%
(0/20)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/186)0%
(0/69)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/12)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/79)0%
(0/34)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/29)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/222)0%
(0/82)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/99)0%
(0/62)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/233)0%
(0/76)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/153)0%
(0/92)src.plugins.saveas100%
(1/1)100%
(1/1)57%
(29/51)64%
(28/44)src.plugins.telegram0%
(0/1)0%
(0/1)0%
(0/45)0%

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 65 - Still Unstable!

2018-07-23 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/65/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 23 Jul 2018 23:31:34 +
 Build duration:
1 min 49 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.alternativesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report22%
(5/23)26%
(14/53)26%
(14/53)20%
(429/2150)19%
(209/1096)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)92%
(113/123)53%
(51/96)src100%
(8/8)100%
(8/8)75%
(235/312)59%
(124/210)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/136)0%
(0/88)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/17)0%
(0/12)src.plugins.bluetooth0%
(0/1)0%
(0/1)0%
(0/34)0%
(0/14)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/55)0%
(0/20)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/186)0%
(0/69)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/12)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/79)0%
(0/34)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/29)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/222)0%
(0/82)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/99)0%
(0/62)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/233)0%
(0/76)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/153)0%
(0/92)src.plugins.saveas100%
(1/1)100%
(1/1)57%
(29/51)64%
(28/44)src.plugins.telegram0%
(0/1)0%
(0/1)0%
(0/45)0%

KDE CI: Frameworks purpose kf5-qt5 FreeBSDQt5.10 - Build # 53 - Fixed!

2018-07-23 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20FreeBSDQt5.10/53/
 Project:
Frameworks purpose kf5-qt5 FreeBSDQt5.10
 Date of build:
Mon, 23 Jul 2018 23:31:34 +
 Build duration:
1 min 48 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)

KDE CI: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9 - Build # 59 - Fixed!

2018-07-23 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.9/59/
 Project:
Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 23 Jul 2018 21:23:40 +
 Build duration:
2 min 11 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 9 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)82%
(27/33)82%
(27/33)79%
(2273/2891)68%
(1561/2301)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(8/8)100%
(8/8)97%
(499/512)63%
(243/388)examples0%
(0/2)0%
(0/2)0%
(0/197)0%
(0/98)src.cli0%
(0/1)0%
(0/1)0%
(0/67)0%
(0/30)src.indexer100%
(1/1)100%
(1/1)76%
(179/236)76%
(153/202)src.lib86%
(18/21)86%
(18/21)85%
(1595/1879)74%
(1165/1583)

KDE CI: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.10 - Build # 115 - Fixed!

2018-07-23 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.10/115/
 Project:
Frameworks syntax-highlighting kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 23 Jul 2018 21:23:40 +
 Build duration:
2 min 9 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 9 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)82%
(27/33)82%
(27/33)79%
(2273/2891)68%
(1561/2301)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(8/8)100%
(8/8)97%
(499/512)63%
(243/388)examples0%
(0/2)0%
(0/2)0%
(0/197)0%
(0/98)src.cli0%
(0/1)0%
(0/1)0%
(0/67)0%
(0/30)src.indexer100%
(1/1)100%
(1/1)76%
(179/236)76%
(153/202)src.lib86%
(18/21)86%
(18/21)85%
(1595/1879)74%
(1165/1583)

KDE CI: Frameworks syntax-highlighting kf5-qt5 FreeBSDQt5.10 - Build # 43 - Fixed!

2018-07-23 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20FreeBSDQt5.10/43/
 Project:
Frameworks syntax-highlighting kf5-qt5 FreeBSDQt5.10
 Date of build:
Mon, 23 Jul 2018 21:23:37 +
 Build duration:
2 min 0 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 8 test(s)

KDE CI: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9 - Build # 58 - Still Unstable!

2018-07-23 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.9/58/
 Project:
Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 23 Jul 2018 21:21:28 +
 Build duration:
2 min 11 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: TestSuite.testhighlighter_test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)82%
(27/33)82%
(27/33)79%
(2273/2891)68%
(1562/2301)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(8/8)100%
(8/8)97%
(499/512)63%
(244/388)examples0%
(0/2)0%
(0/2)0%
(0/197)0%
(0/98)src.cli0%
(0/1)0%
(0/1)0%
(0/67)0%
(0/30)src.indexer100%
(1/1)100%
(1/1)76%
(179/236)76%
(153/202)src.lib86%
(18/21)86%
(18/21)85%
(1595/1879)74%
(1165/1583)

KDE CI: Frameworks syntax-highlighting kf5-qt5 FreeBSDQt5.10 - Build # 42 - Still Unstable!

2018-07-23 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20FreeBSDQt5.10/42/
 Project:
Frameworks syntax-highlighting kf5-qt5 FreeBSDQt5.10
 Date of build:
Mon, 23 Jul 2018 21:21:28 +
 Build duration:
2 min 7 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 8 test(s)Failed: TestSuite.testhighlighter_test

KDE CI: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.10 - Build # 114 - Still Unstable!

2018-07-23 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.10/114/
 Project:
Frameworks syntax-highlighting kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 23 Jul 2018 21:21:28 +
 Build duration:
2 min 11 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: TestSuite.testhighlighter_test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)82%
(27/33)82%
(27/33)79%
(2273/2891)68%
(1562/2301)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(8/8)100%
(8/8)97%
(499/512)63%
(244/388)examples0%
(0/2)0%
(0/2)0%
(0/197)0%
(0/98)src.cli0%
(0/1)0%
(0/1)0%
(0/67)0%
(0/30)src.indexer100%
(1/1)100%
(1/1)76%
(179/236)76%
(153/202)src.lib86%
(18/21)86%
(18/21)85%
(1595/1879)74%
(1165/1583)

D14282: CSS: fix test reference of the previous commit

2018-07-23 Thread jonathan poelen 
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:a82af177bc2f: CSS: fix test reference of the previous 
commit (authored by jpoelen).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14282?vs=38217=38277

REVISION DETAIL
  https://phabricator.kde.org/D14282

AFFECTED FILES
  autotests/reference/highlight.css.ref
  autotests/reference/review128925-1.css.ref
  autotests/reference/review128925-2.css.ref

To: jpoelen, dhaumann
Cc: kde-frameworks-devel, kwrite-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D14283: C++: fix standard floating-point literals

2018-07-23 Thread jonathan poelen 
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:7a2ae6be229b: C++: fix standard floating-point literals 
(authored by jpoelen).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14283?vs=38218=38276

REVISION DETAIL
  https://phabricator.kde.org/D14283

AFFECTED FILES
  autotests/folding/highlight.cpp.fold
  autotests/html/highlight.cpp.html
  autotests/input/highlight.cpp
  autotests/reference/highlight.cpp.ref
  data/syntax/isocpp.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann
Cc: kde-frameworks-devel, kwrite-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D14308: [Exe Thumbnailer] Improve icon selection algorithm

2018-07-23 Thread Nathaniel Graham 
ngraham added a comment.


  What a dramatic set of before-and-after images! It's like we jumped from 1991 
to 2018.
  
  > Algo is basically copied from Plasma's wallpaper selection
  
  Sounds like we should put this in a Framework and re-use it instead of 
copy-pasting it here.

INLINE COMMENTS

> icoutils_common.cpp:33
> +
> +return qAbs(candidateAspectRatio - desiredAspectRatio) * 25000 + delta;
> +}

Where does this magic number come from?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D14308

To: broulik, #frameworks, dfaure, ngraham, pali, vonreth, antlarr

D14201: Set system default shortcut Ctrl+0 for "Actual Size" action

2018-07-23 Thread Nathaniel Graham 
ngraham added a comment.


  Hah! Well in that case, that won't be a blocker.

REPOSITORY
  R237 KConfig

BRANCH
  shortcut-actual-size (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14201

To: muhlenpfordt, dfaure, broulik, ngraham
Cc: rkflx, kde-frameworks-devel, michaelh, ngraham, bruns

D14201: Set system default shortcut Ctrl+0 for "Actual Size" action

2018-07-23 Thread Henrik Fehlauer 
rkflx added a comment.


  Thanks for your support ;)
  
  In D14201#296520 , @ngraham wrote:
  
  > Let's hold off on landing this patch (if accepted by everyone) until  
Cirkuit has had a release with D14202  so 
we don't wind up with the dreaded "Ambiguous Shortcut!" dialog.
  
  
  Are you sure about that? This might mean waiting forever.
  
  AFAIK Cirkuit did not even have a KF5 release yet, I'd assume everyone is 
just running from the `frameworks` branch, or stuck on an old KDE4 distro which 
would not get the new KConfig anyway. Ubuntu shipped it in 16.04, 18.04 does 
not have it anymore in the default repos. This app is not exactly a second 
DigiKam where your comment might be coming from, with wide distribution and 
regular releases.

REPOSITORY
  R237 KConfig

BRANCH
  shortcut-actual-size (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14201

To: muhlenpfordt, dfaure, broulik, ngraham
Cc: rkflx, kde-frameworks-devel, michaelh, ngraham, bruns

D14201: Set system default shortcut Ctrl+0 for "Actual Size" action

2018-07-23 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Yes, I like it the idea. The chosen shortcut makes sense, and I'm always in 
favor of standardizing these across apps. Let's hold off on landing this patch 
(if accepted by everyone) until  Cirkuit has had a release with D14202 
 so we don't wind up with the dreaded 
"Ambiguous Shortcut!" dialog.

REPOSITORY
  R237 KConfig

BRANCH
  shortcut-actual-size (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14201

To: muhlenpfordt, dfaure, broulik, ngraham
Cc: rkflx, kde-frameworks-devel, michaelh, ngraham, bruns

D14302: Don't block forever in ensureKdeinitRunning

2018-07-23 Thread Jaime Torres Amate 
jtamate added a comment.


  In D14302#296469 , @jtamate wrote:
  
  > I guess this is a Qt bug.
  >
  >   qint64 QDeadlineTimer::remainingTime() const Q_DECL_NOTHROW
  >   {
  >   qint64 ns = remainingTimeNSecs();
  >   return ns <= 0 ? ns : (ns + 99) / (1000 * 1000);
  >   }
  >
  >
  > Shouldn't it be:
  >
  >   return ns <= 0 ? **0** : (ns + 99) / (1000 * 1000);
  >
  
  
  I answer myself. It is ok. If remainingTimeNSecs() return -1 it also returns 
-1 (never expire), and in inremainingTimeNSecs() it can only be -1 or 0 or >0
  
return raw < 0 ? 0 : raw;
  
  But
  (gdb) print timer.remainingTime()
  $11 = -1
  (gdb) print sleepTime
  $13 = 6400
  
  Therefore isForever() is returning true. Why?

REPOSITORY
  R271 KDBusAddons

REVISION DETAIL
  https://phabricator.kde.org/D14302

To: jtamate, dfaure, #frameworks, thiago
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14201: Set system default shortcut Ctrl+0 for "Actual Size" action

2018-07-23 Thread Henrik Fehlauer 
rkflx added a comment.


  @ngraham Would this patch be something you could back?

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D14201

To: muhlenpfordt, dfaure, broulik, ngraham
Cc: rkflx, kde-frameworks-devel, michaelh, ngraham, bruns

D14275: Add Autodesk EAGLE sch and brd file format to the XML category

2018-07-23 Thread Miklos Marton 
martonmiklos updated this revision to Diff 38273.
martonmiklos added a comment.


  Updated revision to 8 from 7 as suggested in the review.

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14275?vs=38204=38273

REVISION DETAIL
  https://phabricator.kde.org/D14275

AFFECTED FILES
  data/syntax/xml.xml

To: martonmiklos, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, 
#framework_syntax_highlighting, michaelh, genethomas, kevinapavew, ngraham, 
bruns, demsking, cullmann, vkrause, sars

D14308: [Exe Thumbnailer] Improve icon selection algorithm

2018-07-23 Thread Kai Uwe Broulik 
broulik created this revision.
broulik added reviewers: Frameworks, dfaure, ngraham, pali, vonreth, antlarr.
broulik requested review of this revision.

REVISION SUMMARY
  Prefer downsampling over upscaling

TEST PLAN
  Dolphin requested 128px thumbnail here. Wine executables have 32, 48, and 256 
icons. It would pick the 48 one:
  F6132594: Screenshot_20180723_204523.png 

  Afterwards it would use the 256 ones
  F6132596: Screenshot_20180723_204442.png 

  The effect isn't neccessarily as noticeable with every icon and I hardly have 
any "real" windows EXE files around to test :)
  Algo is basically copied from Plasma's wallpaper selection

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D14308

AFFECTED FILES
  thumbnail/icoutils_common.cpp

To: broulik, #frameworks, dfaure, ngraham, pali, vonreth, antlarr

D14302: Don't block forever in ensureKdeinitRunning

2018-07-23 Thread David Faure 
dfaure added a comment.


  I agree about tryLock(0) should return immediately, tryLock(-1) should block 
forever -- I wrote that code and that docu ;-)
  
  Thiago wrote QDeadLineTimer later on though, and ported QLockFile to it. 
Thiago, any input?

REPOSITORY
  R271 KDBusAddons

REVISION DETAIL
  https://phabricator.kde.org/D14302

To: jtamate, dfaure, #frameworks, thiago
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14302: Don't block forever in ensureKdeinitRunning

2018-07-23 Thread David Faure 
dfaure added a reviewer: thiago.

REPOSITORY
  R271 KDBusAddons

REVISION DETAIL
  https://phabricator.kde.org/D14302

To: jtamate, dfaure, #frameworks, thiago
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14302: Don't block forever in ensureKdeinitRunning

2018-07-23 Thread Jaime Torres Amate 
jtamate added a comment.


  I guess this is a Qt bug.
  
qint64 QDeadlineTimer::remainingTime() const Q_DECL_NOTHROW
{
qint64 ns = remainingTimeNSecs();
return ns <= 0 ? ns : (ns + 99) / (1000 * 1000);
}
  
  Shouldn't it be:
  
return ns <= 0 ? **0** : (ns + 99) / (1000 * 1000);

REPOSITORY
  R271 KDBusAddons

REVISION DETAIL
  https://phabricator.kde.org/D14302

To: jtamate, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks purpose kf5-qt5 FreeBSDQt5.10 - Build # 52 - Unstable!

2018-07-23 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20FreeBSDQt5.10/52/
 Project:
Frameworks purpose kf5-qt5 FreeBSDQt5.10
 Date of build:
Mon, 23 Jul 2018 18:09:22 +
 Build duration:
1 min 45 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.alternativesmodeltest

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 64 - Unstable!

2018-07-23 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/64/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 23 Jul 2018 18:09:23 +
 Build duration:
1 min 43 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.alternativesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report22%
(5/23)25%
(13/53)25%
(13/53)15%
(328/2146)14%
(154/1128)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests50%
(1/2)50%
(1/2)24%
(30/123)11%
(14/128)src100%
(8/8)100%
(8/8)70%
(217/308)54%
(114/210)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/136)0%
(0/88)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/17)0%
(0/12)src.plugins.bluetooth0%
(0/1)0%
(0/1)0%
(0/34)0%
(0/14)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/55)0%
(0/20)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/186)0%
(0/69)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/12)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/79)0%
(0/34)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/29)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/222)0%
(0/82)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/99)0%
(0/62)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/233)0%
(0/76)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/153)0%
(0/92)src.plugins.saveas100%
(1/1)100%
(1/1)57%
(29/51)45%
(20/44)src.plugins.telegram0%
(0/1)0%
(0/1)0%
(0/45)0%

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 87 - Still Unstable!

2018-07-23 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/87/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 23 Jul 2018 18:09:23 +
 Build duration:
1 min 46 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.alternativesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report22%
(5/23)25%
(13/53)25%
(13/53)14%
(305/2146)12%
(132/1128)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests50%
(1/2)50%
(1/2)24%
(30/123)9%
(12/128)src100%
(8/8)100%
(8/8)63%
(194/308)45%
(94/210)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/136)0%
(0/88)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/17)0%
(0/12)src.plugins.bluetooth0%
(0/1)0%
(0/1)0%
(0/34)0%
(0/14)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/55)0%
(0/20)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/186)0%
(0/69)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/12)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/79)0%
(0/34)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/29)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/222)0%
(0/82)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/99)0%
(0/62)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/233)0%
(0/76)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/153)0%
(0/92)src.plugins.saveas100%
(1/1)100%
(1/1)57%
(29/51)45%
(20/44)src.plugins.telegram0%
(0/1)0%
(0/1)0%
(0/45)0%

D14218: Introduce a test to make sure we're not offering duplicated icons

2018-07-23 Thread Andreas Kainz 
andreaska accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14218

To: apol, andreaska, mart, vkrause, #breeze, #frameworks
Cc: ngraham, andreask, kde-frameworks-devel, michaelh, bruns

D14302: Don't block forever in ensureKdeinitRunning

2018-07-23 Thread Jaime Torres Amate 
jtamate added a comment.


  I kept dolphin blocked, just in case.
  
  The backtrace:
  
#0  0x7f54c47c4c90 in __GI___nanosleep 
(requested_time=requested_time@entry=0x7ffdda996710, 
remaining=remaining@entry=0x7ffdda996710)
at ../sysdeps/unix/sysv/linux/nanosleep.c:28
#1  0x7f54be9b236d in qt_nanosleep(timespec) (amount=...) at 
kernel/qelapsedtimer_unix.cpp:195
#2  0x7f54be8bc985 in QLockFile::tryLock(int) (this=, 
timeout=) at io/qlockfile.cpp:274
#3  0x7f54c0a23afb in KDEInitInterface::ensureKdeinitRunning() () at 
/usr/lib64/libKF5DBusAddons.so.5
#4  0x7f54c2d16ffb in  () at /usr/lib64/libKF5KIOCore.so.5
#5  0x7f54c2d17e7a in KIO::Slave::createSlave(QString const&, QUrl 
const&, int&, QString&) () at /usr/lib64/libKF5KIOCore.so.5
#6  0x7f54c2d4c715 in  () at /usr/lib64/libKF5KIOCore.so.5
#7  0x7f54c2d52fbc in  () at /usr/lib64/libKF5KIOCore.so.5
#8  0x7f54be98ba53 in QMetaObject::activate(QObject*, int, int, void**) 
(sender=0x557a8ecc2948, signalOffset=, local_signal_index=0, 
argv=0x7ffdda996b80) at kernel/qobject.cpp:3771
#9  0x7f54be98c087 in QMetaObject::activate(QObject*, QMetaObject 
const*, int, void**) (sender=, m=m@entry=0x7f54bede4d80 
, local_signal_index=local_signal_index@entry=0, 
argv=argv@entry=0x7ffdda996b80) at kernel/qobject.cpp:3633
#10 0x7f54be996fd7 in QTimer::timeout(QTimer::QPrivateSignal) 
(this=, _t1=...) at .moc/moc_qtimer.cpp:200
#11 0x7f54be98c27b in QObject::event(QEvent*) (this=0x557a8ecc2948, 
e=) at kernel/qobject.cpp:1232
#12 0x7f54bf96eb01 in QApplicationPrivate::notify_helper(QObject*, 
QEvent*) (this=this@entry=0x557a8e694980, 
receiver=receiver@entry=0x557a8ecc2948, e=e@entry=0x7ffdda996e30) at 
kernel/qapplication.cpp:3714
#13 0x7f54bf975cea in QApplication::notify(QObject*, QEvent*) 
(this=0x7ffdda9970b0, receiver=0x557a8ecc2948, e=0x7ffdda996e30) at 
kernel/qapplication.cpp:3473
#14 0x7f54be963be9 in QCoreApplication::notifyInternal2(QObject*, 
QEvent*) (receiver=0x557a8ecc2948, event=0x7ffdda996e30)
at ../../include/QtCore/../../src/corelib/kernel/qobject.h:142
#15 0x7f54be9b1e28 in QCoreApplication::sendEvent(QObject*, QEvent*) 
(event=0x7ffdda996e30, receiver=)
at ../../include/QtCore/../../src/corelib/kernel/qcoreapplication.h:234
#16 0x7f54be9b1e28 in QTimerInfoList::activateTimers() 
(this=0x557a8e760f60) at kernel/qtimerinfo_unix.cpp:643
#17 0x7f54be9b00ac in 
QEventDispatcherUNIX::processEvents(QFlags) 
(this=, flags=...)
at kernel/qeventdispatcher_unix.cpp:514
#18 0x7f54b0c0f78d in 
QUnixEventDispatcherQPA::processEvents(QFlags) 
(this=, flags=...)
at qunixeventdispatcher.cpp:68
#19 0x7f54be9629fb in 
QEventLoop::exec(QFlags) (this=0x7ffdda996fc0, 
flags=...)
at ../../include/QtCore/../../src/corelib/global/qflags.h:140
#20 0x7f54be96a78e in QCoreApplication::exec() () at 
../../include/QtCore/../../src/corelib/global/qflags.h:120
#21 0x7f54c4b03c59 in kdemain(int, char**) (argc=, 
argv=) at 
/usr/src/debug/dolphin-18.04.2-1.1.x86_64/src/main.cpp:150
#22 0x7f54c472011b in __libc_start_main (main=
0x557a8d3057c0 , argc=3, argv=0x7ffdda997238, init=, fini=, rtld_fini=, stack_end=0x7ffdda997228)
at ../csu/libc-start.c:308
#23 0x557a8d3057fa in _start () at ../sysdeps/x86_64/start.S:120
  
  0 timeout should exit immediately, a negative number is locked forever (the 
documentation tells).

REPOSITORY
  R271 KDBusAddons

REVISION DETAIL
  https://phabricator.kde.org/D14302

To: jtamate, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14302: Don't block forever in ensureKdeinitRunning

2018-07-23 Thread David Faure 
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  Strange, I never had that bug.
  
  Note that you can use gdb to get a backtrace for a deadlock, no need for 
hotspot for that particular task. In fact, hotspot even misled you. tryLock() 
can't be the problem, it returns immediately ;)  (default timeout 0)
  
  I guess lock() -- which is the actual blocking method in this code -- is 
where everything got stuck. Unfortunately you didn't get a backtrace so we 
can't verify this until it happens again? :(
  
  Maybe a stale lock file, but not detected as one by QLockFile, could lead to 
lock() blocking forever... A recursive call to that method would do that too, 
but I don't see how that could happen.
  
  If you want to introduce some safety against locking forever, it's lock() 
that should be replaced with tryLock(long timeout). I would make it much more 
than 5s though, kdeinit startup can take much more than that (imagine a slow 
system, swapping already, kdeinit starts a number of other processes, and 
triggers config file migration with kconf_update, etc.).

REPOSITORY
  R271 KDBusAddons

REVISION DETAIL
  https://phabricator.kde.org/D14302

To: jtamate, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14291: Cleanup RemoteAccess buffers on aboutToBeUnbound instead of object destruction

2018-07-23 Thread Roman Gilg 
romangg accepted this revision.
romangg added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> remote_access_interface.cpp:244
>  
> -QObject::connect(rbuf, ::destroyed, [p, rbuf, resource, ] {
> +QObject::connect(rbuf, ::aboutToBeUnbound, p->q, [p, rbuf, 
> resource, ] {
>  if (!p->clientResources.contains(resource)) {

Why `p->q`? Isn't just `p` enough? Or since `getBufferCallback` is static, 
leave the slot without object relation? Just connect to the functor as before. 
But in the end that all doesn't matter much.

> remote_access_interface.cpp:251
>  qCDebug(KWAYLAND_SERVER) << "Remote buffer returned, client" << 
> wl_resource_get_id(resource)
>   << ", id" << rbuf->id()
>   << ", fd" << 
> bh.buf->fd();

If the problem is only this call to id(), then maybe one could just hand over 
this value to the lambda instead of accessing `rbuf`. But connecting to the 
`aboutToBeUnbound` signal is also fine.

REPOSITORY
  R127 KWayland

BRANCH
  dave

REVISION DETAIL
  https://phabricator.kde.org/D14291

To: davidedmundson, #kwin, romangg
Cc: romangg, kde-frameworks-devel, michaelh, ngraham, bruns

D14302: Don't block forever in ensureKdeinitRunning

2018-07-23 Thread Jaime Torres Amate 
jtamate retitled this revision from "Don't block forever to 
ensureKdeinitRunning" to "Don't block forever in ensureKdeinitRunning".
jtamate edited the summary of this revision.

REPOSITORY
  R271 KDBusAddons

REVISION DETAIL
  https://phabricator.kde.org/D14302

To: jtamate, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14302: Don't block forever to ensureKdeinitRunning

2018-07-23 Thread Jaime Torres Amate 
jtamate created this revision.
jtamate added reviewers: dfaure, Frameworks.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
jtamate requested review of this revision.

REVISION SUMMARY
  My wife has been suffering this block for several months while I was not 
there, and it never happened to me.
  Finally, It just has happened to me: plasmashell, ktorrent, akregator and 
dolphin where totally blocked.
  With the help of hotspot, the common method between all of them is: 
ensureKdeinitRunning()
  
  Instead of blocking forever, wait a finite amount of time.

REPOSITORY
  R271 KDBusAddons

REVISION DETAIL
  https://phabricator.kde.org/D14302

AFFECTED FILES
  src/kdeinitinterface.cpp

To: jtamate, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14218: Introduce a test to make sure we're not offering duplicated icons

2018-07-23 Thread Nathaniel Graham 
ngraham added a comment.


  +1 conceptually.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D14218

To: apol, andreaska, mart, vkrause, #breeze, #frameworks
Cc: ngraham, andreask, kde-frameworks-devel, michaelh, bruns

D14218: Introduce a test to make sure we're not offering duplicated icons

2018-07-23 Thread Nathaniel Graham 
ngraham edited reviewers, added: Breeze, Frameworks; removed: Framework: Syntax 
Highlighting.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D14218

To: apol, andreaska, mart, vkrause, #breeze, #frameworks, 
#framework_syntax_highlighting
Cc: andreask, kde-frameworks-devel, michaelh, ngraham, bruns

D13782: RFC: Ignore NTFS hidden flag for root volume

2018-07-23 Thread Nathaniel Graham 
ngraham resigned from this revision.
ngraham added a comment.


  @wbauer, does this work for you now? Or @bruns? Still cannot test as I have 
no NTFS partitions.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13782

To: broulik, dfaure, yurikoles, bruns
Cc: oysteins, wbauer, kde-frameworks-devel, michaelh, ngraham, bruns

D14218: Introduce a test to make sure we're not offering duplicated icons

2018-07-23 Thread Marco Martin 
mart added a comment.


  +100 from me as well

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D14218

To: apol, andreaska, mart, vkrause, #framework_syntax_highlighting
Cc: andreask, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 188 - Still Unstable!

2018-07-23 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/188/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 23 Jul 2018 14:25:37 +
 Build duration:
8 min 18 sec and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)31%
(39/126)31%
(39/126)27%
(3497/13098)19%
(1796/9432)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests79%
(11/14)79%
(11/14)53%
(588/1113)29%
(310/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core19%
(3/16)19%
(3/16)11%
(252/2208)7%
(94/1432)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma55%
(12/22)55%
(12/22)41%
(1418/3491)30%
(790/2633)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/135)0%
(0/12)src.plasma.private47%
(9/19)47%
(9/19)43%
(661/1540)30%
(300/1001)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)28%
(547/1973)17%
(297/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1096)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 - Build # 38 - Still Unstable!

2018-07-23 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.10/38/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10
 Date of build:
Mon, 23 Jul 2018 14:25:37 +
 Build duration:
3 min 34 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

D12311: Align lock icon with bold message text; reduce overall size of dialog

2018-07-23 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.


  Go for it then!

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: stikonas, bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

2018-07-23 Thread Scott Harvey 
sharvey added a comment.


  I believe it's done.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: stikonas, bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D14009: [Plasma PluginLoader] Cache plugins during startup

2018-07-23 Thread Kai Uwe Broulik 
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:af01c2e95370: [Plasma PluginLoader] Cache plugins during 
startup (authored by broulik).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14009?vs=37473=38259

REVISION DETAIL
  https://phabricator.kde.org/D14009

AFFECTED FILES
  src/plasma/pluginloader.cpp

To: broulik, #plasma, davidedmundson, mart
Cc: ngraham, zzag, kde-frameworks-devel, michaelh, bruns

D6512: Add support for proposed tags addition in OCS 1.7

2018-07-23 Thread Arjen Hiemstra 
ahiemstra added a comment.


  T6133  suggests that tags are formatted as 
"group##key=value" or something similar. Wouldn't it make sense to handle 
parsing that format here as well? Or are tags more intended as exact matches?

REPOSITORY
  R235 Attica

REVISION DETAIL
  https://phabricator.kde.org/D6512

To: leinir, #knewstuff, apol, whiting, #kde_store
Cc: ahiemstra, ngraham, kde-frameworks-devel, #kde_store, michaelh, ZrenBot, 
bruns, akiraohgaki, alexanderschmidt, siyuandong, ronaldv, mikesomov, starbuck, 
sebas

D12311: Align lock icon with bold message text; reduce overall size of dialog

2018-07-23 Thread Nathaniel Graham 
ngraham added a comment.


  Can we commit this?

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: stikonas, bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D13869: [solid] Notify when interface to mounted fs is lost

2018-07-23 Thread Anthony Fieroni 
anthonyfieroni added a comment.


  Device(udi).interfaces() ("org.freedesktop.UDisks2.Loop", 
"org.freedesktop.UDisks2.Block") 
  interfaces ("org.freedesktop.UDisks2.Filesystem")

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D13869

To: anthonyfieroni, broulik, cfeck, dfaure
Cc: bcooksley, bruns, kde-frameworks-devel, michaelh, ngraham

D13869: [solid] Notify when interface to mounted fs is lost

2018-07-23 Thread Anthony Fieroni 
anthonyfieroni added inline comments.

INLINE COMMENTS

> bruns wrote in udisksmanager.cpp:220
> This does not answer my question. What I need from you is:
> 
> - which interfaces are in `interfaces`
> - which interfaces are in `device.interfaces()`
> 
> so the **exact** case where the patched code triggers, but the old does not.

In which cases what you to know the interfaces?

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D13869

To: anthonyfieroni, broulik, cfeck, dfaure
Cc: bcooksley, bruns, kde-frameworks-devel, michaelh, ngraham

D13869: [solid] Notify when interface to mounted fs is lost

2018-07-23 Thread Stefan Brüns 
bruns added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in udisksmanager.cpp:220
> Old code is complete broken, about me, it does not check any interface except 
> that it's empty.

Can you please just answer the question?

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D13869

To: anthonyfieroni, broulik, cfeck, dfaure
Cc: bcooksley, bruns, kde-frameworks-devel, michaelh, ngraham

D13869: [solid] Notify when interface to mounted fs is lost

2018-07-23 Thread Anthony Fieroni 
anthonyfieroni added inline comments.

INLINE COMMENTS

> bruns wrote in udisksmanager.cpp:220
> This does not answer my question. What I need from you is:
> 
> - which interfaces are in `interfaces`
> - which interfaces are in `device.interfaces()`
> 
> so the **exact** case where the patched code triggers, but the old does not.

Old code is complete broken, about me, it does not check any interface except 
that it's empty.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D13869

To: anthonyfieroni, broulik, cfeck, dfaure
Cc: bcooksley, bruns, kde-frameworks-devel, michaelh, ngraham

D13869: [solid] Notify when interface to mounted fs is lost

2018-07-23 Thread Stefan Brüns 
bruns added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in udisksmanager.cpp:220
> According to docs, 
> https://dbus.freedesktop.org/doc/dbus-specification.html#standard-interfaces-objectmanager,
>  interfaces should not be empty but a dict of looses ones.

This does not answer my question. What I need from you is:

- which interfaces are in `interfaces`
- which interfaces are in `device.interfaces()`

so the **exact** case where the patched code triggers, but the old does not.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D13869

To: anthonyfieroni, broulik, cfeck, dfaure
Cc: bcooksley, bruns, kde-frameworks-devel, michaelh, ngraham

D14283: C++: fix standard floating-point literals

2018-07-23 Thread Dominik Haumann 
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  Please also increase the version number.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  fix_cpp_udl

REVISION DETAIL
  https://phabricator.kde.org/D14283

To: jpoelen, #framework_syntax_highlighting, dhaumann
Cc: kde-frameworks-devel, kwrite-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D14282: CSS: fix test reference of the previous commit

2018-07-23 Thread Dominik Haumann 
dhaumann accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  fix_cxx

REVISION DETAIL
  https://phabricator.kde.org/D14282

To: jpoelen, dhaumann
Cc: kde-frameworks-devel, kwrite-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 - Build # 37 - Still Unstable!

2018-07-23 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.10/37/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10
 Date of build:
Mon, 23 Jul 2018 10:18:01 +
 Build duration:
28 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 187 - Still Unstable!

2018-07-23 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/187/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 23 Jul 2018 10:18:01 +
 Build duration:
7 min 18 sec and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)31%
(39/126)31%
(39/126)27%
(3489/13084)19%
(1789/9422)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests79%
(11/14)79%
(11/14)53%
(588/1113)29%
(310/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core19%
(3/16)19%
(3/16)11%
(252/2208)7%
(94/1432)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma55%
(12/22)55%
(12/22)41%
(1410/3477)30%
(784/2623)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/135)0%
(0/12)src.plasma.private47%
(9/19)47%
(9/19)43%
(661/1540)30%
(299/1001)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)28%
(547/1973)17%
(297/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1096)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%

D12820: Add KWayland virtual desktop protocol

2018-07-23 Thread Eike Hein 
hein added a task: T4457: [kwayland] Virtual Desktop protocol.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D12820

To: mart, #kwin, #plasma, graesslin, hein
Cc: davidedmundson, zzag, bshah, romangg, kde-frameworks-devel, michaelh, 
ngraham, bruns

D14291: Cleanup RemoteAccess buffers on aboutToBeUnbound instead of object destruction

2018-07-23 Thread David Edmundson 
davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  The destructor or Resource::~Resource will delete the d-pointer used by
  Resource before we reach QObject::~QObject() of the resource which emits
  the destroyed signal. This means this lamba is accessing deleted
  contents.
  
  Based on
  
https://build.kde.org/view/Frameworks/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/71/testReport/
  
  aboutToBeUnbound is emitted before object destruction.

TEST PLAN
  Relevant unit test still passes and this lambda is still invoked.

REPOSITORY
  R127 KWayland

BRANCH
  dave

REVISION DETAIL
  https://phabricator.kde.org/D14291

AFFECTED FILES
  src/server/remote_access_interface.cpp

To: davidedmundson, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13782: RFC: Ignore NTFS hidden flag for root volume

2018-07-23 Thread Kai Uwe Broulik 
broulik added a comment.


  Ping

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13782

To: broulik, dfaure, ngraham, yurikoles, bruns
Cc: oysteins, wbauer, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 - Build # 33 - Still Unstable!

2018-07-23 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.10/33/
 Project:
Frameworks kwayland kf5-qt5 FreeBSDQt5.10
 Date of build:
Mon, 23 Jul 2018 08:55:41 +
 Build duration:
42 min and counting
   JUnit Tests
  Name: (root) Failed: 17 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 40 test(s)Failed: TestSuite.kwayland-testCompositorFailed: TestSuite.kwayland-testDataDeviceFailed: TestSuite.kwayland-testDataSourceFailed: TestSuite.kwayland-testIdleFailed: TestSuite.kwayland-testRegionFailed: TestSuite.kwayland-testRemoteAccessFailed: TestSuite.kwayland-testShmPoolFailed: TestSuite.kwayland-testSubCompositorFailed: TestSuite.kwayland-testSubSurfaceFailed: TestSuite.kwayland-testWaylandConnectionThreadFailed: TestSuite.kwayland-testWaylandRegistryFailed: TestSuite.kwayland-testWaylandServerDisplayFailed: TestSuite.kwayland-testWaylandShellFailed: TestSuite.kwayland-testWaylandSurfaceFailed: TestSuite.kwayland-testXdgShellStableFailed: TestSuite.kwayland-testXdgShellV5Failed: TestSuite.kwayland-testXdgShellV6

D14290: [KWidgetJobTracker] Show "Open Destination" etc buttons only if destination is valid

2018-07-23 Thread Kai Uwe Broulik 
broulik created this revision.
broulik added a reviewer: dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  It checks whether the file is not in `TEMP` but it doesn't check whether the 
`QUrl` is valid.
  It opens `destination` when you click the button which fails when it is 
invalid/empty.
  
  CCBUG: 396738

TEST PLAN
  Buttons no longer show when there is no destination

REPOSITORY
  R288 KJobWidgets

REVISION DETAIL
  https://phabricator.kde.org/D14290

AFFECTED FILES
  src/kwidgetjobtracker.cpp

To: broulik, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14175: Support cursor hints on locked pointer

2018-07-23 Thread Roman Gilg 
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:cebfd2f8d2f9: Support cursor hints on locked pointer 
(authored by romangg).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D14175?vs=37971=38231#toc

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14175?vs=37971=38231

REVISION DETAIL
  https://phabricator.kde.org/D14175

AFFECTED FILES
  autotests/client/test_pointer_constraints.cpp
  src/server/pointerconstraints_interface.cpp
  src/server/pointerconstraints_interface.h
  src/server/pointerconstraints_interface_p.h
  src/server/pointerconstraints_interface_v1.cpp

To: romangg, #plasma, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.9 - Build # 44 - Still Unstable!

2018-07-23 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.9/44/
 Project:
Frameworks kwayland kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 23 Jul 2018 08:55:41 +
 Build duration:
9 min 38 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 44 test(s), Skipped: 0 test(s), Total: 45 test(s)Failed: TestSuite.kwayland-testRemoteAccess
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)90%
(228/254)90%
(228/254)86%
(24010/27979)53%
(9536/18061)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client98%
(40/41)98%
(40/41)98%
(11249/11524)49%
(5991/12113)autotests.server100%
(5/5)100%
(5/5)99%
(353/356)49%
(169/344)src.client97%
(70/72)97%
(70/72)84%
(5601/6696)64%
(1486/2308)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server97%
(111/115)97%
(111/115)86%
(6726/7828)66%
(1890/2883)src.tools0%
(0/2)0%
(0/2)0%
(0/693)0%
(0/272)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/69)0%
(0/10)tests0%
(0/14)0%
(0/14)0%
(0/732)0%
(0/131)

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.10 - Build # 71 - Still Unstable!

2018-07-23 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/71/
 Project:
Frameworks kwayland kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 23 Jul 2018 08:55:41 +
 Build duration:
4 min 33 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 44 test(s), Skipped: 0 test(s), Total: 45 test(s)Failed: TestSuite.kwayland-testRemoteAccess
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)90%
(228/254)90%
(228/254)86%
(24012/27978)53%
(9538/18061)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client98%
(40/41)98%
(40/41)98%
(11248/11523)49%
(5991/12113)autotests.server100%
(5/5)100%
(5/5)99%
(353/356)49%
(169/344)src.client97%
(70/72)97%
(70/72)84%
(5604/6696)64%
(1488/2308)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server97%
(111/115)97%
(111/115)86%
(6726/7828)66%
(1890/2883)src.tools0%
(0/2)0%
(0/2)0%
(0/693)0%
(0/272)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/69)0%
(0/10)tests0%
(0/14)0%
(0/14)0%
(0/732)0%
(0/131)

D14175: Support cursor hints on locked pointer

2018-07-23 Thread Roman Gilg 
romangg edited the summary of this revision.
romangg edited the test plan for this revision.

REPOSITORY
  R127 KWayland

BRANCH
  cursorHints

REVISION DETAIL
  https://phabricator.kde.org/D14175

To: romangg, #plasma, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns