D14237: Make Konqi look good in HiDPI

ngraham edited the summary of this revision. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D14237 To: ngraham, broulik, cfeck, #frameworks Cc: aacid, bruns, kde-frameworks-devel, michaelh, ngraham

D14237: Make Konqi look good in HiDPI

ngraham updated this revision to Diff 38367. ngraham added a comment. Use `zopflipng` to squeeze the image down even smaller (thanks @bruns!) REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14237?vs=38106=38367 BRANCH hidpi-konqi (branched from master)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 179 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/179/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Wed, 25 Jul 2018 04:33:36 + Build duration: 7 min 15 sec and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 89 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/89/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Wed, 25 Jul 2018 04:33:36 + Build duration: 6 min 35 sec and counting JUnit Tests

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 332 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/332/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Wed, 25 Jul 2018 04:33:36 + Build duration: 6 min 55 sec and counting JUnit Tests Name:

D13773: [KDirOperator] Use alternating background colors for multi-column views

ngraham closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13773 To: ngraham, #frameworks, #vdg, #dolphin, abetts Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 178 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/178/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Wed, 25 Jul 2018 03:34:09 + Build duration: 21 min and counting JUnit Tests Name: (root)

D13773: [KDirOperator] Use alternating background colors for multi-column views

abetts accepted this revision. abetts added a comment. This revision is now accepted and ready to land. Looks good! REPOSITORY R241 KIO BRANCH alternating-row-colors-for-list-style-views (branched from master) REVISION DETAIL https://phabricator.kde.org/D13773 To: ngraham,

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 88 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/88/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Wed, 25 Jul 2018 03:34:09 + Build duration: 6 min 9 sec and counting JUnit Tests Name:

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 90 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/90/ Project: Frameworks purpose kf5-qt5 SUSEQt5.10 Date of build: Wed, 25 Jul 2018 03:34:35 + Build duration: 4 min 52 sec and counting JUnit Tests

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 331 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/331/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Wed, 25 Jul 2018 03:34:09 + Build duration: 5 min 2 sec and counting JUnit Tests Name:

D14118: Improve "Remove this [widget]" text

ngraham added a comment. Now that I look at my screenshots more closely, it seems weird to have: Configure Notes... Remove this Notes widget Now I feel like they should match, and be either: Configure Notes... Remove Notes or: Configure this Notes

D14118: Improve "Remove this [widget]" text

ngraham marked an inline comment as done. REPOSITORY R242 Plasma Framework (Library) BRANCH remove-this-widget (branched from master) REVISION DETAIL https://phabricator.kde.org/D14118 To: ngraham, #plasma, #vdg, gladhorn Cc: gladhorn, kde-frameworks-devel, michaelh, ngraham, bruns

D14118: Improve "Remove this [widget]" text

ngraham updated this revision to Diff 38365. ngraham added a comment. Use consistent casing REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14118?vs=37768=38365 BRANCH remove-this-widget (branched from master) REVISION DETAIL

D14237: Make Konqi look good in HiDPI

ngraham added a comment. Funny story: after multiple attempts to use Inkscape to make an SVG of this, all versions were much larger than the new png! I don't think that's an option. @broulik, does the current approach look sane to you? I wasn't able to make it work simply adding an `@2x`

D14345: Give the PlasmaComponents3 TextField the ability to have a Clear button

ngraham added a comment. Thanks for the history! Two questions: 1. Does this mean that PlasmaComponents is semi or fully deprecated or "legacy", and we should be porting Plasma stuff to Kirigami instead? 2. Since there's no Kirigami `TextField`, what do we do with this patch? Is there

D14345: Give the PlasmaComponents3 TextField the ability to have a Clear button

davidedmundson added a comment. Story time! First we had PlasmaComponents (based on some Nokia crap and some custom things from late Plasma4) Then came along Plasma 5 PC2 which was a continuation of above - Then QQC1 came along plasmastyle which was a

D14345: Give the PlasmaComponents3 TextField the ability to have a Clear button

ngraham added a comment. Oh. Maybe I don't know the history here. Why do we have PC2 and PC3 versions of this control, with the PC2 version using QQC1, and the PC3 version using QQC2, but not having all the features of the PC2 one? And why can't we change the PC3 version at all? REPOSITORY

D14345: Give the PlasmaComponents3 TextField the ability to have a Clear button

davidedmundson added a comment. > Hmm QQC2 not PC2 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D14345 To: ngraham, #plasma, mart, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14345: Give the PlasmaComponents3 TextField the ability to have a Clear button

ngraham added a comment. In D14345#297329 , @davidedmundson wrote: > PC3 was previously designed to be a drop in QQC2 implementation. There is currently no new API. > It /might/ have changed after we made plasmastyle instead. Check with

D14345: Give the PlasmaComponents3 TextField the ability to have a Clear button

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. PC3 was previously designed to be a drop in QQC2 implementation. There is currently no new API. It /might/ have changed after we made plasmastyle instead. Check

D14345: Give the PlasmaComponents3 TextField the ability to have a Clear button

ngraham edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D14345 To: ngraham, #plasma, mart, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14345: Give the PlasmaComponents3 TextField the ability to have a Clear button

ngraham edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D14345 To: ngraham, #plasma, mart, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14345: Give the PlasmaComponents3 TextField the ability to have a Clear button

ngraham created this revision. ngraham added reviewers: Plasma, mart, davidedmundson. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY The PlasmaComponents2

D14341: if an applet is invalid, it has immediately UiReadyConstraint

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY mirroring the behavior when the applet is created by

D14302: Don't block forever in ensureKdeinitRunning

thiago added inline comments. INLINE COMMENTS > kdeinitinterface.cpp:46 > QLockFile lock(QDir::tempPath() + QLatin1Char('/') + > QLatin1String("startkdeinitlock")); > -if (!lock.tryLock()) { > +if (!lock.tryLock(timeout)) { > lock.lock(); This line doesn't need changing.

D14302: Don't block forever in ensureKdeinitRunning

thiago added a comment. In D14302#297159 , @jtamate wrote: > (gdb) disass > Dump of assembler code for function _ZN9QLockFile7tryLockEi: > 0x7f54be8bc752 <+2>: mov$0x,%eax > ... > 0x7f54be8bc76d

D14302: Don't block forever in ensureKdeinitRunning

thiago added a comment. Quickly checking on openSUSE Tumbleweed In D14302#297185 , @lvsouza wrote: > I think I know what is happening. This line > > QDeadlineTimer timer(qMax(timeout, -1));// QDT only takes -1 as "forever" > >

D14302: Don't block forever in ensureKdeinitRunning

lvsouza added a comment. I think I know what is happening. This line QDeadlineTimer timer(qMax(timeout, -1));// QDT only takes -1 as "forever" passes the result of qMax() to QDeadlineTimer's constructor. That constructor receives a quint64. Since qMax() is a template:

D14302: Don't block forever in ensureKdeinitRunning

jtamate added a comment. (gdb) disass Dump of assembler code for function _ZN9QLockFile7tryLockEi: 0x7f54be8bc750 <+0>: push %r15 0x7f54be8bc752 <+2>: mov$0x,%eax 0x7f54be8bc757 <+7>: mov$0x1,%edx 0x7f54be8bc75c

D14302: Don't block forever in ensureKdeinitRunning

thiago added a comment. > timer = {t1 = 9223372036854775807, t2 = 0, type = 1} This is indeed Forever. How did it get there? I showed in my debug session that the QDeadlineTimer is passed zero, and then it does initialise properly. So I'm now beginning to question the compiler.

D14302: Don't block forever in ensureKdeinitRunning

jtamate added a comment. In D14302#297120 , @thiago wrote: > Can you print the contents of the timer object inside tryLock()? (gdb) info frame Stack level 2, frame at 0x7ffdda9967c0: rip = 0x7f54be8bc985 in

D14302: Don't block forever in ensureKdeinitRunning

thiago added a comment. Can you print the contents of the timer object inside tryLock()? REPOSITORY R271 KDBusAddons REVISION DETAIL https://phabricator.kde.org/D14302 To: jtamate, dfaure, #frameworks, thiago Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14302: Don't block forever in ensureKdeinitRunning

thiago added a comment. In D14302#296671 , @jtamate wrote: > Another hypothesis: > > QDeadlineTimer::QDeadlineTimer(qint64 msecs, Qt::TimerType type) Q_DECL_NOTHROW > : t2(0) > { > setRemainingTime(msecs, type); > }

D14308: [Exe Thumbnailer] Improve icon selection algorithm

bruns added inline comments. INLINE COMMENTS > icoutils_common.cpp:28 > +{ > +// compute difference of areas > +const qreal desiredAspectRatio = (desiredHeight > 0) ? desiredWidth / > static_cast(desiredHeight) : 0; Can not see an area calculation here ... > broulik wrote in

D14331: Avoid pixmap format test failure with serialising QIcons

davidedmundson created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY Test fails as converting an ARGB formatted pixmap with only RGB data

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.9 - Build # 45 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.9/45/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.9 Date of build: Tue, 24 Jul 2018 11:37:23 + Build duration: 12 min and counting JUnit Tests Name:

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.10 - Build # 72 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/72/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.10 Date of build: Tue, 24 Jul 2018 11:37:23 + Build duration: 7 min 10 sec and counting JUnit Tests

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 - Build # 34 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.10/34/ Project: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 24 Jul 2018 11:37:23 + Build duration: 5 min 50 sec and counting JUnit Tests

D14291: Cleanup RemoteAccess buffers on aboutToBeUnbound instead of object destruction

This revision was automatically updated to reflect the committed changes. Closed by commit R127:6aded9ccf603: Cleanup RemoteAccess buffers on aboutToBeUnbound instead of object destruction (authored by davidedmundson). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

D6513: Add support for Attica tags support

ahiemstra requested changes to this revision. ahiemstra added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > atticaprovider.cpp:283 > +} > +if(filterAcceptsDownloads && checker.filterAccepts(content.tags())) { > +

D6512: Add support for proposed tags addition in OCS 1.7

ahiemstra accepted this revision. This revision is now accepted and ready to land. REPOSITORY R235 Attica REVISION DETAIL https://phabricator.kde.org/D6512 To: leinir, #knewstuff, apol, whiting, #kde_store, ahiemstra Cc: ahiemstra, ngraham, kde-frameworks-devel, #kde_store, michaelh,

D6512: Add support for proposed tags addition in OCS 1.7

ahiemstra added a comment. Right, so leave it to application users how to deal with that, maybe later on add some convenience functions. Sounds sensible. :) REPOSITORY R235 Attica REVISION DETAIL https://phabricator.kde.org/D6512 To: leinir, #knewstuff, apol, whiting, #kde_store Cc:

D6512: Add support for proposed tags addition in OCS 1.7

leinir added a comment. In D6512#296329 , @ahiemstra wrote: > T6133 suggests that tags are formatted as "group##key=value" or something similar. Wouldn't it make sense to handle parsing that format here as

D14308: [Exe Thumbnailer] Improve icon selection algorithm

broulik updated this revision to Diff 38296. broulik added a comment. - Include `` just in case REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14308?vs=38271=38296 REVISION DETAIL https://phabricator.kde.org/D14308 AFFECTED FILES

D14308: [Exe Thumbnailer] Improve icon selection algorithm

broulik added a comment. > Sounds like we should put this in a Framework and re-use it instead of copy-pasting it here. It's a five line function, not gonna go through the hoops of finding a framework where this might fit.. INLINE COMMENTS > ngraham wrote in icoutils_common.cpp:33 >

D14302: Don't block forever in ensureKdeinitRunning

jtamate added a comment. Another hypothesis: QDeadlineTimer::QDeadlineTimer(qint64 msecs, Qt::TimerType type) Q_DECL_NOTHROW : t2(0) { setRemainingTime(msecs, type); } As t1 is not initialized and QDeadlineTimer::setPreciseRemainingTime only add to t1, it