D14449: Display used space in GiB also

[Shubham]

shubham added a comment.


  F6159605: Screenshot_20180729_112335.png 
: SS

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14449

To: shubham, elvisangelaccio, ngraham
Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D14449: Display used space in GiB also

[Dominik Haumann]

dhaumann added a comment.


  Can you add a screenshot?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14449

To: shubham, elvisangelaccio, ngraham
Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D14449: Display used space in GiB also

[Shubham]

shubham created this revision.
shubham added reviewers: elvisangelaccio, ngraham.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
shubham requested review of this revision.

REVISION SUMMARY
  BUG: 334263

TEST PLAN
  1. Goto properties
  2. Used space displayed in GiB also

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14449

AFFECTED FILES
  src/widgets/kpropertiesdialog.cpp

To: shubham, elvisangelaccio, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14237: Make Konqi look good in HiDPI

[Stefan Brüns]

bruns added a comment.


  In D14237#299794 , @ngraham wrote:
  
  >   sodipodi:absref="/home/sbruens/Downloads/aboutkde_doubled2.png"
  >   ...
  >   width="449.999" />
  >   
  
  
  Just delete the image element from the SVG and you should be good.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D14237

To: ngraham, broulik, cfeck, #frameworks
Cc: aacid, bruns, kde-frameworks-devel, michaelh, ngraham

D14237: Make Konqi look good in HiDPI

[Nathaniel Graham]

ngraham added a comment.


  Thanks! But where seems to be something wrong with that SVG. Qt complains 
when I try to load it into a `QPixmap`:
  
couldn't create image from  
"file:///home/sbruens/Downloads/aboutkde_doubled2.png"
  
  Looking inside the SVG file itself, I see the following:
  


REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D14237

To: ngraham, broulik, cfeck, #frameworks
Cc: aacid, bruns, kde-frameworks-devel, michaelh, ngraham

D13808: Fix KMainWindow saving incorrect widget settings

[Nathaniel Graham]

ngraham added a comment.


  In the Bugzilla ticket, it was mentioned that KMail (and only KMail)  still 
suffers from the issue even with this patch, so it might be a KMail-specific 
issue.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D13808

To: maxrd2, #kde_applications, dfaure, elvisangelaccio, broulik, cfeck
Cc: anthonyfieroni, marten, asturmlechner, wbauer, aacid, ngraham, 
kde-frameworks-devel, michaelh, bruns

D13808: Fix KMainWindow saving incorrect widget settings

[David Faure]

dfaure added a comment.


  Hmm, for me the bug is still there. Or maybe it means it's a different bug, 
but I kind of doubt it.
  
  Steps:
  
  1. I start kmail (with a cleaned up ~/.config/kmail2rc to make sure the 
StatusBar and the Toolbar are shown).
  2. I close it (Alt+F4 ).
  3. I start it again, it has no statusbar and no toolbar.
  
  Steps 1 and 2 alone lead to this in kmail2rc, section [Main Window]:
  MenuBar=Disabled  


  StatusBar=Disabled
  ToolBarsMovable=Disabled
  
  Any idea if this is related to this bug?
  I do have kxmlgui 5.48, with the presumed fix from this review request, of 
course.
  I think it means the fix isn't good enough?

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D13808

To: maxrd2, #kde_applications, dfaure, elvisangelaccio, broulik, cfeck
Cc: anthonyfieroni, marten, asturmlechner, wbauer, aacid, ngraham, 
kde-frameworks-devel, michaelh, bruns

D14447: Sonnet: setLanguage should schedule a rehighlight if highlight is enabled

[David Faure]

dfaure created this revision.
dfaure added reviewers: sandsmark, mlaurent.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  ... even if automatic enabling/disabling is off, as is the case in KMail.
  
  This will allow removing a direct call to rehighlight() in kpimtextedit
  which leads to the full highlighting being done twice (very slow on very
  large emails).

TEST PLAN
  Replying to a mail in kmail and watching how many times
  slotRehighlight is called. Well, this commit alone makes it worse,
  but after a fix in kpimtextedit, it's down from 2 to 1.

REPOSITORY
  R246 Sonnet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14447

AFFECTED FILES
  src/ui/highlighter.cpp

To: dfaure, sandsmark, mlaurent
Cc: kde-frameworks-devel, #kde_pim, michaelh, ngraham, bruns

D14435: Fix KTimeComboBox input mask for AM/PM times

[Glenn Watson]

glennw updated this revision to Diff 38685.
glennw added a comment.


  Added an autotest to ensure that the line edit mask is updated correctly.
  
  A couple of notes about the test results below:
  
  - I tried to set the current locale in the new test to ensure it reproduces. 
The setLocale() function is not reentrant, which should be fine unless tests 
are run in parallel?
  - There are other tests in this file that fail before my patch, and now pass 
afterwards. I guess they are probably passing in CI due to the CI locale 
setting?
  
  Test results before this patch:
  
* Start testing of KTimeComboBoxTest *
Config: Using QtTest library 5.9.5, Qt 5.9.5 (x86_64-little_endian-lp64 
shared (dynamic) release build; by GCC 7.3.0)
PASS   : KTimeComboBoxTest::initTestCase()
PASS   : KTimeComboBoxTest::_q_showIfNotHidden()
FAIL!  : KTimeComboBoxTest::testDefaults() Compared values are not the same
   Actual   (m_combo->time())  : 12:00:00.000
   Expected (QTime(0, 0, 0, 0)): 00:00:00.000
   Loc: [kde/kwidgetsaddons/autotests/ktimecomboboxtest.cpp(33)]
PASS   : KTimeComboBoxTest::testValidNull()
FAIL!  : KTimeComboBoxTest::testTimeRange() Compared values are not the same
   Actual   (m_combo->isValid()): 1
   Expected (false) : 0
   Loc: [kde/kwidgetsaddons/autotests/ktimecomboboxtest.cpp(69)]
PASS   : KTimeComboBoxTest::testTimeListInterval()
PASS   : KTimeComboBoxTest::testTimeList()
PASS   : KTimeComboBoxTest::testOptions()
PASS   : KTimeComboBoxTest::testDisplayFormat()
FAIL!  : KTimeComboBoxTest::testMask() Compared values are not the same
   Actual   (mask.contains(QLatin1String("aa"))): 0
   Expected (true)  : 1
   Loc: [kde/kwidgetsaddons/autotests/ktimecomboboxtest.cpp(198)]
PASS   : KTimeComboBoxTest::cleanupTestCase()
Totals: 8 passed, 3 failed, 0 skipped, 0 blacklisted, 71ms
* Finished testing of KTimeComboBoxTest *
  
  Test results after:
  
* Start testing of KTimeComboBoxTest *
Config: Using QtTest library 5.9.5, Qt 5.9.5 (x86_64-little_endian-lp64 
shared (dynamic) release build; by GCC 7.3.0)
PASS   : KTimeComboBoxTest::initTestCase()
PASS   : KTimeComboBoxTest::_q_showIfNotHidden()
PASS   : KTimeComboBoxTest::testDefaults()
PASS   : KTimeComboBoxTest::testValidNull()
PASS   : KTimeComboBoxTest::testTimeRange()
PASS   : KTimeComboBoxTest::testTimeListInterval()
PASS   : KTimeComboBoxTest::testTimeList()
PASS   : KTimeComboBoxTest::testOptions()
PASS   : KTimeComboBoxTest::testDisplayFormat()
PASS   : KTimeComboBoxTest::testMask()
PASS   : KTimeComboBoxTest::cleanupTestCase()
Totals: 11 passed, 0 failed, 0 skipped, 0 blacklisted, 69ms
* Finished testing of KTimeComboBoxTest *

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14435?vs=38638=38685

REVISION DETAIL
  https://phabricator.kde.org/D14435

AFFECTED FILES
  autotests/ktimecomboboxtest.cpp
  autotests/ktimecomboboxtest.h
  src/ktimecombobox.cpp

To: glennw, cfeck, mlaurent
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D12709: Allow skipping the build of the KPackage install handlers when building `frameworkintegration`

[Aleix Pol Gonzalez]

apol added a comment.


  Why would we want to make it optional?
  In fact, the only one that is mandatory is the KNS one.

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D12709

To: tundracomp
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D12674: Mark `Phonon4Qt5` dependency as optional in CMakeLists file

[Aleix Pol Gonzalez]

apol added a comment.


  You didn't specify for which repository this is.

REVISION DETAIL
  https://phabricator.kde.org/D12674

To: tundracomp
Cc: apol, ltoscano, cgiboudeaux, #frameworks, michaelh, ngraham, bruns

D13805: Present error dialog when user tries to create directory named "." or ".."

[Thomas Marshall]

tmarshall added a comment.


  In D13805#299580 , 
@elvisangelaccio wrote:
  
  > @tmarshall Do you have commit access?
  
  
  I do not.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13805

To: tmarshall, #dolphin, #frameworks, ngraham, dfaure, elvisangelaccio
Cc: cfeck, elvisangelaccio, dfaure, tmarshall, bruns, ngraham, 
kde-frameworks-devel, michaelh, spoorun, navarromorales, firef, andrebarros, 
emmanuelp

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 183 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/183/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 28 Jul 2018 17:18:33 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 58 test(s), Skipped: 0 test(s), Total: 59 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesviewtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)65%
(258/396)65%
(258/396)53%
(31908/59868)38%
(16107/42640)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(55/55)100%
(55/55)95%
(9006/9436)51%
(3921/7700)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core84%
(98/116)84%
(98/116)58%
(8330/14357)50%
(4649/9289)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3893/7900)34%
(1581/4655)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(527/1015)39%
(315/814)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1364)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/245)0%
(0/144)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1775/4320)35%
(1304/3700)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(628/1330)55%
(619/1123)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/257)7%
(14/212)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash56%
(5/9)56%
(5/9)51%
  

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 336 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/336/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 28 Jul 2018 17:18:33 +
 Build duration:
9 min 58 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 58 test(s), Skipped: 0 test(s), Total: 59 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesviewtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)65%
(258/396)65%
(258/396)53%
(31849/59867)38%
(16086/42642)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(55/55)100%
(55/55)95%
(9006/9436)51%
(3922/7700)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core84%
(98/116)84%
(98/116)58%
(8271/14356)50%
(4626/9285)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3892/7900)34%
(1580/4655)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(527/1015)39%
(315/814)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1364)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/245)0%
(0/144)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1775/4320)35%
(1304/3700)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(629/1330)55%
(620/1123)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/257)7%
(14/212)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash56%
(5/9)56%

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 93 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/93/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.10
 Date of build:
Sat, 28 Jul 2018 17:18:33 +
 Build duration:
8 min 3 sec and counting
   JUnit Tests
  Name: (root) Failed: 5 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiofilewidgets-kfileplacesviewtestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

D13805: Present error dialog when user tries to create directory named "." or ".."

[Elvis Angelaccio]

elvisangelaccio added a comment.


  @tmarshall Do you have commit access?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13805

To: tmarshall, #dolphin, #frameworks, ngraham, dfaure, elvisangelaccio
Cc: cfeck, elvisangelaccio, dfaure, tmarshall, bruns, ngraham, 
kde-frameworks-devel, michaelh, spoorun, navarromorales, firef, andrebarros, 
emmanuelp

D13805: Present error dialog when user tries to create directory named "." or ".."

[Elvis Angelaccio]

elvisangelaccio accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13805

To: tmarshall, #dolphin, #frameworks, ngraham, dfaure, elvisangelaccio
Cc: cfeck, elvisangelaccio, dfaure, tmarshall, bruns, ngraham, 
kde-frameworks-devel, michaelh, spoorun, navarromorales, firef, andrebarros, 
emmanuelp

D14290: [KWidgetJobTracker] Show "Open Destination" etc buttons only if destination is valid

[Elvis Angelaccio]

elvisangelaccio added a comment.


  +1

REPOSITORY
  R288 KJobWidgets

REVISION DETAIL
  https://phabricator.kde.org/D14290

To: broulik, dfaure
Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 92 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/92/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.10
 Date of build:
Sat, 28 Jul 2018 15:13:58 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiofilewidgets-kfileplacesviewtestFailed: TestSuite.kiofilewidgets-kfilewidgettestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

KDE CI: Frameworks kservice kf5-qt5 FreeBSDQt5.10 - Build # 15 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20FreeBSDQt5.10/15/
 Project:
Frameworks kservice kf5-qt5 FreeBSDQt5.10
 Date of build:
Sat, 28 Jul 2018 15:22:43 +
 Build duration:
1 min 29 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 10 test(s)Failed: TestSuite.kmimeassociationstest

KDE CI: Frameworks kservice kf5-qt5 SUSEQt5.10 - Build # 40 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20SUSEQt5.10/40/
 Project:
Frameworks kservice kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 28 Jul 2018 15:22:43 +
 Build duration:
1 min 52 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.kplugininfotestFailed: TestSuite.kservicetestFailed: TestSuite.ksycocathreadtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report75%
(6/8)82%
(68/83)82%
(68/83)68%
(5505/8094)48%
(2730/5714)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests92%
(11/12)92%
(11/12)84%
(1316/1563)44%
(625/1414)src.kbuildsycoca100%
(1/1)100%
(1/1)92%
(54/59)68%
(15/22)src.kdeinit0%
(0/2)0%
(0/2)0%
(0/333)0%
(0/241)src.plugin67%
(2/3)67%
(2/3)46%
(40/87)41%
(31/76)src.services97%
(28/29)97%
(28/29)61%
(1869/3047)42%
(790/1884)src.sycoca83%
(24/29)83%
(24/29)77%
(2121/2772)62%
(1236/1989)tests0%
(0/5)0%
(0/5)0%
(0/118)0%
(0/40)tests.pluginlocator100%
(2/2)100%
(2/2)91%
(105/115)69%
(33/48)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 182 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/182/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 28 Jul 2018 15:13:58 +
 Build duration:
10 min and counting
   CONSOLE OUTPUT
  [...truncated 437.94 KB...][ 50%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/kurifilter.cpp.o[ 50%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/dropjob.cpp.o[ 50%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/openfilemanagerwindowjob.cpp.o/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.9/src/widgets/kurlcompletion.cpp: In member function ‘virtual void UserListThread::run()’:/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.9/src/widgets/kurlcompletion.cpp:284:105: note: #pragma message: TODO: add KUser::allUserNames() with a std::function shouldTerminate parameter #pragma message("TODO: add KUser::allUserNames() with a std::function shouldTerminate parameter") ^[ 51%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/pastejob.cpp.o[ 51%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/previewjob.cpp.o/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.9/src/widgets/openfilemanagerwindowjob.cpp: In member function ‘virtual void KIO::OpenFileManagerWindowKRunStrategy::start(const QList&, const QByteArray&)’:/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.9/src/widgets/openfilemanagerwindowjob.cpp:150:26: warning: ‘static bool KRun::runUrl(const QUrl&, const QString&, QWidget*, bool, bool, const QString&, const QByteArray&)’ is deprecated [-Wdeprecated-declarations]   asn)) {  ^In file included from /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.9/build/src/widgets/KRun:1, from /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.9/src/widgets/openfilemanagerwindowjob.cpp:30:/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.9/src/widgets/krun.h:302:39: note: declared here static bool KIOWIDGETS_DEPRECATED runUrl(const QUrl , const QString , QWidget *window,   ^~/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.9/src/widgets/openfilemanagerwindowjob.cpp:150:26: warning: ‘static bool KRun::runUrl(const QUrl&, const QString&, QWidget*, bool, bool, const QString&, const QByteArray&)’ is deprecated [-Wdeprecated-declarations]   asn)) {  ^In file included from /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.9/build/src/widgets/KRun:1, from /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.9/src/widgets/openfilemanagerwindowjob.cpp:30:/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.9/src/widgets/krun.h:302:39: note: declared here static bool KIOWIDGETS_DEPRECATED runUrl(const QUrl , const QString , QWidget *window,   ^~/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.9/src/widgets/previewjob.cpp:27:5: warning: this use of "defined" may not be portable [-Wexpansion-to-defined] #if WITH_SHM ^~~~/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.9/src/widgets/previewjob.cpp:27:5: warning: this use of "defined" may not be portable [-Wexpansion-to-defined]/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.9/src/widgets/previewjob.cpp:199:5: warning: this use of "defined" may not be portable [-Wexpansion-to-defined] #if WITH_SHM ^~~~/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.9/src/widgets/previewjob.cpp:199:5: warning: this use of "defined" may not be portable [-Wexpansion-to-defined]/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.9/src/widgets/previewjob.cpp:645:5: warning: this use of "defined" may not be portable [-Wexpansion-to-defined] #if WITH_SHM ^~~~/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.9/src/widgets/previewjob.cpp:645:5: warning: this use of "defined" may not be portable [-Wexpansion-to-defined]/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.9/src/widgets/previewjob.cpp:677:5: warning: this use of "defined" may not be portable [-Wexpansion-to-defined] #if WITH_SHM ^~~~/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.9/src/widgets/previewjob.cpp:677:5: warning: this use of "defined" may not be portable [-Wexpansion-to-defined][ 51%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/renamedialog.cpp.o[ 51%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/ksslcertificatebox.cpp.o[ 51%] Building CXX object src/widgets/CMakeFiles/KF5KIOWidgets.dir/kdynamicjobtracker.cpp.o/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.9/src/widgets/previewjob.cpp: In function ‘KIO::PreviewJob* KIO::filePreview(const KFileItemList&, int, int, int, int, bool, bool, const 

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 335 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/335/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 28 Jul 2018 15:13:58 +
 Build duration:
5 min 55 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 58 test(s), Skipped: 0 test(s), Total: 59 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesviewtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)65%
(258/396)65%
(258/396)53%
(31865/59867)38%
(16093/42642)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(55/55)100%
(55/55)95%
(9003/9435)51%
(3923/7700)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core84%
(98/116)84%
(98/116)58%
(8290/14357)50%
(4632/9285)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3892/7900)34%
(1580/4655)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(527/1015)39%
(315/814)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1364)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/245)0%
(0/144)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1775/4320)35%
(1304/3700)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(629/1330)55%
(620/1123)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/257)7%
(14/212)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash56%
(5/9)56%

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 - Build # 42 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.9/42/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 28 Jul 2018 14:20:18 +
 Build duration:
3 min 48 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(69/81)85%
(69/81)75%
(6311/8408)43%
(10100/23341)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2685/2761)49%
(5767/11835)src.desktoptojson100%
(2/2)100%
(2/2)78%
(88/113)38%
(122/322)src.lib50%
(1/2)50%
(1/2)62%
(352/572)26%
(243/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/782)18%
(184/1038)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1049/2827)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(652/767)42%
(968/2303)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)47%
(368/778)44%
(845/1899)src.lib.util100%
(10/10)100%
(10/10)81%
(731/908)52%
(826/1581)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.10 - Build # 20 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.10/20/
 Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.10
 Date of build:
Sat, 28 Jul 2018 14:20:18 +
 Build duration:
3 min 41 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 20 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_qfswatch_unittestFailed: TestSuite.kdirwatch_stat_unittest

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 97 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/97/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 28 Jul 2018 14:20:18 +
 Build duration:
3 min 17 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittestFailed: TestSuite.kdirwatch_stat_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(69/81)85%
(69/81)75%
(6312/8408)43%
(10110/23345)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2687/2761)49%
(5776/11833)src.desktoptojson100%
(2/2)100%
(2/2)78%
(88/113)38%
(123/326)src.lib50%
(1/2)50%
(1/2)61%
(351/572)26%
(243/928)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/782)18%
(184/1038)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1047/2821)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(652/767)42%
(968/2305)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)47%
(368/778)45%
(846/1899)src.lib.util100%
(10/10)100%
(10/10)81%
(731/908)52%
(827/1583)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

D14435: Fix KTimeComboBox input mask for AM/PM times

[Laurent Montel]

mlaurent requested changes to this revision.
mlaurent added a comment.
This revision now requires changes to proceed.


  could you provide an autotest for it please ?
  (see autotest/ktimecomboboxtest.cpp)
  Thanks

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D14435

To: glennw, cfeck, mlaurent
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14435: Fix KTimeComboBox input mask for AM/PM times

[Glenn Watson]

glennw added reviewers: cfeck, mlaurent.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D14435

To: glennw, cfeck, mlaurent
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D6513: Add support for Attica tags support

[Arjen Hiemstra]

ahiemstra accepted this revision.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D6513

To: leinir, #knewstuff, apol, #kde_store, whiting, ahiemstra, mlaurent
Cc: mlaurent, ngraham, ahiemstra, kde-frameworks-devel, #knewstuff, michaelh, 
ZrenBot, bruns

D14435: Fix KTimeComboBox input mask for AM/PM times

[Glenn Watson]

glennw created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
glennw requested review of this revision.

REVISION SUMMARY
  In some cases, the strings returned from amText() and
  pmText() may differ in case to the provided format
  in the timeFormatToInputMask method.
  
  This results in an incorrect mask string being provided
  to the line edit control.
  
  Instead, detect if the format string uses upper or lower
  case for the AM/PM specification, and use this to convert
  the am/pm text strings to a consistent case.
  
  BUG: 361764

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D14435

AFFECTED FILES
  src/ktimecombobox.cpp

To: glennw
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14397: Support libcanberra for audio notification

[René J . V . Bertin]

rjvbb added a comment.


  [I didn't get to send this yesterday]
  
  >   Not using something because it's from a "rival GUI" is not a valid 
argument.
  
  It is IMVHO if "it" introduces a dependency on another GUI middleware. 
Libcanberra does that to the best of my knowledge.
  
  > Canberra over GStreamer works there as well.
  
  Only if you accept dependencies that shouldn't be required if you want to 
keep things as native as possible. The fact that a plasma project already uses 
libcanberra shouldn't be used as an argument for using it in a *framework*. 
Plasma is exclusive to non-Apple Unix (and in fact almost to Linux), and it's 
probably irrealistic to think that one could construct a completely GTk-free 
distribution on such systems (= the library will probably be there anyway).
  KNotifications is a Tier1 framework with a cross-platform vocation. For me 
that means that a solution with QtMultimedia should be preferred if anyway 
possible. Regardless what that component depends on itself... (Alexey beat me 
to it I see :))
  
  NB: I'm not talking about glib. That's a platform-agnostic support library 
that Qt uses even on Mac (I don't know about MSWin).
  
  > You could shove coreaudio or quicktime behind it if you wanted.
  
  *That* would be reinventing the wheel. Why would you want to do that in a 
Qt-based universe if Qt already has a component where this has been done?
  Quicktime is dead, btw.
  
  > That's not true.
  
  It is if you leave my remark in its (generic) context... And sound latencies 
can hardly be avoided with a 100% guarantee with asynchronous playback over an 
independent daemon process.
  
  > I restored the Phonon option for when canberra isn't available on the 
platform.
  
  I haven't checked, but I'd appreciate if that could also be done through a 
cmake option. In packaging systems like MacPorts and HB it's perfectly possible 
to have libcanberra and/or pulseaudio installed for Gnome apps that cannot do 
without them, but still not want to let other software use them (opportunistic 
dependencies). Alternatively, CMake has a DISABLE* backdoor for the basic 
`find_package()`, not very elegant but maybe it can do the trick?

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D14397

To: broulik, #frameworks, dfaure, davidedmundson, sitter, drosca, kfunk, rjvbb
Cc: alexeymin, ngraham, nicolasfella, kde-frameworks-devel, michaelh, bruns

D14360: Remove custom icon selection for trash

[Shubham]

shubham removed a reviewer: dfaure.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14360

To: shubham, ngraham, broulik, #dolphin, #frameworks, pino, dfaure
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D14360: Remove custom icon selection for trash

[Shubham]

shubham updated this revision to Diff 38637.
shubham added a comment.


  Add getter for icon's editability

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14360?vs=38633=38637

REVISION DETAIL
  https://phabricator.kde.org/D14360

AFFECTED FILES
  src/filewidgets/kfileplaceeditdialog.cpp
  src/filewidgets/kfileplaceeditdialog.h

To: shubham, ngraham, broulik, #dolphin, #frameworks, dfaure, pino
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D14360: Remove custom icon selection for trash

[Shubham]

shubham added a comment.


  okay, then it's fine

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14360

To: shubham, ngraham, broulik, #dolphin, #frameworks, dfaure, pino
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D14360: Remove custom icon selection for trash

[Pino Toscano]

pino added a comment.


  In D14360#299443 , @shubham wrote:
  
  > pino: suppose this function is created(canEditIcon()),then this function 
must  also be called when we are creating the m_iconButton at line 123 so as to 
generalize it's creation ( as you had said to take into account other entries 
also if they are also to be excluded).
  
  
  The function I suggested shows to the external users of 
`KFilePlaceEditDialog` (which is only the static 
`KFilePlaceEditDialog::getInformation()`) whether the icon could be edited or 
not.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14360

To: shubham, ngraham, broulik, #dolphin, #frameworks, dfaure, pino
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D14360: Remove custom icon selection for trash

[Shubham]

shubham added a comment.


  pino: suppose this function is created(canEditIcon()),then this function must 
 also be called when we are creating the m_iconButton at line 123 so as to 
generalize it's creation ( as you had said to take into account other entries 
also if they are also to be excluded).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14360

To: shubham, ngraham, broulik, #dolphin, #frameworks, dfaure, pino
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns