D14530: Fix crash when save a QImage to the eps format file

[ZC]

zccrs added a comment.


  In D14530#301690 , @dfaure wrote:
  
  > I don't see much point in this patch, Qt already tells you that a 
QCoreApplication is missing (as you can see in the bug report). You have to 
create a QCoreApplication in any Qt process, that's a fact, we're not going to 
remind the developer before each and every use of a Qt class.
  
  
  Hi, I was replied in https://bugs.kde.org/show_bug.cgi?id=397040. I hope to 
get a reply.

REPOSITORY
  R287 KImageFormats

REVISION DETAIL
  https://phabricator.kde.org/D14530

To: zccrs, mlaurent, kossebau, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14661: Force reevaluation of Predicates if interfaces are removed

[Stefan Brüns]

bruns added a comment.


  This is an alternative to D13869 

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D14661

To: bruns, #frameworks, broulik, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14661: Force reevaluation of Predicates if interfaces are removed

[Stefan Brüns]

bruns edited the test plan for this revision.
bruns added reviewers: Frameworks, broulik, ngraham.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D14661

To: bruns, #frameworks, broulik, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14663: Give the "invalid directory name" dialog a cancel button

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14663

To: ngraham, #vdg, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14640: Use appropriate icon for a cancel button that will ask for a new name

[Nathaniel Graham]

ngraham added a comment.


  In D14640#304429 , @abetts wrote:
  
  > In D14640#304428 , @ngraham 
wrote:
  >
  > > In D14640#304405 , @abetts 
wrote:
  > >
  > > > In D14640#304400 , @ngraham 
wrote:
  > > >
  > > > > Hmm, I'm not sure a cancel button makes sense here because that would 
end the process of creating the folder. If you chose an invalid name, 
presumably you still want to create the folder.
  > > >
  > > >
  > > > I am mostly trying to think of unintended actions upon unintended 
actions. Thinking maybe that a less knowledgeable user just took the wrong path 
in trying to complete an action.
  > >
  > >
  > > Now that I think about it, you're right. I'll submit a patch for that 
once my current crop of patches are accepted and landed. Wanna accept this one?
  >
  >
  > Yes, no problem! Thanks for taking my suggestion.
  
  
  See D14663: Give the "invalid directory name" dialog a cancel button 


REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14640

To: ngraham, #frameworks, #vdg, abetts
Cc: abetts, broulik, dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D14663: Give the "invalid directory name" dialog a cancel button

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14663

To: ngraham, #vdg, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 109 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/109/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.10
 Date of build:
Mon, 06 Aug 2018 22:49:49 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: (root) Failed: 5 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiofilewidgets-kfileplacesviewtestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

D14663: Give the "invalid directory name" dialog a cancel button

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Frameworks.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Adds a cancel button to the "Invalid Directory Name" dialog.

TEST PLAN
  - Try to create a new folder named "." or "..
  - In the resulting dialog, click Enter a DIfferent Name -> you are prompted 
to choose a new name
  - Enter "." or ".." again
  - In the resulting dialog, click Cancel -> dialog disappears
  - Do the above, but enter a valid name when prompted -> the folder is created 
using the valid name

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14663

AFFECTED FILES
  src/filewidgets/knewfilemenu.cpp

To: ngraham, #vdg, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 199 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/199/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 06 Aug 2018 22:39:38 +
 Build duration:
20 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 58 test(s), Skipped: 0 test(s), Total: 59 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesviewtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)65%
(258/396)65%
(258/396)53%
(31964/59914)38%
(16146/42676)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(55/55)100%
(55/55)95%
(9025/9455)51%
(3927/7716)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core84%
(98/116)84%
(98/116)58%
(8352/14358)50%
(4661/9289)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3894/7926)34%
(1586/4669)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(527/1015)39%
(315/814)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1364)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/245)0%
(0/144)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4320)35%
(1306/3700)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(629/1331)55%
(619/1123)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/257)7%
(14/212)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash56%
(5/9)56%
(5/9)52%
  

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 - Build # 200 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.10/200/
 Project:
Frameworks kio kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Mon, 06 Aug 2018 22:39:38 +
 Build duration:
10 min and counting

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 108 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/108/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.10
 Date of build:
Mon, 06 Aug 2018 22:30:48 +
 Build duration:
18 min and counting
   JUnit Tests
  Name: (root) Failed: 5 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiofilewidgets-kfileplacesviewtestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 354 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/354/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 06 Aug 2018 22:41:46 +
 Build duration:
6 min 17 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 58 test(s), Skipped: 0 test(s), Total: 59 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesviewtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)65%
(258/396)65%
(258/396)53%
(31886/59913)38%
(16110/42678)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(55/55)100%
(55/55)95%
(9025/9455)51%
(3929/7716)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core84%
(98/116)84%
(98/116)58%
(8285/14357)50%
(4633/9285)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3893/7926)34%
(1585/4669)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(527/1015)39%
(315/814)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1364)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/245)0%
(0/144)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1775/4320)35%
(1304/3700)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1331)55%
(620/1123)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/257)7%
(14/212)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash56%
(5/9)56%

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 353 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/353/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 06 Aug 2018 22:30:48 +
 Build duration:
10 min and counting
   CONSOLE OUTPUT
  [...truncated 662.29 KB...][ 77%] Generating ui_useragentselectordlg.h[ 77%] Generating ui_useragentdlg.h[ 77%] Generating ui_kproxydlg.h[ 78%] Generating ui_kcookiespolicies.h[ 78%] Generating ui_kcookiesmanagement.hScanning dependencies of target kcm_kio[ 78%] Building CXX object src/kcms/kio/CMakeFiles/kcm_kio.dir/main.cpp.o/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.10/src/filewidgets/knewfilemenu.cpp: In member function ‘void KNewFileMenuPrivate::confirmCreatingHiddenDir(const QString&)’:/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.10/src/filewidgets/knewfilemenu.cpp:416:1: error: version control conflict marker in file <<< 748a65599dd9818e683f7802ef7f0c8198f000de ^~~/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.10/src/filewidgets/knewfilemenu.cpp:416:3: error: expected primary-_expression_ before ‘<<’ token <<< 748a65599dd9818e683f7802ef7f0c8198f000de   ^~/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.10/src/filewidgets/knewfilemenu.cpp:416:5: error: expected primary-_expression_ before ‘<<’ token <<< 748a65599dd9818e683f7802ef7f0c8198f000de ^~/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.10/src/filewidgets/knewfilemenu.cpp:416:7: error: expected primary-_expression_ before ‘<’ token <<< 748a65599dd9818e683f7802ef7f0c8198f000de   ^/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.10/src/filewidgets/knewfilemenu.cpp:416:9: error: unable to find numeric literal operator ‘operator""a65599dd9818e683f7802ef7f0c8198f000de’ <<< 748a65599dd9818e683f7802ef7f0c8198f000de ^~~~/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.10/src/filewidgets/knewfilemenu.cpp:418:1: error: version control conflict marker in file === ^~~/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.10/src/filewidgets/knewfilemenu.cpp:418:3: error: expected primary-_expression_ before ‘==’ token ===   ^~/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.10/src/filewidgets/knewfilemenu.cpp:418:5: error: expected primary-_expression_ before ‘==’ token === ^~/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.10/src/filewidgets/knewfilemenu.cpp:418:7: error: expected primary-_expression_ before ‘=’ token ===   ^/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.10/src/filewidgets/knewfilemenu.cpp:421:1: error: version control conflict marker in file >>> Use appropriate icon for a cancel button that will ask for a new name ^~~/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.10/src/filewidgets/knewfilemenu.cpp:421:3: error: expected primary-_expression_ before ‘>>’ token >>> Use appropriate icon for a cancel button that will ask for a new name   ^~/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.10/src/filewidgets/knewfilemenu.cpp:421:5: error: expected primary-_expression_ before ‘>>’ token >>> Use appropriate icon for a cancel button that will ask for a new name ^~/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.10/src/filewidgets/knewfilemenu.cpp:421:7: error: expected primary-_expression_ before ‘>’ token >>> Use appropriate icon for a cancel button that will ask for a new name   ^/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.10/src/filewidgets/knewfilemenu.cpp:421:9: error: ‘Use’ was not declared in this scope >>> Use appropriate icon for a cancel button that will ask for a new name ^~~/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.10/src/filewidgets/knewfilemenu.cpp:424:5: error: ‘confirmDialog’ was not declared in this scope confirmDialog->setWindowTitle(i18n("Create hidden directory?")); ^/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.10/src/filewidgets/knewfilemenu.cpp:424:5: note: suggested alternative: ‘m_fileDialog’ confirmDialog->setWindowTitle(i18n("Create hidden directory?")); ^ m_fileDialogScanning dependencies of target fixhosturifilter[ 79%] Building CXX object src/urifilters/fixhost/CMakeFiles/fixhosturifilter.dir/fixhosturifilter.cpp.omake[2]: *** [src/filewidgets/CMakeFiles/KF5KIOFileWidgets.dir/build.make:363: src/filewidgets/CMakeFiles/KF5KIOFileWidgets.dir/knewfilemenu.cpp.o] Error 1make[1]: *** [CMakeFiles/Makefile2:3681: src/filewidgets/CMakeFiles/KF5KIOFileWidgets.dir/all] Error 2make[1]: *** Waiting for unfinished jobsScanning dependencies of target kshorturifilter[ 79%] Building CXX object src/urifilters/fixhost/CMakeFiles/fixhosturifilter.dir/fixhosturifilter_autogen/mocs_compilation.cpp.o[ 79%] Building CXX object src/urifilters/shorturi/CMakeFiles/kshorturifilter.dir/kshorturifilter.cpp.o[ 79%] Building CXX object 

D14572: Check the build directory for po/ as well

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R249:64796250e69d: Check the build directory for po/ as well 
(authored by apol).

REPOSITORY
  R249 KI18n

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14572?vs=39196=39233

REVISION DETAIL
  https://phabricator.kde.org/D14572

AFFECTED FILES
  cmake/KF5I18nMacros.cmake.in

To: apol, #frameworks, ltoscano, dfaure
Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 - Build # 199 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.10/199/
 Project:
Frameworks kio kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Mon, 06 Aug 2018 22:30:48 +
 Build duration:
6 min 5 sec and counting
   CONSOLE OUTPUT
  [...truncated 606.17 KB...][ 59%] Built target favicontest[ 60%] Generating qrc_templates.cppScanning dependencies of target KF5KIOFileWidgets[ 60%] Building CXX object src/filewidgets/CMakeFiles/KF5KIOFileWidgets.dir/kstatusbarofflineindicator.cpp.obj[ 60%] Building CXX object src/filewidgets/CMakeFiles/KF5KIOFileWidgets.dir/kfilemetapreview.cpp.obj[ 60%] Building CXX object src/filewidgets/CMakeFiles/KF5KIOFileWidgets.dir/kimagefilepreview.cpp.obj[ 60%] Building CXX object src/filewidgets/CMakeFiles/KF5KIOFileWidgets.dir/kpreviewwidgetbase.cpp.obj[ 61%] Building CXX object src/filewidgets/CMakeFiles/KF5KIOFileWidgets.dir/krecentdirs.cpp.obj[ 61%] Building CXX object src/filewidgets/CMakeFiles/KF5KIOFileWidgets.dir/kdiroperator.cpp.obj[ 61%] Building CXX object src/filewidgets/CMakeFiles/KF5KIOFileWidgets.dir/defaultviewadapter.cpp.obj[ 61%] Building CXX object src/filewidgets/CMakeFiles/KF5KIOFileWidgets.dir/kdiroperatordetailview.cpp.obj[ 61%] Building CXX object src/filewidgets/CMakeFiles/KF5KIOFileWidgets.dir/kdirsortfilterproxymodel.cpp.obj[ 61%] Building CXX object src/filewidgets/CMakeFiles/KF5KIOFileWidgets.dir/kencodingfiledialog.cpp.obj[ 61%] Building CXX object src/filewidgets/CMakeFiles/KF5KIOFileWidgets.dir/kfilebookmarkhandler.cpp.obj[ 61%] Building CXX object src/filewidgets/CMakeFiles/KF5KIOFileWidgets.dir/kfilecopytomenu.cpp.objkstatusbarofflineindicator.cppkrecentdirs.cpp[ 61%] Building CXX object src/filewidgets/CMakeFiles/KF5KIOFileWidgets.dir/kfilecustomdialog.cpp.objkpreviewwidgetbase.cpp[ 62%] Building CXX object src/filewidgets/CMakeFiles/KF5KIOFileWidgets.dir/kfilefiltercombo.cpp.objkfilemetapreview.cppkimagefilepreview.cppkfilefiltercombo.cppkfilecustomdialog.cppdefaultviewadapter.cppkdiroperator.cppkdiroperatordetailview.cppkdirsortfilterproxymodel.cppkencodingfiledialog.cppkfilebookmarkhandler.cppkfilecopytomenu.cpp[ 62%] Building CXX object src/filewidgets/CMakeFiles/KF5KIOFileWidgets.dir/kfilewidget.cpp.objkfilewidget.cpp[ 62%] Building CXX object src/filewidgets/CMakeFiles/KF5KIOFileWidgets.dir/kfilewidgetdocktitlebar.cpp.objkfilewidgetdocktitlebar.cpp[ 62%] Building CXX object src/filewidgets/CMakeFiles/KF5KIOFileWidgets.dir/kfileplacesitem.cpp.objkfileplacesitem.cpp[ 62%] Building CXX object src/filewidgets/CMakeFiles/KF5KIOFileWidgets.dir/kfileplacesmodel.cpp.objkfileplacesmodel.cpp[ 62%] Building CXX object src/filewidgets/CMakeFiles/KF5KIOFileWidgets.dir/kfileplacesview.cpp.objkfileplacesview.cpp[ 62%] Building CXX object src/filewidgets/CMakeFiles/KF5KIOFileWidgets.dir/kfileplaceeditdialog.cpp.objkfileplaceeditdialog.cpp[ 63%] Building CXX object src/filewidgets/CMakeFiles/KF5KIOFileWidgets.dir/kfilepreviewgenerator.cpp.objkfilepreviewgenerator.cpp[ 63%] Building CXX object src/filewidgets/CMakeFiles/KF5KIOFileWidgets.dir/knameandurlinputdialog.cpp.objknameandurlinputdialog.cpp[ 63%] Building CXX object src/filewidgets/CMakeFiles/KF5KIOFileWidgets.dir/knewfilemenu.cpp.objknewfilemenu.cpp[ 63%] Building CXX object src/filewidgets/CMakeFiles/KF5KIOFileWidgets.dir/kurlnavigatordropdownbutton.cpp.objkurlnavigatordropdownbutton.cpp[ 63%] Building CXX object src/filewidgets/CMakeFiles/KF5KIOFileWidgets.dir/kurlnavigatorbuttonbase.cpp.objkurlnavigatorbuttonbase.cpp[ 63%] Building CXX object src/filewidgets/CMakeFiles/KF5KIOFileWidgets.dir/kurlnavigatorbutton.cpp.objkurlnavigatorbutton.cpp[ 63%] Building CXX object src/filewidgets/CMakeFiles/KF5KIOFileWidgets.dir/kurlnavigatorplacesselector.cpp.objkurlnavigatorplacesselector.cpp[ 64%] Building CXX object src/filewidgets/CMakeFiles/KF5KIOFileWidgets.dir/kurlnavigatorprotocolcombo.cpp.objQT5 PORTkurlnavigatorprotocolcombo.cpp[ 64%] Building CXX object src/filewidgets/CMakeFiles/KF5KIOFileWidgets.dir/kurlnavigatortogglebutton.cpp.obj[ 64%] Building CXX object src/filewidgets/CMakeFiles/KF5KIOFileWidgets.dir/kurlnavigator.cpp.objkurlnavigatortogglebutton.cppCannot use XRender with QPixmap anymore. Find equivalent with Qt API.kurlnavigator.cpp[ 64%] Building CXX object src/filewidgets/CMakeFiles/KF5KIOFileWidgets.dir/kurlnavigatormenu.cpp.objC:\CI\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.10\src\filewidgets\knewfilemenu.cpp(416): error C2059: syntax error: '<<'C:\CI\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.10\src\filewidgets\knewfilemenu.cpp(418): error C2059: syntax error: '=='C:\CI\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.10\src\filewidgets\knewfilemenu.cpp(421): error C2059: syntax error: '>>'C:\CI\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.10\src\filewidgets\knewfilemenu.cpp(424): error C2065: 'confirmDialog': undeclared identifierC:\CI\workspace\Frameworks kio kf5-qt5 

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 198 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/198/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 06 Aug 2018 22:30:48 +
 Build duration:
2 min 28 sec and counting
   CONSOLE OUTPUT
  [...truncated 676.92 KB...]/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.9/src/widgets/paste.h:46:35: note: declared here KIOWIDGETS_DEPRECATED_EXPORT Job *pasteClipboard(const QUrl , QWidget *widget, bool move = false);   ^~[ 82%] Built target kdynamicjobtrackernowidgetstest[ 82%] Building CXX object src/filewidgets/CMakeFiles/KF5KIOFileWidgets.dir/krecentdirs.cpp.o[ 82%] Built target kfileitemactionstest[ 83%] Building CXX object src/filewidgets/CMakeFiles/KF5KIOFileWidgets.dir/defaultviewadapter.cpp.o[ 83%] Building CXX object src/filewidgets/CMakeFiles/KF5KIOFileWidgets.dir/kdiroperator.cpp.o[ 83%] Linking CXX executable ../bin/accessmanagertest[ 83%] Linking CXX executable ../bin/jobguitest[ 83%] Building CXX object src/filewidgets/CMakeFiles/KF5KIOFileWidgets.dir/kdiroperatordetailview.cpp.o[ 83%] Building CXX object src/filewidgets/CMakeFiles/KF5KIOFileWidgets.dir/kdirsortfilterproxymodel.cpp.o[ 83%] Built target accessmanagertest[ 83%] Linking CXX executable ../bin/dropjobtest[ 83%] Building CXX object src/filewidgets/CMakeFiles/KF5KIOFileWidgets.dir/kencodingfiledialog.cpp.o[ 83%] Built target jobguitest[ 83%] Building CXX object src/filewidgets/CMakeFiles/KF5KIOFileWidgets.dir/kfilebookmarkhandler.cpp.o[ 83%] Building CXX object src/filewidgets/CMakeFiles/KF5KIOFileWidgets.dir/kfilecopytomenu.cpp.o[ 83%] Building CXX object src/filewidgets/CMakeFiles/KF5KIOFileWidgets.dir/kfilecustomdialog.cpp.o[ 83%] Built target dropjobtest[ 84%] Building CXX object src/filewidgets/CMakeFiles/KF5KIOFileWidgets.dir/kfilefiltercombo.cpp.o[ 84%] Building CXX object src/filewidgets/CMakeFiles/KF5KIOFileWidgets.dir/kfilewidget.cpp.o[ 84%] Building CXX object src/filewidgets/CMakeFiles/KF5KIOFileWidgets.dir/kfilewidgetdocktitlebar.cpp.o[ 84%] Building CXX object src/filewidgets/CMakeFiles/KF5KIOFileWidgets.dir/kfileplacesitem.cpp.o[ 84%] Building CXX object src/filewidgets/CMakeFiles/KF5KIOFileWidgets.dir/kfileplacesmodel.cpp.o[ 84%] Building CXX object src/filewidgets/CMakeFiles/KF5KIOFileWidgets.dir/kfileplacesview.cpp.o[ 84%] Building CXX object src/filewidgets/CMakeFiles/KF5KIOFileWidgets.dir/kfileplaceeditdialog.cpp.o[ 85%] Building CXX object src/filewidgets/CMakeFiles/KF5KIOFileWidgets.dir/kfilepreviewgenerator.cpp.o[ 85%] Building CXX object src/filewidgets/CMakeFiles/KF5KIOFileWidgets.dir/knameandurlinputdialog.cpp.o[ 85%] Building CXX object src/filewidgets/CMakeFiles/KF5KIOFileWidgets.dir/knewfilemenu.cpp.o[ 85%] Building CXX object src/filewidgets/CMakeFiles/KF5KIOFileWidgets.dir/kurlnavigatordropdownbutton.cpp.o/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.9/src/filewidgets/kfilepreviewgenerator.cpp: In member function ‘void KFilePreviewGenerator::Private::limitToSize(QPixmap&, const QSize&)’:/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.9/src/filewidgets/kfilepreviewgenerator.cpp:986:88: note: #pragma message: Cannot use XRender with QPixmap anymore. Find equivalent with Qt API. #pragma message("Cannot use XRender with QPixmap anymore. Find equivalent with Qt API.")^[ 85%] Building CXX object src/filewidgets/CMakeFiles/KF5KIOFileWidgets.dir/kurlnavigatorbuttonbase.cpp.o[ 85%] Building CXX object src/filewidgets/CMakeFiles/KF5KIOFileWidgets.dir/kurlnavigatorbutton.cpp.o/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.9/src/filewidgets/knewfilemenu.cpp: In member function ‘void KNewFileMenuPrivate::confirmCreatingHiddenDir(const QString&)’:/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.9/src/filewidgets/knewfilemenu.cpp:416:1: error: version control conflict marker in file <<< 748a65599dd9818e683f7802ef7f0c8198f000de ^~~/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.9/src/filewidgets/knewfilemenu.cpp:416:3: error: expected primary-_expression_ before ‘<<’ token <<< 748a65599dd9818e683f7802ef7f0c8198f000de   ^~/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.9/src/filewidgets/knewfilemenu.cpp:416:5: error: expected primary-_expression_ before ‘<<’ token <<< 748a65599dd9818e683f7802ef7f0c8198f000de ^~/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.9/src/filewidgets/knewfilemenu.cpp:416:7: error: expected primary-_expression_ before ‘<’ token <<< 748a65599dd9818e683f7802ef7f0c8198f000de   ^/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.9/src/filewidgets/knewfilemenu.cpp:416:9: error: unable to find numeric literal operator ‘operator""a65599dd9818e683f7802ef7f0c8198f000de’ <<< 748a65599dd9818e683f7802ef7f0c8198f000de 

D14640: Use appropriate icon for a cancel button that will ask for a new name

[Nathaniel Graham]

ngraham closed this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14640

To: ngraham, #frameworks, #vdg, abetts
Cc: abetts, broulik, dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D14632: keyword rule: Spport for keywords inclusion from another language/file

[jonathan poelen]

jpoelen added a comment.


  I just thought of `Definition::keywordLists()` which does not list the 
keywords used by this new syntax.
  
  - Should we add the lists used as and when parsing?
  - Move the functionality on the tag ``? (``, ` 
name##language  `)
  - Other?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14632

To: jpoelen, #framework_syntax_highlighting, cullmann, dhaumann
Cc: kwrite-devel, vkrause, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D14610: Use KLineEdit for folder name if folder has write access, else use QLabel

[David Faure]

dfaure added a comment.


  In D14610#304619 , @rkflx wrote:
  
  > In D14610#303987 , @dfaure wrote:
  >
  > > Hmm, well, for IconApplet's use case
  >
  >
  > I'd say it would be nice to be consistent everywhere.
  >
  > > I could do it myself, faster than doing 10 reviews :-)
  >
  > No doubt about that, feel free to work on it ;) If you are busy, we can 
also add this to T9297  so we don't forget 
about it.
  
  
  Done: https://phabricator.kde.org/D14662
  
  > In D14610#304109 , @dfaure wrote:
  > 
  >> Make sure test "Create New / Text File" in dolphin.
  > 
  > 
  > Interesting, for me only Link to Application will bring up the properties 
dialog ;)
  
  Ah yes oops you're right, that's what this is about.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14610

To: shubham, rkflx, dfaure, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14662: KPropertiesDialog: switch to label in setFileNameReadOnly(true)

[David Faure]

dfaure created this revision.
dfaure added reviewers: rkflx, shubham, ngraham.
Restricted Application added a project: Frameworks.
Restricted Application edited subscribers, added: kde-frameworks-devel; 
removed: Frameworks.
dfaure requested review of this revision.

REVISION SUMMARY
  for consistency, when IconApplet calls this method it shouldn't use
  a readonly lineedit, but a QLabel.

TEST PLAN
  locally hacked tests/kpropertiesdialogtest.cpp to add a call to
  setFileNameReadOnly(true)

REPOSITORY
  R241 KIO

BRANCH
  kpropsdlg

REVISION DETAIL
  https://phabricator.kde.org/D14662

AFFECTED FILES
  src/widgets/kpropertiesdialog.cpp

To: dfaure, rkflx, shubham, ngraham
Cc: bruns, michaelh, kde-frameworks-devel, ngraham

D14632: keyword rule: Spport for keywords inclusion from another language/file

[jonathan poelen]

jpoelen edited the summary of this revision.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14632

To: jpoelen, #framework_syntax_highlighting, cullmann, dhaumann
Cc: kwrite-devel, vkrause, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D14643: Bump the minimum logging category to Warning

[Luigi Toscano]

ltoscano abandoned this revision.
ltoscano added a comment.


  Thanks for confirming. I will work on setting the default to Info for 
Frameworks components when it's not the case already, and tuning the debug 
messages.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14643

To: ltoscano, dfaure
Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D14643: Bump the minimum logging category to Warning

[David Faure]

dfaure added a comment.


  In D14643#304608 , @ltoscano wrote:
  
  > I was under the impression that we were generally moving towards less 
chatty components by default, which included having Warning as minimum default 
level.
  >  Unfortunately I don't remember anymore how I've got this idea, but I 
remember some patches setting the default level to Warning.
  >  Is there then an official policy for Frameworks? And outside Frameworks?
  
  
  ECM defines the policy: the default severity is Info.
  
  Since qCInfo is very rarely used, Info or Warning doesn't make a huge 
difference per se, it's just more correct that info works out of the box.
  AFAICS the patches that set the default level to Warning were back when the 
default was actually Debug (before the ECM macro, or for code that doesn't use 
it)...
  
  > It is true that Debian dropped the default qtlogging.ini file, but the 
first feedback from Fedora, for example, showed a strong desire of non-chatty 
at all.
  >  If you think that this can be achieved by reevaluating all the current 
qCInfo to fit them to qCDebug, then I will write more specific patches (in this 
case, for example, kf5.kio.favicons is too chatty; another case is 
kf5.kservice.sycoca).
  
  I don't see any qCInfo in KIO or in KService. I think you're still referring 
to qCDebugs or qDebugs there.
  In fact the only qCInfo usage in KF5 is in plasma-framework (and it's indeed 
wrong, these look like debug statements, feel free to port them to qCDebug).
  
  > But an official policy would be needed at least for Frameworks.
  
  I made it official in the ECM macro ;-)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14643

To: ltoscano, dfaure
Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D14572: Check the build directory for po/ as well

[David Faure]

dfaure accepted this revision.

REPOSITORY
  R249 KI18n

BRANCH
  arcpatch-D14572

REVISION DETAIL
  https://phabricator.kde.org/D14572

To: apol, #frameworks, ltoscano, dfaure
Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D14606: KCrash: DrKonqi cancelled = able to start...

[René J . V . Bertin]

rjvbb added a comment.


  OK, if no one else cares :)
  
  I told you how to reproduce the problem: do whatever it takes to make `cat 
/proc/sys/kernel/core_pattern` return a pipe command. Without that KCrash 
appears to think that you won't get a coredump (wrong...) and will exit when 
DrKonqi exits.
  
  As I said when I abandoned my patch, I think that the content of that 
(special) file should be used only as the initial value for a config setting 
that determines whether or not KCrash should re-raise the signal after DrKonqi 
exited:
  
  - /proc/sys/kernel/core_pattern is linux-specific (I think) and is likely to 
refer to the system crash reporter which shouldn't be used for software built 
locally (e.g. KF5 software).
  - coredumps are possible when that file does not contain a pipe command (in 
fact, that might be the only way to get them)

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D14606

To: rjvbb, #frameworks, sitter
Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D14606: KCrash: DrKonqi cancelled = able to start...

[David Faure]

dfaure added a comment.


  I never said I don't care, I said: tell me how to reproduce this problem.

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D14606

To: rjvbb, #frameworks, sitter
Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D14661: Force reevaluation of Predicates if interfaces are removed

[Stefan Brüns]

bruns created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  If an application wants to show only specicific devices based on predicate
  matching, and one of the matching devices loses an interface which is
  critical for the Predicate to match, the application has to be notified.
  
  As there is no dedicated signal to notify the application about the
  fact a device no longer has e.g. a Solid::StorageAccess iface, signal the
  device has been removed, and immediately readd it, as the device may
  still be relevant.
  
  Remove the call to updateBackend(udi), as the device backend listens to
  the InterfacesRemoved signal itself and updates its property cache.
  
  CCBUG: 394348

REPOSITORY
  R245 Solid

BRANCH
  test

REVISION DETAIL
  https://phabricator.kde.org/D14661

AFFECTED FILES
  src/solid/devices/backends/udisks2/udisksmanager.cpp

To: bruns
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14610: Use KLineEdit for folder name if folder has write access, else use QLabel

[Henrik Fehlauer]

rkflx added a comment.


  In D14610#303987 , @dfaure wrote:
  
  > Hmm, well, for IconApplet's use case
  
  
  I'd say it would be nice to be consistent everywhere.
  
  > I could do it myself, faster than doing 10 reviews :-)
  
  No doubt about that, feel free to work on it ;) If you are busy, we can also 
add this to T9297  so we don't forget about 
it.
  
  ---
  
  In D14610#304109 , @dfaure wrote:
  
  > Make sure test "Create New / Text File" in dolphin.
  
  
  Interesting, for me only Link to Application will bring up the properties 
dialog ;)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14610

To: shubham, rkflx, dfaure, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14643: Bump the minimum logging category to Warning

[Luigi Toscano]

ltoscano added a comment.


  I was under the impression that we were generally moving towards less chatty 
components by default, which included having Warning as minimum default level.
  
  Unfortunately I don't remember anymore how I've got this idea, but I remember 
some patches setting the default level to Warning.
  Is there then an official policy for Frameworks? And outside Frameworks?
  
  It is true that Debian dropped the default qtlogging.ini file, but the first 
feedback from Fedora, for example, showed a strong desire of non-chatty at all.
  If you think that this can be achieved by reevaluating all the current qCInfo 
to fit them to qCDebug, then I will write more specific patches (in this case, 
for example, kf5.kio.favicons is too chatty; another case is 
kf5.kservice.sycoca).
  
  But an official policy would be needed at least for Frameworks.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14643

To: ltoscano, dfaure
Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kirigami kf5-qt5 AndroidQt5.11 - Build # 63 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20AndroidQt5.11/63/
 Project:
Frameworks kirigami kf5-qt5 AndroidQt5.11
 Date of build:
Mon, 06 Aug 2018 16:29:17 +
 Build duration:
3 min 52 sec and counting

KDE CI: Frameworks kirigami kf5-qt5 SUSEQt5.10 - Build # 246 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.10/246/
 Project:
Frameworks kirigami kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 06 Aug 2018 16:29:17 +
 Build duration:
4 min 35 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/4)0%
(0/16)0%
(0/16)0%
(0/1236)0%
(0/869)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsexamples.applicationitemapp0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)examples.galleryapp0%
(0/1)0%
(0/1)0%
(0/10)0%
(0/4)src0%
(0/8)0%
(0/8)0%
(0/734)0%
(0/528)src.libkirigami0%
(0/6)0%
(0/6)0%
(0/484)0%
(0/337)

KDE CI: Frameworks kirigami kf5-qt5 WindowsMSVCQt5.10 - Build # 161 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20WindowsMSVCQt5.10/161/
 Project:
Frameworks kirigami kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Mon, 06 Aug 2018 16:29:17 +
 Build duration:
3 min 13 sec and counting

KDE CI: Frameworks kirigami kf5-qt5 SUSEQt5.9 - Build # 162 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.9/162/
 Project:
Frameworks kirigami kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 06 Aug 2018 16:29:17 +
 Build duration:
2 min 11 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/4)0%
(0/16)0%
(0/16)0%
(0/1236)0%
(0/869)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsexamples.applicationitemapp0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)examples.galleryapp0%
(0/1)0%
(0/1)0%
(0/10)0%
(0/4)src0%
(0/8)0%
(0/8)0%
(0/734)0%
(0/528)src.libkirigami0%
(0/6)0%
(0/6)0%
(0/484)0%
(0/337)

KDE CI: Frameworks kirigami kf5-qt5 SUSEQt5.9 - Build # 161 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.9/161/
 Project:
Frameworks kirigami kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 06 Aug 2018 16:15:56 +
 Build duration:
1 min 26 sec and counting
   CONSOLE OUTPUT
  [...truncated 98.96 KB...]-- The following REQUIRED packages have been found: * Qt5Network (required version >= 5.9.6) * Qt5Qml (required version >= 5.9.6) * Qt5Quick * Qt5Gui * Qt5Widgets (required version >= 5.9.6) * Qt5Svg * Qt5QuickControls2 * Qt5 (required version >= 5.8.0) * ECM (required version >= 5.49.0), Extra CMake Modules.,  * Qt5Core-- The following features have been disabled: * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)-- The following RUNTIME packages have not been found: * QtGraphicalEffects-QMLModule, QML module 'QtGraphicalEffects' is a runtime dependency.-- Configuring done-- Generating done-- Build files have been written to: /home/jenkins/workspace/Frameworks kirigami kf5-qt5 SUSEQt5.9/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[Frameworks kirigami kf5-qt5 SUSEQt5.9] Running shell script+ python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project kirigami --branchGroup kf5-qt5 --platform SUSEQt5.9 --usingInstall /home/jenkins//install-prefix/Scanning dependencies of target KF5Kirigami2_autogen[  2%] Automatic MOC for target KF5Kirigami2[  2%] Built target KF5Kirigami2_autogenScanning dependencies of target applicationitemapp_autogen[  5%] Automatic MOC for target applicationitemapp[  5%] Built target applicationitemapp_autogen[  8%] Generating tabletmodemanager_interface.cpp, tabletmodemanager_interface.h[ 11%] Generating tabletmodemanager_interface.mocScanning dependencies of target KF5Kirigami2[ 14%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/platformtheme.cpp.o[ 17%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/loggingcategory.cpp.o[ 20%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/KF5Kirigami2_autogen/mocs_compilation.cpp.o[ 22%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/tabletmodemanager_interface.cpp.o[ 25%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/tabletmodewatcher.cpp.o[ 28%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/kirigamipluginfactory.cpp.o[ 31%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/basictheme.cpp.o[ 34%] Linking CXX shared library ../../bin/libKF5Kirigami2.so[ 34%] Built target KF5Kirigami2[ 37%] Generating qrc_resources.cppScanning dependencies of target applicationitemapp[ 40%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/main.cpp.o[ 42%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/applicationitemapp_autogen/mocs_compilation.cpp.o[ 45%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/qrc_resources.cpp.o[ 48%] Linking CXX executable ../../bin/applicationitemapp[ 48%] Built target applicationitemappScanning dependencies of target kirigami2gallery_autogen[ 51%] Automatic MOC for target kirigami2gallery[ 51%] Built target kirigami2gallery_autogenScanning dependencies of target copy[ 51%] Built target copy[ 54%] Generating qrc_resources.cppScanning dependencies of target kirigami2gallery[ 57%] Building CXX object examples/galleryapp/CMakeFiles/kirigami2gallery.dir/main.cpp.o[ 60%] Building CXX object examples/galleryapp/CMakeFiles/kirigami2gallery.dir/kirigami2gallery_autogen/mocs_compilation.cpp.o[ 62%] Building CXX object examples/galleryapp/CMakeFiles/kirigami2gallery.dir/qrc_resources.cpp.o[ 65%] Linking CXX executable ../../bin/kirigami2gallery[ 65%] Built target kirigami2galleryScanning dependencies of target kirigamiplugin_autogen[ 68%] Automatic MOC for target kirigamiplugin[ 68%] Built target kirigamiplugin_autogenScanning dependencies of target kirigamiplugin[ 71%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/kirigamiplugin.cpp.o[ 74%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/ECMQmLoader-libkirigami2plugin_qt.cpp.o[ 77%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/kirigamiplugin_autogen/mocs_compilation.cpp.o[ 80%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/mnemonicattached.cpp.o[ 82%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/scenepositionattached.cpp.o[ 88%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/desktopicon.cpp.o[ 88%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/settings.cpp.o[ 94%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/formlayoutattached.cpp.o[ 94%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/delegaterecycler.cpp.o[ 97%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/enums.cpp.o/home/jenkins/workspace/Frameworks kirigami kf5-qt5 SUSEQt5.9/src/desktopicon.cpp: In member function ‘QImage 

KDE CI: Frameworks kirigami kf5-qt5 WindowsMSVCQt5.10 - Build # 160 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20WindowsMSVCQt5.10/160/
 Project:
Frameworks kirigami kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Mon, 06 Aug 2018 16:14:36 +
 Build duration:
1 min 30 sec and counting
   CONSOLE OUTPUT
  [...truncated 111.39 KB...][Frameworks kirigami kf5-qt5 WindowsMSVCQt5.10] Running batch scriptC:\CI\workspace\Frameworks kirigami kf5-qt5 WindowsMSVCQt5.10>call "C:/Program Files (x86)/Microsoft Visual Studio/2017/Professional/VC/Auxiliary/Build/vcvars64.bat"  Visual Studio 2017 Developer Command Prompt v15.7.3** Copyright (c) 2017 Microsoft Corporation**[vcvarsall.bat] Environment initialized for: 'x64'jom 1.0.16 - empower your coresScanning dependencies of target copy[  0%] Built target copyScanning dependencies of target KF5Kirigami2_autogen[  3%] Automatic MOC for target KF5Kirigami2[  3%] Built target KF5Kirigami2_autogenScanning dependencies of target kirigami2gallery_autogen[  6%] Automatic MOC for target kirigami2gallery[  6%] Built target kirigami2gallery_autogenScanning dependencies of target applicationitemapp_autogen[  9%] Automatic MOC for target applicationitemapp[  9%] Built target applicationitemapp_autogenScanning dependencies of target KF5Kirigami2[ 18%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/platformtheme.cpp.obj[ 18%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/kirigamipluginfactory.cpp.obj[ 18%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/basictheme.cpp.objplatformtheme.cpp[ 28%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/tabletmodewatcher.cpp.obj[ 28%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/loggingcategory.cpp.obj[ 28%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/KF5Kirigami2_autogen/mocs_compilation.cpp.objmocs_compilation.cpptabletmodewatcher.cpploggingcategory.cppkirigamipluginfactory.cppbasictheme.cpp[ 31%] Linking CXX shared library ..\..\bin\KF5Kirigami2.dll   Creating library ..\..\lib\KF5Kirigami2.lib and object ..\..\lib\KF5Kirigami2.exp   Creating library ..\..\lib\KF5Kirigami2.lib and object ..\..\lib\KF5Kirigami2.exp[ 31%] Built target KF5Kirigami2[ 34%] Generating qrc_resources.cppScanning dependencies of target kirigami2gallery[ 40%] Building CXX object examples/galleryapp/CMakeFiles/kirigami2gallery.dir/main.cpp.obj[ 40%] Building CXX object examples/galleryapp/CMakeFiles/kirigami2gallery.dir/kirigami2gallery_autogen/mocs_compilation.cpp.obj[ 43%] Building CXX object examples/galleryapp/CMakeFiles/kirigami2gallery.dir/qrc_resources.cpp.objmain.cppmocs_compilation.cppqrc_resources.cpp[ 46%] Linking CXX executable ..\..\bin\kirigami2gallery.exe   Creating library ..\..\lib\kirigami2gallery.lib and object ..\..\lib\kirigami2gallery.exp   Creating library ..\..\lib\kirigami2gallery.lib and object ..\..\lib\kirigami2gallery.exp[ 46%] Built target kirigami2gallery[ 50%] Generating qrc_resources.cppScanning dependencies of target applicationitemapp[ 53%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/main.cpp.obj[ 56%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/applicationitemapp_autogen/mocs_compilation.cpp.obj[ 59%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/qrc_resources.cpp.objmain.cppmocs_compilation.cppqrc_resources.cpp[ 62%] Linking CXX executable ..\..\bin\applicationitemapp.exe   Creating library ..\..\lib\applicationitemapp.lib and object ..\..\lib\applicationitemapp.exp   Creating library ..\..\lib\applicationitemapp.lib and object ..\..\lib\applicationitemapp.exp[ 62%] Built target applicationitemappScanning dependencies of target kirigamiplugin_autogen[ 65%] Automatic MOC for target kirigamiplugin[ 65%] Built target kirigamiplugin_autogenScanning dependencies of target kirigamiplugin[ 71%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/kirigamiplugin.cpp.obj[ 71%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/enums.cpp.obj[ 81%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/delegaterecycler.cpp.obj[ 81%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/desktopicon.cpp.obj[ 81%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/formlayoutattached.cpp.obj[ 87%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/settings.cpp.obj[ 84%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/scenepositionattached.cpp.objkirigamiplugin.cpp[ 90%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/mnemonicattached.cpp.objsettings.cppenums.cpp[ 93%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/ECMQmLoader-libkirigami2plugin_qt.cpp.obj[ 96%] Building CXX object 

KDE CI: Frameworks kirigami kf5-qt5 AndroidQt5.11 - Build # 62 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20AndroidQt5.11/62/
 Project:
Frameworks kirigami kf5-qt5 AndroidQt5.11
 Date of build:
Mon, 06 Aug 2018 16:15:29 +
 Build duration:
39 sec and counting
   CONSOLE OUTPUT
  [...truncated 110.37 KB...] * Qt5 (required version >= 5.8.0) * ECM (required version >= 5.49.0), Extra CMake Modules.,  * Qt5AndroidExtras (required version >= 5.8.0) * Qt5Core-- The following features have been disabled: * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)-- The following RUNTIME packages have not been found: * QtGraphicalEffects-QMLModule, QML module 'QtGraphicalEffects' is a runtime dependency.-- The following OPTIONAL packages have not been found: * KF5Kirigami2 (required version >= 5.49.0)-- Configuring done-- Generating doneCMake Warning:  Manually-specified variables were not used by the project:KF5_HOST_TOOLING-- Build files have been written to: /home/user/workspace/Frameworks kirigami kf5-qt5 AndroidQt5.11/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[Frameworks kirigami kf5-qt5 AndroidQt5.11] Running shell script+ python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project kirigami --branchGroup kf5-qt5 --platform AndroidQt5.11 --usingInstall /home/user/install-prefix/Scanning dependencies of target copyScanning dependencies of target KF5Kirigami2_autogenScanning dependencies of target applicationitemapp_autogen[  3%] Automatic MOC for target KF5Kirigami2[  6%] Automatic MOC for target applicationitemapp[  6%] Built target copy[  6%] Built target applicationitemapp_autogen[  9%] Generating qrc_resources.cpp[  9%] Built target KF5Kirigami2_autogenScanning dependencies of target applicationitemapp[ 15%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/main.cpp.o[ 15%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/qrc_resources.cpp.o[ 18%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/applicationitemapp_autogen/mocs_compilation.cpp.oScanning dependencies of target KF5Kirigami2[ 21%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/platformtheme.cpp.o[ 25%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/basictheme.cpp.o[ 28%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/kirigamipluginfactory.cpp.o[ 31%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/tabletmodewatcher.cpp.o[ 34%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/loggingcategory.cpp.o[ 37%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/KF5Kirigami2_autogen/mocs_compilation.cpp.o[ 40%] Linking CXX executable ../../bin/applicationitemapp[ 40%] Built target applicationitemapp[ 43%] Linking CXX shared library ../../bin/libKF5Kirigami2.so[ 43%] Built target KF5Kirigami2Scanning dependencies of target kirigamiplugin_autogenScanning dependencies of target kirigami2gallery_autogen[ 46%] Automatic MOC for target kirigamiplugin[ 50%] Automatic MOC for target kirigami2gallery[ 50%] Built target kirigami2gallery_autogen[ 53%] Generating qrc_resources.cppScanning dependencies of target kirigami2gallery[ 56%] Building CXX object examples/galleryapp/CMakeFiles/kirigami2gallery.dir/main.cpp.o[ 59%] Building CXX object examples/galleryapp/CMakeFiles/kirigami2gallery.dir/qrc_resources.cpp.o[ 62%] Building CXX object examples/galleryapp/CMakeFiles/kirigami2gallery.dir/kirigami2gallery_autogen/mocs_compilation.cpp.o[ 62%] Built target kirigamiplugin_autogenScanning dependencies of target kirigamiplugin[ 68%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/enums.cpp.o[ 68%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/kirigamiplugin.cpp.o[ 71%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/delegaterecycler.cpp.o[ 75%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/desktopicon.cpp.o[ 78%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/settings.cpp.o[ 81%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/formlayoutattached.cpp.o[ 84%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/scenepositionattached.cpp.o[ 87%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/mnemonicattached.cpp.o[ 90%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/ECMQmLoader-libkirigami2plugin_qt.cpp.o[ 93%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/kirigamiplugin_autogen/mocs_compilation.cpp.o/home/user/workspace/Frameworks kirigami kf5-qt5 AndroidQt5.11/src/desktopicon.cpp: In member function 'QImage DesktopIcon::findIcon(const QSize&)':/home/user/workspace/Frameworks kirigami kf5-qt5 AndroidQt5.11/src/desktopicon.cpp:440:41: error: 'class QString' has no member named 'startWith' if (iconId.size() >=2 && iconId.startWith(QLatin1String("/:"))) { ^[ 96%] 

KDE CI: Frameworks kirigami kf5-qt5 SUSEQt5.9 - Build # 160 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.9/160/
 Project:
Frameworks kirigami kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 06 Aug 2018 16:12:46 +
 Build duration:
3 min 8 sec and counting
   CONSOLE OUTPUT
  [...truncated 97.36 KB...]  Appstream information won't be generated for .-- The following OPTIONAL packages have been found: * Qt5Test (required version >= 5.8.0) * Qt5DBus-- The following REQUIRED packages have been found: * Qt5Network (required version >= 5.9.6) * Qt5Qml (required version >= 5.9.6) * Qt5Quick * Qt5Gui * Qt5Widgets (required version >= 5.9.6) * Qt5Svg * Qt5QuickControls2 * Qt5 (required version >= 5.8.0) * ECM (required version >= 5.49.0), Extra CMake Modules.,  * Qt5Core-- The following features have been disabled: * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)-- The following RUNTIME packages have not been found: * QtGraphicalEffects-QMLModule, QML module 'QtGraphicalEffects' is a runtime dependency.-- Configuring done-- Generating done-- Build files have been written to: /home/jenkins/workspace/Frameworks kirigami kf5-qt5 SUSEQt5.9/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[Frameworks kirigami kf5-qt5 SUSEQt5.9] Running shell script+ python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project kirigami --branchGroup kf5-qt5 --platform SUSEQt5.9 --usingInstall /home/jenkins//install-prefix/Scanning dependencies of target KF5Kirigami2_autogen[  2%] Automatic MOC for target KF5Kirigami2[  2%] Built target KF5Kirigami2_autogenScanning dependencies of target copy[  2%] Built target copyScanning dependencies of target kirigami2gallery_autogen[  5%] Automatic MOC for target kirigami2gallery[  5%] Built target kirigami2gallery_autogenScanning dependencies of target applicationitemapp_autogen[  8%] Automatic MOC for target applicationitemapp[  8%] Built target applicationitemapp_autogen[ 11%] Generating tabletmodemanager_interface.cpp, tabletmodemanager_interface.h[ 14%] Generating tabletmodemanager_interface.mocScanning dependencies of target KF5Kirigami2[ 17%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/platformtheme.cpp.o[ 20%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/basictheme.cpp.o[ 22%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/kirigamipluginfactory.cpp.o[ 25%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/tabletmodewatcher.cpp.o[ 28%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/tabletmodemanager_interface.cpp.o[ 31%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/loggingcategory.cpp.o[ 34%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/KF5Kirigami2_autogen/mocs_compilation.cpp.o[ 37%] Linking CXX shared library ../../bin/libKF5Kirigami2.so[ 37%] Built target KF5Kirigami2[ 40%] Generating qrc_resources.cppScanning dependencies of target kirigami2gallery[ 42%] Building CXX object examples/galleryapp/CMakeFiles/kirigami2gallery.dir/main.cpp.o[ 45%] Building CXX object examples/galleryapp/CMakeFiles/kirigami2gallery.dir/qrc_resources.cpp.o[ 48%] Building CXX object examples/galleryapp/CMakeFiles/kirigami2gallery.dir/kirigami2gallery_autogen/mocs_compilation.cpp.o[ 51%] Linking CXX executable ../../bin/kirigami2gallery[ 51%] Built target kirigami2gallery[ 54%] Generating qrc_resources.cppScanning dependencies of target applicationitemapp[ 57%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/main.cpp.o[ 60%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/qrc_resources.cpp.o[ 62%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/applicationitemapp_autogen/mocs_compilation.cpp.o[ 65%] Linking CXX executable ../../bin/applicationitemapp[ 65%] Built target applicationitemappScanning dependencies of target kirigamiplugin_autogen[ 68%] Automatic MOC for target kirigamiplugin[ 68%] Built target kirigamiplugin_autogenScanning dependencies of target kirigamiplugin[ 71%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/kirigamiplugin.cpp.o[ 74%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/enums.cpp.o[ 77%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/delegaterecycler.cpp.o[ 80%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/desktopicon.cpp.o/home/jenkins/workspace/Frameworks kirigami kf5-qt5 SUSEQt5.9/src/desktopicon.cpp: In member function ‘QImage DesktopIcon::findIcon(const QSize&)’:/home/jenkins/workspace/Frameworks kirigami kf5-qt5 SUSEQt5.9/src/desktopicon.cpp:440:41: error: ‘class QString’ has no member named ‘startWith’; did you mean ‘startsWith’? if (iconId.size() >=2 && iconId.startWith(QLatin1String("/:"))) { ^ startsWithmake[2]: *** 

KDE CI: Frameworks kirigami kf5-qt5 SUSEQt5.10 - Build # 245 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.10/245/
 Project:
Frameworks kirigami kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 06 Aug 2018 16:14:36 +
 Build duration:
53 sec and counting
   CONSOLE OUTPUT
  [...truncated 98.49 KB...]-- The following REQUIRED packages have been found: * Qt5Network (required version >= 5.10.1) * Qt5Qml (required version >= 5.10.1) * Qt5Quick * Qt5Gui * Qt5Widgets (required version >= 5.10.1) * Qt5Svg * Qt5QuickControls2 * Qt5 (required version >= 5.8.0) * ECM (required version >= 5.49.0), Extra CMake Modules.,  * Qt5Core-- The following features have been disabled: * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)-- The following RUNTIME packages have not been found: * QtGraphicalEffects-QMLModule, QML module 'QtGraphicalEffects' is a runtime dependency.-- Configuring done-- Generating done-- Build files have been written to: /home/jenkins/workspace/Frameworks kirigami kf5-qt5 SUSEQt5.10/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[Frameworks kirigami kf5-qt5 SUSEQt5.10] Running shell script+ python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project kirigami --branchGroup kf5-qt5 --platform SUSEQt5.10 --usingInstall /home/jenkins//install-prefix/Scanning dependencies of target copyScanning dependencies of target kirigami2gallery_autogenScanning dependencies of target applicationitemapp_autogenScanning dependencies of target KF5Kirigami2_autogen[  2%] Automatic MOC for target KF5Kirigami2[  5%] Automatic MOC for target kirigami2gallery[  8%] Automatic MOC for target applicationitemapp[  8%] Built target copy[  8%] Built target applicationitemapp_autogen[  8%] Built target kirigami2gallery_autogen[ 11%] Generating qrc_resources.cpp[ 14%] Generating qrc_resources.cpp[ 14%] Built target KF5Kirigami2_autogen[ 17%] Generating tabletmodemanager_interface.cpp, tabletmodemanager_interface.hScanning dependencies of target applicationitemappScanning dependencies of target kirigami2gallery[ 20%] Building CXX object examples/galleryapp/CMakeFiles/kirigami2gallery.dir/main.cpp.o[ 22%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/main.cpp.o[ 25%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/applicationitemapp_autogen/mocs_compilation.cpp.o[ 28%] Building CXX object examples/galleryapp/CMakeFiles/kirigami2gallery.dir/qrc_resources.cpp.o[ 31%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/qrc_resources.cpp.o[ 34%] Generating tabletmodemanager_interface.moc[ 37%] Building CXX object examples/galleryapp/CMakeFiles/kirigami2gallery.dir/kirigami2gallery_autogen/mocs_compilation.cpp.oScanning dependencies of target KF5Kirigami2[ 40%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/platformtheme.cpp.o[ 42%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/basictheme.cpp.o[ 45%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/kirigamipluginfactory.cpp.o[ 48%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/tabletmodewatcher.cpp.o[ 51%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/tabletmodemanager_interface.cpp.o[ 54%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/loggingcategory.cpp.o[ 57%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/KF5Kirigami2_autogen/mocs_compilation.cpp.o[ 60%] Linking CXX executable ../../bin/applicationitemapp[ 62%] Linking CXX executable ../../bin/kirigami2gallery[ 65%] Linking CXX shared library ../../bin/libKF5Kirigami2.so[ 65%] Built target applicationitemapp[ 65%] Built target kirigami2gallery[ 65%] Built target KF5Kirigami2Scanning dependencies of target kirigamiplugin_autogen[ 68%] Automatic MOC for target kirigamiplugin[ 68%] Built target kirigamiplugin_autogenScanning dependencies of target kirigamiplugin[ 71%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/enums.cpp.o[ 74%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/kirigamiplugin.cpp.o[ 77%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/desktopicon.cpp.o[ 80%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/delegaterecycler.cpp.o[ 82%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/ECMQmLoader-libkirigami2plugin_qt.cpp.o[ 85%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/mnemonicattached.cpp.o[ 88%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/formlayoutattached.cpp.o[ 91%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/kirigamiplugin_autogen/mocs_compilation.cpp.o[ 94%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/scenepositionattached.cpp.o/home/jenkins/workspace/Frameworks kirigami kf5-qt5 SUSEQt5.10/src/desktopicon.cpp: In member function ‘QImage DesktopIcon::findIcon(const QSize&)’:/home/jenkins/workspace/Frameworks kirigami 

KDE CI: Frameworks kirigami kf5-qt5 AndroidQt5.11 - Build # 61 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20AndroidQt5.11/61/
 Project:
Frameworks kirigami kf5-qt5 AndroidQt5.11
 Date of build:
Mon, 06 Aug 2018 16:12:47 +
 Build duration:
2 min 41 sec and counting
   CONSOLE OUTPUT
  [...truncated 111.06 KB...] * Qt5QuickControls2 * Qt5 (required version >= 5.8.0) * ECM (required version >= 5.49.0), Extra CMake Modules.,  * Qt5AndroidExtras (required version >= 5.8.0) * Qt5Core-- The following features have been disabled: * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)-- The following RUNTIME packages have not been found: * QtGraphicalEffects-QMLModule, QML module 'QtGraphicalEffects' is a runtime dependency.-- The following OPTIONAL packages have not been found: * KF5Kirigami2 (required version >= 5.49.0)-- Configuring done-- Generating doneCMake Warning:  Manually-specified variables were not used by the project:KF5_HOST_TOOLING-- Build files have been written to: /home/user/workspace/Frameworks kirigami kf5-qt5 AndroidQt5.11/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[Frameworks kirigami kf5-qt5 AndroidQt5.11] Running shell script+ python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project kirigami --branchGroup kf5-qt5 --platform AndroidQt5.11 --usingInstall /home/user/install-prefix/Scanning dependencies of target KF5Kirigami2_autogenScanning dependencies of target copyScanning dependencies of target applicationitemapp_autogen[  3%] Automatic MOC for target KF5Kirigami2[  6%] Automatic MOC for target applicationitemapp[  6%] Built target applicationitemapp_autogen[  9%] Generating qrc_resources.cpp[  9%] Built target copy[  9%] Built target KF5Kirigami2_autogenScanning dependencies of target applicationitemapp[ 12%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/qrc_resources.cpp.o[ 15%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/main.cpp.o[ 18%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/applicationitemapp_autogen/mocs_compilation.cpp.oScanning dependencies of target KF5Kirigami2[ 21%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/platformtheme.cpp.o[ 25%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/basictheme.cpp.o[ 28%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/tabletmodewatcher.cpp.o[ 31%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/loggingcategory.cpp.o[ 34%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/kirigamipluginfactory.cpp.o[ 37%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/KF5Kirigami2_autogen/mocs_compilation.cpp.o[ 40%] Linking CXX executable ../../bin/applicationitemapp[ 40%] Built target applicationitemapp[ 43%] Linking CXX shared library ../../bin/libKF5Kirigami2.so[ 43%] Built target KF5Kirigami2Scanning dependencies of target kirigami2gallery_autogenScanning dependencies of target kirigamiplugin_autogen[ 46%] Automatic MOC for target kirigami2gallery[ 50%] Automatic MOC for target kirigamiplugin[ 50%] Built target kirigami2gallery_autogen[ 53%] Generating qrc_resources.cppScanning dependencies of target kirigami2gallery[ 56%] Building CXX object examples/galleryapp/CMakeFiles/kirigami2gallery.dir/main.cpp.o[ 59%] Building CXX object examples/galleryapp/CMakeFiles/kirigami2gallery.dir/qrc_resources.cpp.o[ 62%] Building CXX object examples/galleryapp/CMakeFiles/kirigami2gallery.dir/kirigami2gallery_autogen/mocs_compilation.cpp.o[ 62%] Built target kirigamiplugin_autogenScanning dependencies of target kirigamiplugin[ 68%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/enums.cpp.o[ 68%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/kirigamiplugin.cpp.o[ 71%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/delegaterecycler.cpp.o[ 75%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/desktopicon.cpp.o[ 78%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/settings.cpp.o[ 81%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/formlayoutattached.cpp.o[ 84%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/scenepositionattached.cpp.o[ 87%] Linking CXX executable ../../bin/kirigami2gallery[ 87%] Built target kirigami2gallery[ 90%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/mnemonicattached.cpp.o[ 93%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/ECMQmLoader-libkirigami2plugin_qt.cpp.o/home/user/workspace/Frameworks kirigami kf5-qt5 AndroidQt5.11/src/desktopicon.cpp: In member function 'QImage DesktopIcon::findIcon(const QSize&)':/home/user/workspace/Frameworks kirigami kf5-qt5 AndroidQt5.11/src/desktopicon.cpp:440:41: error: 'class QString' has no member named 'startWith' if (iconId.size() >=2 && iconId.startWith(QLatin1String("/:"))) { 

KDE CI: Frameworks kirigami kf5-qt5 WindowsMSVCQt5.10 - Build # 159 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20WindowsMSVCQt5.10/159/
 Project:
Frameworks kirigami kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Mon, 06 Aug 2018 16:12:46 +
 Build duration:
1 min 40 sec and counting
   CONSOLE OUTPUT
  [...truncated 111.40 KB...][Frameworks kirigami kf5-qt5 WindowsMSVCQt5.10] Running batch scriptC:\CI\workspace\Frameworks kirigami kf5-qt5 WindowsMSVCQt5.10>call "C:/Program Files (x86)/Microsoft Visual Studio/2017/Professional/VC/Auxiliary/Build/vcvars64.bat"  Visual Studio 2017 Developer Command Prompt v15.7.3** Copyright (c) 2017 Microsoft Corporation**[vcvarsall.bat] Environment initialized for: 'x64'jom 1.0.16 - empower your coresScanning dependencies of target KF5Kirigami2_autogen[  3%] Automatic MOC for target KF5Kirigami2[  3%] Built target KF5Kirigami2_autogenScanning dependencies of target copy[  3%] Built target copyScanning dependencies of target kirigami2gallery_autogen[  6%] Automatic MOC for target kirigami2gallery[  6%] Built target kirigami2gallery_autogenScanning dependencies of target applicationitemapp_autogen[  9%] Automatic MOC for target applicationitemapp[  9%] Built target applicationitemapp_autogenScanning dependencies of target KF5Kirigami2[ 12%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/basictheme.cpp.obj[ 15%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/platformtheme.cpp.obj[ 28%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/tabletmodewatcher.cpp.obj[ 28%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/kirigamipluginfactory.cpp.obj[ 28%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/loggingcategory.cpp.objplatformtheme.cpp[ 28%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/KF5Kirigami2_autogen/mocs_compilation.cpp.objmocs_compilation.cpptabletmodewatcher.cpploggingcategory.cppkirigamipluginfactory.cppbasictheme.cpp[ 31%] Linking CXX shared library ..\..\bin\KF5Kirigami2.dll   Creating library ..\..\lib\KF5Kirigami2.lib and object ..\..\lib\KF5Kirigami2.exp   Creating library ..\..\lib\KF5Kirigami2.lib and object ..\..\lib\KF5Kirigami2.exp[ 31%] Built target KF5Kirigami2[ 34%] Generating qrc_resources.cppScanning dependencies of target kirigami2gallery[ 43%] Building CXX object examples/galleryapp/CMakeFiles/kirigami2gallery.dir/main.cpp.obj[ 43%] Building CXX object examples/galleryapp/CMakeFiles/kirigami2gallery.dir/kirigami2gallery_autogen/mocs_compilation.cpp.obj[ 43%] Building CXX object examples/galleryapp/CMakeFiles/kirigami2gallery.dir/qrc_resources.cpp.objmain.cppmocs_compilation.cppqrc_resources.cpp[ 46%] Linking CXX executable ..\..\bin\kirigami2gallery.exe   Creating library ..\..\lib\kirigami2gallery.lib and object ..\..\lib\kirigami2gallery.exp   Creating library ..\..\lib\kirigami2gallery.lib and object ..\..\lib\kirigami2gallery.exp[ 46%] Built target kirigami2gallery[ 50%] Generating qrc_resources.cppScanning dependencies of target applicationitemapp[ 56%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/main.cpp.obj[ 56%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/applicationitemapp_autogen/mocs_compilation.cpp.obj[ 59%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/qrc_resources.cpp.objmain.cppmocs_compilation.cppqrc_resources.cpp[ 62%] Linking CXX executable ..\..\bin\applicationitemapp.exe   Creating library ..\..\lib\applicationitemapp.lib and object ..\..\lib\applicationitemapp.exp   Creating library ..\..\lib\applicationitemapp.lib and object ..\..\lib\applicationitemapp.exp[ 62%] Built target applicationitemappScanning dependencies of target kirigamiplugin_autogen[ 65%] Automatic MOC for target kirigamiplugin[ 65%] Built target kirigamiplugin_autogenScanning dependencies of target kirigamiplugin[ 71%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/kirigamiplugin.cpp.obj[ 71%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/enums.cpp.obj[ 78%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/delegaterecycler.cpp.obj[ 87%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/mnemonicattached.cpp.obj[ 81%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/desktopicon.cpp.obj[ 87%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/settings.cpp.objkirigamiplugin.cpp[ 90%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/formlayoutattached.cpp.obj[ 90%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/scenepositionattached.cpp.objenums.cpp[ 93%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/ECMQmLoader-libkirigami2plugin_qt.cpp.objsettings.cpp[ 96%] Building CXX object 

KDE CI: Frameworks kirigami kf5-qt5 SUSEQt5.10 - Build # 244 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.10/244/
 Project:
Frameworks kirigami kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 06 Aug 2018 16:12:46 +
 Build duration:
58 sec and counting
   CONSOLE OUTPUT
  [...truncated 98.20 KB...] * Qt5DBus-- The following REQUIRED packages have been found: * Qt5Network (required version >= 5.10.1) * Qt5Qml (required version >= 5.10.1) * Qt5Quick * Qt5Gui * Qt5Widgets (required version >= 5.10.1) * Qt5Svg * Qt5QuickControls2 * Qt5 (required version >= 5.8.0) * ECM (required version >= 5.49.0), Extra CMake Modules.,  * Qt5Core-- The following features have been disabled: * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)-- The following RUNTIME packages have not been found: * QtGraphicalEffects-QMLModule, QML module 'QtGraphicalEffects' is a runtime dependency.-- Configuring done-- Generating done-- Build files have been written to: /home/jenkins/workspace/Frameworks kirigami kf5-qt5 SUSEQt5.10/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[Frameworks kirigami kf5-qt5 SUSEQt5.10] Running shell script+ python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project kirigami --branchGroup kf5-qt5 --platform SUSEQt5.10 --usingInstall /home/jenkins//install-prefix/Scanning dependencies of target copyScanning dependencies of target KF5Kirigami2_autogenScanning dependencies of target kirigami2gallery_autogenScanning dependencies of target applicationitemapp_autogen[  2%] Automatic MOC for target KF5Kirigami2[  5%] Automatic MOC for target applicationitemapp[  8%] Automatic MOC for target kirigami2gallery[  8%] Built target copy[  8%] Built target applicationitemapp_autogen[  8%] Built target kirigami2gallery_autogen[ 11%] Generating qrc_resources.cpp[ 14%] Generating qrc_resources.cpp[ 14%] Built target KF5Kirigami2_autogenScanning dependencies of target applicationitemapp[ 17%] Generating tabletmodemanager_interface.cpp, tabletmodemanager_interface.hScanning dependencies of target kirigami2gallery[ 20%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/qrc_resources.cpp.o[ 22%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/main.cpp.o[ 25%] Generating tabletmodemanager_interface.moc[ 28%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/applicationitemapp_autogen/mocs_compilation.cpp.o[ 31%] Building CXX object examples/galleryapp/CMakeFiles/kirigami2gallery.dir/main.cpp.o[ 34%] Building CXX object examples/galleryapp/CMakeFiles/kirigami2gallery.dir/qrc_resources.cpp.o[ 37%] Building CXX object examples/galleryapp/CMakeFiles/kirigami2gallery.dir/kirigami2gallery_autogen/mocs_compilation.cpp.oScanning dependencies of target KF5Kirigami2[ 40%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/platformtheme.cpp.o[ 42%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/basictheme.cpp.o[ 45%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/kirigamipluginfactory.cpp.o[ 51%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/tabletmodemanager_interface.cpp.o[ 51%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/tabletmodewatcher.cpp.o[ 54%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/loggingcategory.cpp.o[ 57%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/KF5Kirigami2_autogen/mocs_compilation.cpp.o[ 60%] Linking CXX executable ../../bin/kirigami2gallery[ 62%] Linking CXX executable ../../bin/applicationitemapp[ 65%] Linking CXX shared library ../../bin/libKF5Kirigami2.so[ 65%] Built target kirigami2gallery[ 65%] Built target applicationitemapp[ 65%] Built target KF5Kirigami2Scanning dependencies of target kirigamiplugin_autogen[ 68%] Automatic MOC for target kirigamiplugin[ 68%] Built target kirigamiplugin_autogenScanning dependencies of target kirigamiplugin[ 71%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/delegaterecycler.cpp.o[ 74%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/enums.cpp.o[ 77%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/kirigamiplugin.cpp.o[ 80%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/ECMQmLoader-libkirigami2plugin_qt.cpp.o[ 82%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/mnemonicattached.cpp.o[ 85%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/kirigamiplugin_autogen/mocs_compilation.cpp.o[ 88%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/scenepositionattached.cpp.o[ 91%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/formlayoutattached.cpp.o[ 94%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/settings.cpp.o[ 97%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/desktopicon.cpp.o/home/jenkins/workspace/Frameworks kirigami kf5-qt5 SUSEQt5.10/src/desktopicon.cpp: In member function 

D14640: Use appropriate icon for a cancel button that will ask for a new name

[Andres Betts]

abetts added a comment.


  In D14640#304428 , @ngraham wrote:
  
  > In D14640#304405 , @abetts wrote:
  >
  > > In D14640#304400 , @ngraham 
wrote:
  > >
  > > > Hmm, I'm not sure a cancel button makes sense here because that would 
end the process of creating the folder. If you chose an invalid name, 
presumably you still want to create the folder.
  > >
  > >
  > > I am mostly trying to think of unintended actions upon unintended 
actions. Thinking maybe that a less knowledgeable user just took the wrong path 
in trying to complete an action.
  >
  >
  > Now that I think about it, you're right. I'll submit a patch for that once 
my current crop of patches are accepted and landed. Wanna accept this one?
  
  
  Yes, no problem! Thanks for taking my suggestion.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14640

To: ngraham, #frameworks, #vdg
Cc: abetts, broulik, dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D14640: Use appropriate icon for a cancel button that will ask for a new name

[Andres Betts]

abetts accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  rename-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14640

To: ngraham, #frameworks, #vdg, abetts
Cc: abetts, broulik, dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D14640: Use appropriate icon for a cancel button that will ask for a new name

[Nathaniel Graham]

ngraham added a comment.


  In D14640#304405 , @abetts wrote:
  
  > In D14640#304400 , @ngraham 
wrote:
  >
  > > Hmm, I'm not sure a cancel button makes sense here because that would end 
the process of creating the folder. If you chose an invalid name, presumably 
you still want to create the folder.
  >
  >
  > I am mostly trying to think of unintended actions upon unintended actions. 
Thinking maybe that a less knowledgeable user just took the wrong path in 
trying to complete an action.
  
  
  Now that I think about it, you're right. I'll submit a patch for that once my 
current crop of patches are accepted and landed. Wanna accept this one?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14640

To: ngraham, #frameworks, #vdg
Cc: abetts, broulik, dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D14569: Make it possible for ECM to detect po files at configure time

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R240:02881711cfce: Make it possible for ECM to detect po files 
at configure time (authored by apol).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14569?vs=39197=39198

REVISION DETAIL
  https://phabricator.kde.org/D14569

AFFECTED FILES
  kde-modules/KDECMakeSettings.cmake
  modules/ECMPoQmTools.cmake

To: apol, #frameworks, cgiboudeaux
Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D14572: Check the build directory for po/ as well

[Luigi Toscano]

ltoscano accepted this revision.
ltoscano added a comment.


  It was basically already approved, and it already made sense. The only 
requested change (a comment) was applied.

REPOSITORY
  R249 KI18n

BRANCH
  arcpatch-D14572

REVISION DETAIL
  https://phabricator.kde.org/D14572

To: apol, #frameworks, ltoscano, dfaure
Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D14569: Make it possible for ECM to detect po files at configure time

[Aleix Pol Gonzalez]

apol updated this revision to Diff 39197.
apol added a comment.


  Correct version

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14569?vs=38983=39197

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14569

AFFECTED FILES
  kde-modules/KDECMakeSettings.cmake
  modules/ECMPoQmTools.cmake

To: apol, #frameworks, cgiboudeaux
Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D14572: Check the build directory for po/ as well

[Aleix Pol Gonzalez]

apol updated this revision to Diff 39196.
apol added a comment.


  Added David's recommended comment

REPOSITORY
  R249 KI18n

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14572?vs=38988=39196

BRANCH
  arcpatch-D14572

REVISION DETAIL
  https://phabricator.kde.org/D14572

AFFECTED FILES
  cmake/KF5I18nMacros.cmake.in

To: apol, #frameworks, ltoscano, dfaure
Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D14640: Use appropriate icon for a cancel button that will ask for a new name

[Andres Betts]

abetts added a comment.


  In D14640#304400 , @ngraham wrote:
  
  > Hmm, I'm not sure a cancel button makes sense here because that would end 
the process of creating the folder. If you chose an invalid name, presumably 
you still want to create the folder.
  
  
  I am mostly trying to think of unintended actions upon unintended actions. 
Thinking maybe that a less knowledgeable user just took the wrong path in 
trying to complete an action.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14640

To: ngraham, #frameworks, #vdg
Cc: abetts, broulik, dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D14640: Use appropriate icon for a cancel button that will ask for a new name

[Nathaniel Graham]

ngraham added a comment.


  Hmm, I'm not sure a cancel button makes sense here because that would end the 
process of creating the folder. If you chose an invalid name, presumably you 
still want to create the folder.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14640

To: ngraham, #frameworks, #vdg
Cc: abetts, broulik, dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D14606: KCrash: DrKonqi cancelled = able to start...

[René J . V . Bertin]

rjvbb added a comment.


  I'd still like that message not to appear if I just dismissed DrKonqi myself.
  
  But if no one else care about it I'll just patch the code for myself ...

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D14606

To: rjvbb, #frameworks, sitter
Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D14640: Use appropriate icon for a cancel button that will ask for a new name

[Andres Betts]

abetts added a comment.


  Could the message have 2 buttons? A cancel and an "Enter a different name". 
That way, if the user inadvertently entered that reserved name can cancel the 
action still.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14640

To: ngraham, #frameworks, #vdg
Cc: abetts, broulik, dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 197 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/197/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 06 Aug 2018 13:58:31 +
 Build duration:
6 min 15 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 58 test(s), Skipped: 0 test(s), Total: 59 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesviewtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)65%
(258/396)65%
(258/396)53%
(31929/59911)38%
(16130/42676)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(55/55)100%
(55/55)95%
(9025/9455)51%
(3929/7716)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core84%
(98/116)84%
(98/116)58%
(8333/14357)50%
(4655/9289)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3894/7924)34%
(1586/4669)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(527/1015)39%
(315/814)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1364)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/245)0%
(0/144)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1775/4320)35%
(1304/3700)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(629/1331)55%
(619/1123)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/257)7%
(14/212)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash56%
(5/9)56%
(5/9)51%

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 196 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/196/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 06 Aug 2018 13:38:06 +
 Build duration:
20 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 58 test(s), Skipped: 0 test(s), Total: 59 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesviewtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)65%
(258/396)65%
(258/396)53%
(31963/59911)38%
(16150/42676)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(55/55)100%
(55/55)95%
(9025/9455)51%
(3929/7716)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core84%
(98/116)84%
(98/116)58%
(8351/14358)50%
(4662/9289)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3894/7924)34%
(1586/4669)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(528/1015)39%
(316/814)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1364)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/245)0%
(0/144)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4320)35%
(1306/3700)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(629/1331)55%
(619/1123)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/257)7%
(14/212)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash56%
(5/9)56%
(5/9)52%
  

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 107 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/107/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.10
 Date of build:
Mon, 06 Aug 2018 13:46:58 +
 Build duration:
8 min 5 sec and counting
   JUnit Tests
  Name: (root) Failed: 5 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiofilewidgets-kfileplacesviewtestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 352 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/352/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 06 Aug 2018 13:48:25 +
 Build duration:
6 min 56 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 58 test(s), Skipped: 0 test(s), Total: 59 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesviewtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)65%
(258/396)65%
(258/396)53%
(31875/59910)38%
(16104/42678)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(55/55)100%
(55/55)95%
(9025/9455)51%
(3929/7716)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core84%
(98/116)84%
(98/116)58%
(8284/14357)50%
(4636/9285)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3893/7924)34%
(1585/4669)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(527/1015)39%
(315/814)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1364)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/245)0%
(0/144)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1775/4320)35%
(1304/3700)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1331)55%
(620/1123)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/257)7%
(14/212)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash56%
(5/9)56%

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 351 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/351/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 06 Aug 2018 13:38:06 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 58 test(s), Skipped: 0 test(s), Total: 59 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesviewtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)65%
(258/396)65%
(258/396)53%
(31884/59910)38%
(16115/42678)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(55/55)100%
(55/55)95%
(9025/9455)51%
(3929/7716)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core84%
(98/116)84%
(98/116)58%
(8284/14357)50%
(4637/9285)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3893/7924)34%
(1585/4669)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(527/1015)39%
(315/814)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1364)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/245)0%
(0/144)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1775/4320)35%
(1304/3700)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1331)55%
(620/1123)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/257)7%
(14/212)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash56%
(5/9)56%
(5/9)51%

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 106 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/106/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.10
 Date of build:
Mon, 06 Aug 2018 13:38:06 +
 Build duration:
8 min 49 sec and counting
   JUnit Tests
  Name: (root) Failed: 5 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiofilewidgets-kfileplacesviewtestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

D14648: Make read-only filenames selectable

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:748a65599dd9: Make read-only filenames selectable 
(authored by ngraham).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14648?vs=39189=39193

REVISION DETAIL
  https://phabricator.kde.org/D14648

AFFECTED FILES
  src/widgets/kpropertiesdialog.cpp

To: ngraham, shubham, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14650: Use title case for some button labels

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:5bdb364b0a02: Use title case for some button labels 
(authored by ngraham).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14650?vs=39191=39192

REVISION DETAIL
  https://phabricator.kde.org/D14650

AFFECTED FILES
  src/filewidgets/knewfilemenu.cpp

To: ngraham, broulik, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14648: Make read-only filenames selectable

[Shubham]

shubham accepted this revision.
shubham added a comment.
This revision is now accepted and ready to land.


  Oh, forgot to do that  in R241:e2c56f6ddc517bc4915ab3c84971d17054225c76 
.

REPOSITORY
  R241 KIO

BRANCH
  selectable-read-only-filename (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14648

To: ngraham, shubham, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14650: Use title case for some button labels

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  Thanks

REPOSITORY
  R241 KIO

BRANCH
  title-case (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14650

To: ngraham, broulik, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14640: Use appropriate icon for a cancel button that will ask for a new name

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> broulik wrote in knewfilemenu.cpp:416
> Also this needs title capitalization [1]
> 
> [1] https://community.kde.org/KDE_Visual_Design_Group/HIG/Capitalization

Addressed separately in D14650 .

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14640

To: ngraham, #frameworks, #vdg
Cc: broulik, dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D14650: Use title case for some button labels

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: broulik, Frameworks.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Use title case for button labels, per 
https://community.kde.org/KDE_Visual_Design_Group/HIG/Capitalization

REPOSITORY
  R241 KIO

BRANCH
  title-case (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14650

AFFECTED FILES
  src/filewidgets/knewfilemenu.cpp

To: ngraham, broulik, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14640: Use appropriate icon for a cancel button that will ask for a new name

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> knewfilemenu.cpp:416
>  KGuiItem cancelGuiItem(KStandardGuiItem::cancel());
>  cancelGuiItem.setText(i18nc("@action:button", "Enter a different name"));
> +cancelGuiItem.setIcon(QIcon::fromTheme(QStringLiteral("edit-rename")));

Also this needs title capitalization [1]

[1] https://community.kde.org/KDE_Visual_Design_Group/HIG/Capitalization

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14640

To: ngraham, #frameworks, #vdg
Cc: broulik, dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D14610: Use KLineEdit for folder name if folder has write access, else use QLabel

[Nathaniel Graham]

ngraham added a comment.


  Late to the party here, but the read-only label needs to be selectable too. I 
submitted a patch for that: D14648 

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14610

To: shubham, rkflx, dfaure, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14648: Make read-only filenames selectable

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: shubham, Frameworks.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This patch makes read-only filenames (and summaries when selecting more than 
one item) selectable by the mouse and keyboard.

TEST PLAN
  Open the properties dialog for a read-only item or for multiple items and try 
to select the name or summary. You can.

REPOSITORY
  R241 KIO

BRANCH
  selectable-read-only-filename (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14648

AFFECTED FILES
  src/widgets/kpropertiesdialog.cpp

To: ngraham, shubham, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14610: Use KLineEdit for folder name if folder has write access, else use QLabel

[Nathaniel Graham]

ngraham added a task: T9297: Polish file/folder properties dialog.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14610

To: shubham, rkflx, dfaure, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14449: Modify device usage information

[Nathaniel Graham]

ngraham added a task: T9297: Polish file/folder properties dialog.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14449

To: shubham, ngraham, #frameworks, rkflx
Cc: pino, rkflx, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D14501: Top-align labels in properties dialog

[Nathaniel Graham]

ngraham added a task: T9297: Polish file/folder properties dialog.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14501

To: rkflx, dhaumann, ngraham, cfeck
Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

D14640: Use appropriate icon for a cancel button that will ask for a new name

[Nathaniel Graham]

ngraham added a comment.


  Yes indeed, oops. Corrected.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14640

To: ngraham, #frameworks, #vdg
Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D14640: Use appropriate icon for a cancel button that will ask for a new name

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14640

To: ngraham, #frameworks, #vdg
Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D14162: Figure out the escaped path list on kconfig

[Aleix Pol Gonzalez]

apol updated this revision to Diff 39182.
apol added a comment.


  Addressed issues by David and Anthony

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14162?vs=37886=39182

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14162

AFFECTED FILES
  autotests/kconfigtest.cpp
  src/core/kconfiggroup.cpp
  src/core/kconfigini.cpp

To: apol, #frameworks, dfaure
Cc: dfaure, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D14162: Figure out the escaped path list on kconfig

[Aleix Pol Gonzalez]

apol marked 3 inline comments as done.
apol added inline comments.

INLINE COMMENTS

> dfaure wrote in kconfiggroup.cpp:163
> I don't understand why this needs a vector. Isn't this only about consecutive 
> backslashes?
> Wouldn't a counter be enough?

We're extracting the whole string and then removing the escapes, we need to 
remember them all.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D14162

To: apol, #frameworks, dfaure
Cc: dfaure, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D14162: Figure out the escaped path list on kconfig

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kconfigtest.cpp:524
>  << "hostname[$e]=$(hostname)" << endl
> -<< "noeol=foo"; // no EOL
> +<< "noeol=foo" << endl // no EOL
> +<< "escapes=aaa,bb/b,ccc\\,ccc" << endl

You broke the "no EOL" testcase.
Please add yours before it.

> kconfiggroup.cpp:163
>  QStringList value;
> -QString val;
> -val.reserve(data.size());
> -bool quoted = false;
> -for (int p = 0; p < data.length(); p++) {
> -if (quoted) {
> -val += data[p];
> -quoted = false;
> -} else if (data[p].unicode() == '\\') {
> -quoted = true;
> -} else if (data[p].unicode() == ',') {
> -val.squeeze(); // release any unused memory
> -value.append(val);
> -val.clear();
> -val.reserve(data.size() - p);
> -} else {
> -val += data[p];
> +QVector escapedAt;
> +bool escapedLast = false;

I don't understand why this needs a vector. Isn't this only about consecutive 
backslashes?
Wouldn't a counter be enough?

> kconfigini.cpp:797
> +case ',':
> +// not really an escape sequence, but allowed in .desktop 
> files, don't strip '\;' from the string
> +*r = '\\';

Did you mean '\,' here?

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D14162

To: apol, #frameworks, dfaure
Cc: dfaure, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D14606: KCrash: DrKonqi cancelled = able to start...

[David Faure]

dfaure added a comment.


  We only stop printing it at the 4th recursion, I guess just in case that 
printing itself is the reason for the recursive crash...
  
if (crashRecursionCounter < 4) {
fprintf(stderr, "Unable to start Dr. Konqi\n");
}

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D14606

To: rjvbb, #frameworks, sitter
Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D14606: KCrash: DrKonqi cancelled = able to start...

[René J . V . Bertin]

rjvbb added a comment.


  >   I don't see why. We try to start drkonqi even the very first time.
  
  Yes, you'd print it if you're sure that first time failed (the start function 
got pid==0). I don't see the point in stopping to print it if you had a crash 
or two in the crash handler itself (supposing that crash is ever due to not 
being able to start DrKonqi of course).

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D14606

To: rjvbb, #frameworks, sitter
Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D14606: KCrash: DrKonqi cancelled = able to start...

[David Faure]

dfaure added a comment.


  I don't see why. We try to start drkonqi even the very first time.

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D14606

To: rjvbb, #frameworks, sitter
Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D14606: KCrash: DrKonqi cancelled = able to start...

[René J . V . Bertin]

rjvbb added a comment.


  >   The crash recursion counter is increased when a SEGV happens inside the 
crash handler itself.
  
  Yeah, that would make sense. But then wouldn't the "unable to start" message 
have to be printed when the recursion counter is larger than 2?

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D14606

To: rjvbb, #frameworks, sitter
Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D6512: Add support for proposed tags addition in OCS 1.7

[Dan Leinir Turthra Jensen]

leinir requested review of this revision.

REPOSITORY
  R235 Attica

REVISION DETAIL
  https://phabricator.kde.org/D6512

To: leinir, #knewstuff, apol, whiting, #kde_store, ahiemstra
Cc: cfeck, ahiemstra, ngraham, kde-frameworks-devel, #kde_store, michaelh, 
ZrenBot, bruns, akiraohgaki, alexanderschmidt, siyuandong, ronaldv, mikesomov, 
starbuck, sebas

D6512: Add support for proposed tags addition in OCS 1.7

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 39175.
leinir added a comment.


  Address comments by cfeck
  Also mark new public API as @since 5.50

REPOSITORY
  R235 Attica

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6512?vs=16200=39175

REVISION DETAIL
  https://phabricator.kde.org/D6512

AFFECTED FILES
  src/content.cpp
  src/content.h
  src/contentparser.cpp
  src/downloaddescription.cpp
  src/downloaddescription.h
  src/parser.cpp

To: leinir, #knewstuff, apol, whiting, #kde_store, ahiemstra
Cc: cfeck, ahiemstra, ngraham, kde-frameworks-devel, #kde_store, michaelh, 
ZrenBot, bruns, akiraohgaki, alexanderschmidt, siyuandong, ronaldv, mikesomov, 
starbuck, sebas

D6512: Add support for proposed tags addition in OCS 1.7

[Dan Leinir Turthra Jensen]

leinir marked 2 inline comments as done.

REPOSITORY
  R235 Attica

REVISION DETAIL
  https://phabricator.kde.org/D6512

To: leinir, #knewstuff, apol, whiting, #kde_store, ahiemstra
Cc: cfeck, ahiemstra, ngraham, kde-frameworks-devel, #kde_store, michaelh, 
ZrenBot, bruns, akiraohgaki, alexanderschmidt, siyuandong, ronaldv, mikesomov, 
starbuck, sebas

D6513: Add support for Attica tags support

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 39174.
leinir marked 3 inline comments as done.
leinir added a comment.


  Address the various comments by dfaure, cfeck and ngraham - with thanks!

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6513?vs=38506=39174

REVISION DETAIL
  https://phabricator.kde.org/D6513

AFFECTED FILES
  autotests/knewstuffentrytest.cpp
  src/attica/atticaprovider.cpp
  src/core/CMakeLists.txt
  src/core/engine.cpp
  src/core/engine.h
  src/core/entryinternal.cpp
  src/core/entryinternal.h
  src/core/provider.h
  src/core/tagsfilterchecker.cpp
  src/core/tagsfilterchecker.h
  src/staticxml/staticxmlprovider.cpp
  tests/CMakeLists.txt
  tests/khotnewstuff_test.cpp
  tests/khotnewstuff_test.knsrc.in
  tests/knewstuff2_test.cpp
  tests/knewstuff2_test.h
  tests/knewstuff2_test.knsrc
  tests/testdata/entry.xml
  tests/testdata/provider.xml

To: leinir, #knewstuff, apol, #kde_store, whiting, ahiemstra, mlaurent, dfaure
Cc: dfaure, cfeck, mlaurent, ngraham, ahiemstra, kde-frameworks-devel, 
#knewstuff, michaelh, ZrenBot, bruns

D6513: Add support for Attica tags support

[Dan Leinir Turthra Jensen]

leinir marked 17 inline comments as done.
leinir added inline comments.

INLINE COMMENTS

> dfaure wrote in engine.cpp:133
> That's out of bounds, if tagFilter is empty!! It will assert.
> 
> You meant append or push_back, I think.

i did indeed!

> dfaure wrote in engine.cpp:138
> !? What's the point in clearing a list that is already empty?

None at all - that would be a bit of leftovers, thanks for spotting that :)

> cfeck wrote in khotnewstuff_test.knsrc.in:3
> Do we still need the kalzium references?

No, i guess we don't, really... gone :)

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D6513

To: leinir, #knewstuff, apol, #kde_store, whiting, ahiemstra, mlaurent, dfaure
Cc: dfaure, cfeck, mlaurent, ngraham, ahiemstra, kde-frameworks-devel, 
#knewstuff, michaelh, ZrenBot, bruns

KDE CI: Frameworks kpackage kf5-qt5 AndroidQt5.11 - Build # 9 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20AndroidQt5.11/9/
 Project:
Frameworks kpackage kf5-qt5 AndroidQt5.11
 Date of build:
Mon, 06 Aug 2018 09:21:04 +
 Build duration:
2 min 30 sec and counting
   CONSOLE OUTPUT
  [...truncated 73.25 KB...]  "KF5DocTools_DIR" to a directory containing one of the above files.  If  "KF5DocTools" provides a separate development package or SDK, be sure it  has been installed.-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success-- Performing Test COMPILER_HAS_DEPRECATED_ATTR-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success-- The following REQUIRED packages have been found: * Qt5 (required version >= 5.8.0) * KF5Archive (required version >= 5.49.0) * Gettext * KF5I18n (required version >= 5.49.0) * KF5CoreAddons (required version >= 5.49.0) * ECM (required version >= 1.6.0), Extra CMake Modules.,  * Qt5Core * Qt5Test (required version >= 5.8.0)   Required for tests-- The following features have been disabled: * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)-- The following OPTIONAL packages have not been found: * KF5DocTools (required version >= 5.49.0), Tools to generate documentation-- Configuring done-- Generating done-- Build files have been written to: /home/user/workspace/Frameworks kpackage kf5-qt5 AndroidQt5.11/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[Frameworks kpackage kf5-qt5 AndroidQt5.11] Running shell script+ python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project kpackage --branchGroup kf5-qt5 --platform AndroidQt5.11 --usingInstall /home/user/install-prefix/Scanning dependencies of target mockhandler_autogenScanning dependencies of target testpackage-rccScanning dependencies of target KF5Package_autogen[  3%] Automatic MOC for target mockhandler[  3%] Generating testpackage-rcc/contents.rcc[  5%] Automatic MOC for target KF5Package[  5%] Built target mockhandler_autogen[  5%] Built target testpackage-rccScanning dependencies of target mockhandler[  8%] Building CXX object autotests/mockdepresolver/CMakeFiles/mockhandler.dir/main.cpp.o[  8%] Building CXX object autotests/mockdepresolver/CMakeFiles/mockhandler.dir/mockhandler_autogen/mocs_compilation.cpp.o[  8%] Built target KF5Package_autogen[ 10%] Automatic RCC for kpackage.qrcScanning dependencies of target KF5Package[ 13%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/packagestructure.cpp.o[ 13%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/package.cpp.o[ 15%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/packageloader.cpp.o[ 16%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/private/packages.cpp.o[ 18%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/private/packagejob.cpp.o[ 20%] Linking CXX executable ../../bin/mockhandler[ 20%] Built target mockhandler[ 22%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/private/packagejobthread.cpp.o[ 23%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/private/versionparser.cpp.o[ 25%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/version.cpp.o[ 27%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/kpackage_debug.cpp.o[ 28%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/KF5Package_autogen/mocs_compilation.cpp.o[ 30%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/KF5Package_autogen/EWIEGA46WW/qrc_kpackage.cpp.o[ 32%] Linking CXX shared library ../../bin/libKF5Package.so/home/user/install-prefix/include/KF5/KI18n/klocalizedstring.h:1340: error: undefined reference to 'ki18nd(char const*, char const*)'/home/user/install-prefix/include/KF5/KI18n/klocalizedstring.h:1340: error: undefined reference to 'KLocalizedString::toString() const'/home/user/install-prefix/include/KF5/KI18n/klocalizedstring.h:1340: error: undefined reference to 'KLocalizedString::~KLocalizedString()'/home/user/install-prefix/include/KF5/KI18n/klocalizedstring.h:1352: error: undefined reference to 'ki18nd(char const*, char const*)'/home/user/install-prefix/include/KF5/KI18n/klocalizedstring.h:1352: error: undefined reference to 'KLocalizedString::subs(QString const&, int, QChar) const'/home/user/install-prefix/include/KF5/KI18n/klocalizedstring.h:1352: error: undefined reference to 'KLocalizedString::subs(QString const&, int, QChar) const'/home/user/install-prefix/include/KF5/KI18n/klocalizedstring.h:1352: error: undefined reference to 'KLocalizedString::toString() const'/home/user/install-prefix/include/KF5/KI18n/klocalizedstring.h:1352: error: undefined reference to 'KLocalizedString::~KLocalizedString()'/home/user/install-prefix/include/KF5/KI18n/klocalizedstring.h:1352: error: undefined 

KDE CI: Frameworks kunitconversion kf5-qt5 AndroidQt5.11 - Build # 10 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kunitconversion%20kf5-qt5%20AndroidQt5.11/10/
 Project:
Frameworks kunitconversion kf5-qt5 AndroidQt5.11
 Date of build:
Mon, 06 Aug 2018 09:21:02 +
 Build duration:
43 sec and counting
   CONSOLE OUTPUT
  [...truncated 72.86 KB...] * Qt5Test * Qt5 (required version >= 5.8.0)-- The following features have been disabled: * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)-- Configuring done-- Generating doneCMake Warning:  Manually-specified variables were not used by the project:KF5_HOST_TOOLING-- Build files have been written to: /home/user/workspace/Frameworks kunitconversion kf5-qt5 AndroidQt5.11/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[Frameworks kunitconversion kf5-qt5 AndroidQt5.11] Running shell script+ python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project kunitconversion --branchGroup kf5-qt5 --platform AndroidQt5.11 --usingInstall /home/user/install-prefix/Scanning dependencies of target KF5UnitConversion_autogen[  2%] Automatic MOC for target KF5UnitConversion[  2%] Built target KF5UnitConversion_autogenScanning dependencies of target KF5UnitConversion[  4%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/converter.cpp.o[  7%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/value.cpp.o[  9%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/unit.cpp.o[ 11%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/unitcategory.cpp.o[ 14%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/length.cpp.o[ 16%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/area.cpp.o[ 19%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/volume.cpp.o[ 21%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/temperature.cpp.o[ 23%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/velocity.cpp.o[ 26%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/mass.cpp.o[ 28%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/pressure.cpp.o[ 30%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/energy.cpp.o[ 33%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/currency.cpp.o[ 35%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/power.cpp.o[ 38%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/timeunit.cpp.o[ 40%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/fuel_efficiency.cpp.o[ 42%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/density.cpp.o[ 45%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/acceleration.cpp.o[ 47%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/force.cpp.o[ 50%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/angle.cpp.o[ 52%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/frequency.cpp.o[ 54%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/thermal_conductivity.cpp.o[ 57%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/thermal_flux.cpp.o[ 59%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/thermal_generation.cpp.o[ 61%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/voltage.cpp.o[ 64%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/electrical_current.cpp.o[ 66%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/electrical_resistance.cpp.o[ 69%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/KF5UnitConversion_autogen/mocs_compilation.cpp.o[ 71%] Linking CXX shared library ../bin/libKF5UnitConversion.so/home/user/workspace/Frameworks kunitconversion kf5-qt5 AndroidQt5.11/src/unit.cpp:33: error: undefined reference to 'KLocalizedString::KLocalizedString()'/home/user/workspace/Frameworks kunitconversion kf5-qt5 AndroidQt5.11/src/unit.cpp:33: error: undefined reference to 'KLocalizedString::KLocalizedString()'/home/user/workspace/Frameworks kunitconversion kf5-qt5 AndroidQt5.11/src/unit.cpp:33: error: undefined reference to 'KLocalizedString::KLocalizedString()'/home/user/workspace/Frameworks kunitconversion kf5-qt5 AndroidQt5.11/src/unit.cpp:49: error: undefined reference to 'KLocalizedString::KLocalizedString(KLocalizedString const&)'/home/user/workspace/Frameworks kunitconversion kf5-qt5 AndroidQt5.11/src/unit.cpp:49: error: undefined reference to 'KLocalizedString::KLocalizedString(KLocalizedString const&)'/home/user/workspace/Frameworks kunitconversion kf5-qt5 AndroidQt5.11/src/unit.cpp:49: error: undefined reference to 'KLocalizedString::KLocalizedString(KLocalizedString const&)'/home/user/workspace/Frameworks kunitconversion kf5-qt5 AndroidQt5.11/src/unit.cpp:53: error: undefined reference to 'KLocalizedString::~KLocalizedString()'/home/user/workspace/Frameworks kunitconversion kf5-qt5 AndroidQt5.11/src/unit.cpp:53: error: undefined reference to 'KLocalizedString::~KLocalizedString()'/home/user/workspace/Frameworks kunitconversion kf5-qt5 

Re: purpose unittest (AlternativesModelTest::runJobTest) fails randomly

[David Faure]

On lundi 6 août 2018 10:52:52 CEST Ben Cooksley wrote:
> On Mon, Aug 6, 2018 at 7:27 PM, David Faure  wrote:
> > On lundi 6 août 2018 01:18:44 CEST Aleix Pol wrote:
> >> On Sat, Aug 4, 2018 at 12:31 PM David Faure  wrote:
> >> > Any idea about this test that fails sometimes? Timing issue? The wait()
> >> > should be longer in case of slow network?
> >> > 
> >> > https://build.kde.org/view/Frameworks/job/Frameworks%20purpose%20kf5-qt
> >> > 5%2
> >> > 0SUSEQt5.10/92/testReport/junit/(root)/TestSuite/alternativesmodeltest/
> >> 
> >> Hi,
> >> Yes, I looked into fixing it, it seemed like it was but then it wasn't
> >> (yay randomness!).
> >> 
> >> My guess is that it's because kf5.kio.core.copyjob prints the whole
> >> URL which in this case it's a data one (which I tried to fix in
> >> 64492796aa7ca4b63dbae419f47e14da15fbcc51). I failed because it still
> >> prints I added "+
> >> QLoggingCategory::setFilterRules(QStringLiteral("kf5.kio.core.copyjob=fal
> >> se" ));" I'm not sure why this has the effect I hoped it would. Any
> >> ideas?> 
> > If $QT_LOGGING_RULES is set to something like '*.debug=true" then this
> > overrides anything you do programmatically with setFilterRules.
> > 
> > I'm not sure if that's what the CI does, though?
> 
> The CI sets QT_LOGGING_RULES exactly as you describe :)
> This is done at
> https://cgit.kde.org/sysadmin/ci-tooling.git/tree/helpers/run-tests.py#n79

OK, thanks.

> > I guess one possible fix would be a shortenUrl() helper in KIO's
> > copyjob.cpp to never print out such a long URL in full (sounds like this
> > would be useful for developers too, not just for CI...).

Actually the right fix would be:
https://codereview.qt-project.org/236112

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

Re: purpose unittest (AlternativesModelTest::runJobTest) fails randomly

[Ben Cooksley]

On Mon, Aug 6, 2018 at 7:27 PM, David Faure  wrote:
> On lundi 6 août 2018 01:18:44 CEST Aleix Pol wrote:
>> On Sat, Aug 4, 2018 at 12:31 PM David Faure  wrote:
>> > Any idea about this test that fails sometimes? Timing issue? The wait()
>> > should be longer in case of slow network?
>> >
>> > https://build.kde.org/view/Frameworks/job/Frameworks%20purpose%20kf5-qt5%2
>> > 0SUSEQt5.10/92/testReport/junit/(root)/TestSuite/alternativesmodeltest/
>> Hi,
>> Yes, I looked into fixing it, it seemed like it was but then it wasn't
>> (yay randomness!).
>>
>> My guess is that it's because kf5.kio.core.copyjob prints the whole
>> URL which in this case it's a data one (which I tried to fix in
>> 64492796aa7ca4b63dbae419f47e14da15fbcc51). I failed because it still
>> prints I added "+
>> QLoggingCategory::setFilterRules(QStringLiteral("kf5.kio.core.copyjob=false"
>> ));" I'm not sure why this has the effect I hoped it would. Any ideas?
>
> If $QT_LOGGING_RULES is set to something like '*.debug=true" then this
> overrides anything you do programmatically with setFilterRules.
>
> I'm not sure if that's what the CI does, though?

The CI sets QT_LOGGING_RULES exactly as you describe :)
This is done at
https://cgit.kde.org/sysadmin/ci-tooling.git/tree/helpers/run-tests.py#n79

>
> I guess one possible fix would be a shortenUrl() helper in KIO's copyjob.cpp
> to never print out such a long URL in full (sounds like this would be useful
> for developers too, not just for CI...).
>
> --
> David Faure, fa...@kde.org, http://www.davidfaure.fr
> Working on KDE Frameworks 5
>
>
>

Cheers,
Ben

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 350 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/350/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 06 Aug 2018 07:57:53 +
 Build duration:
18 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 58 test(s), Skipped: 0 test(s), Total: 59 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesviewtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)65%
(258/396)65%
(258/396)53%
(31898/59909)38%
(16123/42678)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(55/55)100%
(55/55)95%
(9025/9455)51%
(3927/7716)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core84%
(98/116)84%
(98/116)58%
(8285/14356)50%
(4637/9285)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3894/7924)34%
(1586/4669)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(528/1015)39%
(316/814)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1364)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/245)0%
(0/144)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4320)35%
(1306/3700)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1331)55%
(620/1123)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/257)7%
(14/212)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash56%
(5/9)56%
(5/9)52%

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 195 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/195/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 06 Aug 2018 07:57:53 +
 Build duration:
9 min 25 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 59 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesviewtestFailed: TestSuite.kiofilewidgets-kfilewidgettest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)65%
(258/396)65%
(258/396)53%
(31964/59912)38%
(16148/42676)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(55/55)100%
(55/55)95%
(9025/9455)51%
(3930/7716)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core84%
(98/116)84%
(98/116)58%
(8342/14358)50%
(4658/9289)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3911/7925)34%
(1593/4669)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(527/1015)39%
(315/814)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1364)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/245)0%
(0/144)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1775/4320)35%
(1304/3700)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(629/1331)55%
(619/1123)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/257)7%
(14/212)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash56%
(5/9)56%
 

D14632: keyword rule: Spport for keywords inclusion from another language/file

[Christoph Cullmann]

cullmann added a comment.


  Great ;) I assume we can handle the missing things during that week for a 
real switch.
  
  ATM the basics already work, there are just some missing extras.
  (and the color configuration is a mess)
  
  If you have some time to take a look at the syntax-highlighting branch, any 
feedback is welcome, perhaps I already misuse the API.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14632

To: jpoelen, #framework_syntax_highlighting, cullmann, dhaumann
Cc: kwrite-devel, vkrause, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 105 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/105/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.10
 Date of build:
Mon, 06 Aug 2018 07:57:53 +
 Build duration:
8 min 46 sec and counting
   JUnit Tests
  Name: (root) Failed: 5 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiofilewidgets-kfileplacesviewtestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

D14632: keyword rule: Spport for keywords inclusion from another language/file

[Volker Krause]

vkrause added a comment.


  In D14632#304149 , @cullmann wrote:
  
  > Volker, are you at the conference next week?
  
  
  Sure, I'll be there for the entire week.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14632

To: jpoelen, #framework_syntax_highlighting, cullmann, dhaumann
Cc: kwrite-devel, vkrause, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D14632: keyword rule: Spport for keywords inclusion from another language/file

[Dominik Haumann]

dhaumann added a comment.


  @jpoelen When adding such functionality, could you also also explain in the 
log message *why* this change is required or useful? I think we should have 
real-world use cases before integrating this. But in general, looks good.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14632

To: jpoelen, #framework_syntax_highlighting, cullmann, dhaumann
Cc: kwrite-devel, vkrause, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D14632: keyword rule: Spport for keywords inclusion from another language/file

[Christoph Cullmann]

cullmann added a comment.


  I think this needs to wait with merging until we finalized the usage of the 
syntax-highlighting framework in ktexteditor.
  Volker, are you at the conference next week?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14632

To: jpoelen, #framework_syntax_highlighting, cullmann, dhaumann
Cc: kwrite-devel, vkrause, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D14610: Use KLineEdit for folder name if folder has write access, else use QLabel

[Shubham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:e2c56f6ddc51: Use KLineEdit for folder name if folder has 
write access, else use QLabel (authored by shubham).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14610?vs=39164=39166

REVISION DETAIL
  https://phabricator.kde.org/D14610

AFFECTED FILES
  src/widgets/kpropertiesdialog.cpp

To: shubham, rkflx, dfaure, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14610: Use KLineEdit for folder name if folder has write access, else use QLabel

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  I disagree that it's more readable, but let's not nitpick :-)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14610

To: shubham, rkflx, dfaure, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14610: Use KLineEdit for folder name if folder has write access, else use QLabel

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  (oops, misclicked)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14610

To: shubham, rkflx, dfaure, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14457: Forward-declare X509 structure

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  Can you explain why in the commit log, not just what? The diff tells us what 
already, but why? I assume this fixes a compilation error? Which one, on which 
platform? Thanks.

REPOSITORY
  R239 KDELibs4Support

REVISION DETAIL
  https://phabricator.kde.org/D14457

To: luc4, #frameworks, cfeck, dfaure
Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 194 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/194/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 06 Aug 2018 07:14:37 +
 Build duration:
30 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 58 test(s), Skipped: 0 test(s), Total: 59 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesviewtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)65%
(258/396)65%
(258/396)53%
(31972/59913)38%
(16154/42670)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(55/55)100%
(55/55)95%
(9025/9455)51%
(3931/7716)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core84%
(98/116)84%
(98/116)58%
(8356/14358)50%
(4664/9289)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3894/7924)34%
(1586/4669)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(528/1015)39%
(316/814)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1364)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/245)0%
(0/144)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4320)35%
(1306/3700)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(629/1331)55%
(619/1123)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/257)7%
(14/212)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash56%
(5/9)56%
(5/9)52%