D14526: AppArmor: update syntax and various improvements/fixes

nibags closed this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14526 To: nibags, #framework_syntax_highlighting, #kate, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars,

D14526: AppArmor: update syntax and various improvements/fixes

nibags updated this revision to Diff 39550. nibags added a comment. Fix conflicts in references. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14526?vs=39549=39550 REVISION DETAIL https://phabricator.kde.org/D14526 AFFECTED FILES

D13869: [solid] Notify when interface to mounted fs is lost

anthonyfieroni abandoned this revision. anthonyfieroni added a comment. https://phabricator.kde.org/D14661 REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D13869 To: anthonyfieroni, broulik, cfeck, dfaure, bruns Cc: ngraham, bcooksley, bruns, kde-frameworks-devel,

D14661: Force reevaluation of Predicates if interfaces are removed

anthonyfieroni added a comment. Ok, +1 then. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D14661 To: bruns, #frameworks, broulik, ngraham Cc: anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D14526: AppArmor: update syntax and various improvements/fixes

nibags updated this revision to Diff 39549. nibags added a comment. - Update references. Regenerate file "autotest/reference/usr.bin.apparmor-profile-test.ref" REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14526?vs=38880=39549 BRANCH

D14702: Java: add binaries & hex-float, and support underscores in numbers

nibags closed this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14702 To: nibags, dhaumann, cullmann, vkrause, #kate Cc: ngraham, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, bruns, demsking, cullmann, sars, dhaumann

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 - Build # 49 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.9/49/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 Date of build: Sun, 12 Aug 2018 11:28:34 + Build duration: 3 min 13 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 104 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/104/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Sun, 12 Aug 2018 11:28:34 + Build duration: 6 min 35 sec and counting JUnit Tests

D14593: Update Logtalk language syntax support

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. Thanks for the contribution. I think the version=... should just be an integer, just increment it by one. Beside that, it would be very nice to have some test file in the

D14757: Warn user before copy operation if available space is not enough

dfaure added a comment. You can just emit the warning signal, from the job. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14757 To: shubham, broulik, ngraham, pino Cc: dfaure, pino, kde-frameworks-devel, michaelh, ngraham, bruns

D14661: Force reevaluation of Predicates if interfaces are removed

bruns added inline comments. INLINE COMMENTS > anthonyfieroni wrote in udisksmanager.cpp:239 > Your code seems to work, but i don't get it - why device is added again? How > predicate will work on removed device? Adding it again allows the Predicate to determine if this device is still

D4716: Add some more directives to MIPS assembler highlighting

dhaumann added a comment. Restricted Application added a project: Kate. Restricted Application edited subscribers, added: kde-frameworks-devel, kwrite-devel; removed: Frameworks. Could you provide a test snippet now? I will integrate this then. REPOSITORY R216 Syntax Highlighting REVISION

D14758: use view lines for wheel scrolling, not real lines

ngraham added a comment. Thanks for the patch, Sven! There are two issues with scrolling: 1. Multi-line strings are inappropriately treated as a single line for the purposes of scrolling 2. Lack of per-pixel scrolling that touchpad users expect. This patch fixes #1, but not

D7033: Port ki18n from QtScript to QtQml

carewolf added a comment. I solved the Ts.acall. Unfortunately I forgot how arc works, so it became a new entry https://phabricator.kde.org/D14769 REVISION DETAIL https://phabricator.kde.org/D7033 To: carewolf, ilic Cc: kde-frameworks-devel, huftis, ngraham, dhaumann, ltoscano, kfunk,

D14757: Warn user before copy operation if available space is not enough

shubham edited reviewers, added: dfaure; removed: broulik, ngraham. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14757 To: shubham, pino, dfaure, broulik Cc: dfaure, pino, kde-frameworks-devel, michaelh, ngraham, bruns

D14757: Warn user before copy operation if available space is not enough

pino requested changes to this revision. pino added a comment. This revision now requires changes to proceed. Hint: please make sure you build **and** test the next versions of your patches, otherwise it is just a waste of everybody's time. INLINE COMMENTS > copyjob.cpp:891 > +if

D14762: Proposal: Add "None" highlighting to repository per default

cullmann updated this revision to Diff 39515. cullmann added a comment. Fixes translation + code editor example. No special handling needed there (+ fix for section without name) REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D7033: Port ki18n from QtScript to QtQml

carewolf updated this revision to Diff 39526. carewolf added a comment. Fixed acall using a pure javascript bridge REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7033?vs=39460=39526 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7033

D14763: Definition: Expose command markers

dhaumann created this revision. dhaumann added reviewers: cullmann, vkrause. Restricted Application added projects: Kate, Frameworks. Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. dhaumann requested review of this revision. REVISION SUMMARY Added functios

D14639: Add syntax-highlighting for RDoc (R documentation)

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Looks ok, thanks for the contribution. REPOSITORY R216 Syntax Highlighting BRANCH rdoc REVISION DETAIL https://phabricator.kde.org/D14639 To: aaronpuchert, dhaumann, cullmann

D14632: keyword rule: Spport for keywords inclusion from another language/file

cullmann added a comment. I would like a name##language approach more, as then one could even nicely extend the included lists and as one is forced to have some list around it, they will show up in the kewordLists automatically. We make nice progress with

D14758: use view lines for wheel scrolling, not real lines

dhaumann added a subscriber: ngraham. dhaumann added a comment. Not yet thoroughly reviewed, but some thoughts: - There is a bug report for this: https://bugs.kde.org/show_bug.cgi?id=256561 Could you verify that the issues in the bug report are addressed by this patch? See also the

D14743: Copy PlasmaCore binary qmldir file structure into bin for unit testsThis way tests pass before installation.

davidedmundson marked 2 inline comments as done. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D14743 To: davidedmundson, #plasma, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14236: Add some improvements to kate-syntax-highlighter for use in scripting

dhaumann added a reviewer: vkrause. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14236 To: xciml, #framework_syntax_highlighting, vkrause Cc: kde-frameworks-devel, kwrite-devel, #framework_syntax_highlighting, michaelh, genethomas, kevinapavew, ngraham,

D14762: Proposal: Add "None" highlighting to repository per default

cullmann created this revision. cullmann added reviewers: vkrause, dhaumann. Restricted Application added projects: Kate, Frameworks. Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. cullmann requested review of this revision. REVISION SUMMARY Rational: e.g.

D14760: YAML: fix keys, add numbers and other improvements

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. The screenshots look convincing! REPOSITORY R216 Syntax Highlighting BRANCH fix-yaml REVISION DETAIL https://phabricator.kde.org/D14760 To: nibags, dhaumann, cullmann,

D13940: Add syntax highlighting support for Stan

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Restricted Application added a project: Kate. Restricted Application added a subscriber: kwrite-devel. Looks ok, should I push that for you as "Jeffrey Arnold "? REPOSITORY R216

D14763: Definition: Expose command markers

dhaumann added a comment. @vkrause We simply decided to commit this now. But a review from your side is still appreciated ;) REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14763 To: dhaumann, cullmann, vkrause Cc: kwrite-devel, kde-frameworks-devel,

D14769: Port ki18n from QtScript to QtQml

carewolf created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. carewolf requested review of this revision. REVISION SUMMARY Moves away from the deprecated QtScript module Change-Id:

D14702: Java: add binaries & hex-float, and support underscores in numbers

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Looks reasonable. REPOSITORY R216 Syntax Highlighting BRANCH java-improve-numbers REVISION DETAIL https://phabricator.kde.org/D14702 To: nibags, dhaumann, cullmann, vkrause,

D14760: YAML: fix keys, add numbers and other improvements

nibags closed this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14760 To: nibags, dhaumann, cullmann, #framework_syntax_highlighting Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars,

D14603: SCSS: update syntax. CSS: fix Operator and Selector Tag highlighting

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. I would be for merging this and later replacing with the include list stuff. REPOSITORY R216 Syntax Highlighting BRANCH scss REVISION DETAIL https://phabricator.kde.org/D14603

D14757: Warn user before copy operation if available space is not enough

shubham updated this revision to Diff 39531. shubham added a comment. use simpleJobPrivate REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14757?vs=39492=39531 REVISION DETAIL https://phabricator.kde.org/D14757 AFFECTED FILES src/core/CMakeLists.txt

D14757: Warn user before copy operation if available space is not enough

shubham added a comment. @dfaure is it that message boxes cant be used in non gui library as suggested by pino. Is there any harm in using kmessagebox instead? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14757 To: shubham, broulik, ngraham, pino Cc: dfaure, pino,

D14308: [Exe Thumbnailer] Improve icon selection algorithm

broulik updated this revision to Diff 39519. broulik edited the summary of this revision. broulik added a comment. I found a way to get the actual depth of the icon extracted - Prefer higher DPI as well REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE

D14773: completion widget: fix minimum header section size

dhaumann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D14773 To: brauch, #kate, dhaumann Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann,

D14769: Port ki18n from QtScript to QtQml

carewolf added a reviewer: ilic. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D14769 To: carewolf, ilic Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14526: AppArmor: update syntax and various improvements/fixes

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Has tests, looks ok. Thanks! REPOSITORY R216 Syntax Highlighting BRANCH update-apparmor REVISION DETAIL https://phabricator.kde.org/D14526 To: nibags,

D14763: Definition: Expose command markers

This revision was automatically updated to reflect the committed changes. Closed by commit R216:7a8843f171e8: Definition: Expose command markers (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14763?vs=39512=39545 REVISION

D14763: Definition: Expose command markers

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. > I think that is ok REPOSITORY R216 Syntax Highlighting BRANCH expose-comment-markers (branched from master) REVISION DETAIL

D14762: Proposal: Add "None" highlighting to repository per default

cullmann updated this revision to Diff 39522. cullmann added a comment. make test shall work again ;=) REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14762?vs=39515=39522 REVISION DETAIL https://phabricator.kde.org/D14762 AFFECTED FILES

D14762: Proposal: Add "None" highlighting to repository per default

cullmann added a comment. :=) Perhaps I should fix the unit tests, too. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14762 To: cullmann, vkrause, dhaumann Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking,

D14772: Deprecate KFilterProxySearchLine

svuorela created this revision. svuorela added reviewers: kossebau, dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. svuorela requested review of this revision. REVISION SUMMARY It is too primitive and simple for

D14674: handle non-ASCII encodings of file names in tar archives

ibragimovrinat marked 2 inline comments as done. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D14674 To: ibragimovrinat, dfaure, kossebau Cc: xyquadrat, broulik, cfeck, ibragimovrinat, kde-frameworks-devel, michaelh, ngraham, bruns

D7033: Port ki18n from QtScript to QtQml

carewolf added a comment. Note the latest patch still has a maximum number of arguments for acall. I checked all the usages, and the only place that uses acall with a variable set of arguments is the sr (Serbian) translation. Since supporting a variable number of arguments would require

D14692: Use custom QScrollArea with size hint not limited by font size

valeriymalov added a comment. I don't know, it's frameworks after all but I guess I can land it today since it's a popular bug. Should I just land it on master since there seem to be no other branches? REPOSITORY R295 KCMUtils BRANCH master REVISION DETAIL

D12662: Add InlineNoteInterface

brauch added a comment. Restricted Application edited subscribers, added: kde-frameworks-devel, kwrite-devel; removed: Frameworks. Hey there, what's happening to this? I think this is a really nice feature and it would be very sad if it would bitrot :( Anything anyone can assist with? We

D14769: Port ki18n from QtScript to QtQml

carewolf abandoned this revision. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D14769 To: carewolf, ilic Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14757: Warn user before copy operation if available space is not enough

shubham added a comment. In D14757#306938 , @pino wrote: > Also, considering this is in a job in `KIOCore` (i.e. non-gui library), I suspect that using a message box directly is the wrong way to do it. @dfaure what is your opinion on that?

D14758: use view lines for wheel scrolling, not real lines

brauch added a comment. The "overly sensitive touchpad" issue seems to be missing accumulation of scroll events, so this patch to my understanding should not have it. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D14758 To: brauch, dhaumann Cc: ngraham,

D14707: autotests: skip '/' fstab check with zfs

dfaure added a comment. The check is trying to verify that possibleMountPoints() works, by picking a mount point that we know has to exist, the root mount point. Anything else is hard to rely on, in a unittest ;) At least that was the logic in the old days, before all this magic that

D14762: Proposal: Add "None" highlighting to repository per default

cullmann added a comment. Problem: How to get the "None" into the translation catalog? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14762 To: cullmann, vkrause, dhaumann Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns,

D14760: YAML: fix keys, add numbers and other improvements

nibags edited the summary of this revision. nibags added reviewers: dhaumann, cullmann, Framework: Syntax Highlighting. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14760 To: nibags, dhaumann, cullmann, #framework_syntax_highlighting Cc: kwrite-devel,

D14674: handle non-ASCII encodings of file names in tar archives

ibragimovrinat updated this revision to Diff 39537. ibragimovrinat added a comment. Updated diff to use QString everywhere instead of QStringLiteral and QLatin1String. As those are in tests, performance penalty shouldn't matter. Also using QCOMPARE for comparisons. REPOSITORY R243

D14236: Add some improvements to kate-syntax-highlighter for use in scripting

pino added inline comments. INLINE COMMENTS > htmlhighlighter.h:42-43 > void highlightFile(const QString ); > +void highlightFile(const QString , const QString ); > +void highlightFile(QFile , const QString ); > Instead of both the variants, what about a single one with

D14758: use view lines for wheel scrolling, not real lines

brauch added a comment. I will modify the commit message as suggested. I read through the bug report, and I think this patch does fix the main issue discussed there. The patch suggested by one user there is even quite similar (if a bit less complete) than this one. The original

D14763: Definition: Expose command markers

cullmann added a comment. Ok with that Volker? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14763 To: dhaumann, cullmann, vkrause Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann

D14773: completion widget: fix minimum header section size

brauch created this revision. brauch added a reviewer: Kate. Restricted Application added projects: Kate, Frameworks. Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. brauch requested review of this revision. REVISION SUMMARY The header is hidden, but if the minimum

D14593: Update Logtalk language syntax support

nibags added reviewers: dhaumann, cullmann, vkrause, Framework: Syntax Highlighting, Kate. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14593 To: pmoura, dhaumann, cullmann, vkrause, #framework_syntax_highlighting, #kate Cc: kwrite-devel,

D14760: YAML: fix keys, add numbers and other improvements

nibags created this revision. Restricted Application added projects: Kate, Frameworks. Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY Fix some reported bugs and update the syntax for YAML 1.2: - Fixes

D14763: Definition: Expose command markers

cullmann added a comment. I think later we should check for not more than one marker per type in the files, but otherwise that is ok for me now. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14763 To: dhaumann, cullmann, vkrause Cc: kwrite-devel,

D14757: Warn user before copy operation if available space is not enough

dfaure added a comment. Yes, Pino is right. Trust Pino ;) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14757 To: shubham, broulik, ngraham, pino Cc: dfaure, pino, kde-frameworks-devel, michaelh, ngraham, bruns

D14757: Warn user before copy operation if available space is not enough

dfaure added a comment. Ah, hmm, my suggestion would allow to display a warning messagebox, but not to offer "continue/cancel" type of interaction. You can use SimpleJobPrivate::requestMessageBox instead, with the type argument set to JobUiDelegateExtension::WarningContinueCancel,

D14743: Copy PlasmaCore binary qmldir file structure into bin for unit testsThis way tests pass before installation.

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > CMakeLists.txt:80 > +COMMAND ${CMAKE_COMMAND} -E > +copy > ${CMAKE_BINARY_DIR}/bin/libcorebindingsplugin.so >

Re: purpose unittests on Windows

On samedi 11 août 2018 07:02:18 CEST Ben Cooksley wrote: > On Fri, Aug 10, 2018 at 7:28 PM David Faure wrote: > > Any idea why purpose can't find the KIO http and file protocols -- on > > Windows? > > > > https://build.kde.org/view/Frameworks/job/Frameworks%20purpose%20kf5-qt5%2 > >

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 - Build # 48 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.9/48/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 Date of build: Sun, 12 Aug 2018 09:26:53 + Build duration: 3 min 23 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 103 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/103/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Sun, 12 Aug 2018 09:26:53 + Build duration: 3 min 14 sec and counting JUnit Tests

D14674: handle non-ASCII encodings of file names in tar archives

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Great job, thanks for the unittest. Just a few minor adjustments and this is good to go in. INLINE COMMENTS > karchivetest.cpp:776 > +const QString longName = > +

D14757: Warn user before copy operation if available space is not enough

shubham added a comment. In D14757#306938 , @pino wrote: > Also, considering this is in a job in `KIOCore` (i.e. non-gui library), I suspect that using a message box directly is the wrong way to do it. Most probably you need to use the UI

D14759: Add bool Definition::isWordWrapDelimiter(QChar)

This revision was automatically updated to reflect the committed changes. Closed by commit R216:b422c7e3732a: Add bool Definition::isWordWrapDelimiter(QChar) (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D14759: Add bool Definition::isWordWrapDelimiter(QChar)

cullmann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH add-word-wrap-delimiter (branched from master) REVISION DETAIL https://phabricator.kde.org/D14759 To: dhaumann, vkrause, cullmann Cc: kwrite-devel,

D14759: Add bool Definition::isWordWrapDelimiter(QChar)

dhaumann updated this revision to Diff 39501. dhaumann added a comment. - Compile ;) REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14759?vs=39500=39501 BRANCH add-word-wrap-delimiter (branched from master) REVISION DETAIL

D14759: Add bool Definition::isWordWrapDelimiter(QChar)

dhaumann created this revision. dhaumann added reviewers: vkrause, cullmann. Restricted Application added projects: Kate, Frameworks. Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. dhaumann requested review of this revision. REVISION SUMMARY Checking word wrap

D14757: Warn user before copy operation if available space is not enough

pino requested changes to this revision. pino added a comment. This revision now requires changes to proceed. Also, considering this is in a job in `KIOCore` (i.e. non-gui library), I suspect that using a message box directly is the wrong way to do it. Most probably you need to use the UI

D14758: use view lines for wheel scrolling, not real lines

brauch created this revision. brauch added a reviewer: dhaumann. Restricted Application added projects: Kate, Frameworks. Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. brauch requested review of this revision. REVISION SUMMARY I don't think there is an ideal

D14757: Warn user before copy operation if available space is not enough

shubham created this revision. shubham added reviewers: broulik, ngraham. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. shubham requested review of this revision. REPOSITORY R241 KIO REVISION DETAIL

D14661: Force reevaluation of Predicates if interfaces are removed

anthonyfieroni added inline comments. INLINE COMMENTS > udisksmanager.cpp:239 > +emit deviceRemoved(udi); > +emit deviceAdded(udi); > } Your code seems to work, but i don't get it - why device is added again? How predicate will work on removed device? REPOSITORY R245