KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 379 - Unstable!

2018-08-21 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/379/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 22 Aug 2018 03:45:41 +
 Build duration:
8 min 23 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 58 test(s), Skipped: 0 test(s), Total: 59 test(s)Failed: TestSuite.kiofilewidgets-kfilewidgettest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)65%
(258/396)65%
(258/396)53%
(31912/59935)38%
(16473/43902)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(55/55)100%
(55/55)95%
(9039/9469)48%
(4275/8920)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core84%
(98/116)84%
(98/116)58%
(8286/14358)50%
(4644/9289)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3893/7926)34%
(1585/4669)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(527/1022)38%
(315/830)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1364)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/245)0%
(0/144)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1775/4320)35%
(1304/3700)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1331)55%
(620/1123)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/257)7%
(14/212)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash56%
(5/9)56%
(5/9)51%
  

D14237: Make Konqi look good in HiDPI

2018-08-21 Thread Stefan Brüns
bruns added a comment.


  There was some cruft in the file (empty layers, unused definitions ...)
  F6208866: src_aboutkde.svg 

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D14237

To: ngraham, broulik, cfeck, #frameworks, #vdg, bruns
Cc: aacid, bruns, kde-frameworks-devel, michaelh, ngraham


D14908: Bindings: Add support for scoped enums

2018-08-21 Thread Stefan Brüns
bruns planned changes to this revision.
bruns added a comment.


  Ok, then I will update the requirements in the clang check.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D14908

To: bruns, #frameworks
Cc: mpyne, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns


D14908: Bindings: Add support for scoped enums

2018-08-21 Thread Michael Pyne
mpyne added a comment.


  As long as older versions of LLVM result in the Python binding generation 
step being skipped completely (we already check for libclang in the 
find-package for this, right?), I don't think the dependency increase is a 
problem.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D14908

To: bruns, #frameworks
Cc: mpyne, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns


D14984: Explicitly request Qt 5.7's QtQuick to make use of Connections.enabled

2018-08-21 Thread Michael Pyne
mpyne created this revision.
mpyne added reviewers: Frameworks, Plasma, mart.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
mpyne requested review of this revision.

REVISION SUMMARY
  I recently rebuilt my Qt, KF5, and Plasma 5 environments from scratch. I 
noticed that System Settings no longer started.
  
  It took me a while to figure out the error message but the proximate issue 
ended up being:
  

file:///home/kde-svn/kde-5/lib64/qml/org/kde/kirigami.2/templates/private/ScrollView.qml:95:9:
 
"Connections.enabled" is not available in QtQuick 2.5. 
 enabled: !Settings.tabletMode 
 ^
  
  I imagine that Qt 5 has stricter checking on the use of QML properties. In 
this case we ask for QtQuick as of Qt 5.5, but Connections.enabled is only 
supported in Qt 5.7 on.
  
  I fixed this (and one other such usage) by changing the import statement to 
ask for QtQuick 5.7. We already require at least Qt 5.7 anyways so this isn't a 
new dependency for current KF5.

TEST PLAN
  Installed the updated Kirigami, successfully launched System Settings. 
Additionally the Plasma desktop wallpaper started working again too, though 
that wasn't why I'd made this fix.
  
  I verified by manual inspection of all uses of the 'Connection' QML item that 
there were no other uses of the "enabled" property from Qt 5.7.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D14984

AFFECTED FILES
  src/controls/private/RefreshableScrollView.qml
  src/controls/templates/private/ScrollView.qml

To: mpyne, #frameworks, #plasma, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein


D13627: [KSharedDataCache] Assume lock before flush changes

2018-08-21 Thread Michael Pyne
mpyne accepted this revision.
mpyne added a comment.


  This change has worked fine for me in my testing (including KDE games and 
Plasma themes) so I think it's fine to commit.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D13627

To: anthonyfieroni, davidedmundson, dfaure, #frameworks, hein, mpyne
Cc: mpyne, hein, kde-frameworks-devel, michaelh, ngraham, bruns


D14983: Set breeze as fallback icon theme

2018-08-21 Thread Albert Astals Cid
aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

TEST PLAN
  Ran okular with QT_QPA_PLATFORMTHEME=gtk3 with and without this patch.  With 
icons show up everywhere and looks generally nicer :)

REPOSITORY
  R302 KIconThemes

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14983

AFFECTED FILES
  src/kicontheme.cpp

To: aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D14971: Combine display OSD icon files and move to plasma icon theme

2018-08-21 Thread Nathaniel Graham
ngraham added a comment.


  When I apply this patch and compile and deploy plasma-framework to `/usr/` 
and then delete the Breeze icons versions, I still don't see the new icons in 
the switcher. What am I doing wrong?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D14971

To: pstefan, ngraham, #vdg, broulik
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns


D14966: Added support for disabling the loading of translations

2018-08-21 Thread Albert Astals Cid
aacid added a comment.


  I personally don't think this is the way to go and as said many times think 
that loading a custom translation for tests like ki18n way does is the way to 
go.
  
  Your issue with that seems to be that it won't work on windows, well then i'd 
say skip the test on windows until Qt gets better at it.
  
  But if someone else approves i'm not going to block on it.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D14966

To: habacker, aacid, dfaure
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns


D14967: Disable loading of translations for kformattest, which was not designed with translations

2018-08-21 Thread Albert Astals Cid
aacid added a comment.


  I personally don't think this is the way to go and as said many times think 
that loading a custom translation for tests like ki18n way does is the way to 
go.
  
  Your issue with that seems to be that it won't work on windows, well then i'd 
say skip the test on windows until Qt gets better at it.
  
  But if someone else approves i'm not going to block on it.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D14967

To: habacker, dfaure, aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D14940: kformattest: Use plural suffix (s) consequently

2018-08-21 Thread Albert Astals Cid
aacid requested changes to this revision.
aacid added a comment.
This revision now requires changes to proceed.


  This is not how plurals for decimals work, they are always in plural.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D14940

To: habacker, aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D14978: Add unit test that checks Format data

2018-08-21 Thread Dominik Haumann
dhaumann added a comment.


  The problem likely was that Alerts.xml does not have the 
indentationBasedFolding attribute set. But it's needed in e.g. Python.
  
dh@eriador:syntax :-) (check-full-formats) $ grep Alerts_indent *
alert_indent.xml:
coffee.xml:
coffee.xml:
pig.xml:
prolog.xml: 
prolog.xml: 
python.xml: 
python.xml: 
python.xml: 
python.xml: 

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14978

To: dhaumann, cullmann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann


D14978: Add unit test that checks Format data

2018-08-21 Thread Dominik Haumann
dhaumann updated this revision to Diff 40172.
dhaumann added a comment.


  - Simplify code

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14978?vs=40167=40172

BRANCH
  check-full-formats (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14978

AFFECTED FILES
  autotests/syntaxrepository_test.cpp

To: dhaumann, cullmann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann


D14978: Add unit test that checks Format data

2018-08-21 Thread Christoph Cullmann
cullmann added a comment.


  Given that hl definition is "eaten" during the include cycle, I guess one can 
just delete it and directly include the other one.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14978

To: dhaumann, cullmann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann


D14978: Add unit test that checks Format data

2018-08-21 Thread Christoph Cullmann
cullmann added a comment.


  I think the issue is, that if you have just include rules and a context with 
include rules, you will skip that one context completely during including.
  Therefore it is missing in the end result, I assume.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14978

To: dhaumann, cullmann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann


D14978: Add unit test that checks Format data

2018-08-21 Thread Dominik Haumann
dhaumann added a comment.


  Yes:
  
  1. Why don't we see Alert_indent.xml
  2. Is Alert_indent.xml still needed with the new KSyntaxHighlighting 
framework?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14978

To: dhaumann, cullmann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann


D14978: Add unit test that checks Format data

2018-08-21 Thread Dominik Haumann
dhaumann added a reviewer: vkrause.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14978

To: dhaumann, cullmann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann


D14978: Add unit test that checks Format data

2018-08-21 Thread Christoph Cullmann
cullmann added a comment.


  Still the question is: why is that not seen in includedDefinitions. That hl 
ist not at all found, thought it is included.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14978

To: dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann


D14978: Add unit test that checks Format data

2018-08-21 Thread Dominik Haumann
dhaumann added a comment.


  From kate.git:
  
  commit 6c9ee3c58549d6cad46b9a42cf7407d25cdfa62e 

  Author: Joseph Wenninger 
  Date:   Thu Sep 17 23:33:39 2009 +
  
I'm temporarily adding an alert highlighting which has the indentation 
based folding flag set, so that python folding "works" (at least a littlebit) 
again.
In the end the real solution should be to allow mixing of indentation based 
parts with non indentation based ones.

svn path=/trunk/KDE/kdelibs/kate/; revision=1025083

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14978

To: dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann


D14978: Add unit test that checks Format data

2018-08-21 Thread Dominik Haumann
dhaumann added a comment.


  Interesting: alert_indent.xml has no rules except one IncludeRules (And I am 
supposed to be the author?!):
  
















REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14978

To: dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann


D14978: Add unit test that checks Format data

2018-08-21 Thread Christoph Cullmann
cullmann added a comment.


  Btw., the test is a bit easier to read with:
  
// collect all formats, shall be numbered from 1..
QSet formatIds;
for (auto d : qAsConst(includedDefs)) {
const auto formats = d.formats();
for (const auto format : formats) {
// no duplicates
QVERIFY(!formatIds.contains(format.id()));
formatIds.insert(format.id());
}
}

// ensure all ids are there from 1..size
for (int i = 1; i <= formatIds.size(); ++i) {
printf ("id %d\n", i);
QVERIFY(formatIds.contains(i));
}

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14978

To: dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann


D14978: Add unit test that checks Format data

2018-08-21 Thread Dominik Haumann
dhaumann added a comment.


  What fails here is Jira.xml:
  
  QDEBUG : KSyntaxHighlighting::RepositoryTest::testIncludedFormats() 
syntaxrepository_test(4584)/(default) 
?[31m?[34mKSyntaxHighlighting::RepositoryTest::testIncludedFormats?[0m: 
QVector(1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 
21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 
41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 
61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 
81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 
100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 
116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 
132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143, 144, 145, 146, 147, 
148, 149, 150, 151, 152, 153, 154, 155, 156, 157, 158, 159, 160, 161, 162, 163, 
164, 165, 166, 167, 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 
180, 181, 182, 183, 184, 185, 186, 187, 188, 189, 190, 191, 192, 193, 194, 195, 
196, 197, 198, 199, 200, 201, 202, 203, 204, 205, 206, 207, 208, 209, 210, 211, 
212, 213, 214, 215, 216, 217, 218, 219, 220, 221, 222, 223, 224, 225, 226, 227, 
228, 229, 230, 231, 232, 233, 234, 235, 236, 237, 238, 239, 240, 241, 242, 243, 
244, 245, 246, 247, 248, 249, 250, 251, 252, 253, 254, 255, 256, 257, 258, 259, 
260, 261, 262, 263, 264, 265, 266, 267, 268, 269, 270, 271, 272, 273, 274, 275, 
276, 277, 278, 279, 280, 281, 282, 283, 284, 285, 286, 287, 288, 289, 290, 291, 
292, 293, 294, 295, 296, 297, 298, 299, 300, 301, 302, 303, 304, 305, 306, 307, 
308, 309, 310, 311, 312, 313, 314, 315, 316, 317, 318, 319, 320, 321, 322, 323, 
324, 325, 326, 327, 328, 329, 330, 331, 332, 333, 334, 335, 336, 337, 338, 339, 
340, 341, 342, 343, 344, 345, 346, 347, 348, 349, 350, 351, 352, 353, 354, 355, 
356, 357, 358, 359, 360, 361, 362, 364, 365, 366, 367, 368, 369, 370, 371, 372, 
373, 374, 375, 376, 377, 378, 379, 380, 381, 382, 383, 384, 385, 386, 387, 388, 
389, 390, 391, 392, 393, 394, 395, 396, 397, 398, 399, 400, 401, 402, 403, 404, 
405, 406, 407, 408, 409, 410, 411, 412, 413, 414, 415, 416, 417, 418, 419, 420, 
421, 422, 423, 424, 425, 426, 427, 428, 429, 430, 431, 432, 433, 434, 435, 436, 
437, 438, 439, 440, 441, 442, 443, 444) "Jira"
  QDEBUG : KSyntaxHighlighting::RepositoryTest::testIncludedFormats() 
syntaxrepository_test(4584)/(default) 
?[31m?[34mKSyntaxHighlighting::RepositoryTest::testIncludedFormats?[0m: 
QVector(1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 
21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 
41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 
61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 
81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 
100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 
116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 
132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143, 144, 145, 146, 147, 
148, 149, 150, 151, 152, 153, 154, 155, 156, 157, 158, 159, 160, 161, 162, 163, 
164, 165, 166, 167, 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 
180, 181, 182, 183, 184, 185, 186, 187, 188, 189, 190, 191, 192, 193, 194, 195, 
196, 197, 198, 199, 200, 201, 202, 203, 204, 205, 206, 207, 208, 209, 210, 211, 
212, 213, 214, 215, 216, 217, 218, 219, 220, 221, 222, 223, 224, 225, 226, 227, 
228, 229, 230, 231, 232, 233, 234, 235, 236, 237, 238, 239, 240, 241, 242, 243, 
244, 245, 246, 247, 248, 249, 250, 251, 252, 253, 254, 255, 256, 257, 258, 259, 
260, 261, 262, 263, 264, 265, 266, 267, 268, 269, 270, 271, 272, 273, 274, 275, 
276, 277, 278, 279, 280, 281, 282, 283, 284, 285, 286, 287, 288, 289, 290, 291, 
292, 293, 294, 295, 296, 297, 298, 299, 300, 301, 302, 303, 304, 305, 306, 307, 
308, 309, 310, 311, 312, 313, 314, 315, 316, 317, 318, 319, 320, 321, 322, 323, 
324, 325, 326, 327, 328, 329, 330, 331, 332, 333, 334, 335, 336, 337, 338, 339, 
340, 341, 342, 343, 344, 345, 346, 347, 348, 349, 350, 351, 352, 353, 354, 355, 
356, 357, 358, 359, 360, 361, 362, 363, 364, 365, 366, 367, 368, 369, 370, 371, 
372, 373, 374, 375, 376, 377, 378, 379, 380, 381, 382, 383, 384, 385, 386, 387, 
388, 389, 390, 391, 392, 393, 394, 395, 396, 397, 398, 399, 400, 401, 402, 403, 
404, 405, 406, 407, 408, 409, 410, 411, 412, 413, 414, 415, 416, 417, 418, 419, 
420, 421, 422, 423, 424, 425, 426, 427, 428, 429, 430, 431, 432, 433, 434, 435, 
436, 437, 438, 439, 440, 441, 442, 443)
  
  Difference is: 363 is missing in the first version.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14978

To: dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, 

D14978: Add unit test that checks Format data

2018-08-21 Thread Christoph Cullmann
cullmann added a comment.


  contains 363 Normal Text Alerts_indent is missing.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14978

To: dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann


D14978: Add unit test that checks Format data

2018-08-21 Thread Dominik Haumann
dhaumann created this revision.
dhaumann added a reviewer: cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
dhaumann requested review of this revision.

REVISION SUMMARY
  This unit test loads just one definition including its included defintions.
  Then it gets all Formats of the definition + includedDefinitions(). In
  theory, the format IDs now should be 1, 2, 3, ..., N.
  
  What's currently not clear to me is whether this test is really correct.
  I think so, but Jira.xml fails...

TEST PLAN
  make && make test

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  check-full-formats (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14978

AFFECTED FILES
  autotests/syntaxrepository_test.cpp

To: dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann


Re: Upcoming reorganisation of the CI system

2018-08-21 Thread Morten Volden
Hi Ben

I don't know if this is on you radar or not, but here goes.

I have noticed that quite a few of the KDevelop unittests are failing on
the Windows CI.

Running the tests locally they work fine.

If I look at the output of the failing tests it is similar to that pasted
below.

Searching brought me to this page:

https://stackoverflow.com/questions/43897167/does-qt-build-with-opengl-angle-fix-support-for-windows-clients-not-having-openg/43932575#43932575

Which seem to suggest that (re) install DirectX End-User Runtimes (June
2010) .should
fix the issues.

Since people will be giving the servers some TLC in the near future I
thought it might be worth looking at.

Kind Regards

Morten


qt.qpa.input.tablet: Tablet support:  "None"
qt.qpa.windows: QWindowsContext::setProcessDpiAwareness 2
SetProcessDpiAwareness(2) failed: COM error 0x80070005
E_ACCESSDENIED (Unknown error 0x080070005), using 2
qt.qpa.windows: QWindowsIntegrationPrivate::QWindowsIntegrationPrivate
DpiAwareness= 2 effective process DPI awareness= 2
qt.qpa.windows: QWindowsContext::registerWindowClass "Qt5ClipboardView"
style=0x0 brush=0x0 icon=false atom=49400
qt.qpa.mime: QWindowsClipboard::registerViewer m_clipboardViewer: 0xede04e8
format listener: true next: 0x0
qt.qpa.windows: New Monitor:  Screen "WinDisc" 1024x768+0+0 avail:
1024x768+0+0 physical: -1x-1 DPI: 96x96 Depth: 32 Format: 6 hMonitor:
0x10001 primary virtual desktop lock screen
qt.qpa.fonts: QWindowsFontDatabase::systemDefaultFont QFont( "MS Shell Dlg
2,8.25,-1,5,50,0,0,0,0,0" )
qt.qpa.windows: QWindowsTheme::refreshIconPixmapSizes (QSize(16, 16),
QSize(32, 32), QSize(48, 48), QSize(256, 256))
qt.qpa.gl: QWindowsIntegration::createPlatformOpenGLContext
QSurfaceFormat(version 2.0, options QFlags(),
depthBufferSize -1, redBufferSize -1, greenBufferSize -1, blueBufferSize
-1, alphaBufferSize -1, stencilBufferSize -1, samples -1, swapBehavior
QSurfaceFormat::SwapBehavior(DefaultSwapBehavior), swapInterval 1,
colorSpace QSurfaceFormat::ColorSpace(DefaultColorSpace), profile
QSurfaceFormat::OpenGLContextProfile(NoProfile))
qt.qpa.gl: Basic wglCreateContext gives version 1.1
qt.qpa.gl: OpenGL version too low
qt.qpa.gl: OpenGL 2.0 entry points not found
qt.qpa.gl: GPU features: QSet("disable_d3d11", "disable_desktopgl",
"disable_d3d9")
qt.qpa.gl: Disabling Desktop GL:  GpuDescription(vendorId=0x0,
deviceId=0x0, subSysId=0x0, revision=0, driver: "", version=, "")
qt.qpa.gl: Disabling D3D11:  GpuDescription(vendorId=0x0, deviceId=0x0,
subSysId=0x0, revision=0, driver: "", version=, "")
qt.qpa.gl: Disabling D3D9:  GpuDescription(vendorId=0x0, deviceId=0x0,
subSysId=0x0, revision=0, driver: "", version=, "")
qt.qpa.gl: QWindowsOpenGLTester::supportedRenderers
GpuDescription(vendorId=0x0, deviceId=0x0, subSysId=0x0, revision=0,
driver: "", version=, "") renderer:  QFlags(0x8|0x20)
qt.qpa.gl: Qt: Using EGL from libEGLd
qt.qpa.gl: Qt: Using OpenGL ES 2.0 from libGLESv2d
qt.qpa.gl: QWindowsEGLStaticContext::create Created EGL display
0x1e5631fcd80 v 1 . 4




Den tir. 21. aug. 2018 kl. 17.27 skrev Ben Cooksley :

> Hi all,
>
> Final call for objections or queries for this change - i'll be looking
> to roll this out this weekend.
>
> Note: Plasma and KDevelop, i'm not subscribed to your lists so please
> ensure i'm in CC for any responses.
>
> Cheers,
> Ben
>


-- 
Regards / Med venlig hilsen

Morten Danielsen Volden
Software Developer
M.Sc. EE


D14308: [Exe Thumbnailer] Improve icon selection algorithm

2018-08-21 Thread Stefan Brüns
bruns accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D14308

To: broulik, #frameworks, dfaure, ngraham, pali, vonreth, antlarr, bruns
Cc: bruns


D14952: Fix includedDefinitions, handle definition change in context switch

2018-08-21 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:612343c96543: handle context switch attributes of the 
contexts themself (authored by cullmann).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D14952?vs=40067=40158#toc

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14952?vs=40067=40158

REVISION DETAIL
  https://phabricator.kde.org/D14952

AFFECTED FILES
  src/lib/definition.cpp

To: cullmann, vkrause, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, genethomas, kevinapavew, 
ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann


Re: Upcoming reorganisation of the CI system

2018-08-21 Thread Ben Cooksley
On Wed, Aug 22, 2018 at 2:36 AM Morten Volden  wrote:
>
> Hi Ben

Hi Morten,

>
> I don't know if this is on you radar or not, but here goes.
>
> I have noticed that quite a few of the KDevelop unittests are failing on the 
> Windows CI.
>
> Running the tests locally they work fine.
>
> If I look at the output of the failing tests it is similar to that pasted 
> below.
>
> Searching brought me to this page:
>
> https://stackoverflow.com/questions/43897167/does-qt-build-with-opengl-angle-fix-support-for-windows-clients-not-having-openg/43932575#43932575
>
> Which seem to suggest that (re) install DirectX End-User Runtimes (June 
> 2010).should fix the issues.
>
> Since people will be giving the servers some TLC in the near future I thought 
> it might be worth looking at.

I suspect in this instance the problem may be caused by the KVM QXL
drivers that we're reliant on to serve as the system graphics.
Any ideas as to whether this might be the case or not?

As part of the system setup we have to install the DirectX SDK for
some components so I would have expected that it took care of
installing all the necessary runtime components as well.

>
> Kind Regards
>
> Morten

Cheers,
Ben

>
>
> qt.qpa.input.tablet: Tablet support:  "None"
> qt.qpa.windows: QWindowsContext::setProcessDpiAwareness 2
> SetProcessDpiAwareness(2) failed: COM error 0x80070005 E_ACCESSDENIED 
> (Unknown error 0x080070005), using 2
> qt.qpa.windows: QWindowsIntegrationPrivate::QWindowsIntegrationPrivate 
> DpiAwareness= 2 effective process DPI awareness= 2
> qt.qpa.windows: QWindowsContext::registerWindowClass "Qt5ClipboardView" 
> style=0x0 brush=0x0 icon=false atom=49400
> qt.qpa.mime: QWindowsClipboard::registerViewer m_clipboardViewer: 0xede04e8 
> format listener: true next: 0x0
> qt.qpa.windows: New Monitor:  Screen "WinDisc" 1024x768+0+0 avail: 
> 1024x768+0+0 physical: -1x-1 DPI: 96x96 Depth: 32 Format: 6 hMonitor: 0x10001 
> primary virtual desktop lock screen
> qt.qpa.fonts: QWindowsFontDatabase::systemDefaultFont QFont( "MS Shell Dlg 
> 2,8.25,-1,5,50,0,0,0,0,0" )
> qt.qpa.windows: QWindowsTheme::refreshIconPixmapSizes (QSize(16, 16), 
> QSize(32, 32), QSize(48, 48), QSize(256, 256))
> qt.qpa.gl: QWindowsIntegration::createPlatformOpenGLContext 
> QSurfaceFormat(version 2.0, options QFlags(), 
> depthBufferSize -1, redBufferSize -1, greenBufferSize -1, blueBufferSize -1, 
> alphaBufferSize -1, stencilBufferSize -1, samples -1, swapBehavior 
> QSurfaceFormat::SwapBehavior(DefaultSwapBehavior), swapInterval 1, colorSpace 
> QSurfaceFormat::ColorSpace(DefaultColorSpace), profile  
> QSurfaceFormat::OpenGLContextProfile(NoProfile))
> qt.qpa.gl: Basic wglCreateContext gives version 1.1
> qt.qpa.gl: OpenGL version too low
> qt.qpa.gl: OpenGL 2.0 entry points not found
> qt.qpa.gl: GPU features: QSet("disable_d3d11", "disable_desktopgl", 
> "disable_d3d9")
> qt.qpa.gl: Disabling Desktop GL:  GpuDescription(vendorId=0x0, deviceId=0x0, 
> subSysId=0x0, revision=0, driver: "", version=, "")
> qt.qpa.gl: Disabling D3D11:  GpuDescription(vendorId=0x0, deviceId=0x0, 
> subSysId=0x0, revision=0, driver: "", version=, "")
> qt.qpa.gl: Disabling D3D9:  GpuDescription(vendorId=0x0, deviceId=0x0, 
> subSysId=0x0, revision=0, driver: "", version=, "")
> qt.qpa.gl: QWindowsOpenGLTester::supportedRenderers 
> GpuDescription(vendorId=0x0, deviceId=0x0, subSysId=0x0, revision=0, driver: 
> "", version=, "") renderer:  QFlags(0x8|0x20)
> qt.qpa.gl: Qt: Using EGL from libEGLd
> qt.qpa.gl: Qt: Using OpenGL ES 2.0 from libGLESv2d
> qt.qpa.gl: QWindowsEGLStaticContext::create Created EGL display 0x1e5631fcd80 
> v 1 . 4
>
>
>
>
> Den tir. 21. aug. 2018 kl. 17.27 skrev Ben Cooksley :
>>
>> Hi all,
>>
>> Final call for objections or queries for this change - i'll be looking
>> to roll this out this weekend.
>>
>> Note: Plasma and KDevelop, i'm not subscribed to your lists so please
>> ensure i'm in CC for any responses.
>>
>> Cheers,
>> Ben
>
>
>
> --
> Regards / Med venlig hilsen
>
> Morten Danielsen Volden
> Software Developer
> M.Sc. EE


D14971: Combine display OSD icon files and move to plasma icon theme

2018-08-21 Thread Kai Uwe Broulik
broulik accepted this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D14971

To: pstefan, ngraham, #vdg, broulik
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns


D14971: Combine display OSD icon files and move to plasma icon theme

2018-08-21 Thread Phil Stefan
pstefan updated this revision to Diff 40157.
pstefan added a comment.


  - changed osd-sbs-right to osd-sbs-sright

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14971?vs=40156=40157

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14971

AFFECTED FILES
  src/desktoptheme/breeze/icons/osd.svgz
  src/desktoptheme/breeze/icons/video.svgz

To: pstefan, ngraham, #vdg, broulik
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns


D14971: Combine display OSD icon files and move to plasma icon theme

2018-08-21 Thread Phil Stefan
pstefan updated this revision to Diff 40156.
pstefan added a comment.


  - Modes OSD files out of video.svgz into osd.svgz. Removed the 64-64- prefix.

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14971?vs=40154=40156

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14971

AFFECTED FILES
  src/desktoptheme/breeze/icons/osd.svgz
  src/desktoptheme/breeze/icons/video.svgz

To: pstefan, ngraham, #vdg, broulik
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns


D11193: Sonnet : use current hunspell API

2018-08-21 Thread Kevin Funk
kfunk added a comment.


  Please see concerns on 
https://phabricator.kde.org/R246:0a96acf251baa5c9dd042d093ab2bf8fcee10502

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D11193

To: rjvbb, #frameworks, dfaure, mlaurent, vkrause
Cc: kfunk, kde-frameworks-devel, michaelh, ngraham, bruns


D14971: Combine display OSD icon files and move to plasma icon theme

2018-08-21 Thread Kai Uwe Broulik
broulik requested changes to this revision.
broulik added a comment.
This revision now requires changes to proceed.


  File looking good, not really a fan of the new thin lined icon style, but the 
file must be named `osd.svgz` (Plasma always uses the part before the first 
hyphen for lookup)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D14971

To: pstefan, ngraham, #vdg, broulik
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns


D14971: Combine display OSD icon files and move to plasma icon theme

2018-08-21 Thread Phil Stefan
pstefan updated this revision to Diff 40154.
pstefan added a comment.


  - Reverse name change

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14971?vs=40143=40154

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14971

AFFECTED FILES
  src/desktoptheme/breeze/icons/video.svgz

To: pstefan, ngraham, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


Re: Upcoming reorganisation of the CI system

2018-08-21 Thread Ben Cooksley
Hi all,

Final call for objections or queries for this change - i'll be looking
to roll this out this weekend.

Note: Plasma and KDevelop, i'm not subscribed to your lists so please
ensure i'm in CC for any responses.

Cheers,
Ben


D14946: [DialogShadows] Use 0 offset for disabled borders on Wayland

2018-08-21 Thread David Edmundson
davidedmundson added a comment.


  Yeah, I'm reviewing that now, it just has a lot of maths to get through :)

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  wayland-shadows

REVISION DETAIL
  https://phabricator.kde.org/D14946

To: zzag, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D14946: [DialogShadows] Use 0 offset for disabled borders on Wayland

2018-08-21 Thread Vlad Zagorodniy
zzag added a comment.


  This change depends on D14783 .
  
  I also think that we don't need to attach empty tiles on X11. But it works, 
the Sliding Popups effect was fixed... So, maybe, that's fine.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  wayland-shadows

REVISION DETAIL
  https://phabricator.kde.org/D14946

To: zzag, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D14946: [DialogShadows] Use 0 offset for disabled borders on Wayland

2018-08-21 Thread Vlad Zagorodniy
zzag updated this revision to Diff 40150.
zzag added a comment.


  "QMarginsF margins = QMarginsF();" => "QMarginsF margins;"

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14946?vs=40044=40150

BRANCH
  wayland-shadows

REVISION DETAIL
  https://phabricator.kde.org/D14946

AFFECTED FILES
  src/plasmaquick/dialogshadows.cpp

To: zzag, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D14971: Combine display OSD icon files and move to plasma icon theme

2018-08-21 Thread Nathaniel Graham
ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  If we rename the icons, we will need to correspondingly change the OSD code 
itself to use the new names: 
https://cgit.kde.org/kscreen.git/tree/kded/qml/OsdSelector.qml#n51
  
  Unfortunately, that code lives in `KScreen`, which uses the Plasma release 
schedule rather than the Frameworks schedule. Therefore we cannot guarantee 
that people will be using the right combination of the two pieces of code; it's 
perfectly possible for a distro to ship KDE Frameworks 5.50 (with the renamed 
files) but KDE Plasma 5.13.5 (which would use the old names). If these lived 
on-disk, I'd suggest just making a symlink. Can we do that here internally? Is 
there any way to give one image two names in the svgz file?
  
  Either way, that should be done in a separate commit. Please revert the name 
change and we'll do that later. It's important to keep patches as small as 
possible to keep the git history clean, and also make it easy to revert any 
individual change that caused problems.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D14971

To: pstefan, ngraham, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D14971: Combine display OSD icon files and move to plasma icon theme

2018-08-21 Thread Phil Stefan
pstefan updated this revision to Diff 40143.
pstefan added a comment.


  - Moved all OSD icons into video.svgz and renamed some of them.

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14971?vs=40135=40143

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14971

AFFECTED FILES
  src/desktoptheme/breeze/icons/video.svgz

To: pstefan, ngraham, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D14956: avoid any heap allocation for default constructed Format() as used as "invalid"

2018-08-21 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:61a401b0e523: avoid any heap allocation for default 
constructed Format() as used as invalid (authored by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14956?vs=40134=40140

REVISION DETAIL
  https://phabricator.kde.org/D14956

AFFECTED FILES
  src/lib/definition.cpp
  src/lib/format.cpp
  src/lib/format_p.h

To: cullmann, vkrause
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, cullmann, sars


D14956: avoid any heap allocation for default constructed Format() as used as "invalid"

2018-08-21 Thread Volker Krause
vkrause accepted this revision.
vkrause added a comment.
This revision is now accepted and ready to land.


  Looks good to me, and is indeed a lot less code.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14956

To: cullmann, vkrause
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, cullmann, sars


D14956: avoid any heap allocation for default constructed Format() as used as "invalid"

2018-08-21 Thread Christoph Cullmann
cullmann updated this revision to Diff 40134.
cullmann added a comment.


  Simpler variant with shared default FormatPrivate.

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14956?vs=40073=40134

REVISION DETAIL
  https://phabricator.kde.org/D14956

AFFECTED FILES
  src/lib/definition.cpp
  src/lib/format.cpp
  src/lib/format_p.h

To: cullmann, vkrause
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, cullmann, sars


D14952: Fix includedDefinitions, handle definition change in context switch

2018-08-21 Thread Christoph Cullmann
cullmann reopened this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  I got told that I missed some more ContextSwitch variants.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14952

To: cullmann, vkrause, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, genethomas, kevinapavew, 
ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann


D14956: avoid any heap allocation for default constructed Format() as used as "invalid"

2018-08-21 Thread Christoph Cullmann
cullmann added a comment.


  Hmm, if we go that route, what to do in:

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14956

To: cullmann, vkrause
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, cullmann, sars


D14946: [DialogShadows] Use 0 offset for disabled borders on Wayland

2018-08-21 Thread David Edmundson
davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  wayland-shadows

REVISION DETAIL
  https://phabricator.kde.org/D14946

To: zzag, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D10937: Retouching of Screen Layout Selection OSD Icons

2018-08-21 Thread Phil Stefan
pstefan abandoned this revision.
pstefan added a comment.


  Moved to D14971 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10937

To: pstefan, #breeze, ngraham
Cc: gladhorn, broulik, bruns, #vdg, kde-frameworks-devel, emateli, abetts, 
mart, ngraham, michaelh, crozbo, firef, skadinna, aaronhoneycutt, mbohlender


D14971: Combine display OSD icon files and mobe to plasma icon theme

2018-08-21 Thread Phil Stefan
pstefan edited the summary of this revision.
pstefan added reviewers: ngraham, VDG.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D14971

To: pstefan, ngraham, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D14971: Combine display OSD icon files and move to plasma icon theme

2018-08-21 Thread Phil Stefan
pstefan retitled this revision from "Combine display OSD icon files and mobe to 
plasma icon theme" to "Combine display OSD icon files and move to plasma icon 
theme".

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D14971

To: pstefan, ngraham, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D14971: Combine display OSD icon files and mobe to plasma icon theme

2018-08-21 Thread Phil Stefan
pstefan created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
pstefan requested review of this revision.

REVISION SUMMARY
  Move the icons from [D10937 ] to 
plasma-frameworks and combine all the sizes

TEST PLAN
  "osd-shutd-screen.svg" does not display correctly for me. I can't find any 
difference between it and the rest of the icons. Help appreciated.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14971

AFFECTED FILES
  src/desktoptheme/breeze/icons/osd-duplicate.svg
  src/desktoptheme/breeze/icons/osd-rotate-ccw.svg
  src/desktoptheme/breeze/icons/osd-rotate-cw.svg
  src/desktoptheme/breeze/icons/osd-rotate-flip.svg
  src/desktoptheme/breeze/icons/osd-rotate-normal.svg
  src/desktoptheme/breeze/icons/osd-sbs-left.svg
  src/desktoptheme/breeze/icons/osd-sbs-right.svg
  src/desktoptheme/breeze/icons/osd-shutd-laptop.svg
  src/desktoptheme/breeze/icons/osd-shutd-screen.svg

To: pstefan
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D14927: KConfig: handle directory symlinks correctly.

2018-08-21 Thread Adriaan de Groot
adridg added a comment.


  Sorry, this is getting very confusing:
  
  - when running all tests, unpatched: testDelete and testThreads fail
  - when running all tests, patched: testDefaults fails
  
  I suspect there are some more missing canonicalizations, but I don't have 
time right now to go hunting them.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D14927

To: dfaure, adridg, arichardson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D14308: [Exe Thumbnailer] Improve icon selection algorithm

2018-08-21 Thread Kai Uwe Broulik
broulik updated this revision to Diff 40131.
broulik added a comment.


  - Update wording

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14308?vs=39645=40131

REVISION DETAIL
  https://phabricator.kde.org/D14308

AFFECTED FILES
  thumbnail/icoutils_common.cpp

To: broulik, #frameworks, dfaure, ngraham, pali, vonreth, antlarr, bruns
Cc: bruns


D14779: Fix 'kformattest fails with installed kcoreaddons language package'

2018-08-21 Thread Ralf Habacker
habacker abandoned this revision.
habacker added a comment.


  superseeded by D14967  (tried to updated 
this review with arc diff, but forgot to add the annoying --verbatim argument 
to let phabricator know that I have a changed commit message :-/)

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D14779

To: habacker, #frameworks
Cc: dfaure, aacid, kde-frameworks-devel, michaelh, ngraham, bruns


D14967: Disable loading of translations for kformattest, which was not designed with translations

2018-08-21 Thread Ralf Habacker
habacker created this revision.
habacker added reviewers: dfaure, aacid.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
habacker requested review of this revision.

REVISION SUMMARY
  Required reviews: D14940  D14966 

  
  Review Request: https://phabricator.kde.org/D14779

TEST PLAN
  compiled and checked with kformattest on linux and windows using cross 
compiled build

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14967

AFFECTED FILES
  autotests/kformattest.cpp
  src/lib/CMakeLists.txt

To: habacker, dfaure, aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D14966: Added support for disabling the loading of translations

2018-08-21 Thread Ralf Habacker
habacker created this revision.
habacker added reviewers: aacid, dfaure.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
habacker requested review of this revision.

REVISION SUMMARY
  With this commit ecm_create_qm_loader() creates a specific header file
  containing related helper functions if NAMESPACE argument is provided.

TEST PLAN
  compiled and tested with patched kcoreaddons from git repo

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14966

AFFECTED FILES
  modules/ECMPoQmTools.cmake
  modules/ECMQmLoader.cpp.in
  modules/ECMQmLoader.h.in

To: habacker, aacid, dfaure
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns


D14779: Fix 'kformattest fails with installed kcoreaddons language package'

2018-08-21 Thread Ralf Habacker
habacker added a comment.


  In D14779#311871 , @habacker wrote:
  
  > Thanks for this pointer - with this setting the german translation is not 
fetched anymore.
  
  
  A further look into the windows implementation of the qm loader part 
(https://cgit.kde.org/extra-cmake-modules.git/tree/modules/ECMQmLoader.cpp.in#n65)
 shows that the language is fetched from `QLocale::system() `
  
  QLocale::system() is initiated on unix os from LC_ALL and friends 
(http://code.qt.io/cgit/qt/qtbase.git/tree/src/corelib/tools/qlocale_unix.cpp#n75),
 which could be changed with the qputenv call.
  
  But on Windows the system locale is fetched from the current user locale 
(http://code.qt.io/cgit/qt/qtbase.git/tree/src/corelib/tools/qlocale_win.cpp#n172),
 which could not be changed temporary by the test app.
  
  To have a cross platform solution I think it is really required to disable 
loading translations in this test.  If QLocale::C could not be used for that 
(Albert mentioned that)  an auxiliary function provided by the qmloader is 
required for that.
  I'm going to file a related review request.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D14779

To: habacker, #frameworks
Cc: dfaure, aacid, kde-frameworks-devel, michaelh, ngraham, bruns


D14956: avoid any heap allocation for default constructed Format() as used as "invalid"

2018-08-21 Thread Christoph Cullmann
cullmann added a comment.


  That looks much nicer an avoids the !d checks, which are tedious.
  
  I think the one ref count change is no issue, at least that is orders of 
magnitude better than some malloc on Windows :)
  
  I will adapt the patch.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14956

To: cullmann, vkrause
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, cullmann, sars


D14956: avoid any heap allocation for default constructed Format() as used as "invalid"

2018-08-21 Thread Volker Krause
vkrause added a comment.


  That should work, yes.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14956

To: cullmann, vkrause
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, cullmann, sars