KDE CI: Frameworks kdoctools kf5-qt5 SUSEQt5.10 - Build # 52 - Still Unstable!

2018-08-27 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdoctools%20kf5-qt5%20SUSEQt5.10/52/ Project: Frameworks kdoctools kf5-qt5 SUSEQt5.10 Date of build: Tue, 28 Aug 2018 03:39:58 + Build duration: 4 min 4 sec and counting JUnit Tests

D15105: add JSON to general.entities

2018-08-27 Thread Burkhard Lück
This revision was automatically updated to reflect the committed changes. Closed by commit R238:21232062fc8a: add JSON to general.entities (authored by lueck). REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15105?vs=40517=40525 REVISION DETAIL

D15091: Compile python bindings with the same sipname used by PyQt

2018-08-27 Thread Rex Dieter
rdieter added a comment. I was asking mostly because that's what pyqt upstream strongly suggested (to use all sip_flags) when I asked them. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D15091 To: arojas, #frameworks, bruns Cc: rdieter,

D15091: Compile python bindings with the same sipname used by PyQt

2018-08-27 Thread Antonio Rojas
arojas added a comment. In D15091#316150 , @rdieter wrote: > Why are you simply not using all PYQT_CONFIGURATION["sip_flags"]? Not sure if we really want to do this. For instance, bindings would get tagged with the Qt version that PyQt

D15076: Build failures with KSyntaxHighlighting 5.49

2018-08-27 Thread Christophe Giboudeaux
cgiboudeaux added a comment. David, Elvis, what's the nicest way to fix this ? (https://phabricator.kde.org/D15076#315803 for the details) REPOSITORY R55 Cantor REVISION DETAIL https://phabricator.kde.org/D15076 To: asemke, #kde_edu, #cantor, #frameworks Cc: elvisangelaccio, dfaure,

D15076: Build failures with KSyntaxHighlighting 5.49

2018-08-27 Thread Christophe Giboudeaux
cgiboudeaux added subscribers: dfaure, elvisangelaccio. REPOSITORY R55 Cantor REVISION DETAIL https://phabricator.kde.org/D15076 To: asemke, #kde_edu, #cantor, #frameworks Cc: elvisangelaccio, dfaure, cgiboudeaux, mpyne, cullmann, kde-edu, narvaez, apol

D15105: add JSON to general.entities

2018-08-27 Thread Luigi Toscano
ltoscano accepted this revision as: ltoscano. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D15105 To: lueck, #documentation, yurchor, ltoscano Cc: kde-frameworks-devel, kde-doc-english, michaelh, ngraham, bruns, skadinna

D11945: Improve highlighting of SELinux CIL policies & file contexts

2018-08-27 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Feel free to commit. REPOSITORY R216 Syntax Highlighting BRANCH add-selinux REVISION DETAIL https://phabricator.kde.org/D11945 To: nibags, dhaumann, cullmann,

D15105: add JSON to general.entities

2018-08-27 Thread Yuri Chornoivan
yurchor accepted this revision as: yurchor. This revision is now accepted and ready to land. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D15105 To: lueck, #documentation, yurchor Cc: kde-frameworks-devel, kde-doc-english, michaelh, ngraham, bruns, skadinna

D15105: add JSON to general.entities

2018-08-27 Thread Burkhard Lück
lueck created this revision. lueck added a reviewer: Documentation. Herald added projects: Frameworks, Documentation. Herald added subscribers: kde-doc-english, kde-frameworks-devel. lueck requested review of this revision. REVISION SUMMARY see title REPOSITORY R238 KDocTools REVISION

D15071: Don't draw frames and shadows around images with transparency

2018-08-27 Thread Nathaniel Graham
ngraham added a comment. In D15071#316156 , @bruns wrote: > If we want to avoid **dangerous** confusion, we should not care for previews, but mark executables. This seems like an excellent idea to me. It would improve safety even without

D15071: Don't draw frames and shadows around images with transparency

2018-08-27 Thread Stefan Brüns
bruns added a comment. In D15071#315839 , @broulik wrote: > I'm a bit concerned that removing the frame most of the time blurs the lines between "previews of images" and "actual file icons", especially for the SVG case. > > Now they all

D15091: Compile python bindings with the same sipname used by PyQt

2018-08-27 Thread Rex Dieter
rdieter added a comment. Why are you simply not using all PYQT_CONFIGURATION["sip_flags"]? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D15091 To: arojas, #frameworks, bruns Cc: rdieter, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D15099: add a new property headerVisible

2018-08-27 Thread Andres Betts
abetts added a comment. Thanks for the work Marco! REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D15099 To: mart, #plasma, #frameworks Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D12311: Align lock icon with bold message text; reduce overall size of dialog

2018-08-27 Thread Scott Harvey
This revision was automatically updated to reflect the committed changes. Closed by commit R121:d4ee26a76a21: Align lock icon with bold message text; reduce overall size of dialog (authored by sharvey). REPOSITORY R121 Policykit (Polkit) KDE Agent CHANGES SINCE LAST UPDATE

D15099: add a new property headerVisible

2018-08-27 Thread Marco Martin
mart updated this revision to Diff 40504. mart added a comment. - emit changed REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15099?vs=40501=40504 BRANCH phab/headerVisible REVISION DETAIL https://phabricator.kde.org/D15099 AFFECTED FILES

D15099: add a new property headerVisible

2018-08-27 Thread Marco Martin
mart added a comment. KCM showing its own title F6218375: Spectacle.y22236.png Ttile shown by KPageWidget F6218377: Spectacle.S22236.png REPOSITORY R236 KWidgetsAddons REVISION DETAIL

D15099: add a new property headerVisible

2018-08-27 Thread Marco Martin
mart added a reviewer: Frameworks. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D15099 To: mart, #plasma, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15099: add a new property headerVisible

2018-08-27 Thread Marco Martin
mart created this revision. mart added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY add a new property in KPageWidgetItem, headerVisible this way the page can control whether

D14580: support for multi pages kcms

2018-08-27 Thread Marco Martin
mart updated this revision to Diff 40500. mart added a comment. - use the new ConfigMoule push/pop api REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14580?vs=40370=40500 BRANCH mart/multipageKCM REVISION DETAIL https://phabricator.kde.org/D14580

D15098: make push/pop part of ConfigModule API

2018-08-27 Thread Marco Martin
mart added a reviewer: Plasma. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D15098 To: mart, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15098: make push/pop part of ConfigModule API

2018-08-27 Thread Marco Martin
mart created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY for better separation, abstract push/pop and columnWidth in the ConfigModule class so the qml part won't have access to

D14747: [Exe Thumbnailer] Don't generate QTemporaryFile

2018-08-27 Thread Kai Uwe Broulik
broulik added a reviewer: vonreth. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D14747 To: broulik, #frameworks, #windows, vonreth

D15096: [PreviewJob] Send enabled thumbnail plugins to the thumbnail slave

2018-08-27 Thread Kai Uwe Broulik
broulik added a dependent revision: D15097: [Thumbnailer] Use enabled plugins passed in as metadata. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15096 To: broulik, dfaure, fvogt, kossebau Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15096: [PreviewJob] Send enabled thumbnail plugins to the thumbnail slave

2018-08-27 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: dfaure, fvogt, kossebau. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY This way the thumbnailer can use the same enabled plugin

D15089: Add syntax highlighting for SELinux kernel policy language

2018-08-27 Thread Nibaldo González
nibags updated this revision to Diff 40492. nibags added a comment. - Remove depreciated permissions (7 keywords) REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15089?vs=40472=40492 BRANCH add-selinux REVISION DETAIL