D15213: Link 16px icon folders to 16@2

[Chris Rizzitello]

rizzitello retitled this revision from "link 16 to 16@2" to "Link 16px icon 
folders to 16@2".
rizzitello added reviewers: VDG, Plasma.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15213

To: rizzitello, #vdg, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15213: link 16 to 16@2

[Chris Rizzitello]

rizzitello created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
rizzitello requested review of this revision.

REVISION SUMMARY
  Create simlinks for all size 16 folders to 16@2 
  See D6313 
  Todo : add info to theme.index

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15213

AFFECTED FILES
  icons-dark/actions/16@2
  icons-dark/animations/16@2
  icons-dark/apps/16@2
  icons-dark/devices/16@2
  icons-dark/emblems/16@2
  icons-dark/mimetypes/16@2
  icons-dark/places/16@2
  icons-dark/status/16@2
  icons/actions/16@2
  icons/animations/16@2
  icons/apps/16@2
  icons/devices/16@2
  icons/emblems/16@2
  icons/mimetypes/16@2
  icons/places/16@2
  icons/status/16@2

To: rizzitello
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15212: Create links for 16@2 icons

[Chris Rizzitello]

rizzitello abandoned this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15212

To: rizzitello, #vdg, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15212: Create links for 16@2 icons

[Chris Rizzitello]

rizzitello edited the summary of this revision.
rizzitello added reviewers: VDG, Plasma.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15212

To: rizzitello, #vdg, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15212: Create links for 16@2 icons

[Chris Rizzitello]

rizzitello created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
rizzitello requested review of this revision.

REVISION SUMMARY
  Signed-off-by: Chris Rizzitello 

REPOSITORY
  R266 Breeze Icons

BRANCH
  2xScaleLinks

REVISION DETAIL
  https://phabricator.kde.org/D15212

AFFECTED FILES
  icons-dark/actions/16@2/CVnamespace.svg
  icons-dark/actions/16@2/Info-amarok.svg
  icons-dark/actions/16@2/PrePostCondition.svg
  icons-dark/actions/16@2/accept_signal.svg
  icons-dark/actions/16@2/accept_time_event.svg
  icons-dark/actions/16@2/acrobat.svg
  icons-dark/actions/16@2/action-albumfolder-importdir2.svg
  icons-dark/actions/16@2/action-rss_tag.svg
  icons-dark/actions/16@2/activity-fork.svg
  icons-dark/actions/16@2/actor.svg
  icons-dark/actions/16@2/add-placemark.svg
  icons-dark/actions/16@2/address-book-new.svg
  icons-dark/actions/16@2/addressbook-details.svg
  icons-dark/actions/16@2/adjustcol.svg
  icons-dark/actions/16@2/adjustrow.svg
  icons-dark/actions/16@2/adress-book-new.svg
  icons-dark/actions/16@2/aggregation.svg
  icons-dark/actions/16@2/akonadi-phone-home.svg
  icons-dark/actions/16@2/albumfolder-importdir.svg
  icons-dark/actions/16@2/albumfolder-importimages.svg
  icons-dark/actions/16@2/albumfolder-new.svg
  icons-dark/actions/16@2/albumfolder-properties.svg
  icons-dark/actions/16@2/albumfolder-user-trash.svg
  icons-dark/actions/16@2/align-horizontal-baseline.svg
  icons-dark/actions/16@2/align-horizontal-bottom-out.svg
  icons-dark/actions/16@2/align-horizontal-center.svg
  icons-dark/actions/16@2/align-horizontal-left-out.svg
  icons-dark/actions/16@2/align-horizontal-left-to-anchor.svg
  icons-dark/actions/16@2/align-horizontal-left.svg
  icons-dark/actions/16@2/align-horizontal-right-out.svg
  icons-dark/actions/16@2/align-horizontal-right-to-anchor.svg
  icons-dark/actions/16@2/align-horizontal-right.svg
  icons-dark/actions/16@2/align-horizontal-top-out.svg
  icons-dark/actions/16@2/align-vertical-baseline.svg
  icons-dark/actions/16@2/align-vertical-bottom-out.svg
  icons-dark/actions/16@2/align-vertical-bottom-to-anchor.svg
  icons-dark/actions/16@2/align-vertical-bottom.svg
  icons-dark/actions/16@2/align-vertical-center.svg
  icons-dark/actions/16@2/align-vertical-top-out.svg
  icons-dark/actions/16@2/align-vertical-top-to-anchor.svg
  icons-dark/actions/16@2/align-vertical-top.svg
  icons-dark/actions/16@2/amarok_artist.svg
  icons-dark/actions/16@2/amarok_cart_add.svg
  icons-dark/actions/16@2/amarok_cart_remove.svg
  icons-dark/actions/16@2/amarok_cart_view.svg
  icons-dark/actions/16@2/amarok_change_language.svg
  icons-dark/actions/16@2/amarok_clock.svg
  icons-dark/actions/16@2/amarok_lyrics.svg
  icons-dark/actions/16@2/amarok_playcount.svg
  icons-dark/actions/16@2/amarok_playlist.svg
  icons-dark/actions/16@2/amarok_playlist_refresh.svg
  icons-dark/actions/16@2/amarok_scripts.svg
  icons-dark/actions/16@2/anchor.svg
  icons-dark/actions/16@2/animation-stage.svg
  icons-dark/actions/16@2/answer-correct.svg
  icons-dark/actions/16@2/answer.svg
  icons-dark/actions/16@2/application-exit.svg
  icons-dark/actions/16@2/application-menu.svg
  icons-dark/actions/16@2/appointment-new.svg
  icons-dark/actions/16@2/approved.svg
  icons-dark/actions/16@2/archive-extract.svg
  icons-dark/actions/16@2/archive-insert-directory.svg
  icons-dark/actions/16@2/archive-insert.svg
  icons-dark/actions/16@2/archive-remove.svg
  icons-dark/actions/16@2/arrow-down-double.svg
  icons-dark/actions/16@2/arrow-down.svg
  icons-dark/actions/16@2/arrow-left-double.svg
  icons-dark/actions/16@2/arrow-left.svg
  icons-dark/actions/16@2/arrow-right-double.svg
  icons-dark/actions/16@2/arrow-right.svg
  icons-dark/actions/16@2/arrow-up-double.svg
  icons-dark/actions/16@2/arrow-up.svg
  icons-dark/actions/16@2/arrow.svg
  icons-dark/actions/16@2/artifact.svg
  icons-dark/actions/16@2/artistictext-tool.svg
  icons-dark/actions/16@2/association.svg
  icons-dark/actions/16@2/atmosphere.svg
  icons-dark/actions/16@2/auto-scale-all.svg
  icons-dark/actions/16@2/auto-scale-x.svg
  icons-dark/actions/16@2/auto-scale-y.svg
  icons-dark/actions/16@2/autocorrection.svg
  icons-dark/actions/16@2/automated-tasks.svg
  icons-dark/actions/16@2/beamerblock.svg
  icons-dark/actions/16@2/beamerframe.svg
  icons-dark/actions/16@2/bibtex.svg
  icons-dark/actions/16@2/bigskip.svg
  icons-dark/actions/16@2/bitmap-trace.svg
  icons-dark/actions/16@2/black_sum.svg
  icons-dark/actions/16@2/bookmark-add-folder.svg
  icons-dark/actions/16@2/bookmark-edit.svg
  icons-dark/actions/16@2/bookmark-new-list.svg
  icons-dark/actions/16@2/bookmark-new.svg
  icons-dark/actions/16@2/bookmark-remove.svg
  icons-dark/actions/16@2/bookmark-toolbar.svg
  icons-dark/actions/16@2/bookmarks-organize.svg
  icons-dark/actions/16@2/bookmarks.svg
  icons-dark/actions/16@2/borderpainter.svg
  icons-dark/actions/16@2/bordertool.svg
  icons-dark/actions/16@2/box.svg
  

D15194: Draw a line separating PlasmaComponents tab bar from its content area

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15194

To: ngraham, #plasma, #vdg
Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D15211: ::match and ::doMatch => const

[Christoph Cullmann]

cullmann updated this revision to Diff 40836.
cullmann added a comment.


  lower m_dynamic to the three rules that support it at all

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15211?vs=40835=40836

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15211

AFFECTED FILES
  data/schema/language.xsd
  src/lib/rule.cpp
  src/lib/rule_p.h

To: cullmann, vkrause, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D15211: ::match and ::doMatch => const

[Christoph Cullmann]

cullmann updated this revision to Diff 40835.
cullmann added a comment.


  disallow dynamic for stuff we didn't implement

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15211?vs=40834=40835

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15211

AFFECTED FILES
  data/schema/language.xsd
  src/lib/rule.cpp
  src/lib/rule_p.h

To: cullmann, vkrause, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D15211: ::match and ::doMatch => const

[Christoph Cullmann]

cullmann updated this revision to Diff 40834.
cullmann added a comment.


  avoid duplicate storage of pattern

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15211?vs=40833=40834

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15211

AFFECTED FILES
  src/lib/rule.cpp
  src/lib/rule_p.h

To: cullmann, vkrause, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D15211: ::match and ::doMatch => const

[Christoph Cullmann]

cullmann created this revision.
cullmann added reviewers: vkrause, dhaumann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
cullmann requested review of this revision.

REVISION SUMMARY
  make ::match and ::doMatch const
  ATM the keyword list is still mutable (internal it uses mutable, too)
  
  for isDynamic, we just construct a new regex if needed
  that is nicer than working on the stored one

TEST PLAN
  make && make test

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15211

AFFECTED FILES
  src/lib/rule.cpp
  src/lib/rule_p.h

To: cullmann, vkrause, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D8532: [WIP] Restrict file extractor with Seccomp

[Detlef Eppers]

detlefe added a comment.


  I'm just an interested user and cannot comment on the question of external 
plugins. But before this enters a deep sleep, I wonder if at least the 
//current// patch should find its way into the extractors or into kfilemetadata.
  
  A whitelist is the real thing,  and it would be awesome if that could be made 
possible. But if I had the choice between nothing and the blacklist, I would 
pick... the blacklist.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D8532

To: davidk, apol, ossi
Cc: kde-frameworks-devel, michaelh, #baloo, detlefe, ngraham, nicolasfella, 
ashaposhnikov, astippich, spoorun, bruns, abrahams

D13700: implement reading of the replaygain tags

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> taglibextractor.cpp:252
> +if (!lstID3v2.isEmpty()) {
> +TagLib::ID3v2::UserTextIdentificationFrame *userTextFrame;
> +userTextFrame = 
> TagLib::ID3v2::UserTextIdentificationFrame::find(mpegFile.ID3v2Tag(), 
> "replaygain_track_gain");

You can use a typedef in this scope, makes the long lines easier to read
https://en.cppreference.com/w/cpp/language/namespace_alias

  typedef TagLib::ID3v2::UserTextIdentificationFrame IdFrame;
  auto trackGainFrame = IdFrame::find(mpegFile.ID3v2Tag(), 
"replaygain_track_gain");
  if (trackGainFrame) { ...

Using a distinct name for each instance makes it clearer these are independent 
frames.

> taglibextractor.cpp:254
> +userTextFrame = 
> TagLib::ID3v2::UserTextIdentificationFrame::find(mpegFile.ID3v2Tag(), 
> "replaygain_track_gain");
> +if ( userTextFrame ) {
> +data.replayGainTrackGain = 
> convertWCharsToQString(userTextFrame->fieldList().back().toCString(true));

Remove the extra space inside the parentheses.

> taglibextractor.cpp:255
> +if ( userTextFrame ) {
> +data.replayGainTrackGain = 
> convertWCharsToQString(userTextFrame->fieldList().back().toCString(true));
> +}

you can use TStringToQString
`data.replayGainTrackGain = 
TStringToQString(userTextFrame->fieldList().back());`

> taglibextractor.cpp:255
> +if ( userTextFrame ) {
> +data.replayGainTrackGain = 
> convertWCharsToQString(userTextFrame->fieldList().back().toCString(true));
> +}

`fieldList()` may return an empty list, please add a check

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D13700

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D15207: precompute attribute format for context & rules

[Christoph Cullmann]

cullmann added a comment.


  :=)
  
  The second lookup round over all included rules in the context did really 
hide some things.
  
  Now we properly keep track which context is needed to be used for the lookup.
  
  2321fc443483fb5669f9092980c7ab25bf78778d 

  7af02d6b955ef60ac7e9666b2694c461500d52bc 


REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D15207

To: cullmann, vkrause, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

KDE CI: Frameworks syntax-highlighting kf5-qt5 WindowsMSVCQt5.11 - Build # 32 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20WindowsMSVCQt5.11/32/
 Project:
Frameworks syntax-highlighting kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Sat, 01 Sep 2018 16:52:18 +
 Build duration:
3 min 44 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 8 test(s)

KDE CI: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9 - Build # 151 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.9/151/
 Project:
Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 01 Sep 2018 16:52:18 +
 Build duration:
2 min 17 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 9 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)85%
(35/41)85%
(35/41)80%
(2550/3197)68%
(1819/2681)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(8/8)100%
(8/8)98%
(619/630)63%
(369/584)examples0%
(0/2)0%
(0/2)0%
(0/193)0%
(0/98)src.cli0%
(0/1)0%
(0/1)0%
(0/89)0%
(0/40)src.indexer100%
(1/1)100%
(1/1)76%
(193/254)77%
(197/256)src.lib90%
(26/29)90%
(26/29)86%
(1738/2031)74%
(1253/1703)

KDE CI: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.10 - Build # 206 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.10/206/
 Project:
Frameworks syntax-highlighting kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 01 Sep 2018 16:52:18 +
 Build duration:
2 min 5 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 9 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)85%
(35/41)85%
(35/41)80%
(2550/3197)68%
(1819/2681)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(8/8)100%
(8/8)98%
(619/630)63%
(369/584)examples0%
(0/2)0%
(0/2)0%
(0/193)0%
(0/98)src.cli0%
(0/1)0%
(0/1)0%
(0/89)0%
(0/40)src.indexer100%
(1/1)100%
(1/1)76%
(193/254)77%
(197/256)src.lib90%
(26/29)90%
(26/29)86%
(1738/2031)74%
(1253/1703)

D15207: precompute attribute format for context & rules

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:2321fc443483: try to fix unit tests (authored by 
cullmann).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D15207?vs=40827=40830#toc

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15207?vs=40827=40830

REVISION DETAIL
  https://phabricator.kde.org/D15207

AFFECTED FILES
  autotests/html/csharp.cs.html
  autotests/html/highlight.cmake.html
  autotests/html/highlight.cpp.html
  autotests/html/highlight.css.html
  autotests/html/highlight.dox.html
  autotests/html/highlight.hs.html
  autotests/html/highlight.js.html
  autotests/html/highlight.lhs.html
  autotests/html/highlight.lua.html
  autotests/html/highlight.qml.html
  autotests/html/highlight.tex.html
  autotests/html/highlight.y.html
  autotests/html/modelines.py.html
  autotests/html/test.Rd.html
  autotests/html/test.coffee.html
  autotests/html/test.htm.html
  autotests/html/test.js.html
  autotests/html/test.py.html
  autotests/html/test.qml.html
  autotests/html/test.te.html
  autotests/reference/csharp.cs.ref
  autotests/reference/highlight.cmake.ref
  autotests/reference/highlight.cpp.ref
  autotests/reference/highlight.css.ref
  autotests/reference/highlight.dox.ref
  autotests/reference/highlight.hs.ref
  autotests/reference/highlight.js.ref
  autotests/reference/highlight.lhs.ref
  autotests/reference/highlight.lua.ref
  autotests/reference/highlight.qml.ref
  autotests/reference/highlight.tex.ref
  autotests/reference/highlight.y.ref
  autotests/reference/modelines.py.ref
  autotests/reference/review128925-1.css.ref
  autotests/reference/review128925-2.css.ref
  autotests/reference/test.Rd.ref
  autotests/reference/test.coffee.ref
  autotests/reference/test.htm.ref
  autotests/reference/test.js.ref
  autotests/reference/test.py.ref
  autotests/reference/test.qml.ref
  autotests/reference/test.te.ref
  src/lib/context.cpp
  src/lib/context_p.h
  src/lib/rule.cpp

To: cullmann, vkrause, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

KDE CI: Frameworks syntax-highlighting kf5-qt5 WindowsMSVCQt5.11 - Build # 30 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20WindowsMSVCQt5.11/30/
 Project:
Frameworks syntax-highlighting kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Sat, 01 Sep 2018 16:08:38 +
 Build duration:
30 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 8 test(s)Failed: TestSuite.htmlhighlighter_testFailed: TestSuite.testhighlighter_test

D7909: Add syntax support for Crystal Programming Language

[Faustino Aguilar]

faguilar added a comment.


  In D7909#318737 , @cullmann wrote:
  
  > Hi, any update on this?
  
  
  Not yet!  :)

REPOSITORY
  R40 Kate

REVISION DETAIL
  https://phabricator.kde.org/D7909

To: faguilar, dhaumann, vkrause, #framework_syntax_highlighting, #kate, mwolff, 
cullmann
Cc: kwrite-devel, oprypin, mwolff, cullmann, ngraham, #kate, #frameworks, 
faguilar, bmortimer, michaelh, genethomas, kevinapavew, bruns, demsking, 
vkrause, sars, dhaumann

KDE CI: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.10 - Build # 205 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.10/205/
 Project:
Frameworks syntax-highlighting kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 01 Sep 2018 16:19:43 +
 Build duration:
8 min 15 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: TestSuite.htmlhighlighter_testFailed: TestSuite.testhighlighter_test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)85%
(35/41)85%
(35/41)80%
(2554/3201)68%
(1820/2681)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(8/8)100%
(8/8)98%
(619/630)63%
(369/584)examples0%
(0/2)0%
(0/2)0%
(0/193)0%
(0/98)src.cli0%
(0/1)0%
(0/1)0%
(0/89)0%
(0/40)src.indexer100%
(1/1)100%
(1/1)76%
(193/254)77%
(197/256)src.lib90%
(26/29)90%
(26/29)86%
(1742/2035)74%
(1254/1703)

D15207: precompute attribute format for context & rules

[Christoph Cullmann]

cullmann reopened this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Hmm, tests are unstable :/
  I did run them here now X times, they are stable. Perhaps depending on which 
highlightings got parsed in which order.
  Why should then the id's be equal for different definitions?
  
  e.g.
  
  QDEBUG : TestHighlighterTest::testHighlight(test.py) Using syntax "Python"
  
  - "/home/jenkins/workspace/Frameworks syntax-highlighting kf5-qt5 
SUSEQt5.9/autotests/reference/test.py.ref"  2018-09-01 16:10:03.327043830 +
  
  +++ "/home/jenkins/workspace/Frameworks syntax-highlighting kf5-qt5 
SUSEQt5.9/build/autotests/output/test.py.ref" 2018-09-01 16:13:08.885670252 
+
  @@ -1,6 +1,6 @@
  -# comment with ALERT
  +# comment with ALERT
   
  -''' multiline
  +''' multiline
   comment
   ###
   '''

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D15207

To: cullmann, vkrause, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

KDE CI: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9 - Build # 150 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.9/150/
 Project:
Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 01 Sep 2018 16:19:43 +
 Build duration:
3 min 2 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: TestSuite.htmlhighlighter_testFailed: TestSuite.testhighlighter_test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)85%
(35/41)85%
(35/41)80%
(2554/3201)68%
(1820/2681)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(8/8)100%
(8/8)98%
(619/630)63%
(369/584)examples0%
(0/2)0%
(0/2)0%
(0/193)0%
(0/98)src.cli0%
(0/1)0%
(0/1)0%
(0/89)0%
(0/40)src.indexer100%
(1/1)100%
(1/1)76%
(193/254)77%
(197/256)src.lib90%
(26/29)90%
(26/29)86%
(1742/2035)74%
(1254/1703)

KDE CI: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9 - Build # 149 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.9/149/
 Project:
Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 01 Sep 2018 16:08:38 +
 Build duration:
6 min 10 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: TestSuite.htmlhighlighter_testFailed: TestSuite.testhighlighter_test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)85%
(35/41)85%
(35/41)80%
(2554/3201)68%
(1820/2681)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(8/8)100%
(8/8)98%
(619/630)63%
(369/584)examples0%
(0/2)0%
(0/2)0%
(0/193)0%
(0/98)src.cli0%
(0/1)0%
(0/1)0%
(0/89)0%
(0/40)src.indexer100%
(1/1)100%
(1/1)76%
(193/254)77%
(197/256)src.lib90%
(26/29)90%
(26/29)86%
(1742/2035)74%
(1254/1703)

KDE CI: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.10 - Build # 204 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.10/204/
 Project:
Frameworks syntax-highlighting kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 01 Sep 2018 16:08:38 +
 Build duration:
3 min 5 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: TestSuite.htmlhighlighter_testFailed: TestSuite.testhighlighter_test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)85%
(35/41)85%
(35/41)80%
(2554/3201)68%
(1820/2681)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(8/8)100%
(8/8)98%
(619/630)63%
(369/584)examples0%
(0/2)0%
(0/2)0%
(0/193)0%
(0/98)src.cli0%
(0/1)0%
(0/1)0%
(0/89)0%
(0/40)src.indexer100%
(1/1)100%
(1/1)76%
(193/254)77%
(197/256)src.lib90%
(26/29)90%
(26/29)86%
(1742/2035)74%
(1254/1703)

D15207: precompute attribute format for context & rules

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:91d29a45389e: precompute attribute format for context 
 rules (authored by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15207?vs=40826=40827

REVISION DETAIL
  https://phabricator.kde.org/D15207

AFFECTED FILES
  autotests/html/csharp.cs.html
  autotests/html/highlight.cmake.html
  autotests/html/highlight.cpp.html
  autotests/html/highlight.css.html
  autotests/html/highlight.dox.html
  autotests/html/highlight.hs.html
  autotests/html/highlight.js.html
  autotests/html/highlight.lhs.html
  autotests/html/highlight.lua.html
  autotests/html/highlight.qml.html
  autotests/html/highlight.tex.html
  autotests/html/highlight.y.html
  autotests/html/modelines.py.html
  autotests/html/test.Rd.html
  autotests/html/test.coffee.html
  autotests/html/test.htm.html
  autotests/html/test.js.html
  autotests/html/test.py.html
  autotests/html/test.qml.html
  autotests/html/test.te.html
  autotests/reference/csharp.cs.ref
  autotests/reference/highlight.cmake.ref
  autotests/reference/highlight.cpp.ref
  autotests/reference/highlight.css.ref
  autotests/reference/highlight.dox.ref
  autotests/reference/highlight.gdb.ref
  autotests/reference/highlight.hs.ref
  autotests/reference/highlight.js.ref
  autotests/reference/highlight.lhs.ref
  autotests/reference/highlight.lua.ref
  autotests/reference/highlight.qml.ref
  autotests/reference/highlight.tex.ref
  autotests/reference/highlight.y.ref
  autotests/reference/modelines.py.ref
  autotests/reference/review128925-1.css.ref
  autotests/reference/review128925-2.css.ref
  autotests/reference/test.Rd.ref
  autotests/reference/test.coffee.ref
  autotests/reference/test.htm.ref
  autotests/reference/test.js.ref
  autotests/reference/test.jsx.ref
  autotests/reference/test.py.ref
  autotests/reference/test.qml.ref
  autotests/reference/test.te.ref
  src/lib/CMakeLists.txt
  src/lib/abstracthighlighter.cpp
  src/lib/context.cpp
  src/lib/context_p.h
  src/lib/definition.cpp
  src/lib/matchresult.cpp
  src/lib/matchresult_p.h
  src/lib/repository.cpp
  src/lib/rule.cpp
  src/lib/rule_p.h

To: cullmann, vkrause, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D15207: precompute attribute format for context & rules

[Volker Krause]

vkrause accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15207

To: cullmann, vkrause, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D7909: Add syntax support for Crystal Programming Language

[Christoph Cullmann]

cullmann added a comment.


  Hi, any update on this?

REPOSITORY
  R40 Kate

REVISION DETAIL
  https://phabricator.kde.org/D7909

To: faguilar, dhaumann, vkrause, #framework_syntax_highlighting, #kate, mwolff, 
cullmann
Cc: kwrite-devel, oprypin, mwolff, cullmann, ngraham, #kate, #frameworks, 
faguilar, bmortimer, michaelh, genethomas, kevinapavew, bruns, demsking, 
vkrause, sars, dhaumann

D15207: precompute attribute format for context & rules

[Christoph Cullmann]

cullmann added a comment.


  I inlined the MatchResult, it is used the whole time and given it is purely 
internal, one doesn't need to waste cycles for having calls to get the two ints 
and the reference to the stringlist.
  The implicit constructor now doesn't play around with the stringlist either.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D15207

To: cullmann, vkrause, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D15207: precompute attribute format for context & rules

[Christoph Cullmann]

cullmann updated this revision to Diff 40826.
cullmann added a comment.


  inline MatchResult, very often used, no need to waste time for calls
  
  fix scoping in Repository::definitionForMimeType

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15207?vs=40825=40826

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15207

AFFECTED FILES
  autotests/html/csharp.cs.html
  autotests/html/highlight.cmake.html
  autotests/html/highlight.cpp.html
  autotests/html/highlight.css.html
  autotests/html/highlight.dox.html
  autotests/html/highlight.hs.html
  autotests/html/highlight.js.html
  autotests/html/highlight.lhs.html
  autotests/html/highlight.lua.html
  autotests/html/highlight.qml.html
  autotests/html/highlight.tex.html
  autotests/html/highlight.y.html
  autotests/html/modelines.py.html
  autotests/html/test.Rd.html
  autotests/html/test.coffee.html
  autotests/html/test.htm.html
  autotests/html/test.js.html
  autotests/html/test.py.html
  autotests/html/test.qml.html
  autotests/html/test.te.html
  autotests/reference/csharp.cs.ref
  autotests/reference/highlight.cmake.ref
  autotests/reference/highlight.cpp.ref
  autotests/reference/highlight.css.ref
  autotests/reference/highlight.dox.ref
  autotests/reference/highlight.gdb.ref
  autotests/reference/highlight.hs.ref
  autotests/reference/highlight.js.ref
  autotests/reference/highlight.lhs.ref
  autotests/reference/highlight.lua.ref
  autotests/reference/highlight.qml.ref
  autotests/reference/highlight.tex.ref
  autotests/reference/highlight.y.ref
  autotests/reference/modelines.py.ref
  autotests/reference/review128925-1.css.ref
  autotests/reference/review128925-2.css.ref
  autotests/reference/test.Rd.ref
  autotests/reference/test.coffee.ref
  autotests/reference/test.htm.ref
  autotests/reference/test.js.ref
  autotests/reference/test.jsx.ref
  autotests/reference/test.py.ref
  autotests/reference/test.qml.ref
  autotests/reference/test.te.ref
  src/lib/CMakeLists.txt
  src/lib/abstracthighlighter.cpp
  src/lib/context.cpp
  src/lib/context_p.h
  src/lib/definition.cpp
  src/lib/matchresult.cpp
  src/lib/matchresult_p.h
  src/lib/repository.cpp
  src/lib/rule.cpp
  src/lib/rule_p.h

To: cullmann, vkrause, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D15207: precompute attribute format for context & rules

[Christoph Cullmann]

cullmann created this revision.
cullmann added reviewers: vkrause, dhaumann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
cullmann requested review of this revision.

REVISION SUMMARY
  avoid costly lookup, e.g. 3% of runtime of highlighting
  
  simplifies the highlightLine stuff, as we only need to keep track of format 
changes,
  not lookup contexts in addition
  
  fixes that we don't see that formats change if name is equal in different
  definitions
  
  accessors are inline, the classes are internal anyways

TEST PLAN
  make && make test
  
  updated references, now we properly applyFormat if we walk from one into a 
other
  definition with same name formats

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15207

AFFECTED FILES
  autotests/html/csharp.cs.html
  autotests/html/highlight.cmake.html
  autotests/html/highlight.cpp.html
  autotests/html/highlight.css.html
  autotests/html/highlight.dox.html
  autotests/html/highlight.hs.html
  autotests/html/highlight.js.html
  autotests/html/highlight.lhs.html
  autotests/html/highlight.lua.html
  autotests/html/highlight.qml.html
  autotests/html/highlight.tex.html
  autotests/html/highlight.y.html
  autotests/html/modelines.py.html
  autotests/html/test.Rd.html
  autotests/html/test.coffee.html
  autotests/html/test.htm.html
  autotests/html/test.js.html
  autotests/html/test.py.html
  autotests/html/test.qml.html
  autotests/html/test.te.html
  autotests/reference/csharp.cs.ref
  autotests/reference/highlight.cmake.ref
  autotests/reference/highlight.cpp.ref
  autotests/reference/highlight.css.ref
  autotests/reference/highlight.dox.ref
  autotests/reference/highlight.gdb.ref
  autotests/reference/highlight.hs.ref
  autotests/reference/highlight.js.ref
  autotests/reference/highlight.lhs.ref
  autotests/reference/highlight.lua.ref
  autotests/reference/highlight.qml.ref
  autotests/reference/highlight.tex.ref
  autotests/reference/highlight.y.ref
  autotests/reference/modelines.py.ref
  autotests/reference/review128925-1.css.ref
  autotests/reference/review128925-2.css.ref
  autotests/reference/test.Rd.ref
  autotests/reference/test.coffee.ref
  autotests/reference/test.htm.ref
  autotests/reference/test.js.ref
  autotests/reference/test.jsx.ref
  autotests/reference/test.py.ref
  autotests/reference/test.qml.ref
  autotests/reference/test.te.ref
  src/lib/abstracthighlighter.cpp
  src/lib/context.cpp
  src/lib/context_p.h
  src/lib/definition.cpp
  src/lib/rule.cpp
  src/lib/rule_p.h

To: cullmann, vkrause, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.11 - Build # 14 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.11/14/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.11
 Date of build:
Sat, 01 Sep 2018 15:12:15 +
 Build duration:
7 min 57 sec and counting

KDE CI: Frameworks threadweaver kf5-qt5 FreeBSDQt5.11 - Build # 3 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20threadweaver%20kf5-qt5%20FreeBSDQt5.11/3/
 Project:
Frameworks threadweaver kf5-qt5 FreeBSDQt5.11
 Date of build:
Sat, 01 Sep 2018 15:12:21 +
 Build duration:
4 min 25 sec and counting

KDE CI: Frameworks solid kf5-qt5 FreeBSDQt5.11 - Build # 4 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20solid%20kf5-qt5%20FreeBSDQt5.11/4/
 Project:
Frameworks solid kf5-qt5 FreeBSDQt5.11
 Date of build:
Sat, 01 Sep 2018 15:12:19 +
 Build duration:
4 min 0 sec and counting

KDE CI: Frameworks kinit kf5-qt5 FreeBSDQt5.11 - Build # 3 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kinit%20kf5-qt5%20FreeBSDQt5.11/3/
 Project:
Frameworks kinit kf5-qt5 FreeBSDQt5.11
 Date of build:
Sat, 01 Sep 2018 15:12:14 +
 Build duration:
2 min 39 sec and counting

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.11 - Build # 3 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.11/3/
 Project:
Frameworks kwayland kf5-qt5 FreeBSDQt5.11
 Date of build:
Sat, 01 Sep 2018 15:12:18 +
 Build duration:
3 min 50 sec and counting

KDE CI: Frameworks khtml kf5-qt5 FreeBSDQt5.11 - Build # 4 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20khtml%20kf5-qt5%20FreeBSDQt5.11/4/
 Project:
Frameworks khtml kf5-qt5 FreeBSDQt5.11
 Date of build:
Sat, 01 Sep 2018 15:12:12 +
 Build duration:
2 min 45 sec and counting

KDE CI: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.11 - Build # 4 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.11/4/
 Project:
Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.11
 Date of build:
Sat, 01 Sep 2018 15:12:10 +
 Build duration:
2 min 54 sec and counting

KDE CI: Frameworks kjs kf5-qt5 FreeBSDQt5.11 - Build # 3 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kjs%20kf5-qt5%20FreeBSDQt5.11/3/
 Project:
Frameworks kjs kf5-qt5 FreeBSDQt5.11
 Date of build:
Sat, 01 Sep 2018 15:12:17 +
 Build duration:
3 min 17 sec and counting

KDE CI: Frameworks kiconthemes kf5-qt5 FreeBSDQt5.11 - Build # 4 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kiconthemes%20kf5-qt5%20FreeBSDQt5.11/4/
 Project:
Frameworks kiconthemes kf5-qt5 FreeBSDQt5.11
 Date of build:
Sat, 01 Sep 2018 15:12:13 +
 Build duration:
1 min 31 sec and counting

KDE CI: Frameworks kdesu kf5-qt5 FreeBSDQt5.11 - Build # 3 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kdesu%20kf5-qt5%20FreeBSDQt5.11/3/
 Project:
Frameworks kdesu kf5-qt5 FreeBSDQt5.11
 Date of build:
Sat, 01 Sep 2018 15:12:11 +
 Build duration:
29 sec and counting

KDE CI: Frameworks kcrash kf5-qt5 FreeBSDQt5.11 - Build # 3 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kcrash%20kf5-qt5%20FreeBSDQt5.11/3/
 Project:
Frameworks kcrash kf5-qt5 FreeBSDQt5.11
 Date of build:
Sat, 01 Sep 2018 15:12:06 +
 Build duration:
41 sec and counting

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.11 - Build # 6 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.11/6/
 Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.11
 Date of build:
Sat, 01 Sep 2018 15:10:11 +
 Build duration:
45 sec and counting

D13700: implement reading of the replaygain tags

[Alexander Stippich]

astippich added inline comments.

INLINE COMMENTS

> mgallien wrote in taglibextractor.cpp:944
> Could you check if it is not faster to use QLatin1String here ?

At least if my interpretations of callgrind are correct, it's exactly the same.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D13700

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D13700: implement reading of the replaygain tags

[Alexander Stippich]

astippich updated this revision to Diff 40824.
astippich marked 5 inline comments as done.
astippich added a comment.


  - add documentation, remove unrelated changes and debug info
  - get rid of string comparisons for id3v2

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13700?vs=36901=40824

BRANCH
  replaygain

REVISION DETAIL
  https://phabricator.kde.org/D13700

AFFECTED FILES
  autotests/samplefiles/test.flac
  autotests/samplefiles/test.mp3
  autotests/samplefiles/test.mpc
  autotests/samplefiles/test.ogg
  autotests/samplefiles/test.opus
  autotests/taglibextractortest.cpp
  src/extractors/taglibextractor.cpp
  src/extractors/taglibextractor.h
  src/properties.h
  src/propertyinfo.cpp

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D15194: Draw a line separating PlasmaComponents tab bar from its content area

[Nathaniel Graham]

ngraham added a reviewer: VDG.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15194

To: ngraham, #plasma, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15113: Add license text of GPL 2.0, LGPL 2.0 and LGPL 2.1

[Fabian Vogt]

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:bfbef9f61a17: Add license text of GPL 2.0, LGPL 2.0 and 
LGPL 2.1 (authored by fvogt).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15113?vs=40535=40820

REVISION DETAIL
  https://phabricator.kde.org/D15113

AFFECTED FILES
  COPYING.GPLv2
  COPYING.LGPLv2.0
  COPYING.LGPLv2.1

To: fvogt, #frameworks, elvisangelaccio
Cc: lbeltrame

D15113: Add license text of GPL 2.0, LGPL 2.0 and LGPL 2.1

[Elvis Angelaccio]

elvisangelaccio accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R320 KIO Extras

BRANCH
  Applications/18.08

REVISION DETAIL
  https://phabricator.kde.org/D15113

To: fvogt, #frameworks, elvisangelaccio
Cc: lbeltrame

D15076: Build failures with KSyntaxHighlighting 5.49

[Elvis Angelaccio]

elvisangelaccio added a comment.


  Hmm, I can only think of renaming the `cantor` folder to something else (but 
that would probably be annoying for packagers...)

REPOSITORY
  R55 Cantor

REVISION DETAIL
  https://phabricator.kde.org/D15076

To: asemke, #kde_edu, #cantor, #frameworks
Cc: elvisangelaccio, dfaure, cgiboudeaux, mpyne, cullmann, kde-edu, narvaez, 
apol

D8256: Add _XOPEN_SOURCE to C definitions

[David Faure]

dfaure added a comment.


  Indeed,
  
  22:23:51 In file included from /usr/include/sys/mount.h:36:
  22:23:51 /usr/include/sys/ucred.h:84:2: error: unknown type name 'u_int'; did 
you mean 'uint'?
  22:23:51 u_int   cr_version; /* structure layout version 
*/
  22:23:51 ^
  
  
https://build.kde.org/view/Frameworks/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.11/5/console
  
  I'll revert.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D8256

To: awilcox, alexmerry, dfaure
Cc: bcooksley, #freebsd, kde-frameworks-devel, kde-buildsystem, mpyne, dfaure, 
michaelh, ngraham, bruns

D15196: avoid word delimiter check at start of keyword

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:2475bc4dd2ca: avoid word delimiter check at start of 
keyword (authored by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15196?vs=40801=40802

REVISION DETAIL
  https://phabricator.kde.org/D15196

AFFECTED FILES
  autotests/folding/test.py.fold
  autotests/html/test.coffee.html
  autotests/html/test.py.html
  autotests/input/test.py
  autotests/reference/test.coffee.ref
  autotests/reference/test.py.ref
  src/lib/rule.cpp

To: cullmann, vkrause, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D11776: Make use of upstream CMake infrastructure to detect the compiler toolchain

[Volker Krause]

vkrause added a comment.


  In D11776#318339 , @Martchus wrote:
  
  > @vkrause Thanks for confirming. So it is not a local issue. Could you find 
a workaround (beside reverting these changes)?
  
  
  I edit the file `stl` in the build dir to strip out the additional -lxxx 
entries, but that has to be redone after every  cmake run. Haven't found the 
time to properly investigate this yet unfortunately.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D11776

To: apol, #frameworks, #build_system, vkrause
Cc: kde-frameworks-devel, kde-buildsystem, Martchus, vkrause, michaelh, 
ngraham, bruns

D15196: avoid word delimiter check at start of keyword

[Volker Krause]

vkrause accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15196

To: cullmann, vkrause, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D15196: avoid word delimiter check at start of keyword

[Christoph Cullmann]

cullmann created this revision.
cullmann added reviewers: vkrause, dhaumann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
cullmann requested review of this revision.

REVISION SUMMARY
  be compatible with old KTextEditor implementation
  
  BUG: 397719

TEST PLAN
  added test for python showing the error
  works now
  only other diff in coffee, looks not wrong, function as keyword
  
  make && make test

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15196

AFFECTED FILES
  autotests/folding/test.py.fold
  autotests/html/test.coffee.html
  autotests/html/test.py.html
  autotests/input/test.py
  autotests/reference/test.coffee.ref
  autotests/reference/test.py.ref
  src/lib/rule.cpp

To: cullmann, vkrause, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann