KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.11 - Build # 6 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.11/6/ Project: Frameworks kio kf5-qt5 WindowsMSVCQt5.11 Date of build: Sun, 02 Sep 2018 19:25:46 + Build duration: 1 hr 16 min and counting JUnit Tests

D15076: Build failures with KSyntaxHighlighting 5.49

dfaure added a comment. Yes, maybe rename cantor to cantorplugins? The plugins dir already has some subdirs named plasmacalendarplugins or ruqolaplugins. Of course the loading code has to be adapted accordingly. We need the plugins in the bin dir for autotests to be able to loca

D12587: Indentation script for R

devillemereuil added a comment. Will do. Thanks! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12587 To: devillemereuil, #ktexteditor, #rkward, cullmann Cc: kwrite-devel, kde-frameworks-devel, cullmann, tfry, dhaumann, michaelh, kevinapavew, ngraham, bruns, dem

D12587: Indentation script for R

cullmann added a comment. I normally follow the steps on https://community.kde.org/Guidelines_and_HOWTOs/Build_from_source and just do kdesrc-build ktexteditor after the initial setup. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12587 To: devillemere

D15213: Link 16px icon folders to 16@2

rizzitello added a comment. In D15213#319039 , @broulik wrote: > I think the suffix should be `@2x`, not just `@2`. Also, I don't think it's neccessary for the `animation` folder. > Anyway, without the `ScalableIcons` entry in `index.theme` te

D12587: Indentation script for R

devillemereuil added a comment. I... git cloned ktexteditor and ran `cmake .`? Is there a better way? Sorry, I'm a real newb in this as you can probably tell! I'm not a dev by training. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12587 To: devillemereuil, #kt

D12587: Indentation script for R

cullmann added a comment. And btw., thanks that you work on that stuff! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12587 To: devillemereuil, #ktexteditor, #rkward, cullmann Cc: kwrite-devel, kde-frameworks-devel, cullmann, tfry, dhaumann, michaelh, kevinapav

D12587: Indentation script for R

cullmann added a comment. Hi, the message means you need to update the extra-cmake-modules. How did you compile the stuff? If you use kdesrc-build, I would just let that run once more. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12587 To: devillemereuil,

D12587: Indentation script for R

devillemereuil added a comment. OK. So, that'll require compile ktexteditor from source. I should be able to manage that (I guess?). I'll report here if it gives me too many headaches. I tried today, but gave up because of an issue with ECM (?) version. I got: Could not find a configur

D12587: Indentation script for R

cullmann added a comment. You might need a .kateconfig in the R folder like in e.g. the cstyle folder which tells "use R highlighting and R indenter" REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12587 To: devillemereuil, #ktexteditor, #rkward, cullmann Cc: kwr

D12587: Indentation script for R

cullmann added a comment. I added these lines https://commits.kde.org/ktexteditor/784302a921b8e1fafd6d32cf172552eaea1775bf If you do make, you can later in the build folder run: ./bin/kateindenttest ATM it will tell at the end: SKIP : IndentTest::testR() /home/cullma

D12587: Indentation script for R

cullmann added a comment. Ok, here the basic idea: in autotests/src/identtest.cpp and .h > in .h === add some void testR_data(); void testR(); > in .cpp = add some void IndentTest::testR_data() { getTestData("R"); }

D12587: Indentation script for R

devillemereuil added a comment. That's the thing: I don't know how to run the test. If it requires dealing with cmake and stuff, that's take me a while to figure out. Is there any simple documentation about it? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D1258

D13700: implement reading of the replaygain tags

bruns added inline comments. INLINE COMMENTS > taglibextractor.cpp:50 > { > return QString::fromWCharArray((const wchar_t*)t.toCWString(), > t.length()); > } This is definitely broken: http://taglib.org/api/classTagLib_1_1String.html#a0ef8ad270d710863e0bb1c1b18cdb95d `const wchar_t* Tag

D12587: Indentation script for R

cullmann added a comment. You don't need to commit them. You just can add them locally test by test and after each one run the indent test locally. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12587 To: devillemereuil, #ktexteditor, #rkward, cullmann Cc: kwr

D12587: Indentation script for R

devillemereuil added a comment. So, basically, I just write a bunch of tests, commit them here and we'll debug them if needed from here? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12587 To: devillemereuil, #ktexteditor, #rkward, cullmann Cc: kwrite-devel, kd

D12587: Indentation script for R

cullmann added a comment. The easiest way is just to put the test in the autotests input like for other highlighters and then run the indent test, that will pick this up and tell you what happens. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12587 To: deville

D12587: Indentation script for R

devillemereuil added a comment. Say that I have the files for a unit test (origin, input.js and expected). How can I check the code for the unit test? Is there a way to simply execute the javascript code and verify it does what I expect? It would be a shame to have the unit test fail because

D15219: forbid sub-rules

cullmann added a comment. Documentation updated. The regressions for highlightings outside the repo should be minimal, as we just ignore the suffix rules. REPOSITORY R40 Kate REVISION DETAIL https://phabricator.kde.org/D15219 To: cullmann, vkrause, dhaumann Cc: kde-doc-english, kwrite

D15219: forbid sub-rules

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R40:8f32f2df2d7f: remove child rule description, no longer supported (authored by cullmann). Herald added a project: Documen

D15219: forbid sub-rules

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R216:376311622d37: forbid sub-rules (authored by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D15219: forbid sub-rules

cullmann reopened this revision. cullmann added a comment. Need to update the docs. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D15219 To: cullmann, vkrause, dhaumann Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsk

D15219: forbid sub-rules

cullmann added a comment. I will push this + adapt the kate.git docs for it. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D15219 To: cullmann, vkrause, dhaumann Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cu

D15213: Link 16px icon folders to 16@2

broulik added a comment. I think the suffix should be `@2x`, not just `@2`. Also, I don't think it's neccessary for the `animation` folder. Anyway, without the `ScalableIcons` entry in `index.theme` testing this is difficult REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabric

KDE CI: Frameworks syntax-highlighting kf5-qt5 WindowsMSVCQt5.11 - Build # 40 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20WindowsMSVCQt5.11/40/ Project: Frameworks syntax-highlighting kf5-qt5 WindowsMSVCQt5.11 Date of build: Sun, 02 Sep 2018 16:18:05 + Build duration: 3 min 0 sec and c

KDE CI: Frameworks syntax-highlighting kf5-qt5 WindowsMSVCQt5.11 - Build # 39 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20WindowsMSVCQt5.11/39/ Project: Frameworks syntax-highlighting kf5-qt5 WindowsMSVCQt5.11 Date of build: Sun, 02 Sep 2018 15:48:53 + Build duration: 28 min and count

KDE CI: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.10 - Build # 213 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.10/213/ Project: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.10 Date of build: Sun, 02 Sep 2018 15:48:53 + Build duration: 4 min 8 sec and counting

KDE CI: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.10 - Build # 212 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.10/212/ Project: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.10 Date of build: Sun, 02 Sep 2018 15:24:53 + Build duration: 18 min and counting JU

D15180: kioexecd: watch for creations or modifications of the temporary files

jtamate edited the summary of this revision. jtamate edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15180 To: jtamate, #frameworks, broulik, ngraham, dfaure Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D8256: Add _XOPEN_SOURCE to C definitions

mpyne added a comment. Sorry, if I'd been able to check this earlier I'd have warned against pushing, this was the kind of concern I was addressing with my earlier comment about FreeBSD. I had run into a lot of those issues when trying to get KF5 to build on Alpine. Adding an _XOPEN_SOU

D15217: Tune KeywordList lookup

cullmann added a comment. And yes, the skip offset lookup is still deadly ;=) 8.27% 8.27% highlighter_ben libKF5SyntaxHighlighting.so.5.50.0 [.] QHash::findNode REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D15217 To: cullmann, vkrause, dh

D15219: forbid sub-rules

vkrause added a comment. no objections to the idea, should indeed simplify things REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D15219 To: cullmann, vkrause, dhaumann Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demskin

D15219: forbid sub-rules

cullmann updated this revision to Diff 40860. cullmann added a comment. converted all highlightings to use contexts instead of sub-rules REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15219?vs=40859&id=40860 BRANCH master REVISION DETAIL h

D15217: Tune KeywordList lookup & avoid allocations for implicit capture group

cullmann retitled this revision from "Tune KeywordList lookup" to "Tune KeywordList lookup & avoid allocations for implicit capture group". REVISION DETAIL https://phabricator.kde.org/D15217 To: cullmann, vkrause, dhaumann Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham,

D15219: forbid sub-rules

cullmann updated this revision to Diff 40859. cullmann added a comment. more sub-rules replaced with contexts REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15219?vs=40857&id=40859 BRANCH master REVISION DETAIL https://phabricator.kde.org/

D15220: implement more basic tags for taglibwriter

astippich updated this revision to Diff 40861. astippich added a comment. - use different test data REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15220?vs=40858&id=40861 BRANCH taglib_write REVISION DETAIL https://phabricator.kde.org/D15220 AF

D15217: Tune KeywordList lookup

cullmann added a comment. perf before: F6230373: perf.xZfpV.svg F6230374: perf.xZfpV.txt REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D15217 To: cullmann, vkrause, dhaum

D14757: Warn user before copy operation if available space is not enough

shubham added inline comments. INLINE COMMENTS > pino wrote in copyjob.cpp:891 > Uninitialized pointer, this will crash two lines later... > Also, this is the base class of the private class used for this job, and this > function is part of that class already; so why aren't you just invoking it?

D15220: implement more basic tags for taglibwriter

astippich created this revision. astippich added reviewers: mgallien, bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY implement all basic tags directly provided by taglib for the

D13700: implement reading of the replaygain tags

astippich added inline comments. INLINE COMMENTS > bruns wrote in taglibextractor.cpp:255 > you can use TStringToQString > `data.replayGainTrackGain = > TStringToQString(userTextFrame->fieldList().back());` toCString() was actually completely unnecessary. I removed it since convertWChartsToQSt

D13700: implement reading of the replaygain tags

astippich updated this revision to Diff 40851. astippich marked 4 inline comments as done. astippich added a comment. - improve readability and add check REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13700?vs=40824&id=40851 BRANCH replaygain REVI

D15217: Tune KeywordList lookup & avoid allocations for implicit capture group

vkrause accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://phabricator.kde.org/D15217 To: cullmann, vkrause, dhaumann Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann

D15219: forbid sub-rules

cullmann updated this revision to Diff 40862. cullmann added a comment. remove sub-rules support now we do all things just with flat rules + flat contexts REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15219?vs=40860&id=40862 BRANCH mast

D15217: Tune KeywordList lookup

cullmann updated this revision to Diff 40852. cullmann added a comment. Avoid saving the implicit capture group 0 on each regex match. That avoids allocating the match string each time (and the non-empty list). One anyways shall only access capture group >= 1 CHANGES SINCE LAST UPDATE ht

D15217: Tune KeywordList lookup

cullmann added a comment. perf after the change F6230377: perf.2U8ac.svg F6230378: perf.2U8ac.txt REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D15217 To: cullmann, vkrause,

D14632: keyword rule: Spport for keywords inclusion from another language/file

cullmann added a comment. For the keywords stuff, one must keep in mind I altered the implementation of keyword lists a lot in: https://phabricator.kde.org/D15217 REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14632 To: jpoelen, #framework_syntax_h

D15217: Tune KeywordList lookup & avoid allocations for implicit capture group

This revision was automatically updated to reflect the committed changes. Closed by commit R216:a492c36d3ca5: Tune KeywordList lookup & avoid allocations for implicit capture group (authored by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.o

D15219: forbid sub-rules

cullmann added a comment. ::load will skip over no longer supported sub-rules, beside minimal breakage for non-shipped hls, all should be fine (the suffixes will lack HL) REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D15219 To: cullmann, vkrause, dhauma

D15219: forbid sub-rules

cullmann added a comment. Done with all shipped things. make && make test still works Code is nicer, no nesting, we just can call doMatch, that btw. saves again 3-4% of overhead of ::match. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D15219

D15219: forbid sub-rules

cullmann updated this revision to Diff 40863. cullmann added a comment. fix comments in schema, no child rules REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15219?vs=40862&id=40863 BRANCH master REVISION DETAIL https://phabricator.kde.org

D14757: Warn user before copy operation if available space is not enough

shubham added a comment. @dfaure @pino help? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14757 To: shubham, pino, dfaure, cfeck Cc: dfaure, pino, kde-frameworks-devel, michaelh, ngraham, bruns

D15217: Tune KeywordList lookup & avoid allocations for implicit capture group

cullmann added a comment. Now the QRegularExpression::match call is the real offender allocation wise. REVISION DETAIL https://phabricator.kde.org/D15217 To: cullmann, vkrause, dhaumann Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars,

D15219: forbid sub-rules

cullmann created this revision. cullmann added reviewers: vkrause, dhaumann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. cullmann requested review of this revision. REVISION SUMMARY sub-rules are a hassle they are only allowed for i

D15217: Tune KeywordList lookup

cullmann created this revision. cullmann added reviewers: vkrause, dhaumann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. cullmann requested review of this revision. REVISION SUMMARY No longer any allocations, we use sorted vectors for lo

D15180: kioexecd: watch for creations or modifications of the temporary files

elvisangelaccio added a comment. I don't understand what's the counter used for. Can you explain why we need it and can you update the Test plan accordingly? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15180 To: jtamate, #frameworks, broulik, ngraham, dfaure Cc: elv

D15211: ::match and ::doMatch => const

cullmann added a comment. Done: https://phabricator.kde.org/R40:7e3292bffc3012d20c0d4df2de0b1a8bab0ca886 Removed mentioning of "dynamic" for contexts, too, that is no longer used at all. Should purge it from XSD, too. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://

D15211: ::match and ::doMatch => const

dhaumann added a comment. @cullmann Can you update the docbook in kate.git/doc/ so that the documentation about writing syntax highlighting files keeps up to date also for the dynamic changes? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D15211 To: cu

D15211: ::match and ::doMatch => const

This revision was automatically updated to reflect the committed changes. Closed by commit R216:96ec243322ef: ::match and ::doMatch => const (authored by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15211?vs=40836&id=40845 REVISION DE

D15211: ::match and ::doMatch => const

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D15211 To: cullmann, vkrause, dhaumann Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bru