D15258: Remove random kio output

2018-09-03 Thread Nathaniel Graham
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D15258 To: apol, #frameworks, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15240: Create a default wallet when user refuses to do so

2018-09-03 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. This strikes me as likely to cause intense frustration. Consider the following dramatized dialogue between a user and the computer: User: "Neat, I just set up this KDE

D15189: [KRun] Don’t follow redirection to speed up and avoid incorrect behavior

2018-09-03 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15189 To: achauvel, #frameworks, dfaure, cfeck Cc: anthonyfieroni, ngraham, kde-frameworks-devel, michaelh, bruns

D15258: Remove random kio output

2018-09-03 Thread Aleix Pol Gonzalez
apol created this revision. apol added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY It's not even categorised and it seems more like someone was actually debugging something

D15213: Provide icons for 2x scaling

2018-09-03 Thread Chris Rizzitello
rizzitello retitled this revision from "Link 16px icon folders to 16@2" to "Provide icons for 2x scaling". rizzitello edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D15213 To: rizzitello, #vdg, #plasma Cc: broulik,

D15252: [KPropertiesDialog] Use QIcon::fromTheme rather than KIconLoader::loadIcon

2018-09-03 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15252 To: broulik, #frameworks, #vdg, davidedmundson, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15213: Link 16px icon folders to 16@2

2018-09-03 Thread Kai Uwe Broulik
broulik added a comment. Thanks a lot! There's a quirk in Dolphin where it wouldn't pick up the 22px places icons as in `KStandardItemListWidget::pixmapForIcon` it scales the size (22→44) first and then clamps it to an icon size (48) and so it won't find the fixed 22. Also, the problem

D15213: Link 16px icon folders to 16@2

2018-09-03 Thread Chris Rizzitello
rizzitello updated this revision to Diff 40942. rizzitello added a comment. - Link 24 to 24@2x - Link actions/32 to actions/32@2x REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15213?vs=40941=40942 BRANCH 2xIcons REVISION DETAIL

D15213: Link 16px icon folders to 16@2

2018-09-03 Thread Chris Rizzitello
rizzitello updated this revision to Diff 40941. rizzitello added a comment. - Add 22@2x links REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15213?vs=40934=40941 BRANCH 2xIcons REVISION DETAIL https://phabricator.kde.org/D15213 AFFECTED FILES

D15252: [KPropertiesDialog] Use QIcon::fromTheme rather than KIconLoader::loadIcon

2018-09-03 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Frameworks, VDG, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY The former knows high dpi scaling TEST PLAN Before

D15213: Link 16px icon folders to 16@2

2018-09-03 Thread Chris Rizzitello
rizzitello updated this revision to Diff 40934. rizzitello added a comment. - 16@2x icons - icon.theme updated REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15213?vs=40840=40934 BRANCH 16@2x REVISION DETAIL https://phabricator.kde.org/D15213

D15251: Fix autotests with -DBUILD_QCH:BOOL=TRUE

2018-09-03 Thread Heiko Becker
heikobecker created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. heikobecker requested review of this revision. REVISION SUMMARY After 507415c54bd111fbb35716bd9809119d990f9a16

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 207 - Still Unstable!

2018-09-03 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/207/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Mon, 03 Sep 2018 16:45:52 + Build duration: 2 min 57 sec and counting

D14946: [DialogShadows] Use 0 offset for disabled borders on Wayland

2018-09-03 Thread Vlad Zagorodniy
This revision was automatically updated to reflect the committed changes. Closed by commit R242:8497832a8bf0: [DialogShadows] Use 0 offset for disabled borders on Wayland (authored by zzag). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D15242: RFC: [KFileItem] Handle permissions ourselves in isReadable()/isWritable()

2018-09-03 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: dfaure, elvisangelaccio, fvogt, lbeltrame. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Avoids creating a `QFileInfo` which might block

D15180: kioexecd: watch for creations or modifications of the temporary files

2018-09-03 Thread Anthony Fieroni
anthonyfieroni added inline comments. INLINE COMMENTS > kioexecd.cpp:80 > +{ > +if (!m_deleted.contains(path)) { > +return; Contains should be also in the guard. > kioexecd.h:40 > virtual ~KIOExecd(); > +void clearDir(const QString ); > Unused? REPOSITORY R241 KIO

D15180: kioexecd: watch for creations or modifications of the temporary files

2018-09-03 Thread Anthony Fieroni
anthonyfieroni added inline comments. INLINE COMMENTS > kioexecd.cpp:134 > +QDir(parentDir).removeRecursively(); > +it=m_deleted.erase(it); > +} Also for loop should looks like: for (it = begin(); it != end();) { if () { it =

D15240: Create a default wallet when user refuses to do so

2018-09-03 Thread Oleg Solovyov
McPain added a reviewer: Frameworks. REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D15240 To: McPain, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15240: Create a default wallet when user refuses to do so

2018-09-03 Thread Oleg Solovyov
McPain created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. McPain requested review of this revision. REVISION SUMMARY This patch allows creating a default wallet with empty password when user explicitly refuses to create one (tons of

D15180: kioexecd: watch for creations or modifications of the temporary files

2018-09-03 Thread Anthony Fieroni
anthonyfieroni added inline comments. INLINE COMMENTS > kioexecd.cpp:122 > +m_deleted_mutex.unlock(); > +QTimer::singleShot(31000, [this]() { // 31s > +m_deleted_mutex.lock(); Better to me, make a class variable single shot timer, then when you add in deleted start it if not,

D15180: kioexecd: watch for creations or modifications of the temporary files

2018-09-03 Thread Jaime Torres Amate
jtamate updated this revision to Diff 40908. jtamate edited the summary of this revision. jtamate edited the test plan for this revision. jtamate added a comment. As I'm never sure if a timed execution can happen in the middle of other execution, I've added a mutex for m_deleted. REPOSITORY

D14162: Figure out the escaped path list on kconfig

2018-09-03 Thread Aleix Pol Gonzalez
apol added a comment. ping? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D14162 To: apol, #frameworks, dfaure Cc: dfaure, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.11 - Build # 7 - Unstable!

2018-09-03 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.11/7/ Project: Frameworks kio kf5-qt5 WindowsMSVCQt5.11 Date of build: Mon, 03 Sep 2018 07:26:37 + Build duration: 3 hr 14 min and counting JUnit Tests

D15076: Build failures with KSyntaxHighlighting 5.49

2018-09-03 Thread Ben Cooksley
bcooksley added a comment. @dfaure That change was an urgent measure on my part, in order to allow KDevelop tests on the CI system to find something, and be able to complete successfully. At the moment they all hang due to being unable to find any plugins (they have an error popup...). The

D15180: kioexecd: watch for creations or modifications of the temporary files

2018-09-03 Thread Jaime Torres Amate
jtamate added a comment. In D15180#319314 , @anthonyfieroni wrote: > I'm unhappy with that stop watching is on exit == 0, so when it's not, somehow, containers will continue to grow, it'll result in higher memory usage and slower performance.

D15189: [KRun] Don’t follow redirection to speed up and avoid incorrect behavior

2018-09-03 Thread Mélanie Chauvel
achauvel updated this revision to Diff 40897. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15189?vs=40784=40897 REVISION DETAIL https://phabricator.kde.org/D15189 AFFECTED FILES src/widgets/krun.cpp To: achauvel, #frameworks, dfaure, cfeck Cc:

D15213: Link 16px icon folders to 16@2

2018-09-03 Thread Kai Uwe Broulik
broulik added a comment. About the `index.theme`, what you want to do is, for every folder duplicate the non-2x entry and add a `Scale=2` to it, e.g. [places/16] Size=16 Context=Places Type=Fixed add after it [places/16@2x] Size=16 Scale=2

D15180: kioexecd: watch for creations or modifications of the temporary files

2018-09-03 Thread Anthony Fieroni
anthonyfieroni added a comment. I'm unhappy with that stop watching is on exit == 0, so when it's not, somehow, containers will continue to grow, it'll result in higher memory usage and slower performance. So stop watching should not depend on process return code, also same command should

D15180: kioexecd: watch for creations or modifications of the temporary files

2018-09-03 Thread Jaime Torres Amate
jtamate updated this revision to Diff 40888. jtamate added a reviewer: elvisangelaccio. jtamate added a comment. Updated with the code that handles m_openedBy right. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15180?vs=40779=40888 REVISION DETAIL