D15240: Create a default wallet when user refuses to do so

2018-09-04 Thread Nathaniel Graham
ngraham added a comment. In D15240#319994 , @McPain wrote: > What could you say about stuff that doesn't work without wallet but stubborn user always _refuses_ to create one? I would say that the computer should conform to the user's

D15071: Don't draw frames and shadows around images with transparency

2018-09-04 Thread Nathaniel Graham
ngraham added a comment. Friendly ping! I'm getting the sense that nobody feels very strongly about this. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15071 To: ngraham, #frameworks, #dolphin, #vdg, broulik, cfeck Cc: anthonyfieroni, markg, abetts, bruns,

D15072: [server] Abort drag start on correct conditions and without posting error

2018-09-04 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH startDragAbortFix REVISION DETAIL https://phabricator.kde.org/D15072 To: romangg, #kwin, davidedmundson Cc: adridg, kde-frameworks-devel, michaelh, ngraham, bruns

D6513: Add support for Attica tags support

2018-09-04 Thread Christoph Feck
cfeck added inline comments. INLINE COMMENTS > atticaprovider.cpp:282 > +for (const Attica::DownloadDescription : > content.downloadUrlDescriptions()) { > +if(downloadschecker.filterAccepts(dli.tags())) { > +filterAcceptsDownloads =

D15180: kioexecd: watch for creations or modifications of the temporary files

2018-09-04 Thread Elvis Angelaccio
elvisangelaccio requested changes to this revision. elvisangelaccio added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kioexecd.cpp:65 > qCDebug(KIOEXEC) << "About to delete" << parentDir << "containing" > << info.fileName(); > -

D15072: [server] Abort drag start on correct conditions and without posting error

2018-09-04 Thread Adriaan de Groot
adridg added inline comments. INLINE COMMENTS > adridg wrote in datadevice_interface.cpp:103 > this looks like it's still missing a !, based on the explanation "when the > client does not have an implicit pointer grab" I need new glasses :) REPOSITORY R127 KWayland REVISION DETAIL

D15274: Don't require Qt5::XmlPatterns

2018-09-04 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R39:891ee97d541f: Dont require Qt5::XmlPatterns (authored by vkrause). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15274?vs=40997=40999 REVISION DETAIL

D15274: Don't require Qt5::XmlPatterns

2018-09-04 Thread Dominik Haumann
dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Is this due to drop of own hl implementation? In any case, lgtm. REPOSITORY R39 KTextEditor BRANCH master REVISION DETAIL https://phabricator.kde.org/D15274 To: vkrause,

D15274: Don't require Qt5::XmlPatterns

2018-09-04 Thread Volker Krause
vkrause created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. vkrause requested review of this revision. REVISION SUMMARY Seems unused. REPOSITORY R39 KTextEditor BRANCH master REVISION DETAIL

D8708: [WIP] Introduce AbstractAnnotationItemDelegate for more control by consumer

2018-09-04 Thread Friedrich W. H. Kossebau
kossebau updated this revision to Diff 40990. kossebau added a comment. Herald edited subscribers, added: kde-frameworks-devel, kwrite-devel; removed: Frameworks. update to latest master REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D15240: Create a default wallet when user refuses to do so

2018-09-04 Thread Andres Betts
abetts added a comment. In D15240#319850 , @ngraham wrote: > This strikes me as likely to cause intense frustration. Consider the following dramatized dialogue between a user and the computer: > > User: "Neat, I just set up this KDE plasma

D15072: [server] Abort drag start on correct conditions and without posting error

2018-09-04 Thread Roman Gilg
romangg added inline comments. INLINE COMMENTS > adridg wrote in datadevice_interface.cpp:103 > this looks like it's still missing a !, based on the explanation "when the > client does not have an implicit pointer grab" There is a `!` in the beginning. Or did you mean something else?

D15072: [server] Abort drag start on correct conditions and without posting error

2018-09-04 Thread Adriaan de Groot
adridg added inline comments. INLINE COMMENTS > datadevice_interface.cpp:103 > // TODO: allow touch > -if (seat->hasImplicitPointerGrab(serial) && > seat->focusedPointerSurface() != origin) { > -wl_resource_post_error(resource, 0, "Surface doesn't have pointer > grab"); > +

D6513: Add support for Attica tags support

2018-09-04 Thread Dan Leinir Turthra Jensen
leinir updated this revision to Diff 40981. leinir added a comment. Uncrustify-kf5 things as requested, hope this is better! REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6513?vs=39174=40981 REVISION DETAIL https://phabricator.kde.org/D6513 AFFECTED

D6513: Add support for Attica tags support

2018-09-04 Thread Christoph Feck
cfeck requested changes to this revision. cfeck added a comment. This revision now requires changes to proceed. I still see many coding style issues. If you cannot run it through the formatting scripts, I will review it later. REPOSITORY R304 KNewStuff REVISION DETAIL

D15180: kioexecd: watch for creations or modifications of the temporary files

2018-09-04 Thread Jaime Torres Amate
jtamate updated this revision to Diff 40961. jtamate added a comment. I missed that part, sorry. It is safer that way, the start(time) method was added in Qt 5.8. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15180?vs=40960=40961 REVISION DETAIL

D15180: kioexecd: watch for creations or modifications of the temporary files

2018-09-04 Thread Anthony Fieroni
anthonyfieroni added a comment. m_timer.start(predefinedTimeout) should be m_timer.start() in 2 places, but let's see @elvisangelaccio and @dfaure comments. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15180 To: jtamate, #frameworks, broulik, ngraham, dfaure,

D15180: kioexecd: watch for creations or modifications of the temporary files

2018-09-04 Thread Jaime Torres Amate
jtamate updated this revision to Diff 40960. jtamate marked 3 inline comments as done. jtamate added a comment. Done. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15180?vs=40952=40960 REVISION DETAIL https://phabricator.kde.org/D15180 AFFECTED FILES

D15240: Create a default wallet when user refuses to do so

2018-09-04 Thread Oleg Solovyov
McPain added a comment. In D15240#319850 , @ngraham wrote: > This strikes me as likely to cause intense frustration. Consider the following dramatized dialogue between a user and the computer: > > User: "Neat, I just set up this KDE plasma

D15180: kioexecd: watch for creations or modifications of the temporary files

2018-09-04 Thread Anthony Fieroni
anthonyfieroni added inline comments. INLINE COMMENTS > kioexecd.cpp:53 > connect(m_watcher, ::deleted, this, ::slotDeleted); > +m_timer.setSingleShot(true); > +connect(_timer, ::timeout, this, > ::slotCheckDeletedFiles); Also add interval here, setInterval, in other place just

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 391 - Fixed!

2018-09-04 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/391/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Tue, 04 Sep 2018 06:41:49 + Build duration: 7 min 2 sec and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.11 - Build # 8 - Still Failing!

2018-09-04 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.11/8/ Project: Frameworks kio kf5-qt5 WindowsMSVCQt5.11 Date of build: Tue, 04 Sep 2018 06:41:49 + Build duration: 3 min 49 sec and counting CONSOLE OUTPUT

D15252: [KPropertiesDialog] Use QIcon::fromTheme rather than KIconLoader::loadIcon

2018-09-04 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R241:f27ac45b52c0: [KPropertiesDialog] Use QIcon::fromTheme rather than KIconLoader::loadIcon (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D15180: kioexecd: watch for creations or modifications of the temporary files

2018-09-04 Thread Jaime Torres Amate
jtamate updated this revision to Diff 40952. jtamate marked 4 inline comments as done. jtamate added a comment. Implemented Anthony comments/suggestions. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15180?vs=40908=40952 REVISION DETAIL