D15213: Provide icons for 2x scaling

2018-09-06 Thread Chris Rizzitello
rizzitello closed this revision. rizzitello added a comment. landed: https://cgit.kde.org/breeze-icons.git/commit/?id=2dcc2b712a88e726f31f3a4732ba2c39c01a2bce REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D15213 To: rizzitello, #vdg, #plasma, broulik, ngraham

D15321: [Calendar] Expose firstDayOfWeek in MonthView for calendar widgets to override the Locale

2018-09-06 Thread Chris Holland
Zren created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. Zren requested review of this revision. REVISION SUMMARY Users may want to start the week on a Sunday, Saturday, or Monday without changing their locale's date formatting.

D15309: [Calendar] Wrap day name index around

2018-09-06 Thread Chris Holland
Zren added a comment. Nice thinking on using `repeater.count` instead of the hardcoded `7`! Hmm, was worried `days.count` would trigger `onCountChanged` every time a delegate is made (count=1, count=2, etc), but it seems that the `delegate.text` is only calculated twice (delegate

D15317: trash: Fix directorysizes cache parsing

2018-09-06 Thread Alexander Volkov
volkov added a comment. It should fix the bugs: https://bugs.kde.org/show_bug.cgi?id=331707 https://bugs.kde.org/show_bug.cgi?id=386460 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15317 To: volkov, #frameworks, dfaure Cc: kde-frameworks-devel, michaelh, ngraham,

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 394 - Fixed!

2018-09-06 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/394/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Thu, 06 Sep 2018 21:43:48 + Build duration: 4 min 48 sec and counting JUnit Tests Name:

D15317: trash: Fix directorysizes cache parsing

2018-09-06 Thread Alexander Volkov
volkov closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15317 To: volkov, #frameworks, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15318: Automatically re-upload saved files located on samba shares instead of asking first

2018-09-06 Thread Elvis Angelaccio
elvisangelaccio added a comment. Note that kioexecd is slave-agnostic, we shouldn't test only with the samba slave. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15318 To: ngraham, #frameworks, broulik, jtamate Cc: elvisangelaccio, kde-frameworks-devel, broulik,

D15317: trash: Fix directorysizes cache parsing

2018-09-06 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Whoops! REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D15317 To: volkov, #frameworks, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D6513: Add support for Attica tags support

2018-09-06 Thread David Faure
dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > tagsfilterchecker.cpp:33 > +{ > +qDeleteAll(validators.values()); > +} Unnecessarily slow. Remove the .values() call. >

D12545: Set focus on the filename line edit when a file is selected

2018-09-06 Thread Alex Nemeth
anemeth abandoned this revision. anemeth added a comment. @ngraham I'm sorry, but because of my new job I don't have much free time left so I can't actively develop anymore. I'd really like if someone took over this patch. REPOSITORY R241 KIO REVISION DETAIL

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.9 - Build # 54 - Still Failing!

2018-09-06 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.9/54/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.9 Date of build: Thu, 06 Sep 2018 19:24:53 + Build duration: 12 min and counting CONSOLE OUTPUT

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.10 - Build # 81 - Fixed!

2018-09-06 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/81/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.10 Date of build: Thu, 06 Sep 2018 19:24:53 + Build duration: 3 min 54 sec and counting JUnit Tests

D12950: add test which checks the property types

2018-09-06 Thread Alexander Stippich
astippich added a comment. ping REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12950 To: astippich, mgallien, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D13700: implement reading of the replaygain tags

2018-09-06 Thread Alexander Stippich
astippich added inline comments. INLINE COMMENTS > bruns wrote in taglibextractor.cpp:50 > This is definitely broken: > http://taglib.org/api/classTagLib_1_1String.html#a0ef8ad270d710863e0bb1c1b18cdb95d > > `const wchar_t* TagLib::String::toCWString() const` > > > Returns a standard

D13700: implement reading of the replaygain tags

2018-09-06 Thread Alexander Stippich
astippich updated this revision to Diff 41119. astippich marked 2 inline comments as done. astippich added a comment. - remove space and adjust comment REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13700?vs=40851=41119 BRANCH replaygain REVISION

D15318: Automatically re-upload saved files located on samba shares instead of asking first

2018-09-06 Thread Jaime Torres Amate
jtamate added a comment. In D15318#321461 , @ngraham wrote: > > but wouldn't it be nicer to not get the dialog to overwrite the modified file > > You're still seeing that with git master? If so, I agree that we should fix that too.

D15318: Automatically re-upload saved files located on samba shares instead of asking first

2018-09-06 Thread Nathaniel Graham
ngraham added a comment. In D15318#321460 , @jtamate wrote: > It does automatically upload the modified file Not before asking, which is what this patch takes out. > but wouldn't it be nicer to not get the dialog to overwrite the

D15318: Automatically re-upload saved files located on samba shares instead of asking first

2018-09-06 Thread Jaime Torres Amate
jtamate added a comment. It does automatically upload the modified file, but wouldn't it be nicer to not get the dialog to overwrite the modified file, that of course is not there in the case of local files. It is just a third parameter to copy and tell it to Overwrite. REPOSITORY R241

D15318: Automatically re-upload saved files located on samba shares instead of asking first

2018-09-06 Thread Nathaniel Graham
ngraham planned changes to this revision. ngraham added a comment. That makes sense. I can add the mimetype check. For the save mashing case, do you have a proposal? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15318 To: ngraham, #frameworks, broulik, jtamate Cc:

D15317: trash: Fix directorysizes cache parsing

2018-09-06 Thread Anthony Fieroni
anthonyfieroni added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15317 To: volkov, #frameworks, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15318: Automatically re-upload saved files located on samba shares instead of asking first

2018-09-06 Thread Kai Uwe Broulik
broulik added a comment. I would like to have some sanity checks there, like if the file is empty, or its mime type changed, it should ask. Also what if the file changes, is uploaded, and then changes again midflight? I'm a person that mashes Ctrl+S usually. REPOSITORY R241 KIO REVISION

D15318: Automatically re-upload saved files located on samba shares instead of asking first

2018-09-06 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: Frameworks, broulik, jtamate. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY Right now, when you use a non-KDE app to save an edited file

D15317: trash: Fix directorysizes cache parsing

2018-09-06 Thread Alexander Volkov
volkov created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. volkov requested review of this revision. REVISION SUMMARY Entries in this file have the following format: [size] [mtime] [percent-encoded-directory-name] , and

D15317: trash: Fix directorysizes cache parsing

2018-09-06 Thread Alexander Volkov
volkov added a reviewer: Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15317 To: volkov, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15213: Provide icons for 2x scaling

2018-09-06 Thread Andrew Crouthamel
acrouthamel added a comment. I love all of these HIDPI fixes lately. REPOSITORY R266 Breeze Icons BRANCH 2xIcons REVISION DETAIL https://phabricator.kde.org/D15213 To: rizzitello, #vdg, #plasma, broulik, ngraham Cc: acrouthamel, ngraham, broulik, kde-frameworks-devel, michaelh, bruns

D15213: Provide icons for 2x scaling

2018-09-06 Thread Nathaniel Graham
ngraham added a comment. Fantastic, shipit! REPOSITORY R266 Breeze Icons BRANCH 2xIcons REVISION DETAIL https://phabricator.kde.org/D15213 To: rizzitello, #vdg, #plasma, broulik, ngraham Cc: ngraham, broulik, kde-frameworks-devel, michaelh, bruns

D8708: [WIP] Introduce AbstractAnnotationItemDelegate for more control by consumer

2018-09-06 Thread Friedrich W. H. Kossebau
kossebau updated this revision to Diff 41112. kossebau added a comment. fix not listening to sizeHintChanged signal REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8708?vs=41078=41112 BRANCH addAnnotationItemDelegate REVISION DETAIL

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 393 - Unstable!

2018-09-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/393/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Thu, 06 Sep 2018 14:40:57 + Build duration: 5 min 26 sec and counting JUnit Tests Name:

D15180: kioexecd: watch for creations or modifications of the temporary files

2018-09-06 Thread Jaime Torres Amate
This revision was automatically updated to reflect the committed changes. jtamate marked an inline comment as done. Closed by commit R241:820f622e86bb: kioexecd: watch for creations or modifications of the temporary files (authored by jtamate). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.9 - Build # 53 - Still Failing!

2018-09-06 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.9/53/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.9 Date of build: Thu, 06 Sep 2018 14:06:24 + Build duration: 12 min and counting CONSOLE OUTPUT

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.9 - Build # 52 - Failure!

2018-09-06 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.9/52/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.9 Date of build: Thu, 06 Sep 2018 13:54:02 + Build duration: 12 min and counting CONSOLE OUTPUT

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.10 - Build # 80 - Still Unstable!

2018-09-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/80/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.10 Date of build: Thu, 06 Sep 2018 14:00:12 + Build duration: 4 min 21 sec and counting JUnit Tests

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.10 - Build # 79 - Still Unstable!

2018-09-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/79/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.10 Date of build: Thu, 06 Sep 2018 13:54:02 + Build duration: 6 min 9 sec and counting JUnit Tests

D15074: [server] Do not try to create data offers without source

2018-09-06 Thread Roman Gilg
This revision was automatically updated to reflect the committed changes. Closed by commit R127:698777a7224e: [server] Do not try to create data offers without source (authored by romangg). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15074?vs=40407=41108

D15072: [server] Abort drag start on correct conditions and without posting error

2018-09-06 Thread Roman Gilg
This revision was automatically updated to reflect the committed changes. Closed by commit R127:83d0c8d21ec7: [server] Abort drag start on correct conditions and without posting error (authored by romangg). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

D15242: RFC: [KFileItem] Handle permissions ourselves in isReadable()/isWritable()

2018-09-06 Thread Fabian Vogt
fvogt requested changes to this revision. fvogt added a comment. This revision now requires changes to proceed. This will likely not work with ACLs. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15242 To: broulik, dfaure, elvisangelaccio, fvogt, lbeltrame Cc:

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 213 - Still Unstable!

2018-09-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/213/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Thu, 06 Sep 2018 12:58:58 + Build duration: 2 min 31 sec and counting

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 212 - Still Unstable!

2018-09-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/212/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Thu, 06 Sep 2018 12:45:11 + Build duration: 13 min and counting JUnit

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 211 - Still Unstable!

2018-09-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/211/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Thu, 06 Sep 2018 12:28:28 + Build duration: 16 min and counting JUnit

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 210 - Still Unstable!

2018-09-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/210/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Thu, 06 Sep 2018 12:05:56 + Build duration: 22 min and counting JUnit

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.9 - Build # 134 - Fixed!

2018-09-06 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.9/134/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.9 Date of build: Thu, 06 Sep 2018 12:11:02 + Build duration: 3 min 0 sec and counting JUnit

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.9 - Build # 133 - Unstable!

2018-09-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.9/133/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.9 Date of build: Thu, 06 Sep 2018 12:05:56 + Build duration: 5 min 5 sec and counting

D15164: Support button icons when present

2018-09-06 Thread Marco Martin
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R242:85cab5772c56: Support button icons when present (authored by mart). REPOSITORY R242 Plasma Framework (Library)

D15213: Provide icons for 2x scaling

2018-09-06 Thread Chris Rizzitello
rizzitello added a comment. In D15213#321121 , @ngraham wrote: > Does this mean that every new 16px, 22px, 24px, and 32px monochrome icon will need an `@2x` symlink? There will be no need for that since I have simlinked the folders using

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 209 - Still Unstable!

2018-09-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/209/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Thu, 06 Sep 2018 10:42:36 + Build duration: 5 min 16 sec and counting

D15309: [Calendar] Wrap day name index around

2018-09-06 Thread Kai Uwe Broulik
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R242:020d3e3ebea5: [Calendar] Wrap day name index around (authored by broulik). REPOSITORY R242 Plasma Framework

D15309: [Calendar] Wrap day name index around

2018-09-06 Thread Safa Alfulaij
safaalfulaij added a comment. I thought that this is a feature/cool look :D Thanks a lot! REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15309 To: broulik, #plasma, Zren Cc: safaalfulaij, kde-frameworks-devel, michaelh, ngraham, bruns

D15309: [Calendar] Wrap day name index around

2018-09-06 Thread Kai Uwe Broulik
broulik edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15309 To: broulik, #plasma, Zren Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15309: [Calendar] Wrap day name index around

2018-09-06 Thread Kai Uwe Broulik
broulik added a reviewer: Zren. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15309 To: broulik, #plasma, Zren Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15309: [Calendar] Wrap day name index around

2018-09-06 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Otherwise when the week starts on a day other than Sunday or Monday we access

D15180: kioexecd: watch for creations or modifications of the temporary files

2018-09-06 Thread Jaime Torres Amate
jtamate marked an inline comment as done. jtamate added inline comments. INLINE COMMENTS > elvisangelaccio wrote in kioexecd.cpp:129 > Maybe `constBegin()`/`constEnd()` here? I always thought const iterators were meant to be used when the whole container is considered ReadOnly, not only its