D14632: keyword rule: Spport for keywords inclusion from another language/file

cullmann added a comment. The properties##CSS variant is really just like what I wanted, too! Nice. Only nitpick API wise: I would not expose the difference between includedDefinitions and includedKeywordDefinitions, I would just like to have all included definitions in includedDefinitio

D15390: Bash: fix parameter & brace expansion

dhaumann accepted this revision. dhaumann added a comment. +1, thanks. REPOSITORY R216 Syntax Highlighting BRANCH fix-bash REVISION DETAIL https://phabricator.kde.org/D15390 To: nibags, cullmann, dhaumann, #framework_syntax_highlighting Cc: kwrite-devel, kde-frameworks-devel, michaelh

D15390: Bash: fix parameter & brace expansion

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Looks better, thanks. REPOSITORY R216 Syntax Highlighting BRANCH fix-bash REVISION DETAIL https://phabricator.kde.org/D15390 To: nibags, cullmann, dhaumann, #framework_syntax_hi

D15318: [WIP] Automatically re-upload saved files located on remote locations instead of asking first

ngraham planned changes to this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15318 To: ngraham, #frameworks, broulik, jtamate Cc: elvisangelaccio, kde-frameworks-devel, broulik, jtamate, michaelh, ngraham, bruns

D15318: [WIP] Automatically re-upload saved files located on remote locations instead of asking first

ngraham retitled this revision from "[WIP] Automatically re-upload saved files located on samba shares instead of asking first" to "[WIP] Automatically re-upload saved files located on remote locations instead of asking first". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org

D15318: [WIP] Automatically re-upload saved files located on samba shares instead of asking first

ngraham updated this revision to Diff 41305. ngraham added a comment. - Don't show the unnecessary and annoying overwrite dialog - Make a note of the validation steps I need to implement REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15318?vs=41117&id=41305

D15318: [WIP] Automatically re-upload saved files located on samba shares instead of asking first

ngraham retitled this revision from "Automatically re-upload saved files located on samba shares instead of asking first" to "[WIP] Automatically re-upload saved files located on samba shares instead of asking first". ngraham edited the summary of this revision. ngraham edited the test plan for t

D15390: Bash: fix parameter & brace expansion

nibags edited the summary of this revision. nibags added reviewers: cullmann, dhaumann, Framework: Syntax Highlighting. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D15390 To: nibags, cullmann, dhaumann, #framework_syntax_highlighting Cc: kwrite-devel, kde-

D15390: Bash: fix parameter & brace expansion

nibags edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D15390 To: nibags, cullmann, dhaumann, #framework_syntax_highlighting Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann

D15390: Bash: fix parameter & brace expansion

nibags created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH fix-bash REVISION DETAIL https://phabricator.kde.org/D15390 AFFECTED FI

D14632: keyword rule: Spport for keywords inclusion from another language/file

jpoelen updated this revision to Diff 41298. jpoelen added a comment. include rule in keyword list to import those from another file REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14632?vs=39138&id=41298 BRANCH kwinclude REVISION DETAIL ht

Re: ECM Behaviour: Setting QT_PLUGIN_PATH on Windows

On Sat, 8 Sep 2018, 20:12 David Faure, wrote: > On vendredi 31 août 2018 10:50:53 CEST Ben Cooksley wrote: > > On Tue, Aug 28, 2018 at 10:35 PM Ben Cooksley wrote: > > > Hi all, > > > > Hi all, > > > > > We currently have a severe bug in ECM's AddTest macro due to it's > > > behaviour around the

Re: CI System Reorganisation

On Mon, 10 Sep 2018, 01:17 Christoph Feck, wrote: > On 09.09.2018 10:59, Ben Cooksley wrote: > > As a followup to my earlier mail sent about 3 weeks ago, i've now > > transitioned all builds on the CI system over to the folder layout > > previously described. > > > > Builds can now be found in fo

D15353: Use _NET_WM_WINDOW_TYPE_COMBO instead of _NET_WM_WINDOW_TYPE_COMBOBOX

zzag added a comment. In D15353#322991 , @aacid wrote: > I'm not a KWindowSystem developer so take this with a grain of salt, but maybe it makes sense to still support the old name in case someone is really using it and add the new one as a syno

D15353: Use _NET_WM_WINDOW_TYPE_COMBO instead of _NET_WM_WINDOW_TYPE_COMBOBOX

aacid added a comment. I'm not a KWindowSystem developer so take this with a grain of salt, but maybe it makes sense to still support the old name in case someone is really using it and add the new one as a synonym? REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.o

D15364: Plasma style: Remove hardcoded textFormat

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. You're absolutely right this is wrong. > @sune It is a crap default, but it shouldn't change per theme when a user is using Qqc2 directly. They might develop for th

D15364: Plasma style: Remove hardcoded textFormat

jbbgameich added a comment. On Plasma Mobile all applications use the Plasma Style for QtQuickControls 2. (kaidan is also a Plasma Mobile application) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15364 To: jbbgameich, #plasma Cc: svuorela, ngra

D15364: Plasma style: Remove hardcoded textFormat

ngraham added a comment. Should Applications really be using Plasma style and components? I think they probably should be using desktop QQC2 style via Kirigami instead. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15364 To: jbbgameich, #plasma

D15364: Plasma style: Remove hardcoded textFormat

jbbgameich added a comment. @ngraham The screenshot is from Kaidan. It's using QtQuickControls 2 with the Plasma Style, so not PlasmaComponents direcltly. I don't think it's possible to set the textFormat for this tooltip in QtQuickControls 2 unfortunately. @svuorela So it seems like app

D15364: Plasma style: Remove hardcoded textFormat

ngraham added a comment. What app/plasmoid/widget is that a screenshot from? It might make more sense to just set the text format there, rather than universally. P.S. you can attach screenshots to comments here so they appear inline. REPOSITORY R242 Plasma Framework (Library) REVISION

D15364: Plasma style: Remove hardcoded textFormat

jbbgameich added a comment. @ngraham I noticed the issue when using the QtQuickControls 2 style. All other styles I know don't require setting the textFormat, only the Plasma Style. Of course all QQC2 applications could just set the textFormat, but it's not possible in all cases. For example

D15375: Exclude genome files from indexing

This revision was automatically updated to reflect the committed changes. Closed by commit R293:1f7ac8433e12: Exclude genome files from indexing (authored by nicolasfella). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15375?vs=41261&id=41262 REVISION DETAIL

D14006: Fix WebDAV destination header on COPY and MOVE operations

dantti added a comment. Well the issue will probably depend on the server, for example Apache2 with Nextcloud it returns forbidden for both operations, in Cloudlyst which does: QUrl::fromEncoded(QStringLiteral("file:///speçiál").toLatin1()).toLocalFile(); you get a file with a different

D15375: Exclude genome files from indexing

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks for the fast patch! REPOSITORY R293 Baloo BRANCH genome REVISION DETAIL https://phabricator.kde.org/D15375 To: nicolasfella, #baloo, ngraham Cc: ngraham, kde-frameworks-dev

D15375: Exclude genome files from indexing

nicolasfella updated this revision to Diff 41261. nicolasfella added a comment. - Bump version REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15375?vs=41259&id=41261 BRANCH genome REVISION DETAIL https://phabricator.kde.org/D15375 AFFECTED FILES src/

D15375: Exclude genome files from indexing

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Hah, I saw the Reddit thread on this subject and was getting ready to to do the same thing myself. You beat me to it. :) Just one change is needed: don't forget to bump the

D15375: Exclude genome files from indexing

nicolasfella created this revision. nicolasfella added a reviewer: Baloo. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Those files contain huge amounts of genome data that is uninterest

D14006: Fix WebDAV destination header on COPY and MOVE operations

bruns added a comment. In D14006#322626 , @dantti wrote: > Test plan: > > 1. Connecto to a WebDav server > 2. Create a file named "foo" > 3. Try to rename the file to "speçiál" - it should result in "spe" > > The COPY operation has t

Re: CI System Reorganisation

On 09.09.2018 10:59, Ben Cooksley wrote: As a followup to my earlier mail sent about 3 weeks ago, i've now transitioned all builds on the CI system over to the folder layout previously described. Builds can now be found in folders following the following structure on Jenkins: / How I can vie

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.11 - Build # 15 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.11/15/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Sun, 09 Sep 2018 10:37:16 + Build duration: 1 min 2 sec and counting CONSOLE OUTPUT [...tru

D15370: Scripting: isCode() returns false for dsAlert text

This revision was automatically updated to reflect the committed changes. Closed by commit R39:af5ebba716f5: Scripting: isCode() returns false for dsAlert text (authored by dhaumann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15370?vs=41248&id=41249 R

D15370: Scripting: isCode() returns false for dsAlert text

cullmann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R39 KTextEditor BRANCH fix-is-code (branched from master) REVISION DETAIL https://phabricator.kde.org/D15370 To: dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, n

D15370: Scripting: isCode() returns false for dsAlert text

dhaumann created this revision. dhaumann added a reviewer: cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. dhaumann requested review of this revision. REVISION SUMMARY BUG: 398393 TEST PLAN make && make test REPOSITORY R39 KT

D15328: kfilewidget: convert connect syntax

jtamate updated this revision to Diff 41246. jtamate added a comment. Use nullptr instead of 0. Remove the copied/pasted part of the cause of two dissconnects. @bruns, as I'm not sure if the code emits other signals for lineEdit, I prefer to keep it as it was. REPOSITORY R241 KIO CH

CI System Reorganisation

Hi all, As a followup to my earlier mail sent about 3 weeks ago, i've now transitioned all builds on the CI system over to the folder layout previously described. Builds can now be found in folders following the following structure on Jenkins: / For those with access to run DSL Scripts: Please

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 WindowsMSVCQt5.11 - Build # 50 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20WindowsMSVCQt5.11/50/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sun, 09 Sep 2018 08:51:03 + Build duration: 4 min 13 sec and counting JUnit Tests

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 WindowsMSVCQt5.11 - Build # 49 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20WindowsMSVCQt5.11/49/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sun, 09 Sep 2018 07:45:39 + Build duration: 31 sec and counting CONSOLE OUTPUT

D15358: Unit test: Check all shipped themes for completeness

This revision was automatically updated to reflect the committed changes. Closed by commit R216:58ce23f7fdb9: Unit test: Check all shipped themes for completeness (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15358?vs=41221

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 FreeBSDQt5.11 - Build # 43 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20FreeBSDQt5.11/43/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Sun, 09 Sep 2018 07:22:51 + Build duration: 30 sec and counting CONSOLE OUTPUT [...

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 WindowsMSVCQt5.11 - Build # 48 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20WindowsMSVCQt5.11/48/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sun, 09 Sep 2018 07:22:51 + Build duration: 38 sec and counting CONSOLE OUTPUT

D15364: Plasma style: Remove hardcoded textFormat

svuorela added a comment. I think it is undesireable to change the default, because all users are now used to having it PlainText, so they are now dumping things-that-looks-like-html into it and expecting it to be plaintext. so all users of Label that don't have textFormat set now needs

D15358: Unit test: Check all shipped themes for completeness

vkrause accepted this revision. REPOSITORY R216 Syntax Highlighting BRANCH check-themes (branched from master) REVISION DETAIL https://phabricator.kde.org/D15358 To: dhaumann, vkrause, cullmann, acrouthamel Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, de

D15340: Add Solarized Light and Dark themes

dhaumann added a comment. Sure, please use kdesrc-build as described here: https://community.kde.org/Guidelines_and_HOWTOs/Build_from_source Once setup, you can build everything by invoking ./kdesrc-build You can also pass a module to build: ./kdesrc-build syntax-highlighting