Re: Quality of Frameworks announcements

[Kai Uwe Broulik]

Hi,

if you have any commits where the heading is a very technical description, 
consider using the CHANGELOG: tag, for instance 

Look up foo directly instead of doing bar

When doing foo we needlessly ended up doing bar which comes with a huge 
overhead. 

CHANGELOG: Significantly sped up doing bla in boo dialog

Cheers
Kai Uwe 

D6513: Add support for Attica tags support

[Nathaniel Graham]

ngraham added a comment.


  In D6513#322167 , @leinir wrote:
  
  > In D6513#322078 , @ngraham wrote:
  >
  > > So is this enough for people to start tagging KDE4 content as such? Or is 
anything else still required before that capability lands?
  >
  >
  > In short, this is basically enough :) When people run KNewStuff with this 
patch, any content which has been marked as ghns_exclude (that tick box you and 
the other moderators have on the store) will be hidden from the user :) For 
doing more "proper" filtering, changes will want to be done to either just the 
knsrc files, or to the clients themselves (which would be for things like 
"don't show wallpapers with incorrect resolutions" or "only show things with 
x86 binaries" or that sort of stuff).
  
  
  So I see `ghns_exclude` over at store.kde.org, but it doesn't feel quite 
right to check that box next to everything KDE4. Is that what I should be doing?

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D6513

To: leinir, #knewstuff, apol, #kde_store, whiting, ahiemstra, mlaurent, dfaure, 
cfeck
Cc: dfaure, cfeck, mlaurent, ngraham, ahiemstra, kde-frameworks-devel, 
#knewstuff, michaelh, ZrenBot, bruns

D15406: Manually resize KCMUtilDialog to sizeHint()

[Valeriy Malov]

This revision was automatically updated to reflect the committed changes.
Closed by commit R295:cc4ecfdcd48a: Manually resize KCMUtilDialog to sizeHint() 
(authored by valeriymalov).

REPOSITORY
  R295 KCMUtils

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15406?vs=41344=41446

REVISION DETAIL
  https://phabricator.kde.org/D15406

AFFECTED FILES
  src/kcmultidialog.cpp

To: valeriymalov, #frameworks, ngraham
Cc: davidedmundson, acrouthamel, kde-frameworks-devel, michaelh, ngraham, bruns

D15443: [server] Allow multiple touch interfaces per client and remove fallback code

[Roman Gilg]

romangg created this revision.
romangg added reviewers: KWin, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
romangg requested review of this revision.

REVISION SUMMARY
  The touch related code in the seat interface class has been for no apparent
  reason very different to pointer and keyboard code.
  
  This patch makes touch reladet code more similar and by that allows a client
  to receive touch events through multiple interfaces.
  
  Some undocumented fallback code has been removed as well. Platforms not
  supporting touch are just considered not capable instead.

TEST PLAN
  Manually and auto tests still pass.

REPOSITORY
  R127 KWayland

BRANCH
  refactorSeatTouch

REVISION DETAIL
  https://phabricator.kde.org/D15443

AFFECTED FILES
  src/server/seat_interface.cpp
  src/server/seat_interface_p.h

To: romangg, #kwin, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

Re: Quality of Frameworks announcements

[Luigi Toscano]

On Sunday, 9 September 2018 16:07:43 CEST Yuri Chornoivan wrote:
> Hi,
> 
> I think that several latest Frameworks announcements are not of even medium
> quality. It is hard to translate them because the commit messages list looks
> like some kind of puzzle. 

This is a good point, but the i18n list is not the right place. Redirecting to 
kde-frameworks-devel.

> Examples:
> 
> no need to new/delete hash on each doHighlight, clearing it is good enough
> 
> ensure we can handle invalid attribute indices that can happen as left overs
> after HL switch for a document
> 
> let smart pointer handle deletion of objects, less manual stuff to do
> 
> remove map to lookup additional hl properties
> 
> KTextEditor uses the KSyntaxHighlighting framework for all
> 
> use character encodings as provided by the definitions
> 
> non-bold text no longer renders with font weight thin but (bug 393861)
> 
> footer separator line visually lighter
> 
> make can break bit more like in word code
> 
> no linked list without any reason
> 
> cleanup properties init
> 
> etc.
> 
> There are meaningless to the end-user messages:
> 
> Merge branch 'master' into syntax-highlighting
> 
> Merge branch 'master' into syntax-highlighting (again)
> 
> There are also some workflow things (commit -> revert -> commit again,
> commit (5.49) -> revert (5.50)).
> 
> If announce is some kind of advertisement it can be some kind of meaningful.
> 
> Is it possible to ask developers/release team/marketing team to give us,
> translators, the material that can be retranslated to community on the
> quality that KDE deserves?
> 
> Thanks in advance for your help.
> 
> Best regards,
> Yuri

-- 
Luigi

D15406: Manually resize KCMUtilDialog to sizeHint()

[Andrew Crouthamel]

acrouthamel added a comment.


  I've tested this patch on my system. Although it does not resolve the scaling 
issue I experience, it does not cause any regressions I see. Ship it! :)

REPOSITORY
  R295 KCMUtils

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15406

To: valeriymalov, #frameworks, ngraham
Cc: davidedmundson, acrouthamel, kde-frameworks-devel, michaelh, ngraham, bruns

D15426: Avoid QByteArray::remove in AccessManagerReply::readData

[Stefan Brüns]

bruns added a comment.


  For the trivial case, do the clear in `readData()`.
  
  For the non-trivial case:
  
  1. in `readData()`, no memmoves were ever done. Currently, if you have e.g. 
50 kB in m_data, you read 2 * 16 kB, and move the remaining 18 kB to the front. 
You can instead just read 3 * 16 + 2 kB.
  2. in `slotData()`, you have to do a copy every time `capacity()` is 
exceeded. You can piggy-pack on this necessary copy/move, and either do a move 
if `m_offset >= data.size()` else do a copy of the old data, last append the 
new `data`.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15426

To: fvogt, #frameworks, elvisangelaccio
Cc: bruns, kde-frameworks-devel, michaelh, ngraham

D15426: Avoid QByteArray::remove in AccessManagerReply::readData

[Fabian Vogt]

fvogt added inline comments.

INLINE COMMENTS

> bruns wrote in accessmanagerreply_p.cpp:156
> Wouldn't it be better to trim the buffer in slotData, at least in the 
> non-trivial case?

For the non-trivial case it shouldn't make a difference really. For the trivial 
one it does, as otherwise it would never empty m_data.

So to avoid code duplication, it's only done here.

> bruns wrote in accessmanagerreply_p.h:99
> You could use in-class initialization here ...

It's not done for the other members. I assume it's a style preference.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15426

To: fvogt, #frameworks, elvisangelaccio
Cc: bruns, kde-frameworks-devel, michaelh, ngraham

D15426: Avoid QByteArray::remove in AccessManagerReply::readData

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> accessmanagerreply_p.cpp:156
>  
> -if (length) {
> -memcpy(data, m_data.constData(), length);
> -m_data.remove(0, length);
> +// Remove the stale data before m_offset only if it grows to half
> +// of the total size, to avoid calling the expensive .remove function.

Wouldn't it be better to trim the buffer in slotData, at least in the 
non-trivial case?

> accessmanagerreply_p.h:99
>  QByteArray m_data;
> +qint64 m_offset;
>  bool m_metaDataRead;

You could use in-class initialization here ...

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15426

To: fvogt, #frameworks, elvisangelaccio
Cc: bruns, kde-frameworks-devel, michaelh, ngraham

KDE CI: Frameworks » kservice » kf5-qt5 WindowsMSVCQt5.11 - Build # 5 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20WindowsMSVCQt5.11/5/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Tue, 11 Sep 2018 18:38:44 +
 Build duration:
2 min 36 sec and counting
   CONSOLE OUTPUT
  [...truncated 112.51 KB...]   Required for the Trader parser * Doxygen (required version >= 1.8.13)   Needed for API dox QCH file generation * QHelpGenerator, Part of Qt5 tools   Needed for API dox QCH file generation * Qt5Concurrent * Qt5Test * Qt5 (required version >= 5.8.0)-- Configuring done-- Generating done-- Build files have been written to: C:/CI/workspace/Frameworks/kservice/kf5-qt5 WindowsMSVCQt5.11/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] bat[kf5-qt5 WindowsMSVCQt5.11] Running batch scriptC:\CI\workspace\Frameworks\kservice\kf5-qt5 WindowsMSVCQt5.11>call "C:/Program Files (x86)/Microsoft Visual Studio/2017/Professional/VC/Auxiliary/Build/vcvars64.bat"  Visual Studio 2017 Developer Command Prompt v15.7.3** Copyright (c) 2017 Microsoft Corporation**[vcvarsall.bat] Environment initialized for: 'x64'jom 1.1.2 - empower your coresjom: parallel job execution disabled for MakefileScanning dependencies of target docs-kbuildsycoca5-kbuildsycoca5-8Scanning dependencies of target docs-desktoptojson-desktoptojson-8Scanning dependencies of target copy_menuScanning dependencies of target KF5Service_QCHScanning dependencies of target copy_servicetypes[  1%] Generating kbuildsycoca5.8[  2%] Built target copy_servicetypes[  2%] Built target copy_menufile:///C:/CI/workspace/Frameworks/kservice/kf5-qt5%20WindowsMSVCQt5.11/install-prefix/bin/data/kf5/kdoctools/customization/dtd/kdedbx45.dtd:102: warning: failed to load external entity "file:///C:/CI/Craft/CI-Qt511/windows-msvc2017_64-cl-debug/bin/data/xml/docbook/schema/dtd/4.5/docbookx.dtd"%DocBookDTD;^file:///C:/CI/workspace/Frameworks/kservice/kf5-qt5%20WindowsMSVCQt5.11/install-prefix/bin/data/kf5/kdoctools/customization/dtd/modifications.elements:43: validity error : PEReference: %div.title.content; not found ^file:///C:/CI/workspace/Frameworks/kservice/kf5-qt5%20WindowsMSVCQt5.11/install-prefix/bin/data/kf5/kdoctools/customization/dtd/modifications.elements:43: parser error : ContentDecl : Name or '(' expected ^file:///C:/CI/workspace/Frameworks/kservice/kf5-qt5%20WindowsMSVCQt5.11/install-prefix/bin/data/kf5/kdoctools/customization/dtd/modifications.elements:43: parser error : expected '>'   ^file:///C:/CI/workspace/Frameworks/kservice/kf5-qt5%20WindowsMSVCQt5.11/install-prefix/bin/data/kf5/kdoctools/customization/dtd/modifications.elements:43: parser error : Content error in the external subset   ^man-kbuildsycoca5.8.docbook:6: parser error : Entity 'language' not defined  ^man-kbuildsycoca5.8.docbook:9: parser error : Entity 'kde' not defined Frameworks: KService^man-kbuildsycoca5.8.docbook:21: parser error : Entity 'kde' not definedUpdated the documentation for  Frameworks 5.^[  1%] Generating desktoptojson.8file:///C:/CI/workspace/Frameworks/kservice/kf5-qt5%20WindowsMSVCQt5.11/install-prefix/bin/data/kf5/kdoctools/customization/dtd/kdedbx45.dtd:102: warning: failed to load external entity "file:///C:/CI/Craft/CI-Qt511/windows-msvc2017_64-cl-debug/bin/data/xml/docbook/schema/dtd/4.5/docbookx.dtd"%DocBookDTD;^file:///C:/CI/workspace/Frameworks/kservice/kf5-qt5%20WindowsMSVCQt5.11/install-prefix/bin/data/kf5/kdoctools/customization/dtd/modifications.elements:43: validity error : PEReference: %div.title.content; not found ^file:///C:/CI/workspace/Frameworks/kservice/kf5-qt5%20WindowsMSVCQt5.11/install-prefix/bin/data/kf5/kdoctools/customization/dtd/modifications.elements:43: parser error : ContentDecl : Name or '(' expected ^file:///C:/CI/workspace/Frameworks/kservice/kf5-qt5%20WindowsMSVCQt5.11/install-prefix/bin/data/kf5/kdoctools/customization/dtd/modifications.elements:43: parser error : expected '>'   ^file:///C:/CI/workspace/Frameworks/kservice/kf5-qt5%20WindowsMSVCQt5.11/install-prefix/bin/data/kf5/kdoctools/customization/dtd/modifications.elements:43: parser error : Content error in the external subset   ^man-desktoptojson.8.docbook:6: parser error : Entity 'language' not defined  ^man-desktoptojson.8.docbook:9: parser error : Entity 'kde' not defined Frameworks: KService^jom: C:\CI\workspace\Frameworks\kservice\kf5-qt5 

D13700: implement reading of the replaygain tags

[Alexander Stippich]

astippich added inline comments.

INLINE COMMENTS

> bruns wrote in taglibextractor.cpp:943
> You should check if the value can be converted to double, and probably also 
> if it is in a sane range.

I added the checks for a successful conversion, but in my opinion kfilemetadata 
should not judge if the result is within a reasonable range. This should be up 
to the application.

> bruns wrote in taglibextractor.cpp:50
> Can you do a followup-patch to fix this?

Yes, will do after this patch landed

REPOSITORY
  R286 KFileMetaData

BRANCH
  replaygain

REVISION DETAIL
  https://phabricator.kde.org/D13700

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D13700: implement reading of the replaygain tags

[Alexander Stippich]

astippich updated this revision to Diff 41429.
astippich added a comment.


  - add checks for conversion to double

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13700?vs=41119=41429

BRANCH
  replaygain

REVISION DETAIL
  https://phabricator.kde.org/D13700

AFFECTED FILES
  autotests/samplefiles/test.flac
  autotests/samplefiles/test.mp3
  autotests/samplefiles/test.mpc
  autotests/samplefiles/test.ogg
  autotests/samplefiles/test.opus
  autotests/taglibextractortest.cpp
  src/extractors/taglibextractor.cpp
  src/extractors/taglibextractor.h
  src/properties.h
  src/propertyinfo.cpp

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.9 - Build # 50 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.9/50/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Tue, 11 Sep 2018 18:03:58 +
 Build duration:
6 min 24 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackage-nodisplay-appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)95%
(18/19)95%
(18/19)72%
(1531/2125)51%
(1075/2120)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(6/6)100%
(6/6)99%
(537/539)51%
(243/472)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(558/755)64%
(598/935)src.kpackage.private100%
(6/6)100%
(6/6)79%
(278/352)49%
(96/195)src.kpackagetool100%
(2/2)100%
(2/2)31%
(144/461)26%
(131/506)

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.10 - Build # 72 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.10/72/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 11 Sep 2018 18:03:59 +
 Build duration:
4 min 30 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackage-nodisplay-appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)95%
(18/19)95%
(18/19)72%
(1531/2125)51%
(1075/2120)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(6/6)100%
(6/6)99%
(537/539)51%
(243/472)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(558/755)64%
(598/935)src.kpackage.private100%
(6/6)100%
(6/6)79%
(278/352)49%
(96/195)src.kpackagetool100%
(2/2)100%
(2/2)31%
(144/461)26%
(131/506)

KDE CI: Frameworks » kpackage » kf5-qt5 AndroidQt5.11 - Build # 18 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20AndroidQt5.11/18/
 Project:
kf5-qt5 AndroidQt5.11
 Date of build:
Tue, 11 Sep 2018 18:03:59 +
 Build duration:
35 sec and counting
   CONSOLE OUTPUT
  [...truncated 72.23 KB...]  "KF5DocTools_DIR" to a directory containing one of the above files.  If  "KF5DocTools" provides a separate development package or SDK, be sure it  has been installed.-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success-- Performing Test COMPILER_HAS_DEPRECATED_ATTR-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success-- The following REQUIRED packages have been found: * Qt5 (required version >= 5.8.0) * KF5Archive (required version >= 5.50.0) * Gettext * KF5I18n (required version >= 5.50.0) * KF5CoreAddons (required version >= 5.50.0) * ECM (required version >= 1.6.0), Extra CMake Modules.,  * Qt5Core * Qt5Test (required version >= 5.8.0)   Required for tests-- The following features have been disabled: * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)-- The following OPTIONAL packages have not been found: * KF5DocTools (required version >= 5.50.0), Tools to generate documentation-- Configuring done-- Generating done-- Build files have been written to: /home/user/workspace/Frameworks/kpackage/kf5-qt5 AndroidQt5.11/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[kf5-qt5 AndroidQt5.11] Running shell script+ python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project kpackage --branchGroup kf5-qt5 --platform AndroidQt5.11 --usingInstall /home/user/install-prefix/Scanning dependencies of target testpackage-rccScanning dependencies of target KF5Package_autogenScanning dependencies of target mockhandler_autogen[  1%] Generating testpackage-rcc/contents.rcc[  3%] Automatic MOC for target mockhandler[  5%] Automatic MOC for target KF5Package[  5%] Built target mockhandler_autogen[  5%] Built target testpackage-rccScanning dependencies of target mockhandler[  5%] Built target KF5Package_autogen[  6%] Automatic RCC for kpackage.qrc[  8%] Building CXX object autotests/mockdepresolver/CMakeFiles/mockhandler.dir/main.cpp.o[ 10%] Building CXX object autotests/mockdepresolver/CMakeFiles/mockhandler.dir/mockhandler_autogen/mocs_compilation.cpp.oScanning dependencies of target KF5Package[ 11%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/package.cpp.o[ 13%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/packagestructure.cpp.o[ 15%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/packageloader.cpp.o[ 16%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/private/packages.cpp.o[ 18%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/private/packagejob.cpp.o[ 20%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/private/packagejobthread.cpp.o[ 22%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/private/versionparser.cpp.o[ 23%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/version.cpp.o[ 25%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/kpackage_debug.cpp.o[ 27%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/KF5Package_autogen/mocs_compilation.cpp.o[ 28%] Linking CXX executable ../../bin/mockhandler[ 28%] Built target mockhandler[ 30%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/KF5Package_autogen/EWIEGA46WW/qrc_kpackage.cpp.o[ 32%] Linking CXX shared library ../../bin/libKF5Package.so/home/user/install-prefix/include/KF5/KI18n/klocalizedstring.h:1340: error: undefined reference to 'ki18nd(char const*, char const*)'/home/user/install-prefix/include/KF5/KI18n/klocalizedstring.h:1340: error: undefined reference to 'KLocalizedString::toString() const'/home/user/install-prefix/include/KF5/KI18n/klocalizedstring.h:1340: error: undefined reference to 'KLocalizedString::~KLocalizedString()'/home/user/install-prefix/include/KF5/KI18n/klocalizedstring.h:1352: error: undefined reference to 'ki18nd(char const*, char const*)'/home/user/install-prefix/include/KF5/KI18n/klocalizedstring.h:1352: error: undefined reference to 'KLocalizedString::subs(QString const&, int, QChar) const'/home/user/install-prefix/include/KF5/KI18n/klocalizedstring.h:1352: error: undefined reference to 'KLocalizedString::subs(QString const&, int, QChar) const'/home/user/install-prefix/include/KF5/KI18n/klocalizedstring.h:1352: error: undefined reference to 'KLocalizedString::toString() const'/home/user/install-prefix/include/KF5/KI18n/klocalizedstring.h:1352: error: undefined reference to 'KLocalizedString::~KLocalizedString()'/home/user/install-prefix/include/KF5/KI18n/klocalizedstring.h:1352: error: undefined reference to 

D15426: Avoid QByteArray::remove in AccessManagerReply::readData

[Fabian Vogt]

fvogt edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15426

To: fvogt, #frameworks, elvisangelaccio
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15426: Avoid QByteArray::remove in AccessManagerReply::readData

[Fabian Vogt]

fvogt updated this revision to Diff 41427.
fvogt added a comment.


  - Actually make it work
  - Free memory if m_offset is half of the array size
  - Bail out if maxSize < 0

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15426?vs=41406=41427

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15426

AFFECTED FILES
  src/widgets/accessmanagerreply_p.cpp
  src/widgets/accessmanagerreply_p.h

To: fvogt, #frameworks, elvisangelaccio
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15426: Avoid QByteArray::remove in AccessManagerReply::readData

[Fabian Vogt]

fvogt edited the summary of this revision.
fvogt edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15426

To: fvogt, #frameworks, elvisangelaccio
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15406: Manually resize KCMUtilDialog to sizeHint()

[David Edmundson]

davidedmundson added a comment.


  > neither QWidget::adjustSize() nor QWidget::adjustedSize() seem to use 
devicePixelRatio
  
  They shouldn't.
  
  Both qwidget sizes and qscreen sizes are in logical pixels.

REPOSITORY
  R295 KCMUtils

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15406

To: valeriymalov, #frameworks, ngraham
Cc: davidedmundson, acrouthamel, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kjsembed » kf5-qt5 WindowsMSVCQt5.11 - Build # 4 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kjsembed/job/kf5-qt5%20WindowsMSVCQt5.11/4/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Tue, 11 Sep 2018 16:45:18 +
 Build duration:
39 sec and counting
   CONSOLE OUTPUT
  [...truncated 83.40 KB...]-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Professional/VC/Tools/MSVC/14.14.26428/bin/Hostx64/x64/cl.exe-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Professional/VC/Tools/MSVC/14.14.26428/bin/Hostx64/x64/cl.exe -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Looking for __GLIBC__-- Looking for __GLIBC__ - not found-- Tried to enable sanitizers (-DECM_ENABLE_SANITIZERS=address), but compiler (MSVC) does not have sanitizer support-- Could not set up the appstream test. appstreamcli is missing.-- Found Gettext: C:/Craft/CI-Qt511/windows-msvc2017_64-cl-debug/bin/msgmerge.exe (found version "0.19.8.1") -- Performing Test COMPILER_HAS_DEPRECATED_ATTR-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Failed-- Performing Test COMPILER_HAS_DEPRECATED-- Performing Test COMPILER_HAS_DEPRECATED - Success-- The following OPTIONAL packages have been found: * KF5DocTools (required version >= 5.50.0)-- The following REQUIRED packages have been found: * ECM (required version >= 5.50.0), Extra CMake Modules.,  * Qt5Gui (required version >= 5.11.1) * Qt5UiTools * Qt5Widgets * Qt5Xml * Qt5Svg * Qt5 (required version >= 5.8.0) * Qt5Core * KF5JS (required version >= 5.50.0) * Gettext * KF5I18n (required version >= 5.50.0)-- Configuring done-- Generating doneCMake Warning:  Manually-specified variables were not used by the project:BUILD_QCH-- Build files have been written to: C:/CI/workspace/Frameworks/kjsembed/kf5-qt5 WindowsMSVCQt5.11/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] bat[kf5-qt5 WindowsMSVCQt5.11] Running batch scriptC:\CI\workspace\Frameworks\kjsembed\kf5-qt5 WindowsMSVCQt5.11>call "C:/Program Files (x86)/Microsoft Visual Studio/2017/Professional/VC/Auxiliary/Build/vcvars64.bat"  Visual Studio 2017 Developer Command Prompt v15.7.3** Copyright (c) 2017 Microsoft Corporation**[vcvarsall.bat] Environment initialized for: 'x64'jom 1.1.2 - empower your coresjom: parallel job execution disabled for MakefileScanning dependencies of target docs-kjscmd5-kjscmd5-1Scanning dependencies of target KF5JsEmbed_autogen[  1%] Generating kjscmd5.1[  3%] Automatic MOC for target KF5JsEmbed[  3%] Built target KF5JsEmbed_autogenfile:///C:/CI/workspace/Frameworks/kjsembed/kf5-qt5%20WindowsMSVCQt5.11/install-prefix/bin/data/kf5/kdoctools/customization/dtd/kdedbx45.dtd:102: warning: failed to load external entity "file:///C:/CI/Craft/CI-Qt511/windows-msvc2017_64-cl-debug/bin/data/xml/docbook/schema/dtd/4.5/docbookx.dtd"%DocBookDTD;^file:///C:/CI/workspace/Frameworks/kjsembed/kf5-qt5%20WindowsMSVCQt5.11/install-prefix/bin/data/kf5/kdoctools/customization/dtd/modifications.elements:43: validity error : PEReference: %div.title.content; not found ^file:///C:/CI/workspace/Frameworks/kjsembed/kf5-qt5%20WindowsMSVCQt5.11/install-prefix/bin/data/kf5/kdoctools/customization/dtd/modifications.elements:43: parser error : ContentDecl : Name or '(' expected ^file:///C:/CI/workspace/Frameworks/kjsembed/kf5-qt5%20WindowsMSVCQt5.11/install-prefix/bin/data/kf5/kdoctools/customization/dtd/modifications.elements:43: parser error : expected '>'   ^file:///C:/CI/workspace/Frameworks/kjsembed/kf5-qt5%20WindowsMSVCQt5.11/install-prefix/bin/data/kf5/kdoctools/customization/dtd/modifications.elements:43: parser error : Content error in the external subset   ^man-kjscmd5.1.docbook:6: parser error : Entity 'language' not defined  ^jom: C:\CI\workspace\Frameworks\kjsembed\kf5-qt5 WindowsMSVCQt5.11\build\docs\kjscmd5\CMakeFiles\docs-kjscmd5-kjscmd5-1.dir\build.make [docs\kjscmd5\kjscmd5.1] Error 1jom: C:\CI\workspace\Frameworks\kjsembed\kf5-qt5 WindowsMSVCQt5.11\build\CMakeFiles\Makefile2 [docs\kjscmd5\CMakeFiles\docs-kjscmd5-kjscmd5-1.dir\all] Error 2Scanning dependencies of target KF5JsEmbedjom: C:\CI\workspace\Frameworks\kjsembed\kf5-qt5 WindowsMSVCQt5.11\build\Makefile [all] Error 2[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] emailextrecipients[Pipeline] emailext

KDE CI: Frameworks » kjs » kf5-qt5 WindowsMSVCQt5.11 - Build # 4 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kjs/job/kf5-qt5%20WindowsMSVCQt5.11/4/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Tue, 11 Sep 2018 16:14:43 +
 Build duration:
57 sec and counting
   CONSOLE OUTPUT
  [...truncated 120.25 KB...] * ECM (required version >= 5.50.0), Extra CMake Modules.,  * Qt5Core (required version >= 5.8.0) * Perl,Needed for building kdelibs * Qt5Test (required version >= 5.8.0)-- Configuring doneCMake Warning (dev) in src/kjs/CMakeLists.txt:  Policy CMP0071 is not set: Let AUTOMOC and AUTOUIC process GENERATED files.  Run "cmake --help-policy CMP0071" for policy details.  Use the cmake_policy  command to set the policy and suppress this warning.  For compatibility, CMake is excluding the GENERATED source file(s):"C:/CI/workspace/Frameworks/kjs/kf5-qt5 WindowsMSVCQt5.11/build/src/kjs/date_object.lut.h""C:/CI/workspace/Frameworks/kjs/kf5-qt5 WindowsMSVCQt5.11/build/src/kjs/number_object.lut.h""C:/CI/workspace/Frameworks/kjs/kf5-qt5 WindowsMSVCQt5.11/build/src/kjs/string_object.lut.h""C:/CI/workspace/Frameworks/kjs/kf5-qt5 WindowsMSVCQt5.11/build/src/kjs/array_object.lut.h""C:/CI/workspace/Frameworks/kjs/kf5-qt5 WindowsMSVCQt5.11/build/src/kjs/math_object.lut.h""C:/CI/workspace/Frameworks/kjs/kf5-qt5 WindowsMSVCQt5.11/build/src/kjs/json_object.lut.h""C:/CI/workspace/Frameworks/kjs/kf5-qt5 WindowsMSVCQt5.11/build/src/kjs/regexp_object.lut.h""C:/CI/workspace/Frameworks/kjs/kf5-qt5 WindowsMSVCQt5.11/build/src/kjs/lexer.lut.h""C:/CI/workspace/Frameworks/kjs/kf5-qt5 WindowsMSVCQt5.11/build/src/kjs/opcodes.cpp""C:/CI/workspace/Frameworks/kjs/kf5-qt5 WindowsMSVCQt5.11/build/src/kjs/machine.cpp"  from processing by AUTOMOC.  If any of the files should be processed, set  CMP0071 to NEW.  If any of the files should not be processed, explicitly  exclude them by setting the source file property SKIP_AUTOMOC:set_property(SOURCE file.h PROPERTY SKIP_AUTOMOC ON)This warning is for project developers.  Use -Wno-dev to suppress it.-- Generating doneCMake Warning:  Manually-specified variables were not used by the project:BUILD_QCH-- Build files have been written to: C:/CI/workspace/Frameworks/kjs/kf5-qt5 WindowsMSVCQt5.11/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] bat[kf5-qt5 WindowsMSVCQt5.11] Running batch scriptC:\CI\workspace\Frameworks\kjs\kf5-qt5 WindowsMSVCQt5.11>call "C:/Program Files (x86)/Microsoft Visual Studio/2017/Professional/VC/Auxiliary/Build/vcvars64.bat"  Visual Studio 2017 Developer Command Prompt v15.7.3** Copyright (c) 2017 Microsoft Corporation**[vcvarsall.bat] Environment initialized for: 'x64'jom 1.1.2 - empower your coresjom: parallel job execution disabled for MakefileScanning dependencies of target icemaker_autogenScanning dependencies of target docs-kjs5-kjs5-1Scanning dependencies of target KF5JS_autogen[  3%] Automatic MOC for target icemaker[  3%] Built target icemaker_autogen[  2%] Automatic MOC for target KF5JS[  1%] Generating kjs5.1file:///C:/CI/workspace/Frameworks/kjs/kf5-qt5%20WindowsMSVCQt5.11/install-prefix/bin/data/kf5/kdoctools/customization/dtd/kdedbx45.dtd:102: warning: failed to load external entity "file:///C:/CI/Craft/CI-Qt511/windows-msvc2017_64-cl-debug/bin/data/xml/docbook/schema/dtd/4.5/docbookx.dtd"%DocBookDTD;^file:///C:/CI/workspace/Frameworks/kjs/kf5-qt5%20WindowsMSVCQt5.11/install-prefix/bin/data/kf5/kdoctools/customization/dtd/modifications.elements:43: validity error : PEReference: %div.title.content; not found ^file:///C:/CI/workspace/Frameworks/kjs/kf5-qt5%20WindowsMSVCQt5.11/install-prefix/bin/data/kf5/kdoctools/customization/dtd/modifications.elements:43: parser error : ContentDecl : Name or '(' expected ^file:///C:/CI/workspace/Frameworks/kjs/kf5-qt5%20WindowsMSVCQt5.11/install-prefix/bin/data/kf5/kdoctools/customization/dtd/modifications.elements:43: parser error : expected '>'   ^file:///C:/CI/workspace/Frameworks/kjs/kf5-qt5%20WindowsMSVCQt5.11/install-prefix/bin/data/kf5/kdoctools/customization/dtd/modifications.elements:43: parser error : Content error in the external subset   ^man-kjs5.1.docbook:6: parser error : Entity 'language' not defined  ^man-kjs5.1.docbook:32: parser error : Entity 'kde' not defined ECMAScript compatible interpreter ^[  3%] Built target KF5JS_autogenjom: C:\CI\workspace\Frameworks\kjs\kf5-qt5 WindowsMSVCQt5.11\build\docs\kjs5\CMakeFiles\docs-kjs5-kjs5-1.dir\build.make [docs\kjs5\kjs5.1] Error 1jom: C:\CI\workspace\Frameworks\kjs\kf5-qt5 WindowsMSVCQt5.11\build\CMakeFiles\Makefile2 

D15422: [server] Fix remote access buffer handling when output not bound

[Roman Gilg]

This revision was automatically updated to reflect the committed changes.
Closed by commit R127:1faa629d2791: [server] Fix remote access buffer handling 
when output not bound (authored by romangg).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15422?vs=41423=41425

REVISION DETAIL
  https://phabricator.kde.org/D15422

AFFECTED FILES
  autotests/client/test_remote_access.cpp
  src/server/remote_access_interface.cpp

To: romangg, #kwin, #frameworks, davidedmundson
Cc: jgrulich, davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D15023: [server] Add selectionChanged signal

[Roman Gilg]

romangg updated this revision to Diff 41424.
romangg added a comment.


  Rebase on master.

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15023?vs=41386=41424

BRANCH
  0selectionChangeXwl

REVISION DETAIL
  https://phabricator.kde.org/D15023

AFFECTED FILES
  src/server/seat_interface.cpp
  src/server/seat_interface.h

To: romangg, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 84 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/84/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 11 Sep 2018 15:40:28 +
 Build duration:
4 min 41 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 45 test(s), Skipped: 0 test(s), Total: 45 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)92%
(234/254)92%
(234/254)87%
(24784/28429)54%
(9811/18335)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(41/41)100%
(41/41)99%
(11687/11759)50%
(6204/12323)autotests.server100%
(5/5)100%
(5/5)99%
(353/356)49%
(169/344)src.client99%
(71/72)99%
(71/72)85%
(5732/6771)65%
(1505/2322)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server100%
(115/115)100%
(115/115)87%
(6931/7968)66%
(1933/2933)src.tools0%
(0/2)0%
(0/2)0%
(0/693)0%
(0/272)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/69)0%
(0/10)tests0%
(0/14)0%
(0/14)0%
(0/732)0%
(0/131)

D15422: [server] Fix remote access buffer handling when output not bound

[Roman Gilg]

romangg added a comment.


  At several places only one of two signal spies were waiting, what can lead to 
flickering tests.
  
  Fixed this with an
  
if (spy.size() == 0) {
spy.wait();
}
  
  on the second spy. Is there a nicer solution?

REPOSITORY
  R127 KWayland

BRANCH
  remoteBufferClientsUnbindOutput

REVISION DETAIL
  https://phabricator.kde.org/D15422

To: romangg, #kwin, #frameworks, davidedmundson
Cc: jgrulich, davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D15422: [server] Fix remote access buffer handling when output not bound

[Roman Gilg]

romangg updated this revision to Diff 41423.
romangg added a comment.


  - Some more cleanup of test.

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15422?vs=41422=41423

BRANCH
  remoteBufferClientsUnbindOutput

REVISION DETAIL
  https://phabricator.kde.org/D15422

AFFECTED FILES
  autotests/client/test_remote_access.cpp
  src/server/remote_access_interface.cpp

To: romangg, #kwin, #frameworks, davidedmundson
Cc: jgrulich, davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D15422: [server] Fix remote access buffer handling when output not bound

[Roman Gilg]

romangg updated this revision to Diff 41422.
romangg added a comment.


  Add autotest. Needed larger refactoring to allow multiple clients with 
different outputs being bound.

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15422?vs=41400=41422

BRANCH
  remoteBufferClientsUnbindOutput

REVISION DETAIL
  https://phabricator.kde.org/D15422

AFFECTED FILES
  autotests/client/test_remote_access.cpp
  src/server/remote_access_interface.cpp

To: romangg, #kwin, #frameworks, davidedmundson
Cc: jgrulich, davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D15420: Intialize m_lastPosition

[Jaime Torres Amate]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:3348145dbfbf: Intialize m_lastPosition (authored by 
jtamate).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15420?vs=41393=41419

REVISION DETAIL
  https://phabricator.kde.org/D15420

AFFECTED FILES
  src/view/kateviewaccessible.h

To: jtamate, #ktexteditor, cullmann, volkov
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D15431: Make PersonPluginManager API public

[Igor Poboiko]

poboiko created this revision.
poboiko added reviewers: KDE PIM, dvratil, apol.
poboiko added a project: KDE PIM.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
poboiko requested review of this revision.

REVISION SUMMARY
  This patch makes PersonPluginManager available to third-party applications, 
allowing them to use KPeople in a stand-alone way, without interacting with 
system-wide plugins.
  
  It is part of T9595: [KAddressbook] Use KPeople model for contact list 
. Currently we only want to use only Akonadi 
plugin (to be developed), and then possibly add support for other (i.e. 
KTelepathy) plugins.
  For Akonadi plugin, we want to pass an `EntityTreeModel` to use it as data 
source, which would be impossible if we use system-wide plugin system.
  
  
  
  I've also noted several issues not directly related to this patch, but it 
would be nice to fix those anyways.
  
  - There some ancient compatibility code inside 
`PersonPluginManagerPrivate::loadDataSourcePlugins()`, which was added 3 years 
ago. Apparently, it's not needed anymore.
  - Inside `widgets/CMakeLists.txt`, its headers are installed with PREFIX 
`KPeople` instead of `KPeople/Widgets`. Because of that `#include 
` does not work, because it refers to 
non-existent header `kpeople/persondetailsview.h`.
  - In the same file, there is redundant `install(FILES [...])`, which does not 
install any file (line 46)
  
  If it's OK, I can add those changes without posting a differential revision 
(since they're trivial).

TEST PLAN
  It compiles, it works.

REPOSITORY
  R307 KPeople

REVISION DETAIL
  https://phabricator.kde.org/D15431

AFFECTED FILES
  autotests/persondatatests.cpp
  autotests/personsmodeltest.cpp
  autotests/personsproxymodeltest.cpp
  src/CMakeLists.txt
  src/global.cpp
  src/persondata.cpp
  src/personpluginmanager.cpp
  src/personpluginmanager.h
  src/personpluginmanager_p.h
  src/personsmodel.cpp

To: poboiko, #kde_pim, dvratil, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns, dvasin, rodsevich, winterz, 
vkrause, mlaurent, knauss, dvratil

D15406: Manually resize KCMUtilDialog to sizeHint()

[Andrew Crouthamel]

acrouthamel added a comment.


  In D15406#324063 , @ngraham wrote:
  
  > @acrouthamel, could you test this patch to make sure it doesn't regress 
anything for High DPI users?
  
  
  I can test it out tonight.

REPOSITORY
  R295 KCMUtils

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15406

To: valeriymalov, #frameworks, ngraham
Cc: acrouthamel, kde-frameworks-devel, michaelh, ngraham, bruns

D15406: Manually resize KCMUtilDialog to sizeHint()

[Nathaniel Graham]

ngraham added a comment.


  @acrouthamel, could you test this patch to make sure it doesn't regress 
anything for High DPI users?

REPOSITORY
  R295 KCMUtils

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15406

To: valeriymalov, #frameworks, ngraham
Cc: acrouthamel, kde-frameworks-devel, michaelh, ngraham, bruns

D15406: Manually resize KCMUtilDialog to sizeHint()

[Valeriy Malov]

valeriymalov added a comment.


  neither `QWidget::adjustSize()` nor `QWidget::adjustedSize()` seem to use 
`devicePixelRatio` 
(https://code.qt.io/cgit/qt/qtbase.git/tree/src/widgets/kernel/qwidget.cpp#n8665),
 but I can't test that to vouch that it works on HiDPI as intended
  I can land it as is but I don't really want to break kcmshell further for 
HiDPI users

REPOSITORY
  R295 KCMUtils

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15406

To: valeriymalov, #frameworks, ngraham
Cc: acrouthamel, kde-frameworks-devel, michaelh, ngraham, bruns

D15426: Avoid QByteArray::remove in AccessManagerReply::readData

[Fabian Vogt]

fvogt added a comment.


  Depending on how AccessManagerReply is used, it might be necessary to do 
`m_data.remove(0, m_offset); m_offset = 0;` if `m_offset` grows too large to 
not leak memory. Can a KIO expert answer this?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15426

To: fvogt, #frameworks, elvisangelaccio
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15426: Avoid QByteArray::remove in AccessManagerReply::readData

[Fabian Vogt]

fvogt created this revision.
fvogt added reviewers: Frameworks, elvisangelaccio.
Herald added a project: Frameworks.
fvogt requested review of this revision.

REVISION SUMMARY
  It copies the remaining data to the beginning of the buffer, which can be
  really expensive.
  BUG: 375765

TEST PLAN
  Only build tested, please test with kio-gdrive.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15426

AFFECTED FILES
  src/widgets/accessmanagerreply_p.cpp
  src/widgets/accessmanagerreply_p.h

To: fvogt, #frameworks, elvisangelaccio
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15422: [server] Fix remote access buffer handling when output not bound

[Jan Grulich]

jgrulich added a comment.


  Both versions solve issue I have and KWin no longer opens dozens of fds and 
abort when reaches the limit.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D15422

To: romangg, #kwin, #frameworks
Cc: jgrulich, davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D15422: [server] Fix remote access buffer handling when output not bound

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R127 KWayland

BRANCH
  remoteBufferClientsUnbindOutput

REVISION DETAIL
  https://phabricator.kde.org/D15422

To: romangg, #kwin, #frameworks, davidedmundson
Cc: jgrulich, davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D15422: [server] Fix remote access buffer handling when output not bound

[Roman Gilg]

romangg marked an inline comment as done.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D15422

To: romangg, #kwin, #frameworks
Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D11055: Pack python bindings into right dirs

[Oleg Solovyov]

McPain abandoned this revision.
Herald edited subscribers, added: kde-buildsystem, kde-frameworks-devel; 
removed: Frameworks, Build System.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D11055

To: McPain, vkrause
Cc: kde-frameworks-devel, kde-buildsystem, arojas, apol, michaelh, ngraham, 
bruns, #frameworks, #build_system

D15422: [server] Fix remote access buffer handling when output not bound

[Roman Gilg]

romangg edited the summary of this revision.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D15422

To: romangg, #kwin, #frameworks
Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D15422: [server] Fix remote access buffer handling when output not bound

[Roman Gilg]

romangg retitled this revision from "[server] Fix remote access buffer handlig 
when output not bound" to "[server] Fix remote access buffer handling when 
output not bound".

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D15422

To: romangg, #kwin, #frameworks
Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D15422: [server] Fix remote access buffer handlig when output not bound

[Roman Gilg]

romangg updated this revision to Diff 41400.
romangg marked an inline comment as done.
romangg added a comment.


  - Emit bufferReleased signal instead of cleaning up directly

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15422?vs=41396=41400

BRANCH
  remoteBufferClientsUnbindOutput

REVISION DETAIL
  https://phabricator.kde.org/D15422

AFFECTED FILES
  src/server/remote_access_interface.cpp

To: romangg, #kwin, #frameworks
Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D15422: [server] Fix remote access buffer handlig when output not bound

[Roman Gilg]

romangg added inline comments.

INLINE COMMENTS

> davidedmundson wrote in remote_access_interface.cpp:217
> Would it be better to emit bufferReleased?
> 
> Otherwise we're sometimes doing this deletion in the framework, sometimes in 
> kwin

True, is nicer.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D15422

To: romangg, #kwin, #frameworks
Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D15422: [server] Fix remote access buffer handlig when output not bound

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> remote_access_interface.cpp:217
> +// buffer was not requested by any client
> +close(buf->fd());
> +delete buf;

Would it be better to emit bufferReleased?

Otherwise we're sometimes doing this deletion in the framework, sometimes in 
kwin

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D15422

To: romangg, #kwin, #frameworks
Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D15422: [server] Fix remote access buffer handlig when output not bound

[Roman Gilg]

romangg created this revision.
romangg added reviewers: KWin, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
romangg requested review of this revision.

REVISION SUMMARY
  If a client has not bound a certain output do not directly return
  but try to deliver the buffer to other clients.
  
  If none of them has requested it, directly clean it up.

TEST PLAN
  Manually. Autotest planned.

REPOSITORY
  R127 KWayland

BRANCH
  remoteBufferClientsUnbindOutput

REVISION DETAIL
  https://phabricator.kde.org/D15422

AFFECTED FILES
  src/server/remote_access_interface.cpp

To: romangg, #kwin, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

kio slaves + kcrash + drkonqi

[Harald Sitter]

Hey

I am a bit confused about crash handling in kio slaves. As in: it's
not working the way it should be working and I don't know why it is
the way it is.

The debugging faq [1] suggest that this should behave like KCrash. by
default all crashes get drkonqi'd unless you set KDE_DEBUG at which
point drkonqi is disabled. However, having quickly jumped through the
kdelibs history I am not sure that was true even before the kf5 shake
up...

kio/src/core/slavebase.cpp has

```
if (qEnvironmentVariableIsEmpty("KDE_DEBUG")) {
::signal(SIGSEGV, _handler);

```

sigsegv_handler is a local crash handler that is bypassing kcrash AND
drkonqi entirely and instead prints a backtrace() to stderr.

i.e. by default a slave crash is logged via the local-to-slave crash
handler to stderr. when setting KDE_DEBUG even that logging gets
disabled.

Now to me that makes no sense at all. Why would one want to disable a
simple backtrace print? More importantly, why would one bypass kcrash
at all?

You might rightfully ask why I even care though. The problems are:

a) kcrash isn't used or initialized -> no drkonqi -> no user visible
crash reports about bugged out slaves (as a result it's near useless
to have any q_asserts or qfatals whatsoever in slaves) and we wouldn't
know if the slave quality is garbage
b) since kcrash isn't used -> no recording in dump handler
applications like coredumpd/apport/ABRT -> no way to retrace/report
after the fact either for sysadmins or distros
c) even if kcrash was used it'd still be overridden by the
local-to-slave handler, meaning a slave author can't even force kcrash
use unless they know about this and know how to force the correct
handler to be installed after the local-to-slave handler.

To me it seems all of this is weird and horrible and what I think
would make much more sense is:

- SlaveBase drops the KDE_DEBUG check
- SlaveBase calls KCrash::initialize()
- SlaveBase uses KCrash::setCrashHandler to set its own crash handler
to print the backtrace on stderr
- SlaveBase's backtrace handler then forwards to
KCrash::defaultCrashHandler so shared logic runs (i.e. drkonqi and
then forwarding to dump handlers on linux)
- Possibly KCRASH_AUTO_RESTARTED needs setting by something in KIO.
>From what I see, if I make a slave crash on every invocation, KIO
would try to repeat the action it wanted to do by restarting the salve
ad infinitum when instead it should abort at some point so as to not
spam the user with drkonqis.

The end result is that we still have the stderr backtrace, which I
think is very useful. In fact, by dropping the KDE_DEBUG condition
it's always enabled even when the user disables drkonqi using
KDE_DEBUG=1. The user will get a GUI in the form of drkonqi enabling
them to file a crash report with us so we actually know that our
slaves are crashing. Through KCrash the crash is also forwarded to
system level crash handlers, if applicable, so sysadmins or distros
also know that our slaves are crashing.

(In fact, I'd even argue that maybe kcrash itself should do the
backtrace() print. It seems useful in all crash scenarios I'd imagine,
in particular consider drkonqi can be disabled or not installed. But
then I don't know if/what performance penalty it'd entail with regards
to auto restarts.)

Thoughts?

[1] https://community.kde.org/KDE/FAQs/Debugging_FAQ

D15421: [server] Add surface data proxy mechanism

[Roman Gilg]

romangg added a comment.


  Thinking about it again it makes probably more sense to only allow one proxy 
surface per remote. Otherwise a drag remote can change mid-drag when a user 
presses a second button while the drag is going on.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D15421

To: romangg, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15420: Intialize m_lastPosition

[Alexander Volkov]

volkov accepted this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D15420

To: jtamate, #ktexteditor, cullmann, volkov
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D15421: [server] Add surface data proxy mechanism

[Roman Gilg]

romangg set the repository for this revision to R127 KWayland.
romangg added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D15421

To: romangg, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15023: [server] Add selectionChanged signal

[Roman Gilg]

romangg added a dependent revision: D15421: [server] Add surface data proxy 
mechanism.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D15023

To: romangg, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15421: [server] Add surface data proxy mechanism

[Roman Gilg]

romangg added a dependency: D15023: [server] Add selectionChanged signal.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D15421

To: romangg, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15420: Intialize m_lastPosition

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Reasonable fix. Thanks!

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D15420

To: jtamate, #ktexteditor, cullmann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D12016: [ktexteditor] much faster positionFromCursor

[Jaime Torres Amate]

jtamate added a comment.


  In D12016#323833 , @volkov wrote:
  
  > I get the following warning from valgrind because of this change:
  
  
  Fix in D15420 

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D12016

To: jtamate, #kate, cullmann, #frameworks
Cc: kwrite-devel, kde-frameworks-devel, volkov, anthonyfieroni, mwolff, brauch, 
cullmann, #frameworks, michaelh, kevinapavew, ngraham, bruns, demsking, sars, 
dhaumann

D15420: Intialize m_lastPosition

[Jaime Torres Amate]

jtamate created this revision.
jtamate added reviewers: KTextEditor, cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
jtamate requested review of this revision.

REVISION SUMMARY
  Avoid uninitialized usage of m_lastPosition.

TEST PLAN
  Run kwrite under valgrind, no message.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D15420

AFFECTED FILES
  src/view/kateviewaccessible.h

To: jtamate, #ktexteditor, cullmann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D15417: [AppImage Thumbnailer] Avoid creating QTemporaryFile

[TheAssassin]

TheAssassin accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D15417

To: broulik, #frameworks, TheAssassin, anthonyfieroni

D12016: [ktexteditor] much faster positionFromCursor

[Alexander Volkov]

volkov added a comment.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.


  I get the following warning from valgrind because of this change:
  
==3621== Conditional jump or move depends on uninitialised value(s)
==3621==at 0x4FF3605: 
KateViewAccessible::positionFromCursor(KateViewInternal*, KTextEditor::Cursor 
const&) const (kateviewaccessible.h:201)
==3621==by 0x4FE41CA: 
KateViewInternal::documentTextInserted(KTextEditor::Document*, 
KTextEditor::Range const&) (kateviewinternal.cpp:3830)
==3621==by 0x967762A: call (qobjectdefs_impl.h:376)
==3621==by 0x967762A: QMetaObject::activate(QObject*, int, int, void**) 
(qobject.cpp:3754)
==3621==by 0x50C25E6: 
KTextEditor::DocumentPrivate::textInserted(KTextEditor::Document*, 
KTextEditor::Range const&) (moc_katedocument_6APBFLF6VF33HC.cpp:985)
==3621==by 0x4F498DE: KTextEditor::DocumentPrivate::editInsertText(int, 
int, QString const&) (katedocument.cpp:1235)
==3621==by 0x4F4DF67: 
KTextEditor::DocumentPrivate::insertText(KTextEditor::Cursor const&, QString 
const&, bool) (katedocument.cpp:780)
==3621==by 0x4F51838: 
KTextEditor::DocumentPrivate::typeChars(KTextEditor::ViewPrivate*, QString 
const&) (katedocument.cpp:3024)
==3621==by 0x4FE9BF4: KateViewInternal::keyPressEvent(QKeyEvent*) 
(kateviewinternal.cpp:2522)
==3621==by 0x4FF1F12: KateViewInternal::eventFilter(QObject*, QEvent*) 
(kateviewinternal.cpp:2370)
==3621==by 0x96493EC: 
QCoreApplicationPrivate::sendThroughObjectEventFilters(QObject*, QEvent*) 
(qcoreapplication.cpp:1174)
==3621==by 0x8284834: QApplicationPrivate::notify_helper(QObject*, 
QEvent*) (in /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5.11.0)
==3621==by 0x828D30E: QApplication::notify(QObject*, QEvent*) (in 
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5.11.0)
==3621==  Uninitialised value was created by a heap allocation
==3621==at 0x4C2C25F: operator new(unsigned long) (in 
/usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==3621==by 0x4FE3EF0: accessibleInterfaceFactory(QString const&, 
QObject*) (kateviewaccessible.h:288)
==3621==by 0x8A70D2C: QAccessible::queryAccessibleInterface(QObject*) 
(in /usr/lib/x86_64-linux-gnu/libQt5Gui.so.5.11.0)
==3621==by 0x8A7172E: QAccessibleEvent::accessibleInterface() const (in 
/usr/lib/x86_64-linux-gnu/libQt5Gui.so.5.11.0)
==3621==by 0x8A71BFC: 
QAccessible::updateAccessibility(QAccessibleEvent*) (in 
/usr/lib/x86_64-linux-gnu/libQt5Gui.so.5.11.0)
==3621==by 0x82C0A72: QWidgetPrivate::show_helper() (in 
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5.11.0)
==3621==by 0x82C3CC4: QWidget::setVisible(bool) (in 
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5.11.0)
==3621==by 0x82C0957: QWidgetPrivate::showChildren(bool) (in 
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5.11.0)
==3621==by 0x82C09DE: QWidgetPrivate::show_helper() (in 
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5.11.0)
==3621==by 0x82C0946: QWidgetPrivate::showChildren(bool) (in 
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5.11.0)
==3621==by 0x82C09DE: QWidgetPrivate::show_helper() (in 
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5.11.0)
==3621==by 0x82C3CC4: QWidget::setVisible(bool) (in 
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5.11.0)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D12016

To: jtamate, #kate, cullmann, #frameworks
Cc: kwrite-devel, kde-frameworks-devel, volkov, anthonyfieroni, mwolff, brauch, 
cullmann, #frameworks, michaelh, kevinapavew, ngraham, bruns, demsking, sars, 
dhaumann

D15417: [AppImage Thumbnailer] Avoid creating QTemporaryFile

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Frameworks, TheAssassin, anthonyfieroni.
broulik requested review of this revision.

REVISION SUMMARY
  Instead use new API that returns a buffer to avoid writing to the file system

TEST PLAN
  Built libappimage with https://github.com/AppImage/libappimage/pull/9
  Thumbnails are created just fine

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D15417

AFFECTED FILES
  thumbnail/appimagecreator.cpp

To: broulik, #frameworks, TheAssassin, anthonyfieroni

D15023: [server] Add selectionChanged signal

[Roman Gilg]

romangg updated this revision to Diff 41386.
romangg added a comment.


  Rebase on master.

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15023?vs=40302=41386

BRANCH
  0selectionChangeXwl

REVISION DETAIL
  https://phabricator.kde.org/D15023

AFFECTED FILES
  src/server/seat_interface.cpp
  src/server/seat_interface.h

To: romangg, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns