D15194: Draw a line separating PlasmaComponents tab bar from its content area

romangg added a comment. If there are more items than space available in the list a line is drawn already now to indicate that there are more items to come by scrolling down. Does this not conflict with the new line? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://pha

D15611: [KCollapsibleGroupBox] Respect styles that disable widget animations

ngraham added a comment. Shouldn't the duration respect the global setting rather than being hardcoded to 500ms? REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D15611 To: cfeck, #frameworks Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D15194: Draw a line separating PlasmaComponents tab bar from its content area

ngraham added a comment. So I've got a +1 from VDG. Any opinions from someone in #plasma ? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15194 To: ngraham, #plasma, #vdg Cc: abetts, kde-frameworks-devel,

D15583: [Balooctl] fix directory parent check

ngraham added reviewers: Frameworks, cfeck. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15583 To: ngraham, #baloo, #dolphin, bruns, #frameworks, cfeck Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D11880: Add firewalld icons

ngraham added a comment. In D11880#328630 , @ndavis wrote: > Panic mode in FirewallD is not worse than Error. Panic mode is enabled by the user. It is something that the user enables when they need to stop all network traffic to the system.

D11880: Add firewalld icons

ndavis added a comment. In D11880#328623 , @ngraham wrote: > Oops, it looks like this patch totally got missed, sorry! > > Not sure I like that `firewall-applet-error` is linked to `security-low`. To me, a firewall error should have some more

D13315: Detect mime type of local files based on their contents

ngraham added a comment. In D13315#328252 , @miklosm wrote: > There may be an other solution to the problem I was trying to solve with this patch series: remove the jpeg thumbnailer, and let the generic image thumbnailer handle jpeg as well.

D11880: Add firewalld icons

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks. Oops, it looks like this patch totally got missed, sorry! Not sure I like that `firewall-applet-e

D15611: [KCollapsibleGroupBox] Respect styles that disable widget animations

cfeck created this revision. cfeck added a reviewer: Frameworks. cfeck added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cfeck requested review of this revision. REVISION SUMMARY Query QStyle::SH_Widget_Animate style hint to check if the style has animations. QTime

D15559: Python bindings: use cmake_parse_arguments, fix documentation

bruns updated this revision to Diff 41952. bruns added a comment. Fix parentheses REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15559?vs=41772&id=41952 BRANCH python_ecm_cleanup REVISION DETAIL https://phabricator.kde.org/D15559 AFFECTED

D15559: Python bindings: use cmake_parse_arguments, fix documentation

bruns added a reviewer: dfaure. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D15559 To: bruns, #frameworks, dfaure Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D15559: Python bindings: use cmake_parse_arguments, fix documentation

bruns retitled this revision from "Python bindings: use cmake_parse_arguements, fix documentation" to "Python bindings: use cmake_parse_arguments, fix documentation". bruns edited the summary of this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 410 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/410/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 19 Sep 2018 20:31:40 + Build duration: 18 min and counting JUnit Tests Name: (root) Failed: 1 test

D13700: implement reading of the replaygain tags

This revision was automatically updated to reflect the committed changes. Closed by commit R286:22c0757e6e51: implement reading of the replaygain tags (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13700?vs=41429&id=41948 REVISI

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 255 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/255/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 19 Sep 2018 20:31:40 + Build duration: 16 min and counting JUnit Tests Name: (root) Failed: 1 test(s

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 25 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/25/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 19 Sep 2018 20:31:40 + Build duration: 1.3 sec and counting CONSOLE OUTPUT Started by

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 227 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/227/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 19 Sep 2018 14:05:02 + Build duration: 2 min 11 sec and counting JUnit Tests Name: (r

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.9 - Build # 152 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.9/152/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 19 Sep 2018 13:58:41 + Build duration: 7 min 46 sec and counting JUnit Tests Name: (roo

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 226 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/226/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 19 Sep 2018 13:49:09 + Build duration: 15 min and counting JUnit Tests Name: (root) F

D15591: Add Open Document thumbnailer

abetts added a comment. +1 REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D15591 To: broulik, #frameworks, #vdg, ngraham, kossebau, jtamate, fvogt, wbauer Cc: abetts, kde-frameworks-devel, kfm-devel, leinir, kossebau, jtamate, ngraham, feverfew, michaelh, spoorun

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.9 - Build # 151 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.9/151/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 19 Sep 2018 13:55:19 + Build duration: 3 min 21 sec and counting JUnit Tests Name: (roo

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.9 - Build # 150 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.9/150/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 19 Sep 2018 13:49:09 + Build duration: 3 min 23 sec and counting JUnit Tests Name: (roo

D15364: Plasma style: Remove hardcoded textFormat

broulik added a comment. I thought we did that consciously and intentionally since we could break compat here and the `AutoText` which tries to guess from the contents and even allows injecting `img` was something we wanted to avoid? REPOSITORY R242 Plasma Framework (Library) REVISION DET

D15364: Plasma style: Remove hardcoded textFormat

jbbgameich added a comment. @davidedmundson I'm not yet used to the KDE Phabricator workfolow... do I need to do anything else to get this patch landed / included? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15364 To: jbbgameich, #plasma, davi

D15591: Add Open Document thumbnailer

This revision was automatically updated to reflect the committed changes. Closed by commit R320:6828ff113ac3: Add Open Document thumbnailer (authored by broulik). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15591?vs=41926&id=41934 REVISION DETAIL http

D15591: Add Open Document thumbnailer

broulik added a reviewer: wbauer. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D15591 To: broulik, #frameworks, #vdg, ngraham, kossebau, jtamate, fvogt, wbauer Cc:

D15591: Add Open Document thumbnailer

jtamate accepted this revision. jtamate added a comment. This revision is now accepted and ready to land. Ok by side. It installs now, and don't ask for passwords. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D15591 To: broulik, #frameworks, #vdg, ngraham, kosse

D13315: Detect mime type of local files based on their contents

bcooksley added a comment. Please note that any CMS that isn't serving files for download properly (ie. not using Content-Disposition and telling the client the name the file should be called) is broken and isn't something we can fix. REPOSITORY R241 KIO REVISION DETAIL https://phabrica

D15591: Add Open Document thumbnailer

broulik updated this revision to Diff 41926. broulik added a reviewer: fvogt. broulik added a comment. - Add missing desktop file REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15591?vs=41905&id=41926 REVISION DETAIL https://phabricator.kde.org/D15591

D13315: Detect mime type of local files based on their contents

dfaure added a comment. I agree, extensions are not reliable over HTTP, which is why mimeTypeForUrl doesn't use them for HTTP urls. But here we're in KFileItem, so much more likely talking about local files or FTP/SFTP/FISH/SMB/etc. where the *.php issue doesn't happen. > The case of M