D15645: [WIP] Add scheme selection menu with a "System" entry.

2018-09-22 Thread Shubham
shubham added inline comments. INLINE COMMENTS > kcolorschememanager.cpp:39 > > +KActionMenu* KColorSchemeManagerPrivate::createSchemeMenu(const QIcon , > const QString , const QString , bool defaultEntry, > QObject *parent) > +{ KActionMenu* -> KActionMenu * REPOSITORY R265

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 27 - Still unstable!

2018-09-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/27/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sun, 23 Sep 2018 03:43:43 + Build duration: 1 hr 3 min and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 257 - Still Unstable!

2018-09-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/257/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sun, 23 Sep 2018 03:43:42 + Build duration: 30 min and counting JUnit Tests Name: (root) Failed: 1

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 412 - Still Unstable!

2018-09-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/412/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 23 Sep 2018 03:43:42 + Build duration: 10 min and counting JUnit Tests Name: (root) Failed: 1

D15645: [WIP] Add scheme selection menu with a "System" entry.

2018-09-22 Thread Nathaniel Graham
ngraham added a comment. Very much +1 on the end goal! INLINE COMMENTS > amhndu wrote in kcolorschememanager.h:127 > `createSchemeSelectionMenuWithDefaultEntry` ? > won't it be too big ? I think it's okay. Pixels and characters are cheap. :) REPOSITORY R265 KConfigWidgets REVISION

D15426: Avoid QByteArray::remove in AccessManagerReply::readData

2018-09-22 Thread Nathaniel Graham
ngraham added a comment. So this doesn't completely fix https://bugs.kde.org/show_bug.cgi?id=375765? More is needed? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15426 To: fvogt, #frameworks, elvisangelaccio, dfaure, svuorela Cc: svuorela, ngraham, bruns,

D15615: bump required taglib version

2018-09-22 Thread Sune Vuorela
svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH bumb_taglib_version REVISION DETAIL https://phabricator.kde.org/D15615 To: astippich, mgallien, svuorela Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh,

D15614: remove usage of own TString to QString conversion function

2018-09-22 Thread Sune Vuorela
svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH taglib_extractor_string_conversion REVISION DETAIL https://phabricator.kde.org/D15614 To: astippich, bruns, mgallien, svuorela Cc: kde-frameworks-devel, #baloo,

D15583: [Balooctl] remove directory parent check

2018-09-22 Thread Nathaniel Graham
ngraham retitled this revision from "[Balooctl] fix directory parent check" to "[Balooctl] remove directory parent check". ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15583

D15583: [Balooctl] fix directory parent check

2018-09-22 Thread Nathaniel Graham
ngraham updated this revision to Diff 42152. ngraham edited the test plan for this revision. ngraham added a comment. Remove parent directory check entirely; it's not necessary REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15583?vs=42018=42152 BRANCH

D15583: [Balooctl] fix directory parent check

2018-09-22 Thread Nathaniel Graham
ngraham added a comment. Oh wow, you're right. Let me fix `balooctl` to support that, then. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15583 To: ngraham, #baloo, #dolphin, bruns, #frameworks Cc: anthonyfieroni, kde-frameworks-devel, ashaposhnikov, michaelh,

D15697: Fix deletion of files from DAV

2018-09-22 Thread Daniel Vrátil
dvratil created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dvratil requested review of this revision. REVISION SUMMARY Always assume del() deletes a file, not a directory so don't try to append slash at the end of the path. Some servers

D15697: Fix deletion of files from DAV

2018-09-22 Thread Daniel Vrátil
dvratil added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15697 To: dvratil, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15644: Provide option to hide menu bar for Ksysguard

2018-09-22 Thread Nathaniel Graham
ngraham added a comment. In D15644#330281 , @lsartorelli wrote: > Hi Nathaniel, thanks for all the support. > I can understand and agree with your concerns. > Not sure but maybe an option could be to add the hide menu bar entry in the

D15644: Provide option to hide menu bar for Ksysguard

2018-09-22 Thread Luca Sartorelli
lsartorelli added a comment. Hi Nathaniel, thanks for all the support. I can understand and agree with your concerns. Not sure but maybe an option could be to add the hide menu bar entry in the setting menu via kxmlguiwindow and another entry to unhide it maybe can be putted in the

D15644: Provide option to hide menu bar for Ksysguard

2018-09-22 Thread Luca Sartorelli
lsartorelli retitled this revision from "Provide option to hide menu bar for Ksysguard - Bug 395349" to "Provide option to hide menu bar for Ksysguard". lsartorelli edited the summary of this revision. REVISION DETAIL https://phabricator.kde.org/D15644 To: lsartorelli, ngraham, #plasma,

D15687: [Device Notifier] Avoid accessing attributes of stale UDIs

2018-09-22 Thread Stefan Brüns
bruns marked an inline comment as done. bruns added inline comments. INLINE COMMENTS > ngraham wrote in FullRepresentation.qml:180 > Indentation irks, tabs ... REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D15687 To: bruns, #frameworks Cc: ngraham,

D15687: [Device Notifier] Avoid accessing attributes of stale UDIs

2018-09-22 Thread Stefan Brüns
bruns updated this revision to Diff 42149. bruns added a comment. fix indentation REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15687?vs=42127=42149 REVISION DETAIL https://phabricator.kde.org/D15687 AFFECTED FILES

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 26 - Still unstable!

2018-09-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/26/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sat, 22 Sep 2018 16:24:11 + Build duration: 1 hr 29 min and counting JUnit Tests Name:

D15583: [Balooctl] fix directory parent check

2018-09-22 Thread Stefan Brüns
bruns added a comment. In D15583#330119 , @ngraham wrote: > In D15583#330085 , @bruns wrote: > > > I think the whole `startsWith` is flawed - it should be possible to have a e.g.

D15566: Add QT_NO_NARROWING_CONVERSIONS_IN_CONNECT as default compile flags

2018-09-22 Thread Laurent Montel
This revision was automatically updated to reflect the committed changes. Closed by commit R240:9b528012703a: Add QT_NO_NARROWING_CONVERSIONS_IN_CONNECT as default compile flags (authored by mlaurent). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 256 - Still Unstable!

2018-09-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/256/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sat, 22 Sep 2018 16:24:11 + Build duration: 17 min and counting JUnit Tests Name: (root) Failed: 1

D15426: Avoid QByteArray::remove in AccessManagerReply::readData

2018-09-22 Thread Sune Vuorela
svuorela added a comment. @fvogt mostly a unit test that ensures that all these 3 codepaths in slotData works. I'm not sure that the current unit tests ensures that. I might be wrong though. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15426 To: fvogt, #frameworks,

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 411 - Still Unstable!

2018-09-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/411/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 22 Sep 2018 16:24:11 + Build duration: 5 min 54 sec and counting JUnit Tests Name: (root) Failed:

D15426: Avoid QByteArray::remove in AccessManagerReply::readData

2018-09-22 Thread Fabian Vogt
This revision was automatically updated to reflect the committed changes. Closed by commit R241:d2d52da38016: Avoid QByteArray::remove in AccessManagerReply::readData (authored by fvogt). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15426?vs=41476=42138

D15426: Avoid QByteArray::remove in AccessManagerReply::readData

2018-09-22 Thread Fabian Vogt
fvogt added a comment. @svuorela accessmanagertest already tests whether the AMR works in general. Do you mean a test which ensures there is no performance regression? REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D15426 To: fvogt, #frameworks,

D15426: Avoid QByteArray::remove in AccessManagerReply::readData

2018-09-22 Thread Sune Vuorela
svuorela accepted this revision. svuorela added a comment. This revision is now accepted and ready to land. Though unit tests would be nice. It looks like something that quite easy could break if next author is not careful. REPOSITORY R241 KIO BRANCH master REVISION DETAIL

D15277: [RFC] kio_mtp: Move MTP device handling from kioslave to kiod-module

2018-09-22 Thread David Faure
dfaure added inline comments. INLINE COMMENTS > elvisangelaccio wrote in kmtpd.json:10 > Currently the module is spawned by the ioslave on-demand. But imho it should > be possible to browse the device using only dbus, without having to open > dolphin first. > > Can we try to autostart the

D15277: [RFC] kio_mtp: Move MTP device handling from kioslave to kiod-module

2018-09-22 Thread David Faure
dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. This is excellent work, thanks a lot for doing this. I just have "a few" minor comments... ;) INLINE COMMENTS > kio_mtp.cpp:107 > { > -qCDebug(LOG_KIO_MTP) << url.path(); >

D15687: [Device Notifier] Avoid accessing attributes of stale UDIs

2018-09-22 Thread Nathaniel Graham
ngraham added a comment. Code change looks pretty sane to me. INLINE COMMENTS > FullRepresentation.qml:180 > actionToolTip: { > + var types = model["Device Types"]; > if (!mounted) { Indentation REPOSITORY R120 Plasma Workspace REVISION DETAIL

D15583: [Balooctl] fix directory parent check

2018-09-22 Thread Nathaniel Graham
ngraham added a comment. In D15583#330085 , @bruns wrote: > I think the whole `startsWith` is flawed - it should be possible to have a e.g. "/home/user/foo/bar" include when "/home/user/foo" has been excluded. Hmm, I'm not sure how much

D15277: [RFC] kio_mtp: Move MTP device handling from kioslave to kiod-module

2018-09-22 Thread Elvis Angelaccio
elvisangelaccio added inline comments. INLINE COMMENTS > kmtpd.json:10 > +"X-KDE-DBus-ServiceName": "kmtpd", > +"X-KDE-Kded-autoload": false, > +"X-KDE-Kded-load-on-demand": true Currently the module is spawned by the ioslave on-demand. But imho it should be possible to browse the

D15277: [RFC] kio_mtp: Move MTP device handling from kioslave to kiod-module

2018-09-22 Thread Elvis Angelaccio
elvisangelaccio added a reviewer: dfaure. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D15277 To: akrutzler, elvisangelaccio, ltoscano, hetzenecker, dfaure Cc: kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, navarromorales, firef, ngraham,

D15277: [RFC] kio_mtp: Move MTP device handling from kioslave to kiod-module

2018-09-22 Thread Elvis Angelaccio
elvisangelaccio added a comment. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. From a quick look, the architecture is sound and respects what was discussed in T9390 . And indeed it works pretty well,

D15566: Add QT_NO_NARROWING_CONVERSIONS_IN_CONNECT as default compile flags

2018-09-22 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH add_QT_NO_NARROWING_CONVERSIONS_IN_CONNECT REVISION DETAIL https://phabricator.kde.org/D15566 To: mlaurent, dfaure Cc: kde-frameworks-devel, kde-buildsystem,

D15583: [Balooctl] fix directory parent check

2018-09-22 Thread Stefan Brüns
bruns added a comment. I think the whole `startsWith` is flawed - it should be possible to have a e.g. "/home/user/foo/bar" include when "/home/user/foo" has been excluded. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15583 To: ngraham, #baloo, #dolphin, bruns,

D15566: Add QT_NO_NARROWING_CONVERSIONS_IN_CONNECT as default compile flags

2018-09-22 Thread Laurent Montel
mlaurent added a comment. Ping? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D15566 To: mlaurent, dfaure Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D15687: [Device Notifier] Avoid accessing attributes of stale UDIs

2018-09-22 Thread Stefan Brüns
bruns updated this revision to Diff 42127. bruns added a comment. add one more invalid access fix REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15687?vs=42123=42127 REVISION DETAIL https://phabricator.kde.org/D15687 AFFECTED FILES

D15687: [Device Notifier] Avoid accessing attributes of stale UDIs

2018-09-22 Thread Stefan Brüns
bruns created this revision. bruns added a reviewer: Frameworks. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY When a Solid device is removed (e.g. a CD is ejected) the notifier tries to read the attributes

D15686: Prevent highlighter from erasing selected text

2018-09-22 Thread Simon Depiets
sdepiets closed this revision. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D15686 To: sdepiets, #framework_syntax_highlighting, mlaurent, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15686: Prevent highlighter from erasing selected text

2018-09-22 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R246 Sonnet BRANCH master REVISION DETAIL https://phabricator.kde.org/D15686 To: sdepiets, #framework_syntax_highlighting, mlaurent, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15686: Prevent highlighter from erasing selected text

2018-09-22 Thread Simon Depiets
sdepiets updated this revision to Diff 42121. sdepiets added a comment. Coding style REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15686?vs=42120=42121 BRANCH master REVISION DETAIL https://phabricator.kde.org/D15686 AFFECTED FILES

D15686: Prevent highlighter from erasing selected text

2018-09-22 Thread David Faure
dfaure added a comment. Makes sense. INLINE COMMENTS > highlighter.cpp:198 > +if (cursor.hasSelection()) > +{ > +cursor.clearSelection(); coding style: join with previous line REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D15686 To:

D15686: Prevent highlighter from erasing selected text

2018-09-22 Thread Simon Depiets
sdepiets edited the summary of this revision. sdepiets added reviewers: Framework: Syntax Highlighting, mlaurent, dfaure. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D15686 To: sdepiets, #framework_syntax_highlighting, mlaurent, dfaure Cc: kde-frameworks-devel,

D15686: Prevent highlighter from erasing selected text

2018-09-22 Thread Simon Depiets
sdepiets created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sdepiets requested review of this revision. REPOSITORY R246 Sonnet BRANCH master REVISION DETAIL https://phabricator.kde.org/D15686 AFFECTED FILES src/ui/highlighter.cpp

D11880: Add firewall-config and firewall-applet icons

2018-09-22 Thread Noah Davis
ndavis updated this revision to Diff 42119. ndavis added a comment. Change to bruns/state-* hybrid style REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11880?vs=41973=42119 BRANCH firewalld-icons (branched from master) REVISION DETAIL