D15718: Do not index the path if the path has no execute permissions.

2018-09-24 Thread James Smith
smithjd added a comment.


  > No, because even if the default umask is 002, or 022, POSIX says that the 
default permissions of a file on creation are going to be 0666, not 0777:
  
  Trial-and-error proven. :(
  
  In D15718#331449 , @ngraham wrote:
  
  > Let's back up a bit. What's the goal here? What are you trying to 
accomplish?
  
  
  Baloo currently has no method for do-not-index. Perhaps a better way exists 
that prevents new downloads from automatically being indexed and can also 
prevent Baloo vaults from being indexed?
  
  Tracker uses a .trackerignore file. This (or something similar) probably has 
little chance as a default distro safety feature and its usefulness is 
questionable (browsers let you save outside the downloads folder), so this is 
out for the first requirement. This may be a candidate for the second 
requirement.
  
  While this method is already proven, the xdg method of setting tags can fit 
well the second requirement. KDE is sadly lacking in xattr support (no 
'Attributes' tab in file property dialog, xattrs can be silently dropped by KIO 
when moved across filesystems, ...). A variation of the xdg recommendation, 
only recognizing false tags, would also work well.
  
  The first requirement could be solved by ignoring files with no execute bit 
set, though this is opposed. (extra work, etc)

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15718

To: smithjd, ngraham, #baloo, ltoscano
Cc: ltoscano, marten, bruns, ngraham, kde-frameworks-devel, #baloo, 
ashaposhnikov, michaelh, astippich, spoorun, abrahams


D11880: Add firewall-config and firewall-applet icons

2018-09-24 Thread Noah Davis
ndavis added a comment.


  In D11880#331450 , @ngraham wrote:
  
  > FWIW, I'm okay with the existing `firewall-applet`. So here's what we've 
got now, as viewed with `cuttlefish`:
  >  F6283724: Screenshot_20180924_215450.png 

  >
  > I say +1!
  >
  > However, there seems to be a problem for the breeze dark versions:
  >  F6283726: Screenshot_20180924_215524.png 

  >
  > Shouldn't the wall be light-colored? Does it work for you when actually 
deployed and in use with breeze dark?
  
  
  Yes, it should be #f2f2f2 and it is on my end. I have the correct color on my 
own copy and when I download the raw files from Phabricator. Are you sure you 
aren't experiencing some kind of bug or maybe your cache is old?

REPOSITORY
  R266 Breeze Icons

BRANCH
  firewalld-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, michaelh


D7446: [Places panel] Add a Recently Used item by default

2018-09-24 Thread Nathaniel Graham
ngraham edited reviewers, added: VDG, Frameworks; removed: KDE Applications, 
dfaure, emmanuelp.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: ngraham, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks, 
#kde_applications
Cc: kde-frameworks-devel, spoorun, anthonyfieroni, andreaska, gregormi, markg, 
alexeymin, broulik, elvisangelaccio, dfaure, davidedmundson, ltoscano, 
#konqueror, feverfew, michaelh, navarromorales, firef, ngraham, andrebarros, 
bruns, emmanuelp


D15739: [Places panel] Don't show Root by default

2018-09-24 Thread Nathaniel Graham
ngraham edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15739

To: ngraham, #dolphin, #vdg
Cc: acrouthamel, kde-frameworks-devel, michaelh, ngraham, bruns


D15739: [Places panel] Don't show Root by default

2018-09-24 Thread Nathaniel Graham
ngraham edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15739

To: ngraham, #dolphin, #vdg
Cc: acrouthamel, kde-frameworks-devel, michaelh, ngraham, bruns


D11880: Add firewall-config and firewall-applet icons

2018-09-24 Thread Nathaniel Graham
ngraham added a comment.


  FWIW, I'm okay with the existing `firewall-applet`. So here's what we've got 
now, as viewed with `cuttlefish`:
  F6283724: Screenshot_20180924_215450.png 

  
  I say +1!
  
  However, there seems to be a problem for the breeze dark versions:
  F6283726: Screenshot_20180924_215524.png 

  
  Shouldn't the wall be light-colored? Does it work for you when actually 
deployed and in use with breeze dark?

REPOSITORY
  R266 Breeze Icons

BRANCH
  firewalld-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, michaelh


D15718: Do not index the path if the path has no execute permissions.

2018-09-24 Thread Nathaniel Graham
ngraham added a comment.


  Let's back up a bit. What's the goal here? What are you trying to accomplish?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15718

To: smithjd, ngraham, #baloo, ltoscano
Cc: ltoscano, marten, bruns, ngraham, kde-frameworks-devel, #baloo, 
ashaposhnikov, michaelh, astippich, spoorun, abrahams


D11767: Remove Recently Saved This Month and Recently Saved Last Month entries by default

2018-09-24 Thread Nathaniel Graham
ngraham added a task: T8349: Improve Places panel usability and presentation.
Herald added a subscriber: kde-frameworks-devel.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11767

To: ngraham, #dolphin, #gwenview, #frameworks, #vdg, davidedmundson
Cc: kde-frameworks-devel, rkflx, davidedmundson, michaelh, sharvey, 
elvisangelaccio, abetts, rizzitello, ngraham, bruns


D11880: Add firewall-config and firewall-applet icons

2018-09-24 Thread Nathaniel Graham
ngraham added a comment.


  In D11880#330865 , @ndavis wrote:
  
  > In D11880#330861 , @ngraham 
wrote:
  >
  > > For the panic mode icon, how about leaving the wall itself black, and 
only the lock is orange?
  >
  >
  > Like this? This is #4d4d4d (icon grey), the standard color for small breeze 
icons, not black.
  >  F6281673: Screenshot_20180924_000854.png 
F6281669: Screenshot_20180924_000627.png 

  
  
  Perfect, I love it!

REPOSITORY
  R266 Breeze Icons

BRANCH
  firewalld-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, michaelh


D7446: [Places panel] Add a Recently Used item by default

2018-09-24 Thread Nathaniel Graham
ngraham added a comment.


  I'd like to re-submit this patch (now re-based on master) for consideration. 
I put some work into improving the `recentdocuments:/` ioslave in D14893 
 so it's useful now. User requests for this 
feature to be added by default still pop up from time to time, and both GNOME 
and macOS both have this feature in their file browsers and file pickers. I 
think it's relevant and desirable.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: ngraham, #dolphin, #kde_applications, broulik, elvisangelaccio, dfaure, 
emmanuelp, markg
Cc: kde-frameworks-devel, spoorun, anthonyfieroni, andreaska, gregormi, markg, 
alexeymin, broulik, elvisangelaccio, dfaure, davidedmundson, ltoscano, 
#konqueror, feverfew, michaelh, navarromorales, firef, ngraham, andrebarros, 
bruns, emmanuelp


D15739: [Places panel] Don't show Root by default

2018-09-24 Thread Andrew Crouthamel
acrouthamel added a comment.


  +1
  
  Seeing "Root" written as such, also makes me think of `/root`, which makes no 
sense to have there. The odds of needing quick access to `/` via Dolphin are 
extremely rare, and there is already a link anyway. People are used to clicking 
the primary drive to get to root dir.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15739

To: ngraham, #dolphin, #vdg
Cc: acrouthamel, kde-frameworks-devel, michaelh, ngraham, bruns


D7446: [Places panel] Add a Recently Used item by default

2018-09-24 Thread Nathaniel Graham
ngraham edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: ngraham, #dolphin, #kde_applications, broulik, elvisangelaccio, dfaure, 
emmanuelp, markg
Cc: kde-frameworks-devel, spoorun, anthonyfieroni, andreaska, gregormi, markg, 
alexeymin, broulik, elvisangelaccio, dfaure, davidedmundson, ltoscano, 
#konqueror, feverfew, michaelh, navarromorales, firef, ngraham, andrebarros, 
bruns, emmanuelp


D7446: [Places panel] Add a Recently Used item by default

2018-09-24 Thread Nathaniel Graham
ngraham added a task: T8349: Improve Places panel usability and presentation.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: ngraham, #dolphin, #kde_applications, broulik, elvisangelaccio, dfaure, 
emmanuelp, markg
Cc: kde-frameworks-devel, spoorun, anthonyfieroni, andreaska, gregormi, markg, 
alexeymin, broulik, elvisangelaccio, dfaure, davidedmundson, ltoscano, 
#konqueror, feverfew, michaelh, navarromorales, firef, ngraham, andrebarros, 
bruns, emmanuelp


D7446: [Places panel] Add a Recently Used item by default

2018-09-24 Thread Nathaniel Graham
ngraham retitled this revision from "Add a Recent Documents places item to 
Dolphin and file pickers by default" to "[Places panel] Add a Recently Used 
item by default".
ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: ngraham, #dolphin, #kde_applications, broulik, elvisangelaccio, dfaure, 
emmanuelp, markg
Cc: kde-frameworks-devel, spoorun, anthonyfieroni, andreaska, gregormi, markg, 
alexeymin, broulik, elvisangelaccio, dfaure, davidedmundson, ltoscano, 
#konqueror, feverfew, michaelh, navarromorales, firef, ngraham, andrebarros, 
bruns, emmanuelp


D14893: [recentdocuments:/] Filter out files that can't be browsed with a file manager

2018-09-24 Thread Nathaniel Graham
ngraham added a task: T8349: Improve Places panel usability and presentation.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D14893

To: ngraham, broulik, #dolphin, #frameworks
Cc: kde-frameworks-devel, kfm-devel, elvisangelaccio, markg, feverfew, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp


D7446: Add a Recent Documents places item to Dolphin and file pickers by default

2018-09-24 Thread Nathaniel Graham
ngraham updated this revision to Diff 42277.
ngraham added a comment.
Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks.


  Re-base on master

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7446?vs=18867=42277

REVISION DETAIL
  https://phabricator.kde.org/D7446

AFFECTED FILES
  src/filewidgets/kfileplacesmodel.cpp

To: ngraham, #dolphin, #kde_applications, broulik, elvisangelaccio, dfaure, 
emmanuelp, markg
Cc: kde-frameworks-devel, spoorun, anthonyfieroni, andreaska, gregormi, markg, 
alexeymin, broulik, elvisangelaccio, dfaure, davidedmundson, ltoscano, 
#konqueror, feverfew, michaelh, navarromorales, firef, ngraham, andrebarros, 
bruns, emmanuelp, #frameworks


D15739: [Places panel] Don't show Root by default

2018-09-24 Thread Nathaniel Graham
ngraham added a task: T8349: Improve Places panel usability and presentation.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15739

To: ngraham, #dolphin, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D15739: [Places panel] Don't show Root by default

2018-09-24 Thread Nathaniel Graham
ngraham edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15739

To: ngraham, #dolphin, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D15739: [Places panel] Don't show Root by default

2018-09-24 Thread Nathaniel Graham
ngraham created this revision.
ngraham added reviewers: Dolphin, VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This patch removes Root from the default Places panel for new installations, 
for the following reasons:
  
  - It's redundant; you can still get to / on your machine in one click using 
the appropriate disk entry on the bottom of the Places panel.
  - The Root item shows up in red, indicating its danger. Dangerous items are 
probably not a good idea to show by default, especially not right next to safe 
items such as Home.
  - It's not very useful. On Linux systems, messing around with / is 
discouraged, and Dolphin doesn't even yet have the ability to modify files and 
folders there anyway even if the user wanted to; it's purely read-only. The 
usefulness of such a thing is questionable.
  - By removing it, we gain room to add something more useful such as a Recent 
Documents item (D7446 ) without making the 
Places panel show a vertical scrollbar with Dolphin's default size.

TEST PLAN
  Login in with a new user account or rm `~/.local/share/user-places.xbel` and 
open Dolphin; notice that Root is not on the Places panel.
  
  [image goes here]
  
  Existing user accounts are untouched.

REPOSITORY
  R241 KIO

BRANCH
  remote-root-from-places-panel (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15739

AFFECTED FILES
  src/filewidgets/kfileplacesmodel.cpp

To: ngraham, #dolphin, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D15718: Do not index the path if the path has no execute permissions.

2018-09-24 Thread James Smith
smithjd added a comment.


  https://www.freedesktop.org/wiki/CommonExtendedAttributes suggests xattrs to 
use to store do-not-index information and also requires each file to be 
explicitly set to be indexed.
  
  > user.xdg.robots.index: On a file: "true" to index, "false" to not index. On 
a directory: "true" to traverse the into the directory for indexing, "false" 
for not traversing into it.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15718

To: smithjd, ngraham, #baloo, ltoscano
Cc: ltoscano, marten, bruns, ngraham, kde-frameworks-devel, #baloo, 
ashaposhnikov, michaelh, astippich, spoorun, abrahams


D15583: [Balooctl] remove directory parent check

2018-09-24 Thread Nathaniel Graham
ngraham added a comment.


  https://phabricator.kde.org/D15583?id=42018 didn't let you add `~/foo/bar` to 
the list of includes or excludes if `~/foo` was already present.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15583

To: ngraham, #baloo, #dolphin, bruns, #frameworks
Cc: smithjd, anthonyfieroni, kde-frameworks-devel, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams


D15721: Make lock on plasmavault icon visible with breeze-dark

2018-09-24 Thread Nathaniel Graham
ngraham added a comment.


  Can you provide steps to reproduce the problem so I can test it? In my naive 
testing, the `plasmavault` icon looks like a lock and shows up fine on both 
Breeze Light and Breeze Dark. I'm also confused by the images you posted (which 
should be in the Test Plan{ section, BTW that depict different icons. Can you 
help a brotha out?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15721

To: ndavis, #vdg
Cc: ngraham, abetts, kde-frameworks-devel, michaelh, bruns


D15583: [Balooctl] remove directory parent check

2018-09-24 Thread James Smith
smithjd added a comment.


  What was wrong with https://phabricator.kde.org/D15583?id=42018 ?
  
  > I could see the case for allowing this behavior to be explicitly overridden 
by an advanced user who marks ~/foo/ as excluded and then later marks ~foo/bar/ 
as included, but that would be material for another patch I think.
  
  This is actually already how this works, the excludes and includes are both 
resolved into either an index path or do not index path outcome.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15583

To: ngraham, #baloo, #dolphin, bruns, #frameworks
Cc: smithjd, anthonyfieroni, kde-frameworks-devel, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams


D15635: Use String to store UDS_USER and UDS_GROUP of String type.

2018-09-24 Thread Nathaniel Graham
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Code looks better and I can verify that it fixes the bug. Feels a bit faster, 
too. Maybe wait for a final review from @broulik or someone in #frameworks 
 though before landing.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15635

To: jtamate, dfaure, #baloo, #frameworks, ngraham
Cc: ngraham, broulik, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, bruns, abrahams


D15718: Do not index the path if the path has no execute permissions.

2018-09-24 Thread Luigi Toscano
ltoscano requested changes to this revision.
ltoscano added a comment.


  I agree with all the objections raised so far, and I'm not sure about the 
rationale of this change. I'd like to add one point:
  
  In D15718#330844 , @smithjd wrote:
  
  > In D15718#330836 , @ngraham 
wrote:
  >
  > > Wouldn't this have the effect of un-indexing most files? A quick check of 
my documents (text, word processing, excel, etc) reveals that none of them have 
the execute bit set. As-is, I think this would render Baloo mostly useless.
  >
  >
  > A default mask of 0002 or more permissive looks fairly common across 
distros, and is permissive enough to index files by default.
  
  
  No, because even if the default umask is 002, or 022, POSIX says that the 
default permissions of a file on creation are going to be 0666, not 0777:
  
  
http://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap01.html#tag_17_01_01_04
  
  So not only file downloaded by browsers won't have the executable bit, but 
*every* file on the system. Let's leave the executable bit on files to scripts 
and other real programs.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15718

To: smithjd, ngraham, #baloo, ltoscano
Cc: ltoscano, marten, bruns, ngraham, kde-frameworks-devel, #baloo, 
ashaposhnikov, michaelh, astippich, spoorun, abrahams


D15718: Do not index the path if the path has no execute permissions.

2018-09-24 Thread Nathaniel Graham
ngraham added a comment.


  The point is, we don't make changes to our software that break users, and 
then demand that users alter their own files to keep using the software. It's 
not an option--especially if the breakage results in the software basically not 
working at all (i.e. search no longer works because nothing is being indexed 
anymore) or the fix is very invasive (i.e. you need to recursively change the 
permissions on all of your files, probably using terminal commands).
  
  Sorry, no.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15718

To: smithjd, ngraham, #baloo
Cc: marten, bruns, ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, 
michaelh, astippich, spoorun, abrahams


D15714: add a string suffix to test data and use for unicode testing of taglibwriter

2018-09-24 Thread Alexander Stippich
astippich added inline comments.

INLINE COMMENTS

> smithjd wrote in taglibwritertest.cpp:60
> Is wrapping in a QString necessary?

It does not compile otherwise.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D15714

To: astippich, mgallien, bruns
Cc: smithjd, svuorela, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams


D15714: add a string suffix to test data and use for unicode testing of taglibwriter

2018-09-24 Thread Alexander Stippich
astippich updated this revision to Diff 42270.
astippich added a comment.


  - actually use temporary string variable for unicode

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15714?vs=42264=42270

BRANCH
  taglib_write_unicode

REVISION DETAIL
  https://phabricator.kde.org/D15714

AFFECTED FILES
  autotests/taglibwritertest.cpp

To: astippich, mgallien, bruns
Cc: smithjd, svuorela, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams


D15714: add a string suffix to test data and use for unicode testing of taglibwriter

2018-09-24 Thread Alexander Stippich
astippich updated this revision to Diff 42264.
astippich added a comment.


  - implement feedback

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15714?vs=42197=42264

BRANCH
  taglib_write_unicode

REVISION DETAIL
  https://phabricator.kde.org/D15714

AFFECTED FILES
  autotests/taglibwritertest.cpp

To: astippich, mgallien, bruns
Cc: smithjd, svuorela, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams


D15704: increase test coverage of taglibwriter

2018-09-24 Thread Alexander Stippich
astippich added inline comments.

INLINE COMMENTS

> svuorela wrote in taglibwriter.cpp:22
> Unrelated. but consider making this static ?

Never really though about that, but should be static, yes. None of the writers 
and extractors I looked at currently do this, so if I find time I will do that 
for all at once and separately

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D15704

To: astippich, mgallien, bruns
Cc: svuorela, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams


KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.9 - Build # 154 - Still Unstable!

2018-09-24 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.9/154/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 24 Sep 2018 16:17:53 +
 Build duration:
15 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.plasma-iconitemtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(9/18)45%
(57/126)45%
(57/126)39%
(5181/13178)29%
(2738/9444)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(13/14)93%
(13/14)96%
(1068/1117)51%
(552/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core44%
(7/16)44%
(7/16)33%
(749/2240)27%
(388/1442)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)49%
(1700/3505)39%
(1030/2633)src.plasma.packagestructure57%
(4/7)57%
(4/7)37%
(51/138)42%
(5/12)src.plasma.private63%
(12/19)63%
(12/19)61%
(946/1558)42%
(426/1003)src.plasma.scripting67%
(2/3)67%
(2/3)20%
(34/166)10%
(13/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)30%
(589/1975)19%
(319/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid17%
(1/6)17%
(1/6)1%
(13/1098)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%
(0/2)0%
(0/61)0%
(0/16)tests.testengine0%
  

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 229 - Still Unstable!

2018-09-24 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/229/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 24 Sep 2018 16:14:28 +
 Build duration:
6 min 30 sec and counting
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(44/126)35%
(44/126)27%
(3601/13118)19%
(1821/9446)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(607/1113)29%
(313/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2221)7%
(96/1444)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)41%
(1420/3491)30%
(794/2633)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/135)0%
(0/12)src.plasma.private47%
(9/19)47%
(9/19)43%
(665/1544)30%
(301/1003)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)29%
(579/1976)18%
(312/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1096)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%
  

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.9 - Build # 153 - Still Unstable!

2018-09-24 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.9/153/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 24 Sep 2018 15:59:38 +
 Build duration:
18 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.plasma-iconitemtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(9/18)45%
(57/126)45%
(57/126)39%
(5191/13179)29%
(2741/9444)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(13/14)93%
(13/14)96%
(1068/1117)51%
(552/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core44%
(7/16)44%
(7/16)33%
(749/2240)27%
(388/1442)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)49%
(1700/3505)39%
(1030/2633)src.plasma.packagestructure57%
(4/7)57%
(4/7)37%
(51/138)42%
(5/12)src.plasma.private63%
(12/19)63%
(12/19)61%
(956/1559)43%
(429/1003)src.plasma.scripting67%
(2/3)67%
(2/3)20%
(34/166)10%
(13/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)30%
(589/1975)19%
(319/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid17%
(1/6)17%
(1/6)1%
(13/1098)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%
(0/2)0%
(0/61)0%
(0/16)tests.testengine0%
  

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 228 - Still Unstable!

2018-09-24 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/228/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 24 Sep 2018 15:59:39 +
 Build duration:
7 min 51 sec and counting
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(44/126)35%
(44/126)27%
(3601/13118)19%
(1821/9446)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(607/1113)29%
(313/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2221)7%
(96/1444)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)41%
(1420/3491)30%
(794/2633)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/135)0%
(0/12)src.plasma.private47%
(9/19)47%
(9/19)43%
(665/1544)30%
(301/1003)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)29%
(579/1976)18%
(312/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1096)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%
  

D11880: Add firewall-config and firewall-applet icons

2018-09-24 Thread Noah Davis
ndavis updated this revision to Diff 42257.
ndavis added a comment.


  Remove 48px firewall-applet icon

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11880?vs=42212=42257

BRANCH
  firewalld-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11880

AFFECTED FILES
  icons-dark/apps/16/firewall-applet-error.svg
  icons-dark/apps/16/firewall-applet-panic.svg
  icons-dark/apps/16/firewall-applet.svg
  icons-dark/apps/22/firewall-applet-error.svg
  icons-dark/apps/22/firewall-applet-panic.svg
  icons-dark/apps/22/firewall-applet.svg
  icons-dark/apps/48/firewall-config.svg
  icons/apps/16/firewall-applet-error.svg
  icons/apps/16/firewall-applet-panic.svg
  icons/apps/16/firewall-applet.svg
  icons/apps/22/firewall-applet-error.svg
  icons/apps/22/firewall-applet-panic.svg
  icons/apps/22/firewall-applet.svg
  icons/apps/48/firewall-config.svg

To: ndavis, #vdg, #breeze, ngraham
Cc: bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, michaelh


D11880: Add firewall-config and firewall-applet icons

2018-09-24 Thread Noah Davis
ndavis added a comment.


  In D11880#330909 , @svenmauch 
wrote:
  
  > In D11880#330788 , @ngraham 
wrote:
  >
  > > I think that `firewall-applet` looks maybe a bit too plain at its 22px 
size. The wall seems to need something.
  >
  >
  > I think the 22px firewall-applet looks really good and would fit perfectly 
with the notifications popup and task icons. I'm not sure why the 48px version 
is colored though?
  
  
  It's just a symlink to the firewall-config icon. When I started this diff, 
firewall-applet showed up in searches for "firewall" in the application menus. 
That appears not to be the case anymore, so I will remove the 48px 
firewall-applet icon.
  
  > Thank you for the superb work @ndavis & @bruns!
  
  Thanks!

REPOSITORY
  R266 Breeze Icons

BRANCH
  firewalld-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, michaelh


D15721: Make lock on plasmavault icon visible with breeze-dark

2018-09-24 Thread Andres Betts
abetts added a comment.


  +1

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15721

To: ndavis, #vdg
Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns


D15687: [Device Notifier] Avoid accessing attributes of stale UDIs

2018-09-24 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes.
bruns marked an inline comment as done.
Closed by commit R120:61b2b173e8d6: [Device Notifier] Avoid accessing 
attributes of stale UDIs (authored by bruns).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15687?vs=42149=42244

REVISION DETAIL
  https://phabricator.kde.org/D15687

AFFECTED FILES
  applets/devicenotifier/package/contents/ui/FullRepresentation.qml
  applets/devicenotifier/package/contents/ui/devicenotifier.qml

To: bruns, #frameworks, broulik
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D15675: [sftp] Reformat sftpProtocol::GetRequest::GetRequest()

2018-09-24 Thread Andreas Schneider
asn updated this revision to Diff 42243.
asn added a comment.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.


  Remove former revision

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15675?vs=42084=42243

BRANCH
  arcpatch-D15675

REVISION DETAIL
  https://phabricator.kde.org/D15675

AFFECTED FILES
  sftp/kio_sftp.cpp

To: asn, sitter, ngraham, broulik
Cc: kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp


D15687: [Device Notifier] Avoid accessing attributes of stale UDIs

2018-09-24 Thread Kai Uwe Broulik
broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15687

To: bruns, #frameworks, broulik
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D14528: Android: Make sure we're looking for .mo files in the right path

2018-09-24 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes.
Closed by commit R249:65fe7009ae9e: Android: Make sure were looking for 
.mo files in the right path (authored by apol).

REPOSITORY
  R249 KI18n

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14528?vs=38987=42226

REVISION DETAIL
  https://phabricator.kde.org/D14528

AFFECTED FILES
  src/kcatalog.cpp

To: apol, #frameworks, ilic, ckertesz
Cc: aacid, ltoscano, kde-frameworks-devel, michaelh, ngraham, bruns


D14529: Android: Make sure Qm translations get loaded

2018-09-24 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes.
Closed by commit R240:0d961ecbdf17: Android: Make sure Qm translations get 
loaded (authored by apol).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14529?vs=38883=42225

REVISION DETAIL
  https://phabricator.kde.org/D14529

AFFECTED FILES
  modules/ECMQmLoader.cpp.in

To: apol, #frameworks, aacid
Cc: svuorela, aacid, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, 
bruns


D15685: Fix Android builds using cmake 3.12.1

2018-09-24 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes.
Closed by commit R240:20e619af331f: Fix Android builds using cmake 3.12.1 
(authored by apol).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15685?vs=42117=42224

REVISION DETAIL
  https://phabricator.kde.org/D15685

AFFECTED FILES
  toolchain/ECMAndroidDeployQt.cmake

To: apol, #frameworks, vkrause
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns


D15685: Fix Android builds using cmake 3.12.1

2018-09-24 Thread Volker Krause
vkrause accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  wop

REVISION DETAIL
  https://phabricator.kde.org/D15685

To: apol, #frameworks, vkrause
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns


D11880: Add firewall-config and firewall-applet icons

2018-09-24 Thread Sven Mauch
svenmauch added a comment.


  In D11880#330810 , @ndavis wrote:
  
  > While orange may mean "warning", it could mean any kind of warning. In this 
case, it's a warning that an extreme setting is being used, but there is a lock 
in the corner to show that it is at least safe.
  
  
  Exactly what I thought!
  
  In D11880#330865 , @ndavis wrote:
  
  > Like this? This is #4d4d4d (icon grey), the standard color for small breeze 
icons, not black.
  >  F6281673: Screenshot_20180924_000854.png 
F6281669: Screenshot_20180924_000627.png 

  
  
  Looks great! +1
  
  In D11880#330788 , @ngraham wrote:
  
  > I think that `firewall-applet` looks maybe a bit too plain at its 22px 
size. The wall seems to need something.
  
  
  I think the 22px firewall-applet looks really good and would fit perfectly 
with the notifications popup and task icons. I'm not sure why the 48px version 
is colored though?
  
  Thank you for the superb work @ndavis & @bruns!

REPOSITORY
  R266 Breeze Icons

BRANCH
  firewalld-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, michaelh