D15780: YAML: add literal & folded block styles

[Nibaldo González]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:c32cf6020931: YAML: add literal  folded block styles 
(authored by nibags).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15780?vs=42389=42456

REVISION DETAIL
  https://phabricator.kde.org/D15780

AFFECTED FILES
  autotests/folding/test.yaml.fold
  autotests/html/test.yaml.html
  autotests/input/test.yaml
  autotests/reference/test.yaml.ref
  data/syntax/yaml.xml

To: nibags, cullmann, dhaumann, #framework_syntax_highlighting, turbov
Cc: turbov, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D15780: YAML: add literal & folded block styles

[Nibaldo González]

nibags edited the summary of this revision.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  fix-literal-style-yaml

REVISION DETAIL
  https://phabricator.kde.org/D15780

To: nibags, cullmann, dhaumann, #framework_syntax_highlighting, turbov
Cc: turbov, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D15771: Logcat & SELinux: improvements for the new Solarized schemes

[Nibaldo González]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:5dbf2ec3fe1d: Logcat  SELinux: improvements for the 
new Solarized schemes (authored by nibags).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15771?vs=42369=42455

REVISION DETAIL
  https://phabricator.kde.org/D15771

AFFECTED FILES
  autotests/html/test.logcat.html
  data/syntax/logcat.xml
  data/syntax/selinux-fc.xml
  data/syntax/selinux.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D15773: AppArmor: fix crashes in open rules (in KF5.50) and improvements for the new Solarized schemes

[Nibaldo González]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:896d3bda6c1d: AppArmor: fix crashes in open rules (in 
KF5.50) and improvements for the new… (authored by nibags).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15773?vs=42371=42454

REVISION DETAIL
  https://phabricator.kde.org/D15773

AFFECTED FILES
  autotests/folding/usr.bin.apparmor-profile-test.fold
  autotests/html/usr.bin.apparmor-profile-test.html
  autotests/input/usr.bin.apparmor-profile-test
  autotests/reference/usr.bin.apparmor-profile-test.ref
  data/syntax/apparmor.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D15558: Remove misleading use of KDE_INSTALL_PYTHONBINDINGSDIR

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R244:288d6d3a9d18: Remove misleading use of 
KDE_INSTALL_PYTHONBINDINGSDIR (authored by bruns).

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15558?vs=41771=42453

REVISION DETAIL
  https://phabricator.kde.org/D15558

AFFECTED FILES
  src/lib/CMakeLists.txt

To: bruns, #frameworks, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.9 - Build # 57 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.9/57/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 28 Sep 2018 01:24:36 +
 Build duration:
4 min 29 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(69/81)85%
(69/81)75%
(6331/8428)43%
(10156/23441)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2700/2776)49%
(5801/11903)src.desktoptojson100%
(2/2)100%
(2/2)78%
(88/113)38%
(122/322)src.lib50%
(1/2)50%
(1/2)62%
(352/572)26%
(243/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/782)18%
(184/1038)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1049/2827)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(654/770)42%
(975/2315)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)48%
(374/784)45%
(863/1927)src.lib.util100%
(10/10)100%
(10/10)81%
(728/904)52%
(823/1573)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 113 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/113/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 28 Sep 2018 01:24:36 +
 Build duration:
4 min 10 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittestFailed: TestSuite.kdirwatch_stat_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(69/81)85%
(69/81)75%
(6332/8428)43%
(10166/23445)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2702/2776)49%
(5810/11901)src.desktoptojson100%
(2/2)100%
(2/2)78%
(88/113)38%
(123/326)src.lib50%
(1/2)50%
(1/2)61%
(351/572)26%
(243/928)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/782)18%
(184/1038)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1047/2821)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(654/770)42%
(975/2317)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)48%
(374/784)45%
(864/1927)src.lib.util100%
(10/10)100%
(10/10)81%
(728/904)52%
(824/1575)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

D15558: Remove misleading use of KDE_INSTALL_PYTHONBINDINGSDIR

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15558

To: bruns, #frameworks, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D15558: Remove misleading use of KDE_INSTALL_PYTHONBINDINGSDIR

[Stefan Brüns]

bruns added a comment.


  In D15558#333027 , @apol wrote:
  
  > So the problem is that nobody is defining KDE_INSTALL_PYTHONBINDINGSDIR 
right?
  >  Makes sense to me to remove this line then, if the default behaviour works 
for us (it seems so).
  
  
  Yes, `ecm_generate_python_binding` checks for None and uses a hardcoded 
fallback.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D15558

To: bruns, #frameworks
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D15558: Remove misleading use of KDE_INSTALL_PYTHONBINDINGSDIR

[Aleix Pol Gonzalez]

apol added a comment.


  So the problem is that nobody is defining KDE_INSTALL_PYTHONBINDINGSDIR right?
  Makes sense to me to remove this line then, if the default behaviour works 
for us (it seems so).

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D15558

To: bruns, #frameworks
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D15558: Remove misleading use of KDE_INSTALL_PYTHONBINDINGSDIR

[Stefan Brüns]

bruns added a comment.


  Ping!

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D15558

To: bruns, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15715: remove own implementation of QString to TString conversion for taglibwriter

[Stefan Brüns]

bruns requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D15715

To: astippich, mgallien, bruns, svuorela
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D15704: increase test coverage of taglibwriter

[Stefan Brüns]

bruns requested changes to this revision.
bruns added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> taglibwritertest.cpp:74
> +
> +QTest::addRow("mp3")
> +<< QStringLiteral("mp3")

Can you sort the tests alphabetically? It does not matter much, but IMHO it is 
nicer to have some rule for ordering, instead of arbitrary order.

> taglibwriter.cpp:23
>  QStringList types = {
>  QStringLiteral("audio/mpeg"),
>  QStringLiteral("audio/mpeg3"),

Can you also order these alphabetically based on the main mime type (aliases 
immediate after)?

> taglibwriter.cpp:33
> +QStringLiteral("audio/x-opus+ogg"),
> +QStringLiteral("audio/wav"),
> +QStringLiteral("audio/x-aiff"),

audio/wav and the next three are not backed by tests AFAICS, can you add these 
in a separate review, accompanied by tests files?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D15704

To: astippich, mgallien, bruns
Cc: svuorela, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D15277: [RFC] kio_mtp: Move MTP device handling from kioslave to kiod-module

[Andreas Krutzler]

akrutzler added inline comments.

INLINE COMMENTS

> dfaure wrote in mtpstorage.cpp:499
> DBus timeouts are actually configurable, if you need to block until the copy 
> is done, btw.

In my previous approach I increased the timeout to 10 minutes. This worked fine 
until I downloaded a file of about 10GB or so from my phone -> timeout. It's 
hard to find a proper timeout which is why I chose the async way. :)

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D15277

To: akrutzler, elvisangelaccio, ltoscano, hetzenecker, dfaure
Cc: kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp

D15277: [RFC] kio_mtp: Move MTP device handling from kioslave to kiod-module

[Andreas Krutzler]

akrutzler updated this revision to Diff 42450.
akrutzler marked 13 inline comments as done.
akrutzler added a comment.


  - Rebase
  - Remove unrelated changes
  - Remove Q_FUNC_INFO
  - Remove private static methods from header file
  - Use currentDateTimeUtc instead of currentDateTime
  - Generate D-Bus interface with qdbusxml2cpp

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15277?vs=41002=42450

BRANCH
  mtp_next

REVISION DETAIL
  https://phabricator.kde.org/D15277

AFFECTED FILES
  mtp/CMakeLists.txt
  mtp/devicecache.cpp
  mtp/devicecache.h
  mtp/filecache.cpp
  mtp/filecache.h
  mtp/kio_mtp.cpp
  mtp/kio_mtp.h
  mtp/kio_mtp_helpers.cpp
  mtp/kio_mtp_helpers.h
  mtp/kiod_module/CMakeLists.txt
  mtp/kiod_module/kmtpd.cpp
  mtp/kiod_module/kmtpd.h
  mtp/kiod_module/kmtpd.json
  mtp/kiod_module/mtpdevice.cpp
  mtp/kiod_module/mtpdevice.h
  mtp/kiod_module/mtpstorage.cpp
  mtp/kiod_module/mtpstorage.h
  mtp/shared/CMakeLists.txt
  mtp/shared/kmtpdeviceinterface.cpp
  mtp/shared/kmtpdeviceinterface.h
  mtp/shared/kmtpdinterface.cpp
  mtp/shared/kmtpdinterface.h
  mtp/shared/kmtpfile.cpp
  mtp/shared/kmtpfile.h
  mtp/shared/kmtpstorageinterface.cpp
  mtp/shared/kmtpstorageinterface.h
  mtp/shared/org.kde.kmtp.daemon.xml
  mtp/shared/org.kde.kmtp.device.xml
  mtp/shared/org.kde.kmtp.storage.xml

To: akrutzler, elvisangelaccio, ltoscano, hetzenecker, dfaure
Cc: kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp

D15715: remove own implementation of QString to TString conversion for taglibwriter

[Stefan Brüns]

bruns added a comment.


  Can you copy the summary verbatim from D15614 
, and just add a "See also D15614 
"?
  Otherwise, good to go.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D15715

To: astippich, mgallien, bruns, svuorela
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D15220: implement more basic tags for taglibwriter

[Stefan Brüns]

bruns accepted this revision.
bruns added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> astippich wrote in taglibwriter.cpp:67
> taglib only allows unsigned int for year and track, so I don't know how 
> that's possible with taglib.
> I added checks to ensure only values greater zero are written to it.

Sorry, erred on the track number, hidden track is "0".

REPOSITORY
  R286 KFileMetaData

BRANCH
  taglib_write

REVISION DETAIL
  https://phabricator.kde.org/D15220

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D15714: add a string suffix to test data and use for unicode testing of taglibwriter

[Stefan Brüns]

bruns requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D15714

To: astippich, mgallien, bruns
Cc: smithjd, svuorela, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D7038: [server] Respect input region of sub-surfaces on pointer surface focus

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  I've written you a unit test.
  
  I can either take over this or upload as a separate review that you can merge 
in.

INLINE COMMENTS

> zzag wrote in surface_interface.cpp:819
> So, it would be fine to return `true` in the following case:
> 
>   QRectF(QPoint(0, 0), QSize(10, 10)).contains(QPointF(10, 10));
> 
> ?

I would have said so.

But then it means sizeContains and inputContains behave differently as

QRegion(QRect(0,0,10,10)).contains(10,10);  returns false

which gives us some inconsistency.

> surface_interface.cpp:824
>  {
> -if (!isMapped()) {
> +return sizeContains(size, QRegion(), position) && 
> input.contains(position.toPoint());
> +}

This needs to be

&& (surface.inputIsInfinite() || input.contains(..))

which means either an extra arg in our function pointer or go back to the 
frankly simpler first revision. Writing N complex lines to save duplicating N 
simple lines doesn't make much sense to me, especially when they end up 
deviating.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D7038

To: romangg, #frameworks, graesslin, davidedmundson
Cc: davidedmundson, zzag, kde-frameworks-devel, graesslin, plasma-devel, 
ragreen, Pitel, schernikov, michaelh, ZrenBot, ngraham, bruns, alexeymin, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D15645: Add scheme selection menu with a "System" entry.

[Amish Naidu]

amhndu retitled this revision from "[WIP] Add scheme selection menu with a 
"System" entry." to "Add scheme selection menu with a "System" entry.".
amhndu edited the summary of this revision.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D15645

To: amhndu, #frameworks
Cc: ngraham, broulik, kde-frameworks-devel, michaelh, bruns

D15773: AppArmor: fix crashes in open rules (in KF5.50) and improvements for the new Solarized schemes

[Nibaldo González]

nibags added a comment.


  I attach two files. The "usr.bin.firefox" file causes the error on line 31 
and "usr.bin.apparmor-profile-test" on line 184.
  F6288872: usr.bin.firefox  F6288873: 
usr.bin.apparmor-profile-test 

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  fix-apparmor

REVISION DETAIL
  https://phabricator.kde.org/D15773

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D15806: [Fstab] Remove AIX support

[Stefan Brüns]

bruns created this revision.
bruns added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

TEST PLAN
  make

REPOSITORY
  R245 Solid

BRANCH
  os_cleanup

REVISION DETAIL
  https://phabricator.kde.org/D15806

AFFECTED FILES
  src/solid/devices/backends/fstab/fstabhandling.cpp

To: bruns, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15805: [Fstab] Remove Tru64 (__osf__) support

[Stefan Brüns]

bruns created this revision.
bruns added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

TEST PLAN
  make

REPOSITORY
  R245 Solid

BRANCH
  os_cleanup

REVISION DETAIL
  https://phabricator.kde.org/D15805

AFFECTED FILES
  src/solid/devices/backends/fstab/fstabhandling.cpp

To: bruns, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15773: AppArmor: fix crashes in open rules (in KF5.50) and improvements for the new Solarized schemes

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Ok,
  I would say: this should go in to workaround the current issue.
  
  If you have a file, that triggers the "freeze" with the old version, I would 
be happy to get it here as attachment afterwards to take a look at the issue.
  It might occur in other places, too.
  
  Thanks!

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  fix-apparmor

REVISION DETAIL
  https://phabricator.kde.org/D15773

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D15773: AppArmor: fix crashes in open rules (in KF5.50) and improvements for the new Solarized schemes

[Nibaldo González]

nibags added a comment.


  I did debug with gdb and valgrind, but the information is not relevant, since 
Kate freezes and I have to kill the process (I think I used the term "crash" 
incorrectly :S). 
  I have done some tests and the problem is in the use of `#pop!some_context` 
on the main context ("_profile"). 
  For example, formerly, when doing `#pop!some_context` on the main context, 
"some_context" was stacked on top of the main context, it did not replace it. 
Now, in KF5.50.0, the main context is removed from de "stack" and replaced by 
"some_context". In the AppArmor XML file I use `#pop#pop!some_context` in 
general to finish a rule and, in some cases, `#pop!some_context` is done in the 
main context, which produces the error in large files, since it is not a 
behavior that I envisioned.
  
  I do not know if I'm explaining myself well, but with this diff I solve the 
problem.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D15773

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D14472: Set Dialog flag for JobDialog

[Nathaniel Graham]

ngraham added reviewers: Frameworks, cfeck.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D14472

To: nicolasfella, apol, #frameworks, cfeck
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14472: Set Dialog flag for JobDialog

[Nicolas Fella]

nicolasfella added a comment.


  Ping?

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D14472

To: nicolasfella, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15800: Create and install solid.categories for kdebugsettings

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R245:c16e60d3ba1e: Create and install solid.categories for 
kdebugsettings (authored by bruns).

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15800?vs=42432=42434

REVISION DETAIL
  https://phabricator.kde.org/D15800

AFFECTED FILES
  CMakeLists.txt
  solid.categories

To: bruns, #frameworks, broulik
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15799: [Fstab] Add support for categorized logging

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R245:5c50fa7b7ddc: [Fstab] Add support for categorized logging 
(authored by bruns).

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15799?vs=42431=42433

REVISION DETAIL
  https://phabricator.kde.org/D15799

AFFECTED FILES
  src/solid/devices/backends/fstab/CMakeLists.txt

To: bruns, #frameworks, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15800: Create and install solid.categories for kdebugsettings

[Stefan Brüns]

bruns added a comment.


  In D15800#332850 , @broulik wrote:
  
  > Oh, I thought `kdebugsettings` was somehow magical.
  
  
  Unfortunately not ...
  Would be nice if we could at least autogenerate the *.categories file from 
the ecm_declare_logging_category invocations.

REPOSITORY
  R245 Solid

BRANCH
  fstab_support_non_networkshares

REVISION DETAIL
  https://phabricator.kde.org/D15800

To: bruns, #frameworks, broulik
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15800: Create and install solid.categories for kdebugsettings

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  Oh, I thought `kdebugsettings` was somehow magical.

REPOSITORY
  R245 Solid

BRANCH
  fstab_support_non_networkshares

REVISION DETAIL
  https://phabricator.kde.org/D15800

To: bruns, #frameworks, broulik
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15800: Create and install solid.categories for kdebugsettings

[Stefan Brüns]

bruns created this revision.
bruns added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

TEST PLAN
  install solid.categories into config directory
  start kdebugsettings

REPOSITORY
  R245 Solid

BRANCH
  fstab_support_non_networkshares

REVISION DETAIL
  https://phabricator.kde.org/D15800

AFFECTED FILES
  CMakeLists.txt
  solid.categories

To: bruns, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15799: [Fstab] Add support for categorized logging

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D15799

To: bruns, #frameworks, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15799: [Fstab] Add support for categorized logging

[Stefan Brüns]

bruns created this revision.
bruns added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Add infrastructure to use categorized logging in the fstab backend

TEST PLAN
  make

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D15799

AFFECTED FILES
  src/solid/devices/backends/fstab/CMakeLists.txt

To: bruns, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15778: Log wallet open failure errors

[Arjun AK]

arjun removed a reviewer: mlaurent.
arjun marked an inline comment as done.

REVISION DETAIL
  https://phabricator.kde.org/D15778

To: arjun
Cc: mlaurent, kde-frameworks-devel, michaelh, ngraham, bruns

D15778: Log wallet open failure errors

[Arjun AK]

arjun added a reviewer: mlaurent.

REVISION DETAIL
  https://phabricator.kde.org/D15778

To: arjun, mlaurent
Cc: mlaurent, kde-frameworks-devel, michaelh, ngraham, bruns

D15778: Log wallet open failure errors

[Arjun AK]

arjun updated this revision to Diff 42430.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15778?vs=42381=42430

REVISION DETAIL
  https://phabricator.kde.org/D15778

AFFECTED FILES
  src/runtime/kwalletd/kwalletd.cpp

To: arjun, mlaurent
Cc: mlaurent, kde-frameworks-devel, michaelh, ngraham, bruns

D15798: [Fstab] Show non-empty share name in case root fs is exported

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
bruns marked an inline comment as done.
Closed by commit R245:419a551baa3e: [Fstab] Show non-empty share name in case 
root fs is exported (authored by bruns).

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15798?vs=42427=42429

REVISION DETAIL
  https://phabricator.kde.org/D15798

AFFECTED FILES
  src/solid/devices/backends/fstab/fstabdevice.cpp

To: bruns, #frameworks, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15798: [Fstab] Show non-empty share name in case root fs is exported

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  Alright, ship it

REPOSITORY
  R245 Solid

BRANCH
  ensure_nonempty_nfs_exportname

REVISION DETAIL
  https://phabricator.kde.org/D15798

To: bruns, #frameworks, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15798: [Fstab] Show non-empty share name in case root fs is exported

[Stefan Brüns]

bruns marked an inline comment as done.
bruns added inline comments.

INLINE COMMENTS

> broulik wrote in fstabdevice.cpp:45
> This should probably be moved outside this if, you get the same bug when you 
> do ``//server/`

SMB/Cifs share names can never be empty, i.e. you always have 
`//server/`

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D15798

To: bruns, #frameworks, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15795: Fix warnings about deprecated install dirs

[Dino H.]

dinoh added inline comments.

INLINE COMMENTS

> ltoscano wrote in KDEInstallDirs.cmake:564
> I'm going to comment only on this, but the others (most, if not all) are the 
> same. If you check the definition of _define_relative, this parameter is:
> 
> oldstylename (optional): the old-style name of the variable
> ===
> 
> So this command is exactly defining the old variable in addition to the new 
> one.
> We can't remove the definition of the old variables until they are in use, 
> and for sure not during the lifetime of Frameworks 5.x.
> 
> Unless of course I misunderstood the code...

Hmm, you're right, but then it shouldn't come up with a warning...?

In the _define_relative macro we have:

  if(KDE_INSTALL_${varname})
  ...
  elseif(${_oldstylename})
  if(NOT CMAKE_VERSION VERSION_LESS 3.0.0)
  message(DEPRECATION "${_oldstylename} is deprecated, use 
KDE_INSTALL_${varname} instead.")

In my case the message was triggered for all definitions.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D15795

To: dinoh, apol, bruns, dfaure
Cc: ltoscano, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D15798: [Fstab] Show non-empty share name in case root fs is exported

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> fstabdevice.cpp:45
>  m_product = m_device.mid(m_device.indexOf(":/") + 2);
> +if (m_product.isEmpty()) {
> +m_product = QStringLiteral("/");

This should probably be moved outside this if, you get the same bug when you do 
``//server/`

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D15798

To: bruns, #frameworks, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15798: [Fstab] Show non-empty share name in case root fs is exported

[Stefan Brüns]

bruns edited the summary of this revision.
bruns added a reviewer: broulik.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D15798

To: bruns, #frameworks, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15798: [Fstab] Show non-empty share name in case root fs is exported

[Stefan Brüns]

bruns created this revision.
bruns added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The leading slash is stripped to save some space for the human readable
  description ("share on server"). In case of an exported root filesystem,
  this creates an empty export name, so readd the slash.

TEST PLAN
  Create two entries in fstab:
  `server:/  /mnt/a/ nfs defaults 0 0`
  `server:/b /mnt/b/ nfs defaults 0 0`
  run e.g. solid-hardware5 list details
  result
  ` description = '/ on server'`
  ` description = 'b on server'`

REPOSITORY
  R245 Solid

BRANCH
  ensure_nonempty_nfs_exportname

REVISION DETAIL
  https://phabricator.kde.org/D15798

AFFECTED FILES
  src/solid/devices/backends/fstab/fstabdevice.cpp

To: bruns, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15644: Provide option to hide menu bar for Ksysguard

[Nathaniel Graham]

ngraham added a comment.


  Awesome job, @lsartorelli. For your next trick, would you like to create 
`KStandardAction::showMenubarWithWarning` (or something like that)? This would 
essentially duplicate the code you've written here, but it would be in a new 
central location so we could ensure consistency between apps, and make changes 
in only one place rather than //n// places. Then we could start to port 
KSysGuard, Kate, Gwenview to use it--and also adopt it for some of the 
remaining apps that don't currently show a warning, like Konsole.
  
  The relevant code is in 
https://cgit.kde.org/kconfigwidgets.git/tree/src/kstandardaction.cpp#n619. 
Wanna have a go at it?

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D15644

To: lsartorelli, ngraham, #plasma, #frameworks, sitter
Cc: broulik, sitter, acrouthamel, ngraham, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15795: Fix warnings about deprecated install dirs

[Luigi Toscano]

ltoscano added inline comments.

INLINE COMMENTS

> KDEInstallDirs.cmake:564
>  "documentation bundles generated using kdoctools"
> -HTML_INSTALL_DIR)
> +KDE_INSTALL_DOCBUNDLEDIR)
>  _define_relative(KCFGDIR DATAROOTDIR "config.kcfg"

I'm going to comment only on this, but the others (most, if not all) are the 
same. If you check the definition of _define_relative, this parameter is:

oldstylename (optional): the old-style name of the variable
===

So this command is exactly defining the old variable in addition to the new one.
We can't remove the definition of the old variables until they are in use, and 
for sure not during the lifetime of Frameworks 5.x.

Unless of course I misunderstood the code...

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D15795

To: dinoh, apol, bruns, dfaure
Cc: ltoscano, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D15795: Fix warnings about deprecated install dirs

[Dino H.]

dinoh added reviewers: apol, bruns, dfaure.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D15795

To: dinoh, apol, bruns, dfaure
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D15795: Fix warnings about deprecated install dirs

[Dino H.]

dinoh created this revision.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
dinoh requested review of this revision.

REVISION SUMMARY
  KDEInstallDirs.cmake used the deprecated format for install dirs internally 
and thus caused a bunch of warnings, which are fixed by this patch.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D15795

AFFECTED FILES
  kde-modules/KDEInstallDirs.cmake

To: dinoh
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.9 - Build # 155 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.9/155/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Thu, 27 Sep 2018 11:21:18 +
 Build duration:
15 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.plasma-iconitemtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(9/18)45%
(57/126)45%
(57/126)39%
(5191/13181)29%
(2741/9444)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(13/14)93%
(13/14)96%
(1068/1117)51%
(552/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core44%
(7/16)44%
(7/16)33%
(749/2240)27%
(388/1442)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)49%
(1700/3505)39%
(1030/2633)src.plasma.packagestructure57%
(4/7)57%
(4/7)37%
(51/138)42%
(5/12)src.plasma.private63%
(12/19)63%
(12/19)61%
(956/1559)43%
(429/1003)src.plasma.scripting67%
(2/3)67%
(2/3)20%
(34/166)10%
(13/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)30%
(589/1977)19%
(319/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid17%
(1/6)17%
(1/6)1%
(13/1098)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%
(0/2)0%
(0/61)0%
(0/16)tests.testengine0%
  

D15705: Also raise configuration window when reusing it

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:ea6cf10f4250: Also raise configuration window when 
reusing it (authored by broulik).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15705?vs=42176=42419

REVISION DETAIL
  https://phabricator.kde.org/D15705

AFFECTED FILES
  src/plasmaquick/containmentview.cpp
  src/plasmaquick/view.cpp

To: broulik, #plasma, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 230 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/230/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 27 Sep 2018 11:21:18 +
 Build duration:
2 min 28 sec and counting
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(44/126)35%
(44/126)27%
(3601/13120)19%
(1821/9446)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(607/1113)29%
(313/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2221)7%
(96/1444)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)41%
(1420/3491)30%
(794/2633)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/135)0%
(0/12)src.plasma.private47%
(9/19)47%
(9/19)43%
(665/1544)30%
(301/1003)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)29%
(579/1978)18%
(312/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1096)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%
  

D15705: Also raise configuration window when reusing it

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15705

To: broulik, #plasma, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15644: Provide option to hide menu bar for Ksysguard

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R106:3a3220d41ac4: Provide option to hide menu bar for 
Ksysguard (authored by lsartorelli, committed by sitter).

REPOSITORY
  R106 KSysguard

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15644?vs=42368=42414

REVISION DETAIL
  https://phabricator.kde.org/D15644

AFFECTED FILES
  gui/ksysguard.cpp
  gui/ksysguard.h

To: lsartorelli, ngraham, #plasma, #frameworks, sitter
Cc: broulik, sitter, acrouthamel, ngraham, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15644: Provide option to hide menu bar for Ksysguard

[Harald Sitter]

sitter accepted this revision.
sitter added a comment.


  It's perfect now!

REVISION DETAIL
  https://phabricator.kde.org/D15644

To: lsartorelli, ngraham, #plasma, #frameworks, sitter
Cc: broulik, sitter, acrouthamel, ngraham, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15745: Implement Media and MediaEndpoint API

[David Rosca]

drosca added inline comments.

INLINE COMMENTS

> mweichselbaumer wrote in media_p.h:37
> MediaPrivate will later act as parent for child objects (inheriting QObject).

Then just parent them to Media instead of private class.

REVISION DETAIL
  https://phabricator.kde.org/D15745

To: mweichselbaumer, drosca
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns