D15821: fix pop up positioning for !compositing mode

[Michail Vourlakos]

mvourlakos added inline comments.

INLINE COMMENTS

> dialog.cpp:910
>  const bool outsideParentWindow = ((winInfo.windowType(NET::AllTypesMask) 
> == NET::Dock) || (item->window()->flags() & Qt::X11BypassWindowManagerHint))
> -&& item->window()->mask().isNull();
> +&& !flags().testFlag(Qt::ToolTip);
>  

This positions the plasma taskmanager previews a bit out of place because 
plasma panels are enforcing 2px margin at their edges.

What type of window do you believe should be an exception in order for the 
popup to be placed according to the item that triggered it?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15821

To: mvourlakos, #plasma, broulik, davidedmundson
Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D15821: fix pop up positioning for !compositing mode

[Michail Vourlakos]

mvourlakos updated this revision to Diff 42536.
mvourlakos added a comment.


  - dont use mask() to identify popups placement

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15821?vs=42510=42536

BRANCH
  maskPositioning

REVISION DETAIL
  https://phabricator.kde.org/D15821

AFFECTED FILES
  src/plasmaquick/dialog.cpp

To: mvourlakos, #plasma, broulik, davidedmundson
Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D15814: show all borders for pop up windows in a dock

[Michail Vourlakos]

mvourlakos added inline comments.

INLINE COMMENTS

> davidedmundson wrote in dialog.cpp:209
> How does parentWindow->mask relate to being a dock or not?
> 
> Also we need to be a bit careful on names.
> _NET_WM_WINDOW_TYPE_DOCK is all panels, including the standard plasma one.

The idea was first introduced at popupPlacement() in dialog.cpp. 
In order to distinguish docks from panels.

It is based on the assumption that by design plasma panels do not use mask() 
because their shadows are drawn external from the window and most of the docks 
(e.g. Plank,Latte) are using masking for almost all of their operations.

Do you believe there is a better way to distinguish between docks and panels ?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15814

To: mvourlakos, #plasma, broulik, davidedmundson
Cc: abetts, broulik, ngraham, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 55 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/55/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 29 Sep 2018 03:59:28 +
 Build duration:
4 min 33 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)83%
(5/6)83%
(5/6)34%
(102/299)20%
(36/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)74%
(42/57)56%
(10/18)autotests80%
(4/5)80%
(4/5)25%
(60/242)16%
(26/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 111 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/111/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 29 Sep 2018 03:59:28 +
 Build duration:
1 min 16 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)83%
(5/6)83%
(5/6)34%
(102/299)20%
(36/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)74%
(42/57)56%
(10/18)autotests80%
(4/5)80%
(4/5)25%
(60/242)16%
(26/164)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.9 - Build # 58 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.9/58/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 29 Sep 2018 01:54:43 +
 Build duration:
5 min 22 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(69/81)85%
(69/81)75%
(6331/8428)43%
(10156/23441)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2700/2776)49%
(5801/11903)src.desktoptojson100%
(2/2)100%
(2/2)78%
(88/113)38%
(122/322)src.lib50%
(1/2)50%
(1/2)62%
(352/572)26%
(243/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/782)18%
(184/1038)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1049/2827)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(654/770)42%
(975/2315)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)48%
(374/784)45%
(863/1927)src.lib.util100%
(10/10)100%
(10/10)81%
(728/904)52%
(823/1573)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 114 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/114/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 29 Sep 2018 01:54:43 +
 Build duration:
3 min 12 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittestFailed: TestSuite.kdirwatch_stat_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(69/81)85%
(69/81)75%
(6332/8428)43%
(10166/23445)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2702/2776)49%
(5810/11901)src.desktoptojson100%
(2/2)100%
(2/2)78%
(88/113)38%
(123/326)src.lib50%
(1/2)50%
(1/2)61%
(351/572)26%
(243/928)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/782)18%
(184/1038)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1047/2821)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(654/770)42%
(975/2317)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)48%
(374/784)45%
(864/1927)src.lib.util100%
(10/10)100%
(10/10)81%
(728/904)52%
(824/1575)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

D15643: Android: Allow passing a relative path as the apk dir

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R240:453ba4fee312: Android: Allow passing a relative path as 
the apk dir (authored by apol).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15643?vs=42483=42531

REVISION DETAIL
  https://phabricator.kde.org/D15643

AFFECTED FILES
  toolchain/Android.cmake

To: apol, #frameworks, #gcompris, jjazeix
Cc: jjazeix, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D15826: [Balooshow] Avoid out-of-bounds access when accessing corrupt db data

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, Frameworks.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Looping over `word` without bounds check may cause illegal memory accesses,
  potentially crashing balooshow. Add sanity checks for required lengths
  and provide feedback in case an error has occured.
  
  Invalid data may occur when the DB has beend corrupted.

TEST PLAN
  corrupt database
  run `balooshow -x `

REPOSITORY
  R293 Baloo

BRANCH
  db_robustness2

REVISION DETAIL
  https://phabricator.kde.org/D15826

AFFECTED FILES
  src/tools/balooshow/main.cpp

To: bruns, #baloo, #frameworks
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D15814: show all borders for pop up windows in a dock

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> dialog.cpp:209
> +QWindow *parentWindow = q->transientParent();
> +bool inDock = parentWindow && !parentWindow->mask().isNull() && 
> KWindowSystem::compositingActive();
> +

How does parentWindow->mask relate to being a dock or not?

Also we need to be a bit careful on names.
_NET_WM_WINDOW_TYPE_DOCK is all panels, including the standard plasma one.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15814

To: mvourlakos, #plasma, broulik, davidedmundson
Cc: abetts, broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D15714: add a string suffix to test data and use for unicode testing of taglibwriter

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> taglibwritertest.cpp:152
> +<< QStringLiteral("audio/opus")
> +<< QStringLiteral("€")
>  ;

^ unicodeTestStringSuffix ?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D15714

To: astippich, mgallien, bruns
Cc: smithjd, svuorela, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D15714: add a string suffix to test data and use for unicode testing of taglibwriter

[Stefan Brüns]

bruns added a comment.


  +1
  @svuorela ?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D15714

To: astippich, mgallien, bruns
Cc: smithjd, svuorela, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D15825: move testing of common tags of test files to a new data-driven test for taglibextractor

[Alexander Stippich]

astippich created this revision.
astippich added reviewers: bruns, svuorela.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  as a preparation for more test data, move all tags that
  are directly provided by taglib to a common test function

REPOSITORY
  R286 KFileMetaData

BRANCH
  refactor_taglib_extractor_tests

REVISION DETAIL
  https://phabricator.kde.org/D15825

AFFECTED FILES
  autotests/taglibextractortest.cpp
  autotests/taglibextractortest.h

To: astippich, bruns, svuorela
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D15714: add a string suffix to test data and use for unicode testing of taglibwriter

[Alexander Stippich]

astippich updated this revision to Diff 42525.
astippich added a comment.


  - use suggested test pattern

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15714?vs=42270=42525

BRANCH
  taglib_write_unicode

REVISION DETAIL
  https://phabricator.kde.org/D15714

AFFECTED FILES
  autotests/taglibwritertest.cpp

To: astippich, mgallien, bruns
Cc: smithjd, svuorela, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D15714: add a string suffix to test data and use for unicode testing of taglibwriter

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> astippich wrote in taglibwritertest.cpp:73
> Can this give failures on windows similar to D14122 
> ?

Yes, probably.
Although, this gives also a pointer to a different approach:

  // Add some unicode characters, use codepoints to avoid any issues with 
  // source encoding: "€µ"
  static const QChar data[4] = { 0x20ac, 0xb5 };
  QString unicodeTestStringSuffix(data, 2);

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D15714

To: astippich, mgallien, bruns
Cc: smithjd, svuorela, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D15715: remove own implementation of QString to TString conversion for taglibwriter

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:c413d83851c5: remove own implementation of QString to 
TString conversion for taglibwriter (authored by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15715?vs=42202=42523

REVISION DETAIL
  https://phabricator.kde.org/D15715

AFFECTED FILES
  src/writers/taglibwriter.cpp

To: astippich, mgallien, bruns, svuorela
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D15819: [Exe Thumbnailer] Workaround Qt bug in ico detection heuristic

[Christoph Feck]

cfeck accepted this revision.
cfeck added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> icoutils_common.cpp:85
> +// QTBUG-70812: for files with incorrect bits per pixel, 
> QImageReader::canRead() returns
> +// false but it can still correctly determin the imageCount() and read 
> the icon just fine.
> +if (reader.imageCount() == 0) {

determine

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D15819

To: broulik, ngraham, anthonyfieroni, cfeck
Cc: cfeck, kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp

D15704: increase test coverage of taglibwriter

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:ae3c38293421: increase test coverage of taglibwriter 
(authored by astippich).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D15704?vs=42519=42521#toc

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15704?vs=42519=42521

REVISION DETAIL
  https://phabricator.kde.org/D15704

AFFECTED FILES
  autotests/taglibwritertest.cpp
  autotests/taglibwritertest.h
  src/writers/taglibwriter.cpp

To: astippich, mgallien, bruns
Cc: svuorela, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D15714: add a string suffix to test data and use for unicode testing of taglibwriter

[Alexander Stippich]

astippich added inline comments.

INLINE COMMENTS

> bruns wrote in taglibwritertest.cpp:73
> If safeguarding against bad editors is really necessary, better do it here.
> Alternatively, you can use C++11 unicode string literals, e.g.
> `QString(u"€")`
> If you save that one as e.g. latin1 and try to compile it, gcc reports:
> 
>   error: converting to execution character set: Invalid or incomplete 
> multibyte or wide character
>QString a{u"�"};

Can this give failures on windows similar to D14122 
?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D15714

To: astippich, mgallien, bruns
Cc: smithjd, svuorela, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D15715: remove own implementation of QString to TString conversion for taglibwriter

[Alexander Stippich]

astippich edited the summary of this revision.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D15715

To: astippich, mgallien, bruns, svuorela
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D15715: remove own implementation of QString to TString conversion for taglibwriter

[Stefan Brüns]

bruns accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R286 KFileMetaData

BRANCH
  taglib_write_string

REVISION DETAIL
  https://phabricator.kde.org/D15715

To: astippich, mgallien, bruns, svuorela
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D15715: remove own implementation of QString to TString conversion for taglibwriter

[Alexander Stippich]

astippich added a comment.


  In D15715#333567 , @bruns wrote:
  
  > Thx! Can you also add some line breaks at ~80 chars? ;-)
  
  
  sure :)

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D15715

To: astippich, mgallien, bruns, svuorela
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D15704: increase test coverage of taglibwriter

[Stefan Brüns]

bruns accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R286 KFileMetaData

BRANCH
  taglib_write_mimetypes

REVISION DETAIL
  https://phabricator.kde.org/D15704

To: astippich, mgallien, bruns
Cc: svuorela, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D15715: remove own implementation of QString to TString conversion for taglibwriter

[Stefan Brüns]

bruns added a comment.


  Thx! Can you also add some line breaks at ~80 chars? ;-)

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D15715

To: astippich, mgallien, bruns, svuorela
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D15704: increase test coverage of taglibwriter

[Alexander Stippich]

astippich updated this revision to Diff 42519.
astippich added a comment.


  - remove untested mime types and sort

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15704?vs=42196=42519

BRANCH
  taglib_write_mimetypes

REVISION DETAIL
  https://phabricator.kde.org/D15704

AFFECTED FILES
  autotests/taglibwritertest.cpp
  autotests/taglibwritertest.h
  src/writers/taglibwriter.cpp

To: astippich, mgallien, bruns
Cc: svuorela, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D15715: remove own implementation of QString to TString conversion for taglibwriter

[Alexander Stippich]

astippich edited the summary of this revision.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D15715

To: astippich, mgallien, bruns, svuorela
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D15220: implement more basic tags for taglibwriter

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:0f16dd4d4cbf: implement more basic tags for taglibwriter 
(authored by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15220?vs=41856=42518

REVISION DETAIL
  https://phabricator.kde.org/D15220

AFFECTED FILES
  autotests/taglibwritertest.cpp
  src/writers/taglibwriter.cpp

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D15778: Log wallet open failure errors

[Stefan Brüns]

bruns added a comment.


  The preferred way is to use arc, i.e. `arc diff`, ..., `arc land`, which 
ensures phabricator tags (Reviewed:, Revision, ...) are added to the commit 
message.

INLINE COMMENTS

> kwalletd.cpp:685
> +const auto errorStr = 
> KWallet::Backend::openRCToString(rc);
> +qCWarning(KWALLETD_LOG) << "Failed to open 
> wallet " << wallet << errorStr;
>  kpd->setPrompt(i18n(

nitpick - `qCWarning(..)` add spaces between arguments by default, so there is 
a double space between "wallet" and 

REVISION DETAIL
  https://phabricator.kde.org/D15778

To: arjun, mlaurent
Cc: bruns, mlaurent, kde-frameworks-devel, michaelh, ngraham

D15821: fix pop up positioning for !compositing mode

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15821

To: mvourlakos, #plasma, broulik, davidedmundson
Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D15778: Log wallet open failure errors

[Arjun AK]

arjun added a comment.


  I don't see a merge button,  Am i supposed to push it via git?

REVISION DETAIL
  https://phabricator.kde.org/D15778

To: arjun, mlaurent
Cc: mlaurent, kde-frameworks-devel, michaelh, ngraham, bruns

D15353: Use _NET_WM_WINDOW_TYPE_COMBO instead of _NET_WM_WINDOW_TYPE_COMBOBOX

[Vlad Zagorodniy]

zzag added a comment.


  Ping.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D15353

To: zzag, #kwin
Cc: romangg, aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D15814: show all borders for pop up windows in a dock

[Nathaniel Graham]

ngraham added a comment.


  Ok, no problem!

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15814

To: mvourlakos, #plasma, broulik, davidedmundson
Cc: abetts, broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D15814: show all borders for pop up windows in a dock

[Michail Vourlakos]

mvourlakos added a comment.


  @ngraham @abetts I searched a bit the "downward-pointing triangle" case but I 
dont think it can be drawn based on the current plasma theme implementation. 
Plasma themes are svg(s) so the borders images can also have borders so it isnt 
just drawing a triangle based on the theme background color.
  
  I believe it would be better if the relevant discussion could be taken place 
at another place, in order to keep this review clean for feedback.
  
  This commit improves the situation for Latte a lot until something better is 
supported.
  The arrow case will also need full borders in order to be drawn correctly so 
this commit still has meaning.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15814

To: mvourlakos, #plasma, broulik, davidedmundson
Cc: abetts, broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D15821: fix pop up positioning for !compositing mode

[Michail Vourlakos]

mvourlakos added a reviewer: davidedmundson.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15821

To: mvourlakos, #plasma, broulik, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15814: show all borders for pop up windows in a dock

[Michail Vourlakos]

mvourlakos added reviewers: broulik, davidedmundson.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15814

To: mvourlakos, #plasma, broulik, davidedmundson
Cc: abetts, broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D15821: fix pop up positioning for !compositing mode

[Michail Vourlakos]

mvourlakos added a comment.


  F6292209: εικόνα.png 
  [BEFORE: popup placement in plasma panel in !compositing]
  
  F6292214: εικόνα.png 
  [AFTER: popup placement in plasma panel in !compositing]

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15821

To: mvourlakos, #plasma, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15821: fix pop up positioning for !compositing mode

[Michail Vourlakos]

mvourlakos created this revision.
mvourlakos added reviewers: Plasma, broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mvourlakos requested review of this revision.

REVISION SUMMARY
  --pop up positioning that was introduced in order to a dock
  pop up to not be placed far for the item triggering the pop up
  broke the plasma panel pop-ups placement in !compositing mode
  because plasma panels are also setting a mask in !compositing
  mode. This fix tries to fix the situation for plasma panels
  and also keep the functionality needed by docks.
  --The tooltips exception for !compositing mode is added because
  docks might also want to place their tooltips not according to
  window geometry or mask but according to their inner elements.

TEST PLAN
  test plasma panels in compositing and !compositing in order to
  confirm functionality
  test Latte dock in order to confirm that popups are still placed
  correctly
  test Latte dock tooltips in !compositing mode in order to confirm
  that can be placed inside the window or mask boundaries

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  maskPositioning

REVISION DETAIL
  https://phabricator.kde.org/D15821

AFFECTED FILES
  src/plasmaquick/dialog.cpp

To: mvourlakos, #plasma, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14162: Fix issue when reading path lists

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R237:5f340fc84d89:  Fix issue when reading path lists 
(authored by apol).

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14162?vs=42504=42506

REVISION DETAIL
  https://phabricator.kde.org/D14162

AFFECTED FILES
  autotests/kconfigtest.cpp
  src/core/kconfigini.cpp

To: apol, #frameworks, dfaure
Cc: dfaure, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D15643: Android: Allow passing a relative path as the apk dir

[Johnny Jazeix]

jjazeix accepted this revision.
jjazeix added a comment.
This revision is now accepted and ready to land.


  works fine, sorry for the doubt, I probably badly applied it last time.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  arcpatch-D15643

REVISION DETAIL
  https://phabricator.kde.org/D15643

To: apol, #frameworks, #gcompris, jjazeix
Cc: jjazeix, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D15818: [Exe Thumbnailer] Ignore depth > 32

[Anthony Fieroni]

anthonyfieroni accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D15818

To: broulik, anthonyfieroni
Cc: kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp

D14162: Fix issue when reading path lists

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R237 KConfig

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14162

To: apol, #frameworks, dfaure
Cc: dfaure, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D14162: Fix issue when reading path lists

[Aleix Pol Gonzalez]

apol retitled this revision from "Figure out the escaped path list on kconfig" 
to " Fix issue when reading path lists".
apol edited the summary of this revision.
apol edited the test plan for this revision.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D14162

To: apol, #frameworks, dfaure
Cc: dfaure, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D14162: Figure out the escaped path list on kconfig

[Aleix Pol Gonzalez]

apol updated this revision to Diff 42504.
apol added a comment.


  Removed optimisation

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14162?vs=39182=42504

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14162

AFFECTED FILES
  autotests/kconfigtest.cpp
  src/core/kconfigini.cpp

To: apol, #frameworks, dfaure
Cc: dfaure, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D5197: Make it possible to use the fetched translations

[Aleix Pol Gonzalez]

apol abandoned this revision.
Herald added a project: KDE Edu.
Herald added a subscriber: kde-edu.

REPOSITORY
  R325 KAlgebra

REVISION DETAIL
  https://phabricator.kde.org/D5197

To: apol, #frameworks
Cc: kde-edu, ltoscano, narvaez, apol

D15812: Don't crash if person gets removed

[Igor Poboiko]

poboiko closed this revision.

REPOSITORY
  R307 KPeople

REVISION DETAIL
  https://phabricator.kde.org/D15812

To: poboiko, #frameworks, dvratil, apol, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15819: [Exe Thumbnailer] Workaround Qt bug in ico detection heuristic

[Kai Uwe Broulik]

broulik edited the summary of this revision.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D15819

To: broulik, ngraham, anthonyfieroni
Cc: kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp

D15819: [Exe Thumbnailer] Workaround Qt bug in ico detection heuristic

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: ngraham, anthonyfieroni.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Ico files mostly contain PNGs these days which retain their image header when 
embedded into an ICO file, so the bits per pixel in the ICO header can be 
missing or incorrect. Qt still manages to extract the underlying PNG just file 
but the `canRead` gives up prematurely.

TEST PLAN
  I now get thumbnails for "sierra chart" exe file

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D15819

AFFECTED FILES
  thumbnail/icoutils_common.cpp

To: broulik, ngraham, anthonyfieroni
Cc: kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp

D15818: [Exe Thumbnailer] Ignore depth > 32

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: anthonyfieroni.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  The depth information is read unaltered from the `ico` file and might be 
bogus. `QImage::depth()` claims that 32 is the largest supported value, so cap 
here.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D15818

AFFECTED FILES
  thumbnail/icoutils_common.cpp

To: broulik, anthonyfieroni
Cc: kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp

D15814: show all borders for pop up windows in a dock

[Andres Betts]

abetts added a comment.


  In D15814#85 , @mvourlakos 
wrote:
  
  > In D15814#10 , @ngraham 
wrote:
  >
  > > A big improvement! Even better would be a little downward-pointing 
triangle pointing to the thing that spawned it. Here's a visual example from 
macOS with a vertical Dock: F6291932: macOS.png 

  >
  >
  > I am not sure.
  >  Latte is trying to be as much plasma as possible and a "downward-pointing 
triangle" isnt shown any where else in plasma.
  >  So that would make Latte to look a bit out of place in Plasma.
  >  I think for now a small improvement would be enough.
  
  
  Our HIGs don't prevent it. It is also a different element than a popup or 
sliding notification.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15814

To: mvourlakos, #plasma
Cc: abetts, broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D15814: show all borders for pop up windows in a dock

[Nathaniel Graham]

ngraham added a comment.


  A downward-pointing triangle doesn't make sense for pop-ups with a standard 
Plasma panel because pop-ups appear to slide out of panels, and they're always 
touching one another. So there is never a question about what the parent is. 
Latte has a different visual style and pop-ups are sort of floating in space, 
which is why I suggested the triangle.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15814

To: mvourlakos, #plasma
Cc: abetts, broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D15814: show all borders for pop up windows in a dock

[Michail Vourlakos]

mvourlakos added a comment.


  In D15814#10 , @ngraham wrote:
  
  > A big improvement! Even better would be a little downward-pointing triangle 
pointing to the thing that spawned it. Here's a visual example from macOS with 
a vertical Dock: F6291932: macOS.png 
  
  
  I am not sure.
  Latte is trying to be as much plasma as possible and a "downward-pointing 
triangle" isnt shown any where else in plasma.
  So that would make Latte to look a bit out of place in Plasma.
  I think for now a small improvement would be enough.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15814

To: mvourlakos, #plasma
Cc: abetts, broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D15812: Don't crash if person gets removed

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.


  Thanks!

REPOSITORY
  R307 KPeople

BRANCH
  person-remove (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15812

To: poboiko, #frameworks, dvratil, apol, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15814: show all borders for pop up windows in a dock

[Michail Vourlakos]

mvourlakos added a comment.


  In D15814#13 , @broulik wrote:
  
  > The idea is fine in principle but Plasma may also set a mask on its panels, 
noticeably in non-composited case for rounded corners, so when I disable 
compositing I get borders on all side for regular panel popups
  
  
  how about checking for KWindowSystem::compositingActive() ?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15814

To: mvourlakos, #plasma
Cc: abetts, broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D15814: show all borders for pop up windows in a dock

[Michail Vourlakos]

mvourlakos updated this revision to Diff 42489.
mvourlakos added a comment.


  - do not consider dock for !compositing

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15814?vs=42480=42489

BRANCH
  dockBorders

REVISION DETAIL
  https://phabricator.kde.org/D15814

AFFECTED FILES
  src/plasmaquick/dialog.cpp

To: mvourlakos, #plasma
Cc: abetts, broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D15812: Don't crash if person gets removed

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R307 KPeople

BRANCH
  person-remove (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15812

To: poboiko, #frameworks, dvratil, apol, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15814: show all borders for pop up windows in a dock

[Andres Betts]

abetts added a comment.


  I like both ideas so far. Great improvement! Would it be too hard to create 
the pointer triangle? I think it make so much sense. That way the poppup 
doesn't feel like it is floating out of nowhere.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15814

To: mvourlakos, #plasma
Cc: abetts, broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D15814: show all borders for pop up windows in a dock

[Kai Uwe Broulik]

broulik added a comment.


  The idea is fine in principle but Plasma may also set a mask on its panels, 
noticeably in non-composited case for rounded corners, so when I disable 
compositing I get borders on all side for regular panel popups

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15814

To: mvourlakos, #plasma
Cc: broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D15814: show all borders for pop up windows in a dock

[Nathaniel Graham]

ngraham added a comment.


  A big improvement! Even better would be a little downward-pointing triangle 
pointing to the thing that spawned it. Here's a visual example from macOS with 
a vertical Dock: F6291932: macOS.png 

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15814

To: mvourlakos, #plasma
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D15814: show all borders for pop up windows in a dock

[Michail Vourlakos]

mvourlakos added a comment.


  F6291922: εικόνα.png 
  (before)
  
  F6291928: εικόνα.png 
  (after)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15814

To: mvourlakos, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15643: Android: Allow passing a relative path as the apk dir

[Aleix Pol Gonzalez]

apol updated this revision to Diff 42483.
apol added a comment.


  Rebased

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15643?vs=42046=42483

BRANCH
  arcpatch-D15643

REVISION DETAIL
  https://phabricator.kde.org/D15643

AFFECTED FILES
  toolchain/Android.cmake

To: apol, #frameworks, #gcompris
Cc: jjazeix, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D15643: Android: Allow passing a relative path as the apk dir

[Aleix Pol Gonzalez]

apol added a comment.


  Are you sure you applied the patch properly? You are getting the warning that 
we are guarding against.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D15643

To: apol, #frameworks, #gcompris
Cc: jjazeix, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D15814: show all borders for pop up windows in a dock

[Michail Vourlakos]

mvourlakos created this revision.
mvourlakos added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mvourlakos requested review of this revision.

REVISION SUMMARY
  --it creates a much better and consistent visual effect
  when applets pop ups that are present in a dock draw
  all their borders.

TEST PLAN
  --use Latte dock in order to confirm the behavior
  --use traditional plasma panel in order to confirm
  that nothing broke

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  dockBorders

REVISION DETAIL
  https://phabricator.kde.org/D15814

AFFECTED FILES
  src/plasmaquick/dialog.cpp

To: mvourlakos, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15812: Don't crash if person gets removed

[Igor Poboiko]

poboiko created this revision.
poboiko added reviewers: Frameworks, dvratil, apol.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
poboiko requested review of this revision.

REVISION SUMMARY
  Currently, right after removing a person (which i.e. removes it from 
personIndex), we call personChanged.
  Which itself tries to access personIndex with recently removed key, which 
creates a default (invalid) value with such key.
  In the end we obtain inconsistent (invalid) index, which leads to crash.

TEST PLAN
  I've noted the bug when was working on T9595: [KAddressbook] Use KPeople 
model for contact list , see scratch repo 
 and "testab" 
application there.
  It's sufficient to check/uncheck address books several times to crash it.
  After applying this patch, it no longer crashes.

REPOSITORY
  R307 KPeople

BRANCH
  person-remove (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15812

AFFECTED FILES
  src/personsmodel.cpp

To: poboiko, #frameworks, dvratil, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15806: [Fstab] Remove AIX support

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R245:05b26d0b23d9: [Fstab] Remove AIX support (authored by 
bruns).

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15806?vs=42445=42471

REVISION DETAIL
  https://phabricator.kde.org/D15806

AFFECTED FILES
  src/solid/devices/backends/fstab/fstabhandling.cpp

To: bruns, #frameworks, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15805: [Fstab] Remove Tru64 (__osf__) support

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R245:6311a18d64ac: [Fstab] Remove Tru64 (__osf__) support 
(authored by bruns).

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15805?vs=42444=42470

REVISION DETAIL
  https://phabricator.kde.org/D15805

AFFECTED FILES
  src/solid/devices/backends/fstab/fstabhandling.cpp

To: bruns, #frameworks, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 232 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/232/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 28 Sep 2018 11:19:35 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(44/126)35%
(44/126)27%
(3601/13120)19%
(1821/9446)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(607/1113)29%
(313/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2221)7%
(96/1444)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)41%
(1420/3491)30%
(794/2633)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/135)0%
(0/12)src.plasma.private47%
(9/19)47%
(9/19)43%
(665/1544)30%
(301/1003)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)29%
(579/1978)18%
(312/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1096)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.9 - Build # 157 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.9/157/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 28 Sep 2018 11:18:35 +
 Build duration:
6 min 9 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.plasma-iconitemtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(9/18)45%
(57/126)45%
(57/126)39%
(5181/13180)29%
(2737/9444)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(13/14)93%
(13/14)96%
(1068/1117)51%
(552/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core44%
(7/16)44%
(7/16)33%
(749/2240)27%
(388/1442)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)49%
(1700/3505)39%
(1030/2633)src.plasma.packagestructure57%
(4/7)57%
(4/7)37%
(51/138)42%
(5/12)src.plasma.private63%
(12/19)63%
(12/19)61%
(946/1558)42%
(425/1003)src.plasma.scripting67%
(2/3)67%
(2/3)20%
(34/166)10%
(13/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)30%
(589/1977)19%
(319/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid17%
(1/6)17%
(1/6)1%
(13/1098)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%
(0/2)0%
(0/61)0%
(0/16)tests.testengine0%
 

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 231 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/231/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 28 Sep 2018 11:06:10 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(44/126)35%
(44/126)27%
(3601/13120)19%
(1820/9446)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(607/1113)29%
(313/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2221)7%
(96/1444)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)41%
(1420/3491)30%
(794/2633)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/135)0%
(0/12)src.plasma.private47%
(9/19)47%
(9/19)43%
(665/1544)30%
(300/1003)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)29%
(579/1978)18%
(312/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1096)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.9 - Build # 156 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.9/156/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 28 Sep 2018 11:06:10 +
 Build duration:
2 min 41 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.plasma-iconitemtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(9/18)45%
(57/126)45%
(57/126)39%
(5181/13180)29%
(2738/9444)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(13/14)93%
(13/14)96%
(1068/1117)51%
(552/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core44%
(7/16)44%
(7/16)33%
(749/2240)27%
(388/1442)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)49%
(1700/3505)39%
(1030/2633)src.plasma.packagestructure57%
(4/7)57%
(4/7)37%
(51/138)42%
(5/12)src.plasma.private63%
(12/19)63%
(12/19)61%
(946/1558)42%
(426/1003)src.plasma.scripting67%
(2/3)67%
(2/3)20%
(34/166)10%
(13/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)30%
(589/1977)19%
(319/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid17%
(1/6)17%
(1/6)1%
(13/1098)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%
(0/2)0%
(0/61)0%
(0/16)tests.testengine0%

Re: Re: KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 17 - Still Failing!

[Ben Cooksley]

On Wed, Sep 19, 2018 at 7:25 AM Ben Cooksley  wrote:
>
> On Wed, 19 Sep 2018, 02:50 David Faure,  wrote:
>>
>> Hmm So we need to kill it? 
>
>
> Except regular kill doesn't work. It's immune to that.
>
> Process Explorer (Sysinternals) and Task Manager (built in) can kill it 
> though, not sure how though.
>
> The solutions I can see in this case are:
> a) Don't do D-Bus on Windows (there are many arguments to say it doesn't 
> belong there at all)
>
> b) Disable KSSLD on Windows (we would want to use the system certificate 
> store anyway, so we don't need our own infrastructure)

Any updates on this?

On another note, if Qt knows this part of Windows is broken, why is it
even trying to spin down a thread when they know it's just going to
shoot themselves in the foot?

>
> Cheers,
> Ben
>
>>

Regards,
Ben

>> --  Forwarded Message  --
>>
>> Subject: Re: KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 
>> 17
>> - Still Failing!
>> Date: mardi 18 septembre 2018, 16:09:33 CEST
>> From: Thiago Macieira 
>> To: David Faure 
>>
>> On Tuesday, 18 September 2018 00:16:50 PDT you wrote:
>> > Hi Thiago,
>> >
>> > this looks like another issue with QtDBus using a separate thread, a
>> > deadlock on shutdown, on Windows. I remember seeing discussions about that
>> > in the past, I thought it was fixed? Maybe not in this particular case...
>>
>> It's not. Windows has a known design mistake in shutting down threads that
>> they can't fix. And so can't we.
>>
>> --
>> Thiago Macieira - thiago.macieira (AT) intel.com
>>   Software Architect - Intel Open Source Technology Center
>>
>> -
>> --
>> David Faure, fa...@kde.org, http://www.davidfaure.fr
>> Working on KDE Frameworks 5
>>
>>
>>

D15778: Log wallet open failure errors

[Laurent Montel]

mlaurent accepted this revision.
This revision is now accepted and ready to land.

REVISION DETAIL
  https://phabricator.kde.org/D15778

To: arjun, mlaurent
Cc: mlaurent, kde-frameworks-devel, michaelh, ngraham, bruns

D15805: [Fstab] Remove Tru64 (__osf__) support

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R245 Solid

BRANCH
  os_cleanup

REVISION DETAIL
  https://phabricator.kde.org/D15805

To: bruns, #frameworks, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15806: [Fstab] Remove AIX support

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R245 Solid

BRANCH
  os_cleanup

REVISION DETAIL
  https://phabricator.kde.org/D15806

To: bruns, #frameworks, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns