D15890: kimg_rgb: optimize away QRegExp and QString::fromLocal8Bit.

dfaure added inline comments. INLINE COMMENTS > cfeck wrote in rgb.cpp:702 > head[i] → head.at(i) This would make no difference, given that I made `head` const... REPOSITORY R287 KImageFormats BRANCH master REVISION DETAIL https://phabricator.kde.org/D15890 To: dfaure, cfeck Cc:

D15892: [Devicenotifications Engine] Keep at most one notification per UDI

bruns created this revision. bruns added a reviewer: Frameworks. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY Each notification was created as new datasource, and was newer removed as long as the engine

D15891: Fix monochrome icons missing stylesheets

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Some icons were lacking compatibility with system color schemes and that was fixed.

D15890: kimg_rgb: optimize away QRegExp and QString::fromLocal8Bit.

cfeck accepted this revision. cfeck added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > rgb.cpp:702 > > -const QRegExp regexp(QLatin1String("^\x01\xda\x01[\x01\x02]")); > -QString data(QString::fromLocal8Bit(head)); > - > -return

D15890: kimg_rgb: optimize away QRegExp and QString::fromLocal8Bit.

dfaure created this revision. dfaure added a reviewer: cfeck. Herald added a project: Frameworks. Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks. dfaure requested review of this revision. REVISION SUMMARY The code is even simpler this way. Found by using

D15070: Bindings: Support using sys paths for python install directory

bruns marked 9 inline comments as done. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D15070 To: bruns, #frameworks Cc: cgiboudeaux, bcooksley, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D15070: Bindings: Support using sys paths for python install directory

bruns updated this revision to Diff 42697. bruns marked 2 inline comments as done. bruns added a comment. Add documentation, remove leftover GPB_PYTHON${pyversion}_SITEARCH REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15070?vs=42631=42697

D15866: Reduce emblem size for very small icons to prevent obscuring too much of the icon

cfeck added a comment. I would prefer that. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D15866 To: ngraham, #frameworks, #dolphin, #vdg Cc: acrouthamel, cfeck, broulik, ndavis, kde-frameworks-devel, michaelh, ngraham, bruns

D15866: Reduce emblem size for very small icons to prevent obscuring too much of the icon

ngraham added a comment. It's possible to have tiny symbolic emblems that still convey information. Here's a screenshot from my Dropbox folder in Dolphin, with 16x16 icons plus the tiny little emblems that Dropbox adds: F6297941: 8 emblem on 16 icon.png

D15739: [Places panel] Don't show Root by default

davidedmundson resigned from this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15739 To: ngraham, #dolphin, #vdg Cc: ndavis, romangg, bruns, davidedmundson, abetts, svenmauch, broulik, acrouthamel, kde-frameworks-devel, michaelh, ngraham

D15739: [Places panel] Don't show Root by default

ngraham added a subscriber: ndavis. ngraham added a comment. In D15739#334513 , @romangg wrote: > Imo this patch can go in as it is, but before that I would like to see a patch to have the disk with the root file system getting specially marked

D15873: Improve debugging output by displaying whether the SMBSlave::del() function attempts to delete a file or a directory.

elvisangelaccio accepted this revision. elvisangelaccio added a comment. @madcatx Time to request commit access? :D REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D15873 To: madcatx, elvisangelaccio, broulik Cc: kde-frameworks-devel, kfm-devel, feverfew,

D15866: Reduce emblem size for very small icons to prevent obscuring too much of the icon

acrouthamel added a comment. What are the different possible emblems that can be applied automatically by the mount process? What if for small sizes, we just use simple shapes and colors. Like a green circle for mounted, and a yellow triangle for something else, and a red square for

D15866: Reduce emblem size for very small icons to prevent obscuring too much of the icon

ngraham added a comment. In D15866#335042 , @cfeck wrote: > The emblem conveys important information; it should be clearly visible. Scaling to size 6 or 12 would only make sense if our icon sets ship those sizes for emblem icons. I

D15866: Reduce emblem size for very small icons to prevent obscuring too much of the icon

cfeck added a comment. The emblem convers important information; it should be clearly visible. Scaling to size 6 or 12 would only make sense if our icon sets ship those sizes for emblem icons. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D15866 To: ngraham,

KDE CI: Frameworks » knewstuff » kf5-qt5 SUSEQt5.10 - Build # 115 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.10/115/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 01 Oct 2018 20:07:38 + Build duration: 6 min 19 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » knewstuff » kf5-qt5 SUSEQt5.9 - Build # 74 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.9/74/ Project: kf5-qt5 SUSEQt5.9 Date of build: Mon, 01 Oct 2018 20:07:38 + Build duration: 2 min 56 sec and counting JUnit Tests Name: (root)

D15843: Allow FileIndexerConfig to check device mounted status by path.

bruns added a comment. In D15843#335011 , @smithjd wrote: > In D15843#334518 , @ngraham wrote: > > > > > > This patch (or the other) is a requirement to augment the **current implementation**

D15866: Reduce emblem size for very small icons to prevent obscuring too much of the icon

ngraham added a comment. Hmm, that would only make sense for small icons. If we implement it for small icons but keep the overlay style for larger icons, then there will be an odd change if and when the size is increased, and the label will jump horizontally. Also, since this patch is for

D15843: Allow FileIndexerConfig to check device mounted status by path.

smithjd added a comment. In D15843#334518 , @ngraham wrote: > Perhaps we should discuss the implementation of multi-device indexing in a Phab ticket instead of across the comments of multiple patches. Then we can settle on an agreed-upon

D15277: [RFC] kio_mtp: Move MTP device handling from kioslave to kiod-module

akrutzler added inline comments. INLINE COMMENTS > mlaurent wrote in mtpstorage.cpp:176 > QString() directly no ? Of course, thanks! :) REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D15277 To: akrutzler, elvisangelaccio, ltoscano, hetzenecker, dfaure, mlaurent

D15277: [RFC] kio_mtp: Move MTP device handling from kioslave to kiod-module

akrutzler updated this revision to Diff 42685. akrutzler marked 5 inline comments as done. akrutzler added a comment. - Use QString() directly instead of QStringLiteral("") - Use explicit specifier - Call either finished or error in slave methods REPOSITORY R320 KIO Extras CHANGES

D15353: Use _NET_WM_WINDOW_TYPE_COMBO instead of _NET_WM_WINDOW_TYPE_COMBOBOX

romangg accepted this revision. This revision is now accepted and ready to land. REPOSITORY R278 KWindowSystem BRANCH use-combo-instead-of-combobox REVISION DETAIL https://phabricator.kde.org/D15353 To: zzag, #kwin, romangg Cc: romangg, aacid, kde-frameworks-devel, michaelh, ngraham,

D15353: Use _NET_WM_WINDOW_TYPE_COMBO instead of _NET_WM_WINDOW_TYPE_COMBOBOX

zzag added a comment. Ping. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D15353 To: zzag, #kwin Cc: romangg, aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D15866: Reduce emblem size for very small icons to prevent obscuring too much of the icon

ndavis added a comment. In D15866#334846 , @ngraham wrote: > You mean like this? > > [Icon] [emblem] Label > Yes, like that. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D15866 To: ngraham,

D15866: Reduce emblem size for very small icons to prevent obscuring too much of the icon

ngraham added a comment. In D15866#334519 , @ndavis wrote: > The emblem for the 16px version is too small to read. In D15866#334607 , @broulik wrote: > Did you test this with other

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 112 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/112/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 01 Oct 2018 14:25:02 + Build duration: 3 min 59 sec and counting JUnit Tests Name:

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 56 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/56/ Project: kf5-qt5 SUSEQt5.9 Date of build: Mon, 01 Oct 2018 14:25:02 + Build duration: 1 min 18 sec and counting JUnit Tests Name: (root)

D15853: Change drive-harddisk to more adaptable style

This revision was automatically updated to reflect the committed changes. Closed by commit R266:3f7ca1b59557: Change drive-harddisk to more adaptable style (authored by ndavis, committed by ngraham). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

D15853: Change drive-harddisk to more adaptable style

bruns added a comment. In D15853#334680 , @broulik wrote: > In D15853#334609 , @mart wrote: > > > What's that white blob on top of the hard disk? it looks really weird > > > Hard drives

D15070: Bindings: Support using sys paths for python install directory

bruns marked 2 inline comments as done. bruns added inline comments. INLINE COMMENTS > cgiboudeaux wrote in FindPythonModuleGeneration.cmake:39 > KDE_INSTALL_USE_PYTHON${version}_SYS_PATHS shall be added to the doc Yes, will do. > cgiboudeaux wrote in FindPythonModuleGeneration.cmake:206-207 >

KDE CI: Frameworks » knewstuff » kf5-qt5 SUSEQt5.10 - Build # 114 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.10/114/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 01 Oct 2018 11:49:52 + Build duration: 1 min 29 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » knewstuff » kf5-qt5 SUSEQt5.9 - Build # 73 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.9/73/ Project: kf5-qt5 SUSEQt5.9 Date of build: Mon, 01 Oct 2018 11:49:52 + Build duration: 1 min 28 sec and counting JUnit Tests Name: (root)

D6513: Add support for Attica tags support

This revision was automatically updated to reflect the committed changes. Closed by commit R304:158ba4e2420b: Add support for Attica tags support (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6513?vs=42360=42657 REVISION DETAIL

D15851: Fix signals not being emitted when merging two persons

poboiko closed this revision. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D15851 To: poboiko, #frameworks, dvratil Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15873: Improve debugging output by displaying whether the SMBSlave::del() function attempts to delete a file or a directory.

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D15873 To: madcatx, elvisangelaccio, broulik Cc: kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, navarromorales, firef,

D15853: Change drive-harddisk to more adaptable style

broulik added a comment. In D15853#334609 , @mart wrote: > What's that white blob on top of the hard disk? it looks really weird Hard drives typically have this swivel elevated section that this tries to simulate. For a lack of a

D15871: Add a specific error string for ENOTEMPTY return code in SMB slave.

broulik added a reviewer: sitter. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D15871 To: madcatx, elvisangelaccio, sitter Cc: kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp

D15873: Improve debugging output by displaying whether the SMBSlave::del() function attempts to delete a file or a directory.

madcatx created this revision. madcatx added a reviewer: elvisangelaccio. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. madcatx requested review of this revision. REVISION SUMMARY This has proven to be useful while I was tracking down

D15871: Add a specific error string for ENOTEMPTY return code in SMB slave.

madcatx created this revision. madcatx added a reviewer: elvisangelaccio. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. madcatx requested review of this revision. REVISION SUMMARY ENOEMPTY return code may be a valid return code from i.e.

D15872: Fix Oxygen background gradient for QML modules

hwti created this revision. hwti added reviewers: mart, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. hwti requested review of this revision. REVISION SUMMARY We need to make the QQuickWidget transparent, so we see the window background, which can be

KDE CI: Frameworks » purpose » kf5-qt5 WindowsMSVCQt5.11 - Build # 12 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20WindowsMSVCQt5.11/12/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Mon, 01 Oct 2018 08:32:08 + Build duration: 2 min 39 sec and counting JUnit Tests

D15853: Change drive-harddisk to more adaptable style

mart added a comment. What's that white blob on top of the hard disk? it looks really weird REPOSITORY R266 Breeze Icons BRANCH new-harddisk-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D15853 To: ndavis, #vdg, ngraham, pstefan Cc: mart, pstefan, ngraham,

D15866: Reduce emblem size for very small icons to prevent obscuring too much of the icon

broulik added a comment. Did you test this with other icon sets, such as Oxygen? It may work with SVG ones but not pixel-based iconsets. Oxygen only has 8x8 emblems. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D15866 To: ngraham, #frameworks, #dolphin, #vdg

D15851: Fix signals not being emitted when merging two persons

dvratil accepted this revision. This revision is now accepted and ready to land. REPOSITORY R307 KPeople BRANCH forgotten-signal (branched from master) REVISION DETAIL https://phabricator.kde.org/D15851 To: poboiko, #frameworks, dvratil Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15070: Bindings: Support using sys paths for python install directory

cgiboudeaux added inline comments. INLINE COMMENTS > FindPythonModuleGeneration.cmake:39 > # > > > #= KDE_INSTALL_USE_PYTHON${version}_SYS_PATHS shall be added to the doc > FindPythonModuleGeneration.cmake:206-207

D15818: [Exe Thumbnailer] Ignore depth > 32

This revision was automatically updated to reflect the committed changes. Closed by commit R320:5943efcfed8d: [Exe Thumbnailer] Ignore depth 32 (authored by broulik). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15818?vs=42492=42638 REVISION DETAIL

D15819: [Exe Thumbnailer] Workaround Qt bug in ico detection heuristic

This revision was automatically updated to reflect the committed changes. Closed by commit R320:f7be890d3acd: [Exe Thumbnailer] Workaround Qt bug in ico detection heuristic (authored by broulik). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE