D15935: Don't show an emblem for mounted disks, only unmounted disks

ngraham closed this revision. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D15935 To: ngraham, #vdg, abetts Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15935: Don't show an emblem for mounted disks, only unmounted disks

abetts accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid BRANCH no-mounted-emblem (branched from master) REVISION DETAIL https://phabricator.kde.org/D15935 To: ngraham, #vdg, abetts Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15939: Perform checks for unindexed files and stale index entries on startup

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Works great, thanks for all these Baloo patches! They are very much appreciated. Code looks good. As with the others, please commit for Frameworks 5.52. While you're cranking away

D8708: Introduce AbstractAnnotationItemDelegate for more control by consumer

dhaumann added a comment. If Christoph accepts, I am fine with this. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D8708 To: kossebau, #kate, #kdevelop Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, sars

D15944: [balooctl] Fix "index" command with already indexed, but moved file

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Verified that this fixes https://bugs.kde.org/show_bug.cgi?id=397242. Can you add the following to the summary section: BUG: 397242 FIXED-IN: 5.52 Also please commit after

D8708: Introduce AbstractAnnotationItemDelegate for more control by consumer

dhaumann added a comment. Hm, given the size of the patch, and given it introduces new public API we cannot easily change, I think a silent +1 since noone reacts is not good enough. That said, I will not have time for another review until Oct 14th - so I would appreciate another review

D15943: [balooctl] Monitor also for state changes

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Works for me and the code looks sane. Looks like this fixes https://bugs.kde.org/show_bug.cgi?id=364858, so can you add `BUG: 364858` and `FIXED-IN: 5.52` to the summary section and also

D15973: Add a 'Propreties' entry in the places panel context menu

thsurrel created this revision. thsurrel added reviewers: Frameworks, VDG, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. thsurrel requested review of this revision. REVISION SUMMARY Twin of D15929 for dolphin

D8708: Introduce AbstractAnnotationItemDelegate for more control by consumer

cullmann added a comment. As we have a usecase for this (the extension in KDevelop) I am ok if that goes in, if the extension in KDevelop is going in, too, as consumer. We can still fix minor issues in the KF6 iteration, they will never be found if it is not there and used. REPOSITORY

D15839: extend PlasmaCore.ColorScope for custom colors

mvourlakos edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15839 To: mvourlakos, #plasma, davidedmundson, mart Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15970: Properly look for fallback themes

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY At the moment we always look at the first fallback and load the original theme again,

D15968: kreadconfig: make the tool slightly more useful

apol updated this revision to Diff 42935. apol added a comment. Remove unneeded values REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15968?vs=42934=42935 BRANCH master REVISION DETAIL https://phabricator.kde.org/D15968 AFFECTED FILES

D15968: kreadconfig: make the tool slightly more useful

apol created this revision. apol added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Include --help Don't assume that globals are disabled because we're reading an existing

D15960: Don't check if file is directory based on mime-type

poboiko created this revision. poboiko added reviewers: Baloo, Frameworks. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. poboiko requested review of this revision. REVISION SUMMARY `QDirIterator` returns URLs for directories without trailing slash.

D15959: Wait for the extraction process to finish before scheduling

poboiko created this revision. poboiko added reviewers: Baloo, Frameworks. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. poboiko requested review of this revision. REVISION SUMMARY Right now, a race condition might happen. Signal

D15943: [balooctl] Monitor also for state changes

poboiko retitled this revision from "[balooctl] Monitor also for index changes" to "[balooctl] Monitor also for state changes". poboiko edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15943 To: poboiko, #frameworks, #baloo Cc: bruns,

D15932: [UDisks2] Power down drive on remove if supported

broulik accepted this revision. broulik added a comment. Please wait till after Frameworks tagging (due tomorrow) so we can have more test exposure as Solid changes are usually quite delicate REPOSITORY R245 Solid BRANCH udisks2_power_down REVISION DETAIL