KDE CI: Frameworks » knewstuff » kf5-qt5 SUSEQt5.10 - Build # 117 - Still Unstable!

2018-10-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.10/117/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 07 Oct 2018 04:02:41 + Build duration: 7 min 43 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » knewstuff » kf5-qt5 SUSEQt5.9 - Build # 76 - Still Unstable!

2018-10-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.9/76/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sun, 07 Oct 2018 04:02:40 + Build duration: 1 min 56 sec and counting JUnit Tests Name: (root)

D15996: Add calls to KIO::UDSEntry::reserve in timeline/tags ioslaves

2018-10-06 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes. Closed by commit R293:f517c4bc61a0: Add calls to KIO::UDSEntry::reserve in timeline/tags ioslaves (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15996?vs=42999=43001

D15995: [balooctl] Flush buffered "Indexing " line when indexing starts

2018-10-06 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes. Closed by commit R293:e4e519579656: [balooctl] Flush buffered Indexing file line when indexing starts (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D15985: [balooctl] Print current state & indexing file when monitor starts

2018-10-06 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. Fantastic! Works great. BRANCH monitor-initial-state (branched from master) REVISION DETAIL https://phabricator.kde.org/D15985 To: poboiko, #baloo, #frameworks, bruns, ngraham Cc: ngraham, bruns

D15996: Add calls to KIO::UDSEntry::reserve in timeline/tags ioslaves

2018-10-06 Thread Nathaniel Graham
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH add_udsentry_reserve REVISION DETAIL https://phabricator.kde.org/D15996 To: bruns, #baloo, #frameworks, poboiko, ngraham Cc: kde-frameworks-devel, ashaposhnikov, michaelh,

D15995: [balooctl] Flush buffered "Indexing " line when indexing starts

2018-10-06 Thread Nathaniel Graham
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH do_not_emit_finished_early REVISION DETAIL https://phabricator.kde.org/D15995 To: bruns, #baloo, poboiko, ngraham, #frameworks Cc: kde-frameworks-devel, ashaposhnikov, michaelh,

D15996: Add calls to KIO::UDSEntry::reserve in timeline/tags ioslaves

2018-10-06 Thread Stefan Brüns
bruns created this revision. bruns added reviewers: Baloo, Frameworks, poboiko, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Minor optimization TEST PLAN make REPOSITORY R293

D11828: Simplify orPostingIterator and make it faster

2018-10-06 Thread Stefan Brüns
bruns added a reviewer: poboiko. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11828 To: bruns, #baloo, #frameworks, poboiko Cc: fvogt, kde-frameworks-devel, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D15985: [balooctl] Print current state & indexing file when monitor starts

2018-10-06 Thread Stefan Brüns
bruns accepted this revision. bruns added a comment. This revision is now accepted and ready to land. Looks sane ... BRANCH monitor-initial-state (branched from master) REVISION DETAIL https://phabricator.kde.org/D15985 To: poboiko, #baloo, #frameworks, bruns Cc: bruns

D15993: [PositionCodec] Avoid crash in case of corrupt data

2018-10-06 Thread Stefan Brüns
bruns added a comment. In D15993#337880 , @ngraham wrote: > Congrats, you just fixed the most common Baloo crash. :) Thx - I am just selfish here ;-) REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15993 To:

Re: QtCreator-style block highlighting (and colours) in Kate(part)?

2018-10-06 Thread Dominik Haumann
Hi René, my take on this is rather simple: I don't directly see the value in this feature, so investing a significant amount of time is out of scope. I believe this is valid for other Kate developers as well, especially since we have more important issues to solve (finish port to

D15826: [Balooshow] Avoid out-of-bounds access when accessing corrupt db data

2018-10-06 Thread Stefan Brüns
bruns added a reviewer: poboiko. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15826 To: bruns, #baloo, #frameworks, poboiko Cc: anthonyfieroni, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D15994: [FileContentIndexer] Connect finished signal from extractor process

2018-10-06 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes. Closed by commit R293:197545f873a8: [FileContentIndexer] Connect finished signal from extractor process (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D15993: [PositionCodec] Avoid crash in case of corrupt data

2018-10-06 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes. Closed by commit R293:2d31a8500edb: [PositionCodec] Avoid crash in case of corrupt data (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15993?vs=42992=42995 REVISION

D15993: [PositionCodec] Avoid crash in case of corrupt data

2018-10-06 Thread Stefan Brüns
bruns added a comment. In D15993#337854 , @ngraham wrote: > Thanks! Any chance this will fix https://bugs.kde.org/show_bug.cgi?id=367480? Absolutely! REPOSITORY R293 Baloo BRANCH master REVISION DETAIL

D15993: [PositionCodec] Avoid crash in case of corrupt data

2018-10-06 Thread Nathaniel Graham
ngraham added a comment. Congrats, you just fixed the most common Baloo crash. :) REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D15993 To: bruns, #frameworks, poboiko, ngraham, #baloo Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh,

D15993: [PositionCodec] Avoid crash in case of corrupt data

2018-10-06 Thread Stefan Brüns
bruns edited the summary of this revision. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D15993 To: bruns, #frameworks, poboiko, ngraham, #baloo Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D15995: [balooctl] Flush buffered "Indexing " line when indexing starts

2018-10-06 Thread Stefan Brüns
bruns edited the summary of this revision. bruns edited the test plan for this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15995 To: bruns, #baloo, poboiko, ngraham Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

D15995: [balooctl] Flush buffered "Indexing " line when indexing starts

2018-10-06 Thread Stefan Brüns
bruns added a reviewer: Frameworks. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15995 To: bruns, #baloo, poboiko, ngraham, #frameworks Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D15994: [FileContentIndexer] Connect finished signal from extractor process

2018-10-06 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. > connect(, ::**started**IndexingFile, this, ::slot**Finished**IndexingFile); Lol whoops REPOSITORY R293 Baloo BRANCH do_not_emit_finished_early REVISION DETAIL

D15995: [balooctl] Flush buffered "Indexing " line when indexing starts

2018-10-06 Thread Stefan Brüns
bruns created this revision. bruns added reviewers: Baloo, poboiko, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Without the flush, the line is buffered until the endl from the

D15994: [FileContentIndexer] Connect finished signal from extractor process

2018-10-06 Thread Nathaniel Graham
ngraham added a reviewer: Baloo. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15994 To: bruns, #frameworks, poboiko, ngraham, #baloo Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D15993: [PositionCodec] Avoid crash in case of corrupt data

2018-10-06 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks! Any chance this will fix https://bugs.kde.org/show_bug.cgi?id=367480? REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D15993 To: bruns,

D15994: [FileContentIndexer] Connect finished signal from extractor process

2018-10-06 Thread Stefan Brüns
bruns created this revision. bruns added reviewers: Frameworks, poboiko, ngraham. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Only emit the "finished" signal to any watchers when the

D15993: [PositionCodec] Avoid crash in case of corrupt data

2018-10-06 Thread Nathaniel Graham
ngraham added a reviewer: Baloo. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15993 To: bruns, #frameworks, poboiko, ngraham, #baloo Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D15993: [PositionCodec] Avoid crash in case of corrupt data

2018-10-06 Thread Stefan Brüns
bruns created this revision. bruns added reviewers: Frameworks, poboiko, ngraham. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY getDifferentialVarInt* returns a nullptr in case of a

D15988: Add 'Mount' option to context menu of unmounted device in Places

2018-10-06 Thread Nathaniel Graham
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH arc_mount (branched from master) REVISION DETAIL https://phabricator.kde.org/D15988 To: thsurrel, #frameworks, #vdg, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15959: Wait for the extraction process to finish before scheduling

2018-10-06 Thread Stefan Brüns
bruns added a comment. I think the most trivial and completely correct way to fix this problem is to remove the `m_threadPool.activeThreadCount()` check from `scheduleIndexing()`. `QThreadPool::start(runnable)` puts the runnable in the run queue if there is still another thread running.

D15973: Add a 'Propreties' entry in the places panel context menu

2018-10-06 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added subscribers: anthonyfieroni, elvisangelaccio. ngraham added a comment. This revision is now accepted and ready to land. In your title: Propreties -> Properties Also, add `CCBUG: 181880` to your summary. That will result in the commit details

D15973: Add a 'Propreties' entry in the places panel context menu

2018-10-06 Thread Nathaniel Graham
This revision now requires review to proceed. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15973 To: thsurrel, #frameworks, #vdg, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15939: Perform checks for unindexed files and stale index entries on startup

2018-10-06 Thread Nathaniel Graham
ngraham added a comment. In D15939#337757 , @poboiko wrote: > I've found the relevant bug: https://bugs.kde.org/show_bug.cgi?id=333678 Hah, looks like you pushed a commit for it last year! I'm not wedded to symlink REPOSITORY R293

D15939: Perform checks for unindexed files and stale index entries on startup

2018-10-06 Thread Igor Poboiko
poboiko added a comment. I've found the relevant bug: https://bugs.kde.org/show_bug.cgi?id=333678 REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15939 To: poboiko, #baloo, #frameworks, vhanda, ngraham Cc: bruns, ngraham, kde-frameworks-devel, ashaposhnikov, michaelh,

D15973: Add a 'Propreties' entry in the places panel context menu

2018-10-06 Thread Thomas Surrel
thsurrel updated this revision to Diff 42984. thsurrel added a comment. Use isLocalFile REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15973?vs=42945=42984 BRANCH arc_properties (branched from master) REVISION DETAIL https://phabricator.kde.org/D15973

D15988: Add 'Mount' option to context menu of unmounted device in Places

2018-10-06 Thread Thomas Surrel
thsurrel created this revision. thsurrel added reviewers: Frameworks, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. thsurrel requested review of this revision. REVISION SUMMARY Twin of D15974 for dolphin

D15985: [balooctl] Print current state & indexing file when monitor starts

2018-10-06 Thread Igor Poboiko
poboiko created this revision. poboiko added reviewers: Baloo, Frameworks. poboiko requested review of this revision. REVISION SUMMARY This is based on D15943: [balooctl] Monitor also for state changes . Simply print current state & file when monitor

D15959: Wait for the extraction process to finish before scheduling

2018-10-06 Thread Igor Poboiko
poboiko added a comment. That doesn't looks like it works all the time: sometimes I still have this issue. Apparently, it still can happen that even when the process is finished, signal is emitted, but the thread is not finished yet. Also, it seems like due to `QueuedConnection`,

D15983: React to config updates inside indexer

2018-10-06 Thread Igor Poboiko
poboiko created this revision. poboiko added reviewers: Baloo, Frameworks. poboiko requested review of this revision. REVISION SUMMARY In case a config was changed, we need to: 1. Stop the ContentIndexer (bug 373430) 2. Remove all scheduled indexing of files that should not be indexed

D8708: Introduce AbstractAnnotationItemDelegate for more control by consumer

2018-10-06 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D8708#337408 , @dhaumann wrote: > Hm, given the size of the patch, and given it introduces new public API we cannot easily change, I think a silent +1 since noone reacts is not good enough. I agree that the

D15939: Perform checks for unindexed files and stale index entries on startup

2018-10-06 Thread Stefan Brüns
bruns added a comment. In D15939#337534 , @poboiko wrote: > As for symlinked folders - I once looked into, a year ago or so. As far as I remember, those can be really tricky (but I don't really remember all the details): > > - There might

D15939: Perform checks for unindexed files and stale index entries on startup

2018-10-06 Thread Igor Poboiko
poboiko added a comment. In D15939#337418 , @ngraham wrote: > Works great, thanks for all these Baloo patches! They are very much appreciated. Code looks good. As with the others, please commit for Frameworks 5.52. > > While you're cranking

D15943: [balooctl] Monitor also for state changes

2018-10-06 Thread Stefan Brüns
bruns added a comment. In D15943#337522 , @poboiko wrote: > In D15943#337385 , @ngraham wrote: > > > Works for me and the code looks sane. Looks like this fixes

D15859: allow non-local file:// redirect to a M$-WebDav URL

2018-10-06 Thread Martin Koller
mkoller added a comment. ping REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15859 To: mkoller, dfaure, #frameworks Cc: bruns, ngraham, kde-frameworks-devel, michaelh

D15943: [balooctl] Monitor also for state changes

2018-10-06 Thread Igor Poboiko
poboiko edited the summary of this revision. REPOSITORY R293 Baloo BRANCH monitor-state (branched from master) REVISION DETAIL https://phabricator.kde.org/D15943 To: poboiko, #frameworks, #baloo, ngraham Cc: ngraham, bruns, kde-frameworks-devel, ashaposhnikov, michaelh, astippich,

D15943: [balooctl] Monitor also for state changes

2018-10-06 Thread Igor Poboiko
poboiko added a comment. In D15943#337385 , @ngraham wrote: > Works for me and the code looks sane. Looks like this fixes https://bugs.kde.org/show_bug.cgi?id=364858, so can you add `BUG: 364858` and `FIXED-IN: 5.52` to the summary section and

D15944: [balooctl] Fix "index" command with already indexed, but moved file

2018-10-06 Thread Igor Poboiko
poboiko edited the summary of this revision. REPOSITORY R293 Baloo BRANCH fix-index-renamed (branched from master) REVISION DETAIL https://phabricator.kde.org/D15944 To: poboiko, #baloo, #frameworks, ngraham Cc: ngraham, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun,

Re: QtCreator-style block highlighting (and colours) in Kate(part)?

2018-10-06 Thread René J . V . Bertin
Dominik Haumann wrote: > No and no :) > But feel free to create/add a color scheme called Qt Creator. Not exactly the answer I was hoping for (though I kind of expected it ...) I *could* create a colour scheme if I had no other monk's tasks lying around (there are a *lot* of colours in the

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 58 - Still Unstable!

2018-10-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/58/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sat, 06 Oct 2018 08:48:24 + Build duration: 2 min 48 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 114 - Still Unstable!

2018-10-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/114/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 06 Oct 2018 08:48:24 + Build duration: 1 min 33 sec and counting JUnit Tests Name:

D11880: Add firewall-config and firewall-applet icons

2018-10-06 Thread David Faure
dfaure added a comment. This commit breaks the unittest "scalabletest" : FAIL! : ScalableTest::test_scalable(icons:Applications) The following icons are not available in a scalable directory: firewall-applet-panic firewall-applet firewall-applet-error