D16112: add wma files/asf tags as supported mimetype and add test data
This revision was automatically updated to reflect the committed changes. Closed by commit R286:d7c6fa57d243: add wma files/asf tags as supported mimetype and add test data (authored by astippich). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D16112?vs=43332=43371#toc REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16112?vs=43332=43371 REVISION DETAIL https://phabricator.kde.org/D16112 AFFECTED FILES autotests/samplefiles/test.wma autotests/taglibextractortest.cpp src/extractors/taglibextractor.cpp To: astippich, mgallien, bruns, svuorela Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
D16111: use own extractor for testing the taglibwriter
This revision was automatically updated to reflect the committed changes. Closed by commit R286:d472f470bacb: use own extractor for testing the taglibwriter (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16111?vs=43339=43370 REVISION DETAIL https://phabricator.kde.org/D16111 AFFECTED FILES autotests/taglibwritertest.cpp To: astippich, mgallien, bruns, svuorela Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.10 - Build # 117 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.10/117/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 11 Oct 2018 03:56:46 + Build duration: 9 min 29 sec and counting JUnit Tests Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s) Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report22% (5/23)26% (14/53)26% (14/53)19% (417/2155)18% (195/1106)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests100% (2/2)100% (2/2)97% (124/128)58% (57/98)src100% (8/8)100% (8/8)68% (212/312)50% (104/210)src.externalprocess0% (0/2)0% (0/2)0% (0/136)0% (0/96)src.fileitemactionplugin0% (0/1)0% (0/1)0% (0/17)0% (0/12)src.plugins.bluetooth0% (0/1)0% (0/1)0% (0/34)0% (0/14)src.plugins.email0% (0/1)0% (0/1)0% (0/55)0% (0/20)src.plugins.imgur0% (0/2)0% (0/2)0% (0/186)0% (0/69)src.plugins.kdeconnect0% (0/1)0% (0/1)0% (0/32)0% (0/12)src.plugins.ktp-sendfile0% (0/1)0% (0/1)0% (0/28)0% (0/12)src.plugins.nextcloud0% (0/3)0% (0/3)0% (0/79)0% (0/34)src.plugins.pastebin0% (0/1)0% (0/1)0% (0/54)0% (0/29)src.plugins.phabricator0% (0/3)0% (0/3)0% (0/222)0% (0/82)src.plugins.phabricator.quick0% (0/5)0% (0/5)0% (0/99)0% (0/62)src.plugins.phabricator.tests0% (0/1)0% (0/1)0% (0/60)0% (0/28)src.plugins.reviewboard0% (0/3)0% (0/3)0% (0/233)0% (0/76)src.plugins.reviewboard.quick0% (0/7)0% (0/7)0% (0/153)0% (0/92)src.plugins.saveas100% (1/1)100% (1/1)57% (29/51)64% (28/44)src.plugins.telegram0% (0/1)0% (0/1)0% (0/45)0%
D15939: Perform checks for unindexed files and stale index entries on startup
smithjd added a comment. https://phabricator.kde.org/D11529 was already up for review, implemented the index cleaner and checked for removeable volumes before removing index entries. Exporting the storagedevices object was required: https://phabricator.kde.org/D15047. The alternative, implementing a path lookup function is here: https://phabricator.kde.org/D15843. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15939 To: poboiko, #baloo, #frameworks, vhanda, ngraham Cc: smithjd, bruns, ngraham, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, abrahams
D13425: File indexer closing improvements.
smithjd updated this revision to Diff 43368. smithjd added a comment. Rebase. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13425?vs=43363=43368 BRANCH master-scheduler-haltonquit (branched from master) REVISION DETAIL https://phabricator.kde.org/D13425 AFFECTED FILES src/file/fileindexscheduler.cpp src/file/fileindexscheduler.h src/file/mainhub.cpp To: smithjd, bruns, mgallien, #baloo, poboiko Cc: ngraham, mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, michaelh, astippich, spoorun, abrahams
KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 431 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/431/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 10 Oct 2018 22:53:55 + Build duration: 22 min and counting JUnit Tests Name: (root) Failed: 0 test(s), Passed: 60 test(s), Skipped: 0 test(s), Total: 60 test(s) Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report64% (23/36)66% (261/397)66% (261/397)53% (31959/59978)38% (16479/43884)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests100% (56/56)100% (56/56)95% (9067/9506)48% (4264/8916)autotests.http100% (5/5)100% (5/5)99% (581/582)68% (113/166)autotests.kcookiejar100% (1/1)100% (1/1)91% (179/197)72% (49/68)src100% (1/1)100% (1/1)86% (6/7)67% (4/6)src.core86% (100/116)86% (100/116)58% (8282/14315)50% (4643/9259)src.core.kssl100% (1/1)100% (1/1)40% (35/88)50% (3/6)src.filewidgets76% (28/37)76% (28/37)49% (3898/7936)34% (1588/4687)src.gui100% (2/2)100% (2/2)94% (103/109)74% (49/66)src.ioslaves.file100% (5/5)100% (5/5)51% (525/1023)37% (315/850)src.ioslaves.file.kauth0% (0/2)0% (0/2)0% (0/106)0% (0/65)src.ioslaves.ftp0% (0/1)0% (0/1)0% (0/1364)0% (0/1414)src.ioslaves.help0% (0/5)0% (0/5)0% (0/245)0% (0/144)src.ioslaves.http88% (7/8)88% (7/8)41% (1769/4316)35% (1306/3684)src.ioslaves.http.kcookiejar33% (2/6)33% (2/6)47% (630/1331)55% (620/1123)src.ioslaves.remote100% (2/2)100% (2/2)28% (72/257)7% (14/212)src.ioslaves.remote.kdedmodule0% (0/2)0% (0/2)0% (0/12)100% (0/0)src.ioslaves.telnet0% (0/1)0% (0/1)0% (0/43)0% (0/30)src.ioslaves.trash56% (5/9)56% (5/9)52% (718/1372)43%
KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 276 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/276/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 10 Oct 2018 22:53:55 + Build duration: 9 min 27 sec and counting JUnit Tests Name: (root) Failed: 0 test(s), Passed: 60 test(s), Skipped: 0 test(s), Total: 60 test(s) Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report64% (23/36)66% (261/397)66% (261/397)53% (31994/59979)38% (16482/43884)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests100% (56/56)100% (56/56)95% (9067/9506)48% (4260/8916)autotests.http100% (5/5)100% (5/5)99% (581/582)68% (113/166)autotests.kcookiejar100% (1/1)100% (1/1)91% (179/197)72% (49/68)src100% (1/1)100% (1/1)86% (6/7)67% (4/6)src.core86% (100/116)86% (100/116)58% (8339/14317)50% (4661/9263)src.core.kssl100% (1/1)100% (1/1)40% (35/88)50% (3/6)src.filewidgets76% (28/37)76% (28/37)49% (3893/7935)34% (1588/4687)src.gui100% (2/2)100% (2/2)94% (103/109)74% (49/66)src.ioslaves.file100% (5/5)100% (5/5)51% (525/1023)37% (315/850)src.ioslaves.file.kauth0% (0/2)0% (0/2)0% (0/106)0% (0/65)src.ioslaves.ftp0% (0/1)0% (0/1)0% (0/1364)0% (0/1414)src.ioslaves.help0% (0/5)0% (0/5)0% (0/245)0% (0/144)src.ioslaves.http88% (7/8)88% (7/8)41% (1774/4316)35% (1304/3684)src.ioslaves.http.kcookiejar33% (2/6)33% (2/6)47% (629/1331)55% (619/1123)src.ioslaves.remote100% (2/2)100% (2/2)28% (72/257)7% (14/212)src.ioslaves.remote.kdedmodule0% (0/2)0% (0/2)0% (0/12)100% (0/0)src.ioslaves.telnet0% (0/1)0% (0/1)0% (0/43)0% (0/30)src.ioslaves.trash56% (5/9)56% (5/9)51% (697/1372)42%
D15983: React to config updates inside indexer
bruns added a comment.
Looks good in general, but have to think a little bit more about it ..
INLINE COMMENTS
> fileindexscheduler.cpp:125
>
> +// This should be above content indexing, because there can be files
> that should not be indexed in the DB
> +// (i.e. if config was changed)
Should read "This has to be above ...", also do the line break at ~ 80 chars
> fileindexscheduler.cpp:181
> +// Rescheduling content indexer
> +// (so we won't keep indexing files that should not be, bug 373430)
> +if (m_indexerState == ContentIndexing) {
"Interrupt content indexer, to avoid indexing files that should not be indexed,
bug 373430)"
> fileindexscheduler.cpp:189
> +removeShouldNotIndex(m_xattrFiles, m_config);
> +checkStaleIndexEntries();
> +checkUnindexedFiles();
replace these two lines by
m_checkStaleIndexEntries = true;
m_checkUnindexedFiles = true;
scheduleIndexing();
REVISION DETAIL
https://phabricator.kde.org/D15983
To: poboiko, #baloo, #frameworks
Cc: bruns
D14785: Fix DialogNativeTest in multi screen configuration
habacker added a comment. ping REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D14785 To: habacker, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D14787: Fix 'ThemeTest::testCompositingChange() fails if windows manager is running'
habacker added a comment. ping REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D14787 To: habacker, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13425: File indexer closing improvements.
bruns added a comment. The summary does in no way match the change. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13425 To: smithjd, bruns, mgallien, #baloo, poboiko Cc: ngraham, mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, michaelh, astippich, spoorun, abrahams
KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 430 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/430/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 10 Oct 2018 21:39:20 + Build duration: 21 min and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 59 test(s), Skipped: 0 test(s), Total: 60 test(s)Failed: TestSuite.kiowidgets-kdirmodeltest Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report64% (23/36)65% (260/397)65% (260/397)51% (30730/59953)36% (15774/43884)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests98% (55/56)98% (55/56)87% (8223/9490)44% (3883/8916)autotests.http100% (5/5)100% (5/5)99% (581/582)68% (113/166)autotests.kcookiejar100% (1/1)100% (1/1)91% (179/197)72% (49/68)src100% (1/1)100% (1/1)86% (6/7)67% (4/6)src.core86% (100/116)86% (100/116)56% (8081/14311)48% (4474/9259)src.core.kssl100% (1/1)100% (1/1)40% (35/88)50% (3/6)src.filewidgets76% (28/37)76% (28/37)49% (3893/7935)34% (1588/4687)src.gui100% (2/2)100% (2/2)94% (103/109)74% (49/66)src.ioslaves.file100% (5/5)100% (5/5)51% (525/1023)37% (315/850)src.ioslaves.file.kauth0% (0/2)0% (0/2)0% (0/106)0% (0/65)src.ioslaves.ftp0% (0/1)0% (0/1)0% (0/1364)0% (0/1414)src.ioslaves.help0% (0/5)0% (0/5)0% (0/245)0% (0/144)src.ioslaves.http88% (7/8)88% (7/8)41% (1774/4316)35% (1304/3684)src.ioslaves.http.kcookiejar33% (2/6)33% (2/6)47% (630/1331)55% (620/1123)src.ioslaves.remote100% (2/2)100% (2/2)28% (72/257)7% (14/212)src.ioslaves.remote.kdedmodule0% (0/2)0% (0/2)0% (0/12)100% (0/0)src.ioslaves.telnet0% (0/1)0% (0/1)0% (0/43)0% (0/30)src.ioslaves.trash56% (5/9)56% (5/9)51%
KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 275 - Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/275/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 10 Oct 2018 21:39:20 + Build duration: 16 min and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 59 test(s), Skipped: 0 test(s), Total: 60 test(s)Failed: TestSuite.kiowidgets-kdirmodeltest Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report64% (23/36)65% (260/397)65% (260/397)51% (30819/59955)36% (15806/43884)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests98% (55/56)98% (55/56)87% (8223/9490)44% (3881/8916)autotests.http100% (5/5)100% (5/5)99% (581/582)68% (113/166)autotests.kcookiejar100% (1/1)100% (1/1)91% (179/197)72% (49/68)src100% (1/1)100% (1/1)86% (6/7)67% (4/6)src.core86% (100/116)86% (100/116)57% (8148/14312)48% (4492/9263)src.core.kssl100% (1/1)100% (1/1)40% (35/88)50% (3/6)src.filewidgets76% (28/37)76% (28/37)49% (3900/7936)34% (1590/4687)src.gui100% (2/2)100% (2/2)94% (103/109)74% (49/66)src.ioslaves.file100% (5/5)100% (5/5)51% (525/1023)37% (315/850)src.ioslaves.file.kauth0% (0/2)0% (0/2)0% (0/106)0% (0/65)src.ioslaves.ftp0% (0/1)0% (0/1)0% (0/1364)0% (0/1414)src.ioslaves.help0% (0/5)0% (0/5)0% (0/245)0% (0/144)src.ioslaves.http88% (7/8)88% (7/8)41% (1769/4316)35% (1306/3684)src.ioslaves.http.kcookiejar33% (2/6)33% (2/6)47% (629/1331)55% (619/1123)src.ioslaves.remote100% (2/2)100% (2/2)28% (72/257)7% (14/212)src.ioslaves.remote.kdedmodule0% (0/2)0% (0/2)0% (0/12)100% (0/0)src.ioslaves.telnet0% (0/1)0% (0/1)0% (0/43)0% (0/30)src.ioslaves.trash56% (5/9)56% (5/9)52%
D13425: File indexer closing improvements.
bruns requested changes to this revision. bruns added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > mainhub.cpp:72 > m_config->forceConfigUpdate(); > -// FIXME!! > -//m_fileIndexer.updateConfig(); Unrelated change REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13425 To: smithjd, bruns, mgallien, #baloo, poboiko Cc: ngraham, mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, michaelh, astippich, spoorun, abrahams
D15047: Export the StorageDevices object.
bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. You still have not addressed the raised issues. This gets annoying ... REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15047 To: smithjd, broulik, #baloo, bruns, poboiko Cc: bruns, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, abrahams
Re: kiowidgets_kdirmodeltest fail
El dimecres, 10 d’octubre de 2018, a les 23:09:49 CEST, David Faure va escriure: > On mercredi 10 octobre 2018 22:11:12 CEST Albert Astals Cid wrote: > > El dimecres, 10 d’octubre de 2018, a les 16:33:43 CEST, Jaime va escriure: > > > Hello, > > > > > > About > > > > > > https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/429/ > > > testReport/junit/(root)/TestSuite/kiowidgets_kdirmodeltest/> > > > I'm only able to reproduce the crash 1/7 times I run ctest -j3, never if > > > > > > I run the test alone or run make test. > > > > FWIW I can reproduce the ASAN error quite easily with > > > > while [ true ]; do ASAN_OPTIONS=detect_leaks=0 ./bin/kdirmodeltest > > testOverwriteFileWithDir; if [ $? -ne 0 ]; then break; fi; done > > > > it doesn't go more than two or three loops. > > > > > I've tried applying what worked for me in the 4th revision of > > > > > > https://phabricator.kde.org/D10742 to kdirmodel.cpp around line 600, but > > > without success. > > > > > > Any idea how to fix it is welcomed. > > > > From what i see, the problem is that you're storing QModelIndexes and using > > them later when the model has changed. > > > > This is not correct, you can only use a QModelIndex when you just got it or > > when it's passed it to you, if you need to store it you need to use > > QPersistentModelIndex. > > > > I don't understand much the test, but i think the attached patch is a good > > fix, i.e. use the model indexes as soon as they happen and not store them. > > Also makes the test pass "forever" here. > > Looks good to me. Pushed. Cheers, Albert
D13425: File indexer closing improvements.
ngraham edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13425 To: smithjd, bruns, mgallien, #baloo, poboiko Cc: ngraham, mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, michaelh, astippich, spoorun, abrahams
D13425: File indexer closing improvements.
smithjd added a comment. https://bugs.kde.org/show_bug.cgi?id=353559 REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13425 To: smithjd, bruns, mgallien, #baloo, poboiko Cc: ngraham, mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, michaelh, astippich, spoorun, abrahams
D11529: Balooctl: Deindex unfound files with check command.
smithjd removed a dependency: D13216: Overhaul the file index scheduler.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11529 To: smithjd, #baloo, vhanda, michaelh, broulik, bruns Cc: bruns, kde-frameworks-devel, mgallien, ashaposhnikov, michaelh, astippich, spoorun, ngraham, abrahams
D13216: Overhaul the file index scheduler.
smithjd removed a dependent revision: D11529: Balooctl: Deindex unfound files with check command.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13216 To: smithjd, bruns, mgallien Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, bruns, abrahams
D11529: Balooctl: Deindex unfound files with check command.
smithjd removed a dependency: D15047: Export the StorageDevices object.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11529 To: smithjd, #baloo, vhanda, michaelh, broulik, bruns Cc: bruns, kde-frameworks-devel, mgallien, ashaposhnikov, michaelh, astippich, spoorun, ngraham, abrahams
D15047: Export the StorageDevices object.
smithjd removed a dependent revision: D11529: Balooctl: Deindex unfound files with check command.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15047 To: smithjd, broulik, #baloo, bruns, poboiko Cc: bruns, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, abrahams
D13425: File indexer closing improvements.
ngraham added reviewers: Baloo, poboiko. ngraham added a comment. Does this fix https://bugs.kde.org/show_bug.cgi?id=373430 and/or https://bugs.kde.org/show_bug.cgi?id=353559? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13425 To: smithjd, bruns, mgallien, #baloo, poboiko Cc: ngraham, mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, michaelh, astippich, spoorun, abrahams
D13425: File indexer closing improvements.
smithjd updated this revision to Diff 43363. smithjd added a comment. Rebase. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13425?vs=43361=43363 BRANCH master-scheduler-watchesInstalled (branched from master) REVISION DETAIL https://phabricator.kde.org/D13425 AFFECTED FILES src/file/mainhub.cpp To: smithjd, bruns, mgallien Cc: mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, abrahams
D13425: File indexer closing improvements.
smithjd updated this revision to Diff 43361. smithjd added a comment. Rebase. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13425?vs=40344=43361 BRANCH master-scheduler-haltonquit (branched from master) REVISION DETAIL https://phabricator.kde.org/D13425 AFFECTED FILES src/file/fileindexscheduler.cpp src/file/fileindexscheduler.h src/file/mainhub.cpp To: smithjd, bruns, mgallien Cc: mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, abrahams
Re: kiowidgets_kdirmodeltest fail
On mercredi 10 octobre 2018 22:11:12 CEST Albert Astals Cid wrote: > El dimecres, 10 d’octubre de 2018, a les 16:33:43 CEST, Jaime va escriure: > > Hello, > > > > About > > > > https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/429/ > > testReport/junit/(root)/TestSuite/kiowidgets_kdirmodeltest/> > > I'm only able to reproduce the crash 1/7 times I run ctest -j3, never if > > > > I run the test alone or run make test. > > FWIW I can reproduce the ASAN error quite easily with > > while [ true ]; do ASAN_OPTIONS=detect_leaks=0 ./bin/kdirmodeltest > testOverwriteFileWithDir; if [ $? -ne 0 ]; then break; fi; done > > it doesn't go more than two or three loops. > > > I've tried applying what worked for me in the 4th revision of > > > > https://phabricator.kde.org/D10742 to kdirmodel.cpp around line 600, but > > without success. > > > > Any idea how to fix it is welcomed. > > From what i see, the problem is that you're storing QModelIndexes and using > them later when the model has changed. > > This is not correct, you can only use a QModelIndex when you just got it or > when it's passed it to you, if you need to store it you need to use > QPersistentModelIndex. > > I don't understand much the test, but i think the attached patch is a good > fix, i.e. use the model indexes as soon as they happen and not store them. > Also makes the test pass "forever" here. Looks good to me. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5
D15047: Export the StorageDevices object.
smithjd updated this revision to Diff 43357. smithjd added a comment. - Rebase. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15047?vs=43353=43357 BRANCH master-storageDevicesExport (branched from master) REVISION DETAIL https://phabricator.kde.org/D15047 AFFECTED FILES src/file/fileindexerconfig.cpp src/file/fileindexerconfig.h To: smithjd, broulik, #baloo, bruns, poboiko Cc: bruns, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, abrahams
D13216: Overhaul the file index scheduler.
smithjd updated this revision to Diff 43355. smithjd marked an inline comment as done. smithjd added a comment. - Re-write the file index scheduler. Combine content indexer suspend logic. - Update the balooctl tool with the changed suspend/resume behaviour. - Re-order and use IndexerState to prioritize the indexer thread pool. - Newline and tab fixes. - Prevent a scheduler race condition. - Separate runnableStateChanged into two functors. - Allow the first run indexer to complete before running any other runnables. Prevent the new file and unindexed file runnables from running at the same time. - Revert "Re-order and use IndexerState to prioritize the indexer thread pool." - Simplify locking the scheduler. - Adapt index cleaner to scheduler. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13216?vs=40393=43355 BRANCH master-scheduler (branched from master) REVISION DETAIL https://phabricator.kde.org/D13216 AFFECTED FILES src/file/fileindexerconfig.cpp src/file/fileindexerconfig.h src/file/fileindexscheduler.cpp src/file/fileindexscheduler.h src/tools/balooctl/main.cpp To: smithjd, bruns, mgallien Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, bruns, abrahams
D15047: Export the StorageDevices object.
ngraham added reviewers: Baloo, bruns, poboiko. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15047 To: smithjd, broulik, #baloo, bruns, poboiko Cc: bruns, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, abrahams
D15047: Export the StorageDevices object.
smithjd updated this revision to Diff 43353. smithjd added a comment. - Re-write the file index scheduler. Combine content indexer suspend logic. - Update the balooctl tool with the changed suspend/resume behaviour. - Re-order and use IndexerState to prioritize the indexer thread pool. - Newline and tab fixes. - Prevent a scheduler race condition. - Separate runnableStateChanged into two functors. - Allow the first run indexer to complete before running any other runnables. Prevent the new file and unindexed file runnables from running at the same time. - Revert "Re-order and use IndexerState to prioritize the indexer thread pool." - Simplify locking the scheduler. - Adapt index cleaner to scheduler. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15047?vs=40341=43353 BRANCH master-scheduler (branched from master) REVISION DETAIL https://phabricator.kde.org/D15047 AFFECTED FILES CMakeLists.txt src/file/fileindexerconfig.cpp src/file/fileindexerconfig.h src/file/fileindexscheduler.cpp src/file/fileindexscheduler.h src/tools/balooctl/main.cpp To: smithjd, broulik Cc: bruns, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, abrahams
D16116: [KPropertiesDialog] Show a filename for the / directory
thsurrel created this revision. thsurrel added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. thsurrel requested review of this revision. REVISION SUMMARY The properties dialog was not showing anything in the window title and in the file name label near the icon for the root folder. TEST PLAN Open the properties of the root folder REPOSITORY R241 KIO BRANCH arc_root (branched from master) REVISION DETAIL https://phabricator.kde.org/D16116 AFFECTED FILES src/widgets/kpropertiesdialog.cpp To: thsurrel, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13034: Add mechanism to notify other clients of config changes over DBus
davidedmundson added a comment. Thanks, resolved. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D13034 To: davidedmundson, broulik, dfaure Cc: bcooksley, dfaure, broulik, zzag, kde-frameworks-devel, michaelh, ngraham, bruns
Re: kiowidgets_kdirmodeltest fail
El dimecres, 10 d’octubre de 2018, a les 16:33:43 CEST, Jaime va escriure:
> Hello,
>
> About
> https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/429/testReport/junit/(root)/TestSuite/kiowidgets_kdirmodeltest/
>
> I'm only able to reproduce the crash 1/7 times I run ctest -j3, never if
> I run the test alone or run make test.
FWIW I can reproduce the ASAN error quite easily with
while [ true ]; do ASAN_OPTIONS=detect_leaks=0 ./bin/kdirmodeltest
testOverwriteFileWithDir; if [ $? -ne 0 ]; then break; fi; done
it doesn't go more than two or three loops.
>
> I've tried applying what worked for me in the 4th revision of
> https://phabricator.kde.org/D10742 to kdirmodel.cpp around line 600, but
> without success.
>
> Any idea how to fix it is welcomed.
From what i see, the problem is that you're storing QModelIndexes and using
them later when the model has changed.
This is not correct, you can only use a QModelIndex when you just got it or
when it's passed it to you, if you need to store it you need to use
QPersistentModelIndex.
I don't understand much the test, but i think the attached patch is a good fix,
i.e. use the model indexes as soon as they happen and not store them. Also
makes the test pass "forever" here.
Cheers,
Albert
>
> Best Regards.
> Jaime.
>
diff --git a/autotests/kdirmodeltest.cpp b/autotests/kdirmodeltest.cpp
index 3c0ab0bb..c997ab55 100644
--- a/autotests/kdirmodeltest.cpp
+++ b/autotests/kdirmodeltest.cpp
@@ -1269,10 +1269,23 @@ void KDirModelTest::testOverwriteFileWithDir() // #151851 c4
const QString file = path + "toplevelfile_1";
const int oldTopLevelRowCount = m_dirModel->rowCount();
-QSignalSpy spyRowsRemoved(m_dirModel, SIGNAL(rowsRemoved(QModelIndex,int,int)));
+bool removalWithinTopLevel = false;
+bool dataChangedAtFirstLevel = false;
+connect(m_dirModel, ::rowsRemoved, this, [](const QModelIndex ) {
+if (!index.isValid()) {
+// yes, that's what we have been waiting for
+removalWithinTopLevel = true;
+}
+});
+connect(m_dirModel, ::dataChanged, this, [](const QModelIndex ) {
+if (index.isValid() && !index.parent().isValid()) {
+// a change of a node whose parent is root, yay, that's it
+dataChangedAtFirstLevel = true;
+}
+});
+
checkedConnect(m_dirModel, SIGNAL(rowsRemoved(QModelIndex,int,int)),
_eventLoop, SLOT(exitLoop()));
-QSignalSpy spyDataChanged(m_dirModel, SIGNAL(dataChanged(QModelIndex,QModelIndex)));
KIO::Job *job = KIO::move(QUrl::fromLocalFile(dir), QUrl::fromLocalFile(file), KIO::HideProgressInfo);
job->setUiDelegate(nullptr);
@@ -1285,24 +1298,9 @@ void KDirModelTest::testOverwriteFileWithDir() // #151851 c4
// Wait for a removal within the top level (that's for the old file going away), and also
// for a dataChanged which notifies us that a file has become a directory
-bool removalWithinTopLevel = false;
-bool dataChangedAtFirstLevel = false;
+
int retries = 0;
while ((!removalWithinTopLevel || !dataChangedAtFirstLevel) && retries < 100) {
-for (int i = 0; i < spyRowsRemoved.size() && !removalWithinTopLevel; ++i) {
-QModelIndex parent = spyRowsRemoved[i][0].value();
-if (!parent.isValid()) {
-// yes, that's what we have been waiting for
-removalWithinTopLevel = true;
-}
-}
-for (int i = 0; i < spyDataChanged.size() && !dataChangedAtFirstLevel; ++i) {
-QModelIndex idx = spyDataChanged[i][0].value();
-if (idx.isValid() && !idx.parent().isValid()) {
-// a change of a node whose parent is root, yay, that's it
-dataChangedAtFirstLevel = true;
-}
-}
QTest::qWait(10);
++retries;
}
KDE CI: Frameworks » kconfig » kf5-qt5 SUSEQt5.9 - Build # 44 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kconfig/job/kf5-qt5%20SUSEQt5.9/44/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 10 Oct 2018 20:05:00 + Build duration: 5 min 33 sec and counting JUnit Tests Name: (root) Failed: 0 test(s), Passed: 36 test(s), Skipped: 0 test(s), Total: 36 test(s) Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report86% (6/7)90% (69/77)90% (69/77)79% (6760/8597)58% (3511/6038)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests100% (15/15)100% (15/15)99% (1930/1939)52% (847/1615)autotests.kconfig_compiler96% (24/25)96% (24/25)92% (277/301)47% (96/206)src.core88% (22/25)88% (22/25)69% (2362/3428)56% (1225/2175)src.gui71% (5/7)71% (5/7)61% (429/705)51% (156/305)src.kconf_update100% (2/2)100% (2/2)72% (423/591)59% (247/422)src.kconfig_compiler100% (1/1)100% (1/1)86% (1339/1554)80% (940/1169)src.kreadconfig0% (0/2)0% (0/2)0% (0/79)0% (0/146)
D13541: Port solid from Qt5::Widgets to Qt5::Gui
dhaumann added a comment. @graesslin ping REPOSITORY R245 Solid BRANCH gui-instead-of-widgets REVISION DETAIL https://phabricator.kde.org/D13541 To: graesslin, #frameworks, dhaumann, apol, broulik Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns
D16111: use own extractor for testing the taglibwriter
bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH use_extractor_for_writertest REVISION DETAIL https://phabricator.kde.org/D16111 To: astippich, mgallien, bruns, svuorela Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
D13034: Add mechanism to notify other clients of config changes over DBus
bcooksley added a comment. This change broke the build of KConfig on Qt 5.9 (casting issue in QTest) REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D13034 To: davidedmundson, broulik, dfaure Cc: bcooksley, dfaure, broulik, zzag, kde-frameworks-devel, michaelh, ngraham, bruns
D16111: use own extractor for testing the taglibwriter
astippich marked 2 inline comments as done. astippich added a comment. Sorry, that was really stupid REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16111 To: astippich, mgallien, bruns, svuorela Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
D16111: use own extractor for testing the taglibwriter
astippich updated this revision to Diff 43339. astippich added a comment. - fix stupid mistakes REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16111?vs=43330=43339 BRANCH use_extractor_for_writertest REVISION DETAIL https://phabricator.kde.org/D16111 AFFECTED FILES autotests/taglibwritertest.cpp To: astippich, mgallien, bruns, svuorela Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
D16112: add wma files/asf tags as supported mimetype and add test data
bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH supported_wma_asf REVISION DETAIL https://phabricator.kde.org/D16112 To: astippich, mgallien, bruns, svuorela Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
D16111: use own extractor for testing the taglibwriter
bruns requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16111 To: astippich, mgallien, bruns, svuorela Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
D16111: use own extractor for testing the taglibwriter
bruns added inline comments.
INLINE COMMENTS
> taglibwritertest.cpp:5
> #include "writedata.h"
> -
> +#include
> +#include
double slash
> taglibwritertest.cpp:56
> +QCOMPARE(result.properties().value(Property::Album),
> QVariant(QStringLiteral("Album1") + stringSuffix));
> +QCOMPARE(result.properties().value(Property::TrackNumber),
> QVariant(QStringLiteral("10")));
> +QCOMPARE(result.properties().value(Property::ReleaseYear),
> QVariant(QStringLiteral("1999")));
IIRC TrackNumber and ReleaseYear are unsigned int, so this should be
`value(prop).toInt()`, right?
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D16111
To: astippich, mgallien, bruns, svuorela
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun,
ngraham, bruns, abrahams
D16112: add wma files/asf tags as supported mimetype and add test data
astippich created this revision. astippich added reviewers: mgallien, bruns, svuorela. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Add preliminary support for wma files/asf tags for the tags implemented by taglib. The test file was created using ffmpeg from an existing test file. REPOSITORY R286 KFileMetaData BRANCH supported_wma_asf REVISION DETAIL https://phabricator.kde.org/D16112 AFFECTED FILES autotests/samplefiles/test.wma autotests/taglibextractortest.cpp src/extractors/taglibextractor.cpp To: astippich, mgallien, bruns, svuorela Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
D16111: use own extractor for testing the taglibwriter
astippich created this revision. astippich added reviewers: mgallien, bruns, svuorela. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Instead of querying the tags directly through taglib, use the taglibextractor to read the written tags for the tests. This will become useful once additional tags are added to the taglibwriter that require manual querying and reading. As a bonus, the now unneeded custom TString to QString function is removed. TEST PLAN compiles and tests pass REPOSITORY R286 KFileMetaData BRANCH use_extractor_for_writertest REVISION DETAIL https://phabricator.kde.org/D16111 AFFECTED FILES autotests/taglibwritertest.cpp To: astippich, mgallien, bruns, svuorela Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
D15714: add a string suffix to test data and use for unicode testing of taglibwriter
This revision was automatically updated to reflect the committed changes. astippich marked an inline comment as done. Closed by commit R286:196b1289152c: add a string suffix to test data and use for unicode testing of taglibwriter (authored by astippich). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D15714?vs=42541=43327#toc REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15714?vs=42541=43327 REVISION DETAIL https://phabricator.kde.org/D15714 AFFECTED FILES autotests/taglibwritertest.cpp To: astippich, mgallien, bruns Cc: smithjd, svuorela, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
D15714: add a string suffix to test data and use for unicode testing of taglibwriter
astippich marked an inline comment as done. astippich added inline comments. INLINE COMMENTS > bruns wrote in taglibwritertest.cpp:75 > can you change this to `data[2]` ... > Facepalm myself ... I should have spotted this myself :) REPOSITORY R286 KFileMetaData BRANCH taglib_write_unicode REVISION DETAIL https://phabricator.kde.org/D15714 To: astippich, mgallien, bruns Cc: smithjd, svuorela, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
D15714: add a string suffix to test data and use for unicode testing of taglibwriter
astippich edited the summary of this revision. REPOSITORY R286 KFileMetaData BRANCH taglib_write_unicode REVISION DETAIL https://phabricator.kde.org/D15714 To: astippich, mgallien, bruns Cc: smithjd, svuorela, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
D16059: remove compile time check for taglib version
This revision was automatically updated to reflect the committed changes. Closed by commit R286:d6d86adbd773: remove compile time check for taglib version (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16059?vs=43191=43326 REVISION DETAIL https://phabricator.kde.org/D16059 AFFECTED FILES src/extractors/taglibextractor.cpp To: astippich, svuorela, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
D15833: extend test coverage to all supported mimetypes for taglibextractor
This revision was automatically updated to reflect the committed changes. Closed by commit R286:601059a3c0b6: extend test coverage to all supported mimetypes for taglibextractor (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15833?vs=43031=43325 REVISION DETAIL https://phabricator.kde.org/D15833 AFFECTED FILES autotests/samplefiles/test.aif autotests/samplefiles/test.ape autotests/samplefiles/test.wav autotests/samplefiles/test.wv autotests/taglibextractortest.cpp To: astippich, mgallien, bruns, svuorela Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
KDE CI: Frameworks » kconfig » kf5-qt5 SUSEQt5.9 - Build # 43 - Still Failing!
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kconfig/job/kf5-qt5%20SUSEQt5.9/43/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 10 Oct 2018 16:27:44 + Build duration: 3 min 24 sec and counting CONSOLE OUTPUT [...truncated 226.57 KB...][ 71%] Generating test13.mocScanning dependencies of target test13[ 72%] Building CXX object autotests/kconfig_compiler/CMakeFiles/test13.dir/test13main.cpp.o[ 72%] Building CXX object autotests/kconfig_compiler/CMakeFiles/test13.dir/test13.cpp.o[ 73%] Building CXX object autotests/kconfig_compiler/CMakeFiles/test13.dir/test13_autogen/mocs_compilation.cpp.o[ 73%] Linking CXX executable ../../bin/test13[ 73%] Built target test13[ 73%] Generating test10.h, test10.cppScanning dependencies of target test10[ 74%] Building CXX object autotests/kconfig_compiler/CMakeFiles/test10.dir/test10main.cpp.o[ 74%] Building CXX object autotests/kconfig_compiler/CMakeFiles/test10.dir/test10.cpp.o[ 74%] Building CXX object autotests/kconfig_compiler/CMakeFiles/test10.dir/test10_autogen/mocs_compilation.cpp.o[ 75%] Linking CXX executable ../../bin/test10[ 75%] Built target test10[ 75%] Generating test_dpointer.h, test_dpointer.cppScanning dependencies of target test_dpointer[ 76%] Building CXX object autotests/kconfig_compiler/CMakeFiles/test_dpointer.dir/test_dpointer_main.cpp.o[ 76%] Building CXX object autotests/kconfig_compiler/CMakeFiles/test_dpointer.dir/test_dpointer.cpp.o[ 76%] Building CXX object autotests/kconfig_compiler/CMakeFiles/test_dpointer.dir/test_dpointer_autogen/mocs_compilation.cpp.o[ 77%] Linking CXX executable ../../bin/test_dpointer[ 77%] Built target test_dpointer[ 78%] Generating test_translation_kde.h, test_translation_kde.cppScanning dependencies of target test_translation_kde[ 78%] Building CXX object autotests/kconfig_compiler/CMakeFiles/test_translation_kde.dir/test_translation_kde_main.cpp.o[ 79%] Building CXX object autotests/kconfig_compiler/CMakeFiles/test_translation_kde.dir/test_translation_kde.cpp.o[ 79%] Building CXX object autotests/kconfig_compiler/CMakeFiles/test_translation_kde.dir/test_translation_kde_autogen/mocs_compilation.cpp.o[ 79%] Linking CXX executable ../../bin/test_translation_kde[ 79%] Built target test_translation_kde[ 79%] Generating test_qdebugcategory.h, test_qdebugcategory.cppScanning dependencies of target test_qdebugcategory[ 80%] Building CXX object autotests/kconfig_compiler/CMakeFiles/test_qdebugcategory.dir/test_qdebugcategorymain.cpp.o[ 80%] Building CXX object autotests/kconfig_compiler/CMakeFiles/test_qdebugcategory.dir/test_qdebugcategory_debug.cpp.o[ 80%] Building CXX object autotests/kconfig_compiler/CMakeFiles/test_qdebugcategory.dir/test_qdebugcategory.cpp.o[ 81%] Building CXX object autotests/kconfig_compiler/CMakeFiles/test_qdebugcategory.dir/test_qdebugcategory_autogen/mocs_compilation.cpp.o[ 81%] Linking CXX executable ../../bin/test_qdebugcategory[ 81%] Built target test_qdebugcategory[ 81%] Generating test_signal.h, test_signal.cpp[ 81%] Generating test_signal.mocScanning dependencies of target test_signal[ 82%] Building CXX object autotests/kconfig_compiler/CMakeFiles/test_signal.dir/test_signal_main.cpp.o[ 82%] Building CXX object autotests/kconfig_compiler/CMakeFiles/test_signal.dir/test_signal.cpp.o[ 83%] Building CXX object autotests/kconfig_compiler/CMakeFiles/test_signal.dir/test_signal_autogen/mocs_compilation.cpp.o[ 83%] Linking CXX executable ../../bin/test_signal[ 83%] Built target test_signalScanning dependencies of target kstandardshortcuttest[ 83%] Building CXX object autotests/CMakeFiles/kstandardshortcuttest.dir/kstandardshortcuttest.cpp.o[ 83%] Building CXX object autotests/CMakeFiles/kstandardshortcuttest.dir/kstandardshortcuttest_autogen/mocs_compilation.cpp.o[ 84%] Linking CXX executable ../bin/kstandardshortcuttest[ 84%] Built target kstandardshortcuttestScanning dependencies of target kconfigcore-fallbackconfigresourcestest_autogen[ 85%] Automatic MOC for target kconfigcore-fallbackconfigresourcestest[ 85%] Built target kconfigcore-fallbackconfigresourcestest_autogenScanning dependencies of target kconfigtest_autogen[ 86%] Automatic MOC for target kconfigtest[ 86%] Built target kconfigtest_autogen[ 87%] Generating qrc_fallbackconfigresources.cppScanning dependencies of target kconfigcore-fallbackconfigresourcestest[ 87%] Building CXX object autotests/CMakeFiles/kconfigcore-fallbackconfigresourcestest.dir/fallbackconfigresourcestest.cpp.o[ 88%] Building CXX object autotests/CMakeFiles/kconfigcore-fallbackconfigresourcestest.dir/kconfigcore-fallbackconfigresourcestest_autogen/mocs_compilation.cpp.o[ 88%] Building CXX object autotests/CMakeFiles/kconfigcore-fallbackconfigresourcestest.dir/qrc_fallbackconfigresources.cpp.o[ 88%] Linking CXX executable ../bin/kconfigcore-fallbackconfigresourcestest[ 88%] Built target kconfigcore-fallbackconfigresourcestestScanning dependencies of target kconfigtest[ 89%] Building CXX object
D15825: move testing of common tags of test files to a new data-driven test for taglibextractor
This revision was automatically updated to reflect the committed changes. Closed by commit R286:52920c0003d6: move testing of common tags of test files to a new data-driven test for… (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15825?vs=43028=43324 REVISION DETAIL https://phabricator.kde.org/D15825 AFFECTED FILES autotests/taglibextractortest.cpp autotests/taglibextractortest.h To: astippich, bruns, svuorela Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
D15825: move testing of common tags of test files to a new data-driven test for taglibextractor
astippich edited the summary of this revision. REPOSITORY R286 KFileMetaData BRANCH refactor_taglib_extractor_tests REVISION DETAIL https://phabricator.kde.org/D15825 To: astippich, bruns, svuorela Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
D16108: When re-using runners when reloading, reload their configuration
broulik created this revision. broulik added reviewers: Plasma, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY When configuration is changed, runners are reloaded but their instances re-used so they never get notified of config changes. BUG: 399621 TEST PLAN Changed character runner keyword, hit OK, new keyword was used immediately REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D16108 AFFECTED FILES src/runnermanager.cpp To: broulik, #plasma, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D15417: [AppImage Thumbnailer] Avoid creating QTemporaryFile
This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit R320:ec93501d3318: [AppImage Thumbnailer] Avoid creating QTemporaryFile (authored by broulik). Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15417?vs=41387=43316 REVISION DETAIL https://phabricator.kde.org/D15417 AFFECTED FILES thumbnail/appimagecreator.cpp To: broulik, #frameworks, TheAssassin, anthonyfieroni Cc: kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp
D16060: Reduce double and triple lookups to the frames hash
broulik accepted this revision. broulik added inline comments. INLINE COMMENTS > davidedmundson wrote in framesvg.cpp:967 > if we're calling deref without it being paired with ref then we have bigger > problems. :D fair enough REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D16060 To: apol, #plasma, davidedmundson, broulik Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns
D16060: Reduce double and triple lookups to the frames hash
davidedmundson added inline comments. INLINE COMMENTS > broulik wrote in framesvg.cpp:967 > Can we assume `references` always contains `svg`? if we're calling deref without it being paired with ref then we have bigger problems. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D16060 To: apol, #plasma, davidedmundson Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns
D16060: Reduce double and triple lookups to the frames hash
broulik added inline comments.
INLINE COMMENTS
> framesvg.cpp:967
> {
> -references[svg] = references[svg] - 1;
> -//qCDebug(LOG_PLASMA) << this << svg << references[svg];
> -if (references[svg] < 1) {
> -references.remove(svg);
> +auto it = references.find(svg);
> +(*it)--;
Can we assume `references` always contains `svg`?
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D16060
To: apol, #plasma, davidedmundson
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns
D16060: Reduce double and triple lookups to the frames hash
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D16060 To: apol, #plasma, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns
kiowidgets_kdirmodeltest fail
Hello, About https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/429/testReport/junit/(root)/TestSuite/kiowidgets_kdirmodeltest/ I'm only able to reproduce the crash 1/7 times I run ctest -j3, never if I run the test alone or run make test. I've tried applying what worked for me in the 4th revision of https://phabricator.kde.org/D10742 to kdirmodel.cpp around line 600, but without success. Any idea how to fix it is welcomed. Best Regards. Jaime.
Re: DBus thread shutdown issue on Windows
[Adjusting CC list] On mercredi 10 octobre 2018 11:55:01 CEST Ben Cooksley wrote: > On Thu, Oct 4, 2018 at 3:15 PM Thiago Macieira > > wrote: > > On Wednesday, 3 October 2018 18:12:08 PDT David Faure wrote: > > > On another note, if Qt knows this part of Windows is broken, why is it > > > even trying to spin down a thread when they know it's just going to > > > shoot themselves in the foot? > > > > Because C++. If the object exists, it will be destroyed properly. > > > > The code also predates my finding of the issue on Windows. Nothing I've > > tried so far has managed to fix the issue. I don't remember if simply > > leaking the QThread objects works. I resigned my maintainership over my > > inability to find da solution, so someone else would step up and come up > > with new ideas. > > > > It's been two and a half years and we're still waiting. > > I see. As it seems only some parts of DBus trigger this (because > KDevelop and KNotification tests both cause DBus to start and they > don't get stuck like this) could we try disabling kssld on Windows? > (to my knowledge it's only there to help with certificate stores, and > those should be looked after by Windows infrastructure not by us on > Windows systems...) I believe it also stores "accept this certificate for this session", which makes sense on Windows as well Though not in unittests, I guess, so disabling it use on CI sounds like a possibility. Not sure exactly how to do that though (no time to investigate right now). -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5
D13867: [KMessageWidget] Pass widget to standardIcon()
broulik planned changes to this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D13867 To: broulik, #frameworks, cfeck, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13757: Move parsing .desktop file for folder Comment to file KIO
broulik abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13757 To: broulik, dfaure, lbeltrame Cc: ngraham, kde-frameworks-devel, michaelh, bruns
D15741: Use correct MaximumSize
This revision was automatically updated to reflect the committed changes. Closed by commit R320:1b334712ed0f: Use correct MaximumSize (authored by broulik). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15741?vs=42291=43306 REVISION DETAIL https://phabricator.kde.org/D15741 AFFECTED FILES thumbnail/thumbnail.cpp To: broulik, #frameworks, ngraham Cc: kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp
KDE CI: Frameworks » kconfig » kf5-qt5 SUSEQt5.9 - Build # 42 - Failure!
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks/job/kconfig/job/kf5-qt5%20SUSEQt5.9/42/
Project:
kf5-qt5 SUSEQt5.9
Date of build:
Wed, 10 Oct 2018 13:51:33 +
Build duration:
5 min 26 sec and counting
CONSOLE OUTPUT
[...truncated 129.10 KB...]Scanning dependencies of target kreadconfig5[ 19%] Building CXX object src/kreadconfig/CMakeFiles/kreadconfig5.dir/kreadconfig.cpp.o[ 19%] Linking CXX executable ../../bin/kwriteconfig5[ 19%] Built target KF5ConfigGui_autogen[ 19%] Building CXX object src/kreadconfig/CMakeFiles/kreadconfig5.dir/kreadconfig5_autogen/mocs_compilation.cpp.oScanning dependencies of target kconfig_compiler_autogen[ 19%] Automatic MOC for target kconfig_compiler[ 19%] Built target kconfig_compiler_autogenScanning dependencies of target kconfignokdehometest[ 19%] Building CXX object autotests/CMakeFiles/kconfignokdehometest.dir/kconfignokdehometest.cpp.o[ 19%] Built target kwriteconfig5[ 20%] Building CXX object autotests/CMakeFiles/kconfignokdehometest.dir/kconfignokdehometest_autogen/mocs_compilation.cpp.o[ 20%] Generating qrc_sharedconfigresources.cppScanning dependencies of target kconfigcore-ksharedconfigtest[ 20%] Building CXX object autotests/CMakeFiles/kconfigcore-ksharedconfigtest.dir/ksharedconfigtest.cpp.oScanning dependencies of target kconfigtest[ 21%] Building CXX object autotests/CMakeFiles/kconfigtest.dir/kconfigtest.cpp.o[ 21%] Linking CXX executable ../../bin/kconfigcompiler-basic-test[ 22%] Linking CXX executable ../../bin/kreadconfig5[ 22%] Built target kreadconfig5[ 22%] Built target kconfigcompiler-basic-test[ 22%] Linking CXX executable ../bin/kconfignokdehometest/home/jenkins/workspace/Frameworks/kconfig/kf5-qt5 SUSEQt5.9/autotests/kconfigtest.cpp: In member function ���void KConfigTest::testChangeGroup()���:/home/jenkins/workspace/Frameworks/kconfig/kf5-qt5 SUSEQt5.9/autotests/kconfigtest.cpp:757:34: warning: ���void KConfigGroup::changeGroup(const char*)��� is deprecated [-Wdeprecated-declarations] newGroup.changeGroup("FooBar"); // deprecated! ^In file included from /home/jenkins/workspace/Frameworks/kconfig/kf5-qt5 SUSEQt5.9/autotests/kconfigtest.cpp:34:/home/jenkins/workspace/Frameworks/kconfig/kf5-qt5 SUSEQt5.9/src/core/kconfiggroup.h:160:33: note: declared here KCONFIGCORE_DEPRECATED void changeGroup(const char *group); ^~~/home/jenkins/workspace/Frameworks/kconfig/kf5-qt5 SUSEQt5.9/autotests/kconfigtest.cpp:773:35: warning: ���void KConfigGroup::changeGroup(const char*)��� is deprecated [-Wdeprecated-declarations] newGroup2.changeGroup("FooBar"); // deprecated! ^In file included from /home/jenkins/workspace/Frameworks/kconfig/kf5-qt5 SUSEQt5.9/autotests/kconfigtest.cpp:34:/home/jenkins/workspace/Frameworks/kconfig/kf5-qt5 SUSEQt5.9/src/core/kconfiggroup.h:160:33: note: declared here KCONFIGCORE_DEPRECATED void changeGroup(const char *group); ^~~[ 23%] Building CXX object autotests/CMakeFiles/kconfigcore-ksharedconfigtest.dir/qrc_sharedconfigresources.cpp.o[ 23%] Built target kconfignokdehometest[ 23%] Building CXX object autotests/CMakeFiles/kconfigcore-ksharedconfigtest.dir/kconfigcore-ksharedconfigtest_autogen/mocs_compilation.cpp.o[ 23%] Linking CXX executable ../bin/kconfigcore-ksharedconfigtest[ 23%] Built target kconfigcore-ksharedconfigtestScanning dependencies of target kdesktopfiletest[ 23%] Building CXX object autotests/CMakeFiles/kdesktopfiletest.dir/kdesktopfiletest.cpp.oScanning dependencies of target test_kconfigutils[ 23%] Building CXX object autotests/CMakeFiles/test_kconfigutils.dir/test_kconfigutils.cpp.oIn file included from /usr/include/qt5/QtTest/qtest.h:45, from /usr/include/qt5/QtTest/QtTest:7, from /home/jenkins/workspace/Frameworks/kconfig/kf5-qt5 SUSEQt5.9/autotests/kdesktopfiletest.cpp:26:/home/jenkins/workspace/Frameworks/kconfig/kf5-qt5 SUSEQt5.9/autotests/kdesktopfiletest.cpp: In member function ���void KDesktopFileTest::testReadDirectory()���:/home/jenkins/workspace/Frameworks/kconfig/kf5-qt5 SUSEQt5.9/autotests/kdesktopfiletest.cpp:81:27: warning: ���QStringList KDesktopFile::sortOrder() const��� is deprecated [-Wdeprecated-declarations] QCOMPARE(df.sortOrder(), QStringList() << QString::fromLatin1("2.desktop") ^In file included from /home/jenkins/workspace/Frameworks/kconfig/kf5-qt5 SUSEQt5.9/autotests/kdesktopfiletest.cpp:24:/home/jenkins/workspace/Frameworks/kconfig/kf5-qt5 SUSEQt5.9/src/core/kdesktopfile.h:225:40: note: declared here KCONFIGCORE_DEPRECATED QStringList sortOrder() const;^[ 24%] Generating qrc_fallbackconfigresources.cppScanning dependencies of target kconfigcore-fallbackconfigresourcestest[ 24%] Building CXX object
D13033: Expose getter method for KConfig::addConfigSources
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R237:8e5608346337: Expose getter method for KConfig::addConfigSources (authored by davidedmundson). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13033?vs=34628=43303 REVISION DETAIL https://phabricator.kde.org/D13033 AFFECTED FILES src/core/kconfig.cpp src/core/kconfig.h To: davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13034: Add mechanism to notify other clients of config changes over DBus
This revision was automatically updated to reflect the committed changes. davidedmundson marked an inline comment as done. Closed by commit R237:8579ec54838b: Add mechanism to notify other clients of config changes over DBus (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D13034?vs=41547=43304#toc REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13034?vs=41547=43304 REVISION DETAIL https://phabricator.kde.org/D13034 AFFECTED FILES CMakeLists.txt autotests/kconfigtest.cpp autotests/kconfigtest.h src/core/CMakeLists.txt src/core/config-kconfig.h.cmake src/core/kconfig.cpp src/core/kconfig_p.h src/core/kconfigbase.h src/core/kconfigdata.cpp src/core/kconfigdata.h src/core/kconfigwatcher.cpp src/core/kconfigwatcher.h To: davidedmundson, broulik, dfaure Cc: dfaure, broulik, zzag, kde-frameworks-devel, michaelh, ngraham, bruns
D8708: Introduce AbstractAnnotationItemDelegate for more control by consumer
kossebau added a comment. @cullmann @dhaumann So, what to do? :) Do you think if we delay one more month you will find time to give this the wanted deeper review? Or will this continue to (understandable) lack your motivation given you are so far not a consumer of this new API? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D8708 To: kossebau, #kate, #kdevelop Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, sars
D14111: Install MIME type definition for text/x-rst ourselves for now
kossebau abandoned this revision. kossebau added a comment. I see how this is no simple matter. Given I could solve my needs locally, no need to add things to maintain where no-one else seems to have a need. So discarding, no bad feelings. Given that rst is around since ages and yet nobody had added that to s-m-i, this seems a niche need anyway :) REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D14111 To: kossebau, dfaure, pino Cc: fabianr, kde-frameworks-devel, michaelh, ngraham, bruns
KDE CI: Frameworks » kcmutils » kf5-qt5 SUSEQt5.9 - Build # 35 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcmutils/job/kf5-qt5%20SUSEQt5.9/35/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 10 Oct 2018 11:04:51 + Build duration: 29 min and counting JUnit Tests Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s) Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report0% (0/2)0% (0/21)0% (0/21)0% (0/1648)0% (0/989)Coverage Breakdown by Package Name FilesClassesLinesConditionalssrc0% (0/13)0% (0/13)0% (0/1232)0% (0/760)src.ksettings0% (0/8)0% (0/8)0% (0/416)0% (0/229)
KDE CI: Frameworks » kcmutils » kf5-qt5 SUSEQt5.9 - Build # 34 - Failure!
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks/job/kcmutils/job/kf5-qt5%20SUSEQt5.9/34/
Project:
kf5-qt5 SUSEQt5.9
Date of build:
Wed, 10 Oct 2018 09:49:04 +
Build duration:
1 hr 15 min and counting
CONSOLE OUTPUT
[...truncated 108.99 KB...] * KF5I18n (required version >= 5.51.0) * KF5IconThemes (required version >= 5.51.0) * KF5Service (required version >= 5.51.0) * KF5XmlGui (required version >= 5.51.0) * ECM (required version >= 1.6.0), Extra CMake Modules., * KF5Declarative (required version >= 5.51.0) * Doxygen (required version >= 1.8.13) Needed for API dox QCH file generation * QHelpGenerator, Part of Qt5 tools Needed for API dox QCH file generation-- Configuring done-- Generating done-- Build files have been written to: /home/jenkins/workspace/Frameworks/kcmutils/kf5-qt5 SUSEQt5.9/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[kf5-qt5 SUSEQt5.9] Running shell script+ python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project kcmutils --branchGroup kf5-qt5 --platform SUSEQt5.9 --usingInstall /home/jenkins//install-prefix/Scanning dependencies of target KF5Service_QCHScanning dependencies of target KF5Codecs_QCHScanning dependencies of target KF5Auth_QCHScanning dependencies of target KF5CoreAddons_QCHScanning dependencies of target KF5ConfigWidgets_QCHScanning dependencies of target KF5Config_QCH[ 0%] Built target KF5Service_QCH[ 0%] Built target KF5Codecs_QCH[ 0%] Built target KF5CoreAddons_QCH[ 0%] Built target KF5Auth_QCHScanning dependencies of target KF5KCMUtils_autogen[ 0%] Built target KF5ConfigWidgets_QCH[ 6%] Automatic MOC for target KF5KCMUtilsScanning dependencies of target KF5WidgetsAddons_QCH[ 6%] Built target KF5Config_QCH[ 6%] Built target KF5WidgetsAddons_QCHScanning dependencies of target KF5KCMUtils_QCH[ 12%] Generating src/KF5KCMUtils.qch, src/KF5KCMUtils.tags[ 12%] Built target KF5KCMUtils_autogenScanning dependencies of target KF5KCMUtils[ 18%] Building CXX object src/CMakeFiles/KF5KCMUtils.dir/kcmoduleinfo.cpp.o[ 25%] Building CXX object src/CMakeFiles/KF5KCMUtils.dir/kcmoduleqml.cpp.o[ 31%] Building CXX object src/CMakeFiles/KF5KCMUtils.dir/kcmoduleloader.cpp.o[ 37%] Building CXX object src/CMakeFiles/KF5KCMUtils.dir/kcmoduleproxy.cpp.o[ 43%] Building CXX object src/CMakeFiles/KF5KCMUtils.dir/kcmultidialog.cpp.o[ 50%] Building CXX object src/CMakeFiles/KF5KCMUtils.dir/kpluginselector.cpp.oBuilding up file structure...Insert custom filters...Insert help data for filter section (1 of 1)...Insert files...Insert contents...Insert indices...Documentation successfully generated.[ 50%] Built target KF5KCMUtils_QCH[ 56%] Building CXX object src/CMakeFiles/KF5KCMUtils.dir/ksettingswidgetadaptor.cpp.o[ 62%] Building CXX object src/CMakeFiles/KF5KCMUtils.dir/ksettings/dispatcher.cpp.o[ 68%] Building CXX object src/CMakeFiles/KF5KCMUtils.dir/kcmodulecontainer.cpp.o[ 75%] Building CXX object src/CMakeFiles/KF5KCMUtils.dir/ksettings/dialog.cpp.o/home/jenkins/workspace/Frameworks/kcmutils/kf5-qt5 SUSEQt5.9/src/kpluginselector.cpp: In member function ���void KPluginSelector::Private::PluginDelegate::slotAboutClicked()���:/home/jenkins/workspace/Frameworks/kcmutils/kf5-qt5 SUSEQt5.9/src/kpluginselector.cpp:800:91: warning: ���KAboutData& KAboutData::setProgramIconName(const QString&)��� is deprecated [-Wdeprecated-declarations] aboutData.setProgramIconName(index.model()->data(index, Qt::DecorationRole).toString()); ^In file included from /home/jenkins/workspace/Frameworks/kcmutils/kf5-qt5 SUSEQt5.9/src/kpluginselector.cpp:49:/home/jenkins/install-prefix/include/KF5/KCoreAddons/kaboutdata.h:695:40: note: declared here KCOREADDONS_DEPRECATED KAboutData (const QString ); // KF6 remove this^~/home/jenkins/workspace/Frameworks/kcmutils/kf5-qt5 SUSEQt5.9/src/kcmoduleqml.cpp: In constructor ���KCModuleQml::KCModuleQml(KQuickAddons::ConfigModule*, QWidget*, const QVariantList&)���:/home/jenkins/workspace/Frameworks/kcmutils/kf5-qt5 SUSEQt5.9/src/kcmoduleqml.cpp:156:63: error: ���pagePushed��� is not a member of ���KQuickAddons::ConfigModule��� connect(d->configModule, ::ConfigModule::pagePushed, this, [this](QQuickItem *page) { ^~/home/jenkins/workspace/Frameworks/kcmutils/kf5-qt5 SUSEQt5.9/src/kcmoduleqml.cpp:160:63: error: ���pageRemoved��� is not a member of ���KQuickAddons::ConfigModule��� connect(d->configModule, ::ConfigModule::pageRemoved, this, [this]() { ^~~/home/jenkins/workspace/Frameworks/kcmutils/kf5-qt5 SUSEQt5.9/src/kcmoduleqml.cpp: In lambda function:/home/jenkins/workspace/Frameworks/kcmutils/kf5-qt5 SUSEQt5.9/src/kcmoduleqml.cpp:166:76:
KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.9 - Build # 41 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.9/41/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 10 Oct 2018 06:56:37 + Build duration: 3 hr 47 min and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 40 test(s)Failed: TestSuite.ktabwidget_unittest Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report29% (4/14)43% (124/291)43% (124/291)47% (21750/45961)38% (13184/34249)Coverage Breakdown by Package Name FilesClassesLinesConditionalsdefault0% (0/1)0% (0/1)0% (0/87)0% (0/56)autotests98% (44/45)98% (44/45)98% (11469/11759)50% (7254/14375)src0% (0/1)0% (0/1)0% (0/4)0% (0/2)src.kdebugdialog0% (0/7)0% (0/7)0% (0/256)0% (0/73)src.kdecore76% (65/86)76% (65/86)53% (9506/17866)49% (5599/11459)src.kdeui19% (13/68)19% (13/68)8% (765/9694)6% (330/5364)src.kio7% (2/27)7% (2/27)0% (10/2258)0% (1/1238)src.kioslave.metainfo0% (0/1)0% (0/1)0% (0/32)0% (0/4)src.kparts0% (0/1)0% (0/1)0% (0/24)0% (0/12)src.kssl0% (0/8)0% (0/8)0% (0/1807)0% (0/853)src.kssl.kcm0% (0/3)0% (0/3)0% (0/264)0% (0/145)src.solid0% (0/3)0% (0/3)0% (0/188)0% (0/87)src.solid-networkstatus.kded0% (0/6)0% (0/6)0% (0/185)0% (0/94)tests0% (0/34)0% (0/34)0% (0/1537)0% (0/487)
KDE CI: Frameworks » kcmutils » kf5-qt5 SUSEQt5.10 - Build # 51 - Still Failing!
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks/job/kcmutils/job/kf5-qt5%20SUSEQt5.10/51/
Project:
kf5-qt5 SUSEQt5.10
Date of build:
Wed, 10 Oct 2018 09:59:12 +
Build duration:
2 min 38 sec and counting
CONSOLE OUTPUT
[...truncated 101.34 KB...]-- No such target Qt5Xml_QCH defined when calling ecm_add_qch(), ignored.-- The following features have been enabled: * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)-- The following REQUIRED packages have been found: * Qt5Gui (required version >= 5.10.1) * Qt5Widgets * Qt5DBus * Qt5Network (required version >= 5.10.1) * Qt5Qml * Qt5Quick * Qt5QuickWidgets * Qt5 (required version >= 5.8.0) * KF5ItemViews (required version >= 5.51.0) * KF5ConfigWidgets (required version >= 5.51.0) * KF5CoreAddons (required version >= 5.51.0) * Gettext * KF5I18n (required version >= 5.51.0) * KF5IconThemes (required version >= 5.51.0) * KF5Service (required version >= 5.51.0) * KF5XmlGui (required version >= 5.51.0) * ECM (required version >= 1.6.0), Extra CMake Modules., * KF5Declarative (required version >= 5.51.0) * Doxygen (required version >= 1.8.13) Needed for API dox QCH file generation * QHelpGenerator, Part of Qt5 tools Needed for API dox QCH file generation-- Configuring done-- Generating done-- Build files have been written to: /home/jenkins/workspace/Frameworks/kcmutils/kf5-qt5 SUSEQt5.10/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[kf5-qt5 SUSEQt5.10] Running shell script+ python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project kcmutils --branchGroup kf5-qt5 --platform SUSEQt5.10 --usingInstall /home/jenkins//install-prefix/Scanning dependencies of target KF5Service_QCHScanning dependencies of target KF5Codecs_QCHScanning dependencies of target KF5ConfigWidgets_QCHScanning dependencies of target KF5Config_QCHScanning dependencies of target KF5Auth_QCHScanning dependencies of target KF5CoreAddons_QCH[ 0%] Built target KF5Service_QCH[ 0%] Built target KF5Codecs_QCH[ 0%] Built target KF5Auth_QCH[ 0%] Built target KF5Config_QCH[ 0%] Built target KF5ConfigWidgets_QCH[ 0%] Built target KF5CoreAddons_QCHScanning dependencies of target KF5WidgetsAddons_QCHScanning dependencies of target KF5KCMUtils_autogen[ 0%] Built target KF5WidgetsAddons_QCH[ 6%] Automatic MOC for target KF5KCMUtilsScanning dependencies of target KF5KCMUtils_QCH[ 12%] Generating src/KF5KCMUtils.qch, src/KF5KCMUtils.tags[ 12%] Built target KF5KCMUtils_autogenScanning dependencies of target KF5KCMUtils[ 18%] Building CXX object src/CMakeFiles/KF5KCMUtils.dir/kcmoduleinfo.cpp.o[ 25%] Building CXX object src/CMakeFiles/KF5KCMUtils.dir/kcmoduleqml.cpp.o[ 31%] Building CXX object src/CMakeFiles/KF5KCMUtils.dir/kcmoduleloader.cpp.o[ 37%] Building CXX object src/CMakeFiles/KF5KCMUtils.dir/kcmultidialog.cpp.o[ 43%] Building CXX object src/CMakeFiles/KF5KCMUtils.dir/kcmoduleproxy.cpp.o/home/jenkins/workspace/Frameworks/kcmutils/kf5-qt5 SUSEQt5.10/src/kcmultidialog.cpp: In member function ���KPageWidgetItem* KCMultiDialog::addModule(const KCModuleInfo&, KPageWidgetItem*, const QStringList&)���:/home/jenkins/workspace/Frameworks/kcmutils/kf5-qt5 SUSEQt5.10/src/kcmultidialog.cpp:453:15: error: ���class KPageWidgetItem��� has no member named ���setHeaderVisible���; did you mean ���setHeader���? item->setHeaderVisible(false); ^~~~ setHeader[ 50%] Building CXX object src/CMakeFiles/KF5KCMUtils.dir/kpluginselector.cpp.omake[2]: *** [src/CMakeFiles/KF5KCMUtils.dir/build.make:102: src/CMakeFiles/KF5KCMUtils.dir/kcmultidialog.cpp.o] Error 1make[2]: *** Waiting for unfinished jobs/home/jenkins/workspace/Frameworks/kcmutils/kf5-qt5 SUSEQt5.10/src/kpluginselector.cpp: In member function ���void KPluginSelector::Private::PluginDelegate::slotAboutClicked()���:/home/jenkins/workspace/Frameworks/kcmutils/kf5-qt5 SUSEQt5.10/src/kpluginselector.cpp:800:91: warning: ���KAboutData& KAboutData::setProgramIconName(const QString&)��� is deprecated [-Wdeprecated-declarations] aboutData.setProgramIconName(index.model()->data(index, Qt::DecorationRole).toString()); ^In file included from /home/jenkins/workspace/Frameworks/kcmutils/kf5-qt5 SUSEQt5.10/src/kpluginselector.cpp:49:/home/jenkins/install-prefix/include/KF5/KCoreAddons/kaboutdata.h:695:40: note: declared here KCOREADDONS_DEPRECATED KAboutData (const QString ); // KF6 remove this^~make[1]: *** [CMakeFiles/Makefile2:617: src/CMakeFiles/KF5KCMUtils.dir/all] Error 2make[1]: *** Waiting for unfinished jobsBuilding up file structure...Insert custom filters...Insert help data for filter section (1 of 1)...Insert files...Insert contents...Insert indices...Documentation successfully generated.[ 50%] Built
KDE CI: Frameworks » kcmutils » kf5-qt5 SUSEQt5.10 - Build # 50 - Failure!
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks/job/kcmutils/job/kf5-qt5%20SUSEQt5.10/50/
Project:
kf5-qt5 SUSEQt5.10
Date of build:
Wed, 10 Oct 2018 09:49:04 +
Build duration:
10 min and counting
CONSOLE OUTPUT
[...truncated 100.94 KB...]-- No such target Qt5Gui_QCH defined when calling ecm_add_qch(), ignored.-- No such target Qt5Xml_QCH defined when calling ecm_add_qch(), ignored.-- The following features have been enabled: * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)-- The following REQUIRED packages have been found: * Qt5Gui (required version >= 5.10.1) * Qt5Widgets * Qt5DBus * Qt5Network (required version >= 5.10.1) * Qt5Qml * Qt5Quick * Qt5QuickWidgets * Qt5 (required version >= 5.8.0) * KF5ItemViews (required version >= 5.51.0) * KF5ConfigWidgets (required version >= 5.51.0) * KF5CoreAddons (required version >= 5.51.0) * Gettext * KF5I18n (required version >= 5.51.0) * KF5IconThemes (required version >= 5.51.0) * KF5Service (required version >= 5.51.0) * KF5XmlGui (required version >= 5.51.0) * ECM (required version >= 1.6.0), Extra CMake Modules., * KF5Declarative (required version >= 5.51.0) * Doxygen (required version >= 1.8.13) Needed for API dox QCH file generation * QHelpGenerator, Part of Qt5 tools Needed for API dox QCH file generation-- Configuring done-- Generating done-- Build files have been written to: /home/jenkins/workspace/Frameworks/kcmutils/kf5-qt5 SUSEQt5.10/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[kf5-qt5 SUSEQt5.10] Running shell script+ python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project kcmutils --branchGroup kf5-qt5 --platform SUSEQt5.10 --usingInstall /home/jenkins//install-prefix/Scanning dependencies of target KF5Service_QCHScanning dependencies of target KF5Codecs_QCHScanning dependencies of target KF5Auth_QCH[ 0%] Built target KF5Service_QCH[ 0%] Built target KF5Codecs_QCH[ 0%] Built target KF5Auth_QCHScanning dependencies of target KF5CoreAddons_QCHScanning dependencies of target KF5WidgetsAddons_QCHScanning dependencies of target KF5KCMUtils_autogen[ 0%] Built target KF5CoreAddons_QCH[ 6%] Automatic MOC for target KF5KCMUtils[ 6%] Built target KF5WidgetsAddons_QCHScanning dependencies of target KF5ConfigWidgets_QCHScanning dependencies of target KF5Config_QCH[ 6%] Built target KF5ConfigWidgets_QCH[ 6%] Built target KF5Config_QCHScanning dependencies of target KF5KCMUtils_QCH[ 12%] Generating src/KF5KCMUtils.qch, src/KF5KCMUtils.tags[ 12%] Built target KF5KCMUtils_autogenBuilding up file structure...Insert custom filters...Insert help data for filter section (1 of 1)...Insert files...Insert contents...Insert indices...Documentation successfully generated.[ 12%] Built target KF5KCMUtils_QCHScanning dependencies of target KF5KCMUtils[ 18%] Building CXX object src/CMakeFiles/KF5KCMUtils.dir/kcmoduleinfo.cpp.o[ 25%] Building CXX object src/CMakeFiles/KF5KCMUtils.dir/kcmoduleqml.cpp.o[ 31%] Building CXX object src/CMakeFiles/KF5KCMUtils.dir/kcmoduleloader.cpp.o[ 37%] Building CXX object src/CMakeFiles/KF5KCMUtils.dir/kpluginselector.cpp.o[ 50%] Building CXX object src/CMakeFiles/KF5KCMUtils.dir/kcmoduleproxy.cpp.o[ 50%] Building CXX object src/CMakeFiles/KF5KCMUtils.dir/kcmultidialog.cpp.o/home/jenkins/workspace/Frameworks/kcmutils/kf5-qt5 SUSEQt5.10/src/kcmultidialog.cpp: In member function ���KPageWidgetItem* KCMultiDialog::addModule(const KCModuleInfo&, KPageWidgetItem*, const QStringList&)���:/home/jenkins/workspace/Frameworks/kcmutils/kf5-qt5 SUSEQt5.10/src/kcmultidialog.cpp:453:15: error: ���class KPageWidgetItem��� has no member named ���setHeaderVisible���; did you mean ���setHeader���? item->setHeaderVisible(false); ^~~~ setHeader/home/jenkins/workspace/Frameworks/kcmutils/kf5-qt5 SUSEQt5.10/src/kpluginselector.cpp: In member function ���void KPluginSelector::Private::PluginDelegate::slotAboutClicked()���:/home/jenkins/workspace/Frameworks/kcmutils/kf5-qt5 SUSEQt5.10/src/kpluginselector.cpp:800:91: warning: ���KAboutData& KAboutData::setProgramIconName(const QString&)��� is deprecated [-Wdeprecated-declarations] aboutData.setProgramIconName(index.model()->data(index, Qt::DecorationRole).toString()); ^In file included from /home/jenkins/workspace/Frameworks/kcmutils/kf5-qt5 SUSEQt5.10/src/kpluginselector.cpp:49:/home/jenkins/install-prefix/include/KF5/KCoreAddons/kaboutdata.h:695:40: note: declared here KCOREADDONS_DEPRECATED KAboutData (const QString ); // KF6 remove this^~make[2]: *** [src/CMakeFiles/KF5KCMUtils.dir/build.make:102: src/CMakeFiles/KF5KCMUtils.dir/kcmultidialog.cpp.o] Error 1make[2]: *** Waiting for unfinished jobsmake[1]: *** [CMakeFiles/Makefile2:617:
KDE CI: Frameworks » purpose » kf5-qt5 FreeBSDQt5.11 - Build # 14 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20FreeBSDQt5.11/14/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Wed, 10 Oct 2018 09:50:21 + Build duration: 4 min 52 sec and counting
D14580: support for multi pages kcms
This revision was automatically updated to reflect the committed changes. Closed by commit R295:58e3b29efb99: support for multi pages kcms (authored by mart). REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14580?vs=43279=43280 REVISION DETAIL https://phabricator.kde.org/D14580 AFFECTED FILES src/CMakeLists.txt src/kcmoduleqml.cpp src/kcmultidialog.cpp To: mart, #plasma, #frameworks, davidedmundson Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns
D14580: support for multi pages kcms
mart updated this revision to Diff 43279. mart added a comment. - Merge branch 'master' into arcpatch-D14580 REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14580?vs=40629=43279 BRANCH arcpatch-D14580 REVISION DETAIL https://phabricator.kde.org/D14580 AFFECTED FILES src/CMakeLists.txt src/kcmoduleqml.cpp src/kcmultidialog.cpp To: mart, #plasma, #frameworks, davidedmundson Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns
D15099: add a new property headerVisible
This revision was automatically updated to reflect the committed changes. Closed by commit R236:9069ae42435c: add a new property headerVisible (authored by mart). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15099?vs=40504=43278 REVISION DETAIL https://phabricator.kde.org/D15099 AFFECTED FILES src/kpagemodel.h src/kpageview.cpp src/kpagewidgetmodel.cpp src/kpagewidgetmodel.h To: mart, #plasma, #frameworks, davidedmundson Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns
D15098: make push/pop part of ConfigModule API
This revision was automatically updated to reflect the committed changes. Closed by commit R296:abfc94c6093a: make push/pop part of ConfigModule API (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D15098?vs=40701=43276#toc REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15098?vs=40701=43276 REVISION DETAIL https://phabricator.kde.org/D15098 AFFECTED FILES src/quickaddons/configmodule.cpp src/quickaddons/configmodule.h To: mart, #plasma, davidedmundson Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns
KDE CI: Frameworks » baloo » kf5-qt5 WindowsMSVCQt5.11 - Build # 30 - Failure!
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20WindowsMSVCQt5.11/30/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 10 Oct 2018 04:23:12 + Build duration: 2 hr 50 min and counting CONSOLE OUTPUT [...truncated 113.45 KB...]-- Found KF5IdleTime: C:/CI/Software Installs/baloo/lib/cmake/KF5IdleTime/KF5IdleTimeConfig.cmake (found version "5.51.0") -- Found KF5Solid: C:/CI/Software Installs/baloo/lib/cmake/KF5Solid/KF5SolidConfig.cmake (found version "5.51.0") -- Found KF5FileMetaData: C:/CI/Software Installs/baloo/lib/cmake/KF5FileMetaData/KF5FileMetaDataConfig.cmake (found version "5.51.0") -- Found KF5Crash: C:/CI/Software Installs/baloo/lib/cmake/KF5Crash/KF5CrashConfig.cmake (found version "5.51.0") -- Found KF5KIO: C:/CI/Software Installs/baloo/lib/cmake/KF5KIO/KF5KIOConfig.cmake (found version "5.51.0") -- Found KF5: success (found suitable version "5.51.0", minimum required is "5.51.0") found components: CoreAddons Config DBusAddons I18n IdleTime Solid FileMetaData Crash KIO -- Could NOT find LMDB (missing: LMDB_LIBRARIES) -- LMDB lib: LMDB_LIBRARIES-NOTFOUND-- LMDB include: C:/Craft/CI-Qt511/windows-msvc2017_64-cl-debug/include-- Performing Test COMPILER_HAS_DEPRECATED_ATTR-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Failed-- Performing Test COMPILER_HAS_DEPRECATED-- Performing Test COMPILER_HAS_DEPRECATED - Success-- Found Doxygen: C:/Craft/CI-Qt511/windows-msvc2017_64-cl-debug/dev-utils/bin/doxygen.exe (found suitable version "1.8.14", minimum required is "1.8.13") found components: doxygen missing components: dot-- Found QHelpGenerator executable: C:/Craft/CI-Qt511/windows-msvc2017_64-cl-debug/bin/qhelpgenerator.exe-- No such target Qt5Core_QCH defined when calling ecm_add_qch(), ignored.-- No such tag file "C:/CI/Software Installs/kcoreaddons/bin/data/doc/qch/KF5CoreAddons.tags" found for KF5CoreAddons_QCH when calling ecm_add_qch().CMake Warning at C:/CI/Software Installs/baloo/share/ECM/modules/ECMAddQch.cmake:391 (message): No linking to API dox of KF5CoreAddons_QCH.Call Stack (most recent call first): C:/CI/Software Installs/baloo/share/ECM/modules/ECMAddQch.cmake:566 (_ecm_collect_linkable_qch_targets) src/lib/CMakeLists.txt:90 (ecm_add_qch)-- No such tag file "C:/CI/Software Installs/kfilemetadata/bin/data/doc/qch/KF5FileMetaData.tags" found for KF5FileMetaData_QCH when calling ecm_add_qch().CMake Warning at C:/CI/Software Installs/baloo/share/ECM/modules/ECMAddQch.cmake:391 (message): No linking to API dox of KF5FileMetaData_QCH.Call Stack (most recent call first): C:/CI/Software Installs/baloo/share/ECM/modules/ECMAddQch.cmake:566 (_ecm_collect_linkable_qch_targets) src/lib/CMakeLists.txt:90 (ecm_add_qch)-- The following features have been enabled: * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)-- The following REQUIRED packages have been found: * ECM (required version >= 5.51.0), Extra CMake Modules, * Qt5DBus * Qt5Gui (required version >= 5.11.2) * Qt5Widgets * Qt5Network (required version >= 5.11.2) * Qt5Qml * Qt5Quick * Qt5Test * Qt5 (required version >= 5.8.0) * KF5CoreAddons (required version >= 5.51.0) * KF5Config (required version >= 5.51.0) * KF5DBusAddons (required version >= 5.51.0) * Gettext * KF5I18n (required version >= 5.51.0) * KF5IdleTime (required version >= 5.51.0) * KF5Solid (required version >= 5.51.0) * KF5FileMetaData (required version >= 5.51.0) * KF5Crash (required version >= 5.51.0) * KF5KIO (required version >= 5.51.0) * KF5 (required version >= 5.51.0) * Doxygen (required version >= 1.8.13) Needed for API dox QCH file generation * QHelpGenerator, Part of Qt5 tools Needed for API dox QCH file generation * Qt5Core-- The following features have been disabled: * EXP, Build experimental features-- The following OPTIONAL packages have not been found: * Inotify Filesystem alteration notifications using inotify-- The following REQUIRED packages have not been found: * LMDB, Lightning Memory-Mapped Database (LMDB), CMake Error at C:/Craft/CI-Qt511/windows-msvc2017_64-cl-debug/dev-utils/cmake/share/cmake-3.12/Modules/FeatureSummary.cmake:459 (message): feature_summary() Error: REQUIRED package(s) are missing, aborting CMake run.Call Stack (most recent call first): CMakeLists.txt:159 (feature_summary)CMake Error: The following variables are used in this project, but they are set to NOTFOUND.Please set them or make sure they are set and tested correctly in the CMake files:LMDB_LIBRARIES (ADVANCED)linked by target "KF5BalooEngine" in directory C:/CI/workspace/Frameworks/baloo/kf5-qt5 WindowsMSVCQt5.11/src/engine-- Configuring incomplete, errors occurred!See also "C:/CI/workspace/Frameworks/baloo/kf5-qt5 WindowsMSVCQt5.11/build/CMakeFiles/CMakeOutput.log".See also "C:/CI/workspace/Frameworks/baloo/kf5-qt5 WindowsMSVCQt5.11/build/CMakeFiles/CMakeError.log".[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script
KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.9 - Build # 162 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.9/162/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 10 Oct 2018 04:28:25 + Build duration: 2 hr 32 min and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.plasma-iconitemtest Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report50% (9/18)45% (57/126)45% (57/126)39% (5180/13180)29% (2737/9444)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests93% (13/14)93% (13/14)96% (1068/1117)51% (552/1084)src.declarativeimports.calendar0% (0/6)0% (0/6)0% (0/463)0% (0/231)src.declarativeimports.core44% (7/16)44% (7/16)33% (749/2240)27% (388/1442)src.declarativeimports.plasmacomponents0% (0/6)0% (0/6)0% (0/497)0% (0/187)src.declarativeimports.plasmaextracomponents0% (0/3)0% (0/3)0% (0/42)0% (0/22)src.declarativeimports.platformcomponents0% (0/3)0% (0/3)0% (0/58)0% (0/14)src.declarativeimports.platformcomponents.utils0% (0/2)0% (0/2)0% (0/14)0% (0/2)src.plasma64% (14/22)64% (14/22)49% (1700/3505)39% (1030/2633)src.plasma.packagestructure57% (4/7)57% (4/7)37% (51/138)42% (5/12)src.plasma.private63% (12/19)63% (12/19)61% (945/1558)42% (425/1003)src.plasma.scripting67% (2/3)67% (2/3)20% (34/166)10% (13/128)src.plasmapkg0% (0/1)0% (0/1)0% (0/45)0% (0/40)src.plasmaquick27% (3/11)27% (3/11)30% (589/1977)19% (319/1702)src.plasmaquick.private50% (1/2)50% (1/2)29% (31/107)36% (5/14)src.scriptengines.qml.plasmoid17% (1/6)17% (1/6)1% (13/1098)0% (0/906)tests.dpi0% (0/2)0% (0/2)0% (0/21)0% (0/2)tests.kplugins0% (0/2)0% (0/2)0% (0/61)0% (0/16)tests.testengine0%
KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.9 - Build # 40 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.9/40/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 10 Oct 2018 04:24:53 + Build duration: 2 hr 31 min and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 40 test(s)Failed: TestSuite.ktabwidget_unittest Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report29% (4/14)43% (124/291)43% (124/291)47% (21750/45961)38% (13184/34249)Coverage Breakdown by Package Name FilesClassesLinesConditionalsdefault0% (0/1)0% (0/1)0% (0/87)0% (0/56)autotests98% (44/45)98% (44/45)98% (11469/11759)50% (7254/14375)src0% (0/1)0% (0/1)0% (0/4)0% (0/2)src.kdebugdialog0% (0/7)0% (0/7)0% (0/256)0% (0/73)src.kdecore76% (65/86)76% (65/86)53% (9506/17866)49% (5599/11459)src.kdeui19% (13/68)19% (13/68)8% (765/9694)6% (330/5364)src.kio7% (2/27)7% (2/27)0% (10/2258)0% (1/1238)src.kioslave.metainfo0% (0/1)0% (0/1)0% (0/32)0% (0/4)src.kparts0% (0/1)0% (0/1)0% (0/24)0% (0/12)src.kssl0% (0/8)0% (0/8)0% (0/1807)0% (0/853)src.kssl.kcm0% (0/3)0% (0/3)0% (0/264)0% (0/145)src.solid0% (0/3)0% (0/3)0% (0/188)0% (0/87)src.solid-networkstatus.kded0% (0/6)0% (0/6)0% (0/185)0% (0/94)tests0% (0/34)0% (0/34)0% (0/1537)0% (0/487)
KDE CI: Frameworks » knewstuff » kf5-qt5 SUSEQt5.9 - Build # 78 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.9/78/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 10 Oct 2018 04:25:42 + Build duration: 2 hr 29 min and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: TestSuite.kmoretoolstest Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report38% (5/13)17% (11/63)17% (11/63)15% (901/5957)12% (439/3554)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests100% (2/2)100% (2/2)100% (81/81)53% (38/72)autotests.kmoretools50% (1/2)50% (1/2)73% (198/273)37% (63/172)src22% (2/9)22% (2/9)2% (22/960)0% (0/376)src.attica0% (0/2)0% (0/2)0% (0/298)0% (0/231)src.core17% (3/18)17% (3/18)10% (190/1819)11% (146/1345)src.core.jobs0% (0/6)0% (0/6)0% (0/185)0% (0/83)src.kmoretools60% (3/5)60% (3/5)52% (410/796)36% (192/532)src.qtquick0% (0/5)0% (0/5)0% (0/276)0% (0/104)src.staticxml0% (0/1)0% (0/1)0% (0/169)0% (0/148)src.ui0% (0/8)0% (0/8)0% (0/745)0% (0/317)src.upload0% (0/1)0% (0/1)0% (0/121)0% (0/80)tests0% (0/3)0% (0/3)0% (0/133)0% (0/72)tests.kmoretools0% (0/1)0% (0/1)0% (0/101)0% (0/22)
KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 61 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/61/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 10 Oct 2018 04:23:18 + Build duration: 2 hr 21 min and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.scalable Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report100% (2/2)100% (6/6)100% (6/6)78% (234/300)58% (106/182)Coverage Breakdown by Package Name FilesClassesLinesConditionalsdefault100% (1/1)100% (1/1)74% (42/57)56% (10/18)autotests100% (5/5)100% (5/5)79% (192/243)59% (96/164)
D11282: less expensive findByUrl in KCoreDirListerCache
jtamate abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11282 To: jtamate, #frameworks, dfaure Cc: kde-frameworks-devel, bruns, mwolff, michaelh, ngraham
KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.11 - Build # 9 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.11/9/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Wed, 10 Oct 2018 06:04:18 + Build duration: 34 min and counting
KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.10 - Build # 67 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.10/67/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 10 Oct 2018 06:04:18 + Build duration: 10 min and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 40 test(s)Failed: TestSuite.ktabwidget_unittest Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report29% (4/14)43% (124/291)43% (124/291)47% (21615/45959)38% (13051/34249)Coverage Breakdown by Package Name FilesClassesLinesConditionalsdefault0% (0/1)0% (0/1)0% (0/87)0% (0/56)autotests98% (44/45)98% (44/45)97% (11364/11759)50% (7174/14375)src0% (0/1)0% (0/1)0% (0/4)0% (0/2)src.kdebugdialog0% (0/7)0% (0/7)0% (0/256)0% (0/73)src.kdecore76% (65/86)76% (65/86)53% (9476/17864)48% (5546/11459)src.kdeui19% (13/68)19% (13/68)8% (765/9694)6% (330/5364)src.kio7% (2/27)7% (2/27)0% (10/2258)0% (1/1238)src.kioslave.metainfo0% (0/1)0% (0/1)0% (0/32)0% (0/4)src.kparts0% (0/1)0% (0/1)0% (0/24)0% (0/12)src.kssl0% (0/8)0% (0/8)0% (0/1807)0% (0/853)src.kssl.kcm0% (0/3)0% (0/3)0% (0/264)0% (0/145)src.solid0% (0/3)0% (0/3)0% (0/188)0% (0/87)src.solid-networkstatus.kded0% (0/6)0% (0/6)0% (0/185)0% (0/94)tests0% (0/34)0% (0/34)0% (0/1537)0% (0/487)
