D16189: kio_help: Fix crash in QCoreApplication when accessing help://

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16189

To: mpyne, #frameworks, sitter
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15866: Reduce emblem size for very small icons to prevent obscuring too much of the icon

[Nathaniel Graham]

ngraham abandoned this revision.
ngraham added a comment.


  No longer needed with D15935  (or at 
least, the pressure is off).

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D15866

To: ngraham, #frameworks, #dolphin, #vdg
Cc: acrouthamel, cfeck, broulik, ndavis, kde-frameworks-devel, michaelh, 
ngraham, bruns

Re: KDE4 build question: turning off hidden visibility?

[Michael Pyne]

On Thu, Oct 11, 2018 at 12:25:32PM +0200, René J.V. Bertin wrote:
> Hi,
> 
> Please excuse me for a question that's not directly related to KF5 
> frameworks; I don't know where else to reach an audience who might know 
> (remember) the answer.
> 
> In short: how do I configure a build so it will use default (public) 
> visibility for all symbols, preferably without patching something installed 
> by kdelibs?

In theory it should be as simple as setting the option
-fvisibility=default in the CXXFLAGS used for the build in question.
This can be done in CMAKE_CXX_FLAGS, though try to do this in a way that
maintains the existing KDE settings.

Regards,
 - Michael Pyne

D16189: kio_help: Fix crash in QCoreApplication when accessing help://

[Michael Pyne]

mpyne created this revision.
mpyne added reviewers: Frameworks, sitter.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mpyne requested review of this revision.

REVISION SUMMARY
  A recent commit d428fc8e6447ede81f1e1911d0b66b39265672f3 
 
removed old custom crash handling code in favor of KCrash. But this actually 
adds a dependency on there being a valid `QCoreApplication` object (since 
KCrash uses it in its own init).
  
  I had thought this was done in kdeinit5 (which launches the kioslave) but 
that does not appear to be the case, when I looked at the sibling `kio_file` 
code, it initialized its own QCoreApplication.
  
  I took from that example to simply create the QCoreApplication here.
  
  Reported as bug 399709 .
  
  If this works I'd like to commit shortly to avoid landing a new bug in 5.51.0 
:)

TEST PLAN
  I tried running KHelpCenter as discussed in the original bug report, and 
kdeinit5 did not crash.
  
  I also tried `kioclient5 cat help:konsole` directly and still no crash.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16189

AFFECTED FILES
  src/ioslaves/help/main.cpp

To: mpyne, #frameworks, sitter
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D11236: [KCrash] Establish socket to allow change of ptrace scope

[Christoph Roick]

croick updated this revision to Diff 43560.
croick added a comment.


  - Use empty body for while loop

REPOSITORY
  R285 KCrash

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11236?vs=43020=43560

BRANCH
  ptracer

REVISION DETAIL
  https://phabricator.kde.org/D11236

AFFECTED FILES
  src/kcrash.cpp

To: croick, #frameworks, ossi
Cc: dfaure, lepagevalleeemmanuel, kde-frameworks-devel, sitter, michaelh, 
ngraham, bruns

D16183: KCrash: fix crash (ironic heh) when used in an app without QCoreApplication

[Heiko Becker]

heikobecker accepted this revision.
heikobecker added a comment.
This revision is now accepted and ready to land.


  I can confirm that the crash doesn't occur anymore.

REPOSITORY
  R285 KCrash

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16183

To: dfaure, heikobecker, aacid, sitter
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16183: KCrash: fix crash (ironic heh) when used in an app without QCoreApplication

[David Faure]

dfaure updated this revision to Diff 43555.
dfaure added a comment.


  add bug number

REPOSITORY
  R285 KCrash

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16183?vs=43553=43555

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16183

AFFECTED FILES
  src/kcrash.cpp

To: dfaure, heikobecker, aacid, sitter
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16183: KCrash: fix crash (ironic heh) when used in an app without QCoreApplication

[David Faure]

dfaure created this revision.
dfaure added reviewers: heikobecker, aacid, sitter.
Herald added a project: Frameworks.
Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks.
dfaure requested review of this revision.

REVISION SUMMARY
  For instance in kio_help. The right fix is to create a QCoreApplication
  in all kioslaves, but this commit preserves compatibility between KF 5.50
  and 5.51 after KIO's commit d428fc8e6447ede81f1e1911d0b66b39265672f3 


TEST PLAN
  Starting khelpcenter, no more core files from kio_help in my cores directory.

REPOSITORY
  R285 KCrash

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16183

AFFECTED FILES
  src/kcrash.cpp

To: dfaure, heikobecker, aacid, sitter
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16165: Don't crash on invalid exiv2 data

[Stefan Brüns]

bruns added a comment.


  In D16165#342522 , @poboiko wrote:
  
  > In D16165#342433 , @bruns wrote:
  >
  > > These three should be CCBUG: (not test file, not able to confirm fixed), 
while 375131 should be BUG: (confirmed and fixed).
  >
  >
  > Wait. Those three are about the very same crash I was able to reproduce 
(and fix) on the other test data. I'm pretty sure, looking at backtrace, they 
are due to the same reason.
  >  (It's true that, without their test data I cannot be _completely_ sure, 
but looking at age of those bugs, I don't think users will be able to provide 
their files)
  >
  > While the other one is about baloo hanging, which I wasn't able to 
reproduce, that's why it's just CC'd.
  
  
  Unfortunately 375131 is quite vague, they all speak about "baloo" hanging, 
but as "baloo" is not a single process, it is impossible to tell for sure which 
process crashes or hangs.
  
  Apparent hangs of baloo_file are easy to produce, create a file 
'baloo_file_extractor' with the following content:
  
#! /bin/bash
echo "S foobar"
  
  make it executable, and then (after killing the current baloo_file), run 
`PATH=./ /baloo_file`. When you run 
baloo_monitor, you will see it says "Indexing foobar", but will make no further 
progress as the fake extractor has exited (equivalent to a crash here).
  
  When you run baloo_file from build/bin, make sure you have the relevant 
baloo_file_extractor in the PATH first.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16165

To: poboiko, #baloo, #frameworks
Cc: bruns, astippich, kde-frameworks-devel, ashaposhnikov, michaelh, spoorun, 
ngraham, abrahams

D16165: Don't crash on invalid exiv2 data

[Igor Poboiko]

poboiko added a comment.


  In D16165#342433 , @bruns wrote:
  
  > These three should be CCBUG: (not test file, not able to confirm fixed), 
while 375131 should be BUG: (confirmed and fixed).
  
  
  Wait. Those three are about the very same crash I was able to reproduce (and 
fix) on the other test data. I'm pretty sure, looking at backtrace, they are 
due to the same reason.
  (It's true that, without their test data I cannot be _completely_ sure, but 
looking at age of those bugs, I don't think users will be able to provide their 
files)
  
  While the other one is about baloo hanging, which I wasn't able to reproduce, 
that's why it's just CC'd.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16165

To: poboiko, #baloo, #frameworks
Cc: bruns, astippich, kde-frameworks-devel, ashaposhnikov, michaelh, spoorun, 
ngraham, abrahams

D16179: compare with QLatin1String and harmonize handling of all types

[Alexander Stippich]

astippich created this revision.
astippich added reviewers: mgallien, bruns.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  small optimization and harmonization for all metadata formats in 
taglibextractor

REPOSITORY
  R286 KFileMetaData

BRANCH
  harmonize_optimize

REVISION DETAIL
  https://phabricator.kde.org/D16179

AFFECTED FILES
  src/extractors/taglibextractor.cpp

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

KDE CI: Frameworks » knewstuff » kf5-qt5 SUSEQt5.10 - Build # 121 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.10/121/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 13 Oct 2018 15:32:25 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report38%
(5/13)17%
(11/63)17%
(11/63)15%
(901/5952)12%
(439/3546)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)100%
(81/81)53%
(38/72)autotests.kmoretools50%
(1/2)50%
(1/2)74%
(198/269)38%
(63/166)src22%
(2/9)22%
(2/9)2%
(22/960)0%
(0/376)src.attica0%
(0/2)0%
(0/2)0%
(0/298)0%
(0/231)src.core17%
(3/18)17%
(3/18)10%
(190/1819)11%
(146/1345)src.core.jobs0%
(0/6)0%
(0/6)0%
(0/185)0%
(0/83)src.kmoretools60%
(3/5)60%
(3/5)52%
(410/796)36%
(192/532)src.qtquick0%
(0/5)0%
(0/5)0%
(0/276)0%
(0/104)src.staticxml0%
(0/1)0%
(0/1)0%
(0/168)0%
(0/146)src.ui0%
(0/8)0%
(0/8)0%
(0/745)0%
(0/317)src.upload0%
(0/1)0%
(0/1)0%
(0/121)0%
(0/80)tests0%
(0/3)0%
(0/3)0%
(0/133)0%
(0/72)tests.kmoretools0%
(0/1)0%
(0/1)0%
(0/101)0%
(0/22)

KDE CI: Frameworks » knewstuff » kf5-qt5 SUSEQt5.9 - Build # 80 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.9/80/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 13 Oct 2018 15:32:25 +
 Build duration:
1 min 26 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report38%
(5/13)17%
(11/63)17%
(11/63)15%
(901/5952)12%
(439/3546)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)100%
(81/81)53%
(38/72)autotests.kmoretools50%
(1/2)50%
(1/2)74%
(198/269)38%
(63/166)src22%
(2/9)22%
(2/9)2%
(22/960)0%
(0/376)src.attica0%
(0/2)0%
(0/2)0%
(0/298)0%
(0/231)src.core17%
(3/18)17%
(3/18)10%
(190/1819)11%
(146/1345)src.core.jobs0%
(0/6)0%
(0/6)0%
(0/185)0%
(0/83)src.kmoretools60%
(3/5)60%
(3/5)52%
(410/796)36%
(192/532)src.qtquick0%
(0/5)0%
(0/5)0%
(0/276)0%
(0/104)src.staticxml0%
(0/1)0%
(0/1)0%
(0/168)0%
(0/146)src.ui0%
(0/8)0%
(0/8)0%
(0/745)0%
(0/317)src.upload0%
(0/1)0%
(0/1)0%
(0/121)0%
(0/80)tests0%
(0/3)0%
(0/3)0%
(0/133)0%
(0/72)tests.kmoretools0%
(0/1)0%
(0/1)0%
(0/101)0%
(0/22)

D16145: Adapt autotest to new menu structure

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R304:34e50636dd7b: Adapt autotest to new menu structure 
(authored by nicolasfella).

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16145?vs=43433=43541

REVISION DETAIL
  https://phabricator.kde.org/D16145

AFFECTED FILES
  autotests/kmoretools/kmoretoolstest.cpp

To: nicolasfella, gregormi, dhaumann
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16165: Don't crash on invalid exiv2 data

[Stefan Brüns]

bruns added a comment.


  In D16165#342348 , @poboiko wrote:
  
  > In D16165#342156 , @astippich 
wrote:
  >
  > > I guess bugs
  > >  352856 
  > > 353848
  > > 361259
  > >  will also be fixed by this?
  >
  >
  > Yes, they should be. Thanks for the links! Added it to summary.
  
  
  These three should be CCBUG: (not test file, not able to confirm fixed), 
while 375131 should be BUG: (confirmed and fixed).

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16165

To: poboiko, #baloo, #frameworks
Cc: bruns, astippich, kde-frameworks-devel, ashaposhnikov, michaelh, spoorun, 
ngraham, abrahams

D16165: Don't crash on invalid exiv2 data

[Igor Poboiko]

poboiko added a comment.


  In D16165#342156 , @astippich 
wrote:
  
  > I guess bugs
  >  352856 
  > 353848
  > 361259
  >  will also be fixed by this?
  
  
  Yes, they should be. Thanks for the links! Added it to summary.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16165

To: poboiko, #baloo, #frameworks
Cc: bruns, astippich, kde-frameworks-devel, ashaposhnikov, michaelh, spoorun, 
ngraham, abrahams

D16165: Don't crash on invalid exiv2 data

[Igor Poboiko]

poboiko updated this revision to Diff 43526.
poboiko added a comment.


  Replaced `size()` by `count()`, which is more appropriate here

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16165?vs=43506=43526

BRANCH
  dont-crash-invalid-exiv (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16165

AFFECTED FILES
  src/extractors/exiv2extractor.cpp

To: poboiko, #baloo, #frameworks
Cc: bruns, astippich, kde-frameworks-devel, ashaposhnikov, michaelh, spoorun, 
ngraham, abrahams

D16165: Don't crash on invalid exiv2 data

[Igor Poboiko]

poboiko edited the summary of this revision.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16165

To: poboiko, #baloo, #frameworks
Cc: bruns, astippich, kde-frameworks-devel, ashaposhnikov, michaelh, spoorun, 
ngraham, abrahams

D16135: refactor tests for taglibextractor

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:2d6b448b69b0: refactor tests for taglibextractor 
(authored by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16135?vs=43490=43525

REVISION DETAIL
  https://phabricator.kde.org/D16135

AFFECTED FILES
  autotests/taglibextractortest.cpp
  autotests/taglibextractortest.h

To: astippich, mgallien, bruns, svuorela
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams