KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 438 - Unstable!

2018-10-16 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/438/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 17 Oct 2018 04:34:15 +
 Build duration:
27 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 59 test(s), Skipped: 0 test(s), Total: 60 test(s)Failed: TestSuite.kiowidgets-kdirlistertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(261/397)66%
(261/397)53%
(31972/59990)38%
(16472/43892)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(56/56)100%
(56/56)95%
(9071/9516)48%
(4255/8920)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8294/14316)50%
(4642/9259)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3894/7935)34%
(1590/4691)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(526/1023)37%
(316/850)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1364)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/144)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1769/4316)35%
(1306/3684)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1331)55%
(620/1123)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/257)7%
(14/212)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash56%
(5/9)56%
(5/9)52%
  

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size of in a File System

2018-10-16 Thread Shubham
shubham retitled this revision from "Warn user before copy/move job if required 
space exceeds the maximum volume size of a File System" to "Warn user before 
copy/move job if the file size exceeds the maximum possible file size of in a 
File System".

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16249

To: shubham, ngraham, elvisangelaccio, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in a File System

2018-10-16 Thread Shubham
shubham retitled this revision from "Warn user before copy/move job if the file 
size exceeds the maximum possible file size of in a File System" to "Warn user 
before copy/move job if the file size exceeds the maximum possible file size in 
a File System".

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16249

To: shubham, ngraham, elvisangelaccio, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D16266: [Extractor] Make extractor crash resilient

2018-10-16 Thread Stefan Brüns
bruns updated this revision to Diff 43777.
bruns added a comment.


  rebase

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16266?vs=43769=43777

BRANCH
  mimetype_handling

REVISION DETAIL
  https://phabricator.kde.org/D16266

AFFECTED FILES
  src/file/extractorprocess.cpp
  src/file/extractorprocess.h
  src/file/filecontentindexer.cpp
  src/file/filecontentindexerprovider.cpp
  src/file/filecontentindexerprovider.h

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: apol, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams


D16267: [Extractor] Improve commandline debugging, forward stderr

2018-10-16 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes.
Closed by commit R293:5ce6e8718bab: [Extractor] Improve commandline debugging, 
forward stderr (authored by bruns).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D16267?vs=43774=43776#toc

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16267?vs=43774=43776

REVISION DETAIL
  https://phabricator.kde.org/D16267

AFFECTED FILES
  src/file/extractorprocess.cpp

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams


D16267: [Extractor] Improve commandline debugging, forward stderr

2018-10-16 Thread Nathaniel Graham
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Yep, nice.

REPOSITORY
  R293 Baloo

BRANCH
  mimetype_handling

REVISION DETAIL
  https://phabricator.kde.org/D16267

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams


D16253: [Scheduler] Remove extraneous set of content indexing flag

2018-10-16 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes.
Closed by commit R293:efad0343a5c6: [Scheduler] Remove extraneous set of 
content indexing flag (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16253?vs=43757=43775

REVISION DETAIL
  https://phabricator.kde.org/D16253

AFFECTED FILES
  src/engine/writetransaction.cpp
  src/file/modifiedfileindexer.cpp

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams


D16267: [Extractor] Improve commandline debugging, forward stderr

2018-10-16 Thread Stefan Brüns
bruns created this revision.
bruns added reviewers: Baloo, Frameworks, poboiko, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  In case baloo_file is started from an interactive shell/tty, the debug
  output no longer goes to the syslog/journal, but to stderr. Make sure
  stderr does not end up in the stdin of the parent process but is forwarded.

TEST PLAN
  start baloo_file from the shell, with debugging enabled:
  `QT_LOGGING_RULES='org.kde.baloo=true' PATH=./bin ./bin/baloo_file`
  -> debug output from the extractor appears on stderr

REPOSITORY
  R293 Baloo

BRANCH
  mimetype_handling

REVISION DETAIL
  https://phabricator.kde.org/D16267

AFFECTED FILES
  src/file/extractorprocess.cpp

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams


D16253: [Scheduler] Remove extraneous set of content indexing flag

2018-10-16 Thread Nathaniel Graham
ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D16253

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams


D16256: [Scheduler] Reuse fileinfo from FilteredDirIterator

2018-10-16 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes.
Closed by commit R293:19e9edaec570: [Scheduler] Reuse fileinfo from 
FilteredDirIterator (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16256?vs=43749=43773

REVISION DETAIL
  https://phabricator.kde.org/D16256

AFFECTED FILES
  src/file/filtereddiriterator.cpp
  src/file/filtereddiriterator.h
  src/file/unindexedfileiterator.cpp

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams


D16256: [Scheduler] Reuse fileinfo from FilteredDirIterator

2018-10-16 Thread Nathaniel Graham
ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  indexer_cleanup

REVISION DETAIL
  https://phabricator.kde.org/D16256

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams


D16255: [Scheduler] Fix wrong usage of obsolete QFileInfo::created() timestamp

2018-10-16 Thread Nathaniel Graham
ngraham added a comment.


  Very nice catch! I'm afraid my brain is not big enough to review this one 
though.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D16255

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams


D16254: [Scheduler] Reuse mimetype from UnindexedFileIterator in indexer

2018-10-16 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes.
Closed by commit R293:3807fd53d935: [Scheduler] Reuse mimetype from 
UnindexedFileIterator in indexer (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16254?vs=43746=43772

REVISION DETAIL
  https://phabricator.kde.org/D16254

AFFECTED FILES
  src/file/unindexedfileindexer.cpp

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams


D16263: [Scheduler] Remove superfluous m_extractorIdle variable

2018-10-16 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes.
Closed by commit R293:a8f03d1a374a: [Scheduler] Remove superfluous 
m_extractorIdle variable (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16263?vs=43767=43771

REVISION DETAIL
  https://phabricator.kde.org/D16263

AFFECTED FILES
  src/file/extractorprocess.cpp
  src/file/extractorprocess.h

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams


D16254: [Scheduler] Reuse mimetype from UnindexedFileIterator in indexer

2018-10-16 Thread Nathaniel Graham
ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  indexer_cleanup

REVISION DETAIL
  https://phabricator.kde.org/D16254

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams


D16263: [Scheduler] Remove superfluous m_extractorIdle variable

2018-10-16 Thread Nathaniel Graham
ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D16263

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams


D16197: provide a list of supported mimetypes for embeddedimagedata

2018-10-16 Thread Stefan Brüns
bruns requested changes to this revision.
bruns added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> embeddedimagedatatest.cpp:48
> +testAudioFile = testFilePath("test.opus");
> +
> QCOMPARE(imageData.readMimetypes().contains(mimeDb.mimeTypeForFile(testAudioFile).name()),true);
> +images = imageData.imageData(testAudioFile);

QVERIFY(condition)

> embeddedimagedata.cpp:73
>  
> +QStringList EmbeddedImageData::readMimetypes() const
> +{

`supportedMimeTypes()` ?
capital `T`, see `ImageType` and `QMimeType`

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16197

To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams


D16266: [Extractor] Make extractor crash resilient

2018-10-16 Thread Stefan Brüns
bruns updated this revision to Diff 43769.
bruns marked 2 inline comments as done.
bruns added a comment.


  coding style

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16266?vs=43768=43769

BRANCH
  mimetype_handling

REVISION DETAIL
  https://phabricator.kde.org/D16266

AFFECTED FILES
  src/file/extractorprocess.cpp
  src/file/extractorprocess.h
  src/file/filecontentindexer.cpp
  src/file/filecontentindexerprovider.cpp
  src/file/filecontentindexerprovider.h

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: apol, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams


D16266: [Extractor] Make extractor crash resilient

2018-10-16 Thread Stefan Brüns
bruns marked 3 inline comments as done.
bruns added inline comments.

INLINE COMMENTS

> apol wrote in extractorprocess.cpp:35
> Shouldn't it check the exitCode too?

the exitCode is "only valid for normal exits" (Qt docu 
), and 0 otherwise.

> apol wrote in extractorprocess.cpp:54
> Do you really need to waitForStarted?

Copied from the old code. Should not hurt, as done from a runner thread.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D16266

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: apol, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams


D15960: Don't check if file is directory based on mime-type

2018-10-16 Thread Stefan Brüns
bruns added a comment.


  The reference to `QDirIterator` is misleading, as it applies only to the 
`UnIndexedFileIterator`, the `ModifiedFileIndexer` just receives paths.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15960

To: poboiko, #baloo, #frameworks
Cc: bruns, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, abrahams


D16266: [Extractor] Make extractor crash resilient

2018-10-16 Thread Aleix Pol Gonzalez
apol added inline comments.

INLINE COMMENTS

> extractorprocess.cpp:35
> +connect(_extractorProcess, QOverload QProcess::ExitStatus>::of(::finished),
> +[=](int exitCode, QProcess::ExitStatus exitStatus)
> +{

Shouldn't it check the exitCode too?

> extractorprocess.cpp:54
> +m_extractorProcess.start(QIODevice::Unbuffered | QIODevice::ReadWrite);
> +m_extractorProcess.waitForStarted();
> +m_extractorProcess.setReadChannel(QProcess::StandardOutput);

Do you really need to waitForStarted?

> filecontentindexer.cpp:74
>  
> +bool hadErrors{false};
> +connect(, ::failed, , [, 
> ]() { hadErrors = true; loop.quit(); });

`= false;`

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D16266

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: apol, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams


D15795: Fix warnings about deprecated install dirs

2018-10-16 Thread Stefan Brüns
bruns resigned from this revision.
bruns added a comment.


  sorry, busy with other stuff

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D15795

To: dinoh, apol, dfaure
Cc: ltoscano, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns


D16249: Warn user before copy/move job if required space exceeds the maximum volume size of a File System

2018-10-16 Thread Nathaniel Graham
ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Thanks for this patch! There are a few things:
  
  1. Let's check for this condition before doing a check for whether there's 
enough free space on the disk, or else it will report a less-useful error 
message first (people could go try to make some space, only to discover that 
the filesystem doesn't even support copying a file that big)
  2. `ERR_DISK_FULL` will not display an accurate error message. Perhaps we 
should define a new type of error message in `src/core/job_error.cpp` to handle 
this. Something like `ERR_TOO_LARGE_FOR_FAT32` that has an appropriate error 
message; something like "The file  cannot be transferred because it is 
greater than 4 Gb in size, and the destination's filesystem does not support 
files that large."
  3. There's a `TODO` in this file about implementing this; please remove it.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16249

To: shubham, ngraham, elvisangelaccio, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D16266: [Extractor] Make extractor crash resilient

2018-10-16 Thread Stefan Brüns
bruns created this revision.
bruns added reviewers: Baloo, Frameworks, poboiko, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Connect to QProcess::finished to detect the exit status. In case the
  process has crashed, signal the indexer.
  
  On a crash, restart the process and feed it a smaller batch. If the
  crashing batch contains only a single file, mark the file as failed, i.e.
  add it to the "failedid" db and remove it from the content indexing db
  to avoid further indexing attempts.
  
  CCBUG: 375131

TEST PLAN
  start `balooctl monitor`
  add a file known to crash the extractor to an indexable path
  touch an unproblematic file
  -> indexer crashes on first file and continues with the second

REPOSITORY
  R293 Baloo

BRANCH
  mimetype_handling

REVISION DETAIL
  https://phabricator.kde.org/D16266

AFFECTED FILES
  src/file/extractorprocess.cpp
  src/file/extractorprocess.h
  src/file/filecontentindexer.cpp
  src/file/filecontentindexerprovider.cpp
  src/file/filecontentindexerprovider.h

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams


D16263: [Scheduler] Remove superfluous m_extractorIdle variable

2018-10-16 Thread Stefan Brüns
bruns updated this revision to Diff 43767.
bruns added a comment.


  add missing line to patch

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16263?vs=43762=43767

REVISION DETAIL
  https://phabricator.kde.org/D16263

AFFECTED FILES
  src/file/extractorprocess.cpp
  src/file/extractorprocess.h

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams


D16265: [Scheduler] Use flag to track when a runner is going idle

2018-10-16 Thread Stefan Brüns
bruns updated this revision to Diff 43766.
bruns added a comment.


  rebase

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16265?vs=43765=43766

REVISION DETAIL
  https://phabricator.kde.org/D16265

AFFECTED FILES
  src/file/fileindexscheduler.cpp
  src/file/fileindexscheduler.h

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams


D16265: [Scheduler] Use flag to track when a runner is going idle

2018-10-16 Thread Stefan Brüns
bruns created this revision.
bruns added reviewers: Baloo, Frameworks, poboiko, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Only one runner should be queued/running at a given time, but the current
  condition "m_threadPool.activeThreadCount == 0" is to strong, as the
  done() signal is fired from the runner thread while it is still alive and
  may be processed before the thread has exited.
  
  Set a flag when the runner is finished, and use this to guard from
  scheduling/enqueuing multiple runners. It is fine to enqueue another
  runner while the old is cleaning up, the new one will become active
  afterwards.
  
  Alternative approach to D15959 .

TEST PLAN
  start `balooctl monitor~
  touch a file -> file is indexed, scheduler goes idle afterwards
  touch multiple files, new files -> indexing, idle

REPOSITORY
  R293 Baloo

BRANCH
  mimetype_handling

REVISION DETAIL
  https://phabricator.kde.org/D16265

AFFECTED FILES
  src/file/fileindexscheduler.cpp
  src/file/fileindexscheduler.h

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams


D16263: [Scheduler] Remove superfluous m_extractorIdle variable

2018-10-16 Thread Stefan Brüns
bruns created this revision.
bruns added reviewers: Baloo, Frameworks, poboiko, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Having the variable is quite pointless, as hardly anyone runs baloo
  with compiled with Q_ASSERT enabled.

TEST PLAN
  make
  no functional change

REPOSITORY
  R293 Baloo

BRANCH
  mimetype_handling

REVISION DETAIL
  https://phabricator.kde.org/D16263

AFFECTED FILES
  src/file/extractorprocess.cpp
  src/file/extractorprocess.h

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams


D15763: Set correct image attributes on directory thumbnail

2018-10-16 Thread Nathaniel Graham
ngraham added a comment.


  +1 from me too.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D15763

To: broulik, #frameworks, dfaure, anthonyfieroni, jtamate
Cc: ngraham, kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, 
navarromorales, firef, andrebarros, bruns, emmanuelp


D16253: [Scheduler] Remove extraneous set of content indexing flag

2018-10-16 Thread Stefan Brüns
bruns edited the summary of this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D16253

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams


D16253: [Scheduler] Remove extraneous set of content indexing flag

2018-10-16 Thread Stefan Brüns
bruns updated this revision to Diff 43757.
bruns added a comment.


  also write the id in replaceDocument, not only addDocument

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16253?vs=43745=43757

REVISION DETAIL
  https://phabricator.kde.org/D16253

AFFECTED FILES
  src/engine/writetransaction.cpp
  src/file/modifiedfileindexer.cpp

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams


D7423: [WIP/assistance needed] Populate UDS_CREATION_TIME on Linux if statx system call is available

2018-10-16 Thread Stefan Brüns
bruns added a comment.


  birthTime is supported by QTs QFileInfo::birthTime().
  For the implementation, see here:
  
https://code.woboq.org/qt5/qtbase/src/corelib/io/qfilesystemengine_unix.cpp.html#329

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7423

To: ngraham, dfaure, broulik, elvisangelaccio, #frameworks, #dolphin, fvogt
Cc: huftis, dakon, fvogt, kde-frameworks-devel, bruns, meven, ltoscano, 
#frameworks, michaelh, ngraham


D16255: [Scheduler] Fix wrong usage of obsolete QFileInfo::created() timestamp

2018-10-16 Thread Stefan Brüns
bruns edited the summary of this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D16255

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams


D16255: [Scheduler] Fix wrong usage of obsolete QFileInfo::created() timestamp

2018-10-16 Thread Stefan Brüns
bruns edited the summary of this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D16255

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams


D16256: [Scheduler] Reuse fileinfo from FilteredDirIterator

2018-10-16 Thread Stefan Brüns
bruns created this revision.
bruns added reviewers: Baloo, Frameworks, poboiko, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The FilteredDirIterator already builds a QFileInfo for every returned
  path, just reuse it instead of constructing another one.

TEST PLAN
  make
  no functional changes

REPOSITORY
  R293 Baloo

BRANCH
  indexer_cleanup

REVISION DETAIL
  https://phabricator.kde.org/D16256

AFFECTED FILES
  src/file/filtereddiriterator.cpp
  src/file/filtereddiriterator.h
  src/file/unindexedfileiterator.cpp

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams


D16255: [Scheduler] Fix wrong usage of obsolete QFileInfo::created() timestamp

2018-10-16 Thread Stefan Brüns
bruns created this revision.
bruns added reviewers: Baloo, Frameworks, poboiko, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Baloo uses the metadata change time (stat.st_ctime, man 7 inode) to check
  for XAttr updates. This field corresponds to
  QFileInfo::metadataChangeTime(), while created() returns the first
  available of [birthtime, ctime, mtime].
  
  On filesystems supporting birthtime (XFS, BTRFS) some files were
  continously reindexed as the BasicIndexingJob stored the ctime, while the
  UnindexedFileIterator compared the stored value with the btime. On the
  other hand, XAttr changes where not detected when ctime and btime
  initially matched, as the btime is fixed.
  
  While at it, document the semantics of the two timestamps.

TEST PLAN
  1. watch baloo_file with strace -efile during startup -> files with btime != 
ctime are indexed just once
  2. add a Tag to a file -> file is immediately updated in index, not just 
after baloo_file restart (e.g. session restart)

REPOSITORY
  R293 Baloo

BRANCH
  indexer_cleanup

REVISION DETAIL
  https://phabricator.kde.org/D16255

AFFECTED FILES
  src/engine/documenttimedb.h
  src/file/basicindexingjob.cpp
  src/file/modifiedfileindexer.cpp
  src/file/unindexedfileiterator.cpp

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams


D16254: [Scheduler] Reuse mimetype from UnindexedFileIterator in indexer

2018-10-16 Thread Stefan Brüns
bruns created this revision.
bruns added reviewers: Baloo, Frameworks, poboiko, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The mimetype is already determined in the iterator, no need to do it
  again.

REPOSITORY
  R293 Baloo

BRANCH
  indexer_cleanup

REVISION DETAIL
  https://phabricator.kde.org/D16254

AFFECTED FILES
  src/file/unindexedfileindexer.cpp

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams


D16253: [Scheduler] Remove extraneous set of content indexing flag

2018-10-16 Thread Stefan Brüns
bruns created this revision.
bruns added reviewers: Baloo, Frameworks, poboiko, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The content indexing flag is already set by the BasicIndexingJob::index()
  in ModifiedFileIndexer::run() executed previously, no need to start
  another write transaction. Also, the flag is also set when the config
  only specifies BasicIndexing, i.e. content indexing was always done.

REPOSITORY
  R293 Baloo

BRANCH
  indexer_cleanup

REVISION DETAIL
  https://phabricator.kde.org/D16253

AFFECTED FILES
  src/file/modifiedfileindexer.cpp

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams


D16167: Instead of copying and clearing the file list, just move it

2018-10-16 Thread Stefan Brüns
bruns added a comment.


  `auto runnable = new NewFileIndexer(m_db, m_config, std::exchange(m_newFiles, 
{}));` would work, but that is C++14

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D16167

To: bruns, #baloo, #frameworks, poboiko
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams


D16167: Instead of copying and clearing the file list, just move it

2018-10-16 Thread Stefan Brüns
bruns abandoned this revision.
bruns added a comment.


  Does not work as wanted, as the compiler squeezes in a QStringList copy 
construction and the moves the temporary. Afterwards the temporary is empty(), 
but the filelist is not.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D16167

To: bruns, #baloo, #frameworks, poboiko
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams


D16250: Use lambdas instead of std::bind()

2018-10-16 Thread Alexander Volkov
volkov added a comment.


  @davidedmundson
  
  Lambdas are more readable.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D16250

To: volkov, #kwin
Cc: bruns, davidedmundson, ivan, kde-frameworks-devel, michaelh, ngraham


D16249: Warn user before copy/move job if required space exceeds the maximum volume size of a File System

2018-10-16 Thread Shubham
shubham added a reviewer: Frameworks.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16249

To: shubham, ngraham, elvisangelaccio, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D16250: Use lambdas instead of std::bind()

2018-10-16 Thread Ivan Čukić
ivan added a comment.


  @davidedmundson
  
  Lambdas are generally faster to compile and execute. `std::bind` can make 
code less verbose, but that is not the case here.
  
  @bruns
  
  Well... Qt has quite a few strange guidelines that we don't follow :)

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D16250

To: volkov, #kwin
Cc: bruns, davidedmundson, ivan, kde-frameworks-devel, michaelh, ngraham


D16250: Use lambdas instead of std::bind()

2018-10-16 Thread Stefan Brüns
bruns added a comment.


  In D16250#344183 , @ivan wrote:
  
  > The parentheses are not necessary when a lambda has no arguments.
  >
  >   [something]() { ::: }
  >   
  >
  > can become:
  >
  >   [something] { ::: }
  >   
  >   
  >
  > KWin uses both of these from what I've seen. Personally, I prefer the 
second.
  >
  > Otherwise, +1 for the change.
  
  
  Qt coding style  mandates the 
first

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D16250

To: volkov, #kwin
Cc: bruns, davidedmundson, ivan, kde-frameworks-devel, michaelh, ngraham


D16250: Use lambdas instead of std::bind()

2018-10-16 Thread David Edmundson
davidedmundson added a comment.


  > Use lambdas instead of std::bind()
  
  Why?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D16250

To: volkov, #kwin
Cc: davidedmundson, ivan, kde-frameworks-devel, michaelh, ngraham, bruns


D16250: Use lambdas instead of std::bind()

2018-10-16 Thread Ivan Čukić
ivan added a comment.


  The parentheses are not necessary when a lambda has no arguments.
  
[something]() { ::: }
  
  can become:
  
[something] { ::: }
  
  KWin uses both of these from what I've seen. Personally, I prefer the second.
  
  Otherwise, +1 for the change.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D16250

To: volkov, #kwin
Cc: ivan, kde-frameworks-devel, michaelh, ngraham, bruns


D16250: Use lambdas instead of std::bind()

2018-10-16 Thread Alexander Volkov
volkov added a reviewer: KWin.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D16250

To: volkov, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D16250: Use lambdas instead of std::bind()

2018-10-16 Thread Alexander Volkov
volkov created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
volkov requested review of this revision.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16250

AFFECTED FILES
  src/server/idle_interface.cpp
  src/server/pointerconstraints_interface.cpp

To: volkov
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D16249: Warn user before copy/move job if required space exceeds the maximum volume size of a File System

2018-10-16 Thread Shubham
shubham added a reviewer: elvisangelaccio.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16249

To: shubham, ngraham, elvisangelaccio
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D16165: Don't crash on invalid exiv2 data

2018-10-16 Thread Igor Poboiko
This revision was automatically updated to reflect the committed changes.
Closed by commit R286:5eee9ac75b7d: Dont crash on invalid exiv2 data 
(authored by poboiko).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16165?vs=43526=43736

REVISION DETAIL
  https://phabricator.kde.org/D16165

AFFECTED FILES
  src/extractors/exiv2extractor.cpp

To: poboiko, #baloo, #frameworks, astippich
Cc: bruns, astippich, kde-frameworks-devel, ashaposhnikov, michaelh, spoorun, 
ngraham, abrahams


D16249: Warn user before copy/move job if required space exceeds the maximum volume size of a File System

2018-10-16 Thread Shubham
shubham edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16249

To: shubham, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D16249: Warn user before copy/move job if required space exceeds the maximum volume size of a File System

2018-10-16 Thread Shubham
shubham created this revision.
shubham added a reviewer: ngraham.
shubham added a project: Frameworks.
Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks.
shubham requested review of this revision.

REVISION SUMMARY
  BUG: 198772

TEST PLAN
  1.Prepare copy/move job.
  
  2. Copy/move the contents to external USB drive/ Pen drive
  
  Result: Inline error message appears.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16249

AFFECTED FILES
  src/core/copyjob.cpp

To: shubham, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D12820: Add KWayland virtual desktop protocol

2018-10-16 Thread David Edmundson
davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R127 KWayland

BRANCH
  mart/plasmavirtualdesktop

REVISION DETAIL
  https://phabricator.kde.org/D12820

To: mart, #kwin, #plasma, graesslin, hein, davidedmundson
Cc: davidedmundson, zzag, bshah, romangg, kde-frameworks-devel, michaelh, 
ngraham, bruns


D15763: Set correct image attributes on directory thumbnail

2018-10-16 Thread Anthony Fieroni
anthonyfieroni added a comment.


  +1

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D15763

To: broulik, #frameworks, dfaure, anthonyfieroni, jtamate
Cc: kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp


D15510: Introduce HKDF

2018-10-16 Thread Alexander Volkov
volkov added a comment.


  D16248 

REPOSITORY
  R486 QCA Library

REVISION DETAIL
  https://phabricator.kde.org/D15510

To: volkov, iromanov, sitter, #frameworks, dfaure
Cc: bcooksley, dfaure


D15510: Introduce HKDF

2018-10-16 Thread Ben Cooksley
bcooksley added a comment.


  This has made the FreeBSD CI builds unhappy unfortunately:
  
https://build.kde.org/view/Failing/job/Administration/job/Dependency%20Build%20Applications%20stable-kf5-qt5%20FreeBSDQt5.11/15/console
  
  Due to various issues, QCA isn't built on the Linux CI systems so there may 
be other issues there which only packagers will hit when this is released.

REPOSITORY
  R486 QCA Library

REVISION DETAIL
  https://phabricator.kde.org/D15510

To: volkov, iromanov, sitter, #frameworks, dfaure
Cc: bcooksley, dfaure


D12820: Add KWayland virtual desktop protocol

2018-10-16 Thread Marco Martin
mart added a comment.


  In D12820#297896 , @mart wrote:
  
  > RFC: add back some info for the layout? (in particular: rows and 
orientation, tought orientation is a bit concerning as is view-spacific)
  
  
  it was decided no, we care only about the order

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D12820

To: mart, #kwin, #plasma, graesslin, hein
Cc: davidedmundson, zzag, bshah, romangg, kde-frameworks-devel, michaelh, 
ngraham, bruns