KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.10 - Build # 121 - Unstable!

2018-10-20 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.10/121/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 21 Oct 2018 03:50:42 + Build duration: 19 min and counting JUnit Tests Name: (root) Failed: 1

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 289 - Unstable!

2018-10-20 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/289/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sun, 21 Oct 2018 03:50:13 + Build duration: 20 min and counting JUnit Tests Name: (root) Failed: 1

KDE CI: Frameworks » purpose » kf5-qt5 FreeBSDQt5.11 - Build # 19 - Failure!

2018-10-20 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20FreeBSDQt5.11/19/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Sun, 21 Oct 2018 03:50:42 + Build duration: 3 min 44 sec and counting CONSOLE OUTPUT

D16265: [Scheduler] Use flag to track when a runner is going idle

2018-10-20 Thread Stefan Brüns
bruns marked an inline comment as done. bruns added inline comments. INLINE COMMENTS > poboiko wrote in fileindexscheduler.h:57 > But the very same check is already in the first line of `scheduleIndexing`, > why do we need it also here? Not strictly necessary, but avoids to schedule a timer we

D16344: Do not try to fallback to "less secure" protocols

2018-10-20 Thread Albert Astals Cid
aacid added subscribers: stikonas, dfaure, carewolf. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16344 To: aacid Cc: carewolf, dfaure, stikonas, kde-frameworks-devel, michaelh, ngraham, bruns

D16344: Do not try to fallback to "less secure" protocols

2018-10-20 Thread Albert Astals Cid
aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY Both Firefox and Chrom[e|ium] do this for a while so most sites have already make sure they are better compliant than

D14948: Port scriptabletags to QJSEngine

2018-10-20 Thread Allan Sandfeld Jensen
carewolf added a comment. Yes, he promised to look at it later, but he never got back to me. Maybe I should poke him REVISION DETAIL https://phabricator.kde.org/D14948 To: carewolf, dhaumann, skelly Cc: vkrause, skelly, dhaumann, kde-frameworks-devel

D16018: Fix align of doxygen comments

2018-10-20 Thread Dominik Haumann
dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Well, make test works for me, and if this fixes the issue for you, I'm fine with that. Locally, I had to resolve one hunk that did not apply. Maybe you have to update the patch

D14948: Port scriptabletags to QJSEngine

2018-10-20 Thread Dominik Haumann
dhaumann added a comment. Did you followup on this with @skelly ? REVISION DETAIL https://phabricator.kde.org/D14948 To: carewolf, dhaumann, skelly Cc: vkrause, skelly, dhaumann, kde-frameworks-devel

D16338: Improve R documentation highlighting

2018-10-20 Thread Aaron Puchert
aaronpuchert added a comment. Thanks for the quick review! REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D16338 To: aaronpuchert, cullmann, dhaumann Cc: kwrite-devel, kde-frameworks-devel, #framework_syntax_highlighting, michaelh, ngraham, bruns,

D16338: Improve R documentation highlighting

2018-10-20 Thread Aaron Puchert
This revision was automatically updated to reflect the committed changes. Closed by commit R216:445a3e9ccf52: Improve R documentation highlighting (authored by aaronpuchert). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16338?vs=43984=43991

D16265: [Scheduler] Use flag to track when a runner is going idle

2018-10-20 Thread Stefan Brüns
bruns added a comment. So now we just need someone who accepts it  REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D16265 To: bruns, #baloo, #frameworks, poboiko, ngraham Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D16338: Improve R documentation highlighting

2018-10-20 Thread Dominik Haumann
dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Looks good to me, please commit. REPOSITORY R216 Syntax Highlighting BRANCH improve-rdoc REVISION DETAIL https://phabricator.kde.org/D16338 To: aaronpuchert, cullmann, dhaumann

D16338: Improve R documentation highlighting

2018-10-20 Thread Aaron Puchert
aaronpuchert created this revision. aaronpuchert added reviewers: cullmann, dhaumann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. aaronpuchert requested review of this revision. REVISION SUMMARY After trying out the highlighting on a

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.9 - Build # 65 - Fixed!

2018-10-20 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.9/65/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sat, 20 Oct 2018 15:43:02 + Build duration: 8 min 42 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.9 - Build # 64 - Unstable!

2018-10-20 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.9/64/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sat, 20 Oct 2018 15:38:31 + Build duration: 4 min 30 sec and counting JUnit Tests Name: (root)

D16294: [test/xdgtest] Create/destroy popup on click

2018-10-20 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R127:99d8548a1c8c: [test/xdgtest] Create/destroy popup on click (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D16294?vs=43855=43976#toc REPOSITORY R127 KWayland

D16318: [xdgshell] Add positioner constraint adjustment flag operators

2018-10-20 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R127:706ec10c7172: [xdgshell] Add positioner constraint adjustment flag operators (authored by davidedmundson). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

D7909: Add syntax support for Crystal Programming Language

2018-10-20 Thread Christoph Cullmann
cullmann added a comment. Ping? ;=) REPOSITORY R40 Kate REVISION DETAIL https://phabricator.kde.org/D7909 To: faguilar, dhaumann, vkrause, #framework_syntax_highlighting, #kate, mwolff, cullmann Cc: kwrite-devel, oprypin, mwolff, cullmann, ngraham, #kate, #frameworks, faguilar,

D16018: Fix align of doxygen comments

2018-10-20 Thread Christoph Cullmann
cullmann added a reviewer: dhaumann. cullmann added a comment. Dominik is more well versed in cstyle.js ;=) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D16018 To: buschinski, #ktexteditor, dhaumann Cc: kdevelop-devel, cullmann, kwrite-devel,

D14632: keyword rule: Spport for keywords inclusion from another language/file

2018-10-20 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Then I would say this should go in. We can improve the internals afterwards. The XML files should get a version raise and kateversion raise, I assume, before commiting. REPOSITORY

D14632: keyword rule: Spport for keywords inclusion from another language/file

2018-10-20 Thread Volker Krause
vkrause added a comment. In D14632#346319 , @cullmann wrote: > Volker, have you any objections to have this feature? I'm all for it, seeing how much duplication it removes :) REPOSITORY R216 Syntax Highlighting REVISION DETAIL

D14632: keyword rule: Spport for keywords inclusion from another language/file

2018-10-20 Thread Christoph Cullmann
cullmann added a reviewer: vkrause. cullmann added a comment. Just played a bit with it. Seems to work reasonable well :) As the only visible change for the outside is the XML addition to the keyword list, I think we might even just improve the internal API later. Nothing of it is

D15959: Wait for the extraction process to finish before scheduling

2018-10-20 Thread Igor Poboiko
poboiko abandoned this revision. poboiko added a comment. Dropped in favor of D16265: [Scheduler] Use flag to track when a runner is going idle , which handles this problem better. REPOSITORY R293 Baloo REVISION DETAIL

D16265: [Scheduler] Use flag to track when a runner is going idle

2018-10-20 Thread Igor Poboiko
poboiko added a comment. I like it, it's better than D15959: Wait for the extraction process to finish before scheduling . And it seems to be working, as far as I can see :) INLINE COMMENTS > fileindexscheduler.h:57 > m_newFiles << file; >

D16266: [Extractor] Make extractor crash resilient

2018-10-20 Thread Igor Poboiko
poboiko added inline comments. INLINE COMMENTS > bruns wrote in filecontentindexer.cpp:91 > But it is racy - if the file is replaced in the meantime, inode and filename > no longer match. This is not completely unlikely when dealing with temporary > files. > > It would make the code also