D16347: Expose KTextEditor::ViewPrivate:setInputMode(InputMode) to KTextEditor::View

2018-10-21 Thread Christoph Cullmann
cullmann added a comment. Ah, sorry, BC meant "binary compatible", see e.g. https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B For the linking, on first glance, the change looks ok and should link. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricat

D16366: Fix crash with icon dialog

2018-10-21 Thread Anthony Fieroni
anthonyfieroni added a comment. https://phabricator.kde.org/source/kiconthemes/browse/master/src/kicondialog.cpp;fea52a4f204fd44d9a45e78a663964c326687e33$419 It should be const QString fileName2 = path2.mid(path2.lastIndexOf(QLatin1Char('/')) + 1); no? REPOSITORY R302 KIconTh

D16366: Fix crash with icon dialog

2018-10-21 Thread Christoph Feck
cfeck changed the visibility from "Only User: cfeck (Christoph Feck)" to "Public (No Login Required)". Herald added a subscriber: kde-frameworks-devel. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D16366 To: cfeck, #frameworks Cc: kde-frameworks-devel, #frameworks

D7849: Fix the tray icon scaling on HiDPI screens

2018-10-21 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks. This does not actually compile for me against current git master: /home/dev/repos/plasma-framew

D16137: Add an option to KConfigDialog to fit page contents horizontally

2018-10-21 Thread Nathaniel Graham
ngraham added a comment. In D16137#346032 , @kadabash wrote: > Vertical fitting only occurs on displays that Qt deems large enough. > Displays that are just high enough to fit the content vertically > are apparently sometimes not considered

D16347: Expose KTextEditor::ViewPrivate:setInputMode(InputMode) to KTextEditor::View

2018-10-21 Thread Sébastien D .
demsking added a comment. Thanks @cullmann for your review. Just one question: what do you mean about **BE**. I'm not a native so I'm not sure what it mean. I tried to do that without virtual function like `setScrollPosition()` but there is a linking issue when trying to compile an ex

D16018: Fix align of doxygen comments in templates

2018-10-21 Thread Dominik Haumann
dhaumann added a comment. Yes, in KDE Frameworks, there is only a master branch. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D16018 To: buschinski, #ktexteditor, dhaumann Cc: cullmann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, sar

D15927: Use specified Perl interpreter instead of relying on PATH

2018-10-21 Thread Luigi Toscano
This revision was automatically updated to reflect the committed changes. Closed by commit R238:1caa28ea5614: Use specified Perl interpreter instead of relying on PATH (authored by zrax, committed by ltoscano). REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D

KDE CI: Frameworks » kdoctools » kf5-qt5 SUSEQt5.10 - Build # 58 - Still Unstable!

2018-10-21 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdoctools/job/kf5-qt5%20SUSEQt5.10/58/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 21 Oct 2018 15:14:13 + Build duration: 59 sec and counting JUnit Tests Name: (root) Failed: 1

D16018: Fix align of doxygen comments in templates

2018-10-21 Thread Bernd Buschinski
buschinski closed this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D16018 To: buschinski, #ktexteditor, dhaumann Cc: cullmann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, sars, dhaumann

D16350: Allow KHelpCenter to open the right pages of KDE help when KHelpClient is invoked with an anchor

2018-10-21 Thread Yuri Chornoivan
yurchor created this revision. yurchor added reviewers: Documentation, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. yurchor requested review of this revision. REVISION SUMMARY The current KDE help is built up to contain the anchors to its topic

D16349: [kdirlistertest] Wait a little longer for the lister to finish

2018-10-21 Thread Jaime Torres Amate
jtamate created this revision. jtamate added reviewers: dfaure, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jtamate requested review of this revision. REVISION SUMMARY Wait a little longer and let m_dirLister finish before checking it has fin

D16347: Expose KTextEditor::ViewPrivate:setInputMode(InputMode) to KTextEditor::View

2018-10-21 Thread Christoph Cullmann
cullmann requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D16347 To: demsking, kossebau, mlaurent, vkrause, dhaumann, cullmann Cc: cullmann, kwrite-devel, kde-frameworks-devel, michaelh,

D16347: Expose KTextEditor::ViewPrivate:setInputMode(InputMode) to KTextEditor::View

2018-10-21 Thread Christoph Cullmann
cullmann added a comment. I think having API for this is good, but it must be done without a virtual function, that is not BC. See e.g. setScrollPosition for how to do that. One could add a KF6 TODO to make it virtual. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator

D16018: Fix align of doxygen comments in templates

2018-10-21 Thread Bernd Buschinski
buschinski updated this revision to Diff 44010. buschinski retitled this revision from "Fix align of doxygen comments" to "Fix align of doxygen comments in templates". buschinski removed a project: KDevelop. buschinski removed a subscriber: kdevelop-devel. buschinski added a comment. - updated

D16347: Expose KTextEditor::ViewPrivate:setInputMode(InputMode) to KTextEditor::View

2018-10-21 Thread Sébastien D .
demsking added a reviewer: dhaumann. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D16347 To: demsking, kossebau, mlaurent, vkrause, dhaumann Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D16018: Fix align of doxygen comments

2018-10-21 Thread Bernd Buschinski
buschinski added a comment. Thx for the review :) I will update the patch (and post it here again). I can commit it myself, to master? or any special branch? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D16018 To: buschinski, #ktexteditor, dhaumann Cc: kd

D16347: Expose KTextEditor::ViewPrivate:setInputMode(InputMode) to KTextEditor::View

2018-10-21 Thread Sébastien D .
demsking created this revision. demsking added reviewers: kossebau, mlaurent, vkrause. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. demsking requested review of this revision. REVISION SUMMARY This makes possible to change the View Input

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 290 - Fixed!

2018-10-21 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/290/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sun, 21 Oct 2018 07:39:57 + Build duration: 31 min and counting JUnit Tests Name: (root) Failed: 0 test(s)