D16415: Creating new syntax highlighting file for Job Control Language (JCL)

2018-10-25 Thread Dominik Haumann
dhaumann requested changes to this revision. dhaumann added a comment. This revision now requires changes to proceed. Please add a small test file and explain what this highlighting language is used for :) INLINE COMMENTS > jcl.xml:3 > + > + extensions="*.JCL;*.jcl" mimetype=""> > +

D16416: z/OS CLIST file syntax highlighting

2018-10-25 Thread Dominik Haumann
dhaumann requested changes to this revision. dhaumann added a comment. This revision now requires changes to proceed. Could you explain what CLIST is used for? Please add a small test file that is also MIT licensed. INLINE COMMENTS > clist.xml:3 > + > + extensions="*.clist;*.CLIST"

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

2018-10-25 Thread Laurent Montel
mlaurent requested changes to this revision. mlaurent added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > batchrenamedialog.cpp:40 > +#include > +#include > +#include remove QtWidget > batchrenamedialog.cpp:41 > +#include > +#include > + remove QtGui

D16421: Improve emblem contrast, legibility and consistency

2018-10-25 Thread Noah Davis
ndavis updated this revision to Diff 44230. ndavis added a comment. Make emblem-question symbol thicker REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16421?vs=44211=44230 BRANCH emblem-outlines (branched from master) REVISION DETAIL

D16421: Improve emblem contrast, legibility and consistency

2018-10-25 Thread Noah Davis
ndavis added a comment. In D16421#348702 , @ngraham wrote: > Does this problem still happen after you delete your icon cache? (`rm ~/.cache/icon-cache.kcache`) Yes. REPOSITORY R266 Breeze Icons REVISION DETAIL

D16421: Improve emblem contrast, legibility and consistency

2018-10-25 Thread Nathaniel Graham
ngraham added a comment. In D16421#348664 , @ndavis wrote: > How is this? > F6356555: Screenshot_20181025_193720.png Much better! That looks great. In D16421#348675

D16421: Improve emblem contrast, legibility and consistency

2018-10-25 Thread Noah Davis
ndavis added a comment. In D16421#348609 , @ngraham wrote: > JFYI, I dug through `KIconLoader` today and couldn't find anything that explicitly or implicitly trims the bounds of loaded images that could account for the link emblem not having

D16431: Guard data source being deleted before processing dataoffer receive event

2018-10-25 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY A data source can disappear at any moment, it's plausible a client

D16421: Improve emblem contrast, legibility and consistency

2018-10-25 Thread Noah Davis
ndavis added a comment. In D16421#348594 , @ngraham wrote: > Now that I stare at the summary graphics again, the white question mark looks a bit wispy and insubstantial at the 16px and 22px sizes. Do you agree? Other than that, everything looks

D15826: [Balooshow] Avoid out-of-bounds access when accessing corrupt db data

2018-10-25 Thread Stefan Brüns
bruns updated this revision to Diff 44224. bruns added a comment. use KLocalizedString for deferred i18n substitution REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15826?vs=43176=44224 BRANCH oob2 REVISION DETAIL https://phabricator.kde.org/D15826

D16414: Changes to REXX syntax highlighting

2018-10-25 Thread Christoph Cullmann
cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. Hi, nice that you take care of fixing these issues. Two small things that could be improved: 1. the version="2" needs to be bumped to 3 2. there should be some unit

D16421: Improve emblem contrast, legibility and consistency

2018-10-25 Thread Stefan Brüns
bruns added a comment. In D16421#348609 , @ngraham wrote: > JFYI, I dug through `KIconLoader` today and couldn't find anything that explicitly or implicitly trims the bounds of loaded images that could account for the link emblem not having its

D16421: Improve emblem contrast, legibility and consistency

2018-10-25 Thread Nathaniel Graham
ngraham added a comment. JFYI, I dug through `KIconLoader` today and couldn't find anything that explicitly or implicitly trims the bounds of loaded images that could account for the link emblem not having its original bounds respected and results in it being drawn too high. Either I missed

D16421: Improve emblem contrast, legibility and consistency

2018-10-25 Thread Nathaniel Graham
ngraham added a comment. Now that I stare at the summary graphics again, the white question mark looks a bit wispy and insubstantial at the 16px and 22px sizes. Do you agree? Other than that, everything looks pretty much perfect to me. REPOSITORY R266 Breeze Icons REVISION DETAIL

D16236: [Extractor] Handle documents correctly where mimetype should not be indexed

2018-10-25 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes. Closed by commit R293:db4aac4b6317: [Extractor] Handle documents correctly where mimetype should not be indexed (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D16236: [Extractor] Handle documents correctly where mimetype should not be indexed

2018-10-25 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks, this seems to work well. INLINE COMMENTS > app.cpp:133 > +if (!m_config.shouldBeIndexed(url)) { > // FIXME: This should never be happening! > +

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

2018-10-25 Thread Emirald Mateli
emateli marked 2 inline comments as done. emateli added a comment. Something that might need a bit of input is `BatchRenameJob`. - This was added a while back so that Dolphin doesn't do a batch rename as a series of single file renames. - This job takes care of replacing the `#`

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

2018-10-25 Thread Emirald Mateli
emateli updated this revision to Diff 44218. emateli marked 3 inline comments as done. emateli added a comment. - Remove QtCore/ REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14631?vs=44217=44218 BRANCH batchrename2 REVISION DETAIL

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

2018-10-25 Thread Emirald Mateli
emateli updated this revision to Diff 44217. emateli added a comment. - fix indent - remove setlayout call - Add missing parent parameters - Remove unnecessary QtCore/ prefix REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14631?vs=44189=44217 BRANCH

D16255: [Scheduler] Fix wrong usage of obsolete QFileInfo::created() timestamp

2018-10-25 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes. Closed by commit R293:43ab022f35e8: [Scheduler] Fix wrong usage of obsolete QFileInfo::created() timestamp (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D16427: [solid-hardware5] List icon in device details

2018-10-25 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R245:9910ad1473f4: [solid-hardware5] List icon in device details (authored by broulik). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16427?vs=44214=44215 REVISION

D16427: [solid-hardware5] List icon in device details

2018-10-25 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D16427 To: broulik, #frameworks, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16427: [solid-hardware5] List icon in device details

2018-10-25 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. TEST PLAN udi = '/org/kde/solid/udev/sys/devices/pci:00/:00:01.1/:01:00.0/usb1/1-7'

D16255: [Scheduler] Fix wrong usage of obsolete QFileInfo::created() timestamp

2018-10-25 Thread Luca Beltrame
lbeltrame accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH indexer_cleanup REVISION DETAIL https://phabricator.kde.org/D16255 To: bruns, #baloo, #frameworks, poboiko, ngraham, lbeltrame Cc: lbeltrame, kde-frameworks-devel,

D16236: [Extractor] Handle documents correctly where mimetype should not be indexed

2018-10-25 Thread Stefan Brüns
bruns edited the test plan for this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D16236 To: bruns, #baloo, #frameworks Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D16255: [Scheduler] Fix wrong usage of obsolete QFileInfo::created() timestamp

2018-10-25 Thread Stefan Brüns
bruns added a comment. Good to go? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D16255 To: bruns, #baloo, #frameworks, poboiko, ngraham Cc: lbeltrame, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D16266: [Extractor] Make extractor crash resilient

2018-10-25 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes. Closed by commit R293:1509ca51c5ed: [Extractor] Make extractor crash resilient (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16266?vs=43777=44212 REVISION DETAIL

D16421: Improve emblem contrast, legibility and consistency

2018-10-25 Thread Noah Davis
ndavis updated this revision to Diff 44211. ndavis added a comment. Change style of emblem-symbolic-link at 22px REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16421?vs=44210=44211 BRANCH emblem-outlines (branched from master) REVISION DETAIL

D16266: [Extractor] Make extractor crash resilient

2018-10-25 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Yeah go ahead I think. REPOSITORY R293 Baloo BRANCH mimetype_handling REVISION DETAIL https://phabricator.kde.org/D16266 To: bruns, #baloo, #frameworks, poboiko, ngraham Cc:

D16421: Improve emblem contrast, legibility and consistency

2018-10-25 Thread Nathaniel Graham
ngraham added a comment. In D16421#348516 , @ndavis wrote: > F6350488: Screenshot_20181025_100526.png //Perfect!// REPOSITORY R266 Breeze Icons REVISION DETAIL

D16421: Improve emblem contrast, legibility and consistency

2018-10-25 Thread Noah Davis
ndavis added a comment. In D16421#348513 , @bruns wrote: > The center link looks slightly too heavy, but imho still better. Might be possible to shave off 1/2 pixel from the link top/bottom. As its a solid area, it should not make it too fuzzy.

D16421: Improve emblem contrast, legibility and consistency

2018-10-25 Thread Stefan Brüns
bruns added a comment. In D16421#348507 , @ndavis wrote: > In D16421#348504 , @bruns wrote: > > > In D16421#348502 , @ndavis wrote: > > > > > Also,

D16421: Improve emblem contrast, legibility and consistency

2018-10-25 Thread Nathaniel Graham
ngraham added a comment. In D16421#348507 , @ndavis wrote: > F6350381: Screenshot_20181025_095315.png Good! How about making the center link a tiny bit thinner? I'll look into the code in

D16421: Improve emblem contrast, legibility and consistency

2018-10-25 Thread Noah Davis
ndavis updated this revision to Diff 44210. ndavis added a comment. Change style of emblem-symbolic-link REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16421?vs=44201=44210 BRANCH emblem-outlines (branched from master) REVISION DETAIL

D16421: Improve emblem contrast, legibility and consistency

2018-10-25 Thread Noah Davis
ndavis added a comment. In D16421#348506 , @ngraham wrote: > In D16421#348502 , @ndavis wrote: > > > F6350185: Screenshot_20181025_093827.png > > F6350193:

D16421: Improve emblem contrast, legibility and consistency

2018-10-25 Thread Noah Davis
ndavis added a comment. In D16421#348504 , @bruns wrote: > In D16421#348502 , @ndavis wrote: > > > In D16421#348487 , @bruns wrote: > > > > > Can you

D16421: Improve emblem contrast, legibility and consistency

2018-10-25 Thread Nathaniel Graham
ngraham added a comment. In D16421#348502 , @ndavis wrote: > F6350185: Screenshot_20181025_093827.png > F6350193: Screenshot_20181025_093800.png +1,

D16421: Improve emblem contrast, legibility and consistency

2018-10-25 Thread Stefan Brüns
bruns added a comment. BTW, +1 for all the icons! REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16421 To: ndavis, #vdg Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

2018-10-25 Thread Noah Davis
ndavis added a comment. In D16421#348487 , @bruns wrote: > Can you try the following: > > - Make the center link solid and narower (e.g. 2px height for the 16px one) > - Reduce the height of the right and left links Like this?

D16166: Pass the FileIndexerConfig as const to the individual indexers

2018-10-25 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes. Closed by commit R293:b62e76f6f8c1: Pass the FileIndexerConfig as const to the individual indexers (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16166?vs=43508=44209

D16166: Pass the FileIndexerConfig as const to the individual indexers

2018-10-25 Thread Kai Uwe Broulik
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH indexer_cleanup REVISION DETAIL https://phabricator.kde.org/D16166 To: bruns, #baloo, #frameworks, poboiko, ngraham, dfaure, broulik Cc: kde-frameworks-devel, ashaposhnikov,

D16166: Pass the FileIndexerConfig as const to the individual indexers

2018-10-25 Thread Stefan Brüns
bruns added a comment. Can someone give this a go - as said, only code cleanup ... REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D16166 To: bruns, #baloo, #frameworks, poboiko, ngraham, dfaure Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun,

D16266: [Extractor] Make extractor crash resilient

2018-10-25 Thread Stefan Brüns
bruns marked an inline comment as done. bruns added a comment. How about accepting this as-is, and postponing any enhancements to another patch? This has three benefits: 1. no further delay 2. it is bisectable in case some bug appears 3. it is easy to spot how much code such a

D16421: Improve emblem contrast, legibility and consistency

2018-10-25 Thread Stefan Brüns
bruns added a comment. Can you try the following: - Make the center link solid and narower (e.g. 2px height for the 16px one) - Reduce the height of the right and left links REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16421 To: ndavis, #vdg Cc:

D14948: Port scriptabletags to QJSEngine

2018-10-25 Thread Allan Sandfeld Jensen
carewolf added a comment. See https://github.com/steveire/grantlee/pull/44 REVISION DETAIL https://phabricator.kde.org/D14948 To: carewolf, dhaumann, skelly Cc: vkrause, skelly, dhaumann, kde-frameworks-devel

D16412: Add the possibility to have a keyboard shortcut to create a file

2018-10-25 Thread Thomas Surrel
thsurrel marked 3 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16412 To: thsurrel, #frameworks Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D16412: Add the possibility to have a keyboard shortcut to create a file

2018-10-25 Thread Thomas Surrel
thsurrel updated this revision to Diff 44202. thsurrel added a comment. Fixes as per elvisangelaccio Thank you very much for the review! REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16412?vs=44178=44202 BRANCH newfileshortcut (branched from master)

D16421: Improve emblem contrast, legibility and consistency

2018-10-25 Thread Noah Davis
ndavis added a comment. Here are what the changes look like: 8px symlink emblem, 16px emblem-remove: F6349477: Screenshot_20181025_041309.png Pretty crowded. 16px symlink emblem, 16px emblem-remove: F6349480:

D16421: Improve emblem contrast, legibility and consistency

2018-10-25 Thread Noah Davis
ndavis updated this revision to Diff 44201. ndavis added a comment. Change emblem-remove color to Plasma Blue, Change style of emblem-symbolic-link REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16421?vs=44194=44201 BRANCH emblem-outlines

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.9 - Build # 45 - Still Unstable!

2018-10-25 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.9/45/ Project: kf5-qt5 SUSEQt5.9 Date of build: Thu, 25 Oct 2018 05:57:35 + Build duration: 28 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.10 - Build # 71 - Still Unstable!

2018-10-25 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.10/71/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 25 Oct 2018 05:57:35 + Build duration: 12 min and counting JUnit Tests Name: (root)