D15645: Add scheme selection menu with a "System" entry.

2018-10-26 Thread Amish Naidu
amhndu marked an inline comment as done. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D15645 To: amhndu, #frameworks, broulik, cfeck, elvisangelaccio, ngraham Cc: ngraham, broulik, kde-frameworks-devel, michaelh, bruns

D15645: Add scheme selection menu with a "System" entry.

2018-10-26 Thread Amish Naidu
amhndu updated this revision to Diff 44279. amhndu edited the summary of this revision. amhndu added a comment. Fixed error in colorschemedemo test. Sorry about that, I must've forgotton to commit it. REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE

D16416: z/OS CLIST file syntax highlighting

2018-10-26 Thread Phil Young
phily added a comment. Example CLIST can be viewed here: https://gist.githubusercontent.com/mainframed/9e9c85b7a13186e7ca51b5b47d90b575/raw/1e19fede7d203585b213d2f20700ed08baac9e07/protall.clist Looking at the code repo I wasn't sure exactly where to include the code examples.

D16416: z/OS CLIST file syntax highlighting

2018-10-26 Thread Phil Young
phily updated this revision to Diff 44278. phily marked 5 inline comments as done. phily added a comment. Fixing issues noted by reviewer REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16416?vs=44182=44278 REVISION DETAIL

D16415: Creating new syntax highlighting file for Job Control Language (JCL)

2018-10-26 Thread Phil Young
phily marked an inline comment as done. phily added a comment. Thank you for the feedback. I've gone and updated the syntax file to explain what JCL is and remove the `^` from the regex. Thank you for the suggestions. REPOSITORY R216 Syntax Highlighting REVISION DETAIL

D16415: Creating new syntax highlighting file for Job Control Language (JCL)

2018-10-26 Thread Phil Young
phily updated this revision to Diff 44277. phily marked an inline comment as done. phily added a comment. Making changes based on reviewer comments. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16415?vs=44181=44277 REVISION DETAIL

D16421: Improve emblem contrast, legibility and consistency

2018-10-26 Thread Noah Davis
ndavis added a comment. In D16421#349083 , @ngraham wrote: > In D16421#349082 , @ndavis wrote: > > > In D16421#349081 , @ngraham wrote: > > > > > This

D16421: Improve emblem contrast, legibility and consistency

2018-10-26 Thread Nathaniel Graham
ngraham added a comment. In D16421#349082 , @ndavis wrote: > In D16421#349081 , @ngraham wrote: > > > This would all require some additional changes in Dolphin and Folder view, of course. > >

D16421: Improve emblem contrast, legibility and consistency

2018-10-26 Thread Noah Davis
ndavis added a comment. In D16421#349081 , @ngraham wrote: > This would all require some additional changes in Dolphin and Folder view, of course. So should I change `emblem-added` and `emblem-remove` back to their original colors? It

D16421: Improve emblem contrast, legibility and consistency

2018-10-26 Thread Nathaniel Graham
ngraham added a comment. In D16421#349080 , @ndavis wrote: > Something just occurred to me: Why do we use emblems as if they were action buttons in Dolphin? Would it be so bad if Dolphin used `list-add` and `list-remove` instead of

D16421: Improve emblem contrast, legibility and consistency

2018-10-26 Thread Noah Davis
ndavis added a comment. Something just occurred to me: Why do we use emblems as if they were action buttons in Dolphin? Would it be so bad if Dolphin used `list-add` and `list-remove` instead of `emblem-added` and `emblem-remove`? REPOSITORY R266 Breeze Icons REVISION DETAIL

D16421: Improve emblem contrast, legibility and consistency

2018-10-26 Thread Nathaniel Graham
ngraham added a comment. In D16421#349075 , @bruns wrote: > There may also be a conceptual issue here - previously, the `emblem-locked` which is used for unaccessible (e.g. root owned) files was a lock with orange background, now it is green.

D16421: Improve emblem contrast, legibility and consistency

2018-10-26 Thread Noah Davis
ndavis added a comment. In D16421#349075 , @bruns wrote: > @ndavis - can you upload the `git format-patch -1` output somewhere (temporary)? https://hastebin.com/egepiwurab.diff > There may also be a conceptual issue here -

KDE CI: Frameworks » kiconthemes » kf5-qt5 WindowsMSVCQt5.11 - Build # 16 - Unstable!

2018-10-26 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kiconthemes/job/kf5-qt5%20WindowsMSVCQt5.11/16/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Fri, 26 Oct 2018 23:42:12 + Build duration: 13 min and counting JUnit Tests Name:

D16446: [KIconLoader] Replace heap-allocated QImageReader with stack-allocated one

2018-10-26 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes. Closed by commit R302:34994ba9890d: [KIconLoader] Replace heap-allocated QImageReader with stack-allocated one (authored by bruns). REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE

D16421: Improve emblem contrast, legibility and consistency

2018-10-26 Thread Stefan Brüns
bruns added a comment. In D16421#349072 , @ngraham wrote: > After manual application, the alignment is perfect for me too. So that's not a blocker; must be some local issye on your end, @ndavis. I think we're really close (or ready?) to being

D16446: [KIconLoader] Replace heap-allocated QImageReader with stack-allocated one

2018-10-26 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R302 KIconThemes BRANCH master REVISION DETAIL https://phabricator.kde.org/D16446 To: bruns, #frameworks, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16421: Improve emblem contrast, legibility and consistency

2018-10-26 Thread Nathaniel Graham
ngraham added a comment. After manual application, the alignment is perfect for me too. So that's not a blocker; must be some local issye on your end, @ndavis. I think we're really close (or ready?) to being able to land this! @bruns, are your comments about the question mark a blocker, or

D16446: [KIconLoader] Replace heap-allocated QImageReader with stack-allocated one

2018-10-26 Thread Stefan Brüns
bruns created this revision. bruns added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Minor optimization, saves one new/delete pair per non-cached icon. TEST PLAN make

D15645: Add scheme selection menu with a "System" entry.

2018-10-26 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Doesn't build for me: [ 51%] Building CXX object tests/CMakeFiles/kcodecactiontest.dir/kcodecactiontest.cpp.o

D16344: Do not try to fallback to "less secure" protocols

2018-10-26 Thread Andrius Štikonas
stikonas accepted this revision. stikonas added a comment. This revision is now accepted and ready to land. In D16344#349054 , @aacid wrote: > In D16344#348985 , @stikonas wrote: > > > Can you

D16344: Do not try to fallback to "less secure" protocols

2018-10-26 Thread Albert Astals Cid
aacid added a comment. In D16344#348985 , @stikonas wrote: > Can you confirm that it works with TLSv1.2 only sites? (e.g. https://stikonas.eu:5281/admin/). Ideally we should test with TLSv1.3 too. Yes, it works. And

D16344: Do not try to fallback to "less secure" protocols

2018-10-26 Thread Albert Astals Cid
aacid added a comment. In D16344#348886 , @jtamate wrote: > What protocol does KTcpSocket::SecureProtocols implement (I can't guess it)? If it is the same as QSsl:SecureProtocols Yes, see

D16421: Improve emblem contrast, legibility and consistency

2018-10-26 Thread Stefan Brüns
bruns added a comment. In D16421#348960 , @ngraham wrote: > I wish I could test but I have not gotten the patch to apply so far. Did `arc apply D16421` work for you, or did you have to apply it by hand? No, I just copied a few of the

D16265: [Scheduler] Use flag to track when a runner is going idle

2018-10-26 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes. bruns marked an inline comment as done. Closed by commit R293:b13453360685: [Scheduler] Use flag to track when a runner is going idle (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D16441: [KIconLoader] Correct documentation of emblem/overlay order

2018-10-26 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes. Closed by commit R302:030e65f06fed: [KIconLoader] Correct documentation of emblem/overlay order (authored by bruns). REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE

D16442: [KIconLoader] Adjust emblem border depending on icon size

2018-10-26 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes. Closed by commit R302:9a94fd6edf07: [KIconLoader] Adjust emblem border depending on icon size (authored by bruns). REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE

D16442: [KIconLoader] Adjust emblem border depending on icon size

2018-10-26 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Ah, so that's where those margins were coming from! Big thumbs-up. REPOSITORY R302 KIconThemes BRANCH master REVISION DETAIL https://phabricator.kde.org/D16442 To: bruns,

D16442: [KIconLoader] Adjust emblem border depending on icon size

2018-10-26 Thread Stefan Brüns
bruns edited the test plan for this revision. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D16442 To: bruns, #frameworks, #vdg, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16344: Do not try to fallback to "less secure" protocols

2018-10-26 Thread Andrius Štikonas
stikonas added a comment. Line 89 in https://api.kde.org/frameworks/kio/html/ktcpsocket_8cpp_source.html suggests that it is the same as QSsl:SecureProtocols. Can you confirm that it works with TLSv1.2 only sites? (e.g. https://stikonas.eu:5281/admin/). Ideally we should test with

D16442: [KIconLoader] Adjust emblem border depending on icon size

2018-10-26 Thread Stefan Brüns
bruns edited the test plan for this revision. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D16442 To: bruns, #frameworks, #vdg, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16441: [KIconLoader] Correct documentation of emblem/overlay order

2018-10-26 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Oops, sorry for missing this with 1c564d0b5eb4859dbcb6d6cbf9d840eca0ea2c56 ! REPOSITORY R302 KIconThemes

D16442: [KIconLoader] Adjust emblem border depending on icon size

2018-10-26 Thread Stefan Brüns
bruns created this revision. bruns added reviewers: Frameworks, VDG, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The current fixed margin of 2px on each side leads to overlapping

D16441: [KIconLoader] Correct documentation of emblem/overlay order

2018-10-26 Thread Stefan Brüns
bruns created this revision. bruns added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The order used in the implementation is BR, BL, TL, TR. REPOSITORY R302 KIconThemes

D16421: Improve emblem contrast, legibility and consistency

2018-10-26 Thread Nathaniel Graham
ngraham added a comment. In D16421#348959 , @bruns wrote: > Tried to reproduce it here, but for me the bottom-right emblem just renders fine here: > > F6363939: Unpatched_locked_link_48.png I

D16421: Improve emblem contrast, legibility and consistency

2018-10-26 Thread Stefan Brüns
bruns added a comment. In D16421#348609 , @ngraham wrote: > JFYI, I dug through `KIconLoader` today and couldn't find anything that explicitly or implicitly trims the bounds of loaded images that could account for the link emblem not having its

D15070: Bindings: Support using sys paths for python install directory

2018-10-26 Thread Stefan Brüns
bruns added a comment. If there are no further comments, I will push this on sunday. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D15070 To: bruns, #frameworks Cc: bcooksley, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D16344: Do not try to fallback to "less secure" protocols

2018-10-26 Thread Jaime Torres Amate
jtamate added a comment. What protocol does KTcpSocket::SecureProtocols implement (I can't guess it)? If it is the same as QSsl:SecureProtocols it does: On the client side, this will send a TLS 1.0 Client Hello, enabling TLSv1_0 and SSLv3 connections. On

D16344: Do not try to fallback to "less secure" protocols

2018-10-26 Thread Albert Astals Cid
aacid added a comment. I'll commit this next tuesday unless someone disagrees. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16344 To: aacid Cc: carewolf, dfaure, stikonas, kde-frameworks-devel, michaelh, ngraham, bruns

D16421: Improve emblem contrast, legibility and consistency

2018-10-26 Thread Noah Davis
ndavis added a comment. In D16421#348866 , @bruns wrote: > In D16421#348860 , @ndavis wrote: > > > The other issue with using a font based question mark is I also have to use that for the 8px icon

D16421: Improve emblem contrast, legibility and consistency

2018-10-26 Thread Stefan Brüns
bruns added a comment. In D16421#348860 , @ndavis wrote: > The other issue with using a font based question mark is I also have to use that for the 8px icon if I want consistency. There is nothing wrong with using the font outline as a

D16421: Improve emblem contrast, legibility and consistency

2018-10-26 Thread Noah Davis
ndavis added a comment. In D16421#348857 , @bruns wrote: > In D16421#348826 , @ndavis wrote: > > > I could, but then I'm running into this issue: T9898 > > >

D16421: Improve emblem contrast, legibility and consistency

2018-10-26 Thread Stefan Brüns
bruns added a comment. In D16421#348826 , @ndavis wrote: > I could, but then I'm running into this issue: T9898 > > I made that task when I was trying to come up with a more legible style for

D16421: Improve emblem contrast, legibility and consistency

2018-10-26 Thread Noah Davis
ndavis added a comment. Slight change to make the 16 and 22 px icons look more like the 8px icon: F6363210: Screenshot_20181026_072203.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16421 To: ndavis, #vdg Cc:

D16421: Improve emblem contrast, legibility and consistency

2018-10-26 Thread Noah Davis
ndavis updated this revision to Diff 44248. ndavis added a comment. Widen the circular portion of 16/22 px emblem-question icons REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16421?vs=44230=44248 BRANCH emblem-outlines (branched from master)

D16434: Fix keyboard layout change notifications

2018-10-26 Thread Fabian Vogt
fvogt updated this revision to Diff 44247. fvogt added a comment. Don't use a union. Still works. REPOSITORY R268 KGlobalAccel CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16434?vs=44241=44247 BRANCH master REVISION DETAIL https://phabricator.kde.org/D16434 AFFECTED

D16434: Fix keyboard layout change notifications

2018-10-26 Thread Fabian Vogt
fvogt marked 4 inline comments as done. REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D16434 To: fvogt, #frameworks, #plasma Cc: anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D16434: Fix keyboard layout change notifications

2018-10-26 Thread Fabian Vogt
fvogt added a comment. Note that the way it's done is ~~copied from~~ inspired by QXcbConnection. I don't like it either though, so I'll try getting rid of the union. REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D16434 To: fvogt, #frameworks, #plasma Cc:

D16434: Fix keyboard layout change notifications

2018-10-26 Thread Anthony Fieroni
anthonyfieroni added inline comments. INLINE COMMENTS > kglobalaccel_x11.cpp:198-208 > +typedef union { > + /* All XKB events share these fields. */ > + struct { > + uint8_t response_type; > + uint8_t xkbType; > + uint16_t sequence; > +

D16421: Improve emblem contrast, legibility and consistency

2018-10-26 Thread Noah Davis
ndavis added a comment. In D16421#348825 , @bruns wrote: > In D16421#348664 , @ndavis wrote: > > > In D16421#348594 , @ngraham wrote: > > > > > Now

D16421: Improve emblem contrast, legibility and consistency

2018-10-26 Thread Stefan Brüns
bruns added a comment. In D16421#348664 , @ndavis wrote: > In D16421#348594 , @ngraham wrote: > > > Now that I stare at the summary graphics again, the white question mark looks a bit wispy and

D16434: Fix keyboard layout change notifications

2018-10-26 Thread Fabian Vogt
fvogt created this revision. fvogt added reviewers: Frameworks, Plasma. Herald added a project: Frameworks. fvogt requested review of this revision. REVISION SUMMARY This rework fixes several issues: - Qt wasn't informed about XCB_MAPPING_NOTIFY anymore - With XKB enabled in Qt, X won't