KDE CI: Frameworks » kdoctools » kf5-qt5 WindowsMSVCQt5.11 - Build # 12 - Fixed!

2018-10-30 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kdoctools/job/kf5-qt5%20WindowsMSVCQt5.11/12/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 31 Oct 2018 03:50:31 + Build duration: 7 min 2 sec and counting JUnit Tests

KDE CI: Frameworks » kdoctools » kf5-qt5 SUSEQt5.9 - Build # 47 - Fixed!

2018-10-30 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kdoctools/job/kf5-qt5%20SUSEQt5.9/47/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 31 Oct 2018 03:50:31 + Build duration: 1 min 13 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kdoctools » kf5-qt5 SUSEQt5.10 - Build # 61 - Still Unstable!

2018-10-30 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdoctools/job/kf5-qt5%20SUSEQt5.10/61/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 31 Oct 2018 03:50:31 + Build duration: 1 min 6 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kdoctools » kf5-qt5 SUSEQt5.9 - Build # 46 - Unstable!

2018-10-30 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdoctools/job/kf5-qt5%20SUSEQt5.9/46/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 31 Oct 2018 03:39:36 + Build duration: 4 min 2 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kdoctools » kf5-qt5 WindowsMSVCQt5.11 - Build # 11 - Unstable!

2018-10-30 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdoctools/job/kf5-qt5%20WindowsMSVCQt5.11/11/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 31 Oct 2018 03:39:36 + Build duration: 2 min 9 sec and counting JUnit Tests

KDE CI: Frameworks » kdoctools » kf5-qt5 SUSEQt5.10 - Build # 60 - Still Unstable!

2018-10-30 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdoctools/job/kf5-qt5%20SUSEQt5.10/60/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 31 Oct 2018 03:39:36 + Build duration: 1 min 13 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.9 - Build # 132 - Failure!

2018-10-30 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.9/132/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 31 Oct 2018 00:39:34 + Build duration: 5 min 52 sec and counting CONSOLE OUTPUT [...truncated

D15826: [Balooshow] Avoid out-of-bounds access when accessing corrupt db data

2018-10-30 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes. Closed by commit R293:563dd3418b60: [Balooshow] Avoid out-of-bounds access when accessing corrupt db data (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D16344: Do not try to fallback to "less secure" protocols

2018-10-30 Thread Albert Astals Cid
This revision was automatically updated to reflect the committed changes. Closed by commit R241:e11d4d18f66a: Do not try to fallback to less secure protocols (authored by aacid). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D16344?vs=43997=44509#toc REPOSITORY R241 KIO CHANGES SINCE

D16529: make libssh module default to the "new" libssh config by default

2018-10-30 Thread Kai Uwe Broulik
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL https://phabricator.kde.org/D16529 To: sitter, broulik, asn Cc: kde-frameworks-devel, kfm-devel, alexde, sourabhboss, feverfew, michaelh, spoorun,

D16529: make libssh module default to the "new" libssh config by default

2018-10-30 Thread Harald Sitter
sitter created this revision. sitter added reviewers: broulik, asn. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY - rename module from LibSSH to libssh so casing is consistent

D16523: [Extractor] Replace homegrown IO handler with QDataStream, catch HUP

2018-10-30 Thread Stefan Brüns
bruns marked an inline comment as done. bruns added inline comments. INLINE COMMENTS > poboiko wrote in app.cpp:74 > I haven't work with `QDataStream` before, but shouldn't `m_inputStream >> > nIds` do the same? (and same below) > And probably you should avoid magical constants (4, 8, etc) -

D16471: [RFC] Listen for added DBus interfaces instead of registered services

2018-10-30 Thread Jan Grulich
jgrulich added a comment. > This is RFC because: > > I'm not sure whether it's guaranteed that InterfacesAdded is emitted on service registration as well or both connections are necessary I'm not sure about this either. I'll build it locally and try to use it for a while. > I

D16520: proper kwalletd dbus service file for the legacy name

2018-10-30 Thread Stefan Brüns
bruns added a comment. In D16520#350934 , @damjang wrote: > > but before doing this change the migration agent has to be changed. > > Can you expand on this what needs to be changed? I'd be happy to do it if it's in my capability

D16523: [Extractor] Replace homegrown IO handler with QDataStream, catch HUP

2018-10-30 Thread Stefan Brüns
bruns added a comment. In D16523#350888 , @poboiko wrote: > That's nice! I'll test it a little. This step keeps binary compatibility with the current streaming format. The big cleanup happens in the next commit (D16524

D15464: [server] Touch drag support

2018-10-30 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH touchDrag REVISION DETAIL https://phabricator.kde.org/D15464 To: romangg, #kwin, #frameworks, davidedmundson Cc: davidedmundson, kde-frameworks-devel, michaelh,

D16520: proper kwalletd dbus service file for the legacy name

2018-10-30 Thread Damjan Georgievski
damjang added a comment. > but before doing this change the migration agent has to be changed. Can you expand on this what needs to be changed? I'd be happy to do it if it's in my capability REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D16520 To: damjang,

D15826: [Balooshow] Avoid out-of-bounds access when accessing corrupt db data

2018-10-30 Thread Igor Poboiko
poboiko accepted this revision. poboiko added a comment. This revision is now accepted and ready to land. Yep, fine by me REPOSITORY R293 Baloo BRANCH oob2 REVISION DETAIL https://phabricator.kde.org/D15826 To: bruns, #baloo, #frameworks, poboiko Cc: anthonyfieroni,

D16416: z/OS CLIST file syntax highlighting

2018-10-30 Thread Christoph Cullmann
cullmann added a comment. Thanks for the needed info, will merge this. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D16416 To: phily, #framework_syntax_highlighting, dhaumann, cullmann Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel,

D16523: [Extractor] Replace homegrown IO handler with QDataStream, catch HUP

2018-10-30 Thread Igor Poboiko
poboiko added a comment. That's nice! I'll test it a little. INLINE COMMENTS > app.cpp:74 > + > +memcpy(, buf, 4); > +for (quint32 i = 0; i < nIds; i++) { I haven't work with `QDataStream` before, but shouldn't `m_inputStream >> nIds` do the same? (and same below) And probably you

D15960: Don't check if file is directory based on mime-type

2018-10-30 Thread Igor Poboiko
poboiko edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15960 To: poboiko, #baloo, #frameworks, bruns Cc: bruns, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, abrahams

D16524: [Extractor] Use QDataStream serialization in place of cooked one

2018-10-30 Thread Luca Beltrame
lbeltrame accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH extractor REVISION DETAIL https://phabricator.kde.org/D16524 To: bruns, #baloo, #frameworks, ngraham, poboiko, lbeltrame Cc: kde-frameworks-devel, ashaposhnikov, michaelh,

D16523: [Extractor] Replace homegrown IO handler with QDataStream, catch HUP

2018-10-30 Thread Luca Beltrame
lbeltrame added a comment. In general (for my limited Baloo knowledge) this makes sense. You might want to add a few CCBUGs if you are aware of specific bugs this alleviates (@ngraham or someone from the bugsquad may help). REPOSITORY R293 Baloo REVISION DETAIL