D16579: Musepack disk number field name is DISC.

2018-10-31 Thread James Smith
smithjd added a comment. Useful tag mapping information: https://wiki.hydrogenaud.io/index.php?title=Tag_Mapping REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16579 To: smithjd Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich,

D16579: Musepack disk number field name is DISC.

2018-10-31 Thread James Smith
smithjd created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. smithjd requested review of this revision. REVISION SUMMARY Fix the Musepack disk field. REPOSITORY R286 KFileMetaData BRANCH master-musepackFixes (branched from

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB)

2018-10-31 Thread Shubham
shubham added a comment. Can I get a review? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, elvisangelaccio, #frameworks Cc: cfeck, bruns, kde-frameworks-devel, michaelh, ngraham

D16395: Update the "About KDE" text

2018-10-31 Thread Nathaniel Graham
ngraham edited the test plan for this revision. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D16395 To: ngraham, #vdg, #plasma, #frameworks, #kde_applications, #kde_promo Cc: valorie, davidc, xyquadrat, rizzitello, ltoscano, aspotashev, abetts, kde-frameworks-devel,

D16395: Update the "About KDE" text

2018-10-31 Thread Nathaniel Graham
ngraham updated this revision to Diff 44605. ngraham added a comment. Incorporate more feedback from review comments (thanks @davidc and @valorie!) REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16395?vs=44564=44605 BRANCH update-about-kde-text

D16554: move supported mimetypes to static string list

2018-10-31 Thread Stefan Brüns
bruns added inline comments. INLINE COMMENTS > epubextractor.cpp:38 > +const QStringList EPubExtractor::mMimetypes = > { > +QStringLiteral("application/epub+zip"), Opening braces should go on the same line for everything but functions ... > epubextractor.cpp:48 > namespace > { >

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.9 - Build # 133 - Fixed!

2018-10-31 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.9/133/ Project: kf5-qt5 SUSEQt5.9 Date of build: Thu, 01 Nov 2018 01:34:49 + Build duration: 11 min and counting JUnit Tests Name: (root) Failed: 0

D16488: [KFileMetaData] Add helper for XML encoded Dublin Core metadata

2018-10-31 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes. Closed by commit R286:1b242697d27d: [KFileMetaData] Add helper for XML encoded Dublin Core metadata (authored by bruns). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D16490: [KFileMetaData] Add unittest for XML extractor

2018-10-31 Thread Stefan Brüns
bruns marked an inline comment as done. bruns added a comment. In D16490#351662 , @astippich wrote: > Only one minor thing: please also check that the mimetype is in the list of supported mimetypes This can actually happen and is

D16563: Remove unused variables

2018-10-31 Thread Stefan Brüns
bruns requested changes to this revision. bruns added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > transaction.cpp:519 > out << "\tFileNameTermsDB: "; > for (const QByteArray& term : terms) { > out << term << " ";

D16575: Remove unused variables

2018-10-31 Thread Albert Astals Cid
aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D16575 AFFECTED FILES

D16574: Remove unused variable

2018-10-31 Thread Albert Astals Cid
aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REPOSITORY R282 NetworkManagerQt BRANCH master REVISION DETAIL https://phabricator.kde.org/D16574 AFFECTED FILES

D16573: Remove unused variables

2018-10-31 Thread Albert Astals Cid
aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL https://phabricator.kde.org/D16573 AFFECTED FILES

D16488: [KFileMetaData] Add helper for XML encoded Dublin Core metadata

2018-10-31 Thread Alexander Stippich
astippich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH xml_extractor REVISION DETAIL https://phabricator.kde.org/D16488 To: bruns, #frameworks, astippich Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich,

D16572: don't assign variable to itself

2018-10-31 Thread Albert Astals Cid
aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REPOSITORY R278 KWindowSystem BRANCH master REVISION DETAIL https://phabricator.kde.org/D16572 AFFECTED FILES

D16571: Remove unused variable

2018-10-31 Thread Albert Astals Cid
aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REPOSITORY R311 KWallet BRANCH master REVISION DETAIL https://phabricator.kde.org/D16571 AFFECTED FILES

D16570: Remove unused variables

2018-10-31 Thread Albert Astals Cid
aacid created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. aacid requested review of this revision. REVISION SUMMARY commentLineMark is commented since the code that uses it is also commented a bit below REPOSITORY

D16569: Remove unused variable

2018-10-31 Thread Albert Astals Cid
aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL https://phabricator.kde.org/D16569 AFFECTED FILES src/core/engine.cpp To:

D16568: Remove unused variables

2018-10-31 Thread Albert Astals Cid
aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D16568 AFFECTED FILES src/core/job_error.cpp

D16567: Remove unused variable

2018-10-31 Thread Albert Astals Cid
aacid created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. aacid requested review of this revision. REPOSITORY R286 KFileMetaData BRANCH master REVISION DETAIL https://phabricator.kde.org/D16567 AFFECTED FILES

D16565: Remove unused variable

2018-10-31 Thread Albert Astals Cid
aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D16565 AFFECTED FILES

D16560: create a separate test file for embedded images test

2018-10-31 Thread Alexander Stippich
astippich added a dependent revision: D16564: cleanup the test for embedded image extraction. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16560 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

D16564: cleanup the test for embedded image extraction

2018-10-31 Thread Alexander Stippich
astippich added a dependency: D16560: create a separate test file for embedded images test. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16564 To: astippich, #frameworks, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun,

D16563: Remove unused variables

2018-10-31 Thread Nathaniel Graham
ngraham added reviewers: Baloo, bruns. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D16563 To: aacid, #baloo, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D16564: cleanup the test for embedded image extraction

2018-10-31 Thread Alexander Stippich
astippich created this revision. astippich added reviewers: Frameworks, bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY cleanup the test by converting to a data-driven one

D16563: Remove unused variables

2018-10-31 Thread Albert Astals Cid
aacid created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY As far as i can see the declaration of the variables and calling get "does nothing", so we can remove them

D16562: Reuse resultMap instead of converting to map two times more

2018-10-31 Thread Albert Astals Cid
aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REPOSITORY R495 Purpose Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D16562 AFFECTED FILES

D16561: Remove unused variable

2018-10-31 Thread Albert Astals Cid
aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REPOSITORY R495 Purpose Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D16561 AFFECTED FILES

D15829: make units and prefixes of formatValue translatable

2018-10-31 Thread Alexander Stippich
astippich added a comment. ping REPOSITORY R244 KCoreAddons BRANCH translate_units REVISION DETAIL https://phabricator.kde.org/D15829 To: astippich, bruns, safaalfulaij Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16486: implement support for reading ID3 tags from aiff and wav files

2018-10-31 Thread Alexander Stippich
This revision was automatically updated to reflect the committed changes. Closed by commit R286:19f0237fdc98: implement support for reading ID3 tags from aiff and wav files (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D16560: create a separate test file for embedded images test

2018-10-31 Thread Alexander Stippich
astippich created this revision. astippich added a reviewer: bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY if the test.jpg file is altered, e.g. additional metadata is

D16490: [KFileMetaData] Add unittest for XML extractor

2018-10-31 Thread Alexander Stippich
astippich added a comment. Only one minor thing: please also check that the mimetype is in the list of supported mimetypes REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16490 To: bruns, #frameworks, astippich Cc: lbeltrame, kde-frameworks-devel, #baloo,

D16489: [KFileMetaData] Add extractor for generic XML and SVG

2018-10-31 Thread Alexander Stippich
astippich added inline comments. INLINE COMMENTS > xmlextractor.cpp:24 > + > +#include > +#include seems unused > xmlextractor.cpp:27 > +#include > +#include > + same > xmlextractor.cpp:71 > + > +return list; > +} Can we agree on using a static qstringlist if the mimetypes are

D16520: proper kwalletd dbus service file for the legacy name

2018-10-31 Thread Stefan Brüns
bruns added a subscriber: FreeBSD. REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D16520 To: damjang, #frameworks, cfeck Cc: #freebsd, bruns, apol, kde-frameworks-devel, michaelh, ngraham

D16488: [KFileMetaData] Add helper for XML encoded Dublin Core metadata

2018-10-31 Thread Stefan Brüns
bruns added a comment. In D16488#351584 , @astippich wrote: > I guess you plan to convert the existing extractors to use this? Yes, thats the plan > The only concern I might have that now two iterations over the node are required

D16554: move supported mimetypes to static string list

2018-10-31 Thread Alexander Stippich
astippich created this revision. astippich added a reviewer: bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Do not create the list of supported mime types on demand and use a

D16488: [KFileMetaData] Add helper for XML encoded Dublin Core metadata

2018-10-31 Thread Alexander Stippich
astippich added a comment. I guess you plan to convert the existing extractors to use this? The only concern I might have that now two iterations over the node are required when this is used in e.g. odfextractor, isn't it? Btw, I don't think it's necessary to prepend KFileMetaData in the

D16395: Update the "About KDE" text

2018-10-31 Thread Valorie Zimmerman
valorie added a comment. My only suggestion: KDE creates the efficient, powerful Plasma desktop environment, hundreds of high-quality applications and the many software libraries that support them. Past tense makes the present version seem static. REPOSITORY R263 KXmlGui REVISION

D16395: Update the "About KDE" text

2018-10-31 Thread David C
davidc added a comment. Thanks for the update, and for tightening some of the language. The only nag I have is with the last sentence in the first paragraph. Seeing Plasma described as "friendly" seems a bit like fluff and is an awkward choice of words for a user interface. I know you

D16395: Update the "About KDE" text

2018-10-31 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D16395 To: ngraham, #vdg, #plasma, #frameworks, #kde_applications, #kde_promo Cc: xyquadrat, rizzitello, ltoscano, aspotashev, abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D16520: proper kwalletd dbus service file for the legacy name

2018-10-31 Thread Damjan Georgievski
damjang added a comment. is it ok if the waiting on the legacy kwallet4 is made synchronous? wiring all those signals will make my head explode :) wait 5 sec, otherwise give up on the migration? REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D16520 To:

D16395: Update the "About KDE" text

2018-10-31 Thread Nathaniel Graham
ngraham added a comment. Thanks! Regardless, I'll only land this after the Frameworks string freeze is lifted (i.e. once 5.52 is tagged). REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D16395 To: ngraham, #vdg, #plasma, #frameworks, #kde_applications, #kde_promo

D16395: Update the "About KDE" text

2018-10-31 Thread Isadora D.
skadinna accepted this revision as: KDE Promo. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D16395 To: ngraham, #vdg, #plasma, #frameworks, #kde_applications, #kde_promo Cc: xyquadrat, rizzitello, ltoscano, aspotashev, abetts, kde-frameworks-devel, michaelh,

D16395: Update the "About KDE" text

2018-10-31 Thread Nathaniel Graham
ngraham edited the test plan for this revision. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D16395 To: ngraham, #vdg, #plasma, #frameworks, #kde_applications, #kde_promo Cc: xyquadrat, rizzitello, ltoscano, aspotashev, abetts, kde-frameworks-devel, michaelh,

D16395: Update the "About KDE" text

2018-10-31 Thread Nathaniel Graham
ngraham updated this revision to Diff 44564. ngraham added a comment. Use https URLs REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16395?vs=44563=44564 BRANCH update-about-kde-text (branched from master) REVISION DETAIL

D16395: Update the "About KDE" text

2018-10-31 Thread Nathaniel Graham
ngraham updated this revision to Diff 44563. ngraham added a comment. Promo team tweaks REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16395?vs=44562=44563 BRANCH update-about-kde-text (branched from master) REVISION DETAIL

D16395: Update the "About KDE" text

2018-10-31 Thread Nathaniel Graham
ngraham edited the test plan for this revision. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D16395 To: ngraham, #vdg, #plasma, #frameworks, #kde_applications, #kde_promo Cc: xyquadrat, rizzitello, ltoscano, aspotashev, abetts, kde-frameworks-devel, michaelh,

D16395: Update the "About KDE" text

2018-10-31 Thread Nathaniel Graham
ngraham updated this revision to Diff 44562. ngraham added a comment. Consistently capitalize "Free Software" REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16395?vs=44192=44562 BRANCH update-about-kde-text (branched from master) REVISION DETAIL

D16395: Update the "About KDE" text

2018-10-31 Thread Nathaniel Graham
ngraham edited the test plan for this revision. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D16395 To: ngraham, #vdg, #plasma, #frameworks, #kde_applications, #kde_promo Cc: xyquadrat, rizzitello, ltoscano, aspotashev, abetts, kde-frameworks-devel, michaelh,

D16137: Add an option to KConfigDialog to fit page contents horizontally

2018-10-31 Thread Tim __
kadabash added a comment. While adapting the settings window in Cantor to this proposed change I have discovered that it influences the `sizeHint()` of other (non-modified) pages in the same window. This leads to a worse layout than before. As I cannot currently find the source of that

D16529: make libssh module default to the "new" libssh config by default

2018-10-31 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R320:0e129b10ae30: make libssh module default to the new libssh config by default (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE

D16305: Add a QIconEnginePlugin to allow QIcon deserialization

2018-10-31 Thread Luca Beltrame
lbeltrame added a comment. +1. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D16305 To: fvogt, #frameworks Cc: lbeltrame, kde-frameworks-devel, michaelh, ngraham, bruns