Re: KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.9 - Build # 69 - Still Failing!

2018-11-02 Thread Ben Cooksley
Hi Marco & Plasma Folks, Can someone please look into this? This seems to be the usual class of QTest compilation failures due to changes in how it handles casts between 5.9 / 5.10. Cheers, Ben On Sat, Nov 3, 2018 at 5:06 PM CI System wrote: > *BUILD FAILURE* > Build URL >

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.9 - Build # 69 - Still Failing!

2018-11-02 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.9/69/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sat, 03 Nov 2018 04:05:12 + Build duration: 1 min 20 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks » kconfig » kf5-qt5 AndroidQt5.11 - Build # 33 - Fixed!

2018-11-02 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kconfig/job/kf5-qt5%20AndroidQt5.11/33/ Project: kf5-qt5 AndroidQt5.11 Date of build: Sat, 03 Nov 2018 04:05:05 + Build duration: 52 sec and counting

KDE CI: Frameworks » kjobwidgets » kf5-qt5 AndroidQt5.11 - Build # 22 - Fixed!

2018-11-02 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kjobwidgets/job/kf5-qt5%20AndroidQt5.11/22/ Project: kf5-qt5 AndroidQt5.11 Date of build: Sat, 03 Nov 2018 04:05:05 + Build duration: 51 sec and counting

[sysadmin/ci-tooling] /: Disable parts of the System Dependency building on Android CI until rsync can be made available.

2018-11-02 Thread Ben Cooksley
Git commit a01c4d1ba8fd31f1112c207b61542b14aab3e9e8 by Ben Cooksley. Committed on 03/11/2018 at 03:48. Pushed by bcooksley into branch 'master'. Disable parts of the System Dependency building on Android CI until rsync can be made available. The Docker image for Android CI currently can't be

Regression in Frameworks - DBus Hangs

2018-11-02 Thread Ben Cooksley
Hi all, Following commits made to Frameworks somewhere in the October 21 to October 28 time frame, the unit tests of Konsole on the CI system have started to hang following completion. This hang is occurring due to a behaviour of CTest, where it will wait (indefinitely) following the conclusion

KDE CI: Frameworks » kconfig » kf5-qt5 AndroidQt5.11 - Build # 32 - Still Failing!

2018-11-02 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kconfig/job/kf5-qt5%20AndroidQt5.11/32/ Project: kf5-qt5 AndroidQt5.11 Date of build: Sat, 03 Nov 2018 03:38:00 + Build duration: 33 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks » kjobwidgets » kf5-qt5 AndroidQt5.11 - Build # 21 - Still Failing!

2018-11-02 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kjobwidgets/job/kf5-qt5%20AndroidQt5.11/21/ Project: kf5-qt5 AndroidQt5.11 Date of build: Sat, 03 Nov 2018 03:37:55 + Build duration: 40 sec and counting CONSOLE OUTPUT

D16523: [Extractor] Replace homegrown IO handler with QDataStream, catch HUP

2018-11-02 Thread Stefan Brüns
bruns marked an inline comment as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D16523 To: bruns, #baloo, #frameworks, ngraham, poboiko Cc: lbeltrame, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D16591: [XmlExtractor] Use QXmlStreamReader for better performance

2018-11-02 Thread Stefan Brüns
bruns marked 2 inline comments as done. bruns added inline comments. INLINE COMMENTS > apol wrote in xmlextractortest.cpp:70 > Won't this break any use? Previously, the last element was "foo_bar__", now it is "foo_bar_". SimpleExtractionResult::append(text) adds a space after the inserted text

[sysadmin/ci-tooling] pipeline-templates: Ensure that Groovy passes the shell script through to the shell interpreter for evaluation.

2018-11-02 Thread Ben Cooksley
Git commit 88415288d6803f28f413a67233185ed9698ceeb9 by Ben Cooksley. Committed on 03/11/2018 at 03:14. Pushed by bcooksley into branch 'master'. Ensure that Groovy passes the shell script through to the shell interpreter for evaluation. CCMAIL: kde-frameworks-devel@kde.org M +5-5

D16465: [KSambaShare] Make "net usershare info" parser testable

2018-11-02 Thread Stefan Brüns
bruns added a comment. In D16465#353081 , @apol wrote: > I'm confused, you didn't add a test? See stack REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16465 To: bruns, #frameworks, broulik Cc: apol,

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 65 - Still Unstable!

2018-11-02 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/65/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sat, 03 Nov 2018 01:57:53 + Build duration: 4 min 41 sec and counting JUnit Tests Name: (root)

D16588: Change package manager icons to emblems

2018-11-02 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R266:c52a911f9035: Change package manager icons to emblems (authored by ndavis, committed by ngraham). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D16588?vs=44736=44749#toc REPOSITORY R266

KDE CI: Frameworks » kjobwidgets » kf5-qt5 AndroidQt5.11 - Build # 20 - Failure!

2018-11-02 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kjobwidgets/job/kf5-qt5%20AndroidQt5.11/20/ Project: kf5-qt5 AndroidQt5.11 Date of build: Sat, 03 Nov 2018 01:57:18 + Build duration: 36 sec and counting CONSOLE OUTPUT

D16588: Change package manager icons to emblems

2018-11-02 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Much better, thanks! REPOSITORY R266 Breeze Icons BRANCH package-manager-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D16588 To: ndavis, #vdg, ngraham

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 249 - Still Unstable!

2018-11-02 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/249/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 03 Nov 2018 00:35:03 + Build duration: 16 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.9 - Build # 175 - Still Unstable!

2018-11-02 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.9/175/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sat, 03 Nov 2018 00:35:03 + Build duration: 2 min 29 sec and counting JUnit Tests Name:

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.10 - Build # 125 - Fixed!

2018-11-02 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.10/125/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 03 Nov 2018 00:34:38 + Build duration: 1 min 32 sec and counting JUnit Tests Name: (root)

D16562: Reuse resultMap instead of converting to map two times more

2018-11-02 Thread Albert Astals Cid
aacid closed this revision. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D16562 To: aacid, apol Cc: kde-frameworks-devel, apol, michaelh, ngraham, bruns

D16575: Remove unused variables

2018-11-02 Thread Albert Astals Cid
aacid closed this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D16575 To: aacid, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16620: add const to TypeInfo compare operater

2018-11-02 Thread Aleix Pol Gonzalez
apol added inline comments. INLINE COMMENTS > astippich wrote in typeinfo.h:41 > Yeah, forgot about that :/ You can't change but you can add new ones. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16620 To: astippich, #frameworks, bruns Cc: apol, broulik,

D16591: [XmlExtractor] Use QXmlStreamReader for better performance

2018-11-02 Thread Aleix Pol Gonzalez
apol added a comment. Patch looks good overall +1 INLINE COMMENTS > bruns wrote in xmlextractortest.cpp:70 > QDomElement::text() leaves a final trailing whitespace which is not trimmed. Won't this break any use? REPOSITORY R286 KFileMetaData REVISION DETAIL

D16583: use qlatin1 for embedded image extractor

2018-11-02 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH embedded_image_latin1 REVISION DETAIL https://phabricator.kde.org/D16583 To: astippich, mgallien, bruns, apol Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh,

D16619: add missing license information

2018-11-02 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH license REVISION DETAIL https://phabricator.kde.org/D16619 To: astippich, #frameworks, bruns, apol Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich,

D16465: [KSambaShare] Make "net usershare info" parser testable

2018-11-02 Thread Aleix Pol Gonzalez
apol added a comment. I'm confused, you didn't add a test? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16465 To: bruns, #frameworks, broulik Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D16575: Remove unused variables

2018-11-02 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D16575 To: aacid, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16562: Reuse resultMap instead of converting to map two times more

2018-11-02 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R495 Purpose Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D16562 To: aacid, apol Cc: kde-frameworks-devel, apol, michaelh, ngraham, bruns

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

2018-11-02 Thread Emirald Mateli
emateli added a comment. Also, thoughts on my previous comments regarding `BatchRenameJob`? INLINE COMMENTS > mlaurent wrote in batchrenamedialog.h:69 > it's a good idea to initialize to nullptr each pointer here. > So we can see problem easily. You mean to initialize them to nullptr on the

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

2018-11-02 Thread Emirald Mateli
emateli updated this revision to Diff 44737. emateli marked 4 inline comments as done. emateli added a comment. - coding style fix REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14631?vs=44218=44737 BRANCH batchrename2 REVISION DETAIL

D16588: Change package manager icons to emblems

2018-11-02 Thread Noah Davis
ndavis updated this revision to Diff 44736. ndavis added a comment. Removed broken symlink. It was already copied to the emblems/16 directory, but I forgot to remove the old copy. REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16588?vs=44713=44736

D16618: add explicit to constructors

2018-11-02 Thread Matthieu Gallien
mgallien accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH explicit REVISION DETAIL https://phabricator.kde.org/D16618 To: astippich, #frameworks, bruns, mgallien Cc: mgallien, kde-frameworks-devel, #baloo, ashaposhnikov,

D16588: Change package manager icons to emblems

2018-11-02 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. This fails the symlink test: $ (arcpatch-D16588) make test Running tests... Test project /home/dev/repos/breeze-icons Start 1: appstreamtest 1/5 Test

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.10 - Build # 124 - Unstable!

2018-11-02 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.10/124/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 02 Nov 2018 21:41:32 + Build duration: 28 min and counting JUnit Tests Name: (root) Failed: 1

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.9 - Build # 36 - Still Unstable!

2018-11-02 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.9/36/ Project: kf5-qt5 SUSEQt5.9 Date of build: Fri, 02 Nov 2018 21:39:39 + Build duration: 12 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.10 - Build # 48 - Still Unstable!

2018-11-02 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.10/48/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 02 Nov 2018 21:39:39 + Build duration: 3 min 48 sec and counting JUnit Tests Name:

D16561: Remove unused variable

2018-11-02 Thread Albert Astals Cid
aacid closed this revision. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D16561 To: aacid, svuorela Cc: kde-frameworks-devel, apol, michaelh, ngraham, bruns

D16567: Remove unused variable

2018-11-02 Thread Albert Astals Cid
aacid closed this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16567 To: aacid, svuorela Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D16568: Remove unused variables

2018-11-02 Thread Albert Astals Cid
aacid closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16568 To: aacid, svuorela Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16569: Remove unused variable

2018-11-02 Thread Albert Astals Cid
aacid closed this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D16569 To: aacid, svuorela Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16571: Remove unused variable

2018-11-02 Thread Albert Astals Cid
aacid closed this revision. REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D16571 To: aacid, svuorela Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16572: don't assign variable to itself

2018-11-02 Thread Albert Astals Cid
This revision was automatically updated to reflect the committed changes. Closed by commit R278:09b4523248ab: dont assign variable to itself (authored by aacid). REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16572?vs=44595=44735 REVISION DETAIL

D16573: Remove unused variables

2018-11-02 Thread Albert Astals Cid
This revision was automatically updated to reflect the committed changes. Closed by commit R263:4a7c3dbdaf25: Remove unused variables (authored by aacid). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16573?vs=44596=44734 REVISION DETAIL

KDE CI: Frameworks » kconfig » kf5-qt5 AndroidQt5.11 - Build # 31 - Failure!

2018-11-02 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kconfig/job/kf5-qt5%20AndroidQt5.11/31/ Project: kf5-qt5 AndroidQt5.11 Date of build: Fri, 02 Nov 2018 21:38:16 + Build duration: 30 sec and counting CONSOLE OUTPUT [...truncated

D16574: Remove unused variable

2018-11-02 Thread Albert Astals Cid
aacid closed this revision. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D16574 To: aacid, svuorela Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16565: Remove unused variable

2018-11-02 Thread Albert Astals Cid
This revision was automatically updated to reflect the committed changes. Closed by commit R237:d5c5113e8ea1: Remove unused variable (authored by aacid). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16565?vs=44588=44733 REVISION DETAIL

D16593: [ExtractorCollection] Use only best matching extractor plugin

2018-11-02 Thread Alexander Stippich
astippich accepted this revision. astippich added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > bruns wrote in extractorcollection.cpp:163 > http://doc.qt.io/qt-5/qdebug.html#setAutoInsertSpaces is true by default. I meant the code, not the output :) >

D16618: add explicit to constructors

2018-11-02 Thread Alexander Stippich
astippich updated this revision to Diff 44731. astippich added a comment. - don't change exported classes REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16618?vs=44724=44731 BRANCH explicit REVISION DETAIL https://phabricator.kde.org/D16618

D16593: [ExtractorCollection] Use only best matching extractor plugin

2018-11-02 Thread Stefan Brüns
bruns edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16593 To: bruns, #frameworks, astippich Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D16593: [ExtractorCollection] Use only best matching extractor plugin

2018-11-02 Thread Stefan Brüns
bruns marked 2 inline comments as done. bruns added inline comments. INLINE COMMENTS > astippich wrote in extractorcollection.cpp:163 > nitpick: extra space before "for" http://doc.qt.io/qt-5/qdebug.html#setAutoInsertSpaces is true by default. > astippich wrote in extractorcollection.cpp:164 >

D16618: add explicit to constructors

2018-11-02 Thread Alexander Stippich
astippich planned changes to this revision. astippich added inline comments. INLINE COMMENTS > mgallien wrote in simpleextractionresult.h:42 > Given this class is exported, is this binary compatible ? I've been not really thinking about it while I was looking at the EBN stuff and pushed too

D16620: add const to TypeInfo compare operater

2018-11-02 Thread Alexander Stippich
astippich abandoned this revision. astippich added inline comments. INLINE COMMENTS > broulik wrote in typeinfo.h:41 > This method is exported so you cannot change cv qualifiers Yeah, forgot about that :/ REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16620

D16591: [XmlExtractor] Use QXmlStreamReader for better performance

2018-11-02 Thread Stefan Brüns
bruns marked an inline comment as done. bruns added inline comments. INLINE COMMENTS > astippich wrote in xmlextractortest.cpp:70 > why is there a difference? QDomElement::text() leaves a final trailing whitespace which is not trimmed. REPOSITORY R286 KFileMetaData REVISION DETAIL

D16618: add explicit to constructors

2018-11-02 Thread Matthieu Gallien
mgallien added inline comments. INLINE COMMENTS > simpleextractionresult.h:42 > public: > -SimpleExtractionResult(const QString& url, const QString& mimetype = > QString(), const Flags& flags = ExtractEverything); > +explicit SimpleExtractionResult(const QString& url, const QString& >

D16620: add const to TypeInfo compare operater

2018-11-02 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > typeinfo.h:41 > TypeInfo& operator=(const TypeInfo& rhs); > -bool operator==(const TypeInfo& rhs); > +bool operator==(const TypeInfo& rhs) const; > This method is exported so you cannot change cv qualifiers REPOSITORY R286

D16620: add const to TypeInfo compare operater

2018-11-02 Thread Alexander Stippich
astippich created this revision. astippich added reviewers: Frameworks, bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY as suggested by EBN REPOSITORY R286 KFileMetaData

D16619: add missing license information

2018-11-02 Thread Alexander Stippich
astippich added a comment. I actually don't know what the correct procedure here is regarding copyright. I added the copyright for Varun Joshi who is the first author according to git log. I added myself to the taglibwriter files as where I've added quite a lot of code recently. REPOSITORY

D16619: add missing license information

2018-11-02 Thread Alexander Stippich
astippich created this revision. astippich added reviewers: Frameworks, bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY add missing license information as suggested by EBN

D16618: add explicit to constructors

2018-11-02 Thread Alexander Stippich
astippich created this revision. astippich added reviewers: Frameworks, bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY add explicit to constructors as suggested by EBN

D16617: fix extraction of GPS altitude for exif data

2018-11-02 Thread Alexander Stippich
astippich edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16617 To: astippich, #frameworks, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D16560: create a separate test file for embedded images test

2018-11-02 Thread Alexander Stippich
astippich added a dependent revision: D16617: fix extraction of GPS altitude for exif data. REPOSITORY R286 KFileMetaData BRANCH cover_jpg REVISION DETAIL https://phabricator.kde.org/D16560 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich,

D16617: fix extraction of GPS altitude for exif data

2018-11-02 Thread Alexander Stippich
astippich added a dependency: D16560: create a separate test file for embedded images test. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16617 To: astippich, #frameworks, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun,

D16617: fix extraction of GPS altitude for exif data

2018-11-02 Thread Alexander Stippich
astippich created this revision. astippich added reviewers: Frameworks, bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY The previous code was wrong, since the altitude is

D16591: [XmlExtractor] Use QXmlStreamReader for better performance

2018-11-02 Thread Alexander Stippich
astippich added inline comments. INLINE COMMENTS > xmlextractortest.cpp:70 > QCOMPARE(result.text().leftRef(8), content.leftRef(8)); > -QCOMPARE(result.text().size(), 1 + 8 * count); > +QCOMPARE(result.text().size(), 8 * count); > why is there a difference? REPOSITORY R286

D16593: [ExtractorCollection] Use only best matching extractor plugin

2018-11-02 Thread Alexander Stippich
astippich added inline comments. INLINE COMMENTS > extractorcollection.cpp:163 > +if (!plugins.isEmpty()) { > +qCDebug(KFILEMETADATA_LOG) << "Using inherited mimetype" << > ancestor << "for" << mimetype; > +return plugins; nitpick: extra space before "for" >

D16579: Fix APE tag extraction

2018-11-02 Thread Alexander Stippich
astippich requested changes to this revision. astippich added a comment. You're doing the exact opposite of what we're asking for. Look, I'd love to merge the bug fix for the DISC property. But we need compatibility. I'll give you another reason: KFileMetaData has basically required that

D16583: use qlatin1 for embedded image extractor

2018-11-02 Thread Alexander Stippich
astippich edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16583 To: astippich, mgallien, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D16583: use qlatin1 for embedded image extractor

2018-11-02 Thread Alexander Stippich
astippich updated this revision to Diff 44718. astippich added a comment. - coding style REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16583?vs=44619=44718 BRANCH embedded_image_latin1 REVISION DETAIL https://phabricator.kde.org/D16583

D16583: use qlatin1 for embedded image extractor

2018-11-02 Thread Alexander Stippich
astippich marked an inline comment as done. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16583 To: astippich, mgallien, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D16592: [ExtractorCollection] Add unit-test to verify only specific extractor is used

2018-11-02 Thread Alexander Stippich
astippich accepted this revision. astippich added a comment. This revision is now accepted and ready to land. Thanks :) REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16592 To: bruns, #frameworks, astippich Cc: kde-frameworks-devel, #baloo, ashaposhnikov,

D16588: Change package manager icons to emblems

2018-11-02 Thread Noah Davis
ndavis added a comment. In D16588#352847 , @valorie wrote: > Could not Muon be updated in this way as well? It now uses a package icon for all packages which seems a waste of space. Perhaps, and that would be great, but that would have

D16588: Change package manager icons to emblems

2018-11-02 Thread Valorie Zimmerman
valorie added a comment. Could not Muon be updated in this way as well? It now uses a package icon for all packages which seems a waste of space. REPOSITORY R266 Breeze Icons BRANCH package-manager-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D16588 To:

D16434: Fix keyboard layout change notifications

2018-11-02 Thread Fabian Vogt
fvogt updated this revision to Diff 44715. fvogt added a comment. Use if-else ladder instead of switch-case and fix a typo. REPOSITORY R268 KGlobalAccel CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16434?vs=44714=44715 BRANCH master REVISION DETAIL

D16434: Fix keyboard layout change notifications

2018-11-02 Thread Fabian Vogt
fvogt marked 2 inline comments as done. fvogt added inline comments. INLINE COMMENTS > romangg wrote in kglobalaccel_x11.cpp:96 > Before there was a check to `QX11Info::isPlatformX11()`. Probably we don't > need the check, but did you test on Wayland? The plugin is only loaded if the Qt

D16434: Fix keyboard layout change notifications

2018-11-02 Thread Fabian Vogt
fvogt updated this revision to Diff 44714. fvogt marked an inline comment as done. fvogt added a comment. Add Q_ASSERT and xcb_key_symbols_free. REPOSITORY R268 KGlobalAccel CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16434?vs=44247=44714 BRANCH master REVISION DETAIL

Downtime announcement: www.kde.org

2018-11-02 Thread Ben Cooksley
Hi all, In order to allow for hardware maintenance, one of our physical hardware hosts will need to be shutdown for a few hours on Monday. This downtime will commence around 9:30am UTC and may take several hours. During this time a number of sites will be inaccessible, including: - www.kde.org -

D16588: Change package manager icons to emblems

2018-11-02 Thread Noah Davis
ndavis updated this revision to Diff 44713. ndavis added a comment. Changed installed.svg symlink to target package-installed-updated.svg The original target was package-reinstall.svg I believe it was the way it was because: The original version of package-reinstall looked more

D16588: Change package manager icons to emblems

2018-11-02 Thread Stefan Brüns
bruns added a comment. +1! REPOSITORY R266 Breeze Icons BRANCH package-manager-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D16588 To: ndavis, #vdg, ngraham Cc: bruns, ngraham, #vdg, kde-frameworks-devel, michaelh

D16588: Change package manager icons to emblems

2018-11-02 Thread Nathaniel Graham
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH package-manager-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D16588 To: ndavis, #vdg, ngraham Cc: ngraham, #vdg, kde-frameworks-devel,

D16579: Fix APE tag extraction

2018-11-02 Thread Stefan Brüns
bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. Stop breaking code! REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16579 To: smithjd, astippich, bruns, mgallien Cc: bruns, astippich,

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)

2018-11-02 Thread Shubham
shubham updated this revision to Diff 44712. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16249?vs=44710=44712 REVISION DETAIL https://phabricator.kde.org/D16249 AFFECTED FILES src/core/copyjob.cpp src/core/global.h src/core/job_error.cpp To: shubham,

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)

2018-11-02 Thread Nathaniel Graham
ngraham added a comment. Uh-oh, I think the latest update to this diff isn't quite correct. I see unrelated changes that you didn't make being marked as additions. You might try using `arc` in the future. It makes this process much simpler. See

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)

2018-11-02 Thread Shubham
shubham retitled this revision from "Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB) " to "Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB) ". REPOSITORY R241 KIO

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB)

2018-11-02 Thread Shubham
shubham updated this revision to Diff 44710. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16249?vs=44688=44710 REVISION DETAIL https://phabricator.kde.org/D16249 AFFECTED FILES src/core/copyjob.cpp src/core/global.h src/core/job_error.cpp To: shubham,

D16579: Fix APE tag extraction

2018-11-02 Thread James Smith
smithjd added a comment. In D16579#352788 , @smithjd wrote: > - Use the de-facto Album Artist field name for APE tags. > > Since the discussion around this patch has also included the Album Artist field, add the changes required for this

D16579: Fix APE tag extraction

2018-11-02 Thread James Smith
smithjd retitled this revision from "Musepack disk number field name is DISC." to "Fix APE tag extraction". smithjd edited the summary of this revision. smithjd edited the test plan for this revision. smithjd added a reviewer: mgallien. REPOSITORY R286 KFileMetaData REVISION DETAIL

D16579: Musepack disk number field name is DISC.

2018-11-02 Thread James Smith
smithjd updated this revision to Diff 44708. smithjd added a comment. - Use the de-facto Album Artist field name for APE tags. Since the discussion around this patch has also included the Album Artist field, add the changes required for this field to this review. REPOSITORY R286

D16612: Connect slots explicitly instead of using auto-connections

2018-11-02 Thread Alexander Volkov
volkov added a reviewer: Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16612 To: volkov, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16612: Connect slots explicitly instead of using auto-connections

2018-11-02 Thread Alexander Volkov
volkov created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. volkov requested review of this revision. REVISION SUMMARY Auto-connections is bad practice cause object renames break code and it can't be detected at compile time. REPOSITORY

D16434: Fix keyboard layout change notifications

2018-11-02 Thread Roman Gilg
romangg requested changes to this revision. romangg added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kglobalaccel_x11.cpp:96 > if (!m_keySymbols) { > -return false; > +m_keySymbols = xcb_key_symbols_alloc(QX11Info::connection()); > +

D16305: Add a QIconEnginePlugin to allow QIcon deserialization

2018-11-02 Thread Fabian Vogt
This revision was automatically updated to reflect the committed changes. Closed by commit R302:3501660aa3d7: Add a QIconEnginePlugin to allow QIcon deserialization (authored by fvogt). REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16305?vs=43893=44698

D16305: Add a QIconEnginePlugin to allow QIcon deserialization

2018-11-02 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R302 KIconThemes BRANCH master REVISION DETAIL https://phabricator.kde.org/D16305 To: fvogt, #frameworks, davidedmundson Cc: lbeltrame, kde-frameworks-devel, michaelh, ngraham, bruns

D16588: Change package manager icons to emblems

2018-11-02 Thread Noah Davis
ndavis added a comment. In D16588#352554 , @ngraham wrote: > These are pretty darn good. They no longer have package-related iconography, but maybe that's okay and they never needed it in the first place. I can see how it would actually get in

D16561: Remove unused variable

2018-11-02 Thread Sune Vuorela
svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R495 Purpose Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D16561 To: aacid, svuorela Cc: kde-frameworks-devel, apol, michaelh, ngraham, bruns

D16567: Remove unused variable

2018-11-02 Thread Sune Vuorela
svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH master REVISION DETAIL https://phabricator.kde.org/D16567 To: aacid, svuorela Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

D16569: Remove unused variable

2018-11-02 Thread Sune Vuorela
svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL https://phabricator.kde.org/D16569 To: aacid, svuorela Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16568: Remove unused variables

2018-11-02 Thread Sune Vuorela
svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D16568 To: aacid, svuorela Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16571: Remove unused variable

2018-11-02 Thread Sune Vuorela
svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R311 KWallet BRANCH master REVISION DETAIL https://phabricator.kde.org/D16571 To: aacid, svuorela Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16572: don't assign variable to itself

2018-11-02 Thread Sune Vuorela
svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R278 KWindowSystem BRANCH master REVISION DETAIL https://phabricator.kde.org/D16572 To: aacid, svuorela Cc: kde-frameworks-devel, mart, michaelh, ngraham, bruns

D16573: Remove unused variables

2018-11-02 Thread Sune Vuorela
svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL https://phabricator.kde.org/D16573 To: aacid, svuorela Cc: kde-frameworks-devel, michaelh, ngraham, bruns

  1   2   >